[jira] [Commented] (HIVE-4847) add rename database functionality
[ https://issues.apache.org/jira/browse/HIVE-4847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221969#comment-16221969 ] Pierre Beauvois commented on HIVE-4847: --- No correction planned for this ticket? We're still facing the issue on Hive 2.1... > add rename database functionality > - > > Key: HIVE-4847 > URL: https://issues.apache.org/jira/browse/HIVE-4847 > Project: Hive > Issue Type: New Feature >Affects Versions: 0.11.0 >Reporter: Greg Rahn >Assignee: Teddy Choi >Priority: Minor > Attachments: HIVE-4847.1.patch.txt, HIVE-4847.2.patch.txt > > > There seems to be no way to rename a database in Hive, functionality to do so > would be nice. > Proposed syntax: > ALTER DATABASE dbname RENAME TO newdbname; -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-4847) add rename database functionality
[ https://issues.apache.org/jira/browse/HIVE-4847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15182989#comment-15182989 ] Viktor Gerdin commented on HIVE-4847: - This would be a great addition. Is there anything blocking it? > add rename database functionality > - > > Key: HIVE-4847 > URL: https://issues.apache.org/jira/browse/HIVE-4847 > Project: Hive > Issue Type: New Feature >Affects Versions: 0.11.0 >Reporter: Greg Rahn >Assignee: Teddy Choi >Priority: Minor > Attachments: HIVE-4847.1.patch.txt, HIVE-4847.2.patch.txt > > > There seems to be no way to rename a database in Hive, functionality to do so > would be nice. > Proposed syntax: > ALTER DATABASE dbname RENAME TO newdbname; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-4847) add rename database functionality
[
https://issues.apache.org/jira/browse/HIVE-4847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185003#comment-15185003
]
Hive QA commented on HIVE-4847:
---
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12597394/HIVE-4847.2.patch.txt
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/7193/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/7193/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-7193/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hive-ptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ [[ -n /usr/java/jdk1.7.0_45-cloudera ]]
+ export JAVA_HOME=/usr/java/jdk1.7.0_45-cloudera
+ JAVA_HOME=/usr/java/jdk1.7.0_45-cloudera
+ export
PATH=/usr/java/jdk1.7.0_45-cloudera/bin/:/usr/local/apache-maven-3.0.5/bin:/usr/java/jdk1.7.0_45-cloudera/bin:/usr/local/apache-ant-1.9.1/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/hiveptest/bin
+
PATH=/usr/java/jdk1.7.0_45-cloudera/bin/:/usr/local/apache-maven-3.0.5/bin:/usr/java/jdk1.7.0_45-cloudera/bin:/usr/local/apache-ant-1.9.1/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/hiveptest/bin
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'M2_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost
-Dhttp.proxyPort=3128'
+ M2_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost
-Dhttp.proxyPort=3128'
+ cd /data/hive-ptest/working/
+ tee /data/hive-ptest/logs/PreCommit-HIVE-TRUNK-Build-7193/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 7c4599b HIVE-13083: Writing HiveDecimal to ORC can wrongly
suppress present stream (Prasanth Jayachandran reviewed by Gopal V)
+ git clean -f -d
Removing common/src/java/org/apache/hadoop/hive/conf/HiveConf.java.orig
+ git checkout master
Already on 'master'
+ git reset --hard origin/master
HEAD is now at 7c4599b HIVE-13083: Writing HiveDecimal to ORC can wrongly
suppress present stream (Prasanth Jayachandran reviewed by Gopal V)
+ git merge --ff-only origin/master
Already up-to-date.
+ git gc
+ patchCommandPath=/data/hive-ptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hive-ptest/working/scratch/build.patch
+ [[ -f /data/hive-ptest/working/scratch/build.patch ]]
+ chmod +x /data/hive-ptest/working/scratch/smart-apply-patch.sh
+ /data/hive-ptest/working/scratch/smart-apply-patch.sh
/data/hive-ptest/working/scratch/build.patch
The patch does not appear to apply with p0, p1, or p2
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12597394 - PreCommit-HIVE-TRUNK-Build
> add rename database functionality
> -
>
> Key: HIVE-4847
> URL: https://issues.apache.org/jira/browse/HIVE-4847
> Project: Hive
> Issue Type: New Feature
>Affects Versions: 0.11.0
>Reporter: Greg Rahn
>Assignee: Teddy Choi
>Priority: Minor
> Attachments: HIVE-4847.1.patch.txt, HIVE-4847.2.patch.txt
>
>
> There seems to be no way to rename a database in Hive, functionality to do so
> would be nice.
> Proposed syntax:
> ALTER DATABASE dbname RENAME TO newdbname;
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-4847) add rename database functionality
[ https://issues.apache.org/jira/browse/HIVE-4847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185267#comment-15185267 ] Sushanth Sowmyan commented on HIVE-4847: I do not know of any committer's plan to incorporate this or to explicitly block it - I think this falls in a narrow niche of a feature that would be useful to have, but can prove to be pretty disruptive in terms of the effects it has on a wider ecosystem tooling. At the very least, I think that this patch should not go in as-is without some sort of gating mechanism wherein, by some conf parameter, this feature can be disabled. I can give one example of a place where I am concerned about this feature, for eg - I know that external systems like Falcon, that implement replication between one hive warehouse to another depend on a db name being a primary key, and having that change behind the scene can be destructive to them. In addition, in the HiveMetaStore, we have event logs that do treat the db name as a primary key to provide this functionality to Falcon/etc, and this patch does nothing to change those event log contents. And I stress to add, nor should it modify event logs directly, since that would violate the expectation a third party tool has. One way to do this in a seamless manner would be to introduce another notion of a DBKEY (not DB_ID, since that can be different for each hive warehouse) which will remain unique for a db and not change when a db is renamed. Once that's done, all hive components that use DBNAME as the identifying basis would need to be rewritten to work against the DBKEY, and then, renaming DBNAME might be allowed. This will be a huge change. Another example I wonder about is with things like ACID transactions - we have a log of tables needing compaction - I wonder if this change will affect them too. +cc [~alangates]/[~ekoifman]. > add rename database functionality > - > > Key: HIVE-4847 > URL: https://issues.apache.org/jira/browse/HIVE-4847 > Project: Hive > Issue Type: New Feature >Affects Versions: 0.11.0 >Reporter: Greg Rahn >Assignee: Teddy Choi >Priority: Minor > Attachments: HIVE-4847.1.patch.txt, HIVE-4847.2.patch.txt > > > There seems to be no way to rename a database in Hive, functionality to do so > would be nice. > Proposed syntax: > ALTER DATABASE dbname RENAME TO newdbname; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-4847) add rename database functionality
[ https://issues.apache.org/jira/browse/HIVE-4847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185403#comment-15185403 ] Alan Gates commented on HIVE-4847: -- I agree that there are parts of the system that this can wreak havoc with, such as replication and ACID. But it seems all of the same arguments apply to renaming a table, which Hive supports. Rather than saying we won't apply the patch because of this we should say we won't apply the patch until it addresses these areas. Beyond just ACID and replication the HBase metastore (in 2.0 only) will also be impacted by this, since it uses the db name as the key for storing databases, tables, and partitions. > add rename database functionality > - > > Key: HIVE-4847 > URL: https://issues.apache.org/jira/browse/HIVE-4847 > Project: Hive > Issue Type: New Feature >Affects Versions: 0.11.0 >Reporter: Greg Rahn >Assignee: Teddy Choi >Priority: Minor > Attachments: HIVE-4847.1.patch.txt, HIVE-4847.2.patch.txt > > > There seems to be no way to rename a database in Hive, functionality to do so > would be nice. > Proposed syntax: > ALTER DATABASE dbname RENAME TO newdbname; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-4847) add rename database functionality
[ https://issues.apache.org/jira/browse/HIVE-4847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186224#comment-15186224 ] Teddy Choi commented on HIVE-4847: -- I agree that this feature may cause unexpected errors due to recent innovations, mostly in metadata. I'll update its status. > add rename database functionality > - > > Key: HIVE-4847 > URL: https://issues.apache.org/jira/browse/HIVE-4847 > Project: Hive > Issue Type: New Feature >Affects Versions: 0.11.0 >Reporter: Greg Rahn >Assignee: Teddy Choi >Priority: Minor > Attachments: HIVE-4847.1.patch.txt, HIVE-4847.2.patch.txt > > > There seems to be no way to rename a database in Hive, functionality to do so > would be nice. > Proposed syntax: > ALTER DATABASE dbname RENAME TO newdbname; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
