[jira] [Commented] (HIVE-8446) Failing to delete data after dropping a table or database should result in error
[ https://issues.apache.org/jira/browse/HIVE-8446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622870#comment-16622870 ] Bharathkrishna Guruvayoor Murali commented on HIVE-8446: Yes, that is the case. But if the data was not deleted, it would be good to at least let the user know that failure occurred. > Failing to delete data after dropping a table or database should result in > error > > > Key: HIVE-8446 > URL: https://issues.apache.org/jira/browse/HIVE-8446 > Project: Hive > Issue Type: Bug >Reporter: Brock Noland >Assignee: Bharathkrishna Guruvayoor Murali >Priority: Major > Attachments: HIVE-8446.1.patch > > > Currently if we drop a table and it fails to delete the data, the command > completes successfully. We should instead return an error to the user. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-8446) Failing to delete data after dropping a table or database should result in error
[ https://issues.apache.org/jira/browse/HIVE-8446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622476#comment-16622476 ] Alexander Kolbasov commented on HIVE-8446: -- Why would tests attempt to delete /tmp directory? This seems like a test issue. But for this issue in general. Suppose that user deletes table T and it is successfully deleted in HMS but data deletion fails. Suppose that we return an error to a user. Now we are still in a weird state - table T is no longer visible in HMS but it still has data. Whether we return an error to a user or not things are in a bad state. > Failing to delete data after dropping a table or database should result in > error > > > Key: HIVE-8446 > URL: https://issues.apache.org/jira/browse/HIVE-8446 > Project: Hive > Issue Type: Bug >Reporter: Brock Noland >Assignee: Bharathkrishna Guruvayoor Murali >Priority: Major > Attachments: HIVE-8446.1.patch > > > Currently if we drop a table and it fails to delete the data, the command > completes successfully. We should instead return an error to the user. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-8446) Failing to delete data after dropping a table or database should result in error
[ https://issues.apache.org/jira/browse/HIVE-8446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622363#comment-16622363 ] Bharathkrishna Guruvayoor Murali commented on HIVE-8446: I can see that many tests are failing due to the exception. I think in the tests, many times it gives fileNotFoundExceptions and unable to delete /tmp directory. Should this be a default behavior or should this come under a config? Any thoughts [~pvary] [~akolb] > Failing to delete data after dropping a table or database should result in > error > > > Key: HIVE-8446 > URL: https://issues.apache.org/jira/browse/HIVE-8446 > Project: Hive > Issue Type: Bug >Reporter: Brock Noland >Assignee: Bharathkrishna Guruvayoor Murali >Priority: Major > Attachments: HIVE-8446.1.patch > > > Currently if we drop a table and it fails to delete the data, the command > completes successfully. We should instead return an error to the user. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-8446) Failing to delete data after dropping a table or database should result in error
[
https://issues.apache.org/jira/browse/HIVE-8446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620658#comment-16620658
]
Hive QA commented on HIVE-8446:
---
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12940365/HIVE-8446.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 32 failed/errored test(s), 14979 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_change_db_location]
(batchId=8)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[archive_excludeHadoop20]
(batchId=70)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[dbtxnmgr_ddl1]
(batchId=86)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[dynamic_partition_skip_default]
(batchId=86)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[archive1]
(batchId=98)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[archive_insert1]
(batchId=97)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[archive_insert2]
(batchId=98)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[archive_insert3]
(batchId=98)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[archive_insert4]
(batchId=97)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[archive_multi1]
(batchId=99)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[archive_multi3]
(batchId=97)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[archive_multi4]
(batchId=97)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[archive_multi5]
(batchId=98)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[archive_multi6]
(batchId=97)
org.apache.hadoop.hive.llap.security.TestLlapSignerImpl.testSigning
(batchId=324)
org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testDumpAcidTableWithTableDirMissing
(batchId=243)
org.apache.hadoop.hive.ql.txn.compactor.TestCleanerWithReplication.cleanupAfterMajorPartitionCompaction
(batchId=241)
org.apache.hadoop.hive.ql.txn.compactor.TestCleanerWithReplication.cleanupAfterMajorTableCompaction
(batchId=241)
org.apache.hadoop.hive.ql.txn.compactor.TestCleanerWithReplication.cleanupAfterMinorPartitionCompaction
(batchId=241)
org.apache.hadoop.hive.ql.txn.compactor.TestCleanerWithReplication.cleanupAfterMinorTableCompaction
(batchId=241)
org.apache.hive.hcatalog.listener.TestDbNotificationListener.cleanupNotificationWithError
(batchId=258)
org.apache.hive.hcatalog.listener.TestDbNotificationListener.cleanupNotifs
(batchId=258)
org.apache.hive.hcatalog.listener.TestDbNotificationListener.dropDatabase
(batchId=258)
org.apache.hive.hcatalog.listener.TestDbNotificationListener.dropTable
(batchId=258)
org.apache.hive.hcatalog.listener.TestDbNotificationListener.filter
(batchId=258)
org.apache.hive.hcatalog.listener.TestDbNotificationListener.filterWithMax
(batchId=258)
org.apache.hive.jdbc.TestJdbcWithMiniLlapArrow.testDataTypes (batchId=251)
org.apache.hive.jdbc.TestJdbcWithMiniLlapArrow.testLlapInputFormatEndToEnd
(batchId=251)
org.apache.hive.jdbc.TestJdbcWithMiniLlapArrow.testNonAsciiStrings (batchId=251)
org.apache.hive.jdbc.TestJdbcWithMiniLlapVectorArrow.testLlapInputFormatEndToEnd
(batchId=251)
org.apache.hive.jdbc.TestTriggersNoTezSessionPool.testTriggerDAGTotalTasks
(batchId=249)
org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerHighBytesWrite
(batchId=251)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/13907/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13907/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13907/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 32 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12940365 - PreCommit-HIVE-Build
> Failing to delete data after dropping a table or database should result in
> error
>
>
> Key: HIVE-8446
> URL: https://issues.apache.org/jira/browse/HIVE-8446
> Project: Hive
> Issue Type: Bug
>Reporter: Brock Noland
>Assignee: Bharathkrishna Guruvayoor Murali
>Priority: Major
> Attachments: HIVE-8446.1.patch
>
>
> Currently if we drop a table and it fails to delete the data, the command
> completes successfully. We should instead return an error to the user.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-8446) Failing to delete data after dropping a table or database should result in error
[
https://issues.apache.org/jira/browse/HIVE-8446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620563#comment-16620563
]
Hive QA commented on HIVE-8446:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
8s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
14s{color} | {color:red} metastore-server in master failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
13s{color} | {color:red} metastore-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 11m 57s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-13907/dev-support/hive-personality.sh
|
| git revision | master / 9c90776 |
| Default Java | 1.8.0_111 |
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13907/yetus/branch-findbugs-standalone-metastore_metastore-server.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13907/yetus/patch-findbugs-standalone-metastore_metastore-server.txt
|
| modules | C: standalone-metastore/metastore-server U:
standalone-metastore/metastore-server |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13907/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Failing to delete data after dropping a table or database should result in
> error
>
>
> Key: HIVE-8446
> URL: https://issues.apache.org/jira/browse/HIVE-8446
> Project: Hive
> Issue Type: Bug
>Reporter: Brock Noland
>Assignee: Bharathkrishna Guruvayoor Murali
>Priority: Major
> Attachments: HIVE-8446.1.patch
>
>
> Currently if we drop a table and it fails to delete the data, the command
> completes successfully. We should instead return an error to the user.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-8446) Failing to delete data after dropping a table or database should result in error
[ https://issues.apache.org/jira/browse/HIVE-8446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613743#comment-16613743 ] Bharathkrishna Guruvayoor Murali commented on HIVE-8446: Hi, I am interested in working on this issue. Please let me know if I can assign it to myself. > Failing to delete data after dropping a table or database should result in > error > > > Key: HIVE-8446 > URL: https://issues.apache.org/jira/browse/HIVE-8446 > Project: Hive > Issue Type: Bug >Reporter: Brock Noland >Priority: Major > > Currently if we drop a table and it fails to delete the data, the command > completes successfully. We should instead return an error to the user. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
