[jira] [Commented] (HIVE-9711) ORC Vectorization DoubleColumnVector.isRepeating=false if all entries are NaN

2015-04-22 Thread Prasanth Jayachandran (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-9711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14508084#comment-14508084
 ] 

Prasanth Jayachandran commented on HIVE-9711:
-

Committed patch to master. Thanks [~gopalv] for the patch!

 ORC Vectorization DoubleColumnVector.isRepeating=false if all entries are NaN
 -

 Key: HIVE-9711
 URL: https://issues.apache.org/jira/browse/HIVE-9711
 Project: Hive
  Issue Type: Bug
  Components: File Formats, Vectorization
Affects Versions: 1.2.0
Reporter: Gopal V
Assignee: Gopal V
 Fix For: 1.2.0

 Attachments: HIVE-9711.1.patch, HIVE-9711.2.patch, HIVE-9711.3.patch


 The isRepeating=true check uses Java equality, which results in NaN != NaN 
 comparison operations.
 The noNulls case needs the current check folded into the previous loop, while 
 the hasNulls case needs a logical AND of the isNull[] field instead of == 
 comparisons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-9711) ORC Vectorization DoubleColumnVector.isRepeating=false if all entries are NaN

2015-04-21 Thread Prasanth Jayachandran (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-9711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14506224#comment-14506224
 ] 

Prasanth Jayachandran commented on HIVE-9711:
-

SVN is currently read-only. Will commit this patch once we migrate to git.

 ORC Vectorization DoubleColumnVector.isRepeating=false if all entries are NaN
 -

 Key: HIVE-9711
 URL: https://issues.apache.org/jira/browse/HIVE-9711
 Project: Hive
  Issue Type: Bug
  Components: File Formats, Vectorization
Affects Versions: 1.2.0
Reporter: Gopal V
Assignee: Gopal V
 Fix For: 1.2.0

 Attachments: HIVE-9711.1.patch, HIVE-9711.2.patch, HIVE-9711.3.patch


 The isRepeating=true check uses Java equality, which results in NaN != NaN 
 comparison operations.
 The noNulls case needs the current check folded into the previous loop, while 
 the hasNulls case needs a logical AND of the isNull[] field instead of == 
 comparisons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-9711) ORC Vectorization DoubleColumnVector.isRepeating=false if all entries are NaN

2015-04-20 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-9711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503505#comment-14503505
 ] 

Hive QA commented on HIVE-9711:
---



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12726587/HIVE-9711.3.patch

{color:red}ERROR:{color} -1 due to 15 failed/errored test(s), 8727 tests 
executed
*Failed tests:*
{noformat}
TestMinimrCliDriver-bucketmapjoin6.q-constprog_partitioner.q-infer_bucket_sort_dyn_part.q-and-1-more
 - did not produce a TEST-*.xml file
TestMinimrCliDriver-external_table_with_space_in_location_path.q-infer_bucket_sort_merge.q-auto_sortmerge_join_16.q-and-1-more
 - did not produce a TEST-*.xml file
TestMinimrCliDriver-groupby2.q-import_exported_table.q-bucketizedhiveinputformat.q-and-1-more
 - did not produce a TEST-*.xml file
TestMinimrCliDriver-index_bitmap3.q-stats_counter_partitioned.q-temp_table_external.q-and-1-more
 - did not produce a TEST-*.xml file
TestMinimrCliDriver-infer_bucket_sort_map_operators.q-join1.q-bucketmapjoin7.q-and-1-more
 - did not produce a TEST-*.xml file
TestMinimrCliDriver-infer_bucket_sort_num_buckets.q-disable_merge_for_bucketing.q-uber_reduce.q-and-1-more
 - did not produce a TEST-*.xml file
TestMinimrCliDriver-infer_bucket_sort_reducers_power_two.q-scriptfile1.q-scriptfile1_win.q-and-1-more
 - did not produce a TEST-*.xml file
TestMinimrCliDriver-leftsemijoin_mr.q-load_hdfs_file_with_space_in_the_name.q-root_dir_external_table.q-and-1-more
 - did not produce a TEST-*.xml file
TestMinimrCliDriver-list_bucket_dml_10.q-bucket_num_reducers.q-bucket6.q-and-1-more
 - did not produce a TEST-*.xml file
TestMinimrCliDriver-load_fs2.q-file_with_header_footer.q-ql_rewrite_gbtoidx_cbo_1.q-and-1-more
 - did not produce a TEST-*.xml file
TestMinimrCliDriver-parallel_orderby.q-reduce_deduplicate.q-ql_rewrite_gbtoidx_cbo_2.q-and-1-more
 - did not produce a TEST-*.xml file
TestMinimrCliDriver-ql_rewrite_gbtoidx.q-smb_mapjoin_8.q - did not produce a 
TEST-*.xml file
TestMinimrCliDriver-schemeAuthority2.q-bucket4.q-input16_cc.q-and-1-more - did 
not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_decimal_precision2
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union_view
{noformat}

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3501/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3501/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-3501/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 15 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12726587 - PreCommit-HIVE-TRUNK-Build

 ORC Vectorization DoubleColumnVector.isRepeating=false if all entries are NaN
 -

 Key: HIVE-9711
 URL: https://issues.apache.org/jira/browse/HIVE-9711
 Project: Hive
  Issue Type: Bug
  Components: File Formats, Vectorization
Affects Versions: 1.2.0
Reporter: Gopal V
Assignee: Gopal V
 Fix For: 1.2.0

 Attachments: HIVE-9711.1.patch, HIVE-9711.2.patch, HIVE-9711.3.patch


 The isRepeating=true check uses Java equality, which results in NaN != NaN 
 comparison operations.
 The noNulls case needs the current check folded into the previous loop, while 
 the hasNulls case needs a logical AND of the isNull[] field instead of == 
 comparisons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-9711) ORC Vectorization DoubleColumnVector.isRepeating=false if all entries are NaN

2015-04-04 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-9711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14396061#comment-14396061
 ] 

Hive QA commented on HIVE-9711:
---



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12709405/HIVE-9711.2.patch

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 8700 tests executed
*Failed tests:*
{noformat}
TestMinimrCliDriver-smb_mapjoin_8.q - did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udaf_percentile_approx_23
{noformat}

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3289/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3289/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-3289/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12709405 - PreCommit-HIVE-TRUNK-Build

 ORC Vectorization DoubleColumnVector.isRepeating=false if all entries are NaN
 -

 Key: HIVE-9711
 URL: https://issues.apache.org/jira/browse/HIVE-9711
 Project: Hive
  Issue Type: Bug
  Components: File Formats, Vectorization
Affects Versions: 1.2.0
Reporter: Gopal V
Assignee: Gopal V
 Fix For: 1.2.0

 Attachments: HIVE-9711.1.patch, HIVE-9711.2.patch


 The isRepeating=true check uses Java equality, which results in NaN != NaN 
 comparison operations.
 The noNulls case needs the current check folded into the previous loop, while 
 the hasNulls case needs a logical AND of the isNull[] field instead of == 
 comparisons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-9711) ORC Vectorization DoubleColumnVector.isRepeating=false if all entries are NaN

2015-04-02 Thread Prasanth Jayachandran (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-9711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14393899#comment-14393899
 ] 

Prasanth Jayachandran commented on HIVE-9711:
-

[~gopalv] The patch mostly looks good.
1) Branch for batchSize  1 and batchSize == 1 can be combined together into 
else condition and initializing repeating variable based on the batch size.
2) nit: multiple checks in for() makes it go beyond 100 chars column width.


 ORC Vectorization DoubleColumnVector.isRepeating=false if all entries are NaN
 -

 Key: HIVE-9711
 URL: https://issues.apache.org/jira/browse/HIVE-9711
 Project: Hive
  Issue Type: Bug
  Components: File Formats, Vectorization
Affects Versions: 1.2.0
Reporter: Gopal V
Assignee: Gopal V
 Fix For: 1.2.0

 Attachments: HIVE-9711.1.patch


 The isRepeating=true check uses Java equality, which results in NaN != NaN 
 comparison operations.
 The noNulls case needs the current check folded into the previous loop, while 
 the hasNulls case needs a logical AND of the isNull[] field instead of == 
 comparisons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)