[jira] [Commented] (HIVE-9730) make sure logging is never called when not needed in perf-sensitive places
[ https://issues.apache.org/jira/browse/HIVE-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535885#comment-14535885 ] Sushanth Sowmyan commented on HIVE-9730: Removing fix version of 1.2.0 in preparation of release, since this is not a blocker for 1.2.0. > make sure logging is never called when not needed in perf-sensitive places > -- > > Key: HIVE-9730 > URL: https://issues.apache.org/jira/browse/HIVE-9730 > Project: Hive > Issue Type: Improvement > Components: Logging >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HIVE-9730.patch, log4j-llap.png > > > log4j logging has really inefficient serialization > !log4j-llap.png! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9730) make sure logging is never called when not needed in perf-sensitive places
[ https://issues.apache.org/jira/browse/HIVE-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14363710#comment-14363710 ] Sergey Shelukhin commented on HIVE-9730: [~gopalv] ping? > make sure logging is never called when not needed in perf-sensitive places > -- > > Key: HIVE-9730 > URL: https://issues.apache.org/jira/browse/HIVE-9730 > Project: Hive > Issue Type: Improvement > Components: Logging >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Fix For: 1.2.0 > > Attachments: HIVE-9730.patch, log4j-llap.png > > > log4j logging has really inefficient serialization > !log4j-llap.png! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9730) make sure logging is never called when not needed in perf-sensitive places
[ https://issues.apache.org/jira/browse/HIVE-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347895#comment-14347895 ] Sergey Shelukhin commented on HIVE-9730: ping? > make sure logging is never called when not needed in perf-sensitive places > -- > > Key: HIVE-9730 > URL: https://issues.apache.org/jira/browse/HIVE-9730 > Project: Hive > Issue Type: Improvement > Components: Logging >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Fix For: 1.2.0 > > Attachments: HIVE-9730.patch, log4j-llap.png > > > log4j logging has really inefficient serialization > !log4j-llap.png! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9730) make sure logging is never called when not needed in perf-sensitive places
[
https://issues.apache.org/jira/browse/HIVE-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335579#comment-14335579
]
Hive QA commented on HIVE-9730:
---
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12700557/HIVE-9730.patch
{color:green}SUCCESS:{color} +1 7567 tests passed
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2859/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2859/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2859/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12700557 - PreCommit-HIVE-TRUNK-Build
> make sure logging is never called when not needed in perf-sensitive places
> --
>
> Key: HIVE-9730
> URL: https://issues.apache.org/jira/browse/HIVE-9730
> Project: Hive
> Issue Type: Improvement
> Components: Logging
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Fix For: 1.2.0
>
> Attachments: HIVE-9730.patch, log4j-llap.png
>
>
> log4j logging has really inefficient serialization
> !log4j-llap.png!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-9730) make sure logging is never called when not needed in perf-sensitive places
[ https://issues.apache.org/jira/browse/HIVE-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335333#comment-14335333 ] Sergey Shelukhin commented on HIVE-9730: checks for Log4J logger could be removed. But yea, if we can switch entire Hive to reasonable logging that would not be necessary :) > make sure logging is never called when not needed in perf-sensitive places > -- > > Key: HIVE-9730 > URL: https://issues.apache.org/jira/browse/HIVE-9730 > Project: Hive > Issue Type: Improvement > Components: Logging >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Fix For: 1.2.0 > > Attachments: HIVE-9730.patch, log4j-llap.png > > > log4j logging has really inefficient serialization > !log4j-llap.png! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9730) make sure logging is never called when not needed in perf-sensitive places
[ https://issues.apache.org/jira/browse/HIVE-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335332#comment-14335332 ] Sergey Shelukhin commented on HIVE-9730: oh well > make sure logging is never called when not needed in perf-sensitive places > -- > > Key: HIVE-9730 > URL: https://issues.apache.org/jira/browse/HIVE-9730 > Project: Hive > Issue Type: Improvement > Components: Logging >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Fix For: 1.2.0 > > Attachments: HIVE-9730.patch, log4j-llap.png > > > log4j logging has really inefficient serialization > !log4j-llap.png! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9730) make sure logging is never called when not needed in perf-sensitive places
[ https://issues.apache.org/jira/browse/HIVE-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335331#comment-14335331 ] Sergey Shelukhin commented on HIVE-9730: https://reviews.apache.org/r/31375/ makes for a very exciting review > make sure logging is never called when not needed in perf-sensitive places > -- > > Key: HIVE-9730 > URL: https://issues.apache.org/jira/browse/HIVE-9730 > Project: Hive > Issue Type: Improvement > Components: Logging >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Fix For: 1.2.0 > > Attachments: HIVE-9730.patch, log4j-llap.png > > > log4j logging has really inefficient serialization > !log4j-llap.png! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9730) make sure logging is never called when not needed in perf-sensitive places
[ https://issues.apache.org/jira/browse/HIVE-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335313#comment-14335313 ] Gopal V commented on HIVE-9730: --- [~sershe]: Hold on, before we have checks for Log4JLogger etc, let's test with the log4j2 bridge and see if the performance issue disappears. This is something we'll circle back to after the next profiler run. > make sure logging is never called when not needed in perf-sensitive places > -- > > Key: HIVE-9730 > URL: https://issues.apache.org/jira/browse/HIVE-9730 > Project: Hive > Issue Type: Improvement > Components: Logging >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Fix For: 1.2.0 > > Attachments: HIVE-9730.patch, log4j-llap.png > > > log4j logging has really inefficient serialization > !log4j-llap.png! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
