[jira] [Updated] (HIVE-11079) Fix qfile tests that fail on Windows due to CR/character escape differences

2015-06-23 Thread Jason Dere (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-11079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Dere updated HIVE-11079:
--
Attachment: HIVE-11079.4.patch

Actually it looks like a couple of the test fixes are not necessary - I had 2 
different build environments, and one of them had git core.crlf=true which 
caused the files to have Windows style CRLF line endings, which affects some 
tests. In patch v4 I've removed the changes for decimal_udf2.q and 
describe_comment_indent.q.

 Fix qfile tests that fail on Windows due to CR/character escape differences
 ---

 Key: HIVE-11079
 URL: https://issues.apache.org/jira/browse/HIVE-11079
 Project: Hive
  Issue Type: Bug
  Components: Tests
Reporter: Jason Dere
Assignee: Jason Dere
 Attachments: HIVE-11079.1.patch, HIVE-11079.2.patch, 
 HIVE-11079.3.patch, HIVE-11079.4.patch


 A few qfile tests are failing on Windows due to a couple of windows-specific 
 issues:
 - The table comment for the test includes a CR character, which is different 
 on Windows compared to Unix.
 - The partition path in the test includes a space character. Unlike Unix, on 
 Windows space characters in Hive paths are escaped.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HIVE-11079) Fix qfile tests that fail on Windows due to CR/character escape differences

2015-06-23 Thread Jason Dere (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-11079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Dere updated HIVE-11079:
--
Attachment: HIVE-11079.5.patch

Patch needed rebase after HIVE-11037

 Fix qfile tests that fail on Windows due to CR/character escape differences
 ---

 Key: HIVE-11079
 URL: https://issues.apache.org/jira/browse/HIVE-11079
 Project: Hive
  Issue Type: Bug
  Components: Tests
Reporter: Jason Dere
Assignee: Jason Dere
 Attachments: HIVE-11079.1.patch, HIVE-11079.2.patch, 
 HIVE-11079.3.patch, HIVE-11079.4.patch, HIVE-11079.5.patch


 A few qfile tests are failing on Windows due to a couple of windows-specific 
 issues:
 - The table comment for the test includes a CR character, which is different 
 on Windows compared to Unix.
 - The partition path in the test includes a space character. Unlike Unix, on 
 Windows space characters in Hive paths are escaped.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HIVE-11079) Fix qfile tests that fail on Windows due to CR/character escape differences

2015-06-23 Thread Jason Dere (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-11079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Dere updated HIVE-11079:
--
Attachment: HIVE-11079.3.patch

Patch v3 - updating decimal_udf2.q as well, which has stats/file size 
differences on Windows due to CR differences on text files. Fixing the test by 
changing the table type to ORC rather than text, which should have more 
consistent data size between platforms. The actual stats values look different 
from before, but stats are not really important for this test.

 Fix qfile tests that fail on Windows due to CR/character escape differences
 ---

 Key: HIVE-11079
 URL: https://issues.apache.org/jira/browse/HIVE-11079
 Project: Hive
  Issue Type: Bug
  Components: Tests
Reporter: Jason Dere
Assignee: Jason Dere
 Attachments: HIVE-11079.1.patch, HIVE-11079.2.patch, 
 HIVE-11079.3.patch


 A few qfile tests are failing on Windows due to a couple of windows-specific 
 issues:
 - The table comment for the test includes a CR character, which is different 
 on Windows compared to Unix.
 - The partition path in the test includes a space character. Unlike Unix, on 
 Windows space characters in Hive paths are escaped.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)