[jira] [Updated] (HIVE-15430) Change SchemaTool table validator to test based on the dbType
[ https://issues.apache.org/jira/browse/HIVE-15430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aihua Xu updated HIVE-15430: Resolution: Fixed Fix Version/s: 2.2.0 Status: Resolved (was: Patch Available) Pushed to master. Thanks Naveen for the work. > Change SchemaTool table validator to test based on the dbType > - > > Key: HIVE-15430 > URL: https://issues.apache.org/jira/browse/HIVE-15430 > Project: Hive > Issue Type: Sub-task > Components: Hive >Affects Versions: 2.2.0 >Reporter: Naveen Gangam >Assignee: Naveen Gangam >Priority: Minor > Fix For: 2.2.0 > > Attachments: HIVE-15430.1.patch, HIVE-15430.2.patch, > HIVE-15430.3.patch, HIVE-15430.4.patch > > > Currently the validator parses the "oracle" schema file to determine what > tables are expected in the database. (mostly because of ease of parsing the > schema file compared to other syntax). We have learnt from HIVE-15118, that > not all schema files have the same amount of tables. For example, derby has > an old table that is never used that other DBs do not contain). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15430) Change SchemaTool table validator to test based on the dbType
[ https://issues.apache.org/jira/browse/HIVE-15430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Naveen Gangam updated HIVE-15430: - Status: Patch Available (was: Open) > Change SchemaTool table validator to test based on the dbType > - > > Key: HIVE-15430 > URL: https://issues.apache.org/jira/browse/HIVE-15430 > Project: Hive > Issue Type: Sub-task > Components: Hive >Affects Versions: 2.2.0 >Reporter: Naveen Gangam >Assignee: Naveen Gangam >Priority: Minor > Attachments: HIVE-15430.1.patch, HIVE-15430.2.patch, > HIVE-15430.3.patch, HIVE-15430.4.patch > > > Currently the validator parses the "oracle" schema file to determine what > tables are expected in the database. (mostly because of ease of parsing the > schema file compared to other syntax). We have learnt from HIVE-15118, that > not all schema files have the same amount of tables. For example, derby has > an old table that is never used that other DBs do not contain). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15430) Change SchemaTool table validator to test based on the dbType
[ https://issues.apache.org/jira/browse/HIVE-15430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Naveen Gangam updated HIVE-15430: - Status: Open (was: Patch Available) Got some additional feedback. Will attach patch based on the new feedback. > Change SchemaTool table validator to test based on the dbType > - > > Key: HIVE-15430 > URL: https://issues.apache.org/jira/browse/HIVE-15430 > Project: Hive > Issue Type: Sub-task > Components: Hive >Affects Versions: 2.2.0 >Reporter: Naveen Gangam >Assignee: Naveen Gangam >Priority: Minor > Attachments: HIVE-15430.1.patch, HIVE-15430.2.patch, > HIVE-15430.3.patch, HIVE-15430.4.patch > > > Currently the validator parses the "oracle" schema file to determine what > tables are expected in the database. (mostly because of ease of parsing the > schema file compared to other syntax). We have learnt from HIVE-15118, that > not all schema files have the same amount of tables. For example, derby has > an old table that is never used that other DBs do not contain). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15430) Change SchemaTool table validator to test based on the dbType
[ https://issues.apache.org/jira/browse/HIVE-15430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Naveen Gangam updated HIVE-15430: - Attachment: HIVE-15430.4.patch > Change SchemaTool table validator to test based on the dbType > - > > Key: HIVE-15430 > URL: https://issues.apache.org/jira/browse/HIVE-15430 > Project: Hive > Issue Type: Sub-task > Components: Hive >Affects Versions: 2.2.0 >Reporter: Naveen Gangam >Assignee: Naveen Gangam >Priority: Minor > Attachments: HIVE-15430.1.patch, HIVE-15430.2.patch, > HIVE-15430.3.patch, HIVE-15430.4.patch > > > Currently the validator parses the "oracle" schema file to determine what > tables are expected in the database. (mostly because of ease of parsing the > schema file compared to other syntax). We have learnt from HIVE-15118, that > not all schema files have the same amount of tables. For example, derby has > an old table that is never used that other DBs do not contain). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15430) Change SchemaTool table validator to test based on the dbType
[ https://issues.apache.org/jira/browse/HIVE-15430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Naveen Gangam updated HIVE-15430: - Status: Patch Available (was: Open) > Change SchemaTool table validator to test based on the dbType > - > > Key: HIVE-15430 > URL: https://issues.apache.org/jira/browse/HIVE-15430 > Project: Hive > Issue Type: Sub-task > Components: Hive >Affects Versions: 2.2.0 >Reporter: Naveen Gangam >Assignee: Naveen Gangam >Priority: Minor > Attachments: HIVE-15430.1.patch, HIVE-15430.2.patch, > HIVE-15430.3.patch > > > Currently the validator parses the "oracle" schema file to determine what > tables are expected in the database. (mostly because of ease of parsing the > schema file compared to other syntax). We have learnt from HIVE-15118, that > not all schema files have the same amount of tables. For example, derby has > an old table that is never used that other DBs do not contain). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15430) Change SchemaTool table validator to test based on the dbType
[ https://issues.apache.org/jira/browse/HIVE-15430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Naveen Gangam updated HIVE-15430: - Attachment: HIVE-15430.3.patch > Change SchemaTool table validator to test based on the dbType > - > > Key: HIVE-15430 > URL: https://issues.apache.org/jira/browse/HIVE-15430 > Project: Hive > Issue Type: Sub-task > Components: Hive >Affects Versions: 2.2.0 >Reporter: Naveen Gangam >Assignee: Naveen Gangam >Priority: Minor > Attachments: HIVE-15430.1.patch, HIVE-15430.2.patch, > HIVE-15430.3.patch > > > Currently the validator parses the "oracle" schema file to determine what > tables are expected in the database. (mostly because of ease of parsing the > schema file compared to other syntax). We have learnt from HIVE-15118, that > not all schema files have the same amount of tables. For example, derby has > an old table that is never used that other DBs do not contain). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15430) Change SchemaTool table validator to test based on the dbType
[ https://issues.apache.org/jira/browse/HIVE-15430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Naveen Gangam updated HIVE-15430: - Status: Open (was: Patch Available) Incorporating feedback from RB. > Change SchemaTool table validator to test based on the dbType > - > > Key: HIVE-15430 > URL: https://issues.apache.org/jira/browse/HIVE-15430 > Project: Hive > Issue Type: Sub-task > Components: Hive >Affects Versions: 2.2.0 >Reporter: Naveen Gangam >Assignee: Naveen Gangam >Priority: Minor > Attachments: HIVE-15430.1.patch, HIVE-15430.2.patch, > HIVE-15430.3.patch > > > Currently the validator parses the "oracle" schema file to determine what > tables are expected in the database. (mostly because of ease of parsing the > schema file compared to other syntax). We have learnt from HIVE-15118, that > not all schema files have the same amount of tables. For example, derby has > an old table that is never used that other DBs do not contain). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15430) Change SchemaTool table validator to test based on the dbType
[ https://issues.apache.org/jira/browse/HIVE-15430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Naveen Gangam updated HIVE-15430: - Attachment: HIVE-15430.2.patch Fixing a test failure for derby where the tables parsed from schema files contained "APP." where as the tables from the DB via JDBC returned just the tablename without the "APP." prefix. Fixed the schema tool to accommodate this difference. > Change SchemaTool table validator to test based on the dbType > - > > Key: HIVE-15430 > URL: https://issues.apache.org/jira/browse/HIVE-15430 > Project: Hive > Issue Type: Sub-task > Components: Hive >Affects Versions: 2.2.0 >Reporter: Naveen Gangam >Assignee: Naveen Gangam >Priority: Minor > Attachments: HIVE-15430.1.patch, HIVE-15430.2.patch > > > Currently the validator parses the "oracle" schema file to determine what > tables are expected in the database. (mostly because of ease of parsing the > schema file compared to other syntax). We have learnt from HIVE-15118, that > not all schema files have the same amount of tables. For example, derby has > an old table that is never used that other DBs do not contain). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15430) Change SchemaTool table validator to test based on the dbType
[ https://issues.apache.org/jira/browse/HIVE-15430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Naveen Gangam updated HIVE-15430: - Status: Patch Available (was: Open) > Change SchemaTool table validator to test based on the dbType > - > > Key: HIVE-15430 > URL: https://issues.apache.org/jira/browse/HIVE-15430 > Project: Hive > Issue Type: Sub-task > Components: Hive >Affects Versions: 2.2.0 >Reporter: Naveen Gangam >Assignee: Naveen Gangam >Priority: Minor > Attachments: HIVE-15430.1.patch, HIVE-15430.2.patch > > > Currently the validator parses the "oracle" schema file to determine what > tables are expected in the database. (mostly because of ease of parsing the > schema file compared to other syntax). We have learnt from HIVE-15118, that > not all schema files have the same amount of tables. For example, derby has > an old table that is never used that other DBs do not contain). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15430) Change SchemaTool table validator to test based on the dbType
[ https://issues.apache.org/jira/browse/HIVE-15430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Naveen Gangam updated HIVE-15430: - Status: Open (was: Patch Available) > Change SchemaTool table validator to test based on the dbType > - > > Key: HIVE-15430 > URL: https://issues.apache.org/jira/browse/HIVE-15430 > Project: Hive > Issue Type: Sub-task > Components: Hive >Affects Versions: 2.2.0 >Reporter: Naveen Gangam >Assignee: Naveen Gangam >Priority: Minor > Attachments: HIVE-15430.1.patch > > > Currently the validator parses the "oracle" schema file to determine what > tables are expected in the database. (mostly because of ease of parsing the > schema file compared to other syntax). We have learnt from HIVE-15118, that > not all schema files have the same amount of tables. For example, derby has > an old table that is never used that other DBs do not contain). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15430) Change SchemaTool table validator to test based on the dbType
[ https://issues.apache.org/jira/browse/HIVE-15430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Naveen Gangam updated HIVE-15430: - Status: Patch Available (was: Open) > Change SchemaTool table validator to test based on the dbType > - > > Key: HIVE-15430 > URL: https://issues.apache.org/jira/browse/HIVE-15430 > Project: Hive > Issue Type: Sub-task > Components: Hive >Affects Versions: 2.2.0 >Reporter: Naveen Gangam >Assignee: Naveen Gangam >Priority: Minor > Attachments: HIVE-15430.1.patch > > > Currently the validator parses the "oracle" schema file to determine what > tables are expected in the database. (mostly because of ease of parsing the > schema file compared to other syntax). We have learnt from HIVE-15118, that > not all schema files have the same amount of tables. For example, derby has > an old table that is never used that other DBs do not contain). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15430) Change SchemaTool table validator to test based on the dbType
[ https://issues.apache.org/jira/browse/HIVE-15430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Naveen Gangam updated HIVE-15430: - Attachment: HIVE-15430.1.patch Attaching a patch that contains the following fixes 1) The SchemaTool's schema table validator now parses the respective schema file (based on the dbType specfied). Prior to this change, it always parses the oracle schema files (because the syntax is easier). For ex: for mysql, it parses the hive-schema-xxx.mysql.sql file. 2) The error reporting/messages were not very clear or consistent when a) VERSION table was missing b) VERSION table had no version infor c) VERSION table had an unrecognized version. The tool would throw a FileNotFOundException as it could not find the schema file corresponding to that version. 3) Table Location validator did not validate the location column in SKEWED_COL_VALUE_LOC_MAP table. Added a validator for that column value. > Change SchemaTool table validator to test based on the dbType > - > > Key: HIVE-15430 > URL: https://issues.apache.org/jira/browse/HIVE-15430 > Project: Hive > Issue Type: Sub-task > Components: Hive >Affects Versions: 2.2.0 >Reporter: Naveen Gangam >Assignee: Naveen Gangam >Priority: Minor > Attachments: HIVE-15430.1.patch > > > Currently the validator parses the "oracle" schema file to determine what > tables are expected in the database. (mostly because of ease of parsing the > schema file compared to other syntax). We have learnt from HIVE-15118, that > not all schema files have the same amount of tables. For example, derby has > an old table that is never used that other DBs do not contain). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
