[jira] [Updated] (HIVE-15891) Detect query rewrite scenario for UPDATE/DELETE/MERGE and fail fast
[ https://issues.apache.org/jira/browse/HIVE-15891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei Zheng updated HIVE-15891: - Resolution: Fixed Fix Version/s: 2.2.0 Status: Resolved (was: Patch Available) Committed to master. Thanks [~ekoifman] for the review! > Detect query rewrite scenario for UPDATE/DELETE/MERGE and fail fast > --- > > Key: HIVE-15891 > URL: https://issues.apache.org/jira/browse/HIVE-15891 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 2.2.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Fix For: 2.2.0 > > Attachments: HIVE-15891.1.patch, HIVE-15891.2.patch, > HIVE-15891.3.patch, HIVE-15891.4.patch > > > Currently ACID UpdateDeleteSemanticAnalyzer directly manipulates the AST tree > but it's different from the general approach of modifying the token stream > and thus will cause AST tree mismatch if there is any rewrite happening after > UpdateDeleteSemanticAnalyzer. > The long term solution will be to rewrite the AST handling logic in > UpdateDeleteSemanticAnalyzer, to make it consistent with the general approach. > This ticket will for now detect the error prone cases and fail early. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15891) Detect query rewrite scenario for UPDATE/DELETE/MERGE and fail fast
[ https://issues.apache.org/jira/browse/HIVE-15891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei Zheng updated HIVE-15891: - Attachment: HIVE-15891.4.patch > Detect query rewrite scenario for UPDATE/DELETE/MERGE and fail fast > --- > > Key: HIVE-15891 > URL: https://issues.apache.org/jira/browse/HIVE-15891 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 2.2.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-15891.1.patch, HIVE-15891.2.patch, > HIVE-15891.3.patch, HIVE-15891.4.patch > > > Currently ACID UpdateDeleteSemanticAnalyzer directly manipulates the AST tree > but it's different from the general approach of modifying the token stream > and thus will cause AST tree mismatch if there is any rewrite happening after > UpdateDeleteSemanticAnalyzer. > The long term solution will be to rewrite the AST handling logic in > UpdateDeleteSemanticAnalyzer, to make it consistent with the general approach. > This ticket will for now detect the error prone cases and fail early. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15891) Detect query rewrite scenario for UPDATE/DELETE/MERGE and fail fast
[ https://issues.apache.org/jira/browse/HIVE-15891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei Zheng updated HIVE-15891: - Status: Patch Available (was: Open) > Detect query rewrite scenario for UPDATE/DELETE/MERGE and fail fast > --- > > Key: HIVE-15891 > URL: https://issues.apache.org/jira/browse/HIVE-15891 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 2.2.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-15891.1.patch, HIVE-15891.2.patch, > HIVE-15891.3.patch, HIVE-15891.4.patch > > > Currently ACID UpdateDeleteSemanticAnalyzer directly manipulates the AST tree > but it's different from the general approach of modifying the token stream > and thus will cause AST tree mismatch if there is any rewrite happening after > UpdateDeleteSemanticAnalyzer. > The long term solution will be to rewrite the AST handling logic in > UpdateDeleteSemanticAnalyzer, to make it consistent with the general approach. > This ticket will for now detect the error prone cases and fail early. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15891) Detect query rewrite scenario for UPDATE/DELETE/MERGE and fail fast
[ https://issues.apache.org/jira/browse/HIVE-15891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei Zheng updated HIVE-15891: - Status: Open (was: Patch Available) > Detect query rewrite scenario for UPDATE/DELETE/MERGE and fail fast > --- > > Key: HIVE-15891 > URL: https://issues.apache.org/jira/browse/HIVE-15891 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 2.2.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-15891.1.patch, HIVE-15891.2.patch, > HIVE-15891.3.patch > > > Currently ACID UpdateDeleteSemanticAnalyzer directly manipulates the AST tree > but it's different from the general approach of modifying the token stream > and thus will cause AST tree mismatch if there is any rewrite happening after > UpdateDeleteSemanticAnalyzer. > The long term solution will be to rewrite the AST handling logic in > UpdateDeleteSemanticAnalyzer, to make it consistent with the general approach. > This ticket will for now detect the error prone cases and fail early. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15891) Detect query rewrite scenario for UPDATE/DELETE/MERGE and fail fast
[ https://issues.apache.org/jira/browse/HIVE-15891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei Zheng updated HIVE-15891: - Status: Patch Available (was: Open) > Detect query rewrite scenario for UPDATE/DELETE/MERGE and fail fast > --- > > Key: HIVE-15891 > URL: https://issues.apache.org/jira/browse/HIVE-15891 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 2.2.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-15891.1.patch, HIVE-15891.2.patch, > HIVE-15891.3.patch > > > Currently ACID UpdateDeleteSemanticAnalyzer directly manipulates the AST tree > but it's different from the general approach of modifying the token stream > and thus will cause AST tree mismatch if there is any rewrite happening after > UpdateDeleteSemanticAnalyzer. > The long term solution will be to rewrite the AST handling logic in > UpdateDeleteSemanticAnalyzer, to make it consistent with the general approach. > This ticket will for now detect the error prone cases and fail early. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15891) Detect query rewrite scenario for UPDATE/DELETE/MERGE and fail fast
[ https://issues.apache.org/jira/browse/HIVE-15891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei Zheng updated HIVE-15891: - Attachment: HIVE-15891.3.patch > Detect query rewrite scenario for UPDATE/DELETE/MERGE and fail fast > --- > > Key: HIVE-15891 > URL: https://issues.apache.org/jira/browse/HIVE-15891 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 2.2.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-15891.1.patch, HIVE-15891.2.patch, > HIVE-15891.3.patch > > > Currently ACID UpdateDeleteSemanticAnalyzer directly manipulates the AST tree > but it's different from the general approach of modifying the token stream > and thus will cause AST tree mismatch if there is any rewrite happening after > UpdateDeleteSemanticAnalyzer. > The long term solution will be to rewrite the AST handling logic in > UpdateDeleteSemanticAnalyzer, to make it consistent with the general approach. > This ticket will for now detect the error prone cases and fail early. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15891) Detect query rewrite scenario for UPDATE/DELETE/MERGE and fail fast
[ https://issues.apache.org/jira/browse/HIVE-15891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei Zheng updated HIVE-15891: - Status: Open (was: Patch Available) > Detect query rewrite scenario for UPDATE/DELETE/MERGE and fail fast > --- > > Key: HIVE-15891 > URL: https://issues.apache.org/jira/browse/HIVE-15891 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 2.2.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-15891.1.patch, HIVE-15891.2.patch > > > Currently ACID UpdateDeleteSemanticAnalyzer directly manipulates the AST tree > but it's different from the general approach of modifying the token stream > and thus will cause AST tree mismatch if there is any rewrite happening after > UpdateDeleteSemanticAnalyzer. > The long term solution will be to rewrite the AST handling logic in > UpdateDeleteSemanticAnalyzer, to make it consistent with the general approach. > This ticket will for now detect the error prone cases and fail early. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15891) Detect query rewrite scenario for UPDATE/DELETE/MERGE and fail fast
[ https://issues.apache.org/jira/browse/HIVE-15891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei Zheng updated HIVE-15891: - Attachment: HIVE-15891.2.patch > Detect query rewrite scenario for UPDATE/DELETE/MERGE and fail fast > --- > > Key: HIVE-15891 > URL: https://issues.apache.org/jira/browse/HIVE-15891 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 2.2.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-15891.1.patch, HIVE-15891.2.patch > > > Currently ACID UpdateDeleteSemanticAnalyzer directly manipulates the AST tree > but it's different from the general approach of modifying the token stream > and thus will cause AST tree mismatch if there is any rewrite happening after > UpdateDeleteSemanticAnalyzer. > The long term solution will be to rewrite the AST handling logic in > UpdateDeleteSemanticAnalyzer, to make it consistent with the general approach. > This ticket will for now detect the error prone cases and fail early. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15891) Detect query rewrite scenario for UPDATE/DELETE/MERGE and fail fast
[ https://issues.apache.org/jira/browse/HIVE-15891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei Zheng updated HIVE-15891: - Status: Open (was: Patch Available) > Detect query rewrite scenario for UPDATE/DELETE/MERGE and fail fast > --- > > Key: HIVE-15891 > URL: https://issues.apache.org/jira/browse/HIVE-15891 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 2.2.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-15891.1.patch, HIVE-15891.2.patch > > > Currently ACID UpdateDeleteSemanticAnalyzer directly manipulates the AST tree > but it's different from the general approach of modifying the token stream > and thus will cause AST tree mismatch if there is any rewrite happening after > UpdateDeleteSemanticAnalyzer. > The long term solution will be to rewrite the AST handling logic in > UpdateDeleteSemanticAnalyzer, to make it consistent with the general approach. > This ticket will for now detect the error prone cases and fail early. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15891) Detect query rewrite scenario for UPDATE/DELETE/MERGE and fail fast
[ https://issues.apache.org/jira/browse/HIVE-15891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei Zheng updated HIVE-15891: - Status: Patch Available (was: Open) > Detect query rewrite scenario for UPDATE/DELETE/MERGE and fail fast > --- > > Key: HIVE-15891 > URL: https://issues.apache.org/jira/browse/HIVE-15891 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 2.2.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-15891.1.patch, HIVE-15891.2.patch > > > Currently ACID UpdateDeleteSemanticAnalyzer directly manipulates the AST tree > but it's different from the general approach of modifying the token stream > and thus will cause AST tree mismatch if there is any rewrite happening after > UpdateDeleteSemanticAnalyzer. > The long term solution will be to rewrite the AST handling logic in > UpdateDeleteSemanticAnalyzer, to make it consistent with the general approach. > This ticket will for now detect the error prone cases and fail early. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15891) Detect query rewrite scenario for UPDATE/DELETE/MERGE and fail fast
[ https://issues.apache.org/jira/browse/HIVE-15891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei Zheng updated HIVE-15891: - Attachment: HIVE-15891.1.patch > Detect query rewrite scenario for UPDATE/DELETE/MERGE and fail fast > --- > > Key: HIVE-15891 > URL: https://issues.apache.org/jira/browse/HIVE-15891 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 2.2.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-15891.1.patch > > > Currently ACID UpdateDeleteSemanticAnalyzer directly manipulates the AST tree > but it's different from the general approach of modifying the token stream > and thus will cause AST tree mismatch if there is any rewrite happening after > UpdateDeleteSemanticAnalyzer. > The long term solution will be to rewrite the AST handling logic in > UpdateDeleteSemanticAnalyzer, to make it consistent with the general approach. > This ticket will for now detect the error prone cases and fail early. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15891) Detect query rewrite scenario for UPDATE/DELETE/MERGE and fail fast
[ https://issues.apache.org/jira/browse/HIVE-15891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei Zheng updated HIVE-15891: - Status: Patch Available (was: Open) > Detect query rewrite scenario for UPDATE/DELETE/MERGE and fail fast > --- > > Key: HIVE-15891 > URL: https://issues.apache.org/jira/browse/HIVE-15891 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 2.2.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-15891.1.patch > > > Currently ACID UpdateDeleteSemanticAnalyzer directly manipulates the AST tree > but it's different from the general approach of modifying the token stream > and thus will cause AST tree mismatch if there is any rewrite happening after > UpdateDeleteSemanticAnalyzer. > The long term solution will be to rewrite the AST handling logic in > UpdateDeleteSemanticAnalyzer, to make it consistent with the general approach. > This ticket will for now detect the error prone cases and fail early. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
