[jira] [Updated] (HIVE-17981) Create a set of builders for Thrift classes
[ https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-17981: -- Resolution: Fixed Fix Version/s: 3.0.0 Status: Resolved (was: Patch Available) Patch committed to master. Thanks Peter for the review. Also, I'll file JIRAs for the other raised issues. > Create a set of builders for Thrift classes > --- > > Key: HIVE-17981 > URL: https://issues.apache.org/jira/browse/HIVE-17981 > Project: Hive > Issue Type: Sub-task > Components: Standalone Metastore >Reporter: Alan Gates >Assignee: Alan Gates > Labels: pull-request-available > Fix For: 3.0.0 > > Attachments: HIVE-17981.2.patch, HIVE-17981.3.patch, > HIVE-17981.copy.patch, HIVE-17981.patch > > > Instantiating some of the Thrift classes is painful. Consider building a > {{Table}} object, which requires a {{StorageDescriptor}}, which requires a > {{SerDeInfo}} and a list of {{FieldInfo}}. All that is really necessary for > a Table in the most simple case is a name, a database, and some columns. But > currently creating even a simple Table requires 20+ lines of code. This is > particularly painful in tests. > I propose to add a set of builders. These will come with reasonable defaults > to minimize the boilerplate code. They will also include simple methods for > common operations (like adding columns, or a parameter) without requiring the > user to create all the sub-objects (like {{StorageDescriptor}}). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HIVE-17981) Create a set of builders for Thrift classes
[ https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-17981: -- Attachment: HIVE-17981.3.patch > Create a set of builders for Thrift classes > --- > > Key: HIVE-17981 > URL: https://issues.apache.org/jira/browse/HIVE-17981 > Project: Hive > Issue Type: Sub-task > Components: Standalone Metastore >Reporter: Alan Gates >Assignee: Alan Gates > Labels: pull-request-available > Attachments: HIVE-17981.2.patch, HIVE-17981.3.patch, > HIVE-17981.copy.patch, HIVE-17981.patch > > > Instantiating some of the Thrift classes is painful. Consider building a > {{Table}} object, which requires a {{StorageDescriptor}}, which requires a > {{SerDeInfo}} and a list of {{FieldInfo}}. All that is really necessary for > a Table in the most simple case is a name, a database, and some columns. But > currently creating even a simple Table requires 20+ lines of code. This is > particularly painful in tests. > I propose to add a set of builders. These will come with reasonable defaults > to minimize the boilerplate code. They will also include simple methods for > common operations (like adding columns, or a parameter) without requiring the > user to create all the sub-objects (like {{StorageDescriptor}}). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HIVE-17981) Create a set of builders for Thrift classes
[ https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-17981: -- Attachment: HIVE-17981.2.patch > Create a set of builders for Thrift classes > --- > > Key: HIVE-17981 > URL: https://issues.apache.org/jira/browse/HIVE-17981 > Project: Hive > Issue Type: Sub-task > Components: Standalone Metastore >Reporter: Alan Gates >Assignee: Alan Gates > Labels: pull-request-available > Attachments: HIVE-17981.2.patch, HIVE-17981.copy.patch, > HIVE-17981.patch > > > Instantiating some of the Thrift classes is painful. Consider building a > {{Table}} object, which requires a {{StorageDescriptor}}, which requires a > {{SerDeInfo}} and a list of {{FieldInfo}}. All that is really necessary for > a Table in the most simple case is a name, a database, and some columns. But > currently creating even a simple Table requires 20+ lines of code. This is > particularly painful in tests. > I propose to add a set of builders. These will come with reasonable defaults > to minimize the boilerplate code. They will also include simple methods for > common operations (like adding columns, or a parameter) without requiring the > user to create all the sub-objects (like {{StorageDescriptor}}). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HIVE-17981) Create a set of builders for Thrift classes
[ https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-17981: -- Attachment: HIVE-17981.copy.patch Attaching a copy of the original patch to get ptest to pick it up. > Create a set of builders for Thrift classes > --- > > Key: HIVE-17981 > URL: https://issues.apache.org/jira/browse/HIVE-17981 > Project: Hive > Issue Type: Sub-task > Components: Standalone Metastore >Reporter: Alan Gates >Assignee: Alan Gates > Labels: pull-request-available > Attachments: HIVE-17981.copy.patch, HIVE-17981.patch > > > Instantiating some of the Thrift classes is painful. Consider building a > {{Table}} object, which requires a {{StorageDescriptor}}, which requires a > {{SerDeInfo}} and a list of {{FieldInfo}}. All that is really necessary for > a Table in the most simple case is a name, a database, and some columns. But > currently creating even a simple Table requires 20+ lines of code. This is > particularly painful in tests. > I propose to add a set of builders. These will come with reasonable defaults > to minimize the boilerplate code. They will also include simple methods for > common operations (like adding columns, or a parameter) without requiring the > user to create all the sub-objects (like {{StorageDescriptor}}). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HIVE-17981) Create a set of builders for Thrift classes
[ https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-17981: -- Attachment: HIVE-17981.patch Reattaching the patch as it didn't get picked up by ptest last time. > Create a set of builders for Thrift classes > --- > > Key: HIVE-17981 > URL: https://issues.apache.org/jira/browse/HIVE-17981 > Project: Hive > Issue Type: Sub-task > Components: Standalone Metastore >Reporter: Alan Gates >Assignee: Alan Gates > Labels: pull-request-available > Attachments: HIVE-17981.patch > > > Instantiating some of the Thrift classes is painful. Consider building a > {{Table}} object, which requires a {{StorageDescriptor}}, which requires a > {{SerDeInfo}} and a list of {{FieldInfo}}. All that is really necessary for > a Table in the most simple case is a name, a database, and some columns. But > currently creating even a simple Table requires 20+ lines of code. This is > particularly painful in tests. > I propose to add a set of builders. These will come with reasonable defaults > to minimize the boilerplate code. They will also include simple methods for > common operations (like adding columns, or a parameter) without requiring the > user to create all the sub-objects (like {{StorageDescriptor}}). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HIVE-17981) Create a set of builders for Thrift classes
[ https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-17981: -- Attachment: (was: HIVE-17981.patch) > Create a set of builders for Thrift classes > --- > > Key: HIVE-17981 > URL: https://issues.apache.org/jira/browse/HIVE-17981 > Project: Hive > Issue Type: Sub-task > Components: Standalone Metastore >Reporter: Alan Gates >Assignee: Alan Gates > Labels: pull-request-available > Attachments: HIVE-17981.patch > > > Instantiating some of the Thrift classes is painful. Consider building a > {{Table}} object, which requires a {{StorageDescriptor}}, which requires a > {{SerDeInfo}} and a list of {{FieldInfo}}. All that is really necessary for > a Table in the most simple case is a name, a database, and some columns. But > currently creating even a simple Table requires 20+ lines of code. This is > particularly painful in tests. > I propose to add a set of builders. These will come with reasonable defaults > to minimize the boilerplate code. They will also include simple methods for > common operations (like adding columns, or a parameter) without requiring the > user to create all the sub-objects (like {{StorageDescriptor}}). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HIVE-17981) Create a set of builders for Thrift classes
[ https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HIVE-17981: -- Labels: pull-request-available (was: ) > Create a set of builders for Thrift classes > --- > > Key: HIVE-17981 > URL: https://issues.apache.org/jira/browse/HIVE-17981 > Project: Hive > Issue Type: Sub-task > Components: Standalone Metastore >Reporter: Alan Gates >Assignee: Alan Gates > Labels: pull-request-available > Attachments: HIVE-17981.patch > > > Instantiating some of the Thrift classes is painful. Consider building a > {{Table}} object, which requires a {{StorageDescriptor}}, which requires a > {{SerDeInfo}} and a list of {{FieldInfo}}. All that is really necessary for > a Table in the most simple case is a name, a database, and some columns. But > currently creating even a simple Table requires 20+ lines of code. This is > particularly painful in tests. > I propose to add a set of builders. These will come with reasonable defaults > to minimize the boilerplate code. They will also include simple methods for > common operations (like adding columns, or a parameter) without requiring the > user to create all the sub-objects (like {{StorageDescriptor}}). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HIVE-17981) Create a set of builders for Thrift classes
[ https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-17981: -- Attachment: HIVE-17981.patch > Create a set of builders for Thrift classes > --- > > Key: HIVE-17981 > URL: https://issues.apache.org/jira/browse/HIVE-17981 > Project: Hive > Issue Type: Sub-task > Components: Standalone Metastore >Reporter: Alan Gates >Assignee: Alan Gates > Labels: pull-request-available > Attachments: HIVE-17981.patch > > > Instantiating some of the Thrift classes is painful. Consider building a > {{Table}} object, which requires a {{StorageDescriptor}}, which requires a > {{SerDeInfo}} and a list of {{FieldInfo}}. All that is really necessary for > a Table in the most simple case is a name, a database, and some columns. But > currently creating even a simple Table requires 20+ lines of code. This is > particularly painful in tests. > I propose to add a set of builders. These will come with reasonable defaults > to minimize the boilerplate code. They will also include simple methods for > common operations (like adding columns, or a parameter) without requiring the > user to create all the sub-objects (like {{StorageDescriptor}}). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HIVE-17981) Create a set of builders for Thrift classes
[ https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-17981: -- Status: Patch Available (was: Open) > Create a set of builders for Thrift classes > --- > > Key: HIVE-17981 > URL: https://issues.apache.org/jira/browse/HIVE-17981 > Project: Hive > Issue Type: Sub-task > Components: Standalone Metastore >Reporter: Alan Gates >Assignee: Alan Gates > Attachments: HIVE-17981.patch > > > Instantiating some of the Thrift classes is painful. Consider building a > {{Table}} object, which requires a {{StorageDescriptor}}, which requires a > {{SerDeInfo}} and a list of {{FieldInfo}}. All that is really necessary for > a Table in the most simple case is a name, a database, and some columns. But > currently creating even a simple Table requires 20+ lines of code. This is > particularly painful in tests. > I propose to add a set of builders. These will come with reasonable defaults > to minimize the boilerplate code. They will also include simple methods for > common operations (like adding columns, or a parameter) without requiring the > user to create all the sub-objects (like {{StorageDescriptor}}). -- This message was sent by Atlassian JIRA (v6.4.14#64029)