[jira] [Updated] (HIVE-20542) Incremental REPL DUMP progress information log message is incorrect.
[ https://issues.apache.org/jira/browse/HIVE-20542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Bapat updated HIVE-20542: -- Attachment: HIVE-20542.01.patch > Incremental REPL DUMP progress information log message is incorrect. > > > Key: HIVE-20542 > URL: https://issues.apache.org/jira/browse/HIVE-20542 > Project: Hive > Issue Type: Bug > Components: repl >Affects Versions: 4.0.0, 3.2.0 >Reporter: Sankar Hariappan >Assignee: Ashutosh Bapat >Priority: Minor > Labels: DR, Replication > Attachments: HIVE-20542.01.patch > > > Incremental REPL DUMP have the progress information logged as > "eventsDumpProgress":"49/0". > It should actually log the estimated number of events are denominator but it > is coming as 0 always. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20542) Incremental REPL DUMP progress information log message is incorrect.
[ https://issues.apache.org/jira/browse/HIVE-20542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Bapat updated HIVE-20542: -- Attachment: (was: HIVE-20542.01.patch) > Incremental REPL DUMP progress information log message is incorrect. > > > Key: HIVE-20542 > URL: https://issues.apache.org/jira/browse/HIVE-20542 > Project: Hive > Issue Type: Bug > Components: repl >Affects Versions: 4.0.0, 3.2.0 >Reporter: Sankar Hariappan >Assignee: Ashutosh Bapat >Priority: Minor > Labels: DR, Replication > > Incremental REPL DUMP have the progress information logged as > "eventsDumpProgress":"49/0". > It should actually log the estimated number of events are denominator but it > is coming as 0 always. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20542) Incremental REPL DUMP progress information log message is incorrect.
[ https://issues.apache.org/jira/browse/HIVE-20542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Bapat updated HIVE-20542: -- Attachment: HIVE-20542.01.patch Status: Patch Available (was: Open) > Incremental REPL DUMP progress information log message is incorrect. > > > Key: HIVE-20542 > URL: https://issues.apache.org/jira/browse/HIVE-20542 > Project: Hive > Issue Type: Bug > Components: repl >Affects Versions: 4.0.0, 3.2.0 >Reporter: Sankar Hariappan >Assignee: Ashutosh Bapat >Priority: Minor > Labels: DR, Replication > Attachments: HIVE-20542.01.patch > > > Incremental REPL DUMP have the progress information logged as > "eventsDumpProgress":"49/0". > It should actually log the estimated number of events are denominator but it > is coming as 0 always. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20542) Incremental REPL DUMP progress information log message is incorrect.
[ https://issues.apache.org/jira/browse/HIVE-20542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HIVE-20542: -- Labels: DR Replication pull-request-available (was: DR Replication) > Incremental REPL DUMP progress information log message is incorrect. > > > Key: HIVE-20542 > URL: https://issues.apache.org/jira/browse/HIVE-20542 > Project: Hive > Issue Type: Bug > Components: repl >Affects Versions: 4.0.0, 3.2.0 >Reporter: Sankar Hariappan >Assignee: Ashutosh Bapat >Priority: Minor > Labels: DR, Replication, pull-request-available > Attachments: HIVE-20542.01.patch > > > Incremental REPL DUMP have the progress information logged as > "eventsDumpProgress":"49/0". > It should actually log the estimated number of events are denominator but it > is coming as 0 always. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20542) Incremental REPL DUMP progress information log message is incorrect.
[ https://issues.apache.org/jira/browse/HIVE-20542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Bapat updated HIVE-20542: -- Status: In Progress (was: Patch Available) > Incremental REPL DUMP progress information log message is incorrect. > > > Key: HIVE-20542 > URL: https://issues.apache.org/jira/browse/HIVE-20542 > Project: Hive > Issue Type: Bug > Components: repl >Affects Versions: 4.0.0, 3.2.0 >Reporter: Sankar Hariappan >Assignee: Ashutosh Bapat >Priority: Minor > Labels: DR, Replication, pull-request-available > Attachments: HIVE-20542.01.patch > > > Incremental REPL DUMP have the progress information logged as > "eventsDumpProgress":"49/0". > It should actually log the estimated number of events are denominator but it > is coming as 0 always. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20542) Incremental REPL DUMP progress information log message is incorrect.
[ https://issues.apache.org/jira/browse/HIVE-20542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Bapat updated HIVE-20542: -- Attachment: HIVE-20542.02 Status: Patch Available (was: In Progress) [~sankarh], PFA patch with your comments addressed. See some replies to you comments below (Your comments marked as SHC) # SHC: Need to use Java naming conventions for variables. Eg, dbname_val should be dbNameVal etc. ## Done. # SHC: In addNotificationLoag method, seen similar issue where table name is set to " " (with single space) if it is not an input. Can we make it null if not available. ## Done. # SHC: addNotificationLog can use event.getCatName() to set catalogue name instead of always setting it to NULL. ## Done. # SHC: getNotificationEventsCount can take an optional toEventId as it is allowed for incremental replication. Also, check if we can include LIMIT as well. ## Done. # SHC: In getNotificationEventsCount, can we use (dbName IS NULL) instead of (dbName == null)? Same with catalogName too. ## No, JDOQL doesn't understand IS NULL construct. # SHC: Can add a unit test in TestReplicationScenarios.java to verify if getNotificationEventsCount return proper count for events with db name and not. Shall add a modifier method for getNotificationEventsCount in InjectableBehaviourObjectStore and in the modifier just check if you receive proper count with different inputs for fromEventId, toEventId and limit. ## Done in a different way. I invoked getNotificationEventsCount method directly of Metastore Client with different combinations of arguments. Also added a testcase to make sure that OPEN/COMMIT TRANSACTION events are counted correctly. > Incremental REPL DUMP progress information log message is incorrect. > > > Key: HIVE-20542 > URL: https://issues.apache.org/jira/browse/HIVE-20542 > Project: Hive > Issue Type: Bug > Components: repl >Affects Versions: 4.0.0, 3.2.0 >Reporter: Sankar Hariappan >Assignee: Ashutosh Bapat >Priority: Minor > Labels: DR, Replication, pull-request-available > Attachments: HIVE-20542.01.patch, HIVE-20542.02 > > > Incremental REPL DUMP have the progress information logged as > "eventsDumpProgress":"49/0". > It should actually log the estimated number of events are denominator but it > is coming as 0 always. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20542) Incremental REPL DUMP progress information log message is incorrect.
[ https://issues.apache.org/jira/browse/HIVE-20542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Bapat updated HIVE-20542: -- Status: In Progress (was: Patch Available) > Incremental REPL DUMP progress information log message is incorrect. > > > Key: HIVE-20542 > URL: https://issues.apache.org/jira/browse/HIVE-20542 > Project: Hive > Issue Type: Bug > Components: repl >Affects Versions: 4.0.0, 3.2.0 >Reporter: Sankar Hariappan >Assignee: Ashutosh Bapat >Priority: Minor > Labels: DR, Replication, pull-request-available > Attachments: HIVE-20542.01.patch, HIVE-20542.02 > > > Incremental REPL DUMP have the progress information logged as > "eventsDumpProgress":"49/0". > It should actually log the estimated number of events are denominator but it > is coming as 0 always. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20542) Incremental REPL DUMP progress information log message is incorrect.
[ https://issues.apache.org/jira/browse/HIVE-20542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Bapat updated HIVE-20542: -- Attachment: HIVE-20542.03 Status: Patch Available (was: In Progress) > Incremental REPL DUMP progress information log message is incorrect. > > > Key: HIVE-20542 > URL: https://issues.apache.org/jira/browse/HIVE-20542 > Project: Hive > Issue Type: Bug > Components: repl >Affects Versions: 4.0.0, 3.2.0 >Reporter: Sankar Hariappan >Assignee: Ashutosh Bapat >Priority: Minor > Labels: DR, Replication, pull-request-available > Attachments: HIVE-20542.01.patch, HIVE-20542.02, HIVE-20542.03 > > > Incremental REPL DUMP have the progress information logged as > "eventsDumpProgress":"49/0". > It should actually log the estimated number of events are denominator but it > is coming as 0 always. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20542) Incremental REPL DUMP progress information log message is incorrect.
[ https://issues.apache.org/jira/browse/HIVE-20542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Bapat updated HIVE-20542: -- Status: In Progress (was: Patch Available) > Incremental REPL DUMP progress information log message is incorrect. > > > Key: HIVE-20542 > URL: https://issues.apache.org/jira/browse/HIVE-20542 > Project: Hive > Issue Type: Bug > Components: repl >Affects Versions: 4.0.0, 3.2.0 >Reporter: Sankar Hariappan >Assignee: Ashutosh Bapat >Priority: Minor > Labels: DR, Replication, pull-request-available > Attachments: HIVE-20542.01.patch, HIVE-20542.02, HIVE-20542.03 > > > Incremental REPL DUMP have the progress information logged as > "eventsDumpProgress":"49/0". > It should actually log the estimated number of events are denominator but it > is coming as 0 always. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20542) Incremental REPL DUMP progress information log message is incorrect.
[ https://issues.apache.org/jira/browse/HIVE-20542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Bapat updated HIVE-20542: -- Attachment: HIVE-20542.04 Status: Patch Available (was: In Progress) Addressed whitespace, checkstyle and findbugs comments by Hive-QA. There are two strange things in Hive-QA report # There is one test failure shown in the report here, but jenkins didn't show any test failure. The failing test passed when I ran on my laptop. # One of the tests failed to compile because it didn't find a method in thrift generated code (WarehouseInstance.java:[427,11] cannot find symbol: method setToEventId(java.lang.Long). The test compiled and passed on my laptop. > Incremental REPL DUMP progress information log message is incorrect. > > > Key: HIVE-20542 > URL: https://issues.apache.org/jira/browse/HIVE-20542 > Project: Hive > Issue Type: Bug > Components: repl >Affects Versions: 4.0.0, 3.2.0 >Reporter: Sankar Hariappan >Assignee: Ashutosh Bapat >Priority: Minor > Labels: DR, Replication, pull-request-available > Attachments: HIVE-20542.01.patch, HIVE-20542.02, HIVE-20542.03, > HIVE-20542.04 > > > Incremental REPL DUMP have the progress information logged as > "eventsDumpProgress":"49/0". > It should actually log the estimated number of events are denominator but it > is coming as 0 always. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20542) Incremental REPL DUMP progress information log message is incorrect.
[ https://issues.apache.org/jira/browse/HIVE-20542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sankar Hariappan updated HIVE-20542: Resolution: Fixed Fix Version/s: 4.0.0 Target Version/s: 4.0.0 (was: 4.0.0, 3.2.0) Status: Resolved (was: Patch Available) 04.patch is committed to master! Thanks [~ashutosh.bapat] for the patch! > Incremental REPL DUMP progress information log message is incorrect. > > > Key: HIVE-20542 > URL: https://issues.apache.org/jira/browse/HIVE-20542 > Project: Hive > Issue Type: Bug > Components: repl >Affects Versions: 4.0.0, 3.2.0 >Reporter: Sankar Hariappan >Assignee: Ashutosh Bapat >Priority: Minor > Labels: DR, Replication, pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-20542.01.patch, HIVE-20542.02, HIVE-20542.03, > HIVE-20542.04 > > > Incremental REPL DUMP have the progress information logged as > "eventsDumpProgress":"49/0". > It should actually log the estimated number of events are denominator but it > is coming as 0 always. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
