[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated HIVE-21264: -- Attachment: (was: HIVE-21264.3.patch) > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch, > HIVE-21264.3.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated HIVE-21264: -- Attachment: (was: HIVE-21264.3.patch) > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch, > HIVE-21264.3.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated HIVE-21264: -- Attachment: (was: HIVE-21264.3.patch) > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch, > HIVE-21264.3.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated HIVE-21264: -- Attachment: (was: HIVE-21264.3.patch) > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch, > HIVE-21264.3.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gopal V updated HIVE-21264: --- Resolution: Fixed Fix Version/s: 4.0.0 Status: Resolved (was: Patch Available) Pushed to master, thanks [~belugabehr] > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch, > HIVE-21264.3.patch, HIVE-21264.3.patch, HIVE-21264.3.patch, > HIVE-21264.3.patch, HIVE-21264.3.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated HIVE-21264: -- Status: Open (was: Patch Available) > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch, > HIVE-21264.3.patch, HIVE-21264.3.patch, HIVE-21264.3.patch, > HIVE-21264.3.patch, HIVE-21264.3.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated HIVE-21264: -- Attachment: HIVE-21264.3.patch > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch, > HIVE-21264.3.patch, HIVE-21264.3.patch, HIVE-21264.3.patch, > HIVE-21264.3.patch, HIVE-21264.3.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated HIVE-21264: -- Status: Patch Available (was: Open) > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch, > HIVE-21264.3.patch, HIVE-21264.3.patch, HIVE-21264.3.patch, > HIVE-21264.3.patch, HIVE-21264.3.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated HIVE-21264: -- Status: Patch Available (was: Open) > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch, > HIVE-21264.3.patch, HIVE-21264.3.patch, HIVE-21264.3.patch, HIVE-21264.3.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated HIVE-21264: -- Attachment: HIVE-21264.3.patch > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch, > HIVE-21264.3.patch, HIVE-21264.3.patch, HIVE-21264.3.patch, HIVE-21264.3.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated HIVE-21264: -- Status: Open (was: Patch Available) > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch, > HIVE-21264.3.patch, HIVE-21264.3.patch, HIVE-21264.3.patch, HIVE-21264.3.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated HIVE-21264: -- Status: Patch Available (was: Open) > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch, > HIVE-21264.3.patch, HIVE-21264.3.patch, HIVE-21264.3.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated HIVE-21264: -- Attachment: HIVE-21264.3.patch > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch, > HIVE-21264.3.patch, HIVE-21264.3.patch, HIVE-21264.3.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated HIVE-21264: -- Status: Open (was: Patch Available) > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch, > HIVE-21264.3.patch, HIVE-21264.3.patch, HIVE-21264.3.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated HIVE-21264: -- Status: Patch Available (was: Open) > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch, > HIVE-21264.3.patch, HIVE-21264.3.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated HIVE-21264: -- Attachment: HIVE-21264.3.patch > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch, > HIVE-21264.3.patch, HIVE-21264.3.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated HIVE-21264: -- Status: Open (was: Patch Available) > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch, > HIVE-21264.3.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated HIVE-21264: -- Attachment: HIVE-21264.3.patch > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch, > HIVE-21264.3.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated HIVE-21264: -- Status: Patch Available (was: Open) > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch, > HIVE-21264.3.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated HIVE-21264: -- Status: Open (was: Patch Available) > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HIVE-21264: -- Labels: pull-request-available (was: ) > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch > > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HIVE-21264: --- Status: Open (was: Patch Available) > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Minor > Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch > > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HIVE-21264: --- Attachment: HIVE-21264.2.patch > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Minor > Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch > > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HIVE-21264: --- Status: Patch Available (was: Open) > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Minor > Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch > > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HIVE-21264: --- Description: The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and the length (1-255). {{CharTypeInfo}} objects are often getting cached once they are created. The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are inconsistent. * Make hashcode and equals consistent (and fast) * Simplify the {{getQualifiedName}} implementation and reduce the scope to protected * Other related nits was: The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and the length (1-255). {{CharTypeInfo}} objects are often getting cached once they are created. The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are inconsistent in this regard. * Make hashcode and equals consistent (and fast) * Simplify the {{getQualifiedName}} implementation and reduce the scope to protected * Other related nits > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Minor > Attachments: HIVE-21264.1.patch > > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HIVE-21264: --- Attachment: HIVE-21264.1.patch > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Minor > Attachments: HIVE-21264.1.patch > > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {hashcode()} and {{equals()}} of its sub-classes varchar and char are > inconsistent in this regard. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HIVE-21264: --- Status: Patch Available (was: Open) > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Minor > Attachments: HIVE-21264.1.patch > > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {hashcode()} and {{equals()}} of its sub-classes varchar and char are > inconsistent in this regard. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21264) Improvements Around CharTypeInfo
[ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HIVE-21264: --- Description: The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and the length (1-255). {{CharTypeInfo}} objects are often getting cached once they are created. The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are inconsistent in this regard. * Make hashcode and equals consistent (and fast) * Simplify the {{getQualifiedName}} implementation and reduce the scope to protected * Other related nits was: The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and the length (1-255). {{CharTypeInfo}} objects are often getting cached once they are created. The {hashcode()} and {{equals()}} of its sub-classes varchar and char are inconsistent in this regard. * Make hashcode and equals consistent (and fast) * Simplify the {{getQualifiedName}} implementation and reduce the scope to protected * Other related nits > Improvements Around CharTypeInfo > > > Key: HIVE-21264 > URL: https://issues.apache.org/jira/browse/HIVE-21264 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0, 3.2.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Minor > Attachments: HIVE-21264.1.patch > > > The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and > the length (1-255). {{CharTypeInfo}} objects are often getting cached once > they are created. > The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are > inconsistent in this regard. > * Make hashcode and equals consistent (and fast) > * Simplify the {{getQualifiedName}} implementation and reduce the scope to > protected > * Other related nits -- This message was sent by Atlassian JIRA (v7.6.3#76005)