[jira] [Updated] (HIVE-23015) Fix HIVE_VECTORIZATION_GROUPBY_COMPLEX_TYPES_ENABLED definition

2020-03-12 Thread Peter Varga (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Varga updated HIVE-23015:
---
Attachment: HIVE-23015.patch

> Fix HIVE_VECTORIZATION_GROUPBY_COMPLEX_TYPES_ENABLED definition
> ---
>
> Key: HIVE-23015
> URL: https://issues.apache.org/jira/browse/HIVE-23015
> Project: Hive
>  Issue Type: Bug
>  Components: Vectorization
>Reporter: Peter Vary
>Assignee: Peter Varga
>Priority: Minor
> Attachments: HIVE-23015.patch
>
>
> The _HIVE_VECTORIZATION_GROUPBY_COMPLEX_TYPES_ENABLED_ is definied like this:
> {code}
> HIVE_VECTORIZATION_GROUPBY_COMPLEX_TYPES_ENABLED("hive.vectorized.groupby.complex.types.enabled",
>  true,
> "This flag should be set to true to enable group by vectorization\n" +
> "of aggregations that use complex types.\n",
> "For example, AVG uses a complex type (STRUCT) for partial aggregation 
> results" +
> "The default value is true."),
> {code}
> Notice that the end of the "of aggregations that use complex types.\n" line 
> is a "," instead of "+".
> So this will end up using the following constructor using the second sentence 
> as an "altName" :)
> {code}
> ConfVars(String varname, Object defaultVal, String description, String 
> altName) {
>   this(varname, defaultVal, null, description, true, false, altName);
> }
> {code}
> We should fix this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23015) Fix HIVE_VECTORIZATION_GROUPBY_COMPLEX_TYPES_ENABLED definition

2020-03-12 Thread Peter Varga (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Varga updated HIVE-23015:
---
Status: Patch Available  (was: In Progress)

> Fix HIVE_VECTORIZATION_GROUPBY_COMPLEX_TYPES_ENABLED definition
> ---
>
> Key: HIVE-23015
> URL: https://issues.apache.org/jira/browse/HIVE-23015
> Project: Hive
>  Issue Type: Bug
>  Components: Vectorization
>Reporter: Peter Vary
>Assignee: Peter Varga
>Priority: Minor
> Attachments: HIVE-23015.patch
>
>
> The _HIVE_VECTORIZATION_GROUPBY_COMPLEX_TYPES_ENABLED_ is definied like this:
> {code}
> HIVE_VECTORIZATION_GROUPBY_COMPLEX_TYPES_ENABLED("hive.vectorized.groupby.complex.types.enabled",
>  true,
> "This flag should be set to true to enable group by vectorization\n" +
> "of aggregations that use complex types.\n",
> "For example, AVG uses a complex type (STRUCT) for partial aggregation 
> results" +
> "The default value is true."),
> {code}
> Notice that the end of the "of aggregations that use complex types.\n" line 
> is a "," instead of "+".
> So this will end up using the following constructor using the second sentence 
> as an "altName" :)
> {code}
> ConfVars(String varname, Object defaultVal, String description, String 
> altName) {
>   this(varname, defaultVal, null, description, true, false, altName);
> }
> {code}
> We should fix this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23015) Fix HIVE_VECTORIZATION_GROUPBY_COMPLEX_TYPES_ENABLED definition

2020-03-16 Thread Peter Varga (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Varga updated HIVE-23015:
---
Status: Patch Available  (was: Open)

> Fix HIVE_VECTORIZATION_GROUPBY_COMPLEX_TYPES_ENABLED definition
> ---
>
> Key: HIVE-23015
> URL: https://issues.apache.org/jira/browse/HIVE-23015
> Project: Hive
>  Issue Type: Bug
>  Components: Vectorization
>Reporter: Peter Vary
>Assignee: Peter Varga
>Priority: Minor
> Attachments: HIVE-23015.patch
>
>
> The _HIVE_VECTORIZATION_GROUPBY_COMPLEX_TYPES_ENABLED_ is definied like this:
> {code}
> HIVE_VECTORIZATION_GROUPBY_COMPLEX_TYPES_ENABLED("hive.vectorized.groupby.complex.types.enabled",
>  true,
> "This flag should be set to true to enable group by vectorization\n" +
> "of aggregations that use complex types.\n",
> "For example, AVG uses a complex type (STRUCT) for partial aggregation 
> results" +
> "The default value is true."),
> {code}
> Notice that the end of the "of aggregations that use complex types.\n" line 
> is a "," instead of "+".
> So this will end up using the following constructor using the second sentence 
> as an "altName" :)
> {code}
> ConfVars(String varname, Object defaultVal, String description, String 
> altName) {
>   this(varname, defaultVal, null, description, true, false, altName);
> }
> {code}
> We should fix this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23015) Fix HIVE_VECTORIZATION_GROUPBY_COMPLEX_TYPES_ENABLED definition

2020-03-16 Thread Peter Varga (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Varga updated HIVE-23015:
---
Status: Open  (was: Patch Available)

> Fix HIVE_VECTORIZATION_GROUPBY_COMPLEX_TYPES_ENABLED definition
> ---
>
> Key: HIVE-23015
> URL: https://issues.apache.org/jira/browse/HIVE-23015
> Project: Hive
>  Issue Type: Bug
>  Components: Vectorization
>Reporter: Peter Vary
>Assignee: Peter Varga
>Priority: Minor
> Attachments: HIVE-23015.patch
>
>
> The _HIVE_VECTORIZATION_GROUPBY_COMPLEX_TYPES_ENABLED_ is definied like this:
> {code}
> HIVE_VECTORIZATION_GROUPBY_COMPLEX_TYPES_ENABLED("hive.vectorized.groupby.complex.types.enabled",
>  true,
> "This flag should be set to true to enable group by vectorization\n" +
> "of aggregations that use complex types.\n",
> "For example, AVG uses a complex type (STRUCT) for partial aggregation 
> results" +
> "The default value is true."),
> {code}
> Notice that the end of the "of aggregations that use complex types.\n" line 
> is a "," instead of "+".
> So this will end up using the following constructor using the second sentence 
> as an "altName" :)
> {code}
> ConfVars(String varname, Object defaultVal, String description, String 
> altName) {
>   this(varname, defaultVal, null, description, true, false, altName);
> }
> {code}
> We should fix this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23015) Fix HIVE_VECTORIZATION_GROUPBY_COMPLEX_TYPES_ENABLED definition

2020-03-16 Thread Peter Vary (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Vary updated HIVE-23015:
--
Fix Version/s: 4.0.0
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

Pushed to master.
Thanks for the patch [~pvargacl]!

> Fix HIVE_VECTORIZATION_GROUPBY_COMPLEX_TYPES_ENABLED definition
> ---
>
> Key: HIVE-23015
> URL: https://issues.apache.org/jira/browse/HIVE-23015
> Project: Hive
>  Issue Type: Bug
>  Components: Vectorization
>Reporter: Peter Vary
>Assignee: Peter Varga
>Priority: Minor
> Fix For: 4.0.0
>
> Attachments: HIVE-23015.patch
>
>
> The _HIVE_VECTORIZATION_GROUPBY_COMPLEX_TYPES_ENABLED_ is definied like this:
> {code}
> HIVE_VECTORIZATION_GROUPBY_COMPLEX_TYPES_ENABLED("hive.vectorized.groupby.complex.types.enabled",
>  true,
> "This flag should be set to true to enable group by vectorization\n" +
> "of aggregations that use complex types.\n",
> "For example, AVG uses a complex type (STRUCT) for partial aggregation 
> results" +
> "The default value is true."),
> {code}
> Notice that the end of the "of aggregations that use complex types.\n" line 
> is a "," instead of "+".
> So this will end up using the following constructor using the second sentence 
> as an "altName" :)
> {code}
> ConfVars(String varname, Object defaultVal, String description, String 
> altName) {
>   this(varname, defaultVal, null, description, true, false, altName);
> }
> {code}
> We should fix this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)