[jira] [Updated] (HIVE-23057) ColumnStatsMergerFactory NPE Possible

2020-03-25 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23057:
--
Fix Version/s: 4.0.0
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

Pushed to master.  Thank you for the review [~kgyrtkirk]!

> ColumnStatsMergerFactory NPE Possible
> -
>
> Key: HIVE-23057
> URL: https://issues.apache.org/jira/browse/HIVE-23057
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-23057.1.patch
>
>
> {code:java|title=ColumnStatsMergerFactory.java}
> // make sure that they have the same type
> typeNew = typeNew == typeOld ? typeNew : null;
> switch (typeNew) {
> case BOOLEAN_STATS:
> {code}
> This will throw a NPE if 'typeNew' does not equal 'typeOld'.  Better to throw 
> an Exception with a helpful error message here.
> Also add some cleanup and more null-safety checks in the code to fail-fast.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23057) ColumnStatsMergerFactory NPE Possible

2020-03-24 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23057:
--
Description: 
{code:java|title=ColumnStatsMergerFactory.java}
// make sure that they have the same type
typeNew = typeNew == typeOld ? typeNew : null;
switch (typeNew) {
case BOOLEAN_STATS:
{code}

This will throw a NPE if 'typeNew' does not equal 'typeOld'.  Better to throw 
an Exception with a helpful error message here.

Also add some cleanup and more null-safety checks in the code to fail-fast.

  was:
{code:java|title=ColumnStatsMergerFactory.java}
// make sure that they have the same type
typeNew = typeNew == typeOld ? typeNew : null;
switch (typeNew) {
case BOOLEAN_STATS:
{code}

This will throw a NPE if 'typeNew' does not equal 'typeOld'.  Better to throw 
an Exception with a helpful error message here.


> ColumnStatsMergerFactory NPE Possible
> -
>
> Key: HIVE-23057
> URL: https://issues.apache.org/jira/browse/HIVE-23057
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-23057.1.patch
>
>
> {code:java|title=ColumnStatsMergerFactory.java}
> // make sure that they have the same type
> typeNew = typeNew == typeOld ? typeNew : null;
> switch (typeNew) {
> case BOOLEAN_STATS:
> {code}
> This will throw a NPE if 'typeNew' does not equal 'typeOld'.  Better to throw 
> an Exception with a helpful error message here.
> Also add some cleanup and more null-safety checks in the code to fail-fast.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23057) ColumnStatsMergerFactory NPE Possible

2020-03-20 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23057:
--
Status: Patch Available  (was: Open)

> ColumnStatsMergerFactory NPE Possible
> -
>
> Key: HIVE-23057
> URL: https://issues.apache.org/jira/browse/HIVE-23057
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-23057.1.patch
>
>
> {code:java|title=ColumnStatsMergerFactory.java}
> // make sure that they have the same type
> typeNew = typeNew == typeOld ? typeNew : null;
> switch (typeNew) {
> case BOOLEAN_STATS:
> {code}
> This will throw a NPE if 'typeNew' does not equal 'typeOld'.  Better to throw 
> an Exception with a helpful error message here.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23057) ColumnStatsMergerFactory NPE Possible

2020-03-20 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23057:
--
Attachment: HIVE-23057.1.patch

> ColumnStatsMergerFactory NPE Possible
> -
>
> Key: HIVE-23057
> URL: https://issues.apache.org/jira/browse/HIVE-23057
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-23057.1.patch
>
>
> {code:java|title=ColumnStatsMergerFactory.java}
> // make sure that they have the same type
> typeNew = typeNew == typeOld ? typeNew : null;
> switch (typeNew) {
> case BOOLEAN_STATS:
> {code}
> This will throw a NPE if 'typeNew' does not equal 'typeOld'.  Better to throw 
> an Exception with a helpful error message here.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)