[jira] [Updated] (HIVE-23108) Cleanup HiveBaseResultSet.java

2020-05-05 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23108:
--
Fix Version/s: 4.0.0
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

Pushed to master! Thanks as always [~pvary] for the review.

> Cleanup HiveBaseResultSet.java
> --
>
> Key: HIVE-23108
> URL: https://issues.apache.org/jira/browse/HIVE-23108
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Fix For: 4.0.0
>
> Attachments: HIVE-23108.1.patch, HIVE-23108.2.patch, 
> HIVE-23108.3.patch, HIVE-23108.4.patch, HIVE-23108.5.patch, HIVE-23108.5.patch
>
>
> * Unify the code (there are several implementations of the same thing)
>  * Added better error messages
>  * In some cases, the code was throwing RuntimeExceptions which is against 
> the JDBC Spec
>  * Make findColumn a bit more streamlined
>  * Remove non-javadoc comments
>  * Add {{@Override}} annotations where appropriate
>  * Formatting changes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23108) Cleanup HiveBaseResultSet.java

2020-05-05 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23108:
--
Attachment: (was: HIVE-23108.5.patch)

> Cleanup HiveBaseResultSet.java
> --
>
> Key: HIVE-23108
> URL: https://issues.apache.org/jira/browse/HIVE-23108
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-23108.1.patch, HIVE-23108.2.patch, 
> HIVE-23108.3.patch, HIVE-23108.4.patch, HIVE-23108.5.patch, HIVE-23108.5.patch
>
>
> * Unify the code (there are several implementations of the same thing)
>  * Added better error messages
>  * In some cases, the code was throwing RuntimeExceptions which is against 
> the JDBC Spec
>  * Make findColumn a bit more streamlined
>  * Remove non-javadoc comments
>  * Add {{@Override}} annotations where appropriate
>  * Formatting changes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23108) Cleanup HiveBaseResultSet.java

2020-04-30 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23108:
--
Attachment: HIVE-23108.5.patch

> Cleanup HiveBaseResultSet.java
> --
>
> Key: HIVE-23108
> URL: https://issues.apache.org/jira/browse/HIVE-23108
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-23108.1.patch, HIVE-23108.2.patch, 
> HIVE-23108.3.patch, HIVE-23108.4.patch, HIVE-23108.5.patch, 
> HIVE-23108.5.patch, HIVE-23108.5.patch
>
>
> * Unify the code (there are several implementations of the same thing)
>  * Added better error messages
>  * In some cases, the code was throwing RuntimeExceptions which is against 
> the JDBC Spec
>  * Make findColumn a bit more streamlined
>  * Remove non-javadoc comments
>  * Add {{@Override}} annotations where appropriate
>  * Formatting changes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23108) Cleanup HiveBaseResultSet.java

2020-04-30 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23108:
--
Attachment: HIVE-23108.5.patch

> Cleanup HiveBaseResultSet.java
> --
>
> Key: HIVE-23108
> URL: https://issues.apache.org/jira/browse/HIVE-23108
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-23108.1.patch, HIVE-23108.2.patch, 
> HIVE-23108.3.patch, HIVE-23108.4.patch, HIVE-23108.5.patch, HIVE-23108.5.patch
>
>
> * Unify the code (there are several implementations of the same thing)
>  * Added better error messages
>  * In some cases, the code was throwing RuntimeExceptions which is against 
> the JDBC Spec
>  * Make findColumn a bit more streamlined
>  * Remove non-javadoc comments
>  * Add {{@Override}} annotations where appropriate
>  * Formatting changes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23108) Cleanup HiveBaseResultSet.java

2020-04-29 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23108:
--
Attachment: HIVE-23108.5.patch

> Cleanup HiveBaseResultSet.java
> --
>
> Key: HIVE-23108
> URL: https://issues.apache.org/jira/browse/HIVE-23108
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-23108.1.patch, HIVE-23108.2.patch, 
> HIVE-23108.3.patch, HIVE-23108.4.patch, HIVE-23108.5.patch
>
>
> * Unify the code (there are several implementations of the same thing)
>  * Added better error messages
>  * In some cases, the code was throwing RuntimeExceptions which is against 
> the JDBC Spec
>  * Make findColumn a bit more streamlined
>  * Remove non-javadoc comments
>  * Add {{@Override}} annotations where appropriate
>  * Formatting changes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23108) Cleanup HiveBaseResultSet.java

2020-04-28 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23108:
--
Attachment: HIVE-23108.4.patch

> Cleanup HiveBaseResultSet.java
> --
>
> Key: HIVE-23108
> URL: https://issues.apache.org/jira/browse/HIVE-23108
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-23108.1.patch, HIVE-23108.2.patch, 
> HIVE-23108.3.patch, HIVE-23108.4.patch
>
>
> * Unify the code (there are several implementations of the same thing)
>  * Added better error messages
>  * In some cases, the code was throwing RuntimeExceptions which is against 
> the JDBC Spec
>  * Make findColumn a bit more streamlined
>  * Remove non-javadoc comments
>  * Add {{@Override}} annotations where appropriate
>  * Formatting changes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23108) Cleanup HiveBaseResultSet.java

2020-04-27 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23108:
--
Attachment: HIVE-23108.3.patch

> Cleanup HiveBaseResultSet.java
> --
>
> Key: HIVE-23108
> URL: https://issues.apache.org/jira/browse/HIVE-23108
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-23108.1.patch, HIVE-23108.2.patch, 
> HIVE-23108.3.patch
>
>
> * Unify the code (there are several implementations of the same thing)
>  * Added better error messages
>  * In some cases, the code was throwing RuntimeExceptions which is against 
> the JDBC Spec
>  * Make findColumn a bit more streamlined
>  * Remove non-javadoc comments
>  * Add {{@Override}} annotations where appropriate
>  * Formatting changes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23108) Cleanup HiveBaseResultSet.java

2020-04-27 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23108:
--
Attachment: HIVE-23108.2.patch

> Cleanup HiveBaseResultSet.java
> --
>
> Key: HIVE-23108
> URL: https://issues.apache.org/jira/browse/HIVE-23108
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-23108.1.patch, HIVE-23108.2.patch
>
>
> * Unify the code (there are several implementations of the same thing)
>  * Added better error messages
>  * In some cases, the code was throwing RuntimeExceptions which is against 
> the JDBC Spec
>  * Make findColumn a bit more streamlined
>  * Remove non-javadoc comments
>  * Add {{@Override}} annotations where appropriate
>  * Formatting changes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23108) Cleanup HiveBaseResultSet.java

2020-04-03 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23108:
--
Status: Patch Available  (was: Open)

> Cleanup HiveBaseResultSet.java
> --
>
> Key: HIVE-23108
> URL: https://issues.apache.org/jira/browse/HIVE-23108
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-23108.1.patch
>
>
> * Unify the code (there are several implementations of the same thing)
>  * Added better error messages
>  * In some cases, the code was throwing RuntimeExceptions which is against 
> the JDBC Spec
>  * Make findColumn a bit more streamlined
>  * Remove non-javadoc comments
>  * Add {{@Override}} annotations where appropriate
>  * Formatting changes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23108) Cleanup HiveBaseResultSet.java

2020-03-30 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23108:
--
Attachment: HIVE-23108.1.patch

> Cleanup HiveBaseResultSet.java
> --
>
> Key: HIVE-23108
> URL: https://issues.apache.org/jira/browse/HIVE-23108
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-23108.1.patch
>
>
> * Unify the code (there are several implementations of the same thing)
> * Added better error messages
> * In some cases, the code was throwing RuntimeExceptions which is against the 
> JDBC Spec
> * Make findColumn a bit more streamlined
> * Remove non-javadoc comments
> * Add {{@Override}} annotations where appropriate



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23108) Cleanup HiveBaseResultSet.java

2020-03-30 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23108:
--
Description: 
* Unify the code (there are several implementations of the same thing)
 * Added better error messages
 * In some cases, the code was throwing RuntimeExceptions which is against the 
JDBC Spec
 * Make findColumn a bit more streamlined
 * Remove non-javadoc comments
 * Add {{@Override}} annotations where appropriate
 * Formatting changes

  was:
* Unify the code (there are several implementations of the same thing)
* Added better error messages
* In some cases, the code was throwing RuntimeExceptions which is against the 
JDBC Spec
* Make findColumn a bit more streamlined
* Remove non-javadoc comments
* Add {{@Override}} annotations where appropriate


> Cleanup HiveBaseResultSet.java
> --
>
> Key: HIVE-23108
> URL: https://issues.apache.org/jira/browse/HIVE-23108
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-23108.1.patch
>
>
> * Unify the code (there are several implementations of the same thing)
>  * Added better error messages
>  * In some cases, the code was throwing RuntimeExceptions which is against 
> the JDBC Spec
>  * Make findColumn a bit more streamlined
>  * Remove non-javadoc comments
>  * Add {{@Override}} annotations where appropriate
>  * Formatting changes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)