[jira] [Updated] (HIVE-28135) Remove HiveIOExceptionHandlerUtil

2024-03-26 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-28135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated HIVE-28135:
--
Labels: pull-request-available  (was: )

> Remove HiveIOExceptionHandlerUtil
> -
>
> Key: HIVE-28135
> URL: https://issues.apache.org/jira/browse/HIVE-28135
> Project: Hive
>  Issue Type: Improvement
>Reporter: László Bodor
>Assignee: László Bodor
>Priority: Major
>  Labels: pull-request-available
>
> 1. old history, not really touched:
> https://github.com/apache/hive/commits/master/shims/common/src/main/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerUtil.java
> 2. cannot see a clear usecase
> {code}
> RecordReader innerReader = null;
> try {
>   innerReader = inputFormat.getRecordReader(targetSplit, job,
>   reporter);
> } catch (Exception e) {
>   innerReader = HiveIOExceptionHandlerUtil
>   .handleRecordReaderCreationException(e, job);
> }
> {code}
> define an exception handler to magically create a reader? this looks so hacky
> 3. cannot find and useful usage of "hive.io.exception.handlers" by googling
> 4. swallows exception as described in HIVE-28133



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HIVE-28135) Remove HiveIOExceptionHandlerUtil

2024-03-20 Thread Jira


 [ 
https://issues.apache.org/jira/browse/HIVE-28135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

László Bodor updated HIVE-28135:

Description: 
1. old history, not really touched:
https://github.com/apache/hive/commits/master/shims/common/src/main/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerUtil.java

2. cannot see a clear usecase

3. cannot find and useful usage of "hive.io.exception.handlers" by googling

4. swallows exception as described in HIVE-28133

> Remove HiveIOExceptionHandlerUtil
> -
>
> Key: HIVE-28135
> URL: https://issues.apache.org/jira/browse/HIVE-28135
> Project: Hive
>  Issue Type: Improvement
>Reporter: László Bodor
>Priority: Major
>
> 1. old history, not really touched:
> https://github.com/apache/hive/commits/master/shims/common/src/main/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerUtil.java
> 2. cannot see a clear usecase
> 3. cannot find and useful usage of "hive.io.exception.handlers" by googling
> 4. swallows exception as described in HIVE-28133



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HIVE-28135) Remove HiveIOExceptionHandlerUtil

2024-03-20 Thread Jira


 [ 
https://issues.apache.org/jira/browse/HIVE-28135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

László Bodor updated HIVE-28135:

Description: 
1. old history, not really touched:
https://github.com/apache/hive/commits/master/shims/common/src/main/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerUtil.java

2. cannot see a clear usecase
{code}
RecordReader innerReader = null;
try {
  innerReader = inputFormat.getRecordReader(targetSplit, job,
  reporter);
} catch (Exception e) {
  innerReader = HiveIOExceptionHandlerUtil
  .handleRecordReaderCreationException(e, job);
}
{code}
define an exception handler to magically create a reader? this looks so hacky

3. cannot find and useful usage of "hive.io.exception.handlers" by googling

4. swallows exception as described in HIVE-28133



  was:
1. old history, not really touched:
https://github.com/apache/hive/commits/master/shims/common/src/main/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerUtil.java

2. cannot see a clear usecase

3. cannot find and useful usage of "hive.io.exception.handlers" by googling

4. swallows exception as described in HIVE-28133


> Remove HiveIOExceptionHandlerUtil
> -
>
> Key: HIVE-28135
> URL: https://issues.apache.org/jira/browse/HIVE-28135
> Project: Hive
>  Issue Type: Improvement
>Reporter: László Bodor
>Priority: Major
>
> 1. old history, not really touched:
> https://github.com/apache/hive/commits/master/shims/common/src/main/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerUtil.java
> 2. cannot see a clear usecase
> {code}
> RecordReader innerReader = null;
> try {
>   innerReader = inputFormat.getRecordReader(targetSplit, job,
>   reporter);
> } catch (Exception e) {
>   innerReader = HiveIOExceptionHandlerUtil
>   .handleRecordReaderCreationException(e, job);
> }
> {code}
> define an exception handler to magically create a reader? this looks so hacky
> 3. cannot find and useful usage of "hive.io.exception.handlers" by googling
> 4. swallows exception as described in HIVE-28133



--
This message was sent by Atlassian Jira
(v8.20.10#820010)