[jira] [Updated] (HIVE-7180) BufferedReader is not closed in MetaStoreSchemaInfo ctor

2015-06-27 Thread Alexander Pivovarov (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HIVE-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Pivovarov updated HIVE-7180:
--
Component/s: Metastore

> BufferedReader is not closed in MetaStoreSchemaInfo ctor
> 
>
> Key: HIVE-7180
> URL: https://issues.apache.org/jira/browse/HIVE-7180
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore
>Affects Versions: 0.13.1
>Reporter: Ted Yu
>Assignee: Alexander Pivovarov
>Priority: Minor
> Attachments: HIVE-7180.3.patch, HIVE-7180.4.patch, HIVE-7180.patch, 
> HIVE-7180_001.patch
>
>
> Here is related code:
> {code}
>   BufferedReader bfReader =
> new BufferedReader(new FileReader(upgradeListFile));
>   String currSchemaVersion;
>   while ((currSchemaVersion = bfReader.readLine()) != null) {
> upgradeOrderList.add(currSchemaVersion.trim());
> {code}
> BufferedReader / FileReader should be closed upon return from ctor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HIVE-7180) BufferedReader is not closed in MetaStoreSchemaInfo ctor

2015-06-27 Thread Alexander Pivovarov (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HIVE-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Pivovarov updated HIVE-7180:
--
Labels:   (was: patch)

> BufferedReader is not closed in MetaStoreSchemaInfo ctor
> 
>
> Key: HIVE-7180
> URL: https://issues.apache.org/jira/browse/HIVE-7180
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore
>Affects Versions: 0.13.1
>Reporter: Ted Yu
>Assignee: Alexander Pivovarov
>Priority: Minor
> Attachments: HIVE-7180.3.patch, HIVE-7180.4.patch, HIVE-7180.patch, 
> HIVE-7180_001.patch
>
>
> Here is related code:
> {code}
>   BufferedReader bfReader =
> new BufferedReader(new FileReader(upgradeListFile));
>   String currSchemaVersion;
>   while ((currSchemaVersion = bfReader.readLine()) != null) {
> upgradeOrderList.add(currSchemaVersion.trim());
> {code}
> BufferedReader / FileReader should be closed upon return from ctor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HIVE-7180) BufferedReader is not closed in MetaStoreSchemaInfo ctor

2015-06-27 Thread Alexander Pivovarov (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HIVE-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Pivovarov updated HIVE-7180:
--
Attachment: HIVE-7180.4.patch

patch #4
- using java 7 try-with-resources

> BufferedReader is not closed in MetaStoreSchemaInfo ctor
> 
>
> Key: HIVE-7180
> URL: https://issues.apache.org/jira/browse/HIVE-7180
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 0.13.1
>Reporter: Ted Yu
>Assignee: Alexander Pivovarov
>Priority: Minor
>  Labels: patch
> Attachments: HIVE-7180.3.patch, HIVE-7180.4.patch, HIVE-7180.patch, 
> HIVE-7180_001.patch
>
>
> Here is related code:
> {code}
>   BufferedReader bfReader =
> new BufferedReader(new FileReader(upgradeListFile));
>   String currSchemaVersion;
>   while ((currSchemaVersion = bfReader.readLine()) != null) {
> upgradeOrderList.add(currSchemaVersion.trim());
> {code}
> BufferedReader / FileReader should be closed upon return from ctor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HIVE-7180) BufferedReader is not closed in MetaStoreSchemaInfo ctor

2015-06-26 Thread Alexander Pivovarov (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HIVE-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Pivovarov updated HIVE-7180:
--
Attachment: HIVE-7180.3.patch

patch #3
- add finally block and close reader quietly

> BufferedReader is not closed in MetaStoreSchemaInfo ctor
> 
>
> Key: HIVE-7180
> URL: https://issues.apache.org/jira/browse/HIVE-7180
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 0.13.1
>Reporter: Ted Yu
>Assignee: Alexander Pivovarov
>Priority: Minor
>  Labels: patch
> Attachments: HIVE-7180.3.patch, HIVE-7180.patch, HIVE-7180_001.patch
>
>
> Here is related code:
> {code}
>   BufferedReader bfReader =
> new BufferedReader(new FileReader(upgradeListFile));
>   String currSchemaVersion;
>   while ((currSchemaVersion = bfReader.readLine()) != null) {
> upgradeOrderList.add(currSchemaVersion.trim());
> {code}
> BufferedReader / FileReader should be closed upon return from ctor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HIVE-7180) BufferedReader is not closed in MetaStoreSchemaInfo ctor

2015-06-09 Thread Ted Yu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HIVE-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HIVE-7180:
-
Description: 
Here is related code:
{code}
  BufferedReader bfReader =
new BufferedReader(new FileReader(upgradeListFile));
  String currSchemaVersion;
  while ((currSchemaVersion = bfReader.readLine()) != null) {
upgradeOrderList.add(currSchemaVersion.trim());
{code}
BufferedReader / FileReader should be closed upon return from ctor.

  was:
Here is related code:
{code}
  BufferedReader bfReader =
new BufferedReader(new FileReader(upgradeListFile));
  String currSchemaVersion;
  while ((currSchemaVersion = bfReader.readLine()) != null) {
upgradeOrderList.add(currSchemaVersion.trim());
{code}

BufferedReader / FileReader should be closed upon return from ctor.


> BufferedReader is not closed in MetaStoreSchemaInfo ctor
> 
>
> Key: HIVE-7180
> URL: https://issues.apache.org/jira/browse/HIVE-7180
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 0.13.1
>Reporter: Ted Yu
>Assignee: skrho
>Priority: Minor
>  Labels: patch
> Attachments: HIVE-7180.patch, HIVE-7180_001.patch
>
>
> Here is related code:
> {code}
>   BufferedReader bfReader =
> new BufferedReader(new FileReader(upgradeListFile));
>   String currSchemaVersion;
>   while ((currSchemaVersion = bfReader.readLine()) != null) {
> upgradeOrderList.add(currSchemaVersion.trim());
> {code}
> BufferedReader / FileReader should be closed upon return from ctor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HIVE-7180) BufferedReader is not closed in MetaStoreSchemaInfo ctor

2015-05-17 Thread Ted Yu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HIVE-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HIVE-7180:
-
Description: 
Here is related code:
{code}
  BufferedReader bfReader =
new BufferedReader(new FileReader(upgradeListFile));
  String currSchemaVersion;
  while ((currSchemaVersion = bfReader.readLine()) != null) {
upgradeOrderList.add(currSchemaVersion.trim());
{code}

BufferedReader / FileReader should be closed upon return from ctor.

  was:
Here is related code:
{code}
  BufferedReader bfReader =
new BufferedReader(new FileReader(upgradeListFile));
  String currSchemaVersion;
  while ((currSchemaVersion = bfReader.readLine()) != null) {
upgradeOrderList.add(currSchemaVersion.trim());
{code}
BufferedReader / FileReader should be closed upon return from ctor.


> BufferedReader is not closed in MetaStoreSchemaInfo ctor
> 
>
> Key: HIVE-7180
> URL: https://issues.apache.org/jira/browse/HIVE-7180
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 0.13.1
>Reporter: Ted Yu
>Assignee: skrho
>Priority: Minor
>  Labels: patch
> Attachments: HIVE-7180.patch, HIVE-7180_001.patch
>
>
> Here is related code:
> {code}
>   BufferedReader bfReader =
> new BufferedReader(new FileReader(upgradeListFile));
>   String currSchemaVersion;
>   while ((currSchemaVersion = bfReader.readLine()) != null) {
> upgradeOrderList.add(currSchemaVersion.trim());
> {code}
> BufferedReader / FileReader should be closed upon return from ctor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)