[jira] [Work logged] (HIVE-23935) Fetching primaryKey through beeline fails with NPE
[ https://issues.apache.org/jira/browse/HIVE-23935?focusedWorklogId=843441&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-843441 ] ASF GitHub Bot logged work on HIVE-23935: - Author: ASF GitHub Bot Created on: 03/Feb/23 10:24 Start Date: 03/Feb/23 10:24 Worklog Time Spent: 10m Work Description: ayushtkn merged PR #4009: URL: https://github.com/apache/hive/pull/4009 Issue Time Tracking --- Worklog Id: (was: 843441) Time Spent: 3h 50m (was: 3h 40m) > Fetching primaryKey through beeline fails with NPE > -- > > Key: HIVE-23935 > URL: https://issues.apache.org/jira/browse/HIVE-23935 > Project: Hive > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Time Spent: 3h 50m > Remaining Estimate: 0h > > Fetching PrimaryKey of a table through Beeline !primarykey fails with NPE > {noformat} > 0: jdbc:hive2://localhost:1> !primarykeys Persons > Error: MetaException(message:java.lang.NullPointerException) (state=,code=0) > org.apache.hive.service.cli.HiveSQLException: > MetaException(message:java.lang.NullPointerException) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:360) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:351) > at > org.apache.hive.jdbc.HiveDatabaseMetaData.getPrimaryKeys(HiveDatabaseMetaData.java:573) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hive.beeline.Reflector.invoke(Reflector.java:89) > at org.apache.hive.beeline.Commands.metadata(Commands.java:125) > at org.apache.hive.beeline.Commands.primarykeys(Commands.java:231) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.hive.beeline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:57) > at > org.apache.hive.beeline.BeeLine.execCommandWithPrefix(BeeLine.java:1465) > at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:1504) > at org.apache.hive.beeline.BeeLine.execute(BeeLine.java:1364) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1134) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1082) > at > org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:546) > at org.apache.hive.beeline.BeeLine.main(BeeLine.java:528) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hadoop.util.RunJar.run(RunJar.java:323) > at org.apache.hadoop.util.RunJar.main(RunJar.java:236){noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-23935) Fetching primaryKey through beeline fails with NPE
[ https://issues.apache.org/jira/browse/HIVE-23935?focusedWorklogId=843406&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-843406 ] ASF GitHub Bot logged work on HIVE-23935: - Author: ASF GitHub Bot Created on: 03/Feb/23 09:05 Start Date: 03/Feb/23 09:05 Worklog Time Spent: 10m Work Description: abstractdog commented on code in PR #4009: URL: https://github.com/apache/hive/pull/4009#discussion_r1095518262 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java: ## @@ -12025,7 +12025,9 @@ private List getPrimaryKeysInternal(final String catName, final String db_name_input, final String tbl_name_input) throws MetaException, NoSuchObjectException { -final String db_name = normalizeIdentifier(db_name_input); +final String db_name = StringUtils.isNotBlank(db_name_input) ? Review Comment: oh, this is sooo...hive :) I don't think we can do anything instantly about this, so my approval still holds Issue Time Tracking --- Worklog Id: (was: 843406) Time Spent: 3h 40m (was: 3.5h) > Fetching primaryKey through beeline fails with NPE > -- > > Key: HIVE-23935 > URL: https://issues.apache.org/jira/browse/HIVE-23935 > Project: Hive > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Time Spent: 3h 40m > Remaining Estimate: 0h > > Fetching PrimaryKey of a table through Beeline !primarykey fails with NPE > {noformat} > 0: jdbc:hive2://localhost:1> !primarykeys Persons > Error: MetaException(message:java.lang.NullPointerException) (state=,code=0) > org.apache.hive.service.cli.HiveSQLException: > MetaException(message:java.lang.NullPointerException) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:360) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:351) > at > org.apache.hive.jdbc.HiveDatabaseMetaData.getPrimaryKeys(HiveDatabaseMetaData.java:573) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hive.beeline.Reflector.invoke(Reflector.java:89) > at org.apache.hive.beeline.Commands.metadata(Commands.java:125) > at org.apache.hive.beeline.Commands.primarykeys(Commands.java:231) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.hive.beeline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:57) > at > org.apache.hive.beeline.BeeLine.execCommandWithPrefix(BeeLine.java:1465) > at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:1504) > at org.apache.hive.beeline.BeeLine.execute(BeeLine.java:1364) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1134) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1082) > at > org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:546) > at org.apache.hive.beeline.BeeLine.main(BeeLine.java:528) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hadoop.util.RunJar.run(RunJar.java:323) > at org.apache.hadoop.util.RunJar.main(RunJar.java:236){noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-23935) Fetching primaryKey through beeline fails with NPE
[ https://issues.apache.org/jira/browse/HIVE-23935?focusedWorklogId=843375&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-843375 ] ASF GitHub Bot logged work on HIVE-23935: - Author: ASF GitHub Bot Created on: 03/Feb/23 05:04 Start Date: 03/Feb/23 05:04 Worklog Time Spent: 10m Work Description: ayushtkn commented on PR #4009: URL: https://github.com/apache/hive/pull/4009#issuecomment-1414971020 Got a green build now. @abstractdog can you have a look again, the code changed post your approval, just to be sure you are ok going forward Issue Time Tracking --- Worklog Id: (was: 843375) Time Spent: 3.5h (was: 3h 20m) > Fetching primaryKey through beeline fails with NPE > -- > > Key: HIVE-23935 > URL: https://issues.apache.org/jira/browse/HIVE-23935 > Project: Hive > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Time Spent: 3.5h > Remaining Estimate: 0h > > Fetching PrimaryKey of a table through Beeline !primarykey fails with NPE > {noformat} > 0: jdbc:hive2://localhost:1> !primarykeys Persons > Error: MetaException(message:java.lang.NullPointerException) (state=,code=0) > org.apache.hive.service.cli.HiveSQLException: > MetaException(message:java.lang.NullPointerException) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:360) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:351) > at > org.apache.hive.jdbc.HiveDatabaseMetaData.getPrimaryKeys(HiveDatabaseMetaData.java:573) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hive.beeline.Reflector.invoke(Reflector.java:89) > at org.apache.hive.beeline.Commands.metadata(Commands.java:125) > at org.apache.hive.beeline.Commands.primarykeys(Commands.java:231) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.hive.beeline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:57) > at > org.apache.hive.beeline.BeeLine.execCommandWithPrefix(BeeLine.java:1465) > at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:1504) > at org.apache.hive.beeline.BeeLine.execute(BeeLine.java:1364) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1134) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1082) > at > org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:546) > at org.apache.hive.beeline.BeeLine.main(BeeLine.java:528) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hadoop.util.RunJar.run(RunJar.java:323) > at org.apache.hadoop.util.RunJar.main(RunJar.java:236){noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-23935) Fetching primaryKey through beeline fails with NPE
[ https://issues.apache.org/jira/browse/HIVE-23935?focusedWorklogId=843322&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-843322 ] ASF GitHub Bot logged work on HIVE-23935: - Author: ASF GitHub Bot Created on: 02/Feb/23 21:22 Start Date: 02/Feb/23 21:22 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #4009: URL: https://github.com/apache/hive/pull/4009#issuecomment-1414390321 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4009) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4009&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4009&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4009&resolved=false&types=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4009&metric=coverage&view=list) No Coverage information [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4009&metric=duplicated_lines_density&view=list) No Duplication information Issue Time Tracking --- Worklog Id: (was: 843322) Time Spent: 3h 20m (was: 3h 10m) > Fetching primaryKey through beeline fails with NPE > -- > > Key: HIVE-23935 > URL: https://issues.apache.org/jira/browse/HIVE-23935 > Project: Hive > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Time Spent: 3h 20m > Remaining Estimate: 0h > > Fetching PrimaryKey of a table through Beeline !primarykey fails with NPE > {noformat} > 0: jdbc:hive2://localhost:1> !primarykeys Persons > Error: MetaException(message:java.lang.NullPointerException) (state=,code=0) > org.apache.hive.service.cli.HiveSQLException: > MetaException(message:java.lang.NullPointerException) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:360) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:351) > at > org.apache.hive.jdbc.HiveDatabaseMetaData.getPrimaryKeys(HiveDatabaseMetaData.java:573) > at sun.reflect.NativeMethodAccessorImpl.invoke
[jira] [Work logged] (HIVE-23935) Fetching primaryKey through beeline fails with NPE
[ https://issues.apache.org/jira/browse/HIVE-23935?focusedWorklogId=843316&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-843316 ] ASF GitHub Bot logged work on HIVE-23935: - Author: ASF GitHub Bot Created on: 02/Feb/23 19:41 Start Date: 02/Feb/23 19:41 Worklog Time Spent: 10m Work Description: ayushtkn commented on code in PR #4009: URL: https://github.com/apache/hive/pull/4009#discussion_r1095010784 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java: ## @@ -12025,7 +12025,9 @@ private List getPrimaryKeysInternal(final String catName, final String db_name_input, final String tbl_name_input) throws MetaException, NoSuchObjectException { -final String db_name = normalizeIdentifier(db_name_input); +final String db_name = StringUtils.isNotBlank(db_name_input) ? Review Comment: >what about fixing this in normalizeIdentifier instead? This backfired 😅 This method is widely used, has some 500+ usage and some tests explicitly asks for an NPE which later gets converted to MetaException, because of this it doesn't fail here rather in the end fails with NoSuchObjectException in many cases. Reverting back to original for now to fix this only Issue Time Tracking --- Worklog Id: (was: 843316) Time Spent: 3h 10m (was: 3h) > Fetching primaryKey through beeline fails with NPE > -- > > Key: HIVE-23935 > URL: https://issues.apache.org/jira/browse/HIVE-23935 > Project: Hive > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Time Spent: 3h 10m > Remaining Estimate: 0h > > Fetching PrimaryKey of a table through Beeline !primarykey fails with NPE > {noformat} > 0: jdbc:hive2://localhost:1> !primarykeys Persons > Error: MetaException(message:java.lang.NullPointerException) (state=,code=0) > org.apache.hive.service.cli.HiveSQLException: > MetaException(message:java.lang.NullPointerException) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:360) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:351) > at > org.apache.hive.jdbc.HiveDatabaseMetaData.getPrimaryKeys(HiveDatabaseMetaData.java:573) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hive.beeline.Reflector.invoke(Reflector.java:89) > at org.apache.hive.beeline.Commands.metadata(Commands.java:125) > at org.apache.hive.beeline.Commands.primarykeys(Commands.java:231) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.hive.beeline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:57) > at > org.apache.hive.beeline.BeeLine.execCommandWithPrefix(BeeLine.java:1465) > at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:1504) > at org.apache.hive.beeline.BeeLine.execute(BeeLine.java:1364) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1134) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1082) > at > org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:546) > at org.apache.hive.beeline.BeeLine.main(BeeLine.java:528) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hadoop.util.RunJar.run(RunJar.java:323) > at org.apache.hadoop.util.RunJar.main(RunJar.java:236){noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-23935) Fetching primaryKey through beeline fails with NPE
[ https://issues.apache.org/jira/browse/HIVE-23935?focusedWorklogId=843287&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-843287 ] ASF GitHub Bot logged work on HIVE-23935: - Author: ASF GitHub Bot Created on: 02/Feb/23 16:47 Start Date: 02/Feb/23 16:47 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #4009: URL: https://github.com/apache/hive/pull/4009#issuecomment-1414048193 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4009) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4009&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4009&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4009&resolved=false&types=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4009&metric=coverage&view=list) No Coverage information [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4009&metric=duplicated_lines_density&view=list) No Duplication information Issue Time Tracking --- Worklog Id: (was: 843287) Time Spent: 3h (was: 2h 50m) > Fetching primaryKey through beeline fails with NPE > -- > > Key: HIVE-23935 > URL: https://issues.apache.org/jira/browse/HIVE-23935 > Project: Hive > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Time Spent: 3h > Remaining Estimate: 0h > > Fetching PrimaryKey of a table through Beeline !primarykey fails with NPE > {noformat} > 0: jdbc:hive2://localhost:1> !primarykeys Persons > Error: MetaException(message:java.lang.NullPointerException) (state=,code=0) > org.apache.hive.service.cli.HiveSQLException: > MetaException(message:java.lang.NullPointerException) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:360) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:351) > at > org.apache.hive.jdbc.HiveDatabaseMetaData.getPrimaryKeys(HiveDatabaseMetaData.java:573) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
[jira] [Work logged] (HIVE-23935) Fetching primaryKey through beeline fails with NPE
[ https://issues.apache.org/jira/browse/HIVE-23935?focusedWorklogId=843172&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-843172 ] ASF GitHub Bot logged work on HIVE-23935: - Author: ASF GitHub Bot Created on: 02/Feb/23 11:20 Start Date: 02/Feb/23 11:20 Worklog Time Spent: 10m Work Description: abstractdog commented on code in PR #4009: URL: https://github.com/apache/hive/pull/4009#discussion_r1094387999 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java: ## @@ -12025,7 +12025,9 @@ private List getPrimaryKeysInternal(final String catName, final String db_name_input, final String tbl_name_input) throws MetaException, NoSuchObjectException { -final String db_name = normalizeIdentifier(db_name_input); +final String db_name = StringUtils.isNotBlank(db_name_input) ? Review Comment: 1. can you please fix db_name_input and tbl_name_input naming nightmare as you're touching this part? 2. what about fixing this in normalizeIdentifier instead? ``` return identifier == null ? null : identifier.trim().toLowerCase(); ``` Issue Time Tracking --- Worklog Id: (was: 843172) Time Spent: 2h 50m (was: 2h 40m) > Fetching primaryKey through beeline fails with NPE > -- > > Key: HIVE-23935 > URL: https://issues.apache.org/jira/browse/HIVE-23935 > Project: Hive > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Time Spent: 2h 50m > Remaining Estimate: 0h > > Fetching PrimaryKey of a table through Beeline !primarykey fails with NPE > {noformat} > 0: jdbc:hive2://localhost:1> !primarykeys Persons > Error: MetaException(message:java.lang.NullPointerException) (state=,code=0) > org.apache.hive.service.cli.HiveSQLException: > MetaException(message:java.lang.NullPointerException) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:360) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:351) > at > org.apache.hive.jdbc.HiveDatabaseMetaData.getPrimaryKeys(HiveDatabaseMetaData.java:573) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hive.beeline.Reflector.invoke(Reflector.java:89) > at org.apache.hive.beeline.Commands.metadata(Commands.java:125) > at org.apache.hive.beeline.Commands.primarykeys(Commands.java:231) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.hive.beeline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:57) > at > org.apache.hive.beeline.BeeLine.execCommandWithPrefix(BeeLine.java:1465) > at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:1504) > at org.apache.hive.beeline.BeeLine.execute(BeeLine.java:1364) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1134) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1082) > at > org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:546) > at org.apache.hive.beeline.BeeLine.main(BeeLine.java:528) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hadoop.util.RunJar.run(RunJar.java:323) > at org.apache.hadoop.util.RunJar.main(RunJar.java:236){noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-23935) Fetching primaryKey through beeline fails with NPE
[ https://issues.apache.org/jira/browse/HIVE-23935?focusedWorklogId=843153&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-843153 ] ASF GitHub Bot logged work on HIVE-23935: - Author: ASF GitHub Bot Created on: 02/Feb/23 10:36 Start Date: 02/Feb/23 10:36 Worklog Time Spent: 10m Work Description: ayushtkn commented on PR #4009: URL: https://github.com/apache/hive/pull/4009#issuecomment-1413522930 @abstractdog can you help review Issue Time Tracking --- Worklog Id: (was: 843153) Time Spent: 2h 40m (was: 2.5h) > Fetching primaryKey through beeline fails with NPE > -- > > Key: HIVE-23935 > URL: https://issues.apache.org/jira/browse/HIVE-23935 > Project: Hive > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Time Spent: 2h 40m > Remaining Estimate: 0h > > Fetching PrimaryKey of a table through Beeline !primarykey fails with NPE > {noformat} > 0: jdbc:hive2://localhost:1> !primarykeys Persons > Error: MetaException(message:java.lang.NullPointerException) (state=,code=0) > org.apache.hive.service.cli.HiveSQLException: > MetaException(message:java.lang.NullPointerException) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:360) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:351) > at > org.apache.hive.jdbc.HiveDatabaseMetaData.getPrimaryKeys(HiveDatabaseMetaData.java:573) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hive.beeline.Reflector.invoke(Reflector.java:89) > at org.apache.hive.beeline.Commands.metadata(Commands.java:125) > at org.apache.hive.beeline.Commands.primarykeys(Commands.java:231) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.hive.beeline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:57) > at > org.apache.hive.beeline.BeeLine.execCommandWithPrefix(BeeLine.java:1465) > at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:1504) > at org.apache.hive.beeline.BeeLine.execute(BeeLine.java:1364) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1134) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1082) > at > org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:546) > at org.apache.hive.beeline.BeeLine.main(BeeLine.java:528) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hadoop.util.RunJar.run(RunJar.java:323) > at org.apache.hadoop.util.RunJar.main(RunJar.java:236){noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-23935) Fetching primaryKey through beeline fails with NPE
[ https://issues.apache.org/jira/browse/HIVE-23935?focusedWorklogId=843108&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-843108 ] ASF GitHub Bot logged work on HIVE-23935: - Author: ASF GitHub Bot Created on: 02/Feb/23 08:05 Start Date: 02/Feb/23 08:05 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #4009: URL: https://github.com/apache/hive/pull/4009#issuecomment-1413303240 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4009) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4009&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4009&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4009&resolved=false&types=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4009&resolved=false&types=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4009&metric=coverage&view=list) No Coverage information [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4009&metric=duplicated_lines_density&view=list) No Duplication information Issue Time Tracking --- Worklog Id: (was: 843108) Time Spent: 2.5h (was: 2h 20m) > Fetching primaryKey through beeline fails with NPE > -- > > Key: HIVE-23935 > URL: https://issues.apache.org/jira/browse/HIVE-23935 > Project: Hive > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Time Spent: 2.5h > Remaining Estimate: 0h > > Fetching PrimaryKey of a table through Beeline !primarykey fails with NPE > {noformat} > 0: jdbc:hive2://localhost:1> !primarykeys Persons > Error: MetaException(message:java.lang.NullPointerException) (state=,code=0) > org.apache.hive.service.cli.HiveSQLException: > MetaException(message:java.lang.NullPointerException) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:360) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:351) > at > org.apache.hive.jdbc.HiveDatabaseMetaData.getPrimaryKeys(HiveDatabaseMetaData.java:573) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Na
[jira] [Work logged] (HIVE-23935) Fetching primaryKey through beeline fails with NPE
[ https://issues.apache.org/jira/browse/HIVE-23935?focusedWorklogId=843094&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-843094 ] ASF GitHub Bot logged work on HIVE-23935: - Author: ASF GitHub Bot Created on: 02/Feb/23 07:10 Start Date: 02/Feb/23 07:10 Worklog Time Spent: 10m Work Description: ayushtkn opened a new pull request, #4009: URL: https://github.com/apache/hive/pull/4009 https://issues.apache.org/jira/browse/HIVE-23935 Entire Trace - ``` 0: jdbc:hive2://localhost:1> !primarykeys Persons Error: MetaException(message:java.lang.NullPointerException) (state=,code=0) org.apache.hive.service.cli.HiveSQLException: MetaException(message:java.lang.NullPointerException) at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:360) at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:351) at org.apache.hive.jdbc.HiveDatabaseMetaData.getPrimaryKeys(HiveDatabaseMetaData.java:573) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.hive.beeline.Reflector.invoke(Reflector.java:89) at org.apache.hive.beeline.Commands.metadata(Commands.java:125) at org.apache.hive.beeline.Commands.primarykeys(Commands.java:231) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.hive.beeline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:57) at org.apache.hive.beeline.BeeLine.execCommandWithPrefix(BeeLine.java:1465) at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:1504) at org.apache.hive.beeline.BeeLine.execute(BeeLine.java:1364) at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1134) at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1082) at org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:546) at org.apache.hive.beeline.BeeLine.main(BeeLine.java:528) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.hadoop.util.RunJar.run(RunJar.java:323) at org.apache.hadoop.util.RunJar.main(RunJar.java:236) Caused by: org.apache.hive.service.cli.HiveSQLException: MetaException(message:java.lang.NullPointerException) at org.apache.hive.service.cli.operation.GetPrimaryKeysOperation.runInternal(GetPrimaryKeysOperation.java:120) at org.apache.hive.service.cli.operation.Operation.run(Operation.java:277) at org.apache.hive.service.cli.session.HiveSessionImpl.getPrimaryKeys(HiveSessionImpl.java:997) at org.apache.hive.service.cli.CLIService.getPrimaryKeys(CLIService.java:416) at org.apache.hive.service.cli.thrift.ThriftCLIService.GetPrimaryKeys(ThriftCLIService.java:838) at org.apache.hive.service.rpc.thrift.TCLIService$Processor$GetPrimaryKeys.getResult(TCLIService.java:1717) at org.apache.hive.service.rpc.thrift.TCLIService$Processor$GetPrimaryKeys.getResult(TCLIService.java:1702) at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:39) at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:39) at org.apache.hive.service.auth.TSetIpAddressProcessor.process(TSetIpAddressProcessor.java:56) at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:286) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) Caused by: MetaException(message:java.lang.NullPointerException) at org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.newMetaException(HiveMetaStore.java:7921) at org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.throwMetaException(HiveMetaStore.java:9105) at org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.get_primary_keys(HiveMetaStore.java:9067) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.jav
[jira] [Work logged] (HIVE-23935) Fetching primaryKey through beeline fails with NPE
[ https://issues.apache.org/jira/browse/HIVE-23935?focusedWorklogId=529655&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-529655 ] ASF GitHub Bot logged work on HIVE-23935: - Author: ASF GitHub Bot Created on: 31/Dec/20 01:07 Start Date: 31/Dec/20 01:07 Worklog Time Spent: 10m Work Description: github-actions[bot] closed pull request #1605: URL: https://github.com/apache/hive/pull/1605 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 529655) Time Spent: 2h 10m (was: 2h) > Fetching primaryKey through beeline fails with NPE > -- > > Key: HIVE-23935 > URL: https://issues.apache.org/jira/browse/HIVE-23935 > Project: Hive > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Time Spent: 2h 10m > Remaining Estimate: 0h > > Fetching PrimaryKey of a table through Beeline !primarykey fails with NPE > {noformat} > 0: jdbc:hive2://localhost:1> !primarykeys Persons > Error: MetaException(message:java.lang.NullPointerException) (state=,code=0) > org.apache.hive.service.cli.HiveSQLException: > MetaException(message:java.lang.NullPointerException) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:360) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:351) > at > org.apache.hive.jdbc.HiveDatabaseMetaData.getPrimaryKeys(HiveDatabaseMetaData.java:573) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hive.beeline.Reflector.invoke(Reflector.java:89) > at org.apache.hive.beeline.Commands.metadata(Commands.java:125) > at org.apache.hive.beeline.Commands.primarykeys(Commands.java:231) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.hive.beeline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:57) > at > org.apache.hive.beeline.BeeLine.execCommandWithPrefix(BeeLine.java:1465) > at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:1504) > at org.apache.hive.beeline.BeeLine.execute(BeeLine.java:1364) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1134) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1082) > at > org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:546) > at org.apache.hive.beeline.BeeLine.main(BeeLine.java:528) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hadoop.util.RunJar.run(RunJar.java:323) > at org.apache.hadoop.util.RunJar.main(RunJar.java:236){noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23935) Fetching primaryKey through beeline fails with NPE
[ https://issues.apache.org/jira/browse/HIVE-23935?focusedWorklogId=527916&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-527916 ] ASF GitHub Bot logged work on HIVE-23935: - Author: ASF GitHub Bot Created on: 24/Dec/20 01:03 Start Date: 24/Dec/20 01:03 Worklog Time Spent: 10m Work Description: github-actions[bot] commented on pull request #1605: URL: https://github.com/apache/hive/pull/1605#issuecomment-750677661 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the d...@hive.apache.org list if the patch is in need of reviews. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 527916) Time Spent: 2h (was: 1h 50m) > Fetching primaryKey through beeline fails with NPE > -- > > Key: HIVE-23935 > URL: https://issues.apache.org/jira/browse/HIVE-23935 > Project: Hive > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Time Spent: 2h > Remaining Estimate: 0h > > Fetching PrimaryKey of a table through Beeline !primarykey fails with NPE > {noformat} > 0: jdbc:hive2://localhost:1> !primarykeys Persons > Error: MetaException(message:java.lang.NullPointerException) (state=,code=0) > org.apache.hive.service.cli.HiveSQLException: > MetaException(message:java.lang.NullPointerException) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:360) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:351) > at > org.apache.hive.jdbc.HiveDatabaseMetaData.getPrimaryKeys(HiveDatabaseMetaData.java:573) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hive.beeline.Reflector.invoke(Reflector.java:89) > at org.apache.hive.beeline.Commands.metadata(Commands.java:125) > at org.apache.hive.beeline.Commands.primarykeys(Commands.java:231) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.hive.beeline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:57) > at > org.apache.hive.beeline.BeeLine.execCommandWithPrefix(BeeLine.java:1465) > at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:1504) > at org.apache.hive.beeline.BeeLine.execute(BeeLine.java:1364) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1134) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1082) > at > org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:546) > at org.apache.hive.beeline.BeeLine.main(BeeLine.java:528) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hadoop.util.RunJar.run(RunJar.java:323) > at org.apache.hadoop.util.RunJar.main(RunJar.java:236){noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23935) Fetching primaryKey through beeline fails with NPE
[ https://issues.apache.org/jira/browse/HIVE-23935?focusedWorklogId=504423&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-504423 ] ASF GitHub Bot logged work on HIVE-23935: - Author: ASF GitHub Bot Created on: 24/Oct/20 09:30 Start Date: 24/Oct/20 09:30 Worklog Time Spent: 10m Work Description: ashish-kumar-sharma commented on a change in pull request #1605: URL: https://github.com/apache/hive/pull/1605#discussion_r511362503 ## File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java ## @@ -1124,6 +1125,40 @@ public void testEmptyTrustStoreProps() { setAndCheckSSLProperties(true, "", "", "jks"); } + /** + * Tests getPrimaryKeys() when db_name isn't specified. + */ + @Test + public void testGetPrimaryKeys() throws Exception { Review comment: You are right that its part of ObjectStore but TestPrimaryKey class was created so that we can have all sort of test for primary key in one place. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 504423) Time Spent: 1h 50m (was: 1h 40m) > Fetching primaryKey through beeline fails with NPE > -- > > Key: HIVE-23935 > URL: https://issues.apache.org/jira/browse/HIVE-23935 > Project: Hive > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Time Spent: 1h 50m > Remaining Estimate: 0h > > Fetching PrimaryKey of a table through Beeline !primarykey fails with NPE > {noformat} > 0: jdbc:hive2://localhost:1> !primarykeys Persons > Error: MetaException(message:java.lang.NullPointerException) (state=,code=0) > org.apache.hive.service.cli.HiveSQLException: > MetaException(message:java.lang.NullPointerException) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:360) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:351) > at > org.apache.hive.jdbc.HiveDatabaseMetaData.getPrimaryKeys(HiveDatabaseMetaData.java:573) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hive.beeline.Reflector.invoke(Reflector.java:89) > at org.apache.hive.beeline.Commands.metadata(Commands.java:125) > at org.apache.hive.beeline.Commands.primarykeys(Commands.java:231) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.hive.beeline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:57) > at > org.apache.hive.beeline.BeeLine.execCommandWithPrefix(BeeLine.java:1465) > at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:1504) > at org.apache.hive.beeline.BeeLine.execute(BeeLine.java:1364) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1134) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1082) > at > org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:546) > at org.apache.hive.beeline.BeeLine.main(BeeLine.java:528) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hadoop.util.RunJar.run(RunJar.java:323) > at org.apache.hadoop.util.RunJar.main(RunJar.java:236){noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23935) Fetching primaryKey through beeline fails with NPE
[ https://issues.apache.org/jira/browse/HIVE-23935?focusedWorklogId=504422&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-504422 ] ASF GitHub Bot logged work on HIVE-23935: - Author: ASF GitHub Bot Created on: 24/Oct/20 09:28 Start Date: 24/Oct/20 09:28 Worklog Time Spent: 10m Work Description: ashish-kumar-sharma commented on a change in pull request #1605: URL: https://github.com/apache/hive/pull/1605#discussion_r511361890 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java ## @@ -10833,7 +10833,8 @@ public FileMetadataHandler getFileMetadataHandler(FileMetadataExprType type) { final String db_name_input, final String tbl_name_input) throws MetaException, NoSuchObjectException { -final String db_name = normalizeIdentifier(db_name_input); +final String db_name = Review comment: @ayushtkn 1. You haven't introduce any new variable but since you can change the name of other variable as well along with your PR for sanity 2. For catName, dbName and tableName its better to check and normalize everywhere which helps in making sure that hive is case insensitive for name. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 504422) Time Spent: 1h 40m (was: 1.5h) > Fetching primaryKey through beeline fails with NPE > -- > > Key: HIVE-23935 > URL: https://issues.apache.org/jira/browse/HIVE-23935 > Project: Hive > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Time Spent: 1h 40m > Remaining Estimate: 0h > > Fetching PrimaryKey of a table through Beeline !primarykey fails with NPE > {noformat} > 0: jdbc:hive2://localhost:1> !primarykeys Persons > Error: MetaException(message:java.lang.NullPointerException) (state=,code=0) > org.apache.hive.service.cli.HiveSQLException: > MetaException(message:java.lang.NullPointerException) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:360) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:351) > at > org.apache.hive.jdbc.HiveDatabaseMetaData.getPrimaryKeys(HiveDatabaseMetaData.java:573) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hive.beeline.Reflector.invoke(Reflector.java:89) > at org.apache.hive.beeline.Commands.metadata(Commands.java:125) > at org.apache.hive.beeline.Commands.primarykeys(Commands.java:231) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.hive.beeline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:57) > at > org.apache.hive.beeline.BeeLine.execCommandWithPrefix(BeeLine.java:1465) > at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:1504) > at org.apache.hive.beeline.BeeLine.execute(BeeLine.java:1364) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1134) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1082) > at > org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:546) > at org.apache.hive.beeline.BeeLine.main(BeeLine.java:528) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hadoop.util.RunJar.run(RunJar.java:323) > at org.apache.hadoop.util.RunJar.main(RunJar.java:236){noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23935) Fetching primaryKey through beeline fails with NPE
[ https://issues.apache.org/jira/browse/HIVE-23935?focusedWorklogId=504411&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-504411 ] ASF GitHub Bot logged work on HIVE-23935: - Author: ASF GitHub Bot Created on: 24/Oct/20 04:35 Start Date: 24/Oct/20 04:35 Worklog Time Spent: 10m Work Description: ayushtkn commented on a change in pull request #1605: URL: https://github.com/apache/hive/pull/1605#discussion_r511318476 ## File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java ## @@ -1124,6 +1125,40 @@ public void testEmptyTrustStoreProps() { setAndCheckSSLProperties(true, "", "", "jks"); } + /** + * Tests getPrimaryKeys() when db_name isn't specified. + */ + @Test + public void testGetPrimaryKeys() throws Exception { Review comment: The change itself is in ObjectStore, and the API too is in ObjectStore. The `TestPrimaryKey` is a parametrised test and for one case, this issue doesn't happen. I think the test is better here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 504411) Time Spent: 1.5h (was: 1h 20m) > Fetching primaryKey through beeline fails with NPE > -- > > Key: HIVE-23935 > URL: https://issues.apache.org/jira/browse/HIVE-23935 > Project: Hive > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > > Fetching PrimaryKey of a table through Beeline !primarykey fails with NPE > {noformat} > 0: jdbc:hive2://localhost:1> !primarykeys Persons > Error: MetaException(message:java.lang.NullPointerException) (state=,code=0) > org.apache.hive.service.cli.HiveSQLException: > MetaException(message:java.lang.NullPointerException) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:360) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:351) > at > org.apache.hive.jdbc.HiveDatabaseMetaData.getPrimaryKeys(HiveDatabaseMetaData.java:573) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hive.beeline.Reflector.invoke(Reflector.java:89) > at org.apache.hive.beeline.Commands.metadata(Commands.java:125) > at org.apache.hive.beeline.Commands.primarykeys(Commands.java:231) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.hive.beeline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:57) > at > org.apache.hive.beeline.BeeLine.execCommandWithPrefix(BeeLine.java:1465) > at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:1504) > at org.apache.hive.beeline.BeeLine.execute(BeeLine.java:1364) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1134) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1082) > at > org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:546) > at org.apache.hive.beeline.BeeLine.main(BeeLine.java:528) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hadoop.util.RunJar.run(RunJar.java:323) > at org.apache.hadoop.util.RunJar.main(RunJar.java:236){noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23935) Fetching primaryKey through beeline fails with NPE
[ https://issues.apache.org/jira/browse/HIVE-23935?focusedWorklogId=504410&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-504410 ] ASF GitHub Bot logged work on HIVE-23935: - Author: ASF GitHub Bot Created on: 24/Oct/20 04:07 Start Date: 24/Oct/20 04:07 Worklog Time Spent: 10m Work Description: ayushtkn commented on a change in pull request #1605: URL: https://github.com/apache/hive/pull/1605#discussion_r511305357 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java ## @@ -10833,7 +10833,8 @@ public FileMetadataHandler getFileMetadataHandler(FileMetadataExprType type) { final String db_name_input, final String tbl_name_input) throws MetaException, NoSuchObjectException { -final String db_name = normalizeIdentifier(db_name_input); +final String db_name = Review comment: Thanx @ashish-kumar-sharma 1. I will address. 2. Why for catName? It isn't getting accessed anywhere which can fetch any NPE. 3. I didn't catch this? I haven't introduce any variable itself. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 504410) Time Spent: 1h 20m (was: 1h 10m) > Fetching primaryKey through beeline fails with NPE > -- > > Key: HIVE-23935 > URL: https://issues.apache.org/jira/browse/HIVE-23935 > Project: Hive > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Time Spent: 1h 20m > Remaining Estimate: 0h > > Fetching PrimaryKey of a table through Beeline !primarykey fails with NPE > {noformat} > 0: jdbc:hive2://localhost:1> !primarykeys Persons > Error: MetaException(message:java.lang.NullPointerException) (state=,code=0) > org.apache.hive.service.cli.HiveSQLException: > MetaException(message:java.lang.NullPointerException) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:360) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:351) > at > org.apache.hive.jdbc.HiveDatabaseMetaData.getPrimaryKeys(HiveDatabaseMetaData.java:573) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hive.beeline.Reflector.invoke(Reflector.java:89) > at org.apache.hive.beeline.Commands.metadata(Commands.java:125) > at org.apache.hive.beeline.Commands.primarykeys(Commands.java:231) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.hive.beeline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:57) > at > org.apache.hive.beeline.BeeLine.execCommandWithPrefix(BeeLine.java:1465) > at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:1504) > at org.apache.hive.beeline.BeeLine.execute(BeeLine.java:1364) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1134) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1082) > at > org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:546) > at org.apache.hive.beeline.BeeLine.main(BeeLine.java:528) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hadoop.util.RunJar.run(RunJar.java:323) > at org.apache.hadoop.util.RunJar.main(RunJar.java:236){noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23935) Fetching primaryKey through beeline fails with NPE
[ https://issues.apache.org/jira/browse/HIVE-23935?focusedWorklogId=504409&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-504409 ] ASF GitHub Bot logged work on HIVE-23935: - Author: ASF GitHub Bot Created on: 24/Oct/20 03:53 Start Date: 24/Oct/20 03:53 Worklog Time Spent: 10m Work Description: ashish-kumar-sharma commented on a change in pull request #1605: URL: https://github.com/apache/hive/pull/1605#discussion_r511299604 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java ## @@ -10833,7 +10833,8 @@ public FileMetadataHandler getFileMetadataHandler(FileMetadataExprType type) { final String db_name_input, final String tbl_name_input) throws MetaException, NoSuchObjectException { -final String db_name = normalizeIdentifier(db_name_input); +final String db_name = Review comment: 1. Can we use StringUtils.isNotBlank(db_name_input) instead of (db_name_input!=null). 2. Also can we have the same check on catName. 3. Can we use unified camel casing naming convention across variable name. ## File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java ## @@ -1124,6 +1125,40 @@ public void testEmptyTrustStoreProps() { setAndCheckSSLProperties(true, "", "", "jks"); } + /** + * Tests getPrimaryKeys() when db_name isn't specified. + */ + @Test + public void testGetPrimaryKeys() throws Exception { Review comment: Please add this Test to class TestPrimaryKey.java This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 504409) Time Spent: 1h 10m (was: 1h) > Fetching primaryKey through beeline fails with NPE > -- > > Key: HIVE-23935 > URL: https://issues.apache.org/jira/browse/HIVE-23935 > Project: Hive > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Time Spent: 1h 10m > Remaining Estimate: 0h > > Fetching PrimaryKey of a table through Beeline !primarykey fails with NPE > {noformat} > 0: jdbc:hive2://localhost:1> !primarykeys Persons > Error: MetaException(message:java.lang.NullPointerException) (state=,code=0) > org.apache.hive.service.cli.HiveSQLException: > MetaException(message:java.lang.NullPointerException) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:360) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:351) > at > org.apache.hive.jdbc.HiveDatabaseMetaData.getPrimaryKeys(HiveDatabaseMetaData.java:573) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hive.beeline.Reflector.invoke(Reflector.java:89) > at org.apache.hive.beeline.Commands.metadata(Commands.java:125) > at org.apache.hive.beeline.Commands.primarykeys(Commands.java:231) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.hive.beeline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:57) > at > org.apache.hive.beeline.BeeLine.execCommandWithPrefix(BeeLine.java:1465) > at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:1504) > at org.apache.hive.beeline.BeeLine.execute(BeeLine.java:1364) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1134) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1082) > at > org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:546) > at org.apache.hive.beeline.BeeLine.main(BeeLine.java:528) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAc
[jira] [Work logged] (HIVE-23935) Fetching primaryKey through beeline fails with NPE
[ https://issues.apache.org/jira/browse/HIVE-23935?focusedWorklogId=504211&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-504211 ] ASF GitHub Bot logged work on HIVE-23935: - Author: ASF GitHub Bot Created on: 23/Oct/20 15:05 Start Date: 23/Oct/20 15:05 Worklog Time Spent: 10m Work Description: ayushtkn opened a new pull request #1605: URL: https://github.com/apache/hive/pull/1605 https://issues.apache.org/jira/browse/HIVE-23935 Entire Trace - 0: jdbc:hive2://localhost:1> !primarykeys Persons Error: MetaException(message:java.lang.NullPointerException) (state=,code=0) org.apache.hive.service.cli.HiveSQLException: MetaException(message:java.lang.NullPointerException) at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:360) at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:351) at org.apache.hive.jdbc.HiveDatabaseMetaData.getPrimaryKeys(HiveDatabaseMetaData.java:573) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.hive.beeline.Reflector.invoke(Reflector.java:89) at org.apache.hive.beeline.Commands.metadata(Commands.java:125) at org.apache.hive.beeline.Commands.primarykeys(Commands.java:231) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.hive.beeline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:57) at org.apache.hive.beeline.BeeLine.execCommandWithPrefix(BeeLine.java:1465) at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:1504) at org.apache.hive.beeline.BeeLine.execute(BeeLine.java:1364) at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1134) at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1082) at org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:546) at org.apache.hive.beeline.BeeLine.main(BeeLine.java:528) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.hadoop.util.RunJar.run(RunJar.java:323) at org.apache.hadoop.util.RunJar.main(RunJar.java:236) Caused by: org.apache.hive.service.cli.HiveSQLException: MetaException(message:java.lang.NullPointerException) at org.apache.hive.service.cli.operation.GetPrimaryKeysOperation.runInternal(GetPrimaryKeysOperation.java:120) at org.apache.hive.service.cli.operation.Operation.run(Operation.java:277) at org.apache.hive.service.cli.session.HiveSessionImpl.getPrimaryKeys(HiveSessionImpl.java:997) at org.apache.hive.service.cli.CLIService.getPrimaryKeys(CLIService.java:416) at org.apache.hive.service.cli.thrift.ThriftCLIService.GetPrimaryKeys(ThriftCLIService.java:838) at org.apache.hive.service.rpc.thrift.TCLIService$Processor$GetPrimaryKeys.getResult(TCLIService.java:1717) at org.apache.hive.service.rpc.thrift.TCLIService$Processor$GetPrimaryKeys.getResult(TCLIService.java:1702) at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:39) at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:39) at org.apache.hive.service.auth.TSetIpAddressProcessor.process(TSetIpAddressProcessor.java:56) at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:286) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) Caused by: MetaException(message:java.lang.NullPointerException) at org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.newMetaException(HiveMetaStore.java:7921) at org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.throwMetaException(HiveMetaStore.java:9105) at org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.get_primary_keys(HiveMetaStore.java:9067) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:6
[jira] [Work logged] (HIVE-23935) Fetching primaryKey through beeline fails with NPE
[ https://issues.apache.org/jira/browse/HIVE-23935?focusedWorklogId=500360&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-500360 ] ASF GitHub Bot logged work on HIVE-23935: - Author: ASF GitHub Bot Created on: 14/Oct/20 00:55 Start Date: 14/Oct/20 00:55 Worklog Time Spent: 10m Work Description: github-actions[bot] closed pull request #1321: URL: https://github.com/apache/hive/pull/1321 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 500360) Time Spent: 50m (was: 40m) > Fetching primaryKey through beeline fails with NPE > -- > > Key: HIVE-23935 > URL: https://issues.apache.org/jira/browse/HIVE-23935 > Project: Hive > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > Fetching PrimaryKey of a table through Beeline !primarykey fails with NPE > {noformat} > 0: jdbc:hive2://localhost:1> !primarykeys Persons > Error: MetaException(message:java.lang.NullPointerException) (state=,code=0) > org.apache.hive.service.cli.HiveSQLException: > MetaException(message:java.lang.NullPointerException) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:360) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:351) > at > org.apache.hive.jdbc.HiveDatabaseMetaData.getPrimaryKeys(HiveDatabaseMetaData.java:573) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hive.beeline.Reflector.invoke(Reflector.java:89) > at org.apache.hive.beeline.Commands.metadata(Commands.java:125) > at org.apache.hive.beeline.Commands.primarykeys(Commands.java:231) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.hive.beeline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:57) > at > org.apache.hive.beeline.BeeLine.execCommandWithPrefix(BeeLine.java:1465) > at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:1504) > at org.apache.hive.beeline.BeeLine.execute(BeeLine.java:1364) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1134) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1082) > at > org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:546) > at org.apache.hive.beeline.BeeLine.main(BeeLine.java:528) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hadoop.util.RunJar.run(RunJar.java:323) > at org.apache.hadoop.util.RunJar.main(RunJar.java:236){noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23935) Fetching primaryKey through beeline fails with NPE
[ https://issues.apache.org/jira/browse/HIVE-23935?focusedWorklogId=496253&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-496253 ] ASF GitHub Bot logged work on HIVE-23935: - Author: ASF GitHub Bot Created on: 07/Oct/20 00:52 Start Date: 07/Oct/20 00:52 Worklog Time Spent: 10m Work Description: github-actions[bot] commented on pull request #1321: URL: https://github.com/apache/hive/pull/1321#issuecomment-704629171 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the d...@hive.apache.org list if the patch is in need of reviews. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 496253) Time Spent: 40m (was: 0.5h) > Fetching primaryKey through beeline fails with NPE > -- > > Key: HIVE-23935 > URL: https://issues.apache.org/jira/browse/HIVE-23935 > Project: Hive > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > Fetching PrimaryKey of a table through Beeline !primarykey fails with NPE > {noformat} > 0: jdbc:hive2://localhost:1> !primarykeys Persons > Error: MetaException(message:java.lang.NullPointerException) (state=,code=0) > org.apache.hive.service.cli.HiveSQLException: > MetaException(message:java.lang.NullPointerException) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:360) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:351) > at > org.apache.hive.jdbc.HiveDatabaseMetaData.getPrimaryKeys(HiveDatabaseMetaData.java:573) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hive.beeline.Reflector.invoke(Reflector.java:89) > at org.apache.hive.beeline.Commands.metadata(Commands.java:125) > at org.apache.hive.beeline.Commands.primarykeys(Commands.java:231) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.hive.beeline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:57) > at > org.apache.hive.beeline.BeeLine.execCommandWithPrefix(BeeLine.java:1465) > at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:1504) > at org.apache.hive.beeline.BeeLine.execute(BeeLine.java:1364) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1134) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1082) > at > org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:546) > at org.apache.hive.beeline.BeeLine.main(BeeLine.java:528) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hadoop.util.RunJar.run(RunJar.java:323) > at org.apache.hadoop.util.RunJar.main(RunJar.java:236){noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23935) Fetching primaryKey through beeline fails with NPE
[ https://issues.apache.org/jira/browse/HIVE-23935?focusedWorklogId=467914&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-467914 ] ASF GitHub Bot logged work on HIVE-23935: - Author: ASF GitHub Bot Created on: 07/Aug/20 16:35 Start Date: 07/Aug/20 16:35 Worklog Time Spent: 10m Work Description: ayushtkn commented on pull request #1321: URL: https://github.com/apache/hive/pull/1321#issuecomment-670603579 @kgyrtkirk @belugabehr can you help review!!! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 467914) Time Spent: 0.5h (was: 20m) > Fetching primaryKey through beeline fails with NPE > -- > > Key: HIVE-23935 > URL: https://issues.apache.org/jira/browse/HIVE-23935 > Project: Hive > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > Fetching PrimaryKey of a table through Beeline !primarykey fails with NPE > {noformat} > 0: jdbc:hive2://localhost:1> !primarykeys Persons > Error: MetaException(message:java.lang.NullPointerException) (state=,code=0) > org.apache.hive.service.cli.HiveSQLException: > MetaException(message:java.lang.NullPointerException) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:360) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:351) > at > org.apache.hive.jdbc.HiveDatabaseMetaData.getPrimaryKeys(HiveDatabaseMetaData.java:573) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hive.beeline.Reflector.invoke(Reflector.java:89) > at org.apache.hive.beeline.Commands.metadata(Commands.java:125) > at org.apache.hive.beeline.Commands.primarykeys(Commands.java:231) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.hive.beeline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:57) > at > org.apache.hive.beeline.BeeLine.execCommandWithPrefix(BeeLine.java:1465) > at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:1504) > at org.apache.hive.beeline.BeeLine.execute(BeeLine.java:1364) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1134) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1082) > at > org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:546) > at org.apache.hive.beeline.BeeLine.main(BeeLine.java:528) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hadoop.util.RunJar.run(RunJar.java:323) > at org.apache.hadoop.util.RunJar.main(RunJar.java:236){noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23935) Fetching primaryKey through beeline fails with NPE
[ https://issues.apache.org/jira/browse/HIVE-23935?focusedWorklogId=463408&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463408 ] ASF GitHub Bot logged work on HIVE-23935: - Author: ASF GitHub Bot Created on: 26/Jul/20 21:00 Start Date: 26/Jul/20 21:00 Worklog Time Spent: 10m Work Description: ayushtkn commented on pull request #1321: URL: https://github.com/apache/hive/pull/1321#issuecomment-664039641 Reason - `` public boolean primarykeys(String line) throws Exception { return metadata("getPrimaryKeys", new String[] { beeLine.getConnection().getCatalog(), null, arg1(line, "table name"),});`` Db_Name is passed `null` from `Command.java` and that is a valid value, which is handled later at `MetaStoreDirectSql.java` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 463408) Time Spent: 20m (was: 10m) > Fetching primaryKey through beeline fails with NPE > -- > > Key: HIVE-23935 > URL: https://issues.apache.org/jira/browse/HIVE-23935 > Project: Hive > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > Fetching PrimaryKey of a table through Beeline !primarykey fails with NPE > {noformat} > 0: jdbc:hive2://localhost:1> !primarykeys Persons > Error: MetaException(message:java.lang.NullPointerException) (state=,code=0) > org.apache.hive.service.cli.HiveSQLException: > MetaException(message:java.lang.NullPointerException) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:360) > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:351) > at > org.apache.hive.jdbc.HiveDatabaseMetaData.getPrimaryKeys(HiveDatabaseMetaData.java:573) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hive.beeline.Reflector.invoke(Reflector.java:89) > at org.apache.hive.beeline.Commands.metadata(Commands.java:125) > at org.apache.hive.beeline.Commands.primarykeys(Commands.java:231) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.hive.beeline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:57) > at > org.apache.hive.beeline.BeeLine.execCommandWithPrefix(BeeLine.java:1465) > at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:1504) > at org.apache.hive.beeline.BeeLine.execute(BeeLine.java:1364) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1134) > at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1082) > at > org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:546) > at org.apache.hive.beeline.BeeLine.main(BeeLine.java:528) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hadoop.util.RunJar.run(RunJar.java:323) > at org.apache.hadoop.util.RunJar.main(RunJar.java:236){noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23935) Fetching primaryKey through beeline fails with NPE
[ https://issues.apache.org/jira/browse/HIVE-23935?focusedWorklogId=463407&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463407 ] ASF GitHub Bot logged work on HIVE-23935: - Author: ASF GitHub Bot Created on: 26/Jul/20 20:56 Start Date: 26/Jul/20 20:56 Worklog Time Spent: 10m Work Description: ayushtkn opened a new pull request #1321: URL: https://github.com/apache/hive/pull/1321 https://issues.apache.org/jira/browse/HIVE-23935 Entire Trace - ``` 0: jdbc:hive2://localhost:1> !primarykeys Persons Error: MetaException(message:java.lang.NullPointerException) (state=,code=0) org.apache.hive.service.cli.HiveSQLException: MetaException(message:java.lang.NullPointerException) at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:360) at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:351) at org.apache.hive.jdbc.HiveDatabaseMetaData.getPrimaryKeys(HiveDatabaseMetaData.java:573) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.hive.beeline.Reflector.invoke(Reflector.java:89) at org.apache.hive.beeline.Commands.metadata(Commands.java:125) at org.apache.hive.beeline.Commands.primarykeys(Commands.java:231) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.hive.beeline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:57) at org.apache.hive.beeline.BeeLine.execCommandWithPrefix(BeeLine.java:1465) at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:1504) at org.apache.hive.beeline.BeeLine.execute(BeeLine.java:1364) at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1134) at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:1082) at org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:546) at org.apache.hive.beeline.BeeLine.main(BeeLine.java:528) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.hadoop.util.RunJar.run(RunJar.java:323) at org.apache.hadoop.util.RunJar.main(RunJar.java:236) Caused by: org.apache.hive.service.cli.HiveSQLException: MetaException(message:java.lang.NullPointerException) at org.apache.hive.service.cli.operation.GetPrimaryKeysOperation.runInternal(GetPrimaryKeysOperation.java:120) at org.apache.hive.service.cli.operation.Operation.run(Operation.java:277) at org.apache.hive.service.cli.session.HiveSessionImpl.getPrimaryKeys(HiveSessionImpl.java:997) at org.apache.hive.service.cli.CLIService.getPrimaryKeys(CLIService.java:416) at org.apache.hive.service.cli.thrift.ThriftCLIService.GetPrimaryKeys(ThriftCLIService.java:838) at org.apache.hive.service.rpc.thrift.TCLIService$Processor$GetPrimaryKeys.getResult(TCLIService.java:1717) at org.apache.hive.service.rpc.thrift.TCLIService$Processor$GetPrimaryKeys.getResult(TCLIService.java:1702) at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:39) at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:39) at org.apache.hive.service.auth.TSetIpAddressProcessor.process(TSetIpAddressProcessor.java:56) at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:286) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) Caused by: MetaException(message:java.lang.NullPointerException) at org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.newMetaException(HiveMetaStore.java:7921) at org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.throwMetaException(HiveMetaStore.java:9105) at org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.get_primary_keys(HiveMetaStore.java:9067) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl