[jira] [Work logged] (HIVE-24814) Harmonize Hive Date-Time Formats
[
https://issues.apache.org/jira/browse/HIVE-24814?focusedWorklogId=637902&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637902
]
ASF GitHub Bot logged work on HIVE-24814:
-
Author: ASF GitHub Bot
Created on: 14/Aug/21 00:09
Start Date: 14/Aug/21 00:09
Worklog Time Spent: 10m
Work Description: github-actions[bot] closed pull request #2009:
URL: https://github.com/apache/hive/pull/2009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 637902)
Time Spent: 1h 40m (was: 1.5h)
> Harmonize Hive Date-Time Formats
>
>
> Key: HIVE-24814
> URL: https://issues.apache.org/jira/browse/HIVE-24814
> Project: Hive
> Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Harmonize Hive on JDK date-time formats courtesy of {{DateTimeFormatter}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24814) Harmonize Hive Date-Time Formats
[
https://issues.apache.org/jira/browse/HIVE-24814?focusedWorklogId=635522&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635522
]
ASF GitHub Bot logged work on HIVE-24814:
-
Author: ASF GitHub Bot
Created on: 07/Aug/21 00:08
Start Date: 07/Aug/21 00:08
Worklog Time Spent: 10m
Work Description: github-actions[bot] commented on pull request #2009:
URL: https://github.com/apache/hive/pull/2009#issuecomment-894573586
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the d...@hive.apache.org list if the patch is in
need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 635522)
Time Spent: 1.5h (was: 1h 20m)
> Harmonize Hive Date-Time Formats
>
>
> Key: HIVE-24814
> URL: https://issues.apache.org/jira/browse/HIVE-24814
> Project: Hive
> Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Harmonize Hive on JDK date-time formats courtesy of {{DateTimeFormatter}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24814) Harmonize Hive Date-Time Formats
[
https://issues.apache.org/jira/browse/HIVE-24814?focusedWorklogId=607557&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-607557
]
ASF GitHub Bot logged work on HIVE-24814:
-
Author: ASF GitHub Bot
Created on: 07/Jun/21 00:17
Start Date: 07/Jun/21 00:17
Worklog Time Spent: 10m
Work Description: github-actions[bot] commented on pull request #2009:
URL: https://github.com/apache/hive/pull/2009#issuecomment-855489242
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the d...@hive.apache.org list if the patch is in
need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 607557)
Time Spent: 1h 20m (was: 1h 10m)
> Harmonize Hive Date-Time Formats
>
>
> Key: HIVE-24814
> URL: https://issues.apache.org/jira/browse/HIVE-24814
> Project: Hive
> Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Harmonize Hive on JDK date-time formats courtesy of {{DateTimeFormatter}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24814) Harmonize Hive Date-Time Formats
[
https://issues.apache.org/jira/browse/HIVE-24814?focusedWorklogId=559978&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-559978
]
ASF GitHub Bot logged work on HIVE-24814:
-
Author: ASF GitHub Bot
Created on: 02/Mar/21 14:15
Start Date: 02/Mar/21 14:15
Worklog Time Spent: 10m
Work Description: belugabehr commented on pull request #2009:
URL: https://github.com/apache/hive/pull/2009#issuecomment-788939546
@pgaref Thanks for your interest (as always).
The Time parsing/formatting code is all over the place in Hive. Did you
know there are some areas of the code that allow for 10 digits of nanos, by
truncating the last digit, but not others?
I am trying to consolidate all that stuff and bring it into one place for
visibility and trying to harmonize it with the pre-canned ISO formats already
included in the JDK. The less Hive-specific stuff regarding time handling, the
better. I also plan on adding copious documentation once I get the unit tests
all working. I know some of them are broken. I'm having a pretty hard time
figuring out where they are going wrong.
And yes `ISO_LOCAL_TIME` includes an optional NANO field. This will be
mentioned in comments.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 559978)
Time Spent: 1h 10m (was: 1h)
> Harmonize Hive Date-Time Formats
>
>
> Key: HIVE-24814
> URL: https://issues.apache.org/jira/browse/HIVE-24814
> Project: Hive
> Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Harmonize Hive on JDK date-time formats courtesy of {{DateTimeFormatter}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24814) Harmonize Hive Date-Time Formats
[
https://issues.apache.org/jira/browse/HIVE-24814?focusedWorklogId=559940&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-559940
]
ASF GitHub Bot logged work on HIVE-24814:
-
Author: ASF GitHub Bot
Created on: 02/Mar/21 13:06
Start Date: 02/Mar/21 13:06
Worklog Time Spent: 10m
Work Description: pgaref commented on pull request #2009:
URL: https://github.com/apache/hive/pull/2009#issuecomment-788895303
Hey @belugabehr can you please take another look on the .out diffs?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 559940)
Time Spent: 1h (was: 50m)
> Harmonize Hive Date-Time Formats
>
>
> Key: HIVE-24814
> URL: https://issues.apache.org/jira/browse/HIVE-24814
> Project: Hive
> Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Harmonize Hive on JDK date-time formats courtesy of {{DateTimeFormatter}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24814) Harmonize Hive Date-Time Formats
[
https://issues.apache.org/jira/browse/HIVE-24814?focusedWorklogId=559939&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-559939
]
ASF GitHub Bot logged work on HIVE-24814:
-
Author: ASF GitHub Bot
Created on: 02/Mar/21 13:05
Start Date: 02/Mar/21 13:05
Worklog Time Spent: 10m
Work Description: pgaref commented on a change in pull request #2009:
URL: https://github.com/apache/hive/pull/2009#discussion_r585545605
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastTimestampToString.java
##
@@ -28,20 +28,12 @@
import java.time.ZoneOffset;
import java.time.format.DateTimeFormatter;
import java.time.format.DateTimeFormatterBuilder;
-import java.time.temporal.ChronoField;
public class CastTimestampToString extends TimestampToStringUnaryUDF {
private static final long serialVersionUID = 1L;
- private static final DateTimeFormatter PRINT_FORMATTER;
-
- static {
-DateTimeFormatterBuilder builder = new DateTimeFormatterBuilder();
-// Date and time parts
-builder.append(DateTimeFormatter.ofPattern("-MM-dd HH:mm:ss"));
-// Fractional part
-builder.optionalStart().appendFraction(ChronoField.NANO_OF_SECOND, 0, 9,
true).optionalEnd();
-PRINT_FORMATTER = builder.toFormatter();
- }
+ private static final DateTimeFormatter PRINT_FORMATTER =
+ new
DateTimeFormatterBuilder().append(DateTimeFormatter.ISO_LOCAL_DATE).appendLiteral('
')
+ .append(DateTimeFormatter.ISO_LOCAL_TIME).toFormatter();
Review comment:
is optional Nanotime included in ISO_LOCAL_TIME ? Looks likes its
already there: ``.appendFraction(NANO_OF_SECOND, 0, 9, true)``
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 559939)
Time Spent: 50m (was: 40m)
> Harmonize Hive Date-Time Formats
>
>
> Key: HIVE-24814
> URL: https://issues.apache.org/jira/browse/HIVE-24814
> Project: Hive
> Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Harmonize Hive on JDK date-time formats courtesy of {{DateTimeFormatter}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24814) Harmonize Hive Date-Time Formats
[
https://issues.apache.org/jira/browse/HIVE-24814?focusedWorklogId=559938&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-559938
]
ASF GitHub Bot logged work on HIVE-24814:
-
Author: ASF GitHub Bot
Created on: 02/Mar/21 13:03
Start Date: 02/Mar/21 13:03
Worklog Time Spent: 10m
Work Description: pgaref commented on a change in pull request #2009:
URL: https://github.com/apache/hive/pull/2009#discussion_r585545605
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastTimestampToString.java
##
@@ -28,20 +28,12 @@
import java.time.ZoneOffset;
import java.time.format.DateTimeFormatter;
import java.time.format.DateTimeFormatterBuilder;
-import java.time.temporal.ChronoField;
public class CastTimestampToString extends TimestampToStringUnaryUDF {
private static final long serialVersionUID = 1L;
- private static final DateTimeFormatter PRINT_FORMATTER;
-
- static {
-DateTimeFormatterBuilder builder = new DateTimeFormatterBuilder();
-// Date and time parts
-builder.append(DateTimeFormatter.ofPattern("-MM-dd HH:mm:ss"));
-// Fractional part
-builder.optionalStart().appendFraction(ChronoField.NANO_OF_SECOND, 0, 9,
true).optionalEnd();
-PRINT_FORMATTER = builder.toFormatter();
- }
+ private static final DateTimeFormatter PRINT_FORMATTER =
+ new
DateTimeFormatterBuilder().append(DateTimeFormatter.ISO_LOCAL_DATE).appendLiteral('
')
+ .append(DateTimeFormatter.ISO_LOCAL_TIME).toFormatter();
Review comment:
is optional Nanotime included in ISO_LOCAL_TIME ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 559938)
Time Spent: 40m (was: 0.5h)
> Harmonize Hive Date-Time Formats
>
>
> Key: HIVE-24814
> URL: https://issues.apache.org/jira/browse/HIVE-24814
> Project: Hive
> Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Harmonize Hive on JDK date-time formats courtesy of {{DateTimeFormatter}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24814) Harmonize Hive Date-Time Formats
[
https://issues.apache.org/jira/browse/HIVE-24814?focusedWorklogId=557550&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-557550
]
ASF GitHub Bot logged work on HIVE-24814:
-
Author: ASF GitHub Bot
Created on: 24/Feb/21 22:20
Start Date: 24/Feb/21 22:20
Worklog Time Spent: 10m
Work Description: belugabehr opened a new pull request #2009:
URL: https://github.com/apache/hive/pull/2009
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 557550)
Time Spent: 0.5h (was: 20m)
> Harmonize Hive Date-Time Formats
>
>
> Key: HIVE-24814
> URL: https://issues.apache.org/jira/browse/HIVE-24814
> Project: Hive
> Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Harmonize Hive on JDK date-time formats courtesy of {{DateTimeFormatter}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24814) Harmonize Hive Date-Time Formats
[
https://issues.apache.org/jira/browse/HIVE-24814?focusedWorklogId=557547&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-557547
]
ASF GitHub Bot logged work on HIVE-24814:
-
Author: ASF GitHub Bot
Created on: 24/Feb/21 22:19
Start Date: 24/Feb/21 22:19
Worklog Time Spent: 10m
Work Description: belugabehr closed pull request #2009:
URL: https://github.com/apache/hive/pull/2009
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 557547)
Time Spent: 20m (was: 10m)
> Harmonize Hive Date-Time Formats
>
>
> Key: HIVE-24814
> URL: https://issues.apache.org/jira/browse/HIVE-24814
> Project: Hive
> Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Harmonize Hive on JDK date-time formats courtesy of {{DateTimeFormatter}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24814) Harmonize Hive Date-Time Formats
[
https://issues.apache.org/jira/browse/HIVE-24814?focusedWorklogId=556410&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-556410
]
ASF GitHub Bot logged work on HIVE-24814:
-
Author: ASF GitHub Bot
Created on: 23/Feb/21 15:40
Start Date: 23/Feb/21 15:40
Worklog Time Spent: 10m
Work Description: belugabehr opened a new pull request #2009:
URL: https://github.com/apache/hive/pull/2009
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 556410)
Remaining Estimate: 0h
Time Spent: 10m
> Harmonize Hive Date-Time Formats
>
>
> Key: HIVE-24814
> URL: https://issues.apache.org/jira/browse/HIVE-24814
> Project: Hive
> Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Harmonize Hive on JDK date-time formats courtesy of {{DateTimeFormatter}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
