[jira] [Work logged] (HIVE-24944) When the default engine of the hiveserver is MR and the tez engine is set by the client, the client TEZ progress log cannot be printed normally
[ https://issues.apache.org/jira/browse/HIVE-24944?focusedWorklogId=646654=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646654 ] ASF GitHub Bot logged work on HIVE-24944: - Author: ASF GitHub Bot Created on: 05/Sep/21 00:10 Start Date: 05/Sep/21 00:10 Worklog Time Spent: 10m Work Description: github-actions[bot] closed pull request #2204: URL: https://github.com/apache/hive/pull/2204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 646654) Time Spent: 1h 50m (was: 1h 40m) > When the default engine of the hiveserver is MR and the tez engine is set by > the client, the client TEZ progress log cannot be printed normally > --- > > Key: HIVE-24944 > URL: https://issues.apache.org/jira/browse/HIVE-24944 > Project: Hive > Issue Type: Bug > Components: Tez >Affects Versions: 3.1.0, 4.0.0 >Reporter: ZhangQiDong >Assignee: ZhangQiDong >Priority: Major > Labels: pull-request-available > Attachments: HIVE-24944.001.patch, HIVE-24944.002.patch > > Time Spent: 1h 50m > Remaining Estimate: 0h > > HiveServer configuration parameter execution default MR. When set > hive.execution.engine = tez, the client cannot print the TEZ log. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24944) When the default engine of the hiveserver is MR and the tez engine is set by the client, the client TEZ progress log cannot be printed normally
[ https://issues.apache.org/jira/browse/HIVE-24944?focusedWorklogId=643046=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-643046 ] ASF GitHub Bot logged work on HIVE-24944: - Author: ASF GitHub Bot Created on: 28/Aug/21 00:09 Start Date: 28/Aug/21 00:09 Worklog Time Spent: 10m Work Description: github-actions[bot] commented on pull request #2204: URL: https://github.com/apache/hive/pull/2204#issuecomment-907533741 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the d...@hive.apache.org list if the patch is in need of reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 643046) Time Spent: 1h 40m (was: 1.5h) > When the default engine of the hiveserver is MR and the tez engine is set by > the client, the client TEZ progress log cannot be printed normally > --- > > Key: HIVE-24944 > URL: https://issues.apache.org/jira/browse/HIVE-24944 > Project: Hive > Issue Type: Bug > Components: Tez >Affects Versions: 3.1.0, 4.0.0 >Reporter: ZhangQiDong >Assignee: ZhangQiDong >Priority: Major > Labels: pull-request-available > Attachments: HIVE-24944.001.patch, HIVE-24944.002.patch > > Time Spent: 1h 40m > Remaining Estimate: 0h > > HiveServer configuration parameter execution default MR. When set > hive.execution.engine = tez, the client cannot print the TEZ log. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24944) When the default engine of the hiveserver is MR and the tez engine is set by the client, the client TEZ progress log cannot be printed normally
[ https://issues.apache.org/jira/browse/HIVE-24944?focusedWorklogId=615442=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-615442 ] ASF GitHub Bot logged work on HIVE-24944: - Author: ASF GitHub Bot Created on: 28/Jun/21 03:19 Start Date: 28/Jun/21 03:19 Worklog Time Spent: 10m Work Description: dengzhhu653 removed a comment on pull request #2204: URL: https://github.com/apache/hive/pull/2204#issuecomment-869315915 lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 615442) Time Spent: 1.5h (was: 1h 20m) > When the default engine of the hiveserver is MR and the tez engine is set by > the client, the client TEZ progress log cannot be printed normally > --- > > Key: HIVE-24944 > URL: https://issues.apache.org/jira/browse/HIVE-24944 > Project: Hive > Issue Type: Bug > Components: Tez >Affects Versions: 3.1.0, 4.0.0 >Reporter: ZhangQiDong >Assignee: ZhangQiDong >Priority: Major > Labels: pull-request-available > Attachments: HIVE-24944.001.patch, HIVE-24944.002.patch > > Time Spent: 1.5h > Remaining Estimate: 0h > > HiveServer configuration parameter execution default MR. When set > hive.execution.engine = tez, the client cannot print the TEZ log. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24944) When the default engine of the hiveserver is MR and the tez engine is set by the client, the client TEZ progress log cannot be printed normally
[ https://issues.apache.org/jira/browse/HIVE-24944?focusedWorklogId=615441=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-615441 ] ASF GitHub Bot logged work on HIVE-24944: - Author: ASF GitHub Bot Created on: 28/Jun/21 03:18 Start Date: 28/Jun/21 03:18 Worklog Time Spent: 10m Work Description: dengzhhu653 commented on pull request #2204: URL: https://github.com/apache/hive/pull/2204#issuecomment-869315915 lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 615441) Time Spent: 1h 20m (was: 1h 10m) > When the default engine of the hiveserver is MR and the tez engine is set by > the client, the client TEZ progress log cannot be printed normally > --- > > Key: HIVE-24944 > URL: https://issues.apache.org/jira/browse/HIVE-24944 > Project: Hive > Issue Type: Bug > Components: Tez >Affects Versions: 3.1.0, 4.0.0 >Reporter: ZhangQiDong >Assignee: ZhangQiDong >Priority: Major > Labels: pull-request-available > Attachments: HIVE-24944.001.patch, HIVE-24944.002.patch > > Time Spent: 1h 20m > Remaining Estimate: 0h > > HiveServer configuration parameter execution default MR. When set > hive.execution.engine = tez, the client cannot print the TEZ log. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24944) When the default engine of the hiveserver is MR and the tez engine is set by the client, the client TEZ progress log cannot be printed normally
[ https://issues.apache.org/jira/browse/HIVE-24944?focusedWorklogId=615439=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-615439 ] ASF GitHub Bot logged work on HIVE-24944: - Author: ASF GitHub Bot Created on: 28/Jun/21 03:14 Start Date: 28/Jun/21 03:14 Worklog Time Spent: 10m Work Description: dengzhhu653 commented on a change in pull request #2204: URL: https://github.com/apache/hive/pull/2204#discussion_r659451245 ## File path: service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java ## @@ -794,11 +794,20 @@ public TGetOperationStatusResp GetOperationStatus(TGetOperationStatusReq req) th } JobProgressUpdate progressUpdate = operationStatus.jobProgressUpdate(); ProgressMonitorStatusMapper mapper = ProgressMonitorStatusMapper.DEFAULT; - if ("tez".equals(hiveConf.getVar(ConfVars.HIVE_EXECUTION_ENGINE))) { -mapper = new TezProgressMonitorStatusMapper(); - } - if ("spark".equals(hiveConf.getVar(ConfVars.HIVE_EXECUTION_ENGINE))) { -mapper = new SparkProgressMonitorStatusMapper(); + String engineInSessionConf = cliService.getSessionManager().getOperationManager() + .getOperation(operationHandle) + .getParentSession() + .getHiveConf() + .getVar(ConfVars.HIVE_EXECUTION_ENGINE); + switch (engineInSessionConf) { +case "tez": + mapper = new TezProgressMonitorStatusMapper(); + break; +case "spark": + mapper = new SparkProgressMonitorStatusMapper(); + break; +default: Review comment: nit: maybe we could remove the `default` execution path here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 615439) Time Spent: 1h 10m (was: 1h) > When the default engine of the hiveserver is MR and the tez engine is set by > the client, the client TEZ progress log cannot be printed normally > --- > > Key: HIVE-24944 > URL: https://issues.apache.org/jira/browse/HIVE-24944 > Project: Hive > Issue Type: Bug > Components: Tez >Affects Versions: 3.1.0, 4.0.0 >Reporter: ZhangQiDong >Assignee: ZhangQiDong >Priority: Major > Labels: pull-request-available > Attachments: HIVE-24944.001.patch, HIVE-24944.002.patch > > Time Spent: 1h 10m > Remaining Estimate: 0h > > HiveServer configuration parameter execution default MR. When set > hive.execution.engine = tez, the client cannot print the TEZ log. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24944) When the default engine of the hiveserver is MR and the tez engine is set by the client, the client TEZ progress log cannot be printed normally
[ https://issues.apache.org/jira/browse/HIVE-24944?focusedWorklogId=612416=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-612416 ] ASF GitHub Bot logged work on HIVE-24944: - Author: ASF GitHub Bot Created on: 21/Jun/21 02:41 Start Date: 21/Jun/21 02:41 Worklog Time Spent: 10m Work Description: Qidong-Zhang commented on pull request #2204: URL: https://github.com/apache/hive/pull/2204#issuecomment-864681946 Hi @belugabehr @dengzhhu653 @thejasmn @kgyrtkirk @anishek Please check the submission record,thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 612416) Time Spent: 1h (was: 50m) > When the default engine of the hiveserver is MR and the tez engine is set by > the client, the client TEZ progress log cannot be printed normally > --- > > Key: HIVE-24944 > URL: https://issues.apache.org/jira/browse/HIVE-24944 > Project: Hive > Issue Type: Bug > Components: Tez >Affects Versions: 3.1.0, 4.0.0 >Reporter: ZhangQiDong >Assignee: ZhangQiDong >Priority: Major > Labels: pull-request-available > Attachments: HIVE-24944.001.patch, HIVE-24944.002.patch > > Time Spent: 1h > Remaining Estimate: 0h > > HiveServer configuration parameter execution default MR. When set > hive.execution.engine = tez, the client cannot print the TEZ log. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24944) When the default engine of the hiveserver is MR and the tez engine is set by the client, the client TEZ progress log cannot be printed normally
[ https://issues.apache.org/jira/browse/HIVE-24944?focusedWorklogId=604765=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-604765 ] ASF GitHub Bot logged work on HIVE-24944: - Author: ASF GitHub Bot Created on: 01/Jun/21 20:21 Start Date: 01/Jun/21 20:21 Worklog Time Spent: 10m Work Description: belugabehr edited a comment on pull request #2204: URL: https://github.com/apache/hive/pull/2204#issuecomment-852419901 Looks alright. Can you do me a quick favor and switch statement it? ```java switch(engineInSessionConf) { case "tez": case "mr": default: } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 604765) Time Spent: 50m (was: 40m) > When the default engine of the hiveserver is MR and the tez engine is set by > the client, the client TEZ progress log cannot be printed normally > --- > > Key: HIVE-24944 > URL: https://issues.apache.org/jira/browse/HIVE-24944 > Project: Hive > Issue Type: Bug > Components: Tez >Affects Versions: 3.1.0, 4.0.0 >Reporter: ZhangQiDong >Assignee: ZhangQiDong >Priority: Major > Labels: pull-request-available > Attachments: HIVE-24944.001.patch > > Time Spent: 50m > Remaining Estimate: 0h > > HiveServer configuration parameter execution default MR. When set > hive.execution.engine = tez, the client cannot print the TEZ log. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24944) When the default engine of the hiveserver is MR and the tez engine is set by the client, the client TEZ progress log cannot be printed normally
[ https://issues.apache.org/jira/browse/HIVE-24944?focusedWorklogId=604764=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-604764 ] ASF GitHub Bot logged work on HIVE-24944: - Author: ASF GitHub Bot Created on: 01/Jun/21 20:21 Start Date: 01/Jun/21 20:21 Worklog Time Spent: 10m Work Description: belugabehr commented on pull request #2204: URL: https://github.com/apache/hive/pull/2204#issuecomment-852419901 Looks alright. Can you do me a quick favor and case statement it? ```java switch(engineInSessionConf) { case "tez": case "mr": default: } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 604764) Time Spent: 40m (was: 0.5h) > When the default engine of the hiveserver is MR and the tez engine is set by > the client, the client TEZ progress log cannot be printed normally > --- > > Key: HIVE-24944 > URL: https://issues.apache.org/jira/browse/HIVE-24944 > Project: Hive > Issue Type: Bug > Components: Tez >Affects Versions: 3.1.0, 4.0.0 >Reporter: ZhangQiDong >Assignee: ZhangQiDong >Priority: Major > Labels: pull-request-available > Attachments: HIVE-24944.001.patch > > Time Spent: 40m > Remaining Estimate: 0h > > HiveServer configuration parameter execution default MR. When set > hive.execution.engine = tez, the client cannot print the TEZ log. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24944) When the default engine of the hiveserver is MR and the tez engine is set by the client, the client TEZ progress log cannot be printed normally
[ https://issues.apache.org/jira/browse/HIVE-24944?focusedWorklogId=604353=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-604353 ] ASF GitHub Bot logged work on HIVE-24944: - Author: ASF GitHub Bot Created on: 01/Jun/21 07:37 Start Date: 01/Jun/21 07:37 Worklog Time Spent: 10m Work Description: dengzhhu653 commented on pull request #2204: URL: https://github.com/apache/hive/pull/2204#issuecomment-851899226 Hey @thejasmn, @kgyrtkirk could you please take another look if have secs? thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 604353) Time Spent: 0.5h (was: 20m) > When the default engine of the hiveserver is MR and the tez engine is set by > the client, the client TEZ progress log cannot be printed normally > --- > > Key: HIVE-24944 > URL: https://issues.apache.org/jira/browse/HIVE-24944 > Project: Hive > Issue Type: Bug > Components: Tez >Affects Versions: 3.1.0, 4.0.0 >Reporter: ZhangQiDong >Assignee: ZhangQiDong >Priority: Major > Labels: pull-request-available > Attachments: HIVE-24944.001.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > HiveServer configuration parameter execution default MR. When set > hive.execution.engine = tez, the client cannot print the TEZ log. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24944) When the default engine of the hiveserver is MR and the tez engine is set by the client, the client TEZ progress log cannot be printed normally
[ https://issues.apache.org/jira/browse/HIVE-24944?focusedWorklogId=601513=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601513 ] ASF GitHub Bot logged work on HIVE-24944: - Author: ASF GitHub Bot Created on: 25/May/21 03:22 Start Date: 25/May/21 03:22 Worklog Time Spent: 10m Work Description: dengzhhu653 commented on pull request #2204: URL: https://github.com/apache/hive/pull/2204#issuecomment-847499225 Hi @anishek, could you please take another look on the changes? thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 601513) Time Spent: 20m (was: 10m) > When the default engine of the hiveserver is MR and the tez engine is set by > the client, the client TEZ progress log cannot be printed normally > --- > > Key: HIVE-24944 > URL: https://issues.apache.org/jira/browse/HIVE-24944 > Project: Hive > Issue Type: Bug > Components: Tez >Affects Versions: 3.1.0, 4.0.0 >Reporter: ZhangQiDong >Assignee: ZhangQiDong >Priority: Major > Labels: pull-request-available > Attachments: HIVE-24944.001.patch > > Time Spent: 20m > Remaining Estimate: 0h > > HiveServer configuration parameter execution default MR. When set > hive.execution.engine = tez, the client cannot print the TEZ log. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24944) When the default engine of the hiveserver is MR and the tez engine is set by the client, the client TEZ progress log cannot be printed normally
[ https://issues.apache.org/jira/browse/HIVE-24944?focusedWorklogId=587107=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587107 ] ASF GitHub Bot logged work on HIVE-24944: - Author: ASF GitHub Bot Created on: 22/Apr/21 07:57 Start Date: 22/Apr/21 07:57 Worklog Time Spent: 10m Work Description: Qidong-Zhang opened a new pull request #2204: URL: https://github.com/apache/hive/pull/2204 What changes were proposed in this pull request? See the: https://issues.apache.org/jira/browse/HIVE-24944 Why are the changes needed? When the default engine of the hiveserver is MR and the tez engine is set by the client, the client TEZ progress log cannot be printed normally Does this PR introduce any user-facing change? No How was this patch tested? Remote cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587107) Remaining Estimate: 0h Time Spent: 10m > When the default engine of the hiveserver is MR and the tez engine is set by > the client, the client TEZ progress log cannot be printed normally > --- > > Key: HIVE-24944 > URL: https://issues.apache.org/jira/browse/HIVE-24944 > Project: Hive > Issue Type: Bug > Components: Tez >Affects Versions: 3.1.0, 4.0.0 >Reporter: ZhangQiDong >Assignee: ZhangQiDong >Priority: Major > Attachments: HIVE-24944.001.patch > > Time Spent: 10m > Remaining Estimate: 0h > > HiveServer configuration parameter execution default MR. When set > hive.execution.engine = tez, the client cannot print the TEZ log. -- This message was sent by Atlassian Jira (v8.3.4#803005)