[jira] [Work logged] (HIVE-25266) Fix TestWarehouseExternalDir
[ https://issues.apache.org/jira/browse/HIVE-25266?focusedWorklogId=861401=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861401 ] ASF GitHub Bot logged work on HIVE-25266: - Author: ASF GitHub Bot Created on: 10/May/23 16:15 Start Date: 10/May/23 16:15 Worklog Time Spent: 10m Work Description: aturoczy commented on PR #4297: URL: https://github.com/apache/hive/pull/4297#issuecomment-1542479630 I think it needs to be retrigger. Seems like this test is flaky: java.util.NoSuchElementException at java.util.LinkedList.getLast(LinkedList.java:257) at org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testSizeOfDatabaseReplication(TestReplicationScenariosAcidTables.java:3980) at org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testSizeOfDatabaseReplicationViaDistCp(TestReplicationScenariosAcidTables.java:3911) Issue Time Tracking --- Worklog Id: (was: 861401) Time Spent: 2h (was: 1h 50m) > Fix TestWarehouseExternalDir > > > Key: HIVE-25266 > URL: https://issues.apache.org/jira/browse/HIVE-25266 > Project: Hive > Issue Type: Bug >Reporter: Zoltan Haindrich >Priority: Major > Labels: pull-request-available > Time Spent: 2h > Remaining Estimate: 0h > > test is unstable > http://ci.hive.apache.org/job/hive-flaky-check/244/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-25266) Fix TestWarehouseExternalDir
[ https://issues.apache.org/jira/browse/HIVE-25266?focusedWorklogId=861198=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861198 ] ASF GitHub Bot logged work on HIVE-25266: - Author: ASF GitHub Bot Created on: 09/May/23 13:24 Start Date: 09/May/23 13:24 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #4297: URL: https://github.com/apache/hive/pull/4297#issuecomment-1540120257 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_hive=4297) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_hive=4297=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_hive=4297=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=4297=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_hive=4297=coverage=list) No Coverage information [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_hive=4297=duplicated_lines_density=list) No Duplication information Issue Time Tracking --- Worklog Id: (was: 861198) Time Spent: 1h 50m (was: 1h 40m) > Fix TestWarehouseExternalDir > > > Key: HIVE-25266 > URL: https://issues.apache.org/jira/browse/HIVE-25266 > Project: Hive > Issue Type: Bug >Reporter: Zoltan Haindrich >Priority: Major > Labels: pull-request-available > Time Spent: 1h 50m > Remaining Estimate: 0h > > test is unstable > http://ci.hive.apache.org/job/hive-flaky-check/244/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-25266) Fix TestWarehouseExternalDir
[ https://issues.apache.org/jira/browse/HIVE-25266?focusedWorklogId=861178=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861178 ] ASF GitHub Bot logged work on HIVE-25266: - Author: ASF GitHub Bot Created on: 09/May/23 10:37 Start Date: 09/May/23 10:37 Worklog Time Spent: 10m Work Description: rkirtir commented on code in PR #4297: URL: https://github.com/apache/hive/pull/4297#discussion_r1188462611 ## itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestWarehouseExternalDir.java: ## @@ -44,114 +44,94 @@ import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertTrue; - +import org.apache.hadoop.hive.metastore.api.Database; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import org.apache.hadoop.hive.metastore.Warehouse; - -@org.junit.Ignore("HIVE-25266") public class TestWarehouseExternalDir { - private static final Logger LOG = LoggerFactory.getLogger(TestWarehouseExternalDir.class); + private static final Logger LOG = LoggerFactory.getLogger(TestWarehouseExternalDir.class); + + private static MiniHS2 miniHS2; + private static Hive db; - static MiniHS2 miniHS2; - static Hive db; - static Connection conn; + private static HiveConf conf; + private static Connection conn; Review Comment: Agree. Removed unnecessary conn creation and closed connection in afterTest() class Issue Time Tracking --- Worklog Id: (was: 861178) Time Spent: 1h 40m (was: 1.5h) > Fix TestWarehouseExternalDir > > > Key: HIVE-25266 > URL: https://issues.apache.org/jira/browse/HIVE-25266 > Project: Hive > Issue Type: Bug >Reporter: Zoltan Haindrich >Priority: Major > Labels: pull-request-available > Time Spent: 1h 40m > Remaining Estimate: 0h > > test is unstable > http://ci.hive.apache.org/job/hive-flaky-check/244/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-25266) Fix TestWarehouseExternalDir
[ https://issues.apache.org/jira/browse/HIVE-25266?focusedWorklogId=861177=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861177 ] ASF GitHub Bot logged work on HIVE-25266: - Author: ASF GitHub Bot Created on: 09/May/23 10:36 Start Date: 09/May/23 10:36 Worklog Time Spent: 10m Work Description: rkirtir commented on code in PR #4297: URL: https://github.com/apache/hive/pull/4297#discussion_r1188461797 ## itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestWarehouseExternalDir.java: ## @@ -174,19 +155,19 @@ public void testManagedPaths() throws Exception { @Test public void testExternalDefaultPaths() throws Exception { try (Statement stmt = conn.createStatement()) { - stmt.execute("create external table default.twed_ext1(c1 string)"); - Table tab = db.getTable("default", "twed_ext1"); + stmt.execute("create external table IF NOT EXISTS default.twed_ext1(c1 string)"); Review Comment: fixed Issue Time Tracking --- Worklog Id: (was: 861177) Time Spent: 1.5h (was: 1h 20m) > Fix TestWarehouseExternalDir > > > Key: HIVE-25266 > URL: https://issues.apache.org/jira/browse/HIVE-25266 > Project: Hive > Issue Type: Bug >Reporter: Zoltan Haindrich >Priority: Major > Labels: pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > > test is unstable > http://ci.hive.apache.org/job/hive-flaky-check/244/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-25266) Fix TestWarehouseExternalDir
[ https://issues.apache.org/jira/browse/HIVE-25266?focusedWorklogId=861143=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861143 ] ASF GitHub Bot logged work on HIVE-25266: - Author: ASF GitHub Bot Created on: 09/May/23 08:17 Start Date: 09/May/23 08:17 Worklog Time Spent: 10m Work Description: veghlaci05 commented on code in PR #4297: URL: https://github.com/apache/hive/pull/4297#discussion_r1188287825 ## itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestWarehouseExternalDir.java: ## @@ -44,114 +44,94 @@ import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertTrue; - +import org.apache.hadoop.hive.metastore.api.Database; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import org.apache.hadoop.hive.metastore.Warehouse; - -@org.junit.Ignore("HIVE-25266") public class TestWarehouseExternalDir { - private static final Logger LOG = LoggerFactory.getLogger(TestWarehouseExternalDir.class); + private static final Logger LOG = LoggerFactory.getLogger(TestWarehouseExternalDir.class); + + private static MiniHS2 miniHS2; + private static Hive db; - static MiniHS2 miniHS2; - static Hive db; - static Connection conn; + private static HiveConf conf; + private static Connection conn; Review Comment: I would remove this field. 1. `beforeTest()` creates a connection (line 88) 2. This is **_not closed_** but reassigned with a new connection in setUp() (line 119) 3. `tearDown()` closes the connection after every test (but there's only one test) Even despite the lot of maintenance code this results in an unclosed connection. I would simply create and properly close local connection variables both in `beforeTest()` and `testExternalDefaultPaths()` ## itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestWarehouseExternalDir.java: ## @@ -174,19 +155,19 @@ public void testManagedPaths() throws Exception { @Test public void testExternalDefaultPaths() throws Exception { try (Statement stmt = conn.createStatement()) { - stmt.execute("create external table default.twed_ext1(c1 string)"); - Table tab = db.getTable("default", "twed_ext1"); + stmt.execute("create external table IF NOT EXISTS default.twed_ext1(c1 string)"); Review Comment: Why the `if not exists` clause required? Issue Time Tracking --- Worklog Id: (was: 861143) Time Spent: 1h 20m (was: 1h 10m) > Fix TestWarehouseExternalDir > > > Key: HIVE-25266 > URL: https://issues.apache.org/jira/browse/HIVE-25266 > Project: Hive > Issue Type: Bug >Reporter: Zoltan Haindrich >Priority: Major > Labels: pull-request-available > Time Spent: 1h 20m > Remaining Estimate: 0h > > test is unstable > http://ci.hive.apache.org/job/hive-flaky-check/244/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-25266) Fix TestWarehouseExternalDir
[ https://issues.apache.org/jira/browse/HIVE-25266?focusedWorklogId=860907=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-860907 ] ASF GitHub Bot logged work on HIVE-25266: - Author: ASF GitHub Bot Created on: 07/May/23 11:01 Start Date: 07/May/23 11:01 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #4297: URL: https://github.com/apache/hive/pull/4297#issuecomment-1537401930 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_hive=4297) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_hive=4297=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_hive=4297=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=4297=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_hive=4297=coverage=list) No Coverage information [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_hive=4297=duplicated_lines_density=list) No Duplication information Issue Time Tracking --- Worklog Id: (was: 860907) Time Spent: 1h 10m (was: 1h) > Fix TestWarehouseExternalDir > > > Key: HIVE-25266 > URL: https://issues.apache.org/jira/browse/HIVE-25266 > Project: Hive > Issue Type: Bug >Reporter: Zoltan Haindrich >Priority: Major > Labels: pull-request-available > Time Spent: 1h 10m > Remaining Estimate: 0h > > test is unstable > http://ci.hive.apache.org/job/hive-flaky-check/244/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-25266) Fix TestWarehouseExternalDir
[ https://issues.apache.org/jira/browse/HIVE-25266?focusedWorklogId=860891=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-860891 ] ASF GitHub Bot logged work on HIVE-25266: - Author: ASF GitHub Bot Created on: 06/May/23 19:12 Start Date: 06/May/23 19:12 Worklog Time Spent: 10m Work Description: aturoczy commented on PR #4297: URL: https://github.com/apache/hive/pull/4297#issuecomment-1537205061 LGTM Issue Time Tracking --- Worklog Id: (was: 860891) Time Spent: 1h (was: 50m) > Fix TestWarehouseExternalDir > > > Key: HIVE-25266 > URL: https://issues.apache.org/jira/browse/HIVE-25266 > Project: Hive > Issue Type: Bug >Reporter: Zoltan Haindrich >Priority: Major > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > test is unstable > http://ci.hive.apache.org/job/hive-flaky-check/244/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-25266) Fix TestWarehouseExternalDir
[ https://issues.apache.org/jira/browse/HIVE-25266?focusedWorklogId=860856=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-860856 ] ASF GitHub Bot logged work on HIVE-25266: - Author: ASF GitHub Bot Created on: 05/May/23 23:27 Start Date: 05/May/23 23:27 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #4297: URL: https://github.com/apache/hive/pull/4297#issuecomment-1536901198 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_hive=4297) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_hive=4297=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_hive=4297=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=4297=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive=4297=false=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_hive=4297=coverage=list) No Coverage information [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_hive=4297=duplicated_lines_density=list) No Duplication information Issue Time Tracking --- Worklog Id: (was: 860856) Time Spent: 50m (was: 40m) > Fix TestWarehouseExternalDir > > > Key: HIVE-25266 > URL: https://issues.apache.org/jira/browse/HIVE-25266 > Project: Hive > Issue Type: Bug >Reporter: Zoltan Haindrich >Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > test is unstable > http://ci.hive.apache.org/job/hive-flaky-check/244/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-25266) Fix TestWarehouseExternalDir
[ https://issues.apache.org/jira/browse/HIVE-25266?focusedWorklogId=748290=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-748290 ] ASF GitHub Bot logged work on HIVE-25266: - Author: ASF GitHub Bot Created on: 27/Mar/22 00:20 Start Date: 27/Mar/22 00:20 Worklog Time Spent: 10m Work Description: github-actions[bot] closed pull request #2951: URL: https://github.com/apache/hive/pull/2951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 748290) Time Spent: 40m (was: 0.5h) > Fix TestWarehouseExternalDir > > > Key: HIVE-25266 > URL: https://issues.apache.org/jira/browse/HIVE-25266 > Project: Hive > Issue Type: Bug >Reporter: Zoltan Haindrich >Assignee: Mark Bathori >Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > test is unstable > http://ci.hive.apache.org/job/hive-flaky-check/244/ -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (HIVE-25266) Fix TestWarehouseExternalDir
[ https://issues.apache.org/jira/browse/HIVE-25266?focusedWorklogId=744673=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-744673 ] ASF GitHub Bot logged work on HIVE-25266: - Author: ASF GitHub Bot Created on: 20/Mar/22 00:17 Start Date: 20/Mar/22 00:17 Worklog Time Spent: 10m Work Description: github-actions[bot] commented on pull request #2951: URL: https://github.com/apache/hive/pull/2951#issuecomment-1073134916 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the d...@hive.apache.org list if the patch is in need of reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 744673) Time Spent: 0.5h (was: 20m) > Fix TestWarehouseExternalDir > > > Key: HIVE-25266 > URL: https://issues.apache.org/jira/browse/HIVE-25266 > Project: Hive > Issue Type: Bug >Reporter: Zoltan Haindrich >Assignee: Mark Bathori >Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > test is unstable > http://ci.hive.apache.org/job/hive-flaky-check/244/ -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (HIVE-25266) Fix TestWarehouseExternalDir
[ https://issues.apache.org/jira/browse/HIVE-25266?focusedWorklogId=710552=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-710552 ] ASF GitHub Bot logged work on HIVE-25266: - Author: ASF GitHub Bot Created on: 18/Jan/22 14:42 Start Date: 18/Jan/22 14:42 Worklog Time Spent: 10m Work Description: mbathori-cloudera commented on pull request #2951: URL: https://github.com/apache/hive/pull/2951#issuecomment-1015478633 The TestCliDriver[mapjoin_memcheck] test failure seems to be an intermittent issue. It is passing locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 710552) Time Spent: 20m (was: 10m) > Fix TestWarehouseExternalDir > > > Key: HIVE-25266 > URL: https://issues.apache.org/jira/browse/HIVE-25266 > Project: Hive > Issue Type: Bug >Reporter: Zoltan Haindrich >Assignee: Mark Bathori >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > test is unstable > http://ci.hive.apache.org/job/hive-flaky-check/244/ -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (HIVE-25266) Fix TestWarehouseExternalDir
[ https://issues.apache.org/jira/browse/HIVE-25266?focusedWorklogId=710420=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-710420 ] ASF GitHub Bot logged work on HIVE-25266: - Author: ASF GitHub Bot Created on: 18/Jan/22 11:25 Start Date: 18/Jan/22 11:25 Worklog Time Spent: 10m Work Description: mbathori-cloudera opened a new pull request #2951: URL: https://github.com/apache/hive/pull/2951 ### What changes were proposed in this pull request? - moved the initializing parts from the constructor to `BeforeClass` - moved the initializing and closing database connection in `setup`/`teardown` methods - removed unnecessary logging - swapped deprecated warehouse default database location constant ### Why are the changes needed? Fix the flakiness of `TestWarehouseExternalDir` tests. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Run the hive-flaky-check job: http://ci.hive.apache.org/job/hive-flaky-check/509 The tests were executed successfully 87 times, the interrupting error seems to be environment related and not caused by the test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 710420) Remaining Estimate: 0h Time Spent: 10m > Fix TestWarehouseExternalDir > > > Key: HIVE-25266 > URL: https://issues.apache.org/jira/browse/HIVE-25266 > Project: Hive > Issue Type: Bug >Reporter: Zoltan Haindrich >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > test is unstable > http://ci.hive.apache.org/job/hive-flaky-check/244/ -- This message was sent by Atlassian Jira (v8.20.1#820001)