[jira] [Work logged] (HIVE-25329) CTAS creates a managed table as non-ACID table
[ https://issues.apache.org/jira/browse/HIVE-25329?focusedWorklogId=640639&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-640639 ] ASF GitHub Bot logged work on HIVE-25329: - Author: ASF GitHub Bot Created on: 23/Aug/21 09:17 Start Date: 23/Aug/21 09:17 Worklog Time Spent: 10m Work Description: abstractdog commented on a change in pull request #2477: URL: https://github.com/apache/hive/pull/2477#discussion_r693802859 ## File path: ql/src/test/queries/clientpositive/create_table.q ## @@ -0,0 +1,39 @@ +set hive.support.concurrency=true; +set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager; +set hive.create.as.external.legacy=true; + +-- When hive.create.as.external.legacy is true, the tables created with +-- 'managed' or 'transactional' are ACID tables but the tables create +-- without 'managed' and 'transactional' are non-ACID tables. +-- Note: managed non-ACID tables are allowed because tables are not +-- transformed when hive.in.test is true. + +-- Create tables with 'transactional'. These tables have table property +-- 'transactional'='true' +create transactional table test11 as select 1; +show create table test11; +describe formatted test11; + +create transactional table test12 as select 1; Review comment: why are all the test cases duplicated here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 640639) Time Spent: 1h 10m (was: 1h) > CTAS creates a managed table as non-ACID table > -- > > Key: HIVE-25329 > URL: https://issues.apache.org/jira/browse/HIVE-25329 > Project: Hive > Issue Type: Bug >Reporter: Robbie Zhang >Assignee: Robbie Zhang >Priority: Major > Labels: pull-request-available > Time Spent: 1h 10m > Remaining Estimate: 0h > > According to HIVE-22158, MANAGED tables should be ACID tables only. When we > set hive.create.as.external.legacy to true, the query like 'create managed > table as select 1' creates a non-ACID table. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-25329) CTAS creates a managed table as non-ACID table
[
https://issues.apache.org/jira/browse/HIVE-25329?focusedWorklogId=640640&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-640640
]
ASF GitHub Bot logged work on HIVE-25329:
-
Author: ASF GitHub Bot
Created on: 23/Aug/21 09:18
Start Date: 23/Aug/21 09:18
Worklog Time Spent: 10m
Work Description: abstractdog commented on a change in pull request #2477:
URL: https://github.com/apache/hive/pull/2477#discussion_r693803581
##
File path:
iceberg/iceberg-handler/src/test/results/positive/truncate_force_iceberg_table.q.out
##
@@ -85,7 +85,7 @@ Retention:0
A masked pattern was here
Table Type:EXTERNAL_TABLE
Table Parameters:
- COLUMN_STATS_ACCURATE {\"BASIC_STATS\":\"true\"}
+ COLUMN_STATS_ACCURATE
{\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"id\":\"true\",\"value\":\"true\"}}
Review comment:
could you please clarify how is this change related to the code changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 640640)
Time Spent: 1h 20m (was: 1h 10m)
> CTAS creates a managed table as non-ACID table
> --
>
> Key: HIVE-25329
> URL: https://issues.apache.org/jira/browse/HIVE-25329
> Project: Hive
> Issue Type: Bug
>Reporter: Robbie Zhang
>Assignee: Robbie Zhang
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> According to HIVE-22158, MANAGED tables should be ACID tables only. When we
> set hive.create.as.external.legacy to true, the query like 'create managed
> table as select 1' creates a non-ACID table.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-25329) CTAS creates a managed table as non-ACID table
[
https://issues.apache.org/jira/browse/HIVE-25329?focusedWorklogId=641065&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-641065
]
ASF GitHub Bot logged work on HIVE-25329:
-
Author: ASF GitHub Bot
Created on: 24/Aug/21 12:54
Start Date: 24/Aug/21 12:54
Worklog Time Spent: 10m
Work Description: ujc714 commented on a change in pull request #2477:
URL: https://github.com/apache/hive/pull/2477#discussion_r694821704
##
File path:
iceberg/iceberg-handler/src/test/results/positive/truncate_force_iceberg_table.q.out
##
@@ -85,7 +85,7 @@ Retention:0
A masked pattern was here
Table Type:EXTERNAL_TABLE
Table Parameters:
- COLUMN_STATS_ACCURATE {\"BASIC_STATS\":\"true\"}
+ COLUMN_STATS_ACCURATE
{\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"id\":\"true\",\"value\":\"true\"}}
Review comment:
The iceberg tests failed after I rebased. I don't think this change is
related to the code in SemanticAnalyzer.java. HIVE-25276 also changed these
test files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 641065)
Time Spent: 1.5h (was: 1h 20m)
> CTAS creates a managed table as non-ACID table
> --
>
> Key: HIVE-25329
> URL: https://issues.apache.org/jira/browse/HIVE-25329
> Project: Hive
> Issue Type: Bug
>Reporter: Robbie Zhang
>Assignee: Robbie Zhang
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> According to HIVE-22158, MANAGED tables should be ACID tables only. When we
> set hive.create.as.external.legacy to true, the query like 'create managed
> table as select 1' creates a non-ACID table.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-25329) CTAS creates a managed table as non-ACID table
[ https://issues.apache.org/jira/browse/HIVE-25329?focusedWorklogId=641086&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-641086 ] ASF GitHub Bot logged work on HIVE-25329: - Author: ASF GitHub Bot Created on: 24/Aug/21 13:20 Start Date: 24/Aug/21 13:20 Worklog Time Spent: 10m Work Description: ujc714 commented on a change in pull request #2477: URL: https://github.com/apache/hive/pull/2477#discussion_r694842778 ## File path: ql/src/test/queries/clientpositive/create_table.q ## @@ -0,0 +1,39 @@ +set hive.support.concurrency=true; +set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager; +set hive.create.as.external.legacy=true; + +-- When hive.create.as.external.legacy is true, the tables created with +-- 'managed' or 'transactional' are ACID tables but the tables create +-- without 'managed' and 'transactional' are non-ACID tables. +-- Note: managed non-ACID tables are allowed because tables are not +-- transformed when hive.in.test is true. + +-- Create tables with 'transactional'. These tables have table property +-- 'transactional'='true' +create transactional table test11 as select 1; +show create table test11; +describe formatted test11; + +create transactional table test12 as select 1; Review comment: I'll change the test cases then rebase and submit again :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 641086) Time Spent: 1h 40m (was: 1.5h) > CTAS creates a managed table as non-ACID table > -- > > Key: HIVE-25329 > URL: https://issues.apache.org/jira/browse/HIVE-25329 > Project: Hive > Issue Type: Bug >Reporter: Robbie Zhang >Assignee: Robbie Zhang >Priority: Major > Labels: pull-request-available > Time Spent: 1h 40m > Remaining Estimate: 0h > > According to HIVE-22158, MANAGED tables should be ACID tables only. When we > set hive.create.as.external.legacy to true, the query like 'create managed > table as select 1' creates a non-ACID table. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-25329) CTAS creates a managed table as non-ACID table
[ https://issues.apache.org/jira/browse/HIVE-25329?focusedWorklogId=642203&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-642203 ] ASF GitHub Bot logged work on HIVE-25329: - Author: ASF GitHub Bot Created on: 26/Aug/21 08:17 Start Date: 26/Aug/21 08:17 Worklog Time Spent: 10m Work Description: abstractdog merged pull request #2477: URL: https://github.com/apache/hive/pull/2477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 642203) Time Spent: 1h 50m (was: 1h 40m) > CTAS creates a managed table as non-ACID table > -- > > Key: HIVE-25329 > URL: https://issues.apache.org/jira/browse/HIVE-25329 > Project: Hive > Issue Type: Bug >Reporter: Robbie Zhang >Assignee: Robbie Zhang >Priority: Major > Labels: pull-request-available > Time Spent: 1h 50m > Remaining Estimate: 0h > > According to HIVE-22158, MANAGED tables should be ACID tables only. When we > set hive.create.as.external.legacy to true, the query like 'create managed > table as select 1' creates a non-ACID table. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-25329) CTAS creates a managed table as non-ACID table
[ https://issues.apache.org/jira/browse/HIVE-25329?focusedWorklogId=622810&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622810 ] ASF GitHub Bot logged work on HIVE-25329: - Author: ASF GitHub Bot Created on: 15/Jul/21 00:58 Start Date: 15/Jul/21 00:58 Worklog Time Spent: 10m Work Description: ujc714 opened a new pull request #2477: URL: https://github.com/apache/hive/pull/2477 ### What changes were proposed in this pull request? This change makes "create managed table" query to create a managed table regardless of "hive.create.as.external.legacy=true". ### Why are the changes needed? According to HIVE-22158, MANAGED tables should be ACID tables only. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? mvn test -Dtest=TestMiniTezCliDriver -Dqfile=create_table.q -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 622810) Remaining Estimate: 0h Time Spent: 10m > CTAS creates a managed table as non-ACID table > -- > > Key: HIVE-25329 > URL: https://issues.apache.org/jira/browse/HIVE-25329 > Project: Hive > Issue Type: Bug >Reporter: Robbie Zhang >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > According to HIVE-22158, MANAGED tables should be ACID tables only. When we > set hive.create.as.external.legacy to true, the query like 'create managed > table as select 1' creates a non-ACID table. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-25329) CTAS creates a managed table as non-ACID table
[ https://issues.apache.org/jira/browse/HIVE-25329?focusedWorklogId=626466&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-626466 ] ASF GitHub Bot logged work on HIVE-25329: - Author: ASF GitHub Bot Created on: 22/Jul/21 07:52 Start Date: 22/Jul/21 07:52 Worklog Time Spent: 10m Work Description: abstractdog commented on a change in pull request #2477: URL: https://github.com/apache/hive/pull/2477#discussion_r674574563 ## File path: itests/src/test/resources/testconfiguration.properties ## @@ -7,6 +7,7 @@ minimr.query.files=\ # Queries ran by both MiniLlapLocal and MiniTez minitez.query.files.shared=\ compressed_skip_header_footer_aggr.q,\ + create_table.q,\ Review comment: 1. similarly to HIVE-25331, please use TestMiniLlapLocalCliDriver 2. this patch creates the same .q file, please use a different one, otherwise they'll conflict I guess -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 626466) Time Spent: 20m (was: 10m) > CTAS creates a managed table as non-ACID table > -- > > Key: HIVE-25329 > URL: https://issues.apache.org/jira/browse/HIVE-25329 > Project: Hive > Issue Type: Bug >Reporter: Robbie Zhang >Assignee: Robbie Zhang >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > According to HIVE-22158, MANAGED tables should be ACID tables only. When we > set hive.create.as.external.legacy to true, the query like 'create managed > table as select 1' creates a non-ACID table. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-25329) CTAS creates a managed table as non-ACID table
[ https://issues.apache.org/jira/browse/HIVE-25329?focusedWorklogId=626539&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-626539 ] ASF GitHub Bot logged work on HIVE-25329: - Author: ASF GitHub Bot Created on: 22/Jul/21 10:22 Start Date: 22/Jul/21 10:22 Worklog Time Spent: 10m Work Description: abstractdog commented on a change in pull request #2477: URL: https://github.com/apache/hive/pull/2477#discussion_r674674240 ## File path: ql/src/test/queries/clientpositive/create_table.q ## @@ -0,0 +1,5 @@ +set hive.support.concurrency=true; +set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager; +set hive.create.as.external.legacy=true; +create managed table test as select 1; +show create table test; Review comment: could you please add 1. "describe formatted test" to this test case also? 2. your expectation in a comment (before show create table)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 626539) Time Spent: 0.5h (was: 20m) > CTAS creates a managed table as non-ACID table > -- > > Key: HIVE-25329 > URL: https://issues.apache.org/jira/browse/HIVE-25329 > Project: Hive > Issue Type: Bug >Reporter: Robbie Zhang >Assignee: Robbie Zhang >Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > According to HIVE-22158, MANAGED tables should be ACID tables only. When we > set hive.create.as.external.legacy to true, the query like 'create managed > table as select 1' creates a non-ACID table. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-25329) CTAS creates a managed table as non-ACID table
[ https://issues.apache.org/jira/browse/HIVE-25329?focusedWorklogId=626541&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-626541 ] ASF GitHub Bot logged work on HIVE-25329: - Author: ASF GitHub Bot Created on: 22/Jul/21 10:23 Start Date: 22/Jul/21 10:23 Worklog Time Spent: 10m Work Description: abstractdog commented on pull request #2477: URL: https://github.com/apache/hive/pull/2477#issuecomment-884806739 could you please add a CTAS case to q.out, not only a create table? the jira implies that you're taking care of CTAS (too) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 626541) Time Spent: 40m (was: 0.5h) > CTAS creates a managed table as non-ACID table > -- > > Key: HIVE-25329 > URL: https://issues.apache.org/jira/browse/HIVE-25329 > Project: Hive > Issue Type: Bug >Reporter: Robbie Zhang >Assignee: Robbie Zhang >Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > According to HIVE-22158, MANAGED tables should be ACID tables only. When we > set hive.create.as.external.legacy to true, the query like 'create managed > table as select 1' creates a non-ACID table. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-25329) CTAS creates a managed table as non-ACID table
[ https://issues.apache.org/jira/browse/HIVE-25329?focusedWorklogId=626546&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-626546 ] ASF GitHub Bot logged work on HIVE-25329: - Author: ASF GitHub Bot Created on: 22/Jul/21 10:32 Start Date: 22/Jul/21 10:32 Worklog Time Spent: 10m Work Description: abstractdog commented on a change in pull request #2477: URL: https://github.com/apache/hive/pull/2477#discussion_r674674240 ## File path: ql/src/test/queries/clientpositive/create_table.q ## @@ -0,0 +1,5 @@ +set hive.support.concurrency=true; +set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager; +set hive.create.as.external.legacy=true; +create managed table test as select 1; +show create table test; Review comment: could you please add 1. "describe formatted test" to this test case also? 2. your expectation in a comment (before show create table)? 3. a "create table" without managed keyword to confirm that in case of hive.create.as.external.legacy=true, a non-acid managed table will be created -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 626546) Time Spent: 50m (was: 40m) > CTAS creates a managed table as non-ACID table > -- > > Key: HIVE-25329 > URL: https://issues.apache.org/jira/browse/HIVE-25329 > Project: Hive > Issue Type: Bug >Reporter: Robbie Zhang >Assignee: Robbie Zhang >Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > According to HIVE-22158, MANAGED tables should be ACID tables only. When we > set hive.create.as.external.legacy to true, the query like 'create managed > table as select 1' creates a non-ACID table. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-25329) CTAS creates a managed table as non-ACID table
[ https://issues.apache.org/jira/browse/HIVE-25329?focusedWorklogId=626969&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-626969 ] ASF GitHub Bot logged work on HIVE-25329: - Author: ASF GitHub Bot Created on: 23/Jul/21 02:24 Start Date: 23/Jul/21 02:24 Worklog Time Spent: 10m Work Description: ujc714 commented on a change in pull request #2477: URL: https://github.com/apache/hive/pull/2477#discussion_r675271119 ## File path: ql/src/test/queries/clientpositive/create_table.q ## @@ -0,0 +1,5 @@ +set hive.support.concurrency=true; +set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager; +set hive.create.as.external.legacy=true; +create managed table test as select 1; +show create table test; Review comment: Updated the test files as you request and removed the TestMiniTezCliDriver test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 626969) Time Spent: 1h (was: 50m) > CTAS creates a managed table as non-ACID table > -- > > Key: HIVE-25329 > URL: https://issues.apache.org/jira/browse/HIVE-25329 > Project: Hive > Issue Type: Bug >Reporter: Robbie Zhang >Assignee: Robbie Zhang >Priority: Major > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > According to HIVE-22158, MANAGED tables should be ACID tables only. When we > set hive.create.as.external.legacy to true, the query like 'create managed > table as select 1' creates a non-ACID table. -- This message was sent by Atlassian Jira (v8.3.4#803005)
