[jira] [Work logged] (HIVE-25963) Temporary table creation with not null constraint gets converted to external table
[
https://issues.apache.org/jira/browse/HIVE-25963?focusedWorklogId=771080=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-771080
]
ASF GitHub Bot logged work on HIVE-25963:
-
Author: ASF GitHub Bot
Created on: 17/May/22 00:20
Start Date: 17/May/22 00:20
Worklog Time Spent: 10m
Work Description: github-actions[bot] closed pull request #3040:
HIVE-25963: Create temporary table with not null constraint gets converted to
external table
URL: https://github.com/apache/hive/pull/3040
Issue Time Tracking
---
Worklog Id: (was: 771080)
Time Spent: 3h (was: 2h 50m)
> Temporary table creation with not null constraint gets converted to external
> table
> ---
>
> Key: HIVE-25963
> URL: https://issues.apache.org/jira/browse/HIVE-25963
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, Standalone Metastore
>Reporter: Sourabh Goyal
>Assignee: Sourabh Goyal
>Priority: Major
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
> When creating a temporary table with not null, constraint it gets covered to
> external table. For example:
> create temporary table t2 (a int not null);
> table t2' metadata looks like:
> {code:java}
> +---+++
> | col_name| data_type
>| comment |
> +---+++
> | a | int
>||
> | | NULL
>| NULL |
> | # Detailed Table Information | NULL
>| NULL |
> | Database: | default
>| NULL |
> | OwnerType:| USER
>| NULL |
> | Owner:| sourabh
>| NULL |
> | CreateTime: | Tue Feb 15 15:20:13 PST 2022
>| NULL |
> | LastAccessTime: | UNKNOWN
>| NULL |
> | Retention:| 0
>| NULL |
> | Location: |
> hdfs://localhost:9000/tmp/hive/sourabh/80d374a8-cd7a-4fcf-ae72-51b04ff9c3d8/_tmp_space.db/4574446d-c144-48f9-b4b6-2e9ee0ce5be4
> | NULL |
> | Table Type: | EXTERNAL_TABLE
>| NULL |
> | Table Parameters: | NULL
>| NULL |
> | | COLUMN_STATS_ACCURATE
>| {\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"a\":\"true\"}} |
> | | EXTERNAL
>| TRUE |
> | | TRANSLATED_TO_EXTERNAL
>| TRUE |
> | | bucketing_version
>| 2 |
> | | external.table.purge
>| TRUE |
> | | numFiles
>| 0 |
> | | numRows
>| 0 |
> | | rawDataSize
>| 0 |
> | | totalSize
[jira] [Work logged] (HIVE-25963) Temporary table creation with not null constraint gets converted to external table
[
https://issues.apache.org/jira/browse/HIVE-25963?focusedWorklogId=768247=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-768247
]
ASF GitHub Bot logged work on HIVE-25963:
-
Author: ASF GitHub Bot
Created on: 10/May/22 00:20
Start Date: 10/May/22 00:20
Worklog Time Spent: 10m
Work Description: github-actions[bot] commented on PR #3040:
URL: https://github.com/apache/hive/pull/3040#issuecomment-1121708249
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the d...@hive.apache.org list if the patch is in
need of reviews.
Issue Time Tracking
---
Worklog Id: (was: 768247)
Time Spent: 2h 50m (was: 2h 40m)
> Temporary table creation with not null constraint gets converted to external
> table
> ---
>
> Key: HIVE-25963
> URL: https://issues.apache.org/jira/browse/HIVE-25963
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, Standalone Metastore
>Reporter: Sourabh Goyal
>Assignee: Sourabh Goyal
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> When creating a temporary table with not null, constraint it gets covered to
> external table. For example:
> create temporary table t2 (a int not null);
> table t2' metadata looks like:
> {code:java}
> +---+++
> | col_name| data_type
>| comment |
> +---+++
> | a | int
>||
> | | NULL
>| NULL |
> | # Detailed Table Information | NULL
>| NULL |
> | Database: | default
>| NULL |
> | OwnerType:| USER
>| NULL |
> | Owner:| sourabh
>| NULL |
> | CreateTime: | Tue Feb 15 15:20:13 PST 2022
>| NULL |
> | LastAccessTime: | UNKNOWN
>| NULL |
> | Retention:| 0
>| NULL |
> | Location: |
> hdfs://localhost:9000/tmp/hive/sourabh/80d374a8-cd7a-4fcf-ae72-51b04ff9c3d8/_tmp_space.db/4574446d-c144-48f9-b4b6-2e9ee0ce5be4
> | NULL |
> | Table Type: | EXTERNAL_TABLE
>| NULL |
> | Table Parameters: | NULL
>| NULL |
> | | COLUMN_STATS_ACCURATE
>| {\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"a\":\"true\"}} |
> | | EXTERNAL
>| TRUE |
> | | TRANSLATED_TO_EXTERNAL
>| TRUE |
> | | bucketing_version
>| 2 |
> | | external.table.purge
>| TRUE |
> | | numFiles
>| 0 |
> | | numRows
>| 0 |
> |
[jira] [Work logged] (HIVE-25963) Temporary table creation with not null constraint gets converted to external table
[
https://issues.apache.org/jira/browse/HIVE-25963?focusedWorklogId=741940=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-741940
]
ASF GitHub Bot logged work on HIVE-25963:
-
Author: ASF GitHub Bot
Created on: 15/Mar/22 23:06
Start Date: 15/Mar/22 23:06
Worklog Time Spent: 10m
Work Description: sourabh912 closed pull request #3106:
URL: https://github.com/apache/hive/pull/3106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 741940)
Time Spent: 2h 40m (was: 2.5h)
> Temporary table creation with not null constraint gets converted to external
> table
> ---
>
> Key: HIVE-25963
> URL: https://issues.apache.org/jira/browse/HIVE-25963
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, Standalone Metastore
>Reporter: Sourabh Goyal
>Assignee: Sourabh Goyal
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> When creating a temporary table with not null, constraint it gets covered to
> external table. For example:
> create temporary table t2 (a int not null);
> table t2' metadata looks like:
> {code:java}
> +---+++
> | col_name| data_type
>| comment |
> +---+++
> | a | int
>||
> | | NULL
>| NULL |
> | # Detailed Table Information | NULL
>| NULL |
> | Database: | default
>| NULL |
> | OwnerType:| USER
>| NULL |
> | Owner:| sourabh
>| NULL |
> | CreateTime: | Tue Feb 15 15:20:13 PST 2022
>| NULL |
> | LastAccessTime: | UNKNOWN
>| NULL |
> | Retention:| 0
>| NULL |
> | Location: |
> hdfs://localhost:9000/tmp/hive/sourabh/80d374a8-cd7a-4fcf-ae72-51b04ff9c3d8/_tmp_space.db/4574446d-c144-48f9-b4b6-2e9ee0ce5be4
> | NULL |
> | Table Type: | EXTERNAL_TABLE
>| NULL |
> | Table Parameters: | NULL
>| NULL |
> | | COLUMN_STATS_ACCURATE
>| {\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"a\":\"true\"}} |
> | | EXTERNAL
>| TRUE |
> | | TRANSLATED_TO_EXTERNAL
>| TRUE |
> | | bucketing_version
>| 2 |
> | | external.table.purge
>| TRUE |
> | | numFiles
>| 0 |
> | | numRows
>| 0
[jira] [Work logged] (HIVE-25963) Temporary table creation with not null constraint gets converted to external table
[
https://issues.apache.org/jira/browse/HIVE-25963?focusedWorklogId=741939=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-741939
]
ASF GitHub Bot logged work on HIVE-25963:
-
Author: ASF GitHub Bot
Created on: 15/Mar/22 23:06
Start Date: 15/Mar/22 23:06
Worklog Time Spent: 10m
Work Description: sourabh912 commented on pull request #3106:
URL: https://github.com/apache/hive/pull/3106#issuecomment-1068548698
Thank you for approving and merging the PR, @nrg4878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 741939)
Time Spent: 2.5h (was: 2h 20m)
> Temporary table creation with not null constraint gets converted to external
> table
> ---
>
> Key: HIVE-25963
> URL: https://issues.apache.org/jira/browse/HIVE-25963
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, Standalone Metastore
>Reporter: Sourabh Goyal
>Assignee: Sourabh Goyal
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> When creating a temporary table with not null, constraint it gets covered to
> external table. For example:
> create temporary table t2 (a int not null);
> table t2' metadata looks like:
> {code:java}
> +---+++
> | col_name| data_type
>| comment |
> +---+++
> | a | int
>||
> | | NULL
>| NULL |
> | # Detailed Table Information | NULL
>| NULL |
> | Database: | default
>| NULL |
> | OwnerType:| USER
>| NULL |
> | Owner:| sourabh
>| NULL |
> | CreateTime: | Tue Feb 15 15:20:13 PST 2022
>| NULL |
> | LastAccessTime: | UNKNOWN
>| NULL |
> | Retention:| 0
>| NULL |
> | Location: |
> hdfs://localhost:9000/tmp/hive/sourabh/80d374a8-cd7a-4fcf-ae72-51b04ff9c3d8/_tmp_space.db/4574446d-c144-48f9-b4b6-2e9ee0ce5be4
> | NULL |
> | Table Type: | EXTERNAL_TABLE
>| NULL |
> | Table Parameters: | NULL
>| NULL |
> | | COLUMN_STATS_ACCURATE
>| {\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"a\":\"true\"}} |
> | | EXTERNAL
>| TRUE |
> | | TRANSLATED_TO_EXTERNAL
>| TRUE |
> | | bucketing_version
>| 2 |
> | | external.table.purge
>| TRUE |
> | | numFiles
>| 0 |
> | |
[jira] [Work logged] (HIVE-25963) Temporary table creation with not null constraint gets converted to external table
[
https://issues.apache.org/jira/browse/HIVE-25963?focusedWorklogId=741929=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-741929
]
ASF GitHub Bot logged work on HIVE-25963:
-
Author: ASF GitHub Bot
Created on: 15/Mar/22 22:41
Start Date: 15/Mar/22 22:41
Worklog Time Spent: 10m
Work Description: nrg4878 commented on pull request #3106:
URL: https://github.com/apache/hive/pull/3106#issuecomment-1068535542
PR merged. Please close the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 741929)
Time Spent: 2h 20m (was: 2h 10m)
> Temporary table creation with not null constraint gets converted to external
> table
> ---
>
> Key: HIVE-25963
> URL: https://issues.apache.org/jira/browse/HIVE-25963
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, Standalone Metastore
>Reporter: Sourabh Goyal
>Assignee: Sourabh Goyal
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> When creating a temporary table with not null, constraint it gets covered to
> external table. For example:
> create temporary table t2 (a int not null);
> table t2' metadata looks like:
> {code:java}
> +---+++
> | col_name| data_type
>| comment |
> +---+++
> | a | int
>||
> | | NULL
>| NULL |
> | # Detailed Table Information | NULL
>| NULL |
> | Database: | default
>| NULL |
> | OwnerType:| USER
>| NULL |
> | Owner:| sourabh
>| NULL |
> | CreateTime: | Tue Feb 15 15:20:13 PST 2022
>| NULL |
> | LastAccessTime: | UNKNOWN
>| NULL |
> | Retention:| 0
>| NULL |
> | Location: |
> hdfs://localhost:9000/tmp/hive/sourabh/80d374a8-cd7a-4fcf-ae72-51b04ff9c3d8/_tmp_space.db/4574446d-c144-48f9-b4b6-2e9ee0ce5be4
> | NULL |
> | Table Type: | EXTERNAL_TABLE
>| NULL |
> | Table Parameters: | NULL
>| NULL |
> | | COLUMN_STATS_ACCURATE
>| {\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"a\":\"true\"}} |
> | | EXTERNAL
>| TRUE |
> | | TRANSLATED_TO_EXTERNAL
>| TRUE |
> | | bucketing_version
>| 2 |
> | | external.table.purge
>| TRUE |
> | | numFiles
>| 0 |
> | | numRows
[jira] [Work logged] (HIVE-25963) Temporary table creation with not null constraint gets converted to external table
[
https://issues.apache.org/jira/browse/HIVE-25963?focusedWorklogId=741244=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-741244
]
ASF GitHub Bot logged work on HIVE-25963:
-
Author: ASF GitHub Bot
Created on: 14/Mar/22 20:59
Start Date: 14/Mar/22 20:59
Worklog Time Spent: 10m
Work Description: nrg4878 commented on pull request #3106:
URL: https://github.com/apache/hive/pull/3106#issuecomment-1067280988
@sourabh912 looks like this change might still be missing from this patch.
(https://github.com/apache/hive/pull/3040/commits/c45f4100ee3932609063688e573f67f85e677512)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 741244)
Time Spent: 2h 10m (was: 2h)
> Temporary table creation with not null constraint gets converted to external
> table
> ---
>
> Key: HIVE-25963
> URL: https://issues.apache.org/jira/browse/HIVE-25963
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, Standalone Metastore
>Reporter: Sourabh Goyal
>Assignee: Sourabh Goyal
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> When creating a temporary table with not null, constraint it gets covered to
> external table. For example:
> create temporary table t2 (a int not null);
> table t2' metadata looks like:
> {code:java}
> +---+++
> | col_name| data_type
>| comment |
> +---+++
> | a | int
>||
> | | NULL
>| NULL |
> | # Detailed Table Information | NULL
>| NULL |
> | Database: | default
>| NULL |
> | OwnerType:| USER
>| NULL |
> | Owner:| sourabh
>| NULL |
> | CreateTime: | Tue Feb 15 15:20:13 PST 2022
>| NULL |
> | LastAccessTime: | UNKNOWN
>| NULL |
> | Retention:| 0
>| NULL |
> | Location: |
> hdfs://localhost:9000/tmp/hive/sourabh/80d374a8-cd7a-4fcf-ae72-51b04ff9c3d8/_tmp_space.db/4574446d-c144-48f9-b4b6-2e9ee0ce5be4
> | NULL |
> | Table Type: | EXTERNAL_TABLE
>| NULL |
> | Table Parameters: | NULL
>| NULL |
> | | COLUMN_STATS_ACCURATE
>| {\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"a\":\"true\"}} |
> | | EXTERNAL
>| TRUE |
> | | TRANSLATED_TO_EXTERNAL
>| TRUE |
> | | bucketing_version
>| 2 |
> | | external.table.purge
>| TRUE |
> | | numFiles
[jira] [Work logged] (HIVE-25963) Temporary table creation with not null constraint gets converted to external table
[
https://issues.apache.org/jira/browse/HIVE-25963?focusedWorklogId=741215=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-741215
]
ASF GitHub Bot logged work on HIVE-25963:
-
Author: ASF GitHub Bot
Created on: 14/Mar/22 20:29
Start Date: 14/Mar/22 20:29
Worklog Time Spent: 10m
Work Description: sourabh912 commented on pull request #3106:
URL: https://github.com/apache/hive/pull/3106#issuecomment-1067256994
@nrg4878 : Please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 741215)
Time Spent: 2h (was: 1h 50m)
> Temporary table creation with not null constraint gets converted to external
> table
> ---
>
> Key: HIVE-25963
> URL: https://issues.apache.org/jira/browse/HIVE-25963
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, Standalone Metastore
>Reporter: Sourabh Goyal
>Assignee: Sourabh Goyal
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> When creating a temporary table with not null, constraint it gets covered to
> external table. For example:
> create temporary table t2 (a int not null);
> table t2' metadata looks like:
> {code:java}
> +---+++
> | col_name| data_type
>| comment |
> +---+++
> | a | int
>||
> | | NULL
>| NULL |
> | # Detailed Table Information | NULL
>| NULL |
> | Database: | default
>| NULL |
> | OwnerType:| USER
>| NULL |
> | Owner:| sourabh
>| NULL |
> | CreateTime: | Tue Feb 15 15:20:13 PST 2022
>| NULL |
> | LastAccessTime: | UNKNOWN
>| NULL |
> | Retention:| 0
>| NULL |
> | Location: |
> hdfs://localhost:9000/tmp/hive/sourabh/80d374a8-cd7a-4fcf-ae72-51b04ff9c3d8/_tmp_space.db/4574446d-c144-48f9-b4b6-2e9ee0ce5be4
> | NULL |
> | Table Type: | EXTERNAL_TABLE
>| NULL |
> | Table Parameters: | NULL
>| NULL |
> | | COLUMN_STATS_ACCURATE
>| {\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"a\":\"true\"}} |
> | | EXTERNAL
>| TRUE |
> | | TRANSLATED_TO_EXTERNAL
>| TRUE |
> | | bucketing_version
>| 2 |
> | | external.table.purge
>| TRUE |
> | | numFiles
>| 0 |
> | | numRows
[jira] [Work logged] (HIVE-25963) Temporary table creation with not null constraint gets converted to external table
[
https://issues.apache.org/jira/browse/HIVE-25963?focusedWorklogId=741214=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-741214
]
ASF GitHub Bot logged work on HIVE-25963:
-
Author: ASF GitHub Bot
Created on: 14/Mar/22 20:28
Start Date: 14/Mar/22 20:28
Worklog Time Spent: 10m
Work Description: sourabh912 opened a new pull request #3106:
URL: https://github.com/apache/hive/pull/3106
Ported back commits from https://github.com/apache/hive/pull/3040/commits
that are missing in master branch
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 741214)
Time Spent: 1h 50m (was: 1h 40m)
> Temporary table creation with not null constraint gets converted to external
> table
> ---
>
> Key: HIVE-25963
> URL: https://issues.apache.org/jira/browse/HIVE-25963
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, Standalone Metastore
>Reporter: Sourabh Goyal
>Assignee: Sourabh Goyal
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> When creating a temporary table with not null, constraint it gets covered to
> external table. For example:
> create temporary table t2 (a int not null);
> table t2' metadata looks like:
> {code:java}
> +---+++
> | col_name| data_type
>| comment |
> +---+++
> | a | int
>||
> | | NULL
>| NULL |
> | # Detailed Table Information | NULL
>| NULL |
> | Database: | default
>| NULL |
> | OwnerType:| USER
>| NULL |
> | Owner:| sourabh
>| NULL |
> | CreateTime: | Tue Feb 15 15:20:13 PST 2022
>| NULL |
> | LastAccessTime: | UNKNOWN
>| NULL |
> | Retention:| 0
>| NULL |
> | Location: |
> hdfs://localhost:9000/tmp/hive/sourabh/80d374a8-cd7a-4fcf-ae72-51b04ff9c3d8/_tmp_space.db/4574446d-c144-48f9-b4b6-2e9ee0ce5be4
> | NULL |
> | Table Type: | EXTERNAL_TABLE
>| NULL |
> | Table Parameters: | NULL
>| NULL |
> | | COLUMN_STATS_ACCURATE
>| {\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"a\":\"true\"}} |
> | | EXTERNAL
>| TRUE |
> | | TRANSLATED_TO_EXTERNAL
>| TRUE |
> | | bucketing_version
>| 2 |
> | |
[jira] [Work logged] (HIVE-25963) Temporary table creation with not null constraint gets converted to external table
[
https://issues.apache.org/jira/browse/HIVE-25963?focusedWorklogId=739736=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-739736
]
ASF GitHub Bot logged work on HIVE-25963:
-
Author: ASF GitHub Bot
Created on: 10/Mar/22 21:45
Start Date: 10/Mar/22 21:45
Worklog Time Spent: 10m
Work Description: nrg4878 commented on pull request #3040:
URL: https://github.com/apache/hive/pull/3040#issuecomment-1064532858
Fix has been merged. Please close the PR and the jira as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 739736)
Time Spent: 1h 40m (was: 1.5h)
> Temporary table creation with not null constraint gets converted to external
> table
> ---
>
> Key: HIVE-25963
> URL: https://issues.apache.org/jira/browse/HIVE-25963
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, Standalone Metastore
>Reporter: Sourabh Goyal
>Assignee: Sourabh Goyal
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> When creating a temporary table with not null, constraint it gets covered to
> external table. For example:
> create temporary table t2 (a int not null);
> table t2' metadata looks like:
> {code:java}
> +---+++
> | col_name| data_type
>| comment |
> +---+++
> | a | int
>||
> | | NULL
>| NULL |
> | # Detailed Table Information | NULL
>| NULL |
> | Database: | default
>| NULL |
> | OwnerType:| USER
>| NULL |
> | Owner:| sourabh
>| NULL |
> | CreateTime: | Tue Feb 15 15:20:13 PST 2022
>| NULL |
> | LastAccessTime: | UNKNOWN
>| NULL |
> | Retention:| 0
>| NULL |
> | Location: |
> hdfs://localhost:9000/tmp/hive/sourabh/80d374a8-cd7a-4fcf-ae72-51b04ff9c3d8/_tmp_space.db/4574446d-c144-48f9-b4b6-2e9ee0ce5be4
> | NULL |
> | Table Type: | EXTERNAL_TABLE
>| NULL |
> | Table Parameters: | NULL
>| NULL |
> | | COLUMN_STATS_ACCURATE
>| {\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"a\":\"true\"}} |
> | | EXTERNAL
>| TRUE |
> | | TRANSLATED_TO_EXTERNAL
>| TRUE |
> | | bucketing_version
>| 2 |
> | | external.table.purge
>| TRUE |
> | | numFiles
>| 0 |
> |
[jira] [Work logged] (HIVE-25963) Temporary table creation with not null constraint gets converted to external table
[
https://issues.apache.org/jira/browse/HIVE-25963?focusedWorklogId=736218=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-736218
]
ASF GitHub Bot logged work on HIVE-25963:
-
Author: ASF GitHub Bot
Created on: 03/Mar/22 18:44
Start Date: 03/Mar/22 18:44
Worklog Time Spent: 10m
Work Description: sourabh912 commented on a change in pull request #3040:
URL: https://github.com/apache/hive/pull/3040#discussion_r818961752
##
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
##
@@ -1247,31 +1247,11 @@ public void createTable(Table tbl) throws
AlreadyExistsException,
public void createTable(Table tbl, EnvironmentContext envContext) throws
AlreadyExistsException,
InvalidObjectException, MetaException, NoSuchObjectException, TException
{
-if (!tbl.isSetCatName()) {
- tbl.setCatName(getDefaultCatalog(conf));
-}
-HiveMetaHook hook = getHook(tbl);
-if (hook != null) {
- hook.preCreateTable(tbl);
-}
-boolean success = false;
-try {
- // Subclasses can override this step (for example, for temporary tables)
- create_table_with_environment_context(tbl, envContext);
- if (hook != null) {
-hook.commitCreateTable(tbl);
- }
- success = true;
-}
-finally {
- if (!success && (hook != null)) {
-try {
- hook.rollbackCreateTable(tbl);
-} catch (Exception e){
- LOG.error("Create rollback failed with", e);
-}
- }
+CreateTableRequest request = new CreateTableRequest(tbl);
+if (envContext != null) {
+ request.setEnvContext(envContext);
}
+createTable(request);
Review comment:
`createTable(request)` method at line number 1284 is taking care of that
already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 736218)
Time Spent: 1.5h (was: 1h 20m)
> Temporary table creation with not null constraint gets converted to external
> table
> ---
>
> Key: HIVE-25963
> URL: https://issues.apache.org/jira/browse/HIVE-25963
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, Standalone Metastore
>Reporter: Sourabh Goyal
>Assignee: Sourabh Goyal
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> When creating a temporary table with not null, constraint it gets covered to
> external table. For example:
> create temporary table t2 (a int not null);
> table t2' metadata looks like:
> {code:java}
> +---+++
> | col_name| data_type
>| comment |
> +---+++
> | a | int
>||
> | | NULL
>| NULL |
> | # Detailed Table Information | NULL
>| NULL |
> | Database: | default
>| NULL |
> | OwnerType:| USER
>| NULL |
> | Owner:| sourabh
>| NULL |
> | CreateTime: | Tue Feb 15 15:20:13 PST 2022
>| NULL |
> | LastAccessTime: | UNKNOWN
>| NULL |
> | Retention:| 0
>| NULL |
> | Location: |
>
[jira] [Work logged] (HIVE-25963) Temporary table creation with not null constraint gets converted to external table
[
https://issues.apache.org/jira/browse/HIVE-25963?focusedWorklogId=736211=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-736211
]
ASF GitHub Bot logged work on HIVE-25963:
-
Author: ASF GitHub Bot
Created on: 03/Mar/22 18:40
Start Date: 03/Mar/22 18:40
Worklog Time Spent: 10m
Work Description: sourabh912 commented on a change in pull request #3040:
URL: https://github.com/apache/hive/pull/3040#discussion_r818958406
##
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
##
@@ -1247,31 +1247,11 @@ public void createTable(Table tbl) throws
AlreadyExistsException,
public void createTable(Table tbl, EnvironmentContext envContext) throws
AlreadyExistsException,
InvalidObjectException, MetaException, NoSuchObjectException, TException
{
-if (!tbl.isSetCatName()) {
- tbl.setCatName(getDefaultCatalog(conf));
Review comment:
Good catch !
I will add them back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 736211)
Time Spent: 1h 20m (was: 1h 10m)
> Temporary table creation with not null constraint gets converted to external
> table
> ---
>
> Key: HIVE-25963
> URL: https://issues.apache.org/jira/browse/HIVE-25963
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, Standalone Metastore
>Reporter: Sourabh Goyal
>Assignee: Sourabh Goyal
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> When creating a temporary table with not null, constraint it gets covered to
> external table. For example:
> create temporary table t2 (a int not null);
> table t2' metadata looks like:
> {code:java}
> +---+++
> | col_name| data_type
>| comment |
> +---+++
> | a | int
>||
> | | NULL
>| NULL |
> | # Detailed Table Information | NULL
>| NULL |
> | Database: | default
>| NULL |
> | OwnerType:| USER
>| NULL |
> | Owner:| sourabh
>| NULL |
> | CreateTime: | Tue Feb 15 15:20:13 PST 2022
>| NULL |
> | LastAccessTime: | UNKNOWN
>| NULL |
> | Retention:| 0
>| NULL |
> | Location: |
> hdfs://localhost:9000/tmp/hive/sourabh/80d374a8-cd7a-4fcf-ae72-51b04ff9c3d8/_tmp_space.db/4574446d-c144-48f9-b4b6-2e9ee0ce5be4
> | NULL |
> | Table Type: | EXTERNAL_TABLE
>| NULL |
> | Table Parameters: | NULL
>| NULL |
> | | COLUMN_STATS_ACCURATE
>| {\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"a\":\"true\"}} |
> | | EXTERNAL
>| TRUE |
> | | TRANSLATED_TO_EXTERNAL
>
[jira] [Work logged] (HIVE-25963) Temporary table creation with not null constraint gets converted to external table
[
https://issues.apache.org/jira/browse/HIVE-25963?focusedWorklogId=735855=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735855
]
ASF GitHub Bot logged work on HIVE-25963:
-
Author: ASF GitHub Bot
Created on: 03/Mar/22 10:49
Start Date: 03/Mar/22 10:49
Worklog Time Spent: 10m
Work Description: saihemanth-cloudera commented on a change in pull
request #3040:
URL: https://github.com/apache/hive/pull/3040#discussion_r818520185
##
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
##
@@ -1247,31 +1247,11 @@ public void createTable(Table tbl) throws
AlreadyExistsException,
public void createTable(Table tbl, EnvironmentContext envContext) throws
AlreadyExistsException,
InvalidObjectException, MetaException, NoSuchObjectException, TException
{
-if (!tbl.isSetCatName()) {
- tbl.setCatName(getDefaultCatalog(conf));
Review comment:
catalog name needs to be set if it is not set. Can you please add these
lines back?
##
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
##
@@ -1247,31 +1247,11 @@ public void createTable(Table tbl) throws
AlreadyExistsException,
public void createTable(Table tbl, EnvironmentContext envContext) throws
AlreadyExistsException,
InvalidObjectException, MetaException, NoSuchObjectException, TException
{
-if (!tbl.isSetCatName()) {
- tbl.setCatName(getDefaultCatalog(conf));
-}
-HiveMetaHook hook = getHook(tbl);
-if (hook != null) {
- hook.preCreateTable(tbl);
-}
-boolean success = false;
-try {
- // Subclasses can override this step (for example, for temporary tables)
- create_table_with_environment_context(tbl, envContext);
- if (hook != null) {
-hook.commitCreateTable(tbl);
- }
- success = true;
-}
-finally {
- if (!success && (hook != null)) {
-try {
- hook.rollbackCreateTable(tbl);
-} catch (Exception e){
- LOG.error("Create rollback failed with", e);
-}
- }
+CreateTableRequest request = new CreateTableRequest(tbl);
+if (envContext != null) {
+ request.setEnvContext(envContext);
}
+createTable(request);
Review comment:
Can you please add L4448-4451 to the CreateTableRequest object here
before calling the CreateTable() api? We would need to send the processor
capabilities (if available) to HMS.
##
File path:
ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out
##
@@ -6411,53 +6364,16 @@ STAGE PLANS:
expressions: UDFToInteger(key) (type: int)
outputColumnNames: _col0
Statistics: Num rows: 500 Data size: 2000 Basic stats:
COMPLETE Column stats: COMPLETE
-Filter Operator
- predicate: enforce_constraint(_col0 is not null) (type:
boolean)
Review comment:
I think this is the right behavior. Constraints on temp tables will not
be persisted in metastore and hence the explain plan shouldn't show stats e.t.c.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 735855)
Time Spent: 1h 10m (was: 1h)
> Temporary table creation with not null constraint gets converted to external
> table
> ---
>
> Key: HIVE-25963
> URL: https://issues.apache.org/jira/browse/HIVE-25963
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, Standalone Metastore
>Reporter: Sourabh Goyal
>Assignee: Sourabh Goyal
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> When creating a temporary table with not null, constraint it gets covered to
> external table. For example:
> create temporary table t2 (a int not null);
> table t2' metadata looks like:
> {code:java}
> +---+++
> | col_name| data_type
>| comment |
>
[jira] [Work logged] (HIVE-25963) Temporary table creation with not null constraint gets converted to external table
[
https://issues.apache.org/jira/browse/HIVE-25963?focusedWorklogId=735494=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735494
]
ASF GitHub Bot logged work on HIVE-25963:
-
Author: ASF GitHub Bot
Created on: 02/Mar/22 18:48
Start Date: 02/Mar/22 18:48
Worklog Time Spent: 10m
Work Description: sourabh912 commented on pull request #3040:
URL: https://github.com/apache/hive/pull/3040#issuecomment-1057265718
@yongzhi @harishjp @saihemanth-cloudera @hsnusonic : Would appreciate
feedback from you as well !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 735494)
Time Spent: 1h (was: 50m)
> Temporary table creation with not null constraint gets converted to external
> table
> ---
>
> Key: HIVE-25963
> URL: https://issues.apache.org/jira/browse/HIVE-25963
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, Standalone Metastore
>Reporter: Sourabh Goyal
>Assignee: Sourabh Goyal
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When creating a temporary table with not null, constraint it gets covered to
> external table. For example:
> create temporary table t2 (a int not null);
> table t2' metadata looks like:
> {code:java}
> +---+++
> | col_name| data_type
>| comment |
> +---+++
> | a | int
>||
> | | NULL
>| NULL |
> | # Detailed Table Information | NULL
>| NULL |
> | Database: | default
>| NULL |
> | OwnerType:| USER
>| NULL |
> | Owner:| sourabh
>| NULL |
> | CreateTime: | Tue Feb 15 15:20:13 PST 2022
>| NULL |
> | LastAccessTime: | UNKNOWN
>| NULL |
> | Retention:| 0
>| NULL |
> | Location: |
> hdfs://localhost:9000/tmp/hive/sourabh/80d374a8-cd7a-4fcf-ae72-51b04ff9c3d8/_tmp_space.db/4574446d-c144-48f9-b4b6-2e9ee0ce5be4
> | NULL |
> | Table Type: | EXTERNAL_TABLE
>| NULL |
> | Table Parameters: | NULL
>| NULL |
> | | COLUMN_STATS_ACCURATE
>| {\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"a\":\"true\"}} |
> | | EXTERNAL
>| TRUE |
> | | TRANSLATED_TO_EXTERNAL
>| TRUE |
> | | bucketing_version
>| 2 |
> | | external.table.purge
>| TRUE |
> | | numFiles
>| 0
[jira] [Work logged] (HIVE-25963) Temporary table creation with not null constraint gets converted to external table
[
https://issues.apache.org/jira/browse/HIVE-25963?focusedWorklogId=732626=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-732626
]
ASF GitHub Bot logged work on HIVE-25963:
-
Author: ASF GitHub Bot
Created on: 24/Feb/22 19:39
Start Date: 24/Feb/22 19:39
Worklog Time Spent: 10m
Work Description: sourabh912 commented on a change in pull request #3040:
URL: https://github.com/apache/hive/pull/3040#discussion_r814207394
##
File path:
ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out
##
@@ -6411,53 +6364,16 @@ STAGE PLANS:
expressions: UDFToInteger(key) (type: int)
outputColumnNames: _col0
Statistics: Num rows: 500 Data size: 2000 Basic stats:
COMPLETE Column stats: COMPLETE
-Filter Operator
- predicate: enforce_constraint(_col0 is not null) (type:
boolean)
Review comment:
Yes, it means that not null constraint does not have any meaning for
temporary tables. Before this patch, a temp table with constraints was getting
persisted in metastore and therefore had constraint information persisted. But
after this patch, constraints information will get lost for temporary tables
unless we store constraints related info in memory.
@nrg4878 : Is the behavior for temporary table in terms on constraints as
expected after this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 732626)
Time Spent: 50m (was: 40m)
> Temporary table creation with not null constraint gets converted to external
> table
> ---
>
> Key: HIVE-25963
> URL: https://issues.apache.org/jira/browse/HIVE-25963
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, Standalone Metastore
>Reporter: Sourabh Goyal
>Assignee: Sourabh Goyal
>Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> When creating a temporary table with not null, constraint it gets covered to
> external table. For example:
> create temporary table t2 (a int not null);
> table t2' metadata looks like:
> {code:java}
> +---+++
> | col_name| data_type
>| comment |
> +---+++
> | a | int
>||
> | | NULL
>| NULL |
> | # Detailed Table Information | NULL
>| NULL |
> | Database: | default
>| NULL |
> | OwnerType:| USER
>| NULL |
> | Owner:| sourabh
>| NULL |
> | CreateTime: | Tue Feb 15 15:20:13 PST 2022
>| NULL |
> | LastAccessTime: | UNKNOWN
>| NULL |
> | Retention:| 0
>| NULL |
> | Location: |
> hdfs://localhost:9000/tmp/hive/sourabh/80d374a8-cd7a-4fcf-ae72-51b04ff9c3d8/_tmp_space.db/4574446d-c144-48f9-b4b6-2e9ee0ce5be4
> | NULL |
> | Table Type: | EXTERNAL_TABLE
>| NULL |
> | Table Parameters: | NULL
>| NULL
[jira] [Work logged] (HIVE-25963) Temporary table creation with not null constraint gets converted to external table
[
https://issues.apache.org/jira/browse/HIVE-25963?focusedWorklogId=732585=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-732585
]
ASF GitHub Bot logged work on HIVE-25963:
-
Author: ASF GitHub Bot
Created on: 24/Feb/22 18:41
Start Date: 24/Feb/22 18:41
Worklog Time Spent: 10m
Work Description: sourabh912 commented on pull request #3040:
URL: https://github.com/apache/hive/pull/3040#issuecomment-1050149910
The only test `stats_part_multi_insert_acid.q` failing in the latest commit
seems unrelated to this patch because it is failing in other Hive patches too
for example:
http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-3049/1/tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 732585)
Time Spent: 40m (was: 0.5h)
> Temporary table creation with not null constraint gets converted to external
> table
> ---
>
> Key: HIVE-25963
> URL: https://issues.apache.org/jira/browse/HIVE-25963
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, Standalone Metastore
>Reporter: Sourabh Goyal
>Assignee: Sourabh Goyal
>Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When creating a temporary table with not null, constraint it gets covered to
> external table. For example:
> create temporary table t2 (a int not null);
> table t2' metadata looks like:
> {code:java}
> +---+++
> | col_name| data_type
>| comment |
> +---+++
> | a | int
>||
> | | NULL
>| NULL |
> | # Detailed Table Information | NULL
>| NULL |
> | Database: | default
>| NULL |
> | OwnerType:| USER
>| NULL |
> | Owner:| sourabh
>| NULL |
> | CreateTime: | Tue Feb 15 15:20:13 PST 2022
>| NULL |
> | LastAccessTime: | UNKNOWN
>| NULL |
> | Retention:| 0
>| NULL |
> | Location: |
> hdfs://localhost:9000/tmp/hive/sourabh/80d374a8-cd7a-4fcf-ae72-51b04ff9c3d8/_tmp_space.db/4574446d-c144-48f9-b4b6-2e9ee0ce5be4
> | NULL |
> | Table Type: | EXTERNAL_TABLE
>| NULL |
> | Table Parameters: | NULL
>| NULL |
> | | COLUMN_STATS_ACCURATE
>| {\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"a\":\"true\"}} |
> | | EXTERNAL
>| TRUE |
> | | TRANSLATED_TO_EXTERNAL
>| TRUE |
> | | bucketing_version
>| 2 |
> | | external.table.purge
>| TRUE
[jira] [Work logged] (HIVE-25963) Temporary table creation with not null constraint gets converted to external table
[
https://issues.apache.org/jira/browse/HIVE-25963?focusedWorklogId=731990=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-731990
]
ASF GitHub Bot logged work on HIVE-25963:
-
Author: ASF GitHub Bot
Created on: 23/Feb/22 22:55
Start Date: 23/Feb/22 22:55
Worklog Time Spent: 10m
Work Description: hsnusonic commented on a change in pull request #3040:
URL: https://github.com/apache/hive/pull/3040#discussion_r813399086
##
File path:
ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out
##
@@ -6411,53 +6364,16 @@ STAGE PLANS:
expressions: UDFToInteger(key) (type: int)
outputColumnNames: _col0
Statistics: Num rows: 500 Data size: 2000 Basic stats:
COMPLETE Column stats: COMPLETE
-Filter Operator
- predicate: enforce_constraint(_col0 is not null) (type:
boolean)
Review comment:
Does this mean the not null constraint is not applied after the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 731990)
Time Spent: 0.5h (was: 20m)
> Temporary table creation with not null constraint gets converted to external
> table
> ---
>
> Key: HIVE-25963
> URL: https://issues.apache.org/jira/browse/HIVE-25963
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, Standalone Metastore
>Reporter: Sourabh Goyal
>Assignee: Sourabh Goyal
>Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When creating a temporary table with not null, constraint it gets covered to
> external table. For example:
> create temporary table t2 (a int not null);
> table t2' metadata looks like:
> {code:java}
> +---+++
> | col_name| data_type
>| comment |
> +---+++
> | a | int
>||
> | | NULL
>| NULL |
> | # Detailed Table Information | NULL
>| NULL |
> | Database: | default
>| NULL |
> | OwnerType:| USER
>| NULL |
> | Owner:| sourabh
>| NULL |
> | CreateTime: | Tue Feb 15 15:20:13 PST 2022
>| NULL |
> | LastAccessTime: | UNKNOWN
>| NULL |
> | Retention:| 0
>| NULL |
> | Location: |
> hdfs://localhost:9000/tmp/hive/sourabh/80d374a8-cd7a-4fcf-ae72-51b04ff9c3d8/_tmp_space.db/4574446d-c144-48f9-b4b6-2e9ee0ce5be4
> | NULL |
> | Table Type: | EXTERNAL_TABLE
>| NULL |
> | Table Parameters: | NULL
>| NULL |
> | | COLUMN_STATS_ACCURATE
>| {\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"a\":\"true\"}} |
> | | EXTERNAL
>| TRUE |
> | | TRANSLATED_TO_EXTERNAL
[jira] [Work logged] (HIVE-25963) Temporary table creation with not null constraint gets converted to external table
[
https://issues.apache.org/jira/browse/HIVE-25963?focusedWorklogId=729109=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-729109
]
ASF GitHub Bot logged work on HIVE-25963:
-
Author: ASF GitHub Bot
Created on: 17/Feb/22 17:45
Start Date: 17/Feb/22 17:45
Worklog Time Spent: 10m
Work Description: sourabh912 commented on pull request #3040:
URL: https://github.com/apache/hive/pull/3040#issuecomment-1043233911
@nrg4878 : Please review and provide your feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 729109)
Time Spent: 20m (was: 10m)
> Temporary table creation with not null constraint gets converted to external
> table
> ---
>
> Key: HIVE-25963
> URL: https://issues.apache.org/jira/browse/HIVE-25963
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, Standalone Metastore
>Reporter: Sourabh Goyal
>Assignee: Sourabh Goyal
>Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When creating a temporary table with not null, constraint it gets covered to
> external table. For example:
> create temporary table t2 (a int not null);
> table t2' metadata looks like:
> {code:java}
> +---+++
> | col_name| data_type
>| comment |
> +---+++
> | a | int
>||
> | | NULL
>| NULL |
> | # Detailed Table Information | NULL
>| NULL |
> | Database: | default
>| NULL |
> | OwnerType:| USER
>| NULL |
> | Owner:| sourabh
>| NULL |
> | CreateTime: | Tue Feb 15 15:20:13 PST 2022
>| NULL |
> | LastAccessTime: | UNKNOWN
>| NULL |
> | Retention:| 0
>| NULL |
> | Location: |
> hdfs://localhost:9000/tmp/hive/sourabh/80d374a8-cd7a-4fcf-ae72-51b04ff9c3d8/_tmp_space.db/4574446d-c144-48f9-b4b6-2e9ee0ce5be4
> | NULL |
> | Table Type: | EXTERNAL_TABLE
>| NULL |
> | Table Parameters: | NULL
>| NULL |
> | | COLUMN_STATS_ACCURATE
>| {\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"a\":\"true\"}} |
> | | EXTERNAL
>| TRUE |
> | | TRANSLATED_TO_EXTERNAL
>| TRUE |
> | | bucketing_version
>| 2 |
> | | external.table.purge
>| TRUE |
> | | numFiles
>| 0 |
> | |
[jira] [Work logged] (HIVE-25963) Temporary table creation with not null constraint gets converted to external table
[
https://issues.apache.org/jira/browse/HIVE-25963?focusedWorklogId=729108=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-729108
]
ASF GitHub Bot logged work on HIVE-25963:
-
Author: ASF GitHub Bot
Created on: 17/Feb/22 17:44
Start Date: 17/Feb/22 17:44
Worklog Time Spent: 10m
Work Description: sourabh912 opened a new pull request #3040:
URL: https://github.com/apache/hive/pull/3040
### What changes were proposed in this pull request?
This PR fixes an issue in which a temporary table when created with not null
column constraint, gets converted to external table. It is because HMSClient
api createTableWithConstraints() call createTable(createTableRequest) which is
not overriden by SessionHiveMetaStoreClient (which handles temporary tables
creation/fetch/deletion). As a result of which HMS client makes create_table()
RPC call to HMS server which in turn changes the table to external table and
also persists its metadata. This is not the desired behavior because temporary
tables are stored in memory and the metadata for these should not persisted in
HMS.
### Why are the changes needed?
It fixes a bug as described in HIVE-25963
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Enhanced the existing unit tests by adding positive cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 729108)
Remaining Estimate: 0h
Time Spent: 10m
> Temporary table creation with not null constraint gets converted to external
> table
> ---
>
> Key: HIVE-25963
> URL: https://issues.apache.org/jira/browse/HIVE-25963
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, Standalone Metastore
>Reporter: Sourabh Goyal
>Assignee: Sourabh Goyal
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When creating a temporary table with not null, constraint it gets covered to
> external table. For example:
> create temporary table t2 (a int not null);
> table t2' metadata looks like:
> {code:java}
> +---+++
> | col_name| data_type
>| comment |
> +---+++
> | a | int
>||
> | | NULL
>| NULL |
> | # Detailed Table Information | NULL
>| NULL |
> | Database: | default
>| NULL |
> | OwnerType:| USER
>| NULL |
> | Owner:| sourabh
>| NULL |
> | CreateTime: | Tue Feb 15 15:20:13 PST 2022
>| NULL |
> | LastAccessTime: | UNKNOWN
>| NULL |
> | Retention:| 0
>| NULL |
> | Location: |
> hdfs://localhost:9000/tmp/hive/sourabh/80d374a8-cd7a-4fcf-ae72-51b04ff9c3d8/_tmp_space.db/4574446d-c144-48f9-b4b6-2e9ee0ce5be4
> | NULL |
> | Table Type: | EXTERNAL_TABLE
>| NULL |
> | Table Parameters: | NULL
>| NULL |
> | |
