[jira] [Work logged] (HIVE-25997) Build from source distribution archive fails
[
https://issues.apache.org/jira/browse/HIVE-25997?focusedWorklogId=736028&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-736028
]
ASF GitHub Bot logged work on HIVE-25997:
-
Author: ASF GitHub Bot
Created on: 03/Mar/22 14:48
Start Date: 03/Mar/22 14:48
Worklog Time Spent: 10m
Work Description: pvary merged pull request #3067:
URL: https://github.com/apache/hive/pull/3067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 736028)
Time Spent: 1h 20m (was: 1h 10m)
> Build from source distribution archive fails
>
>
> Key: HIVE-25997
> URL: https://issues.apache.org/jira/browse/HIVE-25997
> Project: Hive
> Issue Type: Bug
> Components: Build Infrastructure
>Affects Versions: 4.0.0-alpha-1
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Blocker
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The generated source package is not compiling with:
> {code:java}
> mvn clean install -DskipTests -Piceberg{code}
> We should fix that for the release
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Work logged] (HIVE-25997) Build from source distribution archive fails
[
https://issues.apache.org/jira/browse/HIVE-25997?focusedWorklogId=735832&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735832
]
ASF GitHub Bot logged work on HIVE-25997:
-
Author: ASF GitHub Bot
Created on: 03/Mar/22 09:47
Start Date: 03/Mar/22 09:47
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on a change in pull request #3067:
URL: https://github.com/apache/hive/pull/3067#discussion_r818483784
##
File path: packaging/src/main/assembly/src.xml
##
@@ -100,12 +100,26 @@
storage-api/**/*
standalone-metastore/metastore-common/**/*
standalone-metastore/metastore-server/**/*
+standalone-metastore/metastore-tools/**/*
+standalone-metastore/src/assembly/src.xml
+standalone-metastore/pom.xml
Review comment:
I think we should go what we have - and at least provide something which
do compile in case someone want to do that...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 735832)
Time Spent: 1h 10m (was: 1h)
> Build from source distribution archive fails
>
>
> Key: HIVE-25997
> URL: https://issues.apache.org/jira/browse/HIVE-25997
> Project: Hive
> Issue Type: Bug
> Components: Build Infrastructure
>Affects Versions: 4.0.0-alpha-1
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Blocker
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The generated source package is not compiling with:
> {code:java}
> mvn clean install -DskipTests -Piceberg{code}
> We should fix that for the release
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Work logged] (HIVE-25997) Build from source distribution archive fails
[
https://issues.apache.org/jira/browse/HIVE-25997?focusedWorklogId=735244&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735244
]
ASF GitHub Bot logged work on HIVE-25997:
-
Author: ASF GitHub Bot
Created on: 02/Mar/22 11:46
Start Date: 02/Mar/22 11:46
Worklog Time Spent: 10m
Work Description: pvary commented on pull request #3067:
URL: https://github.com/apache/hive/pull/3067#issuecomment-1056838849
@kgyrtkirk: You wrote:
> can we add the unpack and build commands to the jenkinsfile - so that we
will be checking that the src archive is usable as part of the CI builds?
Shall we do this in this jira?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 735244)
Time Spent: 1h (was: 50m)
> Build from source distribution archive fails
>
>
> Key: HIVE-25997
> URL: https://issues.apache.org/jira/browse/HIVE-25997
> Project: Hive
> Issue Type: Bug
> Components: Build Infrastructure
>Affects Versions: 4.0.0-alpha-1
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Blocker
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The generated source package is not compiling with:
> {code:java}
> mvn clean install -DskipTests -Piceberg{code}
> We should fix that for the release
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Work logged] (HIVE-25997) Build from source distribution archive fails
[
https://issues.apache.org/jira/browse/HIVE-25997?focusedWorklogId=735229&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735229
]
ASF GitHub Bot logged work on HIVE-25997:
-
Author: ASF GitHub Bot
Created on: 02/Mar/22 11:07
Start Date: 02/Mar/22 11:07
Worklog Time Spent: 10m
Work Description: zabetak commented on a change in pull request #3067:
URL: https://github.com/apache/hive/pull/3067#discussion_r817585171
##
File path: packaging/src/main/assembly/src.xml
##
@@ -100,12 +100,26 @@
storage-api/**/*
standalone-metastore/metastore-common/**/*
standalone-metastore/metastore-server/**/*
+standalone-metastore/metastore-tools/**/*
+standalone-metastore/src/assembly/src.xml
+standalone-metastore/pom.xml
Review comment:
I don't know the full story behind these "independent" releases. If we
want from now on to start releasing everything together that's fine with me.
This could even help sanitize a bit the maven structure which is a bit messy at
the moment. I just wanted to bring this up and be sure that what are doing is
intentional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 735229)
Time Spent: 50m (was: 40m)
> Build from source distribution archive fails
>
>
> Key: HIVE-25997
> URL: https://issues.apache.org/jira/browse/HIVE-25997
> Project: Hive
> Issue Type: Bug
> Components: Build Infrastructure
>Affects Versions: 4.0.0-alpha-1
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Blocker
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The generated source package is not compiling with:
> {code:java}
> mvn clean install -DskipTests -Piceberg{code}
> We should fix that for the release
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Work logged] (HIVE-25997) Build from source distribution archive fails
[
https://issues.apache.org/jira/browse/HIVE-25997?focusedWorklogId=735217&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735217
]
ASF GitHub Bot logged work on HIVE-25997:
-
Author: ASF GitHub Bot
Created on: 02/Mar/22 10:48
Start Date: 02/Mar/22 10:48
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on a change in pull request #3067:
URL: https://github.com/apache/hive/pull/3067#discussion_r817570663
##
File path: packaging/src/main/assembly/src.xml
##
@@ -100,12 +100,26 @@
storage-api/**/*
standalone-metastore/metastore-common/**/*
standalone-metastore/metastore-server/**/*
+standalone-metastore/metastore-tools/**/*
+standalone-metastore/src/assembly/src.xml
+standalone-metastore/pom.xml
Review comment:
these modules are not fully separated - meaning they are connected to
the root pom.xml;
if we really want to separate them - we can put them into a new project...
but honestly I think these things were released separetly because there were
no regular Hive releases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 735217)
Time Spent: 40m (was: 0.5h)
> Build from source distribution archive fails
>
>
> Key: HIVE-25997
> URL: https://issues.apache.org/jira/browse/HIVE-25997
> Project: Hive
> Issue Type: Bug
> Components: Build Infrastructure
>Affects Versions: 4.0.0-alpha-1
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Blocker
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The generated source package is not compiling with:
> {code:java}
> mvn clean install -DskipTests -Piceberg{code}
> We should fix that for the release
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Work logged] (HIVE-25997) Build from source distribution archive fails
[
https://issues.apache.org/jira/browse/HIVE-25997?focusedWorklogId=735209&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735209
]
ASF GitHub Bot logged work on HIVE-25997:
-
Author: ASF GitHub Bot
Created on: 02/Mar/22 10:37
Start Date: 02/Mar/22 10:37
Worklog Time Spent: 10m
Work Description: zabetak commented on a change in pull request #3067:
URL: https://github.com/apache/hive/pull/3067#discussion_r817557491
##
File path: packaging/src/main/assembly/src.xml
##
@@ -100,12 +100,26 @@
storage-api/**/*
Review comment:
This is unrelated to the changes here but it is kind of weird that we
are packing in the source packages of Hive a project/module (`storage-api`)
that has it's own release cycle. If we are including the sources here then we
are somewhat releasing the storage-api multiple times.
##
File path: packaging/src/main/assembly/src.xml
##
@@ -100,12 +100,26 @@
storage-api/**/*
standalone-metastore/metastore-common/**/*
standalone-metastore/metastore-server/**/*
+standalone-metastore/metastore-tools/**/*
+standalone-metastore/src/assembly/src.xml
+standalone-metastore/pom.xml
Review comment:
Honestly, I am not sure what is the proper solution here. The
`standalone-metastore` was separated in HIVE-17159 so that it gets its own
release life-cycle. Since 2017, though I don't think this ever happened in
practice. My concern here is the same with `storage-api`. We shouldn't be
releasing the same code twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 735209)
Time Spent: 0.5h (was: 20m)
> Build from source distribution archive fails
>
>
> Key: HIVE-25997
> URL: https://issues.apache.org/jira/browse/HIVE-25997
> Project: Hive
> Issue Type: Bug
> Components: Build Infrastructure
>Affects Versions: 4.0.0-alpha-1
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Blocker
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The generated source package is not compiling with:
> {code:java}
> mvn clean install -DskipTests -Piceberg{code}
> We should fix that for the release
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Work logged] (HIVE-25997) Build from source distribution archive fails
[
https://issues.apache.org/jira/browse/HIVE-25997?focusedWorklogId=735188&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735188
]
ASF GitHub Bot logged work on HIVE-25997:
-
Author: ASF GitHub Bot
Created on: 02/Mar/22 09:42
Start Date: 02/Mar/22 09:42
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on pull request #3067:
URL: https://github.com/apache/hive/pull/3067#issuecomment-1056697160
can we add the unpack and build commands to the jenkinsfile - so that we
will be checking that the src archive is usable as part of the CI builds?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 735188)
Time Spent: 20m (was: 10m)
> Build from source distribution archive fails
>
>
> Key: HIVE-25997
> URL: https://issues.apache.org/jira/browse/HIVE-25997
> Project: Hive
> Issue Type: Bug
> Components: Build Infrastructure
>Affects Versions: 4.0.0-alpha-1
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Blocker
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The generated source package is not compiling with:
> {code:java}
> mvn clean install -DskipTests -Piceberg{code}
> We should fix that for the release
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
