[jira] [Work logged] (HIVE-26468) Cleanup dependency to FlatBuffers
[ https://issues.apache.org/jira/browse/HIVE-26468?focusedWorklogId=807675=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-807675 ] ASF GitHub Bot logged work on HIVE-26468: - Author: ASF GitHub Bot Created on: 10/Sep/22 17:24 Start Date: 10/Sep/22 17:24 Worklog Time Spent: 10m Work Description: ayushtkn merged PR #3517: URL: https://github.com/apache/hive/pull/3517 Issue Time Tracking --- Worklog Id: (was: 807675) Time Spent: 1h (was: 50m) > Cleanup dependency to FlatBuffers > - > > Key: HIVE-26468 > URL: https://issues.apache.org/jira/browse/HIVE-26468 > Project: Hive > Issue Type: Bug >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > Remove issue with overlapping dependencies to FlatBuffers. > Warning inside shading step for hive-jdbc, hive-beeline shows that we have > wring dependencies. Similar issue exists inside hive-serde. > > Simply switch to Google FlatBuffers artefact > > [WARNING] flatbuffers-java-1.9.0.jar, flatbuffers-java-1.6.0.1.jar define 5 > overlapping classes: > [WARNING] - com.google.flatbuffers.Struct > [WARNING] - com.google.flatbuffers.Table$1 > [WARNING] - com.google.flatbuffers.Constants > [WARNING] - com.google.flatbuffers.Table > [WARNING] - com.google.flatbuffers.FlatBufferBuilder -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-26468) Cleanup dependency to FlatBuffers
[
https://issues.apache.org/jira/browse/HIVE-26468?focusedWorklogId=807674=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-807674
]
ASF GitHub Bot logged work on HIVE-26468:
-
Author: ASF GitHub Bot
Created on: 10/Sep/22 17:22
Start Date: 10/Sep/22 17:22
Worklog Time Spent: 10m
Work Description: ayushtkn commented on code in PR #3517:
URL: https://github.com/apache/hive/pull/3517#discussion_r967681034
##
serde/pom.xml:
##
@@ -81,7 +81,7 @@
${hppc.version}
- com.github.davidmoten
+ com.google.flatbuffers
Review Comment:
Should be fine then. Sorry I forgot about this.
Issue Time Tracking
---
Worklog Id: (was: 807674)
Time Spent: 50m (was: 40m)
> Cleanup dependency to FlatBuffers
> -
>
> Key: HIVE-26468
> URL: https://issues.apache.org/jira/browse/HIVE-26468
> Project: Hive
> Issue Type: Bug
>Reporter: Sylwester Lachiewicz
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Remove issue with overlapping dependencies to FlatBuffers.
> Warning inside shading step for hive-jdbc, hive-beeline shows that we have
> wring dependencies. Similar issue exists inside hive-serde.
>
> Simply switch to Google FlatBuffers artefact
>
> [WARNING] flatbuffers-java-1.9.0.jar, flatbuffers-java-1.6.0.1.jar define 5
> overlapping classes:
> [WARNING] - com.google.flatbuffers.Struct
> [WARNING] - com.google.flatbuffers.Table$1
> [WARNING] - com.google.flatbuffers.Constants
> [WARNING] - com.google.flatbuffers.Table
> [WARNING] - com.google.flatbuffers.FlatBufferBuilder
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-26468) Cleanup dependency to FlatBuffers
[
https://issues.apache.org/jira/browse/HIVE-26468?focusedWorklogId=807659=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-807659
]
ASF GitHub Bot logged work on HIVE-26468:
-
Author: ASF GitHub Bot
Created on: 10/Sep/22 14:28
Start Date: 10/Sep/22 14:28
Worklog Time Spent: 10m
Work Description: slachiewicz commented on code in PR #3517:
URL: https://github.com/apache/hive/pull/3517#discussion_r967660927
##
serde/pom.xml:
##
@@ -81,7 +81,7 @@
${hppc.version}
- com.github.davidmoten
+ com.google.flatbuffers
Review Comment:
@ayushtkn anything more I can help with review?
Issue Time Tracking
---
Worklog Id: (was: 807659)
Time Spent: 40m (was: 0.5h)
> Cleanup dependency to FlatBuffers
> -
>
> Key: HIVE-26468
> URL: https://issues.apache.org/jira/browse/HIVE-26468
> Project: Hive
> Issue Type: Bug
>Reporter: Sylwester Lachiewicz
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Remove issue with overlapping dependencies to FlatBuffers.
> Warning inside shading step for hive-jdbc, hive-beeline shows that we have
> wring dependencies. Similar issue exists inside hive-serde.
>
> Simply switch to Google FlatBuffers artefact
>
> [WARNING] flatbuffers-java-1.9.0.jar, flatbuffers-java-1.6.0.1.jar define 5
> overlapping classes:
> [WARNING] - com.google.flatbuffers.Struct
> [WARNING] - com.google.flatbuffers.Table$1
> [WARNING] - com.google.flatbuffers.Constants
> [WARNING] - com.google.flatbuffers.Table
> [WARNING] - com.google.flatbuffers.FlatBufferBuilder
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-26468) Cleanup dependency to FlatBuffers
[
https://issues.apache.org/jira/browse/HIVE-26468?focusedWorklogId=803914=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-803914
]
ASF GitHub Bot logged work on HIVE-26468:
-
Author: ASF GitHub Bot
Created on: 26/Aug/22 11:14
Start Date: 26/Aug/22 11:14
Worklog Time Spent: 10m
Work Description: slachiewicz commented on code in PR #3517:
URL: https://github.com/apache/hive/pull/3517#discussion_r955937007
##
serde/pom.xml:
##
@@ -81,7 +81,7 @@
${hppc.version}
- com.github.davidmoten
+ com.google.flatbuffers
Review Comment:
I don't think so (see warning message in jira ticket), previously for this
module we have 2 dependencies from different groups and shade plugin may select
one of them randomly. My change makes clear to use only official artefacts from
one source.
Issue Time Tracking
---
Worklog Id: (was: 803914)
Time Spent: 0.5h (was: 20m)
> Cleanup dependency to FlatBuffers
> -
>
> Key: HIVE-26468
> URL: https://issues.apache.org/jira/browse/HIVE-26468
> Project: Hive
> Issue Type: Bug
>Reporter: Sylwester Lachiewicz
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Remove issue with overlapping dependencies to FlatBuffers.
> Warning inside shading step for hive-jdbc, hive-beeline shows that we have
> wring dependencies. Similar issue exists inside hive-serde.
>
> Simply switch to Google FlatBuffers artefact
>
> [WARNING] flatbuffers-java-1.9.0.jar, flatbuffers-java-1.6.0.1.jar define 5
> overlapping classes:
> [WARNING] - com.google.flatbuffers.Struct
> [WARNING] - com.google.flatbuffers.Table$1
> [WARNING] - com.google.flatbuffers.Constants
> [WARNING] - com.google.flatbuffers.Table
> [WARNING] - com.google.flatbuffers.FlatBufferBuilder
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-26468) Cleanup dependency to FlatBuffers
[
https://issues.apache.org/jira/browse/HIVE-26468?focusedWorklogId=803913=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-803913
]
ASF GitHub Bot logged work on HIVE-26468:
-
Author: ASF GitHub Bot
Created on: 26/Aug/22 11:10
Start Date: 26/Aug/22 11:10
Worklog Time Spent: 10m
Work Description: ayushtkn commented on code in PR #3517:
URL: https://github.com/apache/hive/pull/3517#discussion_r955933414
##
serde/pom.xml:
##
@@ -81,7 +81,7 @@
${hppc.version}
- com.github.davidmoten
+ com.google.flatbuffers
Review Comment:
does this change introduce any incompatibilities?
Issue Time Tracking
---
Worklog Id: (was: 803913)
Time Spent: 20m (was: 10m)
> Cleanup dependency to FlatBuffers
> -
>
> Key: HIVE-26468
> URL: https://issues.apache.org/jira/browse/HIVE-26468
> Project: Hive
> Issue Type: Bug
>Reporter: Sylwester Lachiewicz
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Remove issue with overlapping dependencies to FlatBuffers.
> Warning inside shading step for hive-jdbc, hive-beeline shows that we have
> wring dependencies. Similar issue exists inside hive-serde.
>
> Simply switch to Google FlatBuffers artefact
>
> [WARNING] flatbuffers-java-1.9.0.jar, flatbuffers-java-1.6.0.1.jar define 5
> overlapping classes:
> [WARNING] - com.google.flatbuffers.Struct
> [WARNING] - com.google.flatbuffers.Table$1
> [WARNING] - com.google.flatbuffers.Constants
> [WARNING] - com.google.flatbuffers.Table
> [WARNING] - com.google.flatbuffers.FlatBufferBuilder
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-26468) Cleanup dependency to FlatBuffers
[ https://issues.apache.org/jira/browse/HIVE-26468?focusedWorklogId=800338=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-800338 ] ASF GitHub Bot logged work on HIVE-26468: - Author: ASF GitHub Bot Created on: 12/Aug/22 15:15 Start Date: 12/Aug/22 15:15 Worklog Time Spent: 10m Work Description: slachiewicz opened a new pull request, #3517: URL: https://github.com/apache/hive/pull/3517 …ith artefact from Google ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? Issue Time Tracking --- Worklog Id: (was: 800338) Remaining Estimate: 0h Time Spent: 10m > Cleanup dependency to FlatBuffers > - > > Key: HIVE-26468 > URL: https://issues.apache.org/jira/browse/HIVE-26468 > Project: Hive > Issue Type: Bug >Reporter: Sylwester Lachiewicz >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Remove issue with overlapping dependencies to FlatBuffers. > Warning inside shading step for hive-jdbc, hive-beeline shows that we have > wring dependencies. Similar issue exists inside hive-serde. > > Simply switch to Google FlatBuffers artefact > > [WARNING] flatbuffers-java-1.9.0.jar, flatbuffers-java-1.6.0.1.jar define 5 > overlapping classes: > [WARNING] - com.google.flatbuffers.Struct > [WARNING] - com.google.flatbuffers.Table$1 > [WARNING] - com.google.flatbuffers.Constants > [WARNING] - com.google.flatbuffers.Table > [WARNING] - com.google.flatbuffers.FlatBufferBuilder -- This message was sent by Atlassian Jira (v8.20.10#820010)
