[GitHub] [hop] hansva commented on pull request #2562: Configuration setting to determine selector field order #2558

2023-03-21 Thread via GitHub


hansva commented on PR #2562:
URL: https://github.com/apache/hop/pull/2562#issuecomment-1477580270

   going to park this until after the release of 2.4


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hop] hansva commented on pull request #2562: Configuration setting to determine selector field order #2558

2023-03-16 Thread via GitHub


hansva commented on PR #2562:
URL: https://github.com/apache/hop/pull/2562#issuecomment-1471878735

   This is awesome work @nadment !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hop] hansva commented on pull request #2562: Configuration setting to determine selector field order #2558

2023-03-14 Thread via GitHub


hansva commented on PR #2562:
URL: https://github.com/apache/hop/pull/2562#issuecomment-1468726282

   Yes that's the suggestion I'm making


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hop] hansva commented on pull request #2562: Configuration setting to determine selector field order #2558

2023-03-14 Thread via GitHub


hansva commented on PR #2562:
URL: https://github.com/apache/hop/pull/2562#issuecomment-1468108827

   couldn't we turn this around and add the check for the option in Const.java ?
   Then it will always be correct for next developement too


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org