Re: [PR] fix #3540 (hop)
usbrandon merged PR #3659: URL: https://github.com/apache/hop/pull/3659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix #3540 (hop)
sramazzina commented on PR #3659: URL: https://github.com/apache/hop/pull/3659#issuecomment-1962103362 I'm sorry I wrote about it on mattermost. I will copy the message here: _"I made some tests this morning and the delete statement do not throws any exception if the target file doesn't exists. I remember I made this change quite some time ago but I pushed only lastly because of the big work released yesterday evening on Static Schema Definitions. Maybe I had already tried the behavior of the delete at that time. In any case it works even if the target file doesn't exists and thanks for pointing me on that. As a developer, tests are always something where I can make things better"_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix #3540 (hop)
usbrandon commented on PR #3659: URL: https://github.com/apache/hop/pull/3659#issuecomment-1960527123 Waiting on an update for the case that the file does not exist, but the box is checked. Making sure a null object is not deleted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix #3540 (hop)
sramazzina commented on PR #3659: URL: https://github.com/apache/hop/pull/3659#issuecomment-1959310877 Basically the overwrite happened without any changes too, I was unable to reproduce the error the reporter experienced. But by performing the test I experienced another issue and that was the reason of the proposed change. Suppose that we are copying a new text file over an existing one: - The target file, present in the destination directory, contained the following sample text: THIS IS A SAMPLE - The file that we are going to copy contains the following text: APACHE HOP The file that resulted after the copy was something like APACHE HOPSAMPLE. Basically, the behavior of the copyFrom API is that it overwrites the file but in terms of bytes. I mean, the first 10 bytes of the target file will be overwritten with the content of the new file (that is 10 byte in size of course). I tried to investigate on the copyFrom API but I wasn0t able to find something related to this behavior. Therefore, for this reason, I decided to delete the target before the copy to be sure that the ovewrite will happen properly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] fix #3540 (hop)
sramazzina opened a new pull request, #3659: URL: https://github.com/apache/hop/pull/3659 fix #3540 copy transform does not overwrite target file Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
