Re: [PR] fix #3867 (hop)
hansva commented on PR #3878: URL: https://github.com/apache/hop/pull/3878#issuecomment-2097758820 right, a mixup happened in the issue number, for reference this is for #3867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix #3867 (hop)
hansva merged PR #3878: URL: https://github.com/apache/hop/pull/3878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix #3867 (hop)
sramazzina commented on PR #3878: URL: https://github.com/apache/hop/pull/3878#issuecomment-2097649857 Yeah I understand and I agree with you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix #3867 (hop)
hansva commented on PR #3878: URL: https://github.com/apache/hop/pull/3878#issuecomment-2097629033 As stated in my previous comment, nothing you can do about it in this ticket. Just some personal frustration flowing out. Thanks for the change LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix #3867 (hop)
sramazzina commented on PR #3878: URL: https://github.com/apache/hop/pull/3878#issuecomment-2097615165 @hansva, unfortunately, the only thing I'm able to fix is the label. Multiple selection (that I agree with you is not completed in the EnterSelectionDialog therefore it cannot be used. About the hieght of the dialog I'm to find out a way to set the height of the dialog but it seems not that easy. Let me know your opinion about confirming to move forward with this improvement or if we want to throw everything away and leave the things as they are. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix #3867 (hop)
sramazzina commented on PR #3878: URL: https://github.com/apache/hop/pull/3878#issuecomment-2095492004 @hansva sorry for the wrong label name I've not noticed :-(. I will change it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix #3867 (hop)
hansva commented on PR #3878: URL: https://github.com/apache/hop/pull/3878#issuecomment-2093077942 TBH... I hate the dialog you used. there are multiple things wrong with that dialog on MacOS: - It expands beyond the reach of your window - when closing it with escape Hop just moves around (and I have to use escape because I can't reach the buttons) - It doesn't allow multi-select which might be useful in this case None of these problems are introduced by you. The only remark I have which you can handle in this PR is the name on the list when opening the dialo:  Should be please select the unit test or something like that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] fix #3867 (hop)
sramazzina opened a new pull request, #3878: URL: https://github.com/apache/hop/pull/3878 fix #3867 - Unit test action: dialog improvement Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
