[GitHub] [incubator-iceberg] rdblue commented on issue #411: Ignore unsupported partition transforms for forward compatibility
rdblue commented on issue #411: Ignore unsupported partition transforms for forward compatibility URL: https://github.com/apache/incubator-iceberg/pull/411#issuecomment-535226233 Got it. Should we add methods that allow you to set the partition name to the builder instead? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
[GitHub] [incubator-iceberg] rdblue commented on issue #411: Ignore unsupported partition transforms for forward compatibility
rdblue commented on issue #411: Ignore unsupported partition transforms for forward compatibility URL: https://github.com/apache/incubator-iceberg/pull/411#issuecomment-535194580 @prodeezy, I thought that method was internal and only used when parsing a spec. I didn't want the public API to have a way to provide a named function that would actually result in adding an unsupported transform that prevents writing to the table. Can you give a bit more context on how you are using this for custom transforms? Maybe we should build an API to register custom transforms? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
[GitHub] [incubator-iceberg] rdblue commented on issue #411: Ignore unsupported partition transforms for forward compatibility
rdblue commented on issue #411: Ignore unsupported partition transforms for forward compatibility URL: https://github.com/apache/incubator-iceberg/pull/411#issuecomment-525813417 Credit for this one should go to @fbocse, who authored the original PR. Looks like that was lost when GitHub did the squash & merge. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
[GitHub] [incubator-iceberg] rdblue commented on issue #411: Ignore unsupported partition transforms for forward compatibility
rdblue commented on issue #411: Ignore unsupported partition transforms for forward compatibility URL: https://github.com/apache/incubator-iceberg/pull/411#issuecomment-525812283 Thanks for reviewing, @aokolnychyi! I'll merge this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
[GitHub] [incubator-iceberg] rdblue commented on issue #411: Ignore unsupported partition transforms for forward compatibility
rdblue commented on issue #411: Ignore unsupported partition transforms for forward compatibility URL: https://github.com/apache/incubator-iceberg/pull/411#issuecomment-525412584 @aokolnychyi, can you review this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
