[PR] Docs: Add GC.ENABLED property [iceberg]

2023-12-06 Thread via GitHub


nk1506 opened a new pull request, #9231:
URL: https://github.com/apache/iceberg/pull/9231

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] Docs: Add gc.enabled property [iceberg]

2024-04-04 Thread via GitHub


nk1506 closed pull request #9231: Docs: Add gc.enabled property
URL: https://github.com/apache/iceberg/pull/9231


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] Docs: Add gc.enabled property [iceberg]

2024-04-04 Thread via GitHub


nk1506 commented on PR #9231:
URL: https://github.com/apache/iceberg/pull/9231#issuecomment-2037765782

   Closing this as this might nor required on doc. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] Docs: Add GC.ENABLED property [iceberg]

2023-12-06 Thread via GitHub


ajantha-bhat commented on code in PR #9231:
URL: https://github.com/apache/iceberg/pull/9231#discussion_r1417117291


##
docs/configuration.md:
##
@@ -111,6 +111,7 @@ Iceberg tables support table properties to configure table 
behavior, like the de
 | history.expire.max-snapshot-age-ms | 43200 (5 days) | Default max age of 
snapshots to keep on the table and all of its branches while expiring snapshots 
|
 | history.expire.min-snapshots-to-keep | 1| Default min number 
of snapshots to keep on the table and all of its branches while expiring 
snapshots |
 | history.expire.max-ref-age-ms  | `Long.MAX_VALUE` (forever) | For 
snapshot references except the `main` branch, default max age of snapshot 
references to keep while expiring snapshots. The `main` branch never expires. |
+| gc.enabled | true | Property to disable 
garbage collection operations such as expiring snapshots or remove orphan files 
|

Review Comment:
   should be "expire" snapshots or "removing" orphan files.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] Docs: Add GC.ENABLED property [iceberg]

2023-12-06 Thread via GitHub


ajantha-bhat commented on PR #9231:
URL: https://github.com/apache/iceberg/pull/9231#issuecomment-1842664896

   PR title can be "gc.enabled" instead of "GC.ENABLED" as properties are case 
sensitive. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org