[jira] [Commented] (IGNITE-4615) Ignite should be compilable under JDK 9

[Denis Magda (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-4615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167149#comment-16167149
 ] 

Denis Magda commented on IGNITE-4615:
-

[~avinogradov], JDK 9 can be released before Ignite 3.0 is rolled out. My 
preference would be to release it earlier.

> Ignite should be compilable under JDK 9
> ---
>
> Key: IGNITE-4615
> URL: https://issues.apache.org/jira/browse/IGNITE-4615
> Project: Ignite
>  Issue Type: Task
>Reporter: Anton Vinogradov
> Fix For: 2.3
>
> Attachments: ignite.jar.dot
>
>
> The original discussion on the dev list:
> http://apache-ignite-developers.2346864.n4.nabble.com/Should-we-take-care-of-Java-9-in-Ignite-2-0-scope-td14018.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6258) .NET: Thin client: Define metadata exchange protocol

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166799#comment-16166799
 ] 

ASF GitHub Bot commented on IGNITE-6258:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/2662


> .NET: Thin client: Define metadata exchange protocol
> 
>
> Key: IGNITE-6258
> URL: https://issues.apache.org/jira/browse/IGNITE-6258
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.3
>
>
> IGNITE-6236 introduced some metadata operations in client protocol.
> Let's formalize these operations:
> * Which operations should be present? PutMeta, PutMetas, GetMeta, GetSchema, 
> etc.
> * Do we need to retrieve schemas separately from entire metadata?
> * Dynamic type registration



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5097) BinaryMarshaller should write ints in "varint" encoding where it makes sense

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166495#comment-16166495
 ] 

Pavel Tupitsyn commented on IGNITE-5097:


[~daradurvs] looks good to me.

> BinaryMarshaller should write ints in "varint" encoding where it makes sense
> 
>
> Key: IGNITE-5097
> URL: https://issues.apache.org/jira/browse/IGNITE-5097
> Project: Ignite
>  Issue Type: Task
>  Components: general
>Affects Versions: 2.0
>Reporter: Vladimir Ozerov
>Assignee: Vyacheslav Daradur
>  Labels: important, performance
> Fix For: 2.3
>
>
> There are a lot of places in the code where we write integers for some 
> special purposes. Quite often their value will be vary small, so that 
> applying "varint" format could save a lot of space at the cost of very low 
> additional CPU overhead. 
> Specifically:
> 1) Array/collection/map lengths
> 2) BigDecimal's (usually will save ~6 bytes)
> 3) Strings
> 4) Enum ordinals



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6209) .NET: Build NuGet packages for Apache-Ignite release on CI

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166447#comment-16166447
 ] 

Pavel Tupitsyn commented on IGNITE-6209:


The plan is:
1) Download source distro from step #3, unpack only platforms\dotnet
2) Download binary distro from step #3, unpack only libs folder (jars)
3) Download .NET binaries, unpack to corresponding folders (bin\Release of each 
project)
4) run {{build -skipJava -skipDotNet}} to build NuGet packages from existing 
binaries

This requires build.ps1 modification: add {{skipDotNet}} and {{jarFolders}} 
parameters.

> .NET: Build NuGet packages for Apache-Ignite release on CI
> --
>
> Key: IGNITE-6209
> URL: https://issues.apache.org/jira/browse/IGNITE-6209
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Oleg Ostanin
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.3
>
>
> Create a suite to build Ignite.NET NuGet packages on TeamCity: 
> https://ci.ignite.apache.org/project.html?projectId=IgniteRelease



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6258) .NET: Thin client: Define metadata exchange protocol

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166441#comment-16166441
 ] 

Pavel Tupitsyn commented on IGNITE-6258:


Fixed, merged to ignite-5896: {{54b1cc233882bcbc1d3ce2c1d42f1a873eee49d1}}

> .NET: Thin client: Define metadata exchange protocol
> 
>
> Key: IGNITE-6258
> URL: https://issues.apache.org/jira/browse/IGNITE-6258
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.3
>
>
> IGNITE-6236 introduced some metadata operations in client protocol.
> Let's formalize these operations:
> * Which operations should be present? PutMeta, PutMetas, GetMeta, GetSchema, 
> etc.
> * Do we need to retrieve schemas separately from entire metadata?
> * Dynamic type registration



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6385) Offheap page eviction doesn't work if data is loaded without data streamer

[Igor Seliverstov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166438#comment-16166438
 ] 

Igor Seliverstov commented on IGNITE-6385:
--

[~ivan.glukos], looks fine to me.

> Offheap page eviction doesn't work if data is loaded without data streamer
> --
>
> Key: IGNITE-6385
> URL: https://issues.apache.org/jira/browse/IGNITE-6385
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.3
>Reporter: Ivan Rakov
>Assignee: Ivan Rakov
> Fix For: 2.3
>
>
> Page eviction was broken by recent optimizations from IGNITE-5658. We can 
> allocate data pages if there are empty pages in separate stripe of free list 
> bucket.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6385) Offheap page eviction doesn't work if data is loaded without data streamer

[Ivan Rakov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166429#comment-16166429
 ] 

Ivan Rakov commented on IGNITE-6385:


Please, review.
TC run: https://ci.ignite.apache.org/viewQueued.html?itemId=829651

> Offheap page eviction doesn't work if data is loaded without data streamer
> --
>
> Key: IGNITE-6385
> URL: https://issues.apache.org/jira/browse/IGNITE-6385
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.3
>Reporter: Ivan Rakov
>Assignee: Ivan Rakov
> Fix For: 2.3
>
>
> Page eviction was broken by recent optimizations from IGNITE-5658. We can 
> allocate data pages if there are empty pages in separate stripe of free list 
> bucket.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6385) Offheap page eviction doesn't work if data is loaded without data streamer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166419#comment-16166419
 ] 

ASF GitHub Bot commented on IGNITE-6385:


GitHub user glukos opened a pull request:

https://github.com/apache/ignite/pull/2666

IGNITE-6385 Offheap page eviction doesn't work if data is loaded without 
data streamer



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-6385

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/2666.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2666


commit be389f378bc12a1aa9264799eebaa2551741448d
Author: Ivan Rakov 
Date:   2017-09-14T15:02:12Z

IGNITE-6385 Offheap page eviction doesn't work if data is loaded without 
data streamer




> Offheap page eviction doesn't work if data is loaded without data streamer
> --
>
> Key: IGNITE-6385
> URL: https://issues.apache.org/jira/browse/IGNITE-6385
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.3
>Reporter: Ivan Rakov
>Assignee: Ivan Rakov
> Fix For: 2.3
>
>
> Page eviction was broken by recent optimizations from IGNITE-5658. We can 
> allocate data pages if there are empty pages in separate stripe of free list 
> bucket.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (IGNITE-6386) Introduction of distributed neural networks.

[Yury Babak (JIRA)]

Yury Babak created IGNITE-6386:
--

 Summary: Introduction of distributed neural networks.
 Key: IGNITE-6386
 URL: https://issues.apache.org/jira/browse/IGNITE-6386
 Project: Ignite
  Issue Type: New Feature
  Components: ml
Reporter: Yury Babak
 Fix For: 2.3


We want to have deep learning algorithms and for this we need to implement 
neural network over Apache Ignite. Currently we think about using 
[dl4j|https://deeplearning4j.org] as backend but in this case we cannot  train 
one model over multiple nodes efficiently. Also we will think about 
integration/connector with dl4j.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (IGNITE-6385) Offheap page eviction is broken in case loading data without data streamer

[Ivan Rakov (JIRA)]

Ivan Rakov created IGNITE-6385:
--

 Summary: Offheap page eviction is broken in case loading data 
without data streamer
 Key: IGNITE-6385
 URL: https://issues.apache.org/jira/browse/IGNITE-6385
 Project: Ignite
  Issue Type: Bug
Affects Versions: 2.3
Reporter: Ivan Rakov
Assignee: Ivan Rakov
 Fix For: 2.3


Page eviction was broken by recent optimizations from IGNITE-5658. We can 
allocate data pages if there are empty pages in separate stripe of free list 
bucket.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (IGNITE-6385) Offheap page eviction doesn't work if data is loaded without data streamer

[Ivan Rakov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/IGNITE-6385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ivan Rakov updated IGNITE-6385:
---
Summary: Offheap page eviction doesn't work if data is loaded without data 
streamer  (was: Offheap page eviction is broken in case loading data without 
data streamer)

> Offheap page eviction doesn't work if data is loaded without data streamer
> --
>
> Key: IGNITE-6385
> URL: https://issues.apache.org/jira/browse/IGNITE-6385
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.3
>Reporter: Ivan Rakov
>Assignee: Ivan Rakov
> Fix For: 2.3
>
>
> Page eviction was broken by recent optimizations from IGNITE-5658. We can 
> allocate data pages if there are empty pages in separate stripe of free list 
> bucket.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5097) BinaryMarshaller should write ints in "varint" encoding where it makes sense

[Vyacheslav Daradur (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166373#comment-16166373
 ] 

Vyacheslav Daradur commented on IGNITE-5097:


[~ptupitsyn], thank you for the notes!
I've fixed code style notes and have removed unused import.
If you have a minute, please, check it once again. Thanks!

bq. 4) Could not compile Java (mvn clean package)
It's not related to my changes and as I can see the compilation is already 
fixed in the master branch by [a 
commit|https://github.com/apache/ignite/commit/e4e0a280853b896f32ae3d85545f83faeb7aa680].

> BinaryMarshaller should write ints in "varint" encoding where it makes sense
> 
>
> Key: IGNITE-5097
> URL: https://issues.apache.org/jira/browse/IGNITE-5097
> Project: Ignite
>  Issue Type: Task
>  Components: general
>Affects Versions: 2.0
>Reporter: Vladimir Ozerov
>Assignee: Vyacheslav Daradur
>  Labels: important, performance
> Fix For: 2.3
>
>
> There are a lot of places in the code where we write integers for some 
> special purposes. Quite often their value will be vary small, so that 
> applying "varint" format could save a lot of space at the cost of very low 
> additional CPU overhead. 
> Specifically:
> 1) Array/collection/map lengths
> 2) BigDecimal's (usually will save ~6 bytes)
> 3) Strings
> 4) Enum ordinals



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (IGNITE-6277) Convert WAL to human readable form

[Eduard Shangareev (JIRA)]

 [ 
https://issues.apache.org/jira/browse/IGNITE-6277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eduard Shangareev reassigned IGNITE-6277:
-

Assignee: Alexey Goncharuk  (was: Eduard Shangareev)

> Convert WAL to human readable form
> --
>
> Key: IGNITE-6277
> URL: https://issues.apache.org/jira/browse/IGNITE-6277
> Project: Ignite
>  Issue Type: Bug
>  Components: persistence
>Affects Versions: 2.1
>Reporter: Eduard Shangareev
>Assignee: Alexey Goncharuk
> Fix For: 2.3
>
>
> Now there is no way to make wal visible or understandable without coding.
> I propose to write utility which would convert any given compatible WAL to 
> textual form.
> Something like this:
> {code}
> [W] InsertRecord [idx=19, io=H2ExtrasLeafIO[ver=1], rightId=, 
> super=PageDeltaRecord [grpId=2141373875, pageId=00020011, 
> super=WALRecord [size=61, chainSize=0, pos=FileWALPointer [idx=0, 
> fileOffset=2504497, len=61, forceFlush=false], type=BTREE_PAGE_INSERT]]]
> [W] DataRecord [writeEntries=[DataEntry [op=CREATE, writeVer=GridCacheVersion 
> [topVer=116006687, order=0, nodeOrder=1], partId=29, partCnt=33]], 
> super=WALRecord [size=171, chainSize=0, pos=FileWALPointer [idx=0, 
> fileOffset=2504558, len=171, forceFlush=false], type=DATA_RECORD]]
> [W] PagesListRemovePageRecord [rmvdPageId=0001000c002f, 
> pageId=0001000c000a, grpId=-1368047377, super=PageDeltaRecord 
> [grpId=-1368047377, pageId=0001000c000a, super=WALRecord [size=37, 
> chainSize=0, pos=FileWALPointer [idx=0, fileOffset=2504729, len=37, 
> forceFlush=false], type=PAGES_LIST_REMOVE_PAGE]]]
> [W] DataPageInsertRecord [super=PageDeltaRecord [grpId=-1368047377, 
> pageId=0001000c002f, super=WALRecord [size=76, chainSize=0, 
> pos=FileWALPointer [idx=0, fileOffset=2504766, len=76, forceFlush=false], 
> type=DATA_PAGE_INSERT_RECORD]]]
> [W] PagesListAddPageRecord [dataPageId=0001000c002f, 
> super=PageDeltaRecord [grpId=-1368047377, pageId=0001000c000b, 
> super=WALRecord [size=37, chainSize=0, pos=FileWALPointer [idx=0, 
> fileOffset=2504842, len=37, forceFlush=false], type=PAGES_LIST_ADD_PAGE]]]
> [W] DataPageSetFreeListPageRecord [freeListPage=281526516318219, 
> super=PageDeltaRecord [grpId=-1368047377, pageId=0001000c002f, 
> super=WALRecord [size=37, chainSize=0, pos=FileWALPointer [idx=0, 
> fileOffset=2504879, len=37, forceFlush=false], 
> type=DATA_PAGE_SET_FREE_LIST_PAGE]]]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6277) Convert WAL to human readable form

[Eduard Shangareev (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166311#comment-16166311
 ] 

Eduard Shangareev commented on IGNITE-6277:
---

So, I think, the first version of the converter is ready to review.

Please, review!

> Convert WAL to human readable form
> --
>
> Key: IGNITE-6277
> URL: https://issues.apache.org/jira/browse/IGNITE-6277
> Project: Ignite
>  Issue Type: Bug
>  Components: persistence
>Affects Versions: 2.1
>Reporter: Eduard Shangareev
>Assignee: Eduard Shangareev
> Fix For: 2.3
>
>
> Now there is no way to make wal visible or understandable without coding.
> I propose to write utility which would convert any given compatible WAL to 
> textual form.
> Something like this:
> {code}
> [W] InsertRecord [idx=19, io=H2ExtrasLeafIO[ver=1], rightId=, 
> super=PageDeltaRecord [grpId=2141373875, pageId=00020011, 
> super=WALRecord [size=61, chainSize=0, pos=FileWALPointer [idx=0, 
> fileOffset=2504497, len=61, forceFlush=false], type=BTREE_PAGE_INSERT]]]
> [W] DataRecord [writeEntries=[DataEntry [op=CREATE, writeVer=GridCacheVersion 
> [topVer=116006687, order=0, nodeOrder=1], partId=29, partCnt=33]], 
> super=WALRecord [size=171, chainSize=0, pos=FileWALPointer [idx=0, 
> fileOffset=2504558, len=171, forceFlush=false], type=DATA_RECORD]]
> [W] PagesListRemovePageRecord [rmvdPageId=0001000c002f, 
> pageId=0001000c000a, grpId=-1368047377, super=PageDeltaRecord 
> [grpId=-1368047377, pageId=0001000c000a, super=WALRecord [size=37, 
> chainSize=0, pos=FileWALPointer [idx=0, fileOffset=2504729, len=37, 
> forceFlush=false], type=PAGES_LIST_REMOVE_PAGE]]]
> [W] DataPageInsertRecord [super=PageDeltaRecord [grpId=-1368047377, 
> pageId=0001000c002f, super=WALRecord [size=76, chainSize=0, 
> pos=FileWALPointer [idx=0, fileOffset=2504766, len=76, forceFlush=false], 
> type=DATA_PAGE_INSERT_RECORD]]]
> [W] PagesListAddPageRecord [dataPageId=0001000c002f, 
> super=PageDeltaRecord [grpId=-1368047377, pageId=0001000c000b, 
> super=WALRecord [size=37, chainSize=0, pos=FileWALPointer [idx=0, 
> fileOffset=2504842, len=37, forceFlush=false], type=PAGES_LIST_ADD_PAGE]]]
> [W] DataPageSetFreeListPageRecord [freeListPage=281526516318219, 
> super=PageDeltaRecord [grpId=-1368047377, pageId=0001000c002f, 
> super=WALRecord [size=37, chainSize=0, pos=FileWALPointer [idx=0, 
> fileOffset=2504879, len=37, forceFlush=false], 
> type=DATA_PAGE_SET_FREE_LIST_PAGE]]]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (IGNITE-6382) .NET: Set up NDepend analysis on TeamCity

[Pavel Tupitsyn (JIRA)]

 [ 
https://issues.apache.org/jira/browse/IGNITE-6382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pavel Tupitsyn updated IGNITE-6382:
---
Description: 
NDepend provided 6 build machine licenses to Apache Ignite: 
https://svn.apache.org/repos/private/pmc/ignite/licenses/NDepend.txt

1) Install NDepend on Windows agents
2) Set up NDepend project, adjust rules
3) Add NDepend analysis to {{Platform .NET Inspections}}: 
https://ci.ignite.apache.org/viewType.html?buildTypeId=Ignite20Tests_IgnitePlatformNetInspections
4) Update wiki with instructions: 
https://cwiki.apache.org/confluence/display/IGNITE/Ignite.NET+Development

  was:
NDepend provided 6 build machine licenses to Apache Ignite: 
https://svn.apache.org/repos/private/pmc/ignite/licenses/NDepend.txt

1) Install NDepend on Windows agents
2) Set up NDepend project, adjust rules
3) Add NDepend analysis to {{Platform .NET Inspections}}: 
https://ci.ignite.apache.org/viewType.html?buildTypeId=Ignite20Tests_IgnitePlatformNetInspections


> .NET: Set up NDepend analysis on TeamCity
> -
>
> Key: IGNITE-6382
> URL: https://issues.apache.org/jira/browse/IGNITE-6382
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>  Labels: .NET
>
> NDepend provided 6 build machine licenses to Apache Ignite: 
> https://svn.apache.org/repos/private/pmc/ignite/licenses/NDepend.txt
> 1) Install NDepend on Windows agents
> 2) Set up NDepend project, adjust rules
> 3) Add NDepend analysis to {{Platform .NET Inspections}}: 
> https://ci.ignite.apache.org/viewType.html?buildTypeId=Ignite20Tests_IgnitePlatformNetInspections
> 4) Update wiki with instructions: 
> https://cwiki.apache.org/confluence/display/IGNITE/Ignite.NET+Development



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6330) Thin clients: close query cursors on disconnect

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166285#comment-16166285
 ] 

ASF GitHub Bot commented on IGNITE-6330:


Github user isapego closed the pull request at:

https://github.com/apache/ignite/pull/2646


> Thin clients: close query cursors on disconnect
> ---
>
> Key: IGNITE-6330
> URL: https://issues.apache.org/jira/browse/IGNITE-6330
> Project: Ignite
>  Issue Type: Bug
>  Components: jdbc, odbc
>Affects Versions: 2.1
>Reporter: Pavel Tupitsyn
>Assignee: Igor Sapego
> Fix For: 2.3
>
>
> {{JdbcRequestHandler}} and {{OdbcRequestHandler}} store active cursors in 
> {{qryCursors}} map. If client connection abruptly ends, these cursors are not 
> closed properly.
> {{SqlListenerNioListener.onDisconnected}} should call 
> {{SqlListenerConnectionContext.onDisconnected}}, and connection context 
> should clean up all resources there.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (IGNITE-6382) .NET: Set up NDepend analysis on TeamCity

[Pavel Tupitsyn (JIRA)]

Pavel Tupitsyn created IGNITE-6382:
--

 Summary: .NET: Set up NDepend analysis on TeamCity
 Key: IGNITE-6382
 URL: https://issues.apache.org/jira/browse/IGNITE-6382
 Project: Ignite
  Issue Type: Improvement
  Components: platforms
Reporter: Pavel Tupitsyn


NDepend provided 6 build machine licenses to Apache Ignite: 
https://svn.apache.org/repos/private/pmc/ignite/licenses/NDepend.txt

1) Install NDepend on Windows agents
2) Set up NDepend project, adjust rules
3) Add NDepend analysis to {{Platform .NET Inspections}}: 
https://ci.ignite.apache.org/viewType.html?buildTypeId=Ignite20Tests_IgnitePlatformNetInspections



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-4615) Ignite should be compilable under JDK 9

[Anton Vinogradov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-4615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166197#comment-16166197
 ] 

Anton Vinogradov commented on IGNITE-4615:
--

[~dmagda],
What do you think, can we change fix version to 3.0?

> Ignite should be compilable under JDK 9
> ---
>
> Key: IGNITE-4615
> URL: https://issues.apache.org/jira/browse/IGNITE-4615
> Project: Ignite
>  Issue Type: Task
>Reporter: Anton Vinogradov
> Fix For: 2.3
>
> Attachments: ignite.jar.dot
>
>
> The original discussion on the dev list:
> http://apache-ignite-developers.2346864.n4.nabble.com/Should-we-take-care-of-Java-9-in-Ignite-2-0-scope-td14018.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (IGNITE-6209) .NET: Build NuGet packages for Apache-Ignite release on CI

[Pavel Tupitsyn (JIRA)]

 [ 
https://issues.apache.org/jira/browse/IGNITE-6209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pavel Tupitsyn updated IGNITE-6209:
---
Labels: .NET  (was: )

> .NET: Build NuGet packages for Apache-Ignite release on CI
> --
>
> Key: IGNITE-6209
> URL: https://issues.apache.org/jira/browse/IGNITE-6209
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Oleg Ostanin
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.3
>
>
> Create a suite to build Ignite.NET NuGet packages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (IGNITE-6209) .NET: Build NuGet packages for Apache-Ignite release on CI

[Pavel Tupitsyn (JIRA)]

 [ 
https://issues.apache.org/jira/browse/IGNITE-6209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pavel Tupitsyn updated IGNITE-6209:
---
Summary: .NET: Build NuGet packages for Apache-Ignite release on CI  (was: 
Build Ignite.NET NuGet packages for Apache-Ignite release on CI)

> .NET: Build NuGet packages for Apache-Ignite release on CI
> --
>
> Key: IGNITE-6209
> URL: https://issues.apache.org/jira/browse/IGNITE-6209
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Oleg Ostanin
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.3
>
>
> Create a suite to build Ignite.NET NuGet packages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (IGNITE-6209) .NET: Build NuGet packages for Apache-Ignite release on CI

[Pavel Tupitsyn (JIRA)]

 [ 
https://issues.apache.org/jira/browse/IGNITE-6209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pavel Tupitsyn updated IGNITE-6209:
---
Component/s: platforms

> .NET: Build NuGet packages for Apache-Ignite release on CI
> --
>
> Key: IGNITE-6209
> URL: https://issues.apache.org/jira/browse/IGNITE-6209
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Oleg Ostanin
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.3
>
>
> Create a suite to build Ignite.NET NuGet packages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (IGNITE-6209) Build Ignite.NET NuGet packages for Apache-Ignite release on CI

[Pavel Tupitsyn (JIRA)]

 [ 
https://issues.apache.org/jira/browse/IGNITE-6209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pavel Tupitsyn reassigned IGNITE-6209:
--

Assignee: Pavel Tupitsyn

> Build Ignite.NET NuGet packages for Apache-Ignite release on CI
> ---
>
> Key: IGNITE-6209
> URL: https://issues.apache.org/jira/browse/IGNITE-6209
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Oleg Ostanin
>Assignee: Pavel Tupitsyn
> Fix For: 2.3
>
>
> Create a suite to build Ignite.NET NuGet packages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5097) BinaryMarshaller should write ints in "varint" encoding where it makes sense

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166170#comment-16166170
 ] 

Pavel Tupitsyn commented on IGNITE-5097:


[~daradurvs]:
1) Make sure code lines fit within 120 chars (BinaryConfiguration, 
BinaryObjectBuilder, etc)
2) Method comments should be in "///" format, not "/**" (BinaryUtils). I know 
there is some old code with wrong format, but all new/updated methods should 
have proper format.
3) Unused import in BinaryEqualityComparerTest
4) Could not compile Java (mvn clean package):
{code}
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile 
(default-testCompile) on project ignite-indexing: Compilation failure: Compilat
ion failure:
[ERROR] 
/C:/w/incubator-ignite/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/H2DynamicColumnsAbstractBasicSelfTest.java:[272,13]
 reference
 to assertEquals is ambiguous
[ERROR] both method assertEquals(java.lang.Object,java.lang.Object) in 
junit.framework.TestCase and method assertEquals(int,int) in 
junit.framework.TestCase match
[ERROR] 
/C:/w/incubator-ignite/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/H2DynamicColumnsAbstractBasicSelfTest.java:[275,13]
 reference
 to assertEquals is ambiguous
[ERROR] both method assertEquals(java.lang.Object,java.lang.Object) in 
junit.framework.TestCase and method assertEquals(int,int) in 
junit.framework.TestCase match
{code}

Other than that - good job!

> BinaryMarshaller should write ints in "varint" encoding where it makes sense
> 
>
> Key: IGNITE-5097
> URL: https://issues.apache.org/jira/browse/IGNITE-5097
> Project: Ignite
>  Issue Type: Task
>  Components: general
>Affects Versions: 2.0
>Reporter: Vladimir Ozerov
>Assignee: Vyacheslav Daradur
>  Labels: important, performance
> Fix For: 2.3
>
>
> There are a lot of places in the code where we write integers for some 
> special purposes. Quite often their value will be vary small, so that 
> applying "varint" format could save a lot of space at the cost of very low 
> additional CPU overhead. 
> Specifically:
> 1) Array/collection/map lengths
> 2) BigDecimal's (usually will save ~6 bytes)
> 3) Strings
> 4) Enum ordinals



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-4615) Ignite should be compilable under JDK 9

[Andrew Mashenkov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-4615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166146#comment-16166146
 ] 

Andrew Mashenkov commented on IGNITE-4615:
--

Let's move this to 3.0 version as Fix Version have nothing with reality for now 
as Java 9 is not even released yet.

> Ignite should be compilable under JDK 9
> ---
>
> Key: IGNITE-4615
> URL: https://issues.apache.org/jira/browse/IGNITE-4615
> Project: Ignite
>  Issue Type: Task
>Reporter: Anton Vinogradov
> Fix For: 2.3
>
> Attachments: ignite.jar.dot
>
>
> The original discussion on the dev list:
> http://apache-ignite-developers.2346864.n4.nabble.com/Should-we-take-care-of-Java-9-in-Ignite-2-0-scope-td14018.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (IGNITE-6381) add support Scala 2.12 in libs org.apache.ignite.scalar

[AlexZyryanov (JIRA)]

AlexZyryanov created IGNITE-6381:


 Summary: add support Scala 2.12 in libs org.apache.ignite.scalar
 Key: IGNITE-6381
 URL: https://issues.apache.org/jira/browse/IGNITE-6381
 Project: Ignite
  Issue Type: Task
Reporter: AlexZyryanov
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6258) .NET: Thin client: Define metadata exchange protocol

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166108#comment-16166108
 ] 

Pavel Tupitsyn commented on IGNITE-6258:


[~vozerov] makes sense, let's keep it simple for now.

Please review, diff with {{ignite-5896}}.

> .NET: Thin client: Define metadata exchange protocol
> 
>
> Key: IGNITE-6258
> URL: https://issues.apache.org/jira/browse/IGNITE-6258
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.3
>
>
> IGNITE-6236 introduced some metadata operations in client protocol.
> Let's formalize these operations:
> * Which operations should be present? PutMeta, PutMetas, GetMeta, GetSchema, 
> etc.
> * Do we need to retrieve schemas separately from entire metadata?
> * Dynamic type registration



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6258) .NET: Thin client: Define metadata exchange protocol

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166107#comment-16166107
 ] 

ASF GitHub Bot commented on IGNITE-6258:


GitHub user ptupitsyn opened a pull request:

https://github.com/apache/ignite/pull/2662

IGNITE-6258 .NET: Thin client: Define metadata exchange protocol



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-6258

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/2662.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2662


commit 53da5c892a7310ed57ea7c43d78b074f90eed03a
Author: Pavel Tupitsyn 
Date:   2017-09-14T11:29:44Z

IGNITE-6258 .NET: Thin client: Define metadata exchange protocol




> .NET: Thin client: Define metadata exchange protocol
> 
>
> Key: IGNITE-6258
> URL: https://issues.apache.org/jira/browse/IGNITE-6258
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.3
>
>
> IGNITE-6236 introduced some metadata operations in client protocol.
> Let's formalize these operations:
> * Which operations should be present? PutMeta, PutMetas, GetMeta, GetSchema, 
> etc.
> * Do we need to retrieve schemas separately from entire metadata?
> * Dynamic type registration



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (IGNITE-6307) If getAll() fails with NPE, onHeap entry is not removed, for local cache

[Nikolay Izhikov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166001#comment-16166001
 ] 

Nikolay Izhikov edited comment on IGNITE-6307 at 9/14/17 11:27 AM:
---

Dmitriy, thank you.

New test case added.
I run benchmarks and will return with the numbers.


was (Author: nizhikov):
New test case added.

> If getAll() fails with NPE, onHeap entry is not removed, for local cache
> 
>
> Key: IGNITE-6307
> URL: https://issues.apache.org/jira/browse/IGNITE-6307
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.0
>Reporter: Dmitriy Govorukhin
>Assignee: Nikolay Izhikov
>  Labels: MakeTeamcityGreenAgain
> Fix For: 2.3
>
>
> GridCacheLocalFullApiSelfTest.testGetAllWithNulls
> {code}
> final Set c = new HashSet<>();
> c.add("key1");
> c.add(null);
> GridTestUtils.assertThrows(log, new Callable() {
> @Override public Void call() throws Exception {
> cache.getAll(c);
> return null;
> }
> }, NullPointerException.class, null);
> {code}
> After getAll, entry with "key1" will be in heap map, it is dependent of order 
> in collection for getAll();



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6307) If getAll() fails with NPE, onHeap entry is not removed, for local cache

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166075#comment-16166075
 ] 

ASF GitHub Bot commented on IGNITE-6307:


GitHub user nizhikov opened a pull request:

https://github.com/apache/ignite/pull/2661

IGNITE-6307: Bug fix and new tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nizhikov/ignite IGNITE-6307-ignite-2.1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/2661.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2661






> If getAll() fails with NPE, onHeap entry is not removed, for local cache
> 
>
> Key: IGNITE-6307
> URL: https://issues.apache.org/jira/browse/IGNITE-6307
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.0
>Reporter: Dmitriy Govorukhin
>Assignee: Nikolay Izhikov
>  Labels: MakeTeamcityGreenAgain
> Fix For: 2.3
>
>
> GridCacheLocalFullApiSelfTest.testGetAllWithNulls
> {code}
> final Set c = new HashSet<>();
> c.add("key1");
> c.add(null);
> GridTestUtils.assertThrows(log, new Callable() {
> @Override public Void call() throws Exception {
> cache.getAll(c);
> return null;
> }
> }, NullPointerException.class, null);
> {code}
> After getAll, entry with "key1" will be in heap map, it is dependent of order 
> in collection for getAll();



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (IGNITE-4931) Safe way for deactivate cluster

[Alexey Kuznetsov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-4931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164701#comment-16164701
 ] 

Alexey Kuznetsov edited comment on IGNITE-4931 at 9/14/17 10:27 AM:


[~DmitriyGovorukhin] I have reworked tests and now you can review the ticket


was (Author: alexey kuznetsov):
[~DmitriyGovorukhin] I have reworked tests and now you can review them

> Safe way for deactivate cluster
> ---
>
> Key: IGNITE-4931
> URL: https://issues.apache.org/jira/browse/IGNITE-4931
> Project: Ignite
>  Issue Type: Task
>  Components: general
>Affects Versions: 2.0
>Reporter: Dmitriy Govorukhin
>Assignee: Alexey Kuznetsov
>  Labels: MakeTeamcityGreenAgain, Muted_test
> Fix For: 2.3
>
>
> Currently deactivation process, started after transaction start or cache lock 
> on key hangs waiting transaction end\ cache unlock. Closing 
> transaction\unlocking the lock leads to excpetion when deactivation is in 
> progress. It looks like 'deadlock'. 
> So, expected behaviour: starting deactivation should lead to excpetion if 
> transaction is in progress or cache key is locked.
> Exception should be thrown like in case when we start cache and transaction 
> is in progress (see checkEmptyTransactions method). In new tests we should 
> run transactions\lock in the same thread as deactivation started  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (IGNITE-4931) Safe way for deactivate cluster

[Alexey Kuznetsov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-4931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164701#comment-16164701
 ] 

Alexey Kuznetsov edited comment on IGNITE-4931 at 9/14/17 10:26 AM:


[~DmitriyGovorukhin] I have reworked tests and now you can review them


was (Author: alexey kuznetsov):
tests passed : 
https://ci.ignite.apache.org/viewLog.html?buildId=826377=buildResultsDiv=Ignite20Tests_IgniteCache5

PR: https://github.com/apache/ignite/pull/2648/commits

> Safe way for deactivate cluster
> ---
>
> Key: IGNITE-4931
> URL: https://issues.apache.org/jira/browse/IGNITE-4931
> Project: Ignite
>  Issue Type: Task
>  Components: general
>Affects Versions: 2.0
>Reporter: Dmitriy Govorukhin
>Assignee: Alexey Kuznetsov
>  Labels: MakeTeamcityGreenAgain, Muted_test
> Fix For: 2.3
>
>
> Currently deactivation process, started after transaction start or cache lock 
> on key hangs waiting transaction end\ cache unlock. Closing 
> transaction\unlocking the lock leads to excpetion when deactivation is in 
> progress. It looks like 'deadlock'. 
> So, expected behaviour: starting deactivation should lead to excpetion if 
> transaction is in progress or cache key is locked.
> Exception should be thrown like in case when we start cache and transaction 
> is in progress (see checkEmptyTransactions method). In new tests we should 
> run transactions\lock in the same thread as deactivation started  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5097) BinaryMarshaller should write ints in "varint" encoding where it makes sense

[Vyacheslav Daradur (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166042#comment-16166042
 ] 

Vyacheslav Daradur commented on IGNITE-5097:


[~ptupitsyn], could you please review the new changes in .NET part?

> BinaryMarshaller should write ints in "varint" encoding where it makes sense
> 
>
> Key: IGNITE-5097
> URL: https://issues.apache.org/jira/browse/IGNITE-5097
> Project: Ignite
>  Issue Type: Task
>  Components: general
>Affects Versions: 2.0
>Reporter: Vladimir Ozerov
>Assignee: Vyacheslav Daradur
>  Labels: important, performance
> Fix For: 2.3
>
>
> There are a lot of places in the code where we write integers for some 
> special purposes. Quite often their value will be vary small, so that 
> applying "varint" format could save a lot of space at the cost of very low 
> additional CPU overhead. 
> Specifically:
> 1) Array/collection/map lengths
> 2) BigDecimal's (usually will save ~6 bytes)
> 3) Strings
> 4) Enum ordinals



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6116) Easy way to enable metrics for default memory region

[Aleksei Zaitsev (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166022#comment-16166022
 ] 

Aleksei Zaitsev commented on IGNITE-6116:
-

[~dmagda] is this solution actual? Because in discussion [~sergey-chugunov] was 
concerned about the way this issue is going to be solved.

> Easy way to enable metrics for default memory region
> 
>
> Key: IGNITE-6116
> URL: https://issues.apache.org/jira/browse/IGNITE-6116
> Project: Ignite
>  Issue Type: Improvement
>Affects Versions: 2.1
>Reporter: Denis Magda
>Assignee: Aleksei Zaitsev
>  Labels: usability
> Fix For: 2.3
>
>
> Presently it's a bit challenging to enable memory metrics for the default 
> memory region unless you define a new one. Add the following two methods to 
> {{MemoryConfiguration}} to address the issue.
> {code}
> MemoryConfiguration.setDefaultMemoryPolicyMetricsEnabled(boolean)
> boolean MemoryConfiguration.isDefaultMemoryPolicyMetricsEnabled()
> {code}
> Discussion on @dev list: 
> http://apache-ignite-developers.2346864.n4.nabble.com/Enabling-memory-and-persistence-metrics-td19582.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6314) Fix ALTER TABLE tests failures

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166009#comment-16166009
 ] 

ASF GitHub Bot commented on IGNITE-6314:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/2639


> Fix ALTER TABLE tests failures
> --
>
> Key: IGNITE-6314
> URL: https://issues.apache.org/jira/browse/IGNITE-6314
> Project: Ignite
>  Issue Type: Bug
>  Components: sql
>Reporter: Sergey Kalashnikov
>Assignee: Alexander Paschenko
>  Labels: MakeTeamcityGreenAgain, sql
> Fix For: 2.3
>
>
> The following tests need to be fixed as they are failed when run on TeamCity.
> The tests pass when run locally.
> H2DynamicColumnsClientBasicSelfTest.testAddColumnToNonDynamicCacheWithRealValueType
>
> H2DynamicColumnsClientBasicSelfTest.testComplexOperations 
> H2DynamicColumnsServerBasicSelfTest.testAddColumnToNonDynamicCacheWithRealValueType
>
> H2DynamicColumnsServerBasicSelfTest.testComplexOperations 
> H2DynamicColumnsServerCoordinatorBasicSelfTest.testAddColumnToNonDynamicCacheWithRealValueType
> 
> H2DynamicColumnsServerCoordinatorBasicSelfTest.testComplexOperations  
> DynamicColumnsConcurrentAtomicReplicatedSelfTest.testConcurrentRebalance  
> DynamicColumnsConcurrentTransactionalReplicatedSelfTest.testConcurrentOperationsAndNodeStartStopMultithreaded
>  
> DynamicColumnsConcurrentTransactionalReplicatedSelfTest.testCoordinatorChange 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6307) If getAll() fails with NPE, onHeap entry is not removed, for local cache

[Nikolay Izhikov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166001#comment-16166001
 ] 

Nikolay Izhikov commented on IGNITE-6307:
-

New test case added.

> If getAll() fails with NPE, onHeap entry is not removed, for local cache
> 
>
> Key: IGNITE-6307
> URL: https://issues.apache.org/jira/browse/IGNITE-6307
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.0
>Reporter: Dmitriy Govorukhin
>Assignee: Nikolay Izhikov
>  Labels: MakeTeamcityGreenAgain
> Fix For: 2.3
>
>
> GridCacheLocalFullApiSelfTest.testGetAllWithNulls
> {code}
> final Set c = new HashSet<>();
> c.add("key1");
> c.add(null);
> GridTestUtils.assertThrows(log, new Callable() {
> @Override public Void call() throws Exception {
> cache.getAll(c);
> return null;
> }
> }, NullPointerException.class, null);
> {code}
> After getAll, entry with "key1" will be in heap map, it is dependent of order 
> in collection for getAll();



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (IGNITE-6307) If getAll() fails with NPE, onHeap entry is not removed, for local cache

[Dmitriy Govorukhin (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164411#comment-16164411
 ] 

Dmitriy Govorukhin edited comment on IGNITE-6307 at 9/14/17 9:26 AM:
-

One more thing, could you please add new cases in test, with 'null' in first 
element collection, middle and last.


was (Author: dmitriygovorukhin):
One more think, could you please add new cases in test, with 'null' in first 
element collection, middle and last.

> If getAll() fails with NPE, onHeap entry is not removed, for local cache
> 
>
> Key: IGNITE-6307
> URL: https://issues.apache.org/jira/browse/IGNITE-6307
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.0
>Reporter: Dmitriy Govorukhin
>Assignee: Nikolay Izhikov
>  Labels: MakeTeamcityGreenAgain
> Fix For: 2.3
>
>
> GridCacheLocalFullApiSelfTest.testGetAllWithNulls
> {code}
> final Set c = new HashSet<>();
> c.add("key1");
> c.add(null);
> GridTestUtils.assertThrows(log, new Callable() {
> @Override public Void call() throws Exception {
> cache.getAll(c);
> return null;
> }
> }, NullPointerException.class, null);
> {code}
> After getAll, entry with "key1" will be in heap map, it is dependent of order 
> in collection for getAll();



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (IGNITE-6380) Exception should be thrown on cache creation attempt inside transaction

[Yakov Zhdanov (JIRA)]

Yakov Zhdanov created IGNITE-6380:
-

 Summary: Exception should be thrown on cache creation attempt 
inside transaction
 Key: IGNITE-6380
 URL: https://issues.apache.org/jira/browse/IGNITE-6380
 Project: Ignite
  Issue Type: Improvement
Reporter: Yakov Zhdanov


Exception should be thrown on cache creation attempt inside transaction to 
prevent deadlocks since cache start triggers exchange and exchange cannot 
finish until all txs are finished.

We need to check if thread owns a tx before starting cache and if it does then 
IllegalStateException should be thrown.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6350) SQL: Forbid NOT NULL constraints usage for a cache with configured read-through cache store

[Sergey Kalashnikov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165949#comment-16165949
 ] 

Sergey Kalashnikov commented on IGNITE-6350:


[~vozerov], please take a look at the changes.

> SQL: Forbid NOT NULL constraints usage for a cache with configured 
> read-through cache store
> ---
>
> Key: IGNITE-6350
> URL: https://issues.apache.org/jira/browse/IGNITE-6350
> Project: Ignite
>  Issue Type: Bug
>  Components: sql
>Reporter: Sergey Kalashnikov
>Assignee: Sergey Kalashnikov
> Fix For: 2.3
>
>
> We need to throw an exception when user attempts to create or alter a table 
> with a field declared as NOT NULL in a case the corresponding cache 
> configuration employs read-through cache store 
> {{CacheConfiguration.setReadThrough()}}.
> These features seem to not fit together quite well, so we skip the support at 
> the moment and the check will keep things consistent.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6375) CREATE TABLE affinityKey parameter doesn't work as expected

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165945#comment-16165945
 ] 

ASF GitHub Bot commented on IGNITE-6375:


GitHub user devozerov opened a pull request:

https://github.com/apache/ignite/pull/2660

IGNITE-6375



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-6375

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/2660.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2660


commit 77b7c98202c1ab9e476610b262b2bd999a2186b5
Author: devozerov 
Date:   2017-09-14T08:32:02Z

Better affinity collocation for CREATE TABLE.




> CREATE TABLE affinityKey parameter doesn't work as expected
> ---
>
> Key: IGNITE-6375
> URL: https://issues.apache.org/jira/browse/IGNITE-6375
> Project: Ignite
>  Issue Type: Bug
>  Components: sql
>Affects Versions: 2.1
>Reporter: Denis Magda
>Assignee: Vladimir Ozerov
> Fix For: 2.3
>
>
> Start a couple of cluster nodes and preload the data using SQLLine tool and 
> an SQL script as described here:
> https://github.com/dmagda/ignite_world_demo
> The SQL tables are couple by affinity principle, check the script. However, 
> when I try to execute this query with a JOIN
> {code}
> SELECT country.name, city.name, MAX(city.population) as max_pop FROM country
> JOIN city ON city.countrycode = country.code
> WHERE country.code IN ('USA','RUS','CHN')
> GROUP BY country.name, city.name ORDER BY max_pop DESC LIMIT 3
> {code}
> then get a wrong result
> {noformat}
> United States New York 8008278
> United States Los Angeles 3694820
> United States Chicago 2896016
> {noformat}
> The correct result is the following:
> {noformat}
> China Shanghai 9696300
> Russian Federation Moscow 8389200
> United States New York 8008278
> {noformat}
> But you have to force {{non-collocated}} joins to get it. 
> All this means that {{affinityKey}} parameter of CREATE TABLE doesn't work 
> properly or there is an issue with DML.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (IGNITE-6379) CacheExchangeMessageDuplicatedStateTest fails in master

[Alexey Goncharuk (JIRA)]

 [ 
https://issues.apache.org/jira/browse/IGNITE-6379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexey Goncharuk resolved IGNITE-6379.
--
Resolution: Fixed

> CacheExchangeMessageDuplicatedStateTest fails in master
> ---
>
> Key: IGNITE-6379
> URL: https://issues.apache.org/jira/browse/IGNITE-6379
> Project: Ignite
>  Issue Type: Test
>Affects Versions: 2.1
>Reporter: Alexey Goncharuk
>Assignee: Alexey Goncharuk
>  Labels: MakeTeamcityGreenAgain
> Fix For: 2.3
>
>
> The test was broken by the change in partition exchange message



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (IGNITE-6379) CacheExchangeMessageDuplicatedStateTest fails in master

[Alexey Goncharuk (JIRA)]

 [ 
https://issues.apache.org/jira/browse/IGNITE-6379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexey Goncharuk updated IGNITE-6379:
-
Labels: MakeTeamcityGreenAgain  (was: )

> CacheExchangeMessageDuplicatedStateTest fails in master
> ---
>
> Key: IGNITE-6379
> URL: https://issues.apache.org/jira/browse/IGNITE-6379
> Project: Ignite
>  Issue Type: Test
>Affects Versions: 2.1
>Reporter: Alexey Goncharuk
>Assignee: Alexey Goncharuk
>  Labels: MakeTeamcityGreenAgain
> Fix For: 2.3
>
>
> The test was broken by the change in partition exchange message



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (IGNITE-6379) CacheExchangeMessageDuplicatedStateTest fails in master

[Alexey Goncharuk (JIRA)]

Alexey Goncharuk created IGNITE-6379:


 Summary: CacheExchangeMessageDuplicatedStateTest fails in master
 Key: IGNITE-6379
 URL: https://issues.apache.org/jira/browse/IGNITE-6379
 Project: Ignite
  Issue Type: Test
Affects Versions: 2.1
Reporter: Alexey Goncharuk
Assignee: Alexey Goncharuk
 Fix For: 2.3


The test was broken by the change in partition exchange message



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (IGNITE-6378) Web console: Demo mode panel hide part of affix panel.

[Vasiliy Sisko (JIRA)]

Vasiliy Sisko created IGNITE-6378:
-

 Summary: Web console: Demo mode panel hide part of affix panel.
 Key: IGNITE-6378
 URL: https://issues.apache.org/jira/browse/IGNITE-6378
 Project: Ignite
  Issue Type: Bug
Affects Versions: 2.1
Reporter: Vasiliy Sisko
Assignee: Dmitriy Shabalin






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (IGNITE-6377) MemoryPolicyInitializationTest fails with OOME

[Alexey Goncharuk (JIRA)]

 [ 
https://issues.apache.org/jira/browse/IGNITE-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexey Goncharuk resolved IGNITE-6377.
--
Resolution: Fixed

Merged to master

> MemoryPolicyInitializationTest fails with OOME
> --
>
> Key: IGNITE-6377
> URL: https://issues.apache.org/jira/browse/IGNITE-6377
> Project: Ignite
>  Issue Type: Test
>Affects Versions: 2.1
>Reporter: Alexey Goncharuk
>Assignee: Alexey Goncharuk
>  Labels: MakeTeamcityGreenAgain
> Fix For: 2.3
>
>
> Need to increase custom policy memory size



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (IGNITE-6377) MemoryPolicyInitializationTest fails with OOME

[Alexey Goncharuk (JIRA)]

Alexey Goncharuk created IGNITE-6377:


 Summary: MemoryPolicyInitializationTest fails with OOME
 Key: IGNITE-6377
 URL: https://issues.apache.org/jira/browse/IGNITE-6377
 Project: Ignite
  Issue Type: Test
Affects Versions: 2.1
Reporter: Alexey Goncharuk
Assignee: Alexey Goncharuk
 Fix For: 2.3


Need to increase custom policy memory size



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (IGNITE-6375) CREATE TABLE affinityKey parameter doesn't work as expected

[Vladimir Ozerov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/IGNITE-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Ozerov updated IGNITE-6375:

Fix Version/s: (was: 2.2)
   2.3

> CREATE TABLE affinityKey parameter doesn't work as expected
> ---
>
> Key: IGNITE-6375
> URL: https://issues.apache.org/jira/browse/IGNITE-6375
> Project: Ignite
>  Issue Type: Bug
>  Components: sql
>Affects Versions: 2.1
>Reporter: Denis Magda
>Assignee: Vladimir Ozerov
>Priority: Blocker
> Fix For: 2.3
>
>
> Start a couple of cluster nodes and preload the data using SQLLine tool and 
> an SQL script as described here:
> https://github.com/dmagda/ignite_world_demo
> The SQL tables are couple by affinity principle, check the script. However, 
> when I try to execute this query with a JOIN
> {code}
> SELECT country.name, city.name, MAX(city.population) as max_pop FROM country
> JOIN city ON city.countrycode = country.code
> WHERE country.code IN ('USA','RUS','CHN')
> GROUP BY country.name, city.name ORDER BY max_pop DESC LIMIT 3
> {code}
> then get a wrong result
> {noformat}
> United States New York 8008278
> United States Los Angeles 3694820
> United States Chicago 2896016
> {noformat}
> The correct result is the following:
> {noformat}
> China Shanghai 9696300
> Russian Federation Moscow 8389200
> United States New York 8008278
> {noformat}
> But you have to force {{non-collocated}} joins to get it. 
> All this means that {{affinityKey}} parameter of CREATE TABLE doesn't work 
> properly or there is an issue with DML.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (IGNITE-6375) CREATE TABLE affinityKey parameter doesn't work as expected

[Vladimir Ozerov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/IGNITE-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Ozerov updated IGNITE-6375:

Priority: Major  (was: Blocker)

> CREATE TABLE affinityKey parameter doesn't work as expected
> ---
>
> Key: IGNITE-6375
> URL: https://issues.apache.org/jira/browse/IGNITE-6375
> Project: Ignite
>  Issue Type: Bug
>  Components: sql
>Affects Versions: 2.1
>Reporter: Denis Magda
>Assignee: Vladimir Ozerov
> Fix For: 2.3
>
>
> Start a couple of cluster nodes and preload the data using SQLLine tool and 
> an SQL script as described here:
> https://github.com/dmagda/ignite_world_demo
> The SQL tables are couple by affinity principle, check the script. However, 
> when I try to execute this query with a JOIN
> {code}
> SELECT country.name, city.name, MAX(city.population) as max_pop FROM country
> JOIN city ON city.countrycode = country.code
> WHERE country.code IN ('USA','RUS','CHN')
> GROUP BY country.name, city.name ORDER BY max_pop DESC LIMIT 3
> {code}
> then get a wrong result
> {noformat}
> United States New York 8008278
> United States Los Angeles 3694820
> United States Chicago 2896016
> {noformat}
> The correct result is the following:
> {noformat}
> China Shanghai 9696300
> Russian Federation Moscow 8389200
> United States New York 8008278
> {noformat}
> But you have to force {{non-collocated}} joins to get it. 
> All this means that {{affinityKey}} parameter of CREATE TABLE doesn't work 
> properly or there is an issue with DML.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6340) Attempt to create the same cache from multiple threads leads to creation of client cache on server node

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165927#comment-16165927
 ] 

ASF GitHub Bot commented on IGNITE-6340:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/2635


> Attempt to create the same cache from multiple threads leads to creation of 
> client cache on server node
> ---
>
> Key: IGNITE-6340
> URL: https://issues.apache.org/jira/browse/IGNITE-6340
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 2.1
>Reporter: Ilya Lantukh
>Assignee: Alexey Goncharuk
> Fix For: 2.3
>
>
> Implementation of GridCacheProcessor.prepareCacheChangeRequest(...) is based 
> on assumption that if CacheDescriptor exists on affinity node, than server 
> cache also exists. However, this invariant is invalid in general case. For 
> example, request to create cache for given descriptor might be already in 
> queue but still unprocessed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6250) .NET: Thin client: Exception handling

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165926#comment-16165926
 ] 

Pavel Tupitsyn commented on IGNITE-6250:


We need a way to include maximum amount of details in exceptions.
For example, exception can happen in .NET ScanQuery filter, then be rethrown in 
Java. We have {{PlatformNativeException}} which contains serialized platform 
exception.
So the format can be defined like this:
* {{string exceptionClass}}
* {{string exceptionMessage}}
* {{string stackTrace}}
* {{object data}}
* {{bool hasCause}} - if yes, start reading again

> .NET: Thin client: Exception handling
> -
>
> Key: IGNITE-6250
> URL: https://issues.apache.org/jira/browse/IGNITE-6250
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .NET
> Fix For: 2.3
>
>
> Exception handling in thin client: response includes a success flag. Define 
> exception format protocol in case of failure.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6340) Attempt to create the same cache from multiple threads leads to creation of client cache on server node

[Alexey Goncharuk (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165924#comment-16165924
 ] 

Alexey Goncharuk commented on IGNITE-6340:
--

Merged to master.

> Attempt to create the same cache from multiple threads leads to creation of 
> client cache on server node
> ---
>
> Key: IGNITE-6340
> URL: https://issues.apache.org/jira/browse/IGNITE-6340
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 2.1
>Reporter: Ilya Lantukh
>Assignee: Alexey Goncharuk
> Fix For: 2.3
>
>
> Implementation of GridCacheProcessor.prepareCacheChangeRequest(...) is based 
> on assumption that if CacheDescriptor exists on affinity node, than server 
> cache also exists. However, this invariant is invalid in general case. For 
> example, request to create cache for given descriptor might be already in 
> queue but still unprocessed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (IGNITE-6120) Web Console: Propagate "lazy" flag on Query screen

[Pavel Konstantinov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165655#comment-16165655
 ] 

Pavel Konstantinov edited comment on IGNITE-6120 at 9/14/17 7:59 AM:
-

Re-tested 


was (Author: pkonstantinov):
Re-tested in 2.1.5

> Web Console: Propagate "lazy" flag on Query screen
> --
>
> Key: IGNITE-6120
> URL: https://issues.apache.org/jira/browse/IGNITE-6120
> Project: Ignite
>  Issue Type: Task
>  Components: sql, wizards
>Affects Versions: 2.1
>Reporter: Alexey Kuznetsov
>Assignee: Alexey Kuznetsov
> Fix For: 2.3
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6376) Web console: Enable task and job events in demo mode by default.

[Vasiliy Sisko (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165921#comment-16165921
 ] 

Vasiliy Sisko commented on IGNITE-6376:
---

Incremented collecting of task events in demo mode.

> Web console: Enable task and job events in demo mode by default.
> 
>
> Key: IGNITE-6376
> URL: https://issues.apache.org/jira/browse/IGNITE-6376
> Project: Ignite
>  Issue Type: Task
>  Components: wizards
>Affects Versions: 2.1
>Reporter: Vasiliy Sisko
>Assignee: Vasiliy Sisko
> Fix For: 2.3
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5097) BinaryMarshaller should write ints in "varint" encoding where it makes sense

[Vyacheslav Daradur (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165876#comment-16165876
 ] 

Vyacheslav Daradur commented on IGNITE-5097:


[~isapego], could you please port the new changes to the CPP platform?

> BinaryMarshaller should write ints in "varint" encoding where it makes sense
> 
>
> Key: IGNITE-5097
> URL: https://issues.apache.org/jira/browse/IGNITE-5097
> Project: Ignite
>  Issue Type: Task
>  Components: general
>Affects Versions: 2.0
>Reporter: Vladimir Ozerov
>Assignee: Vyacheslav Daradur
>  Labels: important, performance
> Fix For: 2.3
>
>
> There are a lot of places in the code where we write integers for some 
> special purposes. Quite often their value will be vary small, so that 
> applying "varint" format could save a lot of space at the cost of very low 
> additional CPU overhead. 
> Specifically:
> 1) Array/collection/map lengths
> 2) BigDecimal's (usually will save ~6 bytes)
> 3) Strings
> 4) Enum ordinals



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6137) Inaccurate CAS handling in GridNearTxLocal async commit

[Andrey Kuznetsov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165865#comment-16165865
 ] 

Andrey Kuznetsov commented on IGNITE-6137:
--

[~DmitriyGovorukhin], TC link has been added.

> Inaccurate CAS handling in GridNearTxLocal async commit
> ---
>
> Key: IGNITE-6137
> URL: https://issues.apache.org/jira/browse/IGNITE-6137
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.1
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
> Fix For: 2.3
>
>
> CAS for commitFuture is handled inaccurate in commitNearTxLocalAsync method. 
> Can fail on muliple calls, either concurrent or sequential.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5097) BinaryMarshaller should write ints in "varint" encoding where it makes sense

[Vyacheslav Daradur (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165858#comment-16165858
 ] 

Vyacheslav Daradur commented on IGNITE-5097:


[~vozerov],
bq. It should be set to false by default, so that data saved on previous 
version of Ignite can be read without problems.
I agree it makes sense in such case.

I've implemented configuration parameter on {{BinaryConfiguration}}, in Java 
and .NET parts.

Sent to [ci.tests|https://ci.ignite.apache.org/viewQueued.html?itemId=828125] 
once again, after code cleanup.

Could, you please review it?

> BinaryMarshaller should write ints in "varint" encoding where it makes sense
> 
>
> Key: IGNITE-5097
> URL: https://issues.apache.org/jira/browse/IGNITE-5097
> Project: Ignite
>  Issue Type: Task
>  Components: general
>Affects Versions: 2.0
>Reporter: Vladimir Ozerov
>Assignee: Vyacheslav Daradur
>  Labels: important, performance
> Fix For: 2.3
>
>
> There are a lot of places in the code where we write integers for some 
> special purposes. Quite often their value will be vary small, so that 
> applying "varint" format could save a lot of space at the cost of very low 
> additional CPU overhead. 
> Specifically:
> 1) Array/collection/map lengths
> 2) BigDecimal's (usually will save ~6 bytes)
> 3) Strings
> 4) Enum ordinals



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6375) CREATE TABLE affinityKey parameter doesn't work as expected

[Vladimir Ozerov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165844#comment-16165844
 ] 

Vladimir Ozerov commented on IGNITE-6375:
-

[~dmagda], confirming. DDL part is fine - affinity key field name is passed to 
cache configuration. However, for some reason it is not interpreted by cache 
correctly. 

> CREATE TABLE affinityKey parameter doesn't work as expected
> ---
>
> Key: IGNITE-6375
> URL: https://issues.apache.org/jira/browse/IGNITE-6375
> Project: Ignite
>  Issue Type: Bug
>  Components: sql
>Affects Versions: 2.1
>Reporter: Denis Magda
>Assignee: Vladimir Ozerov
>Priority: Blocker
> Fix For: 2.2
>
>
> Start a couple of cluster nodes and preload the data using SQLLine tool and 
> an SQL script as described here:
> https://github.com/dmagda/ignite_world_demo
> The SQL tables are couple by affinity principle, check the script. However, 
> when I try to execute this query with a JOIN
> {code}
> SELECT country.name, city.name, MAX(city.population) as max_pop FROM country
> JOIN city ON city.countrycode = country.code
> WHERE country.code IN ('USA','RUS','CHN')
> GROUP BY country.name, city.name ORDER BY max_pop DESC LIMIT 3
> {code}
> then get a wrong result
> {noformat}
> United States New York 8008278
> United States Los Angeles 3694820
> United States Chicago 2896016
> {noformat}
> The correct result is the following:
> {noformat}
> China Shanghai 9696300
> Russian Federation Moscow 8389200
> United States New York 8008278
> {noformat}
> But you have to force {{non-collocated}} joins to get it. 
> All this means that {{affinityKey}} parameter of CREATE TABLE doesn't work 
> properly or there is an issue with DML.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)