[jira] [Commented] (IGNITE-7405) Distributed MLP cleanup/refactoring phase 2
[ https://issues.apache.org/jira/browse/IGNITE-7405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324795#comment-16324795 ] Oleg Ignatenko commented on IGNITE-7405: Suggest to give yet another try on managing type parameters in {{ParameterUpdateCalculator}} and its implementations. Unchecked cast warnings in implementations of {{update}} method indicate that there is a room for improvement there. This seems to be tricky though: I tried to figure how to improve it when reviewing changes done per IGNITE-7350 and couldn't make it. Maybe we need more time to try harder or maybe there is simply no way out there. Anyway it looks desirable to either figure a fully type-safe design or a compelling explanation (possibly to be added to javadocs) why it can't be done. > Distributed MLP cleanup/refactoring phase 2 > --- > > Key: IGNITE-7405 > URL: https://issues.apache.org/jira/browse/IGNITE-7405 > Project: Ignite > Issue Type: Bug > Components: ml >Affects Versions: 2.4 >Reporter: Artem Malykh >Assignee: Artem Malykh > Fix For: 2.4 > > > All refactoring which is not done in IGNITE-7350. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-7284) Introduce DEV_ONLY marker to IgniteLogger
[ https://issues.apache.org/jira/browse/IGNITE-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324753#comment-16324753 ] Valentin Kulichenko commented on IGNITE-7284: - [~slukyanov], I tried to merge pull request to master, but there are conflicts. Can you please fix them? > Introduce DEV_ONLY marker to IgniteLogger > - > > Key: IGNITE-7284 > URL: https://issues.apache.org/jira/browse/IGNITE-7284 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 2.3 >Reporter: Valentin Kulichenko >Assignee: Stanislav Lukyanov > Fix For: 2.4 > > > Need to add markers support to {{IgniteLogger}} and then introduce > {{DEV_ONLY}} marker for warnings that can be suppressed in prod environments. > Problem and solution are discussed in more detail here: > http://apache-ignite-developers.2346864.n4.nabble.com/Suppressing-quot-development-quot-warning-td25195.html > Make sure to update Loggers documentation explaining how the parameter works > and what's it for: > https://apacheignite.readme.io/docs/logging -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (IGNITE-7405) Distributed MLP cleanup/refactoring phase 2
[ https://issues.apache.org/jira/browse/IGNITE-7405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Ignatenko updated IGNITE-7405: --- Description: All refactoring which is not done in IGNITE-7350. (was: All refactoring which is not done in https://issues.apache.org/jira/browse/IGNITE-7350.) > Distributed MLP cleanup/refactoring phase 2 > --- > > Key: IGNITE-7405 > URL: https://issues.apache.org/jira/browse/IGNITE-7405 > Project: Ignite > Issue Type: Bug > Components: ml >Affects Versions: 2.4 >Reporter: Artem Malykh >Assignee: Artem Malykh > Fix For: 2.4 > > > All refactoring which is not done in IGNITE-7350. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (IGNITE-7376) Document optional SQL on-heap row cache
[ https://issues.apache.org/jira/browse/IGNITE-7376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Denis Magda reassigned IGNITE-7376: --- Assignee: Denis Magda (was: Taras Ledkov) > Document optional SQL on-heap row cache > --- > > Key: IGNITE-7376 > URL: https://issues.apache.org/jira/browse/IGNITE-7376 > Project: Ignite > Issue Type: Task > Components: documentation >Reporter: Taras Ledkov >Assignee: Denis Magda > Fix For: 2.4 > > > Add documentation for on-heap row cache implemented at IGNITE-7173 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (IGNITE-7405) Distributed MLP cleanup/refactoring phase 2
Artem Malykh created IGNITE-7405: Summary: Distributed MLP cleanup/refactoring phase 2 Key: IGNITE-7405 URL: https://issues.apache.org/jira/browse/IGNITE-7405 Project: Ignite Issue Type: Bug Components: ml Affects Versions: 2.4 Reporter: Artem Malykh Assignee: Artem Malykh Fix For: 2.4 All refactoring which is not done in https://issues.apache.org/jira/browse/IGNITE-7350. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (IGNITE-7404) Use various backgrounds for Ignite main page's main blocks
Denis Magda created IGNITE-7404: --- Summary: Use various backgrounds for Ignite main page's main blocks Key: IGNITE-7404 URL: https://issues.apache.org/jira/browse/IGNITE-7404 Project: Ignite Issue Type: Task Components: site Reporter: Denis Magda Assignee: Vica Abramova Fix For: 2.4 This ticket is intended to improve the main page: https://ignite.apache.org All the content that goes below the banner is shown on a *white* background. As a result, it's difficult to separate main building blocks from each other *visually*. Suggest to come up with a second background and rotate it together with the white one among the building blocks. For instance: - Apache Ignite definition and use cases (white) - Features (new background - probably grey) - How Ignite compares (white) - Screencast (new background) - News (white) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (IGNITE-7403) Improve content on What's Ignite page
[ https://issues.apache.org/jira/browse/IGNITE-7403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Denis Magda updated IGNITE-7403: Fix Version/s: 2.4 > Improve content on What's Ignite page > - > > Key: IGNITE-7403 > URL: https://issues.apache.org/jira/browse/IGNITE-7403 > Project: Ignite > Issue Type: Task > Components: site >Affects Versions: 2.4 >Reporter: Denis Magda >Assignee: Vica Abramova > Fix For: 2.4 > > > A proposed of a new draft for the What's Ignite page: > https://ignite.apache.org/whatisignite-2.html > The goal is to make the page more informative and tell about the main things > of Ignite or provide references to them. Overall, the structure should be as > follows: > - Product name and definition. > - Diagram. > - Features and Benefits > - Ignite facts -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (IGNITE-7403) Improve content on What's Ignite page
Denis Magda created IGNITE-7403: --- Summary: Improve content on What's Ignite page Key: IGNITE-7403 URL: https://issues.apache.org/jira/browse/IGNITE-7403 Project: Ignite Issue Type: Task Components: site Affects Versions: 2.4 Reporter: Denis Magda Assignee: Vica Abramova A proposed of a new draft for the What's Ignite page: https://ignite.apache.org/whatisignite-2.html The goal is to make the page more informative and tell about the main things of Ignite or provide references to them. Overall, the structure should be as follows: - Product name and definition. - Diagram. - Features and Benefits - Ignite facts -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-6923) Cache metrics are updated in timeout-worker potentially delaying critical code execution due to current implementation issues.
[ https://issues.apache.org/jira/browse/IGNITE-6923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324440#comment-16324440 ] ASF GitHub Bot commented on IGNITE-6923: GitHub user alex-plekhanov opened a pull request: https://github.com/apache/ignite/pull/3369 IGNITE-6923 Cache metrics optimization You can merge this pull request into a Git repository by running: $ git pull https://github.com/alex-plekhanov/ignite IGNITE-6923 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3369.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3369 commit eef3fed408d7cfbeedcabcb354989c64be773724 Author: Aleksey Plekhanov Date: 2017-12-19T14:44:06Z IGNITE-6923 Optimized nonHeapMemoryUsed commit 122467d0ca4cfe859e2fc5af276b20c4f50dc89c Author: Aleksey Plekhanov Date: 2017-12-20T16:13:34Z IGNITE-6923 getTotalPartitionsCount, getRebalancingPartitionsCount optimization commit e20d842f9ccf9c4d1e4703a52cd723d8e37ddbea Author: Aleksey Plekhanov Date: 2017-12-22T08:56:36Z IGNITE-6923 Cluster metrics optimization (proxy class implemented) commit bff0a1845799ad90c6ecdd3812e84418ba45bd07 Author: Aleksey Plekhanov Date: 2017-12-25T08:40:24Z IGNITE-6923 Partitions metrics optimization commit 6dd59b9961f9fc073d4616367e36607430f113b8 Author: Aleksey Plekhanov Date: 2017-12-26T12:57:01Z IGNITE-6923 Cache metrics optimization commit 96b0396f05c7aacb24bd9ee88e2564d240fae0be Author: Aleksey Plekhanov Date: 2017-12-26T12:58:30Z IGNITE-6923 Cache metrics optimization commit 79067428f7252700bb23d29f3e3b4b7dfa5586bf Author: Aleksey Plekhanov Date: 2017-12-27T07:48:56Z IGNITE-6923 Disable cache metrics update flag commit 5e5d675f6fb6a25eda57fcbf53e49ec87fda3ba2 Author: Aleksey Plekhanov Date: 2017-12-27T08:07:57Z IGNITE-6923 License header commit e90d778d9fab0b1e467ef1314505060494fea1db Author: Aleksey Plekhanov Date: 2018-01-11T20:57:29Z IGNITE-6923 Bugfix commit 77e50a74dadc6ae40d301f63cd0e4b73b6203303 Author: Aleksey Plekhanov Date: 2018-01-12T14:43:29Z IGNITE-6923 Unit test commit 39f7c653e8b91ec7b02244e2633e27ea9103793d Author: Aleksey Plekhanov Date: 2018-01-12T14:47:35Z Revert "IGNITE-6923 Disable cache metrics update flag" This reverts commit 9bb904f commit 62ea9f5d6524eff6e9a69fbc8ca2ac0c95325796 Author: Aleksey Plekhanov Date: 2018-01-12T19:24:57Z IGNITE-6923 Test comment added > Cache metrics are updated in timeout-worker potentially delaying critical > code execution due to current implementation issues. > -- > > Key: IGNITE-6923 > URL: https://issues.apache.org/jira/browse/IGNITE-6923 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.3 >Reporter: Alexei Scherbakov >Assignee: Aleksey Plekhanov >Priority: Critical > Labels: iep-6 > Fix For: 2.4 > > > Some metrics are using cache iteration for calculation. If number of caches > rather large this can be slow. > Similar code is running in discovery thread. > See stack trace for example. > {noformat} > "grid-timeout-worker-#39%DPL_GRID%DplGridNodeName%" #152 prio=5 os_prio=0 > tid=0x7f1009a03000 nid=0x5caa runnable [0x7f0f059d9000] >java.lang.Thread.State: RUNNABLE > at java.util.HashMap.containsKey(HashMap.java:595) > at java.util.HashSet.contains(HashSet.java:203) > at > java.util.Collections$UnmodifiableCollection.contains(Collections.java:1032) > at > org.apache.ignite.internal.processors.cache.IgniteCacheOffheapManagerImpl$3.apply(IgniteCacheOffheapManagerImpl.java:339) > at > org.apache.ignite.internal.processors.cache.IgniteCacheOffheapManagerImpl$3.apply(IgniteCacheOffheapManagerImpl.java:337) > at > org.apache.ignite.internal.util.lang.gridfunc.TransformFilteringIterator.hasNext:@TransformFilteringIterator.java:90) > at > org.apache.ignite.internal.util.lang.GridIteratorAdapter.hasNext(GridIteratorAdapter.java:45) > > at > org.apache.ignite.internal.processors.cache.IgniteCacheOffheapManagerImpl.cacheEntriesCount(IgniteCacheOffheapManagerImpl.java:293) > at > org.apache.ignite.internal.processors.cache.CacheMetricsImpl.getOffHeapPrimaryEntriesCount(CacheMetricsImpl.java:240) > at > org.apache.ignite.internal.processors.cache.CacheMetricsSnapshot.(CacheMetricsSnapshot.java:271) > > at > org.apache.ignite.internal.processors.cache.GridCacheAdapter.localMetrics(GridCacheAdapter.java:3217) > > at > o
[jira] [Comment Edited] (IGNITE-6853) Cassandra cache store does not clean prepared statements cache when remove old cassandra session
[ https://issues.apache.org/jira/browse/IGNITE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324418#comment-16324418 ] Dmitriy Setrakyan edited comment on IGNITE-6853 at 1/12/18 7:17 PM: I agree with Igor. If we introduce a new mocking framework, it should be done at the project level and discussed with the community on the dev@ list. Is there any chance to create a patch without Mockito for now? was (Author: dsetrakyan): I agree with Igor. If we introduce a new mocking framework, it should be done at the project level and discussed with the community on the dev@ list. Is there any chance to create a patch without Mokito for now? > Cassandra cache store does not clean prepared statements cache when remove > old cassandra session > > > Key: IGNITE-6853 > URL: https://issues.apache.org/jira/browse/IGNITE-6853 > Project: Ignite > Issue Type: Bug > Components: cassandra >Affects Versions: 2.3 >Reporter: Mikhail Cherkasov >Assignee: Jason Man > Labels: important > Fix For: 2.4 > > > Cassandra cache store does not clean prepared statements cache when remove > old cassandra session which can lead to: > Prepared > statement cluster error detected, refreshing Cassandra session > com.datastax.driver.core.exceptions.InvalidQueryException: Tried to execute > unknown prepared query : 0xcad5832309a512feeb602eec67408130. You may have > used a PreparedStatement that was created with another Cluster instance. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-6853) Cassandra cache store does not clean prepared statements cache when remove old cassandra session
[ https://issues.apache.org/jira/browse/IGNITE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324418#comment-16324418 ] Dmitriy Setrakyan commented on IGNITE-6853: --- I agree with Igor. If we introduce a new mocking framework, it should be done at the project level and discussed with the community on the dev@ list. Is there any chance to create a patch without Mokito for now? > Cassandra cache store does not clean prepared statements cache when remove > old cassandra session > > > Key: IGNITE-6853 > URL: https://issues.apache.org/jira/browse/IGNITE-6853 > Project: Ignite > Issue Type: Bug > Components: cassandra >Affects Versions: 2.3 >Reporter: Mikhail Cherkasov >Assignee: Jason Man > Labels: important > Fix For: 2.4 > > > Cassandra cache store does not clean prepared statements cache when remove > old cassandra session which can lead to: > Prepared > statement cluster error detected, refreshing Cassandra session > com.datastax.driver.core.exceptions.InvalidQueryException: Tried to execute > unknown prepared query : 0xcad5832309a512feeb602eec67408130. You may have > used a PreparedStatement that was created with another Cluster instance. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (IGNITE-7402) Add ODBC security support
Blackfield created IGNITE-7402: -- Summary: Add ODBC security support Key: IGNITE-7402 URL: https://issues.apache.org/jira/browse/IGNITE-7402 Project: Ignite Issue Type: Improvement Components: odbc Affects Versions: 2.3 Reporter: Blackfield ODBC driver does not support username password to be passed to security plugin in. Please enable end user to provide user name and password. The DSN info on Windows is stored in registry as plain text. The password should NOT be stored as plain text (e.g. encrypted). See Ignite-6941 for the JDBC counter part. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-6923) Cache metrics are updated in timeout-worker potentially delaying critical code execution due to current implementation issues.
[ https://issues.apache.org/jira/browse/IGNITE-6923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324370#comment-16324370 ] ASF GitHub Bot commented on IGNITE-6923: Github user alex-plekhanov closed the pull request at: https://github.com/apache/ignite/pull/3292 > Cache metrics are updated in timeout-worker potentially delaying critical > code execution due to current implementation issues. > -- > > Key: IGNITE-6923 > URL: https://issues.apache.org/jira/browse/IGNITE-6923 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.3 >Reporter: Alexei Scherbakov >Assignee: Aleksey Plekhanov >Priority: Critical > Labels: iep-6 > Fix For: 2.4 > > > Some metrics are using cache iteration for calculation. If number of caches > rather large this can be slow. > Similar code is running in discovery thread. > See stack trace for example. > {noformat} > "grid-timeout-worker-#39%DPL_GRID%DplGridNodeName%" #152 prio=5 os_prio=0 > tid=0x7f1009a03000 nid=0x5caa runnable [0x7f0f059d9000] >java.lang.Thread.State: RUNNABLE > at java.util.HashMap.containsKey(HashMap.java:595) > at java.util.HashSet.contains(HashSet.java:203) > at > java.util.Collections$UnmodifiableCollection.contains(Collections.java:1032) > at > org.apache.ignite.internal.processors.cache.IgniteCacheOffheapManagerImpl$3.apply(IgniteCacheOffheapManagerImpl.java:339) > at > org.apache.ignite.internal.processors.cache.IgniteCacheOffheapManagerImpl$3.apply(IgniteCacheOffheapManagerImpl.java:337) > at > org.apache.ignite.internal.util.lang.gridfunc.TransformFilteringIterator.hasNext:@TransformFilteringIterator.java:90) > at > org.apache.ignite.internal.util.lang.GridIteratorAdapter.hasNext(GridIteratorAdapter.java:45) > > at > org.apache.ignite.internal.processors.cache.IgniteCacheOffheapManagerImpl.cacheEntriesCount(IgniteCacheOffheapManagerImpl.java:293) > at > org.apache.ignite.internal.processors.cache.CacheMetricsImpl.getOffHeapPrimaryEntriesCount(CacheMetricsImpl.java:240) > at > org.apache.ignite.internal.processors.cache.CacheMetricsSnapshot.(CacheMetricsSnapshot.java:271) > > at > org.apache.ignite.internal.processors.cache.GridCacheAdapter.localMetrics(GridCacheAdapter.java:3217) > > at > org.apache.ignite.internal.managers.discovery.GridDiscoveryManager$7.cacheMetrics(GridDiscoveryManager.java:1151) > at > org.apache.ignite.internal.managers.discovery.GridDiscoveryManager$7.nonHeapMemoryUsed(GridDiscoveryManager.java:1121) > at > org.apache.ignite.internal.managers.discovery.GridDiscoveryManager$7.metrics(GridDiscoveryManager.java:1087) > > at > org.apache.ignite.spi.discovery.tcp.internal.TcpDiscoveryNode.metrics(TcpDiscoveryNode.java:269) > > at > org.apache.ignite.internal.IgniteKernal$3.run(IgniteKernal.java:1175) > at > org.apache.ignite.internal.processors.timeout.GridTimeoutProcessor$CancelableTask.onTimeout(GridTimeoutProcessor.java:256) > - locked <0x7f115f5bf890> (a > org.apache.ignite.internal.processors.timeout.GridTimeoutProcessor$CancelableTask) > at > org.apache.ignite.internal.processors.timeout.GridTimeoutProcessor$TimeoutWorker.body(GridTimeoutProcessor.java:158) > at > org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:110) > at java.lang.Thread.run(Thread.java:748) > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (IGNITE-7235) Add warning with with a list of restrictions when Ignite native persistence is used with write-though cache store
[ https://issues.apache.org/jira/browse/IGNITE-7235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Denis Magda updated IGNITE-7235: Component/s: documentation > Add warning with with a list of restrictions when Ignite native persistence > is used with write-though cache store > - > > Key: IGNITE-7235 > URL: https://issues.apache.org/jira/browse/IGNITE-7235 > Project: Ignite > Issue Type: Improvement > Components: documentation >Reporter: Alexey Goncharuk >Assignee: Alexey Goncharuk > Fix For: 2.4 > > > We should remove any validations (if any) for native persistence and > CacheStore. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-7380) Avoid updating PagePartitionCounters in case all counters were not modified
[ https://issues.apache.org/jira/browse/IGNITE-7380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324223#comment-16324223 ] Dmitriy Pavlov commented on IGNITE-7380: Change as one commit: https://github.com/gridgain/apache-ignite/commit/a09f3ad2bc8ca089f154047ab11a19271b37e86f > Avoid updating PagePartitionCounters in case all counters were not modified > --- > > Key: IGNITE-7380 > URL: https://issues.apache.org/jira/browse/IGNITE-7380 > Project: Ignite > Issue Type: Improvement > Components: persistence >Reporter: Dmitriy Pavlov >Assignee: Dmitriy Pavlov >Priority: Critical > Fix For: 2.4 > > > PagePartitionCountersIO ignores actual values of counters and marks pages > dirty even if partition has no counters update. > This leads to PAGE_RECORD creation for pages from PagePartitionCountersIO > and as result with pages from TrackingPageIO. > These modificaiton may be skipped if counters are checked for equality before > storing data. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (IGNITE-7401) Entry can be expired even if it doesn't define expiry policy in "putWithPolicy-then-put" scenario
[ https://issues.apache.org/jira/browse/IGNITE-7401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Gura updated IGNITE-7401: Description: Entry can be expired even if it doesn't define expiry policy in "putWithPolicy-then-put" scenario. The following test case demonstrate the problem. {code:java} public void testPutWithTtlThenPut() throws Exception { Ignite ignite = startGrid(); try { IgniteCache cache = ignite.cache("cache"); CreatedExpiryPolicy expiryPlc = new CreatedExpiryPolicy(new Duration(TimeUnit.MILLISECONDS, 10)); IgniteCache cacheTtl = cache.withExpiryPolicy(expiryPlc); cacheTtl.put("key", "v1"); cache.put("key", "v2"); U.sleep(10); assertEquals("v2", cache.get("key")); // Will fail (flaky) } finally { stopAllGrids(); } } {code} The issue also affects Ignite based cluster manager for Vert.x: https://github.com/vert-x3/vertx-ignite/issues/63 was: Entry can be expired even if it doesn't define expiry policy in "putWithPolicy-then-put" scenario. The following test case demonstrate the problem. {code:java} public void testPutWithTtlThenPut() throws Exception { Ignite ignite = startGrid(); try { IgniteCache cache = ignite.cache("cache"); CreatedExpiryPolicy expiryPlc = new CreatedExpiryPolicy(new Duration(TimeUnit.MILLISECONDS, 10)); IgniteCache cacheTtl = cache.withExpiryPolicy(expiryPlc); cacheTtl.put("key", "v1"); cache.put("key", "v2"); U.sleep(10); assertEquals("v2", cache.get("key")); // Fill fail (flaky) } finally { stopAllGrids(); } } {code} The issue also affects Ignite based cluster manager for Vert.x: https://github.com/vert-x3/vertx-ignite/issues/63 > Entry can be expired even if it doesn't define expiry policy in > "putWithPolicy-then-put" scenario > - > > Key: IGNITE-7401 > URL: https://issues.apache.org/jira/browse/IGNITE-7401 > Project: Ignite > Issue Type: Bug >Reporter: Andrey Gura > > Entry can be expired even if it doesn't define expiry policy in > "putWithPolicy-then-put" scenario. The following test case demonstrate the > problem. > {code:java} > public void testPutWithTtlThenPut() throws Exception { > Ignite ignite = startGrid(); > try { > IgniteCache cache = ignite.cache("cache"); > CreatedExpiryPolicy expiryPlc = new CreatedExpiryPolicy(new > Duration(TimeUnit.MILLISECONDS, 10)); > IgniteCache cacheTtl = > cache.withExpiryPolicy(expiryPlc); > cacheTtl.put("key", "v1"); > cache.put("key", "v2"); > U.sleep(10); > assertEquals("v2", cache.get("key")); // Will fail (flaky) > } > finally { > stopAllGrids(); > } > } > {code} > The issue also affects Ignite based cluster manager for Vert.x: > https://github.com/vert-x3/vertx-ignite/issues/63 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (IGNITE-7401) Entry can be expired even if it doesn't define expiry policy in "putWithPolicy-then-put" scenario
[ https://issues.apache.org/jira/browse/IGNITE-7401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Gura updated IGNITE-7401: Description: Entry can be expired even if it doesn't define expiry policy in "putWithPolicy-then-put" scenario. The following test case demonstrate the problem. {code:java} public void testPutWithTtlThenPut() throws Exception { Ignite ignite = startGrid(); try { IgniteCache cache = ignite.cache("cache"); CreatedExpiryPolicy expiryPlc = new CreatedExpiryPolicy(new Duration(TimeUnit.MILLISECONDS, 10)); IgniteCache cacheTtl = cache.withExpiryPolicy(expiryPlc); cacheTtl.put("key", "v1"); cache.put("key", "v2"); U.sleep(10); assertEquals("v2", cache.get("key")); // Fill fail (flaky) } finally { stopAllGrids(); } } {code} The issue also affects Ignite based cluster manager for Vert.x: https://github.com/vert-x3/vertx-ignite/issues/63 was: Entry can be expired even if it doesn't define expiry policy in "putWithPolicy-then-put" scenario. The following test case demonstrate the problem. {code:java} public void testPutWithTtlThenPut() throws Exception { Ignite ignite = startGrid(); try { IgniteCache cache = ignite.cache("cache"); CreatedExpiryPolicy expiryPlc = new CreatedExpiryPolicy(new Duration(TimeUnit.MILLISECONDS, 10)); IgniteCache cacheTtl = cache.withExpiryPolicy(expiryPlc); cacheTtl.put("key", "v1"); cache.put("key", "v2"); U.sleep(10); assertEquals("v2", cache.get("key")); // Fill fail (flaky) } finally { stopAllGrids(); } } {code} > Entry can be expired even if it doesn't define expiry policy in > "putWithPolicy-then-put" scenario > - > > Key: IGNITE-7401 > URL: https://issues.apache.org/jira/browse/IGNITE-7401 > Project: Ignite > Issue Type: Bug >Reporter: Andrey Gura > > Entry can be expired even if it doesn't define expiry policy in > "putWithPolicy-then-put" scenario. The following test case demonstrate the > problem. > {code:java} > public void testPutWithTtlThenPut() throws Exception { > Ignite ignite = startGrid(); > try { > IgniteCache cache = ignite.cache("cache"); > CreatedExpiryPolicy expiryPlc = new CreatedExpiryPolicy(new > Duration(TimeUnit.MILLISECONDS, 10)); > IgniteCache cacheTtl = > cache.withExpiryPolicy(expiryPlc); > cacheTtl.put("key", "v1"); > cache.put("key", "v2"); > U.sleep(10); > assertEquals("v2", cache.get("key")); // Fill fail (flaky) > } > finally { > stopAllGrids(); > } > } > {code} > The issue also affects Ignite based cluster manager for Vert.x: > https://github.com/vert-x3/vertx-ignite/issues/63 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (IGNITE-7401) Entry can be expired even if it doesn't define expiry policy in "putWithPolicy-then-put" scenario
Andrey Gura created IGNITE-7401: --- Summary: Entry can be expired even if it doesn't define expiry policy in "putWithPolicy-then-put" scenario Key: IGNITE-7401 URL: https://issues.apache.org/jira/browse/IGNITE-7401 Project: Ignite Issue Type: Bug Reporter: Andrey Gura Entry can be expired even if it doesn't define expiry policy in "putWithPolicy-then-put" scenario. The following test case demonstrate the problem. {code:java} public void testPutWithTtlThenPut() throws Exception { Ignite ignite = startGrid(); try { IgniteCache cache = ignite.cache("cache"); CreatedExpiryPolicy expiryPlc = new CreatedExpiryPolicy(new Duration(TimeUnit.MILLISECONDS, 10)); IgniteCache cacheTtl = cache.withExpiryPolicy(expiryPlc); cacheTtl.put("key", "v1"); cache.put("key", "v2"); U.sleep(10); assertEquals("v2", cache.get("key")); // Fill fail (flaky) } finally { stopAllGrids(); } } {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-7350) Distributed MLP cleanup/refactoring
[ https://issues.apache.org/jira/browse/IGNITE-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324173#comment-16324173 ] ASF GitHub Bot commented on IGNITE-7350: GitHub user artemmalykh opened a pull request: https://github.com/apache/ignite/pull/3368 IGNITE-7350: Distributed MLP cleanup/refactoring. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-7350 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3368.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3368 commit 995d781b58b57c4721b3fd92d3867975d652272a Author: Artem Malykh Date: 2018-01-12T13:22:21Z IGNITE-7397: Fix cache configuration and reduced trainings count in MLP group training test. commit 123f14ccc8b8c0e27104061b4644876b45a8a123 Author: Artem Malykh Date: 2018-01-12T13:23:02Z Merge branch 'master-apache' into ignite-7397 commit b2cfa9017b69b8ebfd2bca4143c91315c1fd3a06 Author: Artem Malykh Date: 2018-01-12T15:15:01Z IGNITE-7350: Moved update calculators from nn package to optimization. commit 32de402cd6939aba24cec572e42ddc8d90dc3251 Author: Artem Malykh Date: 2018-01-12T15:24:33Z IGNITE-7350: Moved LossFunctions, fixed some comments. commit eb1ceb580c418ec91c3e5b42585132b15073aa97 Author: Artem Malykh Date: 2018-01-12T16:03:26Z IGNITE-7350: Removed in-place changing of update and model in Nesterov update calculator. commit e5d3299c6b344fb2b9c54b6f578cdda2739c7ffa Author: Artem Malykh Date: 2018-01-12T16:07:31Z IGNITE-7350: Default implementation for 'withParameters'. commit b0dc57dcf8e717def820806dab62d50715de02f6 Author: Artem Malykh Date: 2018-01-12T16:11:26Z IGNITE-7350: Moved some files to appropriate packages. > Distributed MLP cleanup/refactoring > --- > > Key: IGNITE-7350 > URL: https://issues.apache.org/jira/browse/IGNITE-7350 > Project: Ignite > Issue Type: Bug > Components: ml >Reporter: Yury Babak >Assignee: Artem Malykh > Labels: neural_network, refactoring > > Current state of MLP not so good, so we need improve it and may be rewrite > some parts of this NN. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-1628) .NET: Ensure that Ignite works on Mono platform
[ https://issues.apache.org/jira/browse/IGNITE-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324167#comment-16324167 ] Pavel Tupitsyn commented on IGNITE-1628: Found an issue: there is no {{mscoree.dll}} on Linux, so non-default AppDomains are not supported, and tests fail. Investigating. > .NET: Ensure that Ignite works on Mono platform > --- > > Key: IGNITE-1628 > URL: https://issues.apache.org/jira/browse/IGNITE-1628 > Project: Ignite > Issue Type: Task > Components: platforms >Affects Versions: ignite-1.4 >Reporter: Vladimir Ozerov >Assignee: Pavel Tupitsyn > Labels: .net > > *NOTE*: Targeted for 1.6, but could be moved even further in case of tight > release schedule. > *Goal* > As Microsoft is moving .Net towards open standards, Mono receives more an > more attention. > We need to ensure that our product works fine on this platform. This includes > both Windows, Linux and (possibly) Mac environments. > *Tasks* > - Ensure that Ignite works with Mono on Windows. This is the easiest task > because we only need to re-compile .Net part. > - Ensure that Ignite works with Mono on Linux. This will require alternate > build procedure because CPP recompilation will be required as well. > - Create relevant TC builds. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (IGNITE-6899) Adding GA Grid to Apache Ignite ML module.
[ https://issues.apache.org/jira/browse/IGNITE-6899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320924#comment-16320924 ] Oleg Ignatenko edited comment on IGNITE-6899 at 1/12/18 3:58 PM: - I copied [this branch|https://github.com/techbysample/ignite/tree/ignite-6899] to my machine and did a couple of brief checks. Overall, it looks good. Recommend to put an effort into integrating this functionality in Ignite, specifically adjust the code to closer match project coding guidelines and after it's done perform one more round of design review. I have a strong feeling that code and design are mostly good enough and won't need substantial changes in order to be integrated. If needed, refer notes below for more details. - Checked builds of ml module and examples from command line, these went smoothly (my builds were without tests and javadocs though). - Run examples (from IDEA), all executed smoothly: HelloWorld, Movie (with {{-DGENRES=Action,Comedy,Romance}}), OptimizeMakeChange (with {{-DAMOUNTCHANGE=75}}). - Briefly studied examples code. In examples pom, ignite-ml dependency outside of ml profile looks superfluous but that's minor. Wrt java code of examples, good news are that it loos clear and easy to understand, just the kind code I'd want to see when learning new API. Very well done. Bad news are, there are multiple deviations from [coding style guidelines of Ignite|https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines], I am not even sure if it can pass javadocs check at Teamcity. These issues look manageable though and given that examples code is so apparently useful I would strongly recommend to put an effort into onboarding it to the project. - Run unit tests (GAGridTestSuite, in IDEA) - all passed. - Run coverage analysis of unit tests (report attached: [^coverage.zip]). Per cursory glance, coverage looks reasonably okay - similar or better to that in most other ml packages. It's not as good as that of math package but as far as I know improving unit tests coverage in whole ml module is planned as dedicated effort anyway so it's probably good enough for now. - Gave a first read to code added to ml module (note I plan to re-read it later so may add more comments besides notes below): {panel}Generally I've got same impression as of examples: code mostly looks well designed and structured and easy to read but there are multiple deviations from Ignite coding guidelines. Another sad thing I noticed is repeated errors in javadocs of the kind when method parameter type is written instead of name (for example in javadoc for {{Chromosome#setFitnessScore}}). Yet another javadoc related concern (though one that is easy to fix) is {{package-info.java}} files are missing in sub-packages of genetic (sub-folders of src/main/java/org/apache/ignite/ml/genetic) - if not fixed this will break building javadocs of the project if I remember correctly. Another thing I'm not entirely comfortable with is usage of enums in GAGridConstants; it looks familiar and idiomatic for pre-Java 8 code but our experience in ml module so far suggests that using Java 8 functional way instead of enums often works better for stuff like that (for examples refer eg to {{org.apache.ignite.ml.math.functions.Functions}}). Possibly worth giving it a try. There is repeated typo "criteria" -> "critiera" in various places - and what is concerning is shows even in some names of public methods, eg {{GAConfiguration#getChromosomeCritiera}}. In GACongiguration, it would be nice to add a unit test or example with non-default value of {{elitismCount}} (myself I would prefer unit test but I don't insist on that). (maybe minor but still) In class ChromosomeCriteria field {{criteria}} is default visibility but presence of setter and getter suggests that it's supposed to be private.{panel} - Gave a second read to implementation code, this time more of a higher level view, trying to ignore minor formal issues. From this perspective design looks solid (except for that enums issue mentioned in previous comments; I drilled into their usage a little bit deeper and it really feels somehow suboptimal - eg {{FITNESS_EVALUATER_TYPE}} seems to have boolean semantics, not that of enum). That said, I would recommend yet another round design review after adjusting the code style to better fit project guidelines because currently style deviations tend to blur perception and make it harder to evaluate design. - Сhecked [documentation at readme.io|https://apacheignite.readme.io/v2.3/docs/genetic-algorithms] - it seems to be in a _very_ good shape. I only noticed two minor issues: 1) "Apache Ignite 2.x release has expanded..." reads confusing because this is not yet integrated. I'd rephrase to something like "Apache Ignite community is working on expanding..." (this wording o
[jira] [Comment Edited] (IGNITE-6899) Adding GA Grid to Apache Ignite ML module.
[ https://issues.apache.org/jira/browse/IGNITE-6899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320924#comment-16320924 ] Oleg Ignatenko edited comment on IGNITE-6899 at 1/12/18 3:57 PM: - I copied [this branch|https://github.com/techbysample/ignite/tree/ignite-6899] to my machine and did a couple of brief checks. Overall, it looks good. Recommend to put an effort into integrating this functionality in Ignite, specifically adjust the code to closer match project coding guidelines and after it's done perform one more round of design review. I have a strong feeling that code and design are mostly good enough and won't need substantial changes in order to be integrated. If needed, refer notes below for more details. - Checked builds of ml module and examples from command line, these went smoothly (my builds were without tests and javadocs though). - Run examples (from IDEA), all executed smoothly: HelloWorld, Movie (with {{-DGENRES=Action,Comedy,Romance}}), OptimizeMakeChange (with {{-DAMOUNTCHANGE=75}}). - Briefly studied examples code. In examples pom, ignite-ml dependency outside of ml profile looks superfluous but that's minor. Wrt java code of examples, good news are that it loos clear and easy to understand, just the kind code I'd want to see when learning new API. Very well done. Bad news are, there are multiple deviations from [coding style guidelines of Ignite|https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines], I am not even sure if it can pass javadocs check at Teamcity. These issues look manageable though and given that examples code is so apparently useful I would strongly recommend to put an effort into onboarding it to the project. - Run unit tests (GAGridTestSuite, in IDEA) - all passed. - Run coverage analysis of unit tests (report attached: [^coverage.zip]). Per cursory glance, coverage looks reasonably okay - similar or better to that in most other ml packages. It's not as good as that of math package but as far as I know improving unit tests coverage in whole ml module is planned as dedicated effort anyway so it's probably good enough for now. - Gave a first read to code added to ml module (note I plan to re-read it later so may add more comments besides notes below): {panel}Generally I've got same impression as of examples: code mostly looks well designed and structured and easy to read but there are multiple deviations from Ignite coding guidelines. Another sad thing I noticed is repeated errors in javadocs of the kind when method parameter type is written instead of name (for example in javadoc for {{Chromosome#setFitnessScore}}). Yet another javadoc related concern (though one that is easy to fix) is {{package-info.java}} files are missing in sub-packages of genetic (sub-folders of src/main/java/org/apache/ignite/ml/genetic) - if not fixed this will break building javadocs of the project if I remember correctly. Another thing I'm not entirely comfortable with is usage of enums in GAGridConstants; it looks familiar and idiomatic for pre-Java 8 code but our experience in ml module so far suggests that using Java 8 functional way instead of enums often works better for stuff like that (for examples refer eg to {{org.apache.ignite.ml.math.functions.Functions}}). Possibly worth giving it a try. There is repeated typo "criteria" -> "critiera" in various places - and what is concerning is shows even in some names of public methods, eg {{GAConfiguration#getChromosomeCritiera}}. In GACongiguration, it would be nice to add a unit test or example with non-default value of {{elitismCount}} (myself I would prefer unit test but I don't insist on that). (maybe minor but still) In class ChromosomeCriteria field {{criteria}} is default visibility but presence of setter and getter suggests that it's supposed to be private.{panel} - Gave a second read to implementation code, this time more of a higher level view, trying to ignore minor formal issues. From this perspective design looks solid (except for that enums issue mentioned in previous comments; I drilled into their usage a little bit deeper and it really feels somehow suboptimal - eg {{FITNESS_EVALUATER_TYPE}} seems to have boolean semantics, not that of enum). That said, I would recommend yet another round design review after adjusting the code style to better fit project guidelines because currently style deviations tend to blur perception and make it harder to evaluate design. - Сhecked [documentation at readme.io|https://apacheignite.readme.io/v2.3/docs/genetic-algorithms] - it seems to be in a _very_ good shape. I only noticed two minor issues: 1) "Apache Ignite 2.x release has expanded..." reads confusing because this is not yet integrated. I'd rephrase to something like "Apache Ignite community is working on expanding..." (this wording o
[jira] [Updated] (IGNITE-7394) .NET: Add F# tests
[ https://issues.apache.org/jira/browse/IGNITE-7394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pavel Tupitsyn updated IGNITE-7394: --- Description: Add tests to ensure that Ignite.NET can be used from F#. * Check that all F# data types can be used in cache without issues (records, tuples, collections, unions, etc). * Compute * LINQ These tests can be added to {{Apache.Ignite.DotNetCore.sln}}, in a new project {{Apache.Ignite.Tests.FSharp}}. was: Add tests to ensure that Ignite.NET can be used from F#. * Check that all F# data types can be used in cache without issues (records, tuples, collections, unions, etc). * Compute * LINQ These tests can be added to {{Apache.Ignite.DotNetCore.sln}}. > .NET: Add F# tests > -- > > Key: IGNITE-7394 > URL: https://issues.apache.org/jira/browse/IGNITE-7394 > Project: Ignite > Issue Type: Improvement > Components: platforms >Affects Versions: 2.4 >Reporter: Pavel Tupitsyn >Priority: Minor > Labels: .NET, F#, newbie > > Add tests to ensure that Ignite.NET can be used from F#. > * Check that all F# data types can be used in cache without issues (records, > tuples, collections, unions, etc). > * Compute > * LINQ > These tests can be added to {{Apache.Ignite.DotNetCore.sln}}, in a new > project {{Apache.Ignite.Tests.FSharp}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (IGNITE-7400) OptimizedMarshallerIndexNameTest doesn't kill the grid after the test
[ https://issues.apache.org/jira/browse/IGNITE-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirill Shirokov resolved IGNITE-7400. - Resolution: Fixed Fix Version/s: 2.4 Fixed by [~tledkov-gridgain] as a part of IGNITE-7173 fix. > OptimizedMarshallerIndexNameTest doesn't kill the grid after the test > - > > Key: IGNITE-7400 > URL: https://issues.apache.org/jira/browse/IGNITE-7400 > Project: Ignite > Issue Type: Bug > Components: sql >Affects Versions: 2.4 >Reporter: Kirill Shirokov >Assignee: Kirill Shirokov > Fix For: 2.4 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (IGNITE-7400) OptimizedMarshallerIndexNameTest doesn't kill the grid after the test
Kirill Shirokov created IGNITE-7400: --- Summary: OptimizedMarshallerIndexNameTest doesn't kill the grid after the test Key: IGNITE-7400 URL: https://issues.apache.org/jira/browse/IGNITE-7400 Project: Ignite Issue Type: Bug Components: sql Affects Versions: 2.4 Reporter: Kirill Shirokov Assignee: Kirill Shirokov -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (IGNITE-7019) Cluster can not survive after IgniteOOM
[ https://issues.apache.org/jira/browse/IGNITE-7019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitriy Sorokin reassigned IGNITE-7019: --- Assignee: Dmitriy Sorokin > Cluster can not survive after IgniteOOM > --- > > Key: IGNITE-7019 > URL: https://issues.apache.org/jira/browse/IGNITE-7019 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.3 >Reporter: Mikhail Cherkasov >Assignee: Dmitriy Sorokin >Priority: Critical > Labels: iep-7 > Fix For: 2.4 > > > even if we have full sync mode and transactional cache we can't add new nodes > if there was IgniteOOM, after adding new nodes and re-balancing, old nodes > can't evict partitions: > {code} > [2017-11-17 20:02:24,588][ERROR][sys-#65%DR1%][GridDhtPreloader] Partition > eviction failed, this can cause grid hang. > class org.apache.ignite.internal.mem.IgniteOutOfMemoryException: Not enough > memory allocated [policyName=100MB_Region_Eviction, size=104.9 MB] > Consider increasing memory policy size, enabling evictions, adding more nodes > to the cluster, reducing number of backups or reducing model size. > at > org.apache.ignite.internal.pagemem.impl.PageMemoryNoStoreImpl.allocatePage(PageMemoryNoStoreImpl.java:294) > at > org.apache.ignite.internal.processors.cache.persistence.DataStructure.allocatePageNoReuse(DataStructure.java:117) > at > org.apache.ignite.internal.processors.cache.persistence.DataStructure.allocatePage(DataStructure.java:105) > at > org.apache.ignite.internal.processors.cache.persistence.freelist.PagesList.addStripe(PagesList.java:413) > at > org.apache.ignite.internal.processors.cache.persistence.freelist.PagesList.getPageForPut(PagesList.java:528) > at > org.apache.ignite.internal.processors.cache.persistence.freelist.PagesList.put(PagesList.java:617) > at > org.apache.ignite.internal.processors.cache.persistence.freelist.FreeListImpl.addForRecycle(FreeListImpl.java:582) > at > org.apache.ignite.internal.processors.cache.persistence.tree.BPlusTree$Remove.reuseFreePages(BPlusTree.java:3847) > at > org.apache.ignite.internal.processors.cache.persistence.tree.BPlusTree$Remove.releaseAll(BPlusTree.java:4106) > at > org.apache.ignite.internal.processors.cache.persistence.tree.BPlusTree$Remove.access$6900(BPlusTree.java:3166) > at > org.apache.ignite.internal.processors.cache.persistence.tree.BPlusTree.doRemove(BPlusTree.java:1782) > at > org.apache.ignite.internal.processors.cache.persistence.tree.BPlusTree.remove(BPlusTree.java:1567) > at > org.apache.ignite.internal.processors.cache.IgniteCacheOffheapManagerImpl$CacheDataStoreImpl.remove(IgniteCacheOffheapManagerImpl.java:1387) > at > org.apache.ignite.internal.processors.cache.IgniteCacheOffheapManagerImpl.remove(IgniteCacheOffheapManagerImpl.java:374) > at > org.apache.ignite.internal.processors.cache.GridCacheMapEntry.removeValue(GridCacheMapEntry.java:3233) > at > org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtCacheEntry.clearInternal(GridDhtCacheEntry.java:588) > at > org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtLocalPartition.clearAll(GridDhtLocalPartition.java:892) > at > org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtLocalPartition.tryEvict(GridDhtLocalPartition.java:750) > at > org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPreloader$3.call(GridDhtPreloader.java:593) > at > org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPreloader$3.call(GridDhtPreloader.java:580) > at > org.apache.ignite.internal.util.IgniteUtils.wrapThreadLoader(IgniteUtils.java:6639) > at > org.apache.ignite.internal.processors.closure.GridClosureProcessor$2.body(GridClosureProcessor.java:967) > at > org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:110) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:748) > {code} > Discussion on the dev list: > http://apache-ignite-developers.2346864.n4.nabble.com/How-properly-handle-IgniteOOM-td25288.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (IGNITE-7350) Distributed MLP cleanup/refactoring
[ https://issues.apache.org/jira/browse/IGNITE-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Malykh reassigned IGNITE-7350: Assignee: Artem Malykh (was: Yury Babak) > Distributed MLP cleanup/refactoring > --- > > Key: IGNITE-7350 > URL: https://issues.apache.org/jira/browse/IGNITE-7350 > Project: Ignite > Issue Type: Bug > Components: ml >Reporter: Yury Babak >Assignee: Artem Malykh > Labels: neural_network, refactoring > > Current state of MLP not so good, so we need improve it and may be rewrite > some parts of this NN. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (IGNITE-7283) .NET: Include all tests in DotNetCore test project
[ https://issues.apache.org/jira/browse/IGNITE-7283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pavel Tupitsyn reassigned IGNITE-7283: -- Assignee: Pavel Tupitsyn > .NET: Include all tests in DotNetCore test project > -- > > Key: IGNITE-7283 > URL: https://issues.apache.org/jira/browse/IGNITE-7283 > Project: Ignite > Issue Type: Improvement > Components: platforms >Affects Versions: 2.4 >Reporter: Pavel Tupitsyn >Assignee: Pavel Tupitsyn > Labels: .NET, xplat > > Currently we have a separate folder for .NET Core tests > {{Apache.Ignite.Core.Tests.DotNetCore}}. > Ideally we should get rid of it and place > {{Apache.Ignite.Core.Tests.DotNetCore.csproj}} in the > {{Apache.Ignite.Core.Tests}} folder so that all tests are included. > This will require a lot of {{#if !NETCOREAPP2_0}}, but we'll explicitly see > which tests are cross-platform. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (IGNITE-7278) Node failed to recover partition from WAL on unstable topology.
[ https://issues.apache.org/jira/browse/IGNITE-7278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitriy Govorukhin reassigned IGNITE-7278: -- Assignee: Dmitriy Govorukhin (was: Alexey Goncharuk) > Node failed to recover partition from WAL on unstable topology. > --- > > Key: IGNITE-7278 > URL: https://issues.apache.org/jira/browse/IGNITE-7278 > Project: Ignite > Issue Type: Bug > Components: persistence >Reporter: Andrew Mashenkov >Assignee: Dmitriy Govorukhin > Fix For: 2.4 > > Attachments: page_corrupted2.tar.gz > > > The use case is: > -Grid with partitioned cache with 2 backups (or replicated) > -Node-1 is killed in the middle of checkpoint and started again. > -Node-1 detects unfinished checkpoint and tries to recover it. > -At this point Node-2 is killed while node-1 recovering is in progress. > -Node-1 fails with AssertionError. > PFA logs, parsed WAL, reproducer. > Can be reproduced with IgnitePdsContinuousRestartTest with minor changes, > we have to have 2 nodes flapping and kill nodes ungracefully. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (IGNITE-7399) .NET: Thin client: NullRefException when connection to arbitrary server
[ https://issues.apache.org/jira/browse/IGNITE-7399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pavel Tupitsyn updated IGNITE-7399: --- Labels: .NET (was: ) > .NET: Thin client: NullRefException when connection to arbitrary server > --- > > Key: IGNITE-7399 > URL: https://issues.apache.org/jira/browse/IGNITE-7399 > Project: Ignite > Issue Type: Bug > Components: platforms, thin client >Affects Versions: 2.4 >Reporter: Pavel Tupitsyn >Assignee: Pavel Tupitsyn > Labels: .NET > Fix For: 2.4 > > > Reproducer: > {code} > var cfg = new IgniteClientConfiguration { Host = "ya.ru", Port=80 }; > var client = Ignition.StartClient(cfg); > {code} > Result: > {code} > Object reference not set to an instance of an object. > at Apache.Ignite.Core.Impl.Client.ClientSocket.Dispose() >at Apache.Ignite.Core.Impl.Client.ClientSocket.ReceiveBytes(Int32 size) >at > Apache.Ignite.Core.Impl.Client.ClientSocket.Handshake(ClientProtocolVersion > version) >at > Apache.Ignite.Core.Impl.Client.ClientSocket..ctor(IgniteClientConfiguration > clientConfiguration, Nullable`1 version) >at > Apache.Ignite.Core.Impl.Client.IgniteClient..ctor(IgniteClientConfiguration > clientConfiguration) >at Apache.Ignite.Core.Ignition.StartClient(IgniteClientConfiguration > clientConfiguration) > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (IGNITE-7399) .NET: Thin client: NullRefException when connection to arbitrary server
Pavel Tupitsyn created IGNITE-7399: -- Summary: .NET: Thin client: NullRefException when connection to arbitrary server Key: IGNITE-7399 URL: https://issues.apache.org/jira/browse/IGNITE-7399 Project: Ignite Issue Type: Bug Components: platforms, thin client Affects Versions: 2.4 Reporter: Pavel Tupitsyn Assignee: Pavel Tupitsyn Fix For: 2.4 Reproducer: {code} var cfg = new IgniteClientConfiguration { Host = "ya.ru", Port=80 }; var client = Ignition.StartClient(cfg); {code} Result: {code} Object reference not set to an instance of an object. at Apache.Ignite.Core.Impl.Client.ClientSocket.Dispose() at Apache.Ignite.Core.Impl.Client.ClientSocket.ReceiveBytes(Int32 size) at Apache.Ignite.Core.Impl.Client.ClientSocket.Handshake(ClientProtocolVersion version) at Apache.Ignite.Core.Impl.Client.ClientSocket..ctor(IgniteClientConfiguration clientConfiguration, Nullable`1 version) at Apache.Ignite.Core.Impl.Client.IgniteClient..ctor(IgniteClientConfiguration clientConfiguration) at Apache.Ignite.Core.Ignition.StartClient(IgniteClientConfiguration clientConfiguration) {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-6861) SQL parser: support CREATE TABLE and DROP TABLE commands
[ https://issues.apache.org/jira/browse/IGNITE-6861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323997#comment-16323997 ] Kirill Shirokov commented on IGNITE-6861: - Differences in SQL type handling in column definition clauses in Ignite CREATE TABLE vs. SQL-99 standard: h3. String types: * Not supported: CHARACTER SET in character type definition * Not supported: CLOB, NCLOB, LARGE OBJECT * Not supported: NATIONAL * We don't make any difference between national and plain character types * In VARYING types (varchar etc.) length argument is optional h3. Bit string types: * BIT == BOOLEAN in our implementation * Not supported: BIT VARYING * We don't support optional bit string length parameter h3. Approximate numeric types: * FLOAT: We don't support optional precision h3. Datetime types: * TIME, TIMESTAMP: precision is not supported * Not supported: WITH TIME ZONE / WITHOUT TIME ZONE h3. Other types: * Not supported: BINARY LARGE OBJECT, BLOB * Not supported: INTERVAL * Not supported: ROW * Not supported: arrays > SQL parser: support CREATE TABLE and DROP TABLE commands > > > Key: IGNITE-6861 > URL: https://issues.apache.org/jira/browse/IGNITE-6861 > Project: Ignite > Issue Type: Task > Components: sql >Reporter: Vladimir Ozerov >Assignee: Kirill Shirokov > Fix For: 2.5 > > > Partial implementation is ready (see PR). Need to make sure that the full > syntax is supported. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (IGNITE-7202) Include Ignite Direct IO plugin to binary distribution
[ https://issues.apache.org/jira/browse/IGNITE-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitriy Pavlov resolved IGNITE-7202. Resolution: Fixed Ignite Direct IO plugin will be added to optional lib automatically to Apache-ignite-fabric-2.x.x-bin\libs\optional\ignite-direct-io\direct-io-2.x.x.jar To enable Direct IO it is sufficient to place lib to ignite classpath on Linux system. When plugin is applied following messages will be produced {noformat} Configured plugins: ^-- Ignite Native I/O Plugin [Direct I/O] ^-- Copyright(C) Apache Software Foundation {noformat} Following message will be produced for successful setup: {noformat} Page size configuration for storage path [/data/teamcity/tmpfs/work/db/node00-3a1415b8-aa54-4a63-a40a-c75ad48dd6b8]: 4096; Linux memory page size: 4096; Selected FS block size : 4096. Selected FS block size : 4096 Direct IO is enabled for block IO operations on aligned memory structures. [block size = 4096, durable memory page size = 4096] {noformat} Following test suites were added for checking Direct IO functionality using existing PDS tests: https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests20_IgnitePds1DirectIo https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests20_IgnitePds2DirectIo Runs may be triggered by https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests20_RunAllPds [~vveider], FYI, these 2 configs would require migration to new 2.x tests suites > Include Ignite Direct IO plugin to binary distribution > -- > > Key: IGNITE-7202 > URL: https://issues.apache.org/jira/browse/IGNITE-7202 > Project: Ignite > Issue Type: Task >Reporter: Dmitriy Pavlov >Assignee: Dmitriy Pavlov > > Direct IO plugin was supported under > https://issues.apache.org/jira/browse/IGNITE-6341 > it is required to include this plugin into release distribution, -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (IGNITE-7334) MBeans fail to be created for caches with special symbols in names
[ https://issues.apache.org/jira/browse/IGNITE-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Gura updated IGNITE-7334: Fix Version/s: 2.4 > MBeans fail to be created for caches with special symbols in names > -- > > Key: IGNITE-7334 > URL: https://issues.apache.org/jira/browse/IGNITE-7334 > Project: Ignite > Issue Type: Bug > Components: cache >Affects Versions: 2.4 >Reporter: Stanislav Lukyanov >Assignee: Stanislav Lukyanov > Fix For: 2.4 > > > If a cache contains a certain symbols, e.g. an asterisk, its creation will > fail due to an exception during MBean creation. This is because of > insufficient escaping in the shared MBean registration code in IgniteUtils. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (IGNITE-7000) .NET: Document .NET Core support and running on Linux / macOs
[ https://issues.apache.org/jira/browse/IGNITE-7000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pavel Tupitsyn updated IGNITE-7000: --- Description: Create a documentation page about running Ignite.NET under .NET Core and/or Linux. Things to mention: * Exceptions and delegates can't be serialized under .NET Core: https://github.com/dotnet/corefx/issues/24424 * Build warning - suppress {{NU1701}} with {{NU1701}} * Java home, dll paths, etc * Publish and deploy (copy libs folder to {{dotnet publish}} dir) * macOs: document {{No Java runtime present, requesting install.}} issue https://bugs.openjdk.java.net/browse/JDK-7131356, https://github.com/s-u/rJava/issues/37 * Service proxies are not supported because {{Remoting}} is not available on .NET Core: IGNITE-7281 * VS Code and Rider * Mono is supported (useful for 32 bit and/or older distros): need to set {{IgniteHome}} * {{}} may be required was: Create a documentation page about running Ignite.NET under .NET Core and/or Linux. Things to mention: * Exceptions and delegates can't be serialized under .NET Core: https://github.com/dotnet/corefx/issues/24424 * Build warning - suppress {{NU1701}} with {{NU1701}} * Java home, dll paths, etc * Publish and deploy (copy libs folder to {{dotnet publish}} dir) * macOs: document {{No Java runtime present, requesting install.}} issue https://bugs.openjdk.java.net/browse/JDK-7131356, https://github.com/s-u/rJava/issues/37 * Service proxies are not supported because {{Remoting}} is not available on .NET Core: IGNITE-7281 * VS Code and Rider * Mono is supported (useful for 32 bit and/or older distros) * {{}} may be required > .NET: Document .NET Core support and running on Linux / macOs > - > > Key: IGNITE-7000 > URL: https://issues.apache.org/jira/browse/IGNITE-7000 > Project: Ignite > Issue Type: Task > Components: documentation, platforms >Reporter: Pavel Tupitsyn >Assignee: Pavel Tupitsyn >Priority: Minor > Labels: .NET, xplat > Fix For: 2.4 > > > Create a documentation page about running Ignite.NET under .NET Core and/or > Linux. Things to mention: > * Exceptions and delegates can't be serialized under .NET Core: > https://github.com/dotnet/corefx/issues/24424 > * Build warning - suppress {{NU1701}} with > {{NU1701}} > * Java home, dll paths, etc > * Publish and deploy (copy libs folder to {{dotnet publish}} dir) > * macOs: document {{No Java runtime present, requesting install.}} issue > https://bugs.openjdk.java.net/browse/JDK-7131356, > https://github.com/s-u/rJava/issues/37 > * Service proxies are not supported because {{Remoting}} is not available on > .NET Core: IGNITE-7281 > * VS Code and Rider > * Mono is supported (useful for 32 bit and/or older distros): need to set > {{IgniteHome}} > * {{ Version="4.4.0" />}} may be required -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (IGNITE-7000) .NET: Document .NET Core support and running on Linux / macOs
[ https://issues.apache.org/jira/browse/IGNITE-7000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pavel Tupitsyn updated IGNITE-7000: --- Description: Create a documentation page about running Ignite.NET under .NET Core and/or Linux. Things to mention: * Exceptions and delegates can't be serialized under .NET Core: https://github.com/dotnet/corefx/issues/24424 * Build warning - suppress {{NU1701}} with {{NU1701}} * Java home, dll paths, etc * Publish and deploy (copy libs folder to {{dotnet publish}} dir) * macOs: document {{No Java runtime present, requesting install.}} issue https://bugs.openjdk.java.net/browse/JDK-7131356, https://github.com/s-u/rJava/issues/37 * Service proxies are not supported because {{Remoting}} is not available on .NET Core: IGNITE-7281 * VS Code and Rider * Mono is supported (useful for 32 bit and/or older distros): need to set {{IgniteHome}}, need {{sudo apt-get install mono-reference-assemblies-4.0}} to build * {{}} may be required was: Create a documentation page about running Ignite.NET under .NET Core and/or Linux. Things to mention: * Exceptions and delegates can't be serialized under .NET Core: https://github.com/dotnet/corefx/issues/24424 * Build warning - suppress {{NU1701}} with {{NU1701}} * Java home, dll paths, etc * Publish and deploy (copy libs folder to {{dotnet publish}} dir) * macOs: document {{No Java runtime present, requesting install.}} issue https://bugs.openjdk.java.net/browse/JDK-7131356, https://github.com/s-u/rJava/issues/37 * Service proxies are not supported because {{Remoting}} is not available on .NET Core: IGNITE-7281 * VS Code and Rider * Mono is supported (useful for 32 bit and/or older distros): need to set {{IgniteHome}} * {{}} may be required > .NET: Document .NET Core support and running on Linux / macOs > - > > Key: IGNITE-7000 > URL: https://issues.apache.org/jira/browse/IGNITE-7000 > Project: Ignite > Issue Type: Task > Components: documentation, platforms >Reporter: Pavel Tupitsyn >Assignee: Pavel Tupitsyn >Priority: Minor > Labels: .NET, xplat > Fix For: 2.4 > > > Create a documentation page about running Ignite.NET under .NET Core and/or > Linux. Things to mention: > * Exceptions and delegates can't be serialized under .NET Core: > https://github.com/dotnet/corefx/issues/24424 > * Build warning - suppress {{NU1701}} with > {{NU1701}} > * Java home, dll paths, etc > * Publish and deploy (copy libs folder to {{dotnet publish}} dir) > * macOs: document {{No Java runtime present, requesting install.}} issue > https://bugs.openjdk.java.net/browse/JDK-7131356, > https://github.com/s-u/rJava/issues/37 > * Service proxies are not supported because {{Remoting}} is not available on > .NET Core: IGNITE-7281 > * VS Code and Rider > * Mono is supported (useful for 32 bit and/or older distros): need to set > {{IgniteHome}}, need {{sudo apt-get install mono-reference-assemblies-4.0}} > to build > * {{ Version="4.4.0" />}} may be required -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (IGNITE-7397) Fix wrong cache configuration for MLP training data
[ https://issues.apache.org/jira/browse/IGNITE-7397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Malykh reassigned IGNITE-7397: Assignee: Artem Malykh > Fix wrong cache configuration for MLP training data > --- > > Key: IGNITE-7397 > URL: https://issues.apache.org/jira/browse/IGNITE-7397 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.4 >Reporter: Artem Malykh >Assignee: Artem Malykh > Fix For: 2.4 > > > Replicated cache used in MLP group training should be configured as FULL_SYNC. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (IGNITE-7398) InstanceNotFoundException appears in the log when a cache is closed and MBeans are disabled
Stanislav Lukyanov created IGNITE-7398: -- Summary: InstanceNotFoundException appears in the log when a cache is closed and MBeans are disabled Key: IGNITE-7398 URL: https://issues.apache.org/jira/browse/IGNITE-7398 Project: Ignite Issue Type: Bug Affects Versions: 2.4 Reporter: Stanislav Lukyanov Priority: Minor If IGNITE_MBEANS_DISABLED is set to true, whenever a cache is started the following error is logged: javax.management.InstanceNotFoundException: org.apache:clsLdr=18b4aac2,igniteInstanceName=mbeans.GridMBeanDisableSelfTest0,group=Cache groups,name=MyCache at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getMBean(DefaultMBeanServerInterceptor.java:1095) at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.exclusiveUnregisterMBean(DefaultMBeanServerInterceptor.java:427) at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.unregisterMBean(DefaultMBeanServerInterceptor.java:415) at com.sun.jmx.mbeanserver.JmxMBeanServer.unregisterMBean(JmxMBeanServer.java:546) at org.apache.ignite.internal.processors.cache.GridCacheProcessor.cleanup(GridCacheProcessor.java:606) at org.apache.ignite.internal.processors.cache.GridCacheProcessor.stopCacheGroup(GridCacheProcessor.java:2264) at org.apache.ignite.internal.processors.cache.GridCacheProcessor.stopCacheGroup(GridCacheProcessor.java:2253) at org.apache.ignite.internal.processors.cache.GridCacheProcessor.stopCaches(GridCacheProcessor.java:907) at org.apache.ignite.internal.processors.cache.GridCacheProcessor.stop(GridCacheProcessor.java:872) at org.apache.ignite.internal.IgniteKernal.stop0(IgniteKernal.java:2316) at org.apache.ignite.internal.IgniteKernal.stop(IgniteKernal.java:2182) at org.apache.ignite.internal.IgnitionEx$IgniteNamedInstance.stop0(IgnitionEx.java:2512) at org.apache.ignite.internal.IgnitionEx$IgniteNamedInstance.stop(IgnitionEx.java:2475) at org.apache.ignite.internal.IgnitionEx.stop(IgnitionEx.java:362) at org.apache.ignite.Ignition.stop(Ignition.java:224) at org.apache.ignite.internal.IgniteKernal.close(IgniteKernal.java:3509) at org.apache.ignite.util.mbeans.GridMBeanDisableSelfTest.testCorrectMBeanInfo(GridMBeanDisableSelfTest.java:101) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at junit.framework.TestCase.runTest(TestCase.java:176) at org.apache.ignite.testframework.junits.GridAbstractTest.runTestInternal(GridAbstractTest.java:2001) at org.apache.ignite.testframework.junits.GridAbstractTest.access$000(GridAbstractTest.java:133) at org.apache.ignite.testframework.junits.GridAbstractTest$5.run(GridAbstractTest.java:1916) at java.lang.Thread.run(Thread.java:748) That's because GridCacheProcessor::cleanup unconditionally attempts to unregister cache's MBean, not checking whether or not the cache actually has an MBean registered for it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (IGNITE-7397) Fix wrong cache configuration for MLP training data
[ https://issues.apache.org/jira/browse/IGNITE-7397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Malykh updated IGNITE-7397: - Affects Version/s: 2.4 Fix Version/s: 2.4 > Fix wrong cache configuration for MLP training data > --- > > Key: IGNITE-7397 > URL: https://issues.apache.org/jira/browse/IGNITE-7397 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.4 >Reporter: Artem Malykh > Fix For: 2.4 > > > Replicated cache used in MLP group training should be configured as FULL_SYNC. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (IGNITE-7396) IgniteUtils.offheapSize may throw NullPointerException
[ https://issues.apache.org/jira/browse/IGNITE-7396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Gura updated IGNITE-7396: Fix Version/s: 2.4 > IgniteUtils.offheapSize may throw NullPointerException > -- > > Key: IGNITE-7396 > URL: https://issues.apache.org/jira/browse/IGNITE-7396 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.4 >Reporter: Vyacheslav Koptilin >Assignee: Vyacheslav Koptilin > Fix For: 2.4 > > > In case of a newly joined node does not specify > {{ATTR_DATA_REGIONS_OFFHEAP_SIZE}} via node attributes, > {{IgniteUtils.offheapSize()}} throws {{NullPointerException}} > {code} > [2018-01-11 > 12:57:14,257][ERROR][disco-event-worker-#222%cache%][GridDiscoveryManager] > Unexpected exception in discovery worker thread (ignored). > java.lang.NullPointerException > at > org.apache.ignite.internal.util.IgniteUtils.offheapSize(IgniteUtils.java:1250) > at > org.apache.ignite.internal.managers.discovery.GridDiscoveryManager.ackTopology(GridDiscoveryManager.java:1485) > at > org.apache.ignite.internal.managers.discovery.GridDiscoveryManager.access$9500(GridDiscoveryManager.java:166) > at > org.apache.ignite.internal.managers.discovery.GridDiscoveryManager$DiscoveryWorker.body0(GridDiscoveryManager.java:2644) > at > org.apache.ignite.internal.managers.discovery.GridDiscoveryManager$DiscoveryWorker.body(GridDiscoveryManager.java:2573) > at > org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:110) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (IGNITE-7397) Fix wrong cache configuration for MLP training data
Artem Malykh created IGNITE-7397: Summary: Fix wrong cache configuration for MLP training data Key: IGNITE-7397 URL: https://issues.apache.org/jira/browse/IGNITE-7397 Project: Ignite Issue Type: Bug Reporter: Artem Malykh Replicated cache used in MLP group training should be configured as FULL_SYNC. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (IGNITE-7396) IgniteUtils.offheapSize may throw NullPointerException
Vyacheslav Koptilin created IGNITE-7396: --- Summary: IgniteUtils.offheapSize may throw NullPointerException Key: IGNITE-7396 URL: https://issues.apache.org/jira/browse/IGNITE-7396 Project: Ignite Issue Type: Bug Affects Versions: 2.4 Reporter: Vyacheslav Koptilin Assignee: Vyacheslav Koptilin In case of a newly joined node does not specify {{ATTR_DATA_REGIONS_OFFHEAP_SIZE}} via node attributes, {{IgniteUtils.offheapSize()}} throws {{NullPointerException}} {code} [2018-01-11 12:57:14,257][ERROR][disco-event-worker-#222%cache%][GridDiscoveryManager] Unexpected exception in discovery worker thread (ignored). java.lang.NullPointerException at org.apache.ignite.internal.util.IgniteUtils.offheapSize(IgniteUtils.java:1250) at org.apache.ignite.internal.managers.discovery.GridDiscoveryManager.ackTopology(GridDiscoveryManager.java:1485) at org.apache.ignite.internal.managers.discovery.GridDiscoveryManager.access$9500(GridDiscoveryManager.java:166) at org.apache.ignite.internal.managers.discovery.GridDiscoveryManager$DiscoveryWorker.body0(GridDiscoveryManager.java:2644) at org.apache.ignite.internal.managers.discovery.GridDiscoveryManager$DiscoveryWorker.body(GridDiscoveryManager.java:2573) at org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:110) at java.lang.Thread.run(Thread.java:745) {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-1628) .NET: Ensure that Ignite works on Mono platform
[ https://issues.apache.org/jira/browse/IGNITE-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323932#comment-16323932 ] Pavel Tupitsyn commented on IGNITE-1628: * XMLDoc and Obsolete warnings are buggy on Mono, suppresses them (with condition only for mono) * String casing fixed in project references > .NET: Ensure that Ignite works on Mono platform > --- > > Key: IGNITE-1628 > URL: https://issues.apache.org/jira/browse/IGNITE-1628 > Project: Ignite > Issue Type: Task > Components: platforms >Affects Versions: ignite-1.4 >Reporter: Vladimir Ozerov >Assignee: Pavel Tupitsyn > Labels: .net > > *NOTE*: Targeted for 1.6, but could be moved even further in case of tight > release schedule. > *Goal* > As Microsoft is moving .Net towards open standards, Mono receives more an > more attention. > We need to ensure that our product works fine on this platform. This includes > both Windows, Linux and (possibly) Mac environments. > *Tasks* > - Ensure that Ignite works with Mono on Windows. This is the easiest task > because we only need to re-compile .Net part. > - Ensure that Ignite works with Mono on Linux. This will require alternate > build procedure because CPP recompilation will be required as well. > - Create relevant TC builds. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-6022) SQL: add native batch execution support for DML statements
[ https://issues.apache.org/jira/browse/IGNITE-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323886#comment-16323886 ] Roman Kondakov commented on IGNITE-6022: [~al.psc] 1. Ok, I'll get rid of it. 2. We do not fail on non-SQL exception due to JDBC specs 14.1.3 Handling Failures during Execution. Briefly: driver should process *all* queries in the batch despite of any of them failed with *any* reason. If query failed, we mark it as {{Statement.EXECUTE_FAILED}} at {{BatchUpdateException.getUpdateCounts}}. So we have to process all queries even if some of they fail with any exception, and return results of processing back to the client. 3. Ok, I'll fix it. 4. Ok, I'll fix it. 5. Ok, I'll fix it.. 6. Actually, I don't see any reasons for this check in {{UpdatePlanBuilder.checkPlanCanBeDistributed}}. I'll remove it. [~vozerov], is it safe to remove it? 7. Ok, I'll fix it. 8. Ok, I'll fix it. 9. Could you please point on such kind of violations? I haven't found any. 10. I agree, I'll add comments. 11. Ok, I'll fix it. > SQL: add native batch execution support for DML statements > -- > > Key: IGNITE-6022 > URL: https://issues.apache.org/jira/browse/IGNITE-6022 > Project: Ignite > Issue Type: Task > Components: sql >Affects Versions: 2.1 >Reporter: Vladimir Ozerov >Assignee: Roman Kondakov > Labels: iep-1, performance > Fix For: 2.4 > > > We have batch execution support for JDBC and ODBC drivers. This decreases > number of network hops. However, we do not have any batch execution support > on the server side. It means that for batch of N similar statements, every > statement will go through the whole execution chain - parsing, splitting, > communication with servers. And while parsing and splitting might be avoided > with help of statement cache, the most heavy part - network communication - > is still there. > We need to investigate how to optimize the flow for batch updates. Possible > improvements: > 1) Execute statements with certain degree of parallelism; > 2) Send several query execution requests to the server at once; > 3) Ensure that caches are used properly for batching - we should not parse > the same request multiple times. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-1628) .NET: Ensure that Ignite works on Mono platform
[ https://issues.apache.org/jira/browse/IGNITE-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323873#comment-16323873 ] Pavel Tupitsyn commented on IGNITE-1628: Setup steps on Linux: {code} sudo apt-get install mono-devel sudo apt-get install mono-reference-assemblies-4.0 {code} Build: {code} xbuild Apache.Ignite.sln {code} Run tests: TODO > .NET: Ensure that Ignite works on Mono platform > --- > > Key: IGNITE-1628 > URL: https://issues.apache.org/jira/browse/IGNITE-1628 > Project: Ignite > Issue Type: Task > Components: platforms >Affects Versions: ignite-1.4 >Reporter: Vladimir Ozerov >Assignee: Pavel Tupitsyn > Labels: .net > > *NOTE*: Targeted for 1.6, but could be moved even further in case of tight > release schedule. > *Goal* > As Microsoft is moving .Net towards open standards, Mono receives more an > more attention. > We need to ensure that our product works fine on this platform. This includes > both Windows, Linux and (possibly) Mac environments. > *Tasks* > - Ensure that Ignite works with Mono on Windows. This is the easiest task > because we only need to re-compile .Net part. > - Ensure that Ignite works with Mono on Linux. This will require alternate > build procedure because CPP recompilation will be required as well. > - Create relevant TC builds. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-6826) Change default DiscoverySpi ipFinder type for examples
[ https://issues.apache.org/jira/browse/IGNITE-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323867#comment-16323867 ] Ryabov Dmitrii commented on IGNITE-6826: I'll check it. > Change default DiscoverySpi ipFinder type for examples > -- > > Key: IGNITE-6826 > URL: https://issues.apache.org/jira/browse/IGNITE-6826 > Project: Ignite > Issue Type: Improvement > Components: examples >Affects Versions: 2.3 >Reporter: Alexey Popov >Assignee: Ryabov Dmitrii > Labels: newbie > Fix For: 2.4 > > > It is better to change multicast ipFinder to static (vm) ipFinder for java > examples, .NET examples and C++ examples. > http://apache-ignite-developers.2346864.n4.nabble.com/ipFinder-configuration-for-Samples-td23818.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-6736) Java 9: rework GridCacheMapEntry synchronization logic to avoid Unsafe.monitor* methods
[ https://issues.apache.org/jira/browse/IGNITE-6736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323860#comment-16323860 ] Andrey Gura commented on IGNITE-6736: - LGTM. Perfromance tests are ok. But now we have additional memory overhead on each entry. Merged to master branch. > Java 9: rework GridCacheMapEntry synchronization logic to avoid > Unsafe.monitor* methods > --- > > Key: IGNITE-6736 > URL: https://issues.apache.org/jira/browse/IGNITE-6736 > Project: Ignite > Issue Type: Task > Components: cache >Reporter: Vladimir Ozerov >Assignee: Andrey Kuznetsov > Fix For: 2.4 > > > {{GridCacheMapEntry}} class rely on {{synchronized}} on itself heavily. In > {{ATOMIC}} caches we lock multiple entries at once using > {{Unsafe.monitorEnter/Exit}} methods. Unfortunately these methods were > removed in Java 9. Recursion is not an option, as it would cause stack > overflow for {{putAll}} operations with multiple entries. > Possible fixes: > 1) Rework {{synchronized}} to {{ReentrantLock}}. Easy, but may cause > additional memory pressure. > 2) Have different implementations for Java 8 ({{synchronzied}}) and Java 9 > ({{ReentrantLock}}) - much more complex solution, because we will require > separate module for Java 8 and Java 9. > 3) Rework {{ATOMIC}} caches, so that {{putAll}} operation updates entries > one-by-one. As a side effect it will eliminate deadlocks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (IGNITE-6736) Java 9: rework GridCacheMapEntry synchronization logic to avoid Unsafe.monitor* methods
[ https://issues.apache.org/jira/browse/IGNITE-6736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323860#comment-16323860 ] Andrey Gura edited comment on IGNITE-6736 at 1/12/18 11:51 AM: --- LGTM. Perfromance tests are ok. But now we have additional memory overhead on each entry. Merged to master branch. Thanks for contribution! was (Author: agura): LGTM. Perfromance tests are ok. But now we have additional memory overhead on each entry. Merged to master branch. > Java 9: rework GridCacheMapEntry synchronization logic to avoid > Unsafe.monitor* methods > --- > > Key: IGNITE-6736 > URL: https://issues.apache.org/jira/browse/IGNITE-6736 > Project: Ignite > Issue Type: Task > Components: cache >Reporter: Vladimir Ozerov >Assignee: Andrey Kuznetsov > Fix For: 2.4 > > > {{GridCacheMapEntry}} class rely on {{synchronized}} on itself heavily. In > {{ATOMIC}} caches we lock multiple entries at once using > {{Unsafe.monitorEnter/Exit}} methods. Unfortunately these methods were > removed in Java 9. Recursion is not an option, as it would cause stack > overflow for {{putAll}} operations with multiple entries. > Possible fixes: > 1) Rework {{synchronized}} to {{ReentrantLock}}. Easy, but may cause > additional memory pressure. > 2) Have different implementations for Java 8 ({{synchronzied}}) and Java 9 > ({{ReentrantLock}}) - much more complex solution, because we will require > separate module for Java 8 and Java 9. > 3) Rework {{ATOMIC}} caches, so that {{putAll}} operation updates entries > one-by-one. As a side effect it will eliminate deadlocks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-6826) Change default DiscoverySpi ipFinder type for examples
[ https://issues.apache.org/jira/browse/IGNITE-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323856#comment-16323856 ] Pavel Tupitsyn commented on IGNITE-6826: Before that change you could run many examples with ignite.bat/sh with default config, and now you can't (at least for .NET). I don't think this is a good change. > Change default DiscoverySpi ipFinder type for examples > -- > > Key: IGNITE-6826 > URL: https://issues.apache.org/jira/browse/IGNITE-6826 > Project: Ignite > Issue Type: Improvement > Components: examples >Affects Versions: 2.3 >Reporter: Alexey Popov >Assignee: Ryabov Dmitrii > Labels: newbie > Fix For: 2.4 > > > It is better to change multicast ipFinder to static (vm) ipFinder for java > examples, .NET examples and C++ examples. > http://apache-ignite-developers.2346864.n4.nabble.com/ipFinder-configuration-for-Samples-td23818.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-7050) Add support for spring3
[ https://issues.apache.org/jira/browse/IGNITE-7050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323850#comment-16323850 ] Anton Vinogradov commented on IGNITE-7050: -- [~mcherkas] 1) Please discuss this change at devlist first. 2) I see that your solution differ to hibernate support we have. > Add support for spring3 > --- > > Key: IGNITE-7050 > URL: https://issues.apache.org/jira/browse/IGNITE-7050 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.3 >Reporter: Mikhail Cherkasov >Assignee: Mikhail Cherkasov > Fix For: 2.4 > > > there are still users who use spring3 and hence can't use ignite which > depends on spring4. I think we can create separate modules for spring3 > support, like it was done for hibernate 4/5. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (IGNITE-7394) .NET: Add F# tests
[ https://issues.apache.org/jira/browse/IGNITE-7394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pavel Tupitsyn updated IGNITE-7394: --- Description: Add tests to ensure that Ignite.NET can be used from F#. * Check that all F# data types can be used in cache without issues (records, tuples, collections, unions, etc). * Compute * LINQ These tests can be added to {{Apache.Ignite.DotNetCore.sln}}. was: Add tests to ensure that Ignite.NET can be used from F#. * Check that all F# data types can be used in cache without issues (records, tuples, etc). * Compute * LINQ These tests can be added to {{Apache.Ignite.DotNetCore.sln}}. > .NET: Add F# tests > -- > > Key: IGNITE-7394 > URL: https://issues.apache.org/jira/browse/IGNITE-7394 > Project: Ignite > Issue Type: Improvement > Components: platforms >Affects Versions: 2.4 >Reporter: Pavel Tupitsyn >Priority: Minor > Labels: .NET, F#, newbie > > Add tests to ensure that Ignite.NET can be used from F#. > * Check that all F# data types can be used in cache without issues (records, > tuples, collections, unions, etc). > * Compute > * LINQ > These tests can be added to {{Apache.Ignite.DotNetCore.sln}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (IGNITE-7395) Web console: improve list-editable scope variables access
[ https://issues.apache.org/jira/browse/IGNITE-7395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ilya Borisov reassigned IGNITE-7395: Assignee: Dmitriy Shabalin (was: Ilya Borisov) Please review. > Web console: improve list-editable scope variables access > - > > Key: IGNITE-7395 > URL: https://issues.apache.org/jira/browse/IGNITE-7395 > Project: Ignite > Issue Type: Improvement > Components: wizards >Reporter: Ilya Borisov >Assignee: Dmitriy Shabalin >Priority: Minor > > *The problem:* > The only way to access an item instance from inside list-editable > transclusion slots is via _$parent.item_. This approach is both cumbersome > and prone to $scope-related issues (i.e. input elements can't access it if > there are intermidate scopes). > *What to do:* > Provide an easy and reliable way to access item (maybe as _$item_?) variable. > It would also be handy to be able to change item alias name (useful for > nested list-editable's). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (IGNITE-7395) Web console: improve list-editable scope variables access
[ https://issues.apache.org/jira/browse/IGNITE-7395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323831#comment-16323831 ] Ilya Borisov edited comment on IGNITE-7395 at 1/12/18 11:08 AM: [~Dmitriyff] Please review. was (Author: klaster_1): Please review. > Web console: improve list-editable scope variables access > - > > Key: IGNITE-7395 > URL: https://issues.apache.org/jira/browse/IGNITE-7395 > Project: Ignite > Issue Type: Improvement > Components: wizards >Reporter: Ilya Borisov >Assignee: Dmitriy Shabalin >Priority: Minor > > *The problem:* > The only way to access an item instance from inside list-editable > transclusion slots is via _$parent.item_. This approach is both cumbersome > and prone to $scope-related issues (i.e. input elements can't access it if > there are intermidate scopes). > *What to do:* > Provide an easy and reliable way to access item (maybe as _$item_?) variable. > It would also be handy to be able to change item alias name (useful for > nested list-editable's). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (IGNITE-7395) Web console: improve list-editable scope variables access
[ https://issues.apache.org/jira/browse/IGNITE-7395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ilya Borisov updated IGNITE-7395: - Description: *The problem:* The only way to access an item instance from inside list-editable transclusion slots is via _$parent.item_. This approach is both cumbersome and prone to $scope-related issues (i.e. input elements can't access it if there are intermidate scopes). *What to do:* Provide an easy and reliable way to access item (maybe as _$item_?) variable. It would also be handy to be able to change item alias name (useful for nested list-editable's). was: *The problem:* The only way to access an item instance from inside list-editable transclusion slots is via _$parent.item_. This approach is both cumbersome and prone to $scope-related issues (i.e. input elements can't access it if there are intermidate scopes). *What to do:* Provide an easy and reliable way to access item (maybe as _$item_?) and _$index_ variables (used by unique ignite-validator). It would also be handy to be able to change item alias name (useful for nested list-editable's). > Web console: improve list-editable scope variables access > - > > Key: IGNITE-7395 > URL: https://issues.apache.org/jira/browse/IGNITE-7395 > Project: Ignite > Issue Type: Improvement > Components: wizards >Reporter: Ilya Borisov >Assignee: Ilya Borisov >Priority: Minor > > *The problem:* > The only way to access an item instance from inside list-editable > transclusion slots is via _$parent.item_. This approach is both cumbersome > and prone to $scope-related issues (i.e. input elements can't access it if > there are intermidate scopes). > *What to do:* > Provide an easy and reliable way to access item (maybe as _$item_?) variable. > It would also be handy to be able to change item alias name (useful for > nested list-editable's). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (IGNITE-5725) Adapt TracerTest for TC builds.
[ https://issues.apache.org/jira/browse/IGNITE-5725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Ignatenko reassigned IGNITE-5725: -- Assignee: Oleg Ignatenko > Adapt TracerTest for TC builds. > --- > > Key: IGNITE-5725 > URL: https://issues.apache.org/jira/browse/IGNITE-5725 > Project: Ignite > Issue Type: Bug > Components: build, ml >Reporter: Yury Babak >Assignee: Oleg Ignatenko > Labels: continuous_integration, ml, technical_debt > Attachments: TracerTest.java > > > Currently > [TracerTest|https://github.com/apache/ignite/blob/master/modules/ml/src/test/java/org/apache/ignite/ml/math/TracerTest.java] > runs browser when it invokes {{Tracer.showHtml}} but we don`t have even X11 > on TeamCity. So we need to decide - run add possibility to run browser on TC, > change tests and abstain of calling > [Desktop.getDesktop().browse|https://docs.oracle.com/javase/7/docs/api/java/awt/Desktop.html#browse(java.net.URI)] > during TC build or just ignore this test for TC build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (IGNITE-7256) Web Console: Improve notification management.
[ https://issues.apache.org/jira/browse/IGNITE-7256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Kuznetsov reassigned IGNITE-7256: Resolution: Fixed Assignee: Pavel Konstantinov (was: Alexey Kuznetsov) Merged to master. > Web Console: Improve notification management. > - > > Key: IGNITE-7256 > URL: https://issues.apache.org/jira/browse/IGNITE-7256 > Project: Ignite > Issue Type: Improvement > Components: wizards >Reporter: Alexander Kalinin >Assignee: Pavel Konstantinov > Fix For: 2.4 > > > Add checkbox with "Show message" and remeber last input text. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (IGNITE-7386) Get rid of LongAdder8, ConcurrentHashMap8, etc
[ https://issues.apache.org/jira/browse/IGNITE-7386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anton Vinogradov reassigned IGNITE-7386: Assignee: Aleksey Plekhanov > Get rid of LongAdder8, ConcurrentHashMap8, etc > -- > > Key: IGNITE-7386 > URL: https://issues.apache.org/jira/browse/IGNITE-7386 > Project: Ignite > Issue Type: Task >Reporter: Anton Vinogradov >Assignee: Aleksey Plekhanov > Fix For: 2.5 > > > Since we're dropping java7 support there is no need now to use > {{LongAdder8}}, {{ConcurrentHashMap8}}, ... > We should remove all classes from {{org.jsr166}} namespace and use > corresponding classes from jdk8. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-6022) SQL: add native batch execution support for DML statements
[ https://issues.apache.org/jira/browse/IGNITE-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323815#comment-16323815 ] Alexander Paschenko commented on IGNITE-6022: - [~rkondakov] Hi, my comments: 1. Do we really need additional ctor in {{SqlFieldsQueryEx}}? Args field is a list, not an array, and we have null check at {{addBatchedArgs}}, so nothing prevents us from using old ctor and adding as much args as we like. I don't think that pre-allocating list of given size justifies existence of an additional ctor we clearly can live without. 2. {{DmlStatementsProcessor.doInsertBatched}}: why do we not fail fast on unexpected exceptions and instead try to convert non {{IgniteSQLException}} s to {{SQLException}} s? [~vozerov] what could be correct behavior here, how do you think? I believe we should handle only {{IgniteSQLException}} s at this point. 3. {{DmlUtils.isBatched}} can be greatly simplified and turned into a one-liner, please do so ({{return (instanceof && ((QueryEx)isBatched)}}) 4. {{SqlFieldsQueryEx.isBatched}} - please use {{F.isEmpty}} 5. {{JdbcRequestHandler.executeBatchedQuery}}: you don't need {{return}} in {{catch}} clause, instead please move everything after {{catch}} into {{try}}. Local var {{qryRes}} will be declared inside {{try}} then too. 6. Why does {{UpdatePlanBuilder.checkPlanCanBeDistributed}} count {{DmlUtils.isBatched}} unconditionally? Probably there are some cases when batch can be executed in distributed manner? 7. {{DmlBatchSender.add}}: you can simplify code and get rid of duplicate code at the end of this method by rewriting condition to {{if (batch.put(...) != null || batch.size() >= size)}} 8. {{DmlBatchSender.processPage}}: this constant copying of maps on each page looks quite suspicious to me. To avoid this, just keep two maps instead of one where needed: {{}} and {{Object, EntryProcessor}} (same sets of keys) and pass both to {{processPage}}. Method {{countAllRows}} will get simpler too (it will need only values of the first map). 9. Multiple violations of coding conventions - please don't put closing curly brace and anything else on the same line - like this: {{} catch {}}, instead you should move {{catch}} to the next line. 10. In the cases where there are maps or lists with contents that are hard to understand intuitively I would write concise comments about what those tons of generic args mean, or what are those lists of lists of lists. 11. {{UpdatePlan}}: {{createRows(Object[])}} and {{extractArgsValues}} contain parts of clearly copy-pasted code. Can't we unite those? Probably {{createRows(Object[])}} should just call {{extractArgsValues}}? > SQL: add native batch execution support for DML statements > -- > > Key: IGNITE-6022 > URL: https://issues.apache.org/jira/browse/IGNITE-6022 > Project: Ignite > Issue Type: Task > Components: sql >Affects Versions: 2.1 >Reporter: Vladimir Ozerov >Assignee: Roman Kondakov > Labels: iep-1, performance > Fix For: 2.4 > > > We have batch execution support for JDBC and ODBC drivers. This decreases > number of network hops. However, we do not have any batch execution support > on the server side. It means that for batch of N similar statements, every > statement will go through the whole execution chain - parsing, splitting, > communication with servers. And while parsing and splitting might be avoided > with help of statement cache, the most heavy part - network communication - > is still there. > We need to investigate how to optimize the flow for batch updates. Possible > improvements: > 1) Execute statements with certain degree of parallelism; > 2) Send several query execution requests to the server at once; > 3) Ensure that caches are used properly for batching - we should not parse > the same request multiple times. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (IGNITE-7395) Web console: improve list-editable scope variables access
Ilya Borisov created IGNITE-7395: Summary: Web console: improve list-editable scope variables access Key: IGNITE-7395 URL: https://issues.apache.org/jira/browse/IGNITE-7395 Project: Ignite Issue Type: Improvement Components: wizards Reporter: Ilya Borisov Assignee: Ilya Borisov Priority: Minor *The problem:* The only way to access an item instance from inside list-editable transclusion slots is via _$parent.item_. This approach is both cumbersome and prone to $scope-related issues (i.e. input elements can't access it if there are intermidate scopes). *What to do:* Provide an easy and reliable way to access item (maybe as _$item_?) and _$index_ variables (used by unique ignite-validator). It would also be handy to be able to change item alias name (useful for nested list-editable's). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-5725) Adapt TracerTest for TC builds.
[ https://issues.apache.org/jira/browse/IGNITE-5725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323782#comment-16323782 ] ASF GitHub Bot commented on IGNITE-5725: GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/3363 IGNITE-5725 Adapt TracerTest for TC builds. - implemented adaptive testing approach -- verified with diffs overview, clean rebuild and execution of unit tests in both desktop and headless environments You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-5725-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3363.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3363 commit 57ac99736f0748eab79bc408111dfb9e2d077e2e Author: Oleg Ignatenko Date: 2018-01-12T10:02:20Z IGNITE-5725 Adapt TracerTest for TC builds. - implemented adaptive testing approach -- verified with diffs overview, clean rebuild and execution of unit tests in both desktop and headless environments > Adapt TracerTest for TC builds. > --- > > Key: IGNITE-5725 > URL: https://issues.apache.org/jira/browse/IGNITE-5725 > Project: Ignite > Issue Type: Bug > Components: build, ml >Reporter: Yury Babak > Labels: continuous_integration, ml, technical_debt > Attachments: TracerTest.java > > > Currently > [TracerTest|https://github.com/apache/ignite/blob/master/modules/ml/src/test/java/org/apache/ignite/ml/math/TracerTest.java] > runs browser when it invokes {{Tracer.showHtml}} but we don`t have even X11 > on TeamCity. So we need to decide - run add possibility to run browser on TC, > change tests and abstain of calling > [Desktop.getDesktop().browse|https://docs.oracle.com/javase/7/docs/api/java/awt/Desktop.html#browse(java.net.URI)] > during TC build or just ignore this test for TC build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (IGNITE-7256) Web Console: Improve notification management.
[ https://issues.apache.org/jira/browse/IGNITE-7256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Kuznetsov updated IGNITE-7256: - Fix Version/s: 2.4 > Web Console: Improve notification management. > - > > Key: IGNITE-7256 > URL: https://issues.apache.org/jira/browse/IGNITE-7256 > Project: Ignite > Issue Type: Improvement > Components: wizards >Reporter: Alexander Kalinin >Assignee: Alexey Kuznetsov > Fix For: 2.4 > > > Add checkbox with "Show message" and remeber last input text. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-7332) Create selftest suite for ml examples
[ https://issues.apache.org/jira/browse/IGNITE-7332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323739#comment-16323739 ] ASF GitHub Bot commented on IGNITE-7332: Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3316 > Create selftest suite for ml examples > - > > Key: IGNITE-7332 > URL: https://issues.apache.org/jira/browse/IGNITE-7332 > Project: Ignite > Issue Type: Improvement > Components: ml >Reporter: Yury Babak >Assignee: Anton Dmitriev > Labels: examples > Fix For: 2.4 > > > We want to add self test suite for our examples like we have for java8 > examples. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (IGNITE-7256) Web Console: Improve notification management.
[ https://issues.apache.org/jira/browse/IGNITE-7256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Kuznetsov updated IGNITE-7256: - Component/s: wizards > Web Console: Improve notification management. > - > > Key: IGNITE-7256 > URL: https://issues.apache.org/jira/browse/IGNITE-7256 > Project: Ignite > Issue Type: Improvement > Components: wizards >Reporter: Alexander Kalinin >Assignee: Alexey Kuznetsov > > Add checkbox with "Show message" and remeber last input text. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (IGNITE-7391) Web console: ClientConfigurationFactory class name is missing in generated project
[ https://issues.apache.org/jira/browse/IGNITE-7391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Kuznetsov reassigned IGNITE-7391: Assignee: Pavel Konstantinov (was: Alexey Kuznetsov) Merged to master. > Web console: ClientConfigurationFactory class name is missing in generated > project > -- > > Key: IGNITE-7391 > URL: https://issues.apache.org/jira/browse/IGNITE-7391 > Project: Ignite > Issue Type: Bug > Components: wizards >Affects Versions: 2.4 >Reporter: Pavel Konstantinov >Assignee: Pavel Konstantinov >Priority: Blocker > Fix For: 2.4 > > > It present in Java preview but absent in downloaded project -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (IGNITE-7391) Web console: ClientConfigurationFactory class name is missing in generated project
[ https://issues.apache.org/jira/browse/IGNITE-7391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Kuznetsov updated IGNITE-7391: - Component/s: wizards > Web console: ClientConfigurationFactory class name is missing in generated > project > -- > > Key: IGNITE-7391 > URL: https://issues.apache.org/jira/browse/IGNITE-7391 > Project: Ignite > Issue Type: Bug > Components: wizards >Affects Versions: 2.4 >Reporter: Pavel Konstantinov >Assignee: Pavel Konstantinov >Priority: Blocker > Fix For: 2.4 > > > It present in Java preview but absent in downloaded project -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (IGNITE-7195) GridToStringBuilder should limit large collections output to first N elements
[ https://issues.apache.org/jira/browse/IGNITE-7195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Belyak resolved IGNITE-7195. -- Resolution: Fixed Fixed in IGNITE-7385 > GridToStringBuilder should limit large collections output to first N elements > - > > Key: IGNITE-7195 > URL: https://issues.apache.org/jira/browse/IGNITE-7195 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.3 >Reporter: Yakov Zhdanov >Assignee: Alexander Belyak > Fix For: 2.4 > > > GridToStringBuilder should limit large collections output to first N elements > (otherwise, OOME is possible). N should be limited by > IGNITE_TO_STRING_COLLECTION_LIMIT system property and should be 10 by default. > Upd: how about we limit GridToStringBuilder to 1 chars by default to > avoid OOME in complex recursive obj graphs? and (1) provide system property > to change default and (2) also provide S.toString() overload that will accept > maxLen parameter. > Upd1: how about we add thread local message length counter in addition to > thread local with buffers. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (IGNITE-7385) Fix GridToStringBuilder
[ https://issues.apache.org/jira/browse/IGNITE-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Belyak closed IGNITE-7385. > Fix GridToStringBuilder > --- > > Key: IGNITE-7385 > URL: https://issues.apache.org/jira/browse/IGNITE-7385 > Project: Ignite > Issue Type: Bug >Reporter: Alexander Belyak > > Need to review and merge ignite-7195-hotfix. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-7203) Java 8 by default
[ https://issues.apache.org/jira/browse/IGNITE-7203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323733#comment-16323733 ] ASF GitHub Bot commented on IGNITE-7203: Github user vveider closed the pull request at: https://github.com/apache/ignite/pull/3348 > Java 8 by default > - > > Key: IGNITE-7203 > URL: https://issues.apache.org/jira/browse/IGNITE-7203 > Project: Ignite > Issue Type: Improvement >Reporter: Anton Vinogradov >Assignee: Peter Ivanov > Labels: important > Fix For: 2.4 > > > We should drop Java 7 support. > 1) We should > - get rid of java8 profiles > - relocate tests and sources with *.java8.* package to regular sources > - set > {noformat} > 1.8 > 1.8 > {noformat} > by default > 2) Release process > https://ci.ignite.apache.org/project.html?projectId=AssemblyAndRelease > should be updated if necessary. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (IGNITE-7394) .NET: Add F# tests
[ https://issues.apache.org/jira/browse/IGNITE-7394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pavel Tupitsyn updated IGNITE-7394: --- Labels: .NET F# newbie (was: .NET F#) > .NET: Add F# tests > -- > > Key: IGNITE-7394 > URL: https://issues.apache.org/jira/browse/IGNITE-7394 > Project: Ignite > Issue Type: Improvement > Components: platforms >Affects Versions: 2.4 >Reporter: Pavel Tupitsyn >Priority: Minor > Labels: .NET, F#, newbie > > Add tests to ensure that Ignite.NET can be used from F#. > * Check that all F# data types can be used in cache without issues (records, > tuples, etc). > * Compute > * LINQ > These tests can be added to {{Apache.Ignite.DotNetCore.sln}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (IGNITE-7394) .NET: Add F# tests
Pavel Tupitsyn created IGNITE-7394: -- Summary: .NET: Add F# tests Key: IGNITE-7394 URL: https://issues.apache.org/jira/browse/IGNITE-7394 Project: Ignite Issue Type: Improvement Components: platforms Affects Versions: 2.4 Reporter: Pavel Tupitsyn Priority: Minor Add tests to ensure that Ignite.NET can be used from F#. In particular, check that all F# data types can be used in cache without issues (records, tuples, etc). These tests can be added to {{Apache.Ignite.DotNetCore.sln}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (IGNITE-7394) .NET: Add F# tests
[ https://issues.apache.org/jira/browse/IGNITE-7394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pavel Tupitsyn updated IGNITE-7394: --- Description: Add tests to ensure that Ignite.NET can be used from F#. * Check that all F# data types can be used in cache without issues (records, tuples, etc). * Compute * LINQ These tests can be added to {{Apache.Ignite.DotNetCore.sln}}. was: Add tests to ensure that Ignite.NET can be used from F#. In particular, check that all F# data types can be used in cache without issues (records, tuples, etc). These tests can be added to {{Apache.Ignite.DotNetCore.sln}}. > .NET: Add F# tests > -- > > Key: IGNITE-7394 > URL: https://issues.apache.org/jira/browse/IGNITE-7394 > Project: Ignite > Issue Type: Improvement > Components: platforms >Affects Versions: 2.4 >Reporter: Pavel Tupitsyn >Priority: Minor > Labels: .NET, F# > > Add tests to ensure that Ignite.NET can be used from F#. > * Check that all F# data types can be used in cache without issues (records, > tuples, etc). > * Compute > * LINQ > These tests can be added to {{Apache.Ignite.DotNetCore.sln}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (IGNITE-7380) Avoid updating PagePartitionCounters in case all counters were not modified
[ https://issues.apache.org/jira/browse/IGNITE-7380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitriy Pavlov updated IGNITE-7380: --- Fix Version/s: 2.4 > Avoid updating PagePartitionCounters in case all counters were not modified > --- > > Key: IGNITE-7380 > URL: https://issues.apache.org/jira/browse/IGNITE-7380 > Project: Ignite > Issue Type: Improvement > Components: persistence >Reporter: Dmitriy Pavlov >Assignee: Dmitriy Pavlov >Priority: Critical > Fix For: 2.4 > > > PagePartitionCountersIO ignores actual values of counters and marks pages > dirty even if partition has no counters update. > This leads to PAGE_RECORD creation for pages from PagePartitionCountersIO > and as result with pages from TrackingPageIO. > These modificaiton may be skipped if counters are checked for equality before > storing data. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (IGNITE-7393) Apache Ignite delivery in RPM / DEV packages
Peter Ivanov created IGNITE-7393: Summary: Apache Ignite delivery in RPM / DEV packages Key: IGNITE-7393 URL: https://issues.apache.org/jira/browse/IGNITE-7393 Project: Ignite Issue Type: Task Reporter: Peter Ivanov Assignee: Peter Ivanov Priority: Critical Fix For: 2.5 Aggregation task for first stage of preparing Apache Ignite delivery through RPM / DEB packages. Steps: # Prepare source-based package build procedures for RPM and DEB. # Introduce these build procedures to Release Apache Ignite task in PublicTC (including generation of RPM / DEB repositories structure for deployment to apache.org/dist). # Introduce PPA DEB repository for Apache Ignite. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-6826) Change default DiscoverySpi ipFinder type for examples
[ https://issues.apache.org/jira/browse/IGNITE-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323718#comment-16323718 ] ASF GitHub Bot commented on IGNITE-6826: GitHub user SomeFire opened a pull request: https://github.com/apache/ignite/pull/3362 IGNITE-6826 You can merge this pull request into a Git repository by running: $ git pull https://github.com/SomeFire/ignite ignite-6826 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3362.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3362 commit cd268cf53b769d26e3ae8a243013cb028569a846 Author: Dmitrii Ryabov Date: 2017-12-27T10:25:39Z IGNITE-6826: ipFinder changed in java examples. commit 78783a17fb625b854a7a3e3fa86bea918b2b2637 Author: Dmitrii Ryabov Date: 2018-01-11T14:11:11Z IGNITE-6826: ipFinder changed in dotnet examples. commit 69f85efa93195de88e691368b333f3633504ce50 Author: Dmitrii Ryabov Date: 2018-01-11T14:16:53Z IGNITE-6826: ipFinder changed in cpp examples. > Change default DiscoverySpi ipFinder type for examples > -- > > Key: IGNITE-6826 > URL: https://issues.apache.org/jira/browse/IGNITE-6826 > Project: Ignite > Issue Type: Improvement > Components: examples >Affects Versions: 2.3 >Reporter: Alexey Popov >Assignee: Ryabov Dmitrii > Labels: newbie > > It is better to change multicast ipFinder to static (vm) ipFinder for java > examples, .NET examples and C++ examples. > http://apache-ignite-developers.2346864.n4.nabble.com/ipFinder-configuration-for-Samples-td23818.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-7301) .NET: Cluster auto activation (baseline topology)
[ https://issues.apache.org/jira/browse/IGNITE-7301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323713#comment-16323713 ] Pavel Tupitsyn commented on IGNITE-7301: All done, waiting for Java tickets (IGNITE-5850, IGNITE-5851). > .NET: Cluster auto activation (baseline topology) > - > > Key: IGNITE-7301 > URL: https://issues.apache.org/jira/browse/IGNITE-7301 > Project: Ignite > Issue Type: Improvement > Components: platforms >Affects Versions: 2.4 >Reporter: Pavel Tupitsyn >Assignee: Pavel Tupitsyn > Labels: .NET, IEP-4, Phase-1 > Fix For: 2.4 > > > Add auto activation related APIs to .NET, see > https://cwiki.apache.org/confluence/display/IGNITE/IEP-4+Baseline+topology+for+caches -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-6456) Add flags to ClientConnectorConfiguration which enable/disable different clients
[ https://issues.apache.org/jira/browse/IGNITE-6456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323690#comment-16323690 ] Pavel Tupitsyn commented on IGNITE-6456: Looks good to me. > Add flags to ClientConnectorConfiguration which enable/disable different > clients > > > Key: IGNITE-6456 > URL: https://issues.apache.org/jira/browse/IGNITE-6456 > Project: Ignite > Issue Type: Improvement > Components: jdbc, odbc, thin client >Affects Versions: 2.1 >Reporter: Igor Sapego >Assignee: Roman Kondakov > Labels: usability > Fix For: 2.4 > > > There is currently no way to disable only one client. For example, currently > you can't disallow thin JDBC driver connectivity alone, you can only disable > the whole {{ClientListenerProcessor}}, which is going to disable ODBC and > thin .NET clients as well. > We should add options to disable/enable every single client, supported by the > {{ClientListenerProcessor}} separately. For example, we can add flags to the > {{ClientConnectorConfiguration}}: > {{allowJdbc}} > {{allowOdbc}} > {{allowClient}} -- This message was sent by Atlassian JIRA (v6.4.14#64029)