[jira] [Commented] (IGNITE-11278) SQL: Extract query parsing into separate class
[ https://issues.apache.org/jira/browse/IGNITE-11278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764335#comment-16764335 ] Vladimir Ozerov commented on IGNITE-11278: -- Fixed failures. Re-run: https://ci.ignite.apache.org/viewQueued.html?itemId=3051392 https://ci.ignite.apache.org/viewQueued.html?itemId=3051390 https://ci.ignite.apache.org/viewQueued.html?itemId=3051388 https://ci.ignite.apache.org/viewQueued.html?itemId=3051386 https://ci.ignite.apache.org/viewQueued.html?itemId=3051384 https://ci.ignite.apache.org/viewQueued.html?itemId=3051382 https://ci.ignite.apache.org/viewQueued.html?itemId=3051380 > SQL: Extract query parsing into separate class > -- > > Key: IGNITE-11278 > URL: https://issues.apache.org/jira/browse/IGNITE-11278 > Project: Ignite > Issue Type: Task > Components: sql >Reporter: Vladimir Ozerov >Assignee: Vladimir Ozerov >Priority: Major > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > # Introduce separate command types for SELECT, DML and others commands > # Move parsing logic and query cache to separate class > # Fix bug with query parallelism when "distributedQueries" flag is modified > not for newly created query, but globally. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11278) SQL: Extract query parsing into separate class
[
https://issues.apache.org/jira/browse/IGNITE-11278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764324#comment-16764324
]
Ignite TC Bot commented on IGNITE-11278:
{panel:title=--> Run :: All: Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}ZooKeeper (Discovery) 1{color} [[tests 0 TIMEOUT , Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=3048016]]
{color:#d04437}Queries 1{color} [[tests
21|https://ci.ignite.apache.org/viewLog.html?buildId=3048070]]
* IgniteBinaryCacheQueryTestSuite:
IgniteCachelessQueriesSelfTest.testLocalTwoStepQueryOnReplicatedAndSegmentedCacheWithLocalFlag
- 0,0% fails in last 406 master runs.
* IgniteBinaryCacheQueryTestSuite:
IgniteCachelessQueriesSelfTest.testDistributedQueryOnReplicatedCaches - 0,0%
fails in last 406 master runs.
* IgniteBinaryCacheQueryTestSuite:
IgniteCachelessQueriesSelfTest.testLocalQueryOnReplicatedCachesWithLocalFlag -
0,0% fails in last 406 master runs.
* IgniteBinaryCacheQueryTestSuite:
IgniteCachelessQueriesSelfTest.testLocalTwoStepQueryOnSegmentedCachesWithLocalFlag
- 0,0% fails in last 406 master runs.
* IgniteBinaryCacheQueryTestSuite:
IgniteCachelessQueriesSelfTest.testDistributedQueryOnPartitionedAndReplicatedCache
- 0,0% fails in last 406 master runs.
* IgniteBinaryCacheQueryTestSuite:
IgniteCachelessQueriesSelfTest.testDistributedQueryOnReplicatedAndSegmentedCacheWithReplicatedFlag
- 0,0% fails in last 406 master runs.
* IgniteBinaryCacheQueryTestSuite:
IgniteCachelessQueriesSelfTest.testDistributedQueryOnReplicatedAndSegmentedCache
- 0,0% fails in last 406 master runs.
* IgniteBinaryCacheQueryTestSuite:
IgniteCachelessQueriesSelfTest.testDistributedQueryOnPartitionedCaches - 0,0%
fails in last 406 master runs.
* IgniteBinaryCacheQueryTestSuite:
IgniteCachelessQueriesSelfTest.testDistributedQueryOnSegmentedCachesWithReplicatedFlag
- 0,0% fails in last 406 master runs.
* IgniteBinaryCacheQueryTestSuite:
IgniteCachelessQueriesSelfTest.testLocalTwoStepQueryOnSegmentedCachesWithReplicatedAndLocalFlag
- 0,0% fails in last 406 master runs.
* IgniteBinaryCacheQueryTestSuite:
IgniteCachelessQueriesSelfTest.testLocalQueryOnPartitionedAndReplicatedCacheWithLocalFlag
- 0,0% fails in last 406 master runs.
* IgniteBinaryCacheQueryTestSuite:
IgniteCachelessQueriesSelfTest.testDistributedQueryOnPartitionedCachesWithReplicatedFlag
- 0,0% fails in last 406 master runs.
* IgniteBinaryCacheQueryTestSuite:
IgniteCachelessQueriesSelfTest.testDistributedQueryOnSegmentedCaches - 0,0%
fails in last 406 master runs.
* IgniteBinaryCacheQueryTestSuite:
IgniteCachelessQueriesSelfTest.testLocalQueryOnPartitionedCachesWithReplicatedAndLocalFlag
- 0,0% fails in last 406 master runs.
* IgniteBinaryCacheQueryTestSuite:
IgniteCachelessQueriesSelfTest.testDistributedQueryOnPartitionedAndReplicatedCacheWithReplicatedFlag
- 0,0% fails in last 406 master runs.
* IgniteBinaryCacheQueryTestSuite:
IgniteCachelessQueriesSelfTest.testLocalQueryOnPartitionedCachesWithLocalFlag -
0,0% fails in last 406 master runs.
* IgniteBinaryCacheQueryTestSuite:
IgniteCachelessQueriesSelfTest.testLocalQueryOnReplicatedCachesWithReplicatedAndLocalFlag
- 0,0% fails in last 406 master runs.
* IgniteBinaryCacheQueryTestSuite:
IgniteCachelessQueriesSelfTest.testLocalTwoStepQueryOnReplicatedAndSegmentedCacheWithReplicatedAndLocalFlag
- 0,0% fails in last 406 master runs.
* IgniteBinaryCacheQueryTestSuite:
GridCacheCrossCacheQuerySelfTest.testMultiStatement - 0,0% fails in last 406
master runs.
* IgniteBinaryCacheQueryTestSuite:
IgniteCachelessQueriesSelfTest.testLocalQueryOnPartitionedAndReplicatedCacheWithReplicatedAndLocalFlag
- 0,0% fails in last 406 master runs.
* IgniteBinaryCacheQueryTestSuite:
IgniteCachelessQueriesSelfTest.testLocalQueryOnReplicatedCachesWithReplicatedFlag
- 0,0% fails in last 406 master runs.
{color:#d04437}Cache 7{color} [[tests
1|https://ci.ignite.apache.org/viewLog.html?buildId=3048048]]
* IgniteCacheTestSuite7:
TxRollbackAsyncWithPersistenceTest.testSynchronousRollback - 0,0% fails in last
403 master runs.
{color:#d04437}JDBC Driver{color} [[tests
2|https://ci.ignite.apache.org/viewLog.html?buildId=3048001]]
* IgniteJdbcDriverTestSuite:
JdbcThinStatementSelfTest.testExecuteUpdateProducesResultSet - 0,0% fails in
last 411 master runs.
* IgniteJdbcDriverTestSuite:
JdbcThinLocalQueriesSelfTest.testLocalThinJdbcQuery - 0,0% fails in last 411
master runs.
{color:#d04437}MVCC PDS 2{color} [[tests
3|https://ci.ignite.apache.org/viewLog.html?buildId=3048090]]
* IgnitePdsMvccTestSuite2:
IgniteWalReaderTest.testArchiveIncompleteSegmentAfterInactivity - 0,0% fails in
last 416 master runs.
* IgnitePdsMvccTestSuite2:
LocalWalModeChangeDuringRebalancingSelfTest.testWalNotDisabledIfParameterSetToFalse
- 0,0% fails in last 150 master runs.
{color:#d04437}MVCC Cache{color} [[tests
1|http
[jira] [Created] (IGNITE-11280) SQL: Cache all queries, not only two-step
Vladimir Ozerov created IGNITE-11280: Summary: SQL: Cache all queries, not only two-step Key: IGNITE-11280 URL: https://issues.apache.org/jira/browse/IGNITE-11280 Project: Ignite Issue Type: Task Components: sql Reporter: Vladimir Ozerov Fix For: 2.8 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11278) SQL: Extract query parsing into separate class
[ https://issues.apache.org/jira/browse/IGNITE-11278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764247#comment-16764247 ] Vladimir Ozerov commented on IGNITE-11278: -- Implemented. Test run: https://ci.ignite.apache.org/viewQueued.html?itemId=3048094 > SQL: Extract query parsing into separate class > -- > > Key: IGNITE-11278 > URL: https://issues.apache.org/jira/browse/IGNITE-11278 > Project: Ignite > Issue Type: Task > Components: sql >Reporter: Vladimir Ozerov >Assignee: Vladimir Ozerov >Priority: Major > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > # Introduce separate command types for SELECT, DML and others commands > # Move parsing logic and query cache to separate class > # Fix bug with query parallelism when "distributedQueries" flag is modified > not for newly created query, but globally. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (IGNITE-11279) SQL: Remove H2's "prepared" from DML plans
Vladimir Ozerov created IGNITE-11279:
Summary: SQL: Remove H2's "prepared" from DML plans
Key: IGNITE-11279
URL: https://issues.apache.org/jira/browse/IGNITE-11279
Project: Ignite
Issue Type: Task
Components: sql
Reporter: Vladimir Ozerov
Fix For: 2.8
Currently it is only used to get the list of participating tables. Instead, we
should encapsulate this information into {{ParsingResultDml}}. Streamer methods
should use our own parser as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (IGNITE-11278) SQL: Extract query parsing into separate class
[ https://issues.apache.org/jira/browse/IGNITE-11278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Ozerov updated IGNITE-11278: - Ignite Flags: (was: Docs Required) > SQL: Extract query parsing into separate class > -- > > Key: IGNITE-11278 > URL: https://issues.apache.org/jira/browse/IGNITE-11278 > Project: Ignite > Issue Type: Task > Components: sql >Reporter: Vladimir Ozerov >Assignee: Vladimir Ozerov >Priority: Major > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > # Introduce separate command types for SELECT, DML and others commands > # Move parsing logic and query cache to separate class > # Fix bug with query parallelism when "distributedQueries" flag is modified > not for newly created query, but globally. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (IGNITE-11278) SQL: Extract query parsing into separate class
Vladimir Ozerov created IGNITE-11278: Summary: SQL: Extract query parsing into separate class Key: IGNITE-11278 URL: https://issues.apache.org/jira/browse/IGNITE-11278 Project: Ignite Issue Type: Task Components: sql Reporter: Vladimir Ozerov Assignee: Vladimir Ozerov Fix For: 2.8 # Introduce separate command types for SELECT, DML and others commands # Move parsing logic and query cache to separate class # Fix bug with query parallelism when "distributedQueries" flag is modified not for newly created query, but globally. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (IGNITE-11276) Cache (Restarts) 1 flaky tests NPE at GridDhtPartitionsExchangeFuture.topologyVersion
[ https://issues.apache.org/jira/browse/IGNITE-11276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stepachev Maksim reassigned IGNITE-11276: - Assignee: Alexey Goncharuk (was: Stepachev Maksim) > Cache (Restarts) 1 flaky tests NPE at > GridDhtPartitionsExchangeFuture.topologyVersion > - > > Key: IGNITE-11276 > URL: https://issues.apache.org/jira/browse/IGNITE-11276 > Project: Ignite > Issue Type: Bug >Reporter: Stepachev Maksim >Assignee: Alexey Goncharuk >Priority: Critical > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > Sometimes the Cache (Restarts) 1 suit finish with fail. The reason is NPE > into at > org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture.topologyVersion(GridDhtPartitionsExchangeFuture.java:515) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (IGNITE-11276) Cache (Restarts) 1 flaky tests NPE at GridDhtPartitionsExchangeFuture.topologyVersion
[ https://issues.apache.org/jira/browse/IGNITE-11276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stepachev Maksim reassigned IGNITE-11276: - Assignee: Stepachev Maksim (was: Alexey Goncharuk) > Cache (Restarts) 1 flaky tests NPE at > GridDhtPartitionsExchangeFuture.topologyVersion > - > > Key: IGNITE-11276 > URL: https://issues.apache.org/jira/browse/IGNITE-11276 > Project: Ignite > Issue Type: Bug >Reporter: Stepachev Maksim >Assignee: Stepachev Maksim >Priority: Critical > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > Sometimes the Cache (Restarts) 1 suit finish with fail. The reason is NPE > into at > org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture.topologyVersion(GridDhtPartitionsExchangeFuture.java:515) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (IGNITE-11276) Cache (Restarts) 1 flaky tests NPE at GridDhtPartitionsExchangeFuture.topologyVersion
[ https://issues.apache.org/jira/browse/IGNITE-11276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stepachev Maksim reassigned IGNITE-11276: - Assignee: Alexey Goncharuk (was: Stepachev Maksim) > Cache (Restarts) 1 flaky tests NPE at > GridDhtPartitionsExchangeFuture.topologyVersion > - > > Key: IGNITE-11276 > URL: https://issues.apache.org/jira/browse/IGNITE-11276 > Project: Ignite > Issue Type: Bug >Reporter: Stepachev Maksim >Assignee: Alexey Goncharuk >Priority: Critical > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > Sometimes the Cache (Restarts) 1 suit finish with fail. The reason is NPE > into at > org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture.topologyVersion(GridDhtPartitionsExchangeFuture.java:515) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11276) Cache (Restarts) 1 flaky tests NPE at GridDhtPartitionsExchangeFuture.topologyVersion
[
https://issues.apache.org/jira/browse/IGNITE-11276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764207#comment-16764207
]
Ignite TC Bot commented on IGNITE-11276:
{panel:title=--> Run :: All: No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=3045062&buildTypeId=IgniteTests24Java8_RunAll]
> Cache (Restarts) 1 flaky tests NPE at
> GridDhtPartitionsExchangeFuture.topologyVersion
> -
>
> Key: IGNITE-11276
> URL: https://issues.apache.org/jira/browse/IGNITE-11276
> Project: Ignite
> Issue Type: Bug
>Reporter: Stepachev Maksim
>Assignee: Stepachev Maksim
>Priority: Critical
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Sometimes the Cache (Restarts) 1 suit finish with fail. The reason is NPE
> into at
> org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture.topologyVersion(GridDhtPartitionsExchangeFuture.java:515)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (IGNITE-11277) Use maven plugin as default code style checker for project
[
https://issues.apache.org/jira/browse/IGNITE-11277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated IGNITE-11277:
-
Labels: inspections (was: )
> Use maven plugin as default code style checker for project
> --
>
> Key: IGNITE-11277
> URL: https://issues.apache.org/jira/browse/IGNITE-11277
> Project: Ignite
> Issue Type: Task
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Major
> Labels: inspections
> Fix For: 2.8
>
>
> Currently, {{[Inspections] Core suite}} [1] on TC doesn't work well enough.
> The suite has a {{FAILED}} status for more than 2 months due to some issues
> on TeamCity application [2]. It confuses most of the members of the Apache
> Ignite community.
> Moreover, this suite is no longer checks configured rules. For instance, in
> the master branch, 11 {{Unused imports}} can be found (e.g. for
> {{IgniteCachePutAllRestartTest}
> [3]).
> I think the maven-checkstyle-plugin should be used as the default code style
> checker.
> _Advantages:_
> * An IDE agnostic way for code checks
> * Can be used with different CI and build tools
> * Executable from the command line
> * Single configuration
> [1]
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_InspectionsCore&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv
> [2] https://youtrack.jetbrains.com/issue/TW-58504
> [3]
> https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCachePutAllRestartTest.java#L29
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (IGNITE-11277) Use maven plugin as default code style checker for project
Maxim Muzafarov created IGNITE-11277:
Summary: Use maven plugin as default code style checker for project
Key: IGNITE-11277
URL: https://issues.apache.org/jira/browse/IGNITE-11277
Project: Ignite
Issue Type: Task
Reporter: Maxim Muzafarov
Assignee: Maxim Muzafarov
Fix For: 2.8
Currently, {{[Inspections] Core suite}} [1] on TC doesn't work well enough. The
suite has a {{FAILED}} status for more than 2 months due to some issues on
TeamCity application [2]. It confuses most of the members of the Apache Ignite
community.
Moreover, this suite is no longer checks configured rules. For instance, in the
master branch, 11 {{Unused imports}} can be found (e.g. for
{{IgniteCachePutAllRestartTest}
[3]).
I think the maven-checkstyle-plugin should be used as the default code style
checker.
_Advantages:_
* An IDE agnostic way for code checks
* Can be used with different CI and build tools
* Executable from the command line
* Single configuration
[1]
https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_InspectionsCore&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv
[2] https://youtrack.jetbrains.com/issue/TW-58504
[3]
https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCachePutAllRestartTest.java#L29
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (IGNITE-11277) Use maven plugin as default code style checker for project
[
https://issues.apache.org/jira/browse/IGNITE-11277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated IGNITE-11277:
-
Ignite Flags: (was: Docs Required)
> Use maven plugin as default code style checker for project
> --
>
> Key: IGNITE-11277
> URL: https://issues.apache.org/jira/browse/IGNITE-11277
> Project: Ignite
> Issue Type: Task
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Major
> Fix For: 2.8
>
>
> Currently, {{[Inspections] Core suite}} [1] on TC doesn't work well enough.
> The suite has a {{FAILED}} status for more than 2 months due to some issues
> on TeamCity application [2]. It confuses most of the members of the Apache
> Ignite community.
> Moreover, this suite is no longer checks configured rules. For instance, in
> the master branch, 11 {{Unused imports}} can be found (e.g. for
> {{IgniteCachePutAllRestartTest}
> [3]).
> I think the maven-checkstyle-plugin should be used as the default code style
> checker.
> _Advantages:_
> * An IDE agnostic way for code checks
> * Can be used with different CI and build tools
> * Executable from the command line
> * Single configuration
> [1]
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_InspectionsCore&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv
> [2] https://youtrack.jetbrains.com/issue/TW-58504
> [3]
> https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCachePutAllRestartTest.java#L29
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11275) SQL: Move all command processing stuff to DDL processor
[
https://issues.apache.org/jira/browse/IGNITE-11275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764159#comment-16764159
]
Ignite TC Bot commented on IGNITE-11275:
{panel:title=--> Run :: All: Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Queries 1{color} [[tests
2|https://ci.ignite.apache.org/viewLog.html?buildId=3044660]]
* IgniteBinaryCacheQueryTestSuite:
IgniteCheckClusterStateBeforeExecuteQueryTest.testDynamicSchemaChangesPersistence
- 0,0% fails in last 402 master runs.
{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=3044684&buildTypeId=IgniteTests24Java8_RunAll]
> SQL: Move all command processing stuff to DDL processor
> ---
>
> Key: IGNITE-11275
> URL: https://issues.apache.org/jira/browse/IGNITE-11275
> Project: Ignite
> Issue Type: Task
> Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Vladimir Ozerov
>Priority: Major
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If command is of non-SELECT/non-DML type, it should be encapsulated inside
> {{ParsingResult}} as a pair of native/H2 commands and passed to separate
> processor. This will reduce complexity of {{IgniteH2Indexing}} significantly,
> as it will be concerned only about SELECT/DML processing and nothing else.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8550) CacheAbstractJdbcStore expects merge to always return 1 but MySQL may also return 2 or 0
[
https://issues.apache.org/jira/browse/IGNITE-8550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764141#comment-16764141
]
Stanislav Lukyanov commented on IGNITE-8550:
[~smoldachev] I'm OK with this style of the change, but we need to allow 0, 1
and 2, and not allow other values, so the check would be
{code}
if (updCnt < 0 || updCnt > 2)
U.warn(log, "Unexpected return value for update opetation [table=" +
em.fullTableName() + ", entry=" + entry + ", updCnt=" + updCnt + "]");
{code}
And I would even like a little hack with checking the dialect here. It's smelly
but it's simple.
{code}
if (dialect instanceof MySQLDialect) {
if (updCnt < 0 || updCnt > 2)
U.warn(log, "Unexpected return value for update opetation [table=" +
em.fullTableName() + ", entry=" + entry + ", updCnt=" + updCnt + "]");
} else {
if (updCnt != 1)
U.warn(log, "Unexpected return value for update opetation [table=" +
em.fullTableName() + ", entry=" + entry + ", updCnt=" + updCnt + "]");
}
{code}
Also we need a proper comment with a link to this issue that explains why the
code is like his.
> CacheAbstractJdbcStore expects merge to always return 1 but MySQL may also
> return 2 or 0
>
>
> Key: IGNITE-8550
> URL: https://issues.apache.org/jira/browse/IGNITE-8550
> Project: Ignite
> Issue Type: Bug
> Components: cache
>Reporter: Stanislav Lukyanov
>Assignee: Moldachev Sergey
>Priority: Minor
> Labels: newbie
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> CacheAbstractJdbcStore.write attempts to execute a merge update if it is
> available, and expects the merge to always return 1 (as the number of updated
> entries is always 1).
> However, MySQL's `INSERT ... ON DUPLICATE KEY UPDATE`
> (https://dev.mysql.com/doc/refman/8.0/en/insert-on-duplicate.html) may return
> 0 or 2, depending on what was updated:
> {quote}With ON DUPLICATE KEY UPDATE, the affected-rows value per row is 1 if
> the row is inserted as a new row, 2 if an existing row is updated, and 0 if
> an existing row is set to its current values.{quote}
> Because of that, CacheAbstractJdbcStore may report a false warning.
> Need to consider either removing the warning or special-case the MySQL
> dialect to allow to return values other than 1.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11149) Update default value for IGNITE_DISABLE_WAL_DURING_REBALANCING in javadoc
[ https://issues.apache.org/jira/browse/IGNITE-11149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764132#comment-16764132 ] Andrey Kalinin commented on IGNITE-11149: - [~antonovsergey93] please, review again. > Update default value for IGNITE_DISABLE_WAL_DURING_REBALANCING in javadoc > - > > Key: IGNITE-11149 > URL: https://issues.apache.org/jira/browse/IGNITE-11149 > Project: Ignite > Issue Type: Bug > Components: documentation >Reporter: Sergey Antonov >Assignee: Andrey Kalinin >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > After IGNITE-10505 default value of IGNITE_DISABLE_WAL_DURING_REBALANCING was > changed from false to true. But javadoc wasn't updated. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (IGNITE-10695) MVCC: Fix cache API conditional update operations.
[ https://issues.apache.org/jira/browse/IGNITE-10695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Mashenkov reassigned IGNITE-10695: - Assignee: (was: Andrew Mashenkov) > MVCC: Fix cache API conditional update operations. > -- > > Key: IGNITE-10695 > URL: https://issues.apache.org/jira/browse/IGNITE-10695 > Project: Ignite > Issue Type: Improvement > Components: mvcc >Affects Versions: 2.7 >Reporter: Andrew Mashenkov >Priority: Minor > > Operation like putIfAbsent and replace now tries to transfer Predicate > instance (filter) to remote node. > # Predicates are transferred to remote node with each update. > # Predicate should be transferred only for "replace" operation if certain > entry provided, otherwise we should send a correct operation code and use > corresponding static filter on remote side. > # This change will break protocol compatibility. Should we bother about it? > Let's fix protocol and add tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (IGNITE-7164) SQL TX: Remap protocol
[ https://issues.apache.org/jira/browse/IGNITE-7164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Mashenkov reassigned IGNITE-7164: Assignee: (was: Andrew Mashenkov) > SQL TX: Remap protocol > -- > > Key: IGNITE-7164 > URL: https://issues.apache.org/jira/browse/IGNITE-7164 > Project: Ignite > Issue Type: Task > Components: mvcc, sql >Reporter: Igor Seliverstov >Priority: Minor > Fix For: 2.8 > > > We need to provide remap protocol on topology changes -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (IGNITE-11276) Cache (Restarts) 1 flaky tests NPE at GridDhtPartitionsExchangeFuture.topologyVersion
Stepachev Maksim created IGNITE-11276: - Summary: Cache (Restarts) 1 flaky tests NPE at GridDhtPartitionsExchangeFuture.topologyVersion Key: IGNITE-11276 URL: https://issues.apache.org/jira/browse/IGNITE-11276 Project: Ignite Issue Type: Bug Reporter: Stepachev Maksim Assignee: Stepachev Maksim Fix For: 2.8 Sometimes the Cache (Restarts) 1 suit finish with fail. The reason is NPE into at org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture.topologyVersion(GridDhtPartitionsExchangeFuture.java:515) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11275) SQL: Move all command processing stuff to DDL processor
[
https://issues.apache.org/jira/browse/IGNITE-11275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764106#comment-16764106
]
Vladimir Ozerov commented on IGNITE-11275:
--
Done. Test run: https://ci.ignite.apache.org/viewQueued.html?itemId=3044684
> SQL: Move all command processing stuff to DDL processor
> ---
>
> Key: IGNITE-11275
> URL: https://issues.apache.org/jira/browse/IGNITE-11275
> Project: Ignite
> Issue Type: Task
> Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Vladimir Ozerov
>Priority: Major
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If command is of non-SELECT/non-DML type, it should be encapsulated inside
> {{ParsingResult}} as a pair of native/H2 commands and passed to separate
> processor. This will reduce complexity of {{IgniteH2Indexing}} significantly,
> as it will be concerned only about SELECT/DML processing and nothing else.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (IGNITE-11275) SQL: Move all command processing stuff to DDL processor
[
https://issues.apache.org/jira/browse/IGNITE-11275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Ozerov updated IGNITE-11275:
-
Ignite Flags: (was: Docs Required)
> SQL: Move all command processing stuff to DDL processor
> ---
>
> Key: IGNITE-11275
> URL: https://issues.apache.org/jira/browse/IGNITE-11275
> Project: Ignite
> Issue Type: Task
> Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Vladimir Ozerov
>Priority: Major
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If command is of non-SELECT/non-DML type, it should be encapsulated inside
> {{ParsingResult}} as a pair of native/H2 commands and passed to separate
> processor. This will reduce complexity of {{IgniteH2Indexing}} significantly,
> as it will be concerned only about SELECT/DML processing and nothing else.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (IGNITE-11274) SQL: Make GridCacheSqlQuery immutable
Vladimir Ozerov created IGNITE-11274:
Summary: SQL: Make GridCacheSqlQuery immutable
Key: IGNITE-11274
URL: https://issues.apache.org/jira/browse/IGNITE-11274
Project: Ignite
Issue Type: Task
Components: sql
Reporter: Vladimir Ozerov
Assignee: Vladimir Ozerov
The goal of this ticket is to finally make two-step plan fully immutable. First
steps we already made in IGNITE-11223, howevere plan's "query" objects are
still mutable, what make's plan caching inherently unsafe.
# Remove all setters from the message except of {{nodeId}}, which is really
needed
# Make splitter use another trully immutable object instead of
{{GridCacheSqlQuery}}
# Copy splitter's object to {{GridCacheSqlQuery}} during reduce
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (IGNITE-11223) SQL: Make two-step plan immutable
[ https://issues.apache.org/jira/browse/IGNITE-11223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Ozerov updated IGNITE-11223: - Summary: SQL: Make two-step plan immutable (was: SQL: Merge "collectCacheIds" and "processCaches" methods) > SQL: Make two-step plan immutable > - > > Key: IGNITE-11223 > URL: https://issues.apache.org/jira/browse/IGNITE-11223 > Project: Ignite > Issue Type: Task > Components: sql >Reporter: Vladimir Ozerov >Assignee: Vladimir Ozerov >Priority: Major > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > Both methods are essentially two pieces of the same process - collect cache > IDs for the given query, check MVCC mode. But because they are separated, we > have unnecessary collection copies, "isEmpty" checks and iterations. > Provided that these methods are on a hot path, let's merge them accurately. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (IGNITE-11275) SQL: Move all command processing stuff to DDL processor
Vladimir Ozerov created IGNITE-11275:
Summary: SQL: Move all command processing stuff to DDL processor
Key: IGNITE-11275
URL: https://issues.apache.org/jira/browse/IGNITE-11275
Project: Ignite
Issue Type: Task
Components: sql
Reporter: Vladimir Ozerov
Assignee: Vladimir Ozerov
Fix For: 2.8
If command is of non-SELECT/non-DML type, it should be encapsulated inside
{{ParsingResult}} as a pair of native/H2 commands and passed to separate
processor. This will reduce complexity of {{IgniteH2Indexing}} significantly,
as it will be concerned only about SELECT/DML processing and nothing else.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11223) SQL: Merge "collectCacheIds" and "processCaches" methods
[ https://issues.apache.org/jira/browse/IGNITE-11223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764096#comment-16764096 ] Vladimir Ozerov commented on IGNITE-11223: -- Failures are unrelated (confirmed by local runs). Probably these tests are flaky. > SQL: Merge "collectCacheIds" and "processCaches" methods > > > Key: IGNITE-11223 > URL: https://issues.apache.org/jira/browse/IGNITE-11223 > Project: Ignite > Issue Type: Task > Components: sql >Reporter: Vladimir Ozerov >Assignee: Vladimir Ozerov >Priority: Major > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > Both methods are essentially two pieces of the same process - collect cache > IDs for the given query, check MVCC mode. But because they are separated, we > have unnecessary collection copies, "isEmpty" checks and iterations. > Provided that these methods are on a hot path, let's merge them accurately. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (IGNITE-11223) SQL: Make two-step plan immutable
[ https://issues.apache.org/jira/browse/IGNITE-11223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Ozerov updated IGNITE-11223: - Description: It should not mutate between calls. This way we will remove necessity to re-put plans to plan cache on every request. (was: Both methods are essentially two pieces of the same process - collect cache IDs for the given query, check MVCC mode. But because they are separated, we have unnecessary collection copies, "isEmpty" checks and iterations. Provided that these methods are on a hot path, let's merge them accurately.) > SQL: Make two-step plan immutable > - > > Key: IGNITE-11223 > URL: https://issues.apache.org/jira/browse/IGNITE-11223 > Project: Ignite > Issue Type: Task > Components: sql >Reporter: Vladimir Ozerov >Assignee: Vladimir Ozerov >Priority: Major > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > It should not mutate between calls. This way we will remove necessity to > re-put plans to plan cache on every request. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11223) SQL: Merge "collectCacheIds" and "processCaches" methods
[
https://issues.apache.org/jira/browse/IGNITE-11223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764095#comment-16764095
]
Ignite TC Bot commented on IGNITE-11223:
{panel:title=--> Run :: All: Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}JDBC Driver{color} [[tests
1|https://ci.ignite.apache.org/viewLog.html?buildId=3041023]]
* IgniteJdbcDriverTestSuite:
JdbcThinStatementCancelSelfTest.testCloseCancelingQuery - 0,0% fails in last
406 master runs.
{color:#d04437}Cache 3{color} [[tests
2|https://ci.ignite.apache.org/viewLog.html?buildId=3041066]]
* IgniteBinaryObjectsCacheTestSuite3:
IgniteCacheGroupsTest.testCreateDestroyCachesMvccTxPartitioned - 0,0% fails in
last 250 master runs.
{color:#d04437}Thin client: PHP{color} [[tests 0 Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=3041050]]
{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=3041116&buildTypeId=IgniteTests24Java8_RunAll]
> SQL: Merge "collectCacheIds" and "processCaches" methods
>
>
> Key: IGNITE-11223
> URL: https://issues.apache.org/jira/browse/IGNITE-11223
> Project: Ignite
> Issue Type: Task
> Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Vladimir Ozerov
>Priority: Major
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Both methods are essentially two pieces of the same process - collect cache
> IDs for the given query, check MVCC mode. But because they are separated, we
> have unnecessary collection copies, "isEmpty" checks and iterations.
> Provided that these methods are on a hot path, let's merge them accurately.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
