[jira] [Commented] (IGNITE-8473) Add option to enable/disable WAL for several caches with single command
[
https://issues.apache.org/jira/browse/IGNITE-8473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950196#comment-16950196
]
Sergei Ryzhov commented on IGNITE-8473:
---
This change is ready. [~qvad], could you please review?
> Add option to enable/disable WAL for several caches with single command
> ---
>
> Key: IGNITE-8473
> URL: https://issues.apache.org/jira/browse/IGNITE-8473
> Project: Ignite
> Issue Type: Improvement
>Reporter: Ivan Rakov
>Assignee: Sergei Ryzhov
>Priority: Major
> Labels: newbie
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> API method for disabling WAL in IgniteCluster accepts only one cache name.
> Every call triggers exchange and checkpoints cluster-wide - it takes plenty
> of time to disable/enable WAL for multiple caches.
> We should add option to disable/enable WAL for several caches with single
> command.
> New proposed API methods:
> {noformat}
> IgniteCluster.disableWal(Collection cacheNames)
> IgniteCluster.enableWal(Collection cacheNames)
> IgniteCluster.disableWal() // Disables WAL for all caches.
> IgniteCluster.enableWal() // Enables WAL for all caches.
> {noformat}
> Methods should return true if WAL state of at least one cache was actually
> changed by the call.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-8473) Add option to enable/disable WAL for several caches with single command
[
https://issues.apache.org/jira/browse/IGNITE-8473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950193#comment-16950193
]
Ignite TC Bot commented on IGNITE-8473:
---
{panel:title=Branch: [pull/6971/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4691610&buildTypeId=IgniteTests24Java8_RunAll]
> Add option to enable/disable WAL for several caches with single command
> ---
>
> Key: IGNITE-8473
> URL: https://issues.apache.org/jira/browse/IGNITE-8473
> Project: Ignite
> Issue Type: Improvement
>Reporter: Ivan Rakov
>Assignee: Sergei Ryzhov
>Priority: Major
> Labels: newbie
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> API method for disabling WAL in IgniteCluster accepts only one cache name.
> Every call triggers exchange and checkpoints cluster-wide - it takes plenty
> of time to disable/enable WAL for multiple caches.
> We should add option to disable/enable WAL for several caches with single
> command.
> New proposed API methods:
> {noformat}
> IgniteCluster.disableWal(Collection cacheNames)
> IgniteCluster.enableWal(Collection cacheNames)
> IgniteCluster.disableWal() // Disables WAL for all caches.
> IgniteCluster.enableWal() // Enables WAL for all caches.
> {noformat}
> Methods should return true if WAL state of at least one cache was actually
> changed by the call.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-9165) FindBugs: Methods may fail to close stream in core module
[
https://issues.apache.org/jira/browse/IGNITE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950142#comment-16950142
]
Ignite TC Bot commented on IGNITE-9165:
---
{panel:title=Branch: [pull/4481/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4688935&buildTypeId=IgniteTests24Java8_RunAll]
> FindBugs: Methods may fail to close stream in core module
> -
>
> Key: IGNITE-9165
> URL: https://issues.apache.org/jira/browse/IGNITE-9165
> Project: Ignite
> Issue Type: Bug
> Components: binary
>Affects Versions: 2.6
>Reporter: Nikolai Kulagin
>Assignee: Nikolai Kulagin
>Priority: Minor
> Labels: newbie
> Fix For: 2.9
>
> Attachments:
> findbugs-result-apache-ignite[ignite-core]_2018_08_02_12_38_02.html
>
>
> The method creates an IO stream object, does not assign it to any fields,
> pass it to other methods that might close it, or return it, and does not
> appear to close the stream on all paths out of the method. This may result
> in a file descriptor leak.
> Example:
>
> {code:java}
> // GridCacheAbstractLoadTest#GridCacheAbstractLoadTest()
> try {
> props.load(new FileReader(GridTestUtils.resolveIgnitePath(
> "modules/tests/config/cache-load.properties")));
> }
> catch (IOException e) {
> throw new RuntimeException(e);
> }{code}
>
> One of possible solutions:
> {code:java}
> try (Reader reader = new FileReader(GridTestUtils.resolveIgnitePath(
> "modules/tests/config/cache-load.properties"))) {
> props.load(reader);
> }
> catch (IOException e) {
> throw new RuntimeException(e);
> }{code}
> List of classes in "core" module:
>
> +org.apache.ignite.internal:+
> * *BinaryContext*#classesInPackage(String)
> * *GridClientJdkMarshaller*#marshal(Object, int)
> *
> *IgniteExplicitImplicitDeploymentSelfTest*$GridDeploymentResourceTestJob#execute()
> * *OptimizedObjectStreamSelfTest*#testReadLine()
> * *PageIdDistributionTest*#_testRealHistory()
> * *HttpIgniteUpdatesChecker*#getUpdates(boolean)
> * *IpcSharedMemoryNativeLoaderSelfTest*#readStreams(Process)
> +org.apache.ignite:+
> * *GridCacheAbstractLoadTest*#GridCacheAbstractLoadTest()
> * *GridTestUtils*.sslContext()
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-9160) FindBugs: NPE and CCE on equals() methods
[
https://issues.apache.org/jira/browse/IGNITE-9160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950102#comment-16950102
]
Ignite TC Bot commented on IGNITE-9160:
---
{panel:title=Branch: [pull/6967/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4687940&buildTypeId=IgniteTests24Java8_RunAll]
> FindBugs: NPE and CCE on equals() methods
> -
>
> Key: IGNITE-9160
> URL: https://issues.apache.org/jira/browse/IGNITE-9160
> Project: Ignite
> Issue Type: Bug
> Components: cache
>Affects Versions: 2.6
>Reporter: Nikolai Kulagin
>Assignee: Nikolai Kulagin
>Priority: Minor
> Labels: newbie
> Fix For: 2.9
>
> Attachments: check.txt, reproduce.txt
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Some classes have Incorrect equals() method:
> {code:java}
> // GridDhtPartitionMap.java
> @Override public boolean equals(Object o) {
> if (this == o)
> return true;
> GridDhtPartitionMap other = (GridDhtPartitionMap)o;
> return other.nodeId.equals(nodeId) && other.updateSeq == updateSeq;
> }{code}
> In this case, we can get CCE
> {code:java}
> GridDhtPartitionMap gridDhtPartMap = new GridDhtPartitionMap();
> gridDhtPartMap.equals(new Object());
> --
> Exception in thread "main" java.lang.ClassCastException: java.lang.Object
> cannot be cast to
> org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionMap
> at
> org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionMap.equals(GridDhtPartitionMap.java:319)
> at ru.zzzadruga.Ignite.main(Ignite.java:9){code}
> Or NPE
> {code:java}
> GridDhtPartitionMap gridDhtPartMap = new GridDhtPartitionMap();
> gridDhtPartMap.equals(null);
> --
> Exception in thread "main" java.lang.NullPointerException
> at
> org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionMap.equals(GridDhtPartitionMap.java:321)
> at ru.zzzadruga.Ignite.main(Ignite.java:9){code}
> The following code will prevent this
> {code:java}
> if (o == null || getClass() != o.getClass())
> return false;{code}
> + List of classes with similar problems: +
> * *GridTopic$T1-T8* - NPE
> * *GridCachePreloadLifecycleAbstractTest -* NPE
> * *GridDhtPartitionFullMap -* NPE and CCE
> * *GridDhtPartitionMap -* NPE and CCE
> * *OptimizedMarshallerSelfTest -* NPE and CCE
> * *GatewayProtectedCacheProxy -* NPE and CCE
> * *GridNearOptimisticTxPrepareFuture -* NPE and CCE
> * *GridCacheDistributedQueryManager -* NPE and CCE
> * *GridServiceMethodReflectKey -* NPE and CCE
> * *GridListSetSelfTest -* NPE and CCE
> * *GridTestKey -* NPE and CCE
> * *GridCacheMvccCandidate -* CCE
> * *GridDhtPartitionExchangeId -* CCE
> * *GridTuple6 -* CCE
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-11292) There is no way to disable WAL for cache in group
[
https://issues.apache.org/jira/browse/IGNITE-11292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950091#comment-16950091
]
Sergei Ryzhov commented on IGNITE-11292:
https://github.com/apache/ignite/pull/6971
> There is no way to disable WAL for cache in group
> -
>
> Key: IGNITE-11292
> URL: https://issues.apache.org/jira/browse/IGNITE-11292
> Project: Ignite
> Issue Type: Bug
>Reporter: Dmitry Sherstobitov
>Assignee: Sergei Ryzhov
>Priority: Critical
> Labels: newbie
>
> Following code doesn't work if cache is in a cacheGroup:
> {code:java}
> ignite.cluster().disableWal(cacheName){code}
> cacheName == cacheName:
> {code:java}
> Caused by: class org.apache.ignite.IgniteCheckedException: Cannot change WAL
> mode because not all cache names belonging to the group are provided
> [group=cache_group_1, missingCaches=[cache_group_1_005, cache_group_3_063,
> cache_group_1_003, cache_group_3_064, cache_group_1_004, cache_group_3_061,
> cache_group_3_062, cache_group_1_001, cache_group_1_002]]
> {code}
> cacheName == groupName:
> {code:java}
> Caused by: class org.apache.ignite.IgniteCheckedException: Cache doesn't
> exist: cache_group_1{code}
> Also there is no javadoc about this behaviour
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-8473) Add option to enable/disable WAL for several caches with single command
[
https://issues.apache.org/jira/browse/IGNITE-8473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950090#comment-16950090
]
Sergei Ryzhov commented on IGNITE-8473:
---
https://github.com/apache/ignite/pull/6971
> Add option to enable/disable WAL for several caches with single command
> ---
>
> Key: IGNITE-8473
> URL: https://issues.apache.org/jira/browse/IGNITE-8473
> Project: Ignite
> Issue Type: Improvement
>Reporter: Ivan Rakov
>Assignee: Sergei Ryzhov
>Priority: Major
> Labels: newbie
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> API method for disabling WAL in IgniteCluster accepts only one cache name.
> Every call triggers exchange and checkpoints cluster-wide - it takes plenty
> of time to disable/enable WAL for multiple caches.
> We should add option to disable/enable WAL for several caches with single
> command.
> New proposed API methods:
> {noformat}
> IgniteCluster.disableWal(Collection cacheNames)
> IgniteCluster.enableWal(Collection cacheNames)
> IgniteCluster.disableWal() // Disables WAL for all caches.
> IgniteCluster.enableWal() // Enables WAL for all caches.
> {noformat}
> Methods should return true if WAL state of at least one cache was actually
> changed by the call.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12285) Remove boilerplate code in test PluginProvider implementations.
[
https://issues.apache.org/jira/browse/IGNITE-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950067#comment-16950067
]
Ignite TC Bot commented on IGNITE-12285:
{panel:title=Branch: [pull/6969/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4691098&buildTypeId=IgniteTests24Java8_RunAll]
> Remove boilerplate code in test PluginProvider implementations.
> ---
>
> Key: IGNITE-12285
> URL: https://issues.apache.org/jira/browse/IGNITE-12285
> Project: Ignite
> Issue Type: Improvement
>Reporter: PetrovMikhail
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It's needed to remove boilerplate code in test PluginProvider implementations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (IGNITE-11923) [IEP-35] Migrate IgniteMXBean
[ https://issues.apache.org/jira/browse/IGNITE-11923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikolay Izhikov reassigned IGNITE-11923: Assignee: (was: Nikolay Izhikov) > [IEP-35] Migrate IgniteMXBean > - > > Key: IGNITE-11923 > URL: https://issues.apache.org/jira/browse/IGNITE-11923 > Project: Ignite > Issue Type: Improvement >Reporter: Nikolay Izhikov >Priority: Major > Labels: IEP-35, await > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > After merging of IGNITE-11848 we should migrate `IgniteMXBean` to the new > metric framework. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (IGNITE-11923) [IEP-35] Migrate IgniteMXBean
[ https://issues.apache.org/jira/browse/IGNITE-11923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikolay Izhikov reassigned IGNITE-11923: Assignee: Nikolay Izhikov > [IEP-35] Migrate IgniteMXBean > - > > Key: IGNITE-11923 > URL: https://issues.apache.org/jira/browse/IGNITE-11923 > Project: Ignite > Issue Type: Improvement >Reporter: Nikolay Izhikov >Assignee: Nikolay Izhikov >Priority: Major > Labels: IEP-35, await > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > After merging of IGNITE-11848 we should migrate `IgniteMXBean` to the new > metric framework. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12212) Nodes system view
[
https://issues.apache.org/jira/browse/IGNITE-12212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950064#comment-16950064
]
Ignite TC Bot commented on IGNITE-12212:
{panel:title=Branch: [pull/6927/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4691219&buildTypeId=IgniteTests24Java8_RunAll]
> Nodes system view
> -
>
> Key: IGNITE-12212
> URL: https://issues.apache.org/jira/browse/IGNITE-12212
> Project: Ignite
> Issue Type: Sub-task
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Major
> Labels: IEP-35, await
> Fix For: 2.8
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> IGNITE-12145 finished
> We should add nodes system views.
> System view should track current topology nodes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (IGNITE-9913) Prevent data updates blocking in case of backup BLT server node leave
[ https://issues.apache.org/jira/browse/IGNITE-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950019#comment-16950019 ] Alexei Scherbakov edited comment on IGNITE-9913 at 10/12/19 12:14 PM: -- [~avinogradov] I've reviewed changes. Seems it follows the architecture we discussed privately. I left comments in the PR. Besides what you definitely should add more tests. Important scenarious migh be: 1. Baseline node is left under tx load while rebalancing is in progress (rebalancing is due to other node joins). 2. Owners are left one by one under tx load until subset of partitions will have single owner. 3. Owners are left one by one under tx load until subset of partitions will have no owner. Validate partition loss. All tests should check partition integrity: see org.apache.ignite.testframework.junits.common.GridCommonAbstractTest#assertPartitionsSame Do you have plans to implement non-blocking mapping for transactions not affected by topology change by the same ticket ? Let me know if some personal discussion is required. was (Author: ascherbakov): [~avinogradov] I've reviewed changes. Seems it follows the architecture we discussed privately. I left comments in the PR. Besides what you definitely should add more tests. Important scenarious migh be: 1. Baseline node is left under tx load while rebalancing is in progress (rebalancing is due to other node joins). 2. Owners are left one by one under tx load until subset of partitions will have single owner. 3. Owners are left one by one under tx load until subset of partitions will have no owner. Validate partition loss. All tests should check partition integrity: see org.apache.ignite.testframework.junits.common.GridCommonAbstractTest#assertPartitionsSame Do you have plans to implement non-blocking mapping for transactions not affected by topology change by the same ticket ? > Prevent data updates blocking in case of backup BLT server node leave > - > > Key: IGNITE-9913 > URL: https://issues.apache.org/jira/browse/IGNITE-9913 > Project: Ignite > Issue Type: Improvement > Components: general >Reporter: Ivan Rakov >Assignee: Anton Vinogradov >Priority: Major > Fix For: 2.8 > > Attachments: 9913_yardstick.png, master_yardstick.png > > Time Spent: 6h 50m > Remaining Estimate: 0h > > Ignite cluster performs distributed partition map exchange when any server > node leaves or joins the topology. > Distributed PME blocks all updates and may take a long time. If all > partitions are assigned according to the baseline topology and server node > leaves, there's no actual need to perform distributed PME: every cluster node > is able to recalculate new affinity assigments and partition states locally. > If we'll implement such lightweight PME and handle mapping and lock requests > on new topology version correctly, updates won't be stopped (except updates > of partitions that lost their primary copy). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-9913) Prevent data updates blocking in case of backup BLT server node leave
[ https://issues.apache.org/jira/browse/IGNITE-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950019#comment-16950019 ] Alexei Scherbakov commented on IGNITE-9913: --- [~avinogradov] I've reviewed changes. Seems it follows the architecture we discussed privately. I left comments in the PR. Besides what you definitely should add more tests. Important scenarious migh be: 1. Baseline node is left under tx load while rebalancing is in progress (rebalancing is due to other node joins). 2. Owners are left one by one under tx load until subset of partitions will have single owner. 3. Owners are left one by one under tx load until subset of partitions will have no owner. Validate partition loss. All tests should check partition integrity: see org.apache.ignite.testframework.junits.common.GridCommonAbstractTest#assertPartitionsSame Do you have plans to implement non-blocking mapping for transactions not affected by topology change by the same ticket ? > Prevent data updates blocking in case of backup BLT server node leave > - > > Key: IGNITE-9913 > URL: https://issues.apache.org/jira/browse/IGNITE-9913 > Project: Ignite > Issue Type: Improvement > Components: general >Reporter: Ivan Rakov >Assignee: Anton Vinogradov >Priority: Major > Fix For: 2.8 > > Attachments: 9913_yardstick.png, master_yardstick.png > > Time Spent: 6h 50m > Remaining Estimate: 0h > > Ignite cluster performs distributed partition map exchange when any server > node leaves or joins the topology. > Distributed PME blocks all updates and may take a long time. If all > partitions are assigned according to the baseline topology and server node > leaves, there's no actual need to perform distributed PME: every cluster node > is able to recalculate new affinity assigments and partition states locally. > If we'll implement such lightweight PME and handle mapping and lock requests > on new topology version correctly, updates won't be stopped (except updates > of partitions that lost their primary copy). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (IGNITE-12285) Remove boilerplate code in test PluginProvider implementations.
PetrovMikhail created IGNITE-12285: -- Summary: Remove boilerplate code in test PluginProvider implementations. Key: IGNITE-12285 URL: https://issues.apache.org/jira/browse/IGNITE-12285 Project: Ignite Issue Type: Improvement Reporter: PetrovMikhail It's needed to remove boilerplate code in test PluginProvider implementations. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12252) Unchecked exceptions during rebalancing should be handled
[
https://issues.apache.org/jira/browse/IGNITE-12252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949971#comment-16949971
]
Ignite TC Bot commented on IGNITE-12252:
{panel:title=Branch: [pull/6965/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4686231&buildTypeId=IgniteTests24Java8_RunAll]
> Unchecked exceptions during rebalancing should be handled
> -
>
> Key: IGNITE-12252
> URL: https://issues.apache.org/jira/browse/IGNITE-12252
> Project: Ignite
> Issue Type: Bug
>Reporter: Aleksey Plekhanov
>Assignee: Nikolai Kulagin
>Priority: Critical
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Rebalancing should handle unchecked exceptions by failure handler. In current
> implementation unchecked exceptions just ignored. They were handled by IO
> worker before IGNITE-3195.
> Reproducer:
> {code:java}
> @Test
> public void testRebalanceUncheckedError() throws Exception {
> IgniteEx ignite0 = startGrid(new
> IgniteConfiguration().setIgniteInstanceName("ignite0"));
> IgniteCache cache =
> ignite0.getOrCreateCache(DEFAULT_CACHE_NAME);
> IgniteDataStreamer streamer =
> ignite0.dataStreamer(DEFAULT_CACHE_NAME);
> for (int i = 0; i < 100_000; i++)
> streamer.addData(i, i);
> streamer.flush();
> IgniteEx ignite1 = startGrid(new
> IgniteConfiguration().setIgniteInstanceName("ignite1")
>
> .setIncludeEventTypes(EventType.EVT_CACHE_REBALANCE_OBJECT_LOADED));
> ignite1.events().localListen(e -> {
> throw new Error();
> }, EventType.EVT_CACHE_REBALANCE_OBJECT_LOADED);
> awaitPartitionMapExchange();
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
