[jira] [Commented] (IGNITE-14593) Calcite. Support not equal expression.
[ https://issues.apache.org/jira/browse/IGNITE-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325531#comment-17325531 ] Stanilovsky Evgeny commented on IGNITE-14593: - nothing, but seems "!=" is helpful and supported by most of vendors. > Calcite. Support not equal expression. > -- > > Key: IGNITE-14593 > URL: https://issues.apache.org/jira/browse/IGNITE-14593 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Stanilovsky Evgeny >Priority: Major > Labels: calcite > > Looks like it would be helpful to support "!=" syntax, i.e. : > {code:java} > UPDATE test SET a=7 WHERE id != 3 > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14593) Calcite. Support not equal expression.
[ https://issues.apache.org/jira/browse/IGNITE-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325530#comment-17325530 ] Roman Kondakov commented on IGNITE-14593: - What's wrong with {{<>}} sign? > Calcite. Support not equal expression. > -- > > Key: IGNITE-14593 > URL: https://issues.apache.org/jira/browse/IGNITE-14593 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Stanilovsky Evgeny >Priority: Major > Labels: calcite > > Looks like it would be helpful to support "!=" syntax, i.e. : > {code:java} > UPDATE test SET a=7 WHERE id != 3 > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14546) Calcite engine. MIN/MAX aggregates doesn't support string types
[ https://issues.apache.org/jira/browse/IGNITE-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325529#comment-17325529 ] Stanilovsky Evgeny commented on IGNITE-14546: - test ok for now, @ScriptRunnerTestsEnvironment(scriptsRoot = "src/test/sql", regex = "/aggregate/aggregates/test_aggr_string.test") > Calcite engine. MIN/MAX aggregates doesn't support string types > --- > > Key: IGNITE-14546 > URL: https://issues.apache.org/jira/browse/IGNITE-14546 > Project: Ignite > Issue Type: Bug >Reporter: Taras Ledkov >Assignee: Stanilovsky Evgeny >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > MIN/MAX aggregates doesn't support string types. > e.g. > {{CREATE TABLE TEST(val VARCHAR) }} > {{INSERT INTO TEST VALUES ('A'), ('B'), ('C') }} > {{ SELECT MIN(val), MAX(val) FROM TEST}} > Test: {{src/test/sql/aggregate/aggregates/test_aggr_string.test}} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14131) IgniteCompute tasks with same name, running from one node and different ClassLoaders can lead to OOM. Fix problems with concurrent ignite.compute call.
[ https://issues.apache.org/jira/browse/IGNITE-14131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325494#comment-17325494 ] Stanilovsky Evgeny commented on IGNITE-14131: - [~sergey-chugunov] fix ready for review, can u check it plz ? > IgniteCompute tasks with same name, running from one node and different > ClassLoaders can lead to OOM. Fix problems with concurrent ignite.compute > call. > --- > > Key: IGNITE-14131 > URL: https://issues.apache.org/jira/browse/IGNITE-14131 > Project: Ignite > Issue Type: Improvement > Components: compute >Affects Versions: 2.10, 2.9.1 >Reporter: Stanilovsky Evgeny >Assignee: Stanilovsky Evgeny >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > > The root cause of such a problem is growing from assumption that one node can > obtain only one class loader per class name. Thus multiple tasks calling with > different classloaders leads to huge cache grow in server side and finally > leads to oom with jvm metaspace. Additionally we can`t use p2p from multiple > threads, for example ignite instance is shared as a spring bean. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14131) IgniteCompute tasks with same name, running from one node and different ClassLoaders can lead to OOM. Fix problems with concurrent ignite.compute call.
[ https://issues.apache.org/jira/browse/IGNITE-14131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325491#comment-17325491 ] Ignite TC Bot commented on IGNITE-14131: {panel:title=Branch: [pull/9020/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel} {panel:title=Branch: [pull/9020/head] Base: [master] : New Tests (4)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1} {color:#8b}Basic 1{color} [[tests 4|https://ci.ignite.apache.org/viewLog.html?buildId=5973314]] * {color:#013220}IgniteBasicTestSuite: GridDifferentLocalDeploymentSelfTest.testCheckTaskClassloaderCacheIsolatedMode - PASSED{color} * {color:#013220}IgniteBasicTestSuite: GridDifferentLocalDeploymentSelfTest.testCheckTaskClassloaderCacheContinuousMode - PASSED{color} * {color:#013220}IgniteBasicTestSuite: GridDifferentLocalDeploymentSelfTest.testCheckTaskClassloaderCachePrivateMode - PASSED{color} * {color:#013220}IgniteBasicTestSuite: GridDifferentLocalDeploymentSelfTest.testCheckTaskClassloaderCacheSharedMode - PASSED{color} {panel} [TeamCity *--> Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=5973376&buildTypeId=IgniteTests24Java8_RunAll] > IgniteCompute tasks with same name, running from one node and different > ClassLoaders can lead to OOM. Fix problems with concurrent ignite.compute > call. > --- > > Key: IGNITE-14131 > URL: https://issues.apache.org/jira/browse/IGNITE-14131 > Project: Ignite > Issue Type: Improvement > Components: compute >Affects Versions: 2.9.1 >Reporter: Stanilovsky Evgeny >Assignee: Stanilovsky Evgeny >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > > The root cause of such a problem is growing from assumption that one node can > obtain only one class loader per class name. Thus multiple tasks calling with > different classloaders leads to huge cache grow in server side and finally > leads to oom with jvm metaspace. Additionally we can`t use p2p from multiple > threads, for example ignite instance is shared as a spring bean. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (IGNITE-14593) Calcite. Support not equal expression.
Stanilovsky Evgeny created IGNITE-14593: --- Summary: Calcite. Support not equal expression. Key: IGNITE-14593 URL: https://issues.apache.org/jira/browse/IGNITE-14593 Project: Ignite Issue Type: Improvement Components: sql Reporter: Stanilovsky Evgeny Looks like it would be helpful to support "!=" syntax, i.e. : {code:java} UPDATE test SET a=7 WHERE id != 3 {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14573) DML operations failure.
[ https://issues.apache.org/jira/browse/IGNITE-14573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325489#comment-17325489 ] Stanilovsky Evgeny commented on IGNITE-14573: - @ScriptRunnerTestsEnvironment(scriptsRoot = "src/test/sql", regex = "/update/null_update_merge.test") works fine for now. > DML operations failure. > --- > > Key: IGNITE-14573 > URL: https://issues.apache.org/jira/browse/IGNITE-14573 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Stanilovsky Evgeny >Assignee: Stanilovsky Evgeny >Priority: Major > Labels: calcite > Time Spent: 10m > Remaining Estimate: 0h > > As a result, insert with further read operations will fail. > For example: > {code:java} > CREATE TABLE IF NOT EXISTS test (id INTEGER, a INTEGER); > INSERT INTO test VALUES (1, 1), (2, 2), (3, 3), (4, NULL);" > UPDATE test SET a=CASE WHEN id=1 THEN 7 ELSE NULL END WHERE id <= 2"; > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (IGNITE-14576) Ignite command-line tool cannot stop already running ignite instance
[ https://issues.apache.org/jira/browse/IGNITE-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vyacheslav Koptilin closed IGNITE-14576. > Ignite command-line tool cannot stop already running ignite instance > > > Key: IGNITE-14576 > URL: https://issues.apache.org/jira/browse/IGNITE-14576 > Project: Ignite > Issue Type: Bug > Environment: >Reporter: Vyacheslav Koptilin >Assignee: Vyacheslav Koptilin >Priority: Major > Labels: ignite-3, ignite-3-cli-tool > > Ignite command-line tool cannot stop already running ignite instance. > Steps to reproduce: > 1. start Ignite node > {code:bash} > PS C:\projects\ignite-3\modules\cli\target> ./ignite node start > consistent-id= > Starting a new Ignite node... > Node is successfully started. To stop, type ignite node stop > consistent-id= > +---+---+ > | Consistent ID | consistent-id= > | > +---+---+ > | PID | 17476 > | > +---+---+ > | Log File | > C:\projects\ignite-3\modules\cli\target\ignite-log\consistent-id=.log | > +---+---+ > {code} > 2. make sure that Ignite node has been started > {code:bash} > PS C:\projects\ignite-3\modules\cli\target> ./ignite node list > Currently, there are 1 locally running nodes. > ++---+---+ > | Consistent ID | PID | Log File >| > ++---+---+ > | consistent-id= | 17476 | > C:\projects\ignite-3\modules\cli\target\ignite-log\consistent-id=.log | > ++---+---+ > {code} > 3 try to stop the node > {code:bash} > PS C:\projects\ignite-3\modules\cli\target> ./ignite node stop > consistent-ids= > Can't find node with consistent id consistent-ids= > {code} > The root cause is obvious. The tool tries to find > {{consistentId*s*=_...pid}} file instead of {{consistent-id=_...pid}} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (IGNITE-14576) Ignite command-line tool cannot stop already running ignite instance
[ https://issues.apache.org/jira/browse/IGNITE-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vyacheslav Koptilin resolved IGNITE-14576. -- Resolution: Invalid CLI tool works as expected. My fault. > Ignite command-line tool cannot stop already running ignite instance > > > Key: IGNITE-14576 > URL: https://issues.apache.org/jira/browse/IGNITE-14576 > Project: Ignite > Issue Type: Bug > Environment: >Reporter: Vyacheslav Koptilin >Assignee: Vyacheslav Koptilin >Priority: Major > Labels: ignite-3, ignite-3-cli-tool > > Ignite command-line tool cannot stop already running ignite instance. > Steps to reproduce: > 1. start Ignite node > {code:bash} > PS C:\projects\ignite-3\modules\cli\target> ./ignite node start > consistent-id= > Starting a new Ignite node... > Node is successfully started. To stop, type ignite node stop > consistent-id= > +---+---+ > | Consistent ID | consistent-id= > | > +---+---+ > | PID | 17476 > | > +---+---+ > | Log File | > C:\projects\ignite-3\modules\cli\target\ignite-log\consistent-id=.log | > +---+---+ > {code} > 2. make sure that Ignite node has been started > {code:bash} > PS C:\projects\ignite-3\modules\cli\target> ./ignite node list > Currently, there are 1 locally running nodes. > ++---+---+ > | Consistent ID | PID | Log File >| > ++---+---+ > | consistent-id= | 17476 | > C:\projects\ignite-3\modules\cli\target\ignite-log\consistent-id=.log | > ++---+---+ > {code} > 3 try to stop the node > {code:bash} > PS C:\projects\ignite-3\modules\cli\target> ./ignite node stop > consistent-ids= > Can't find node with consistent id consistent-ids= > {code} > The root cause is obvious. The tool tries to find > {{consistentId*s*=_...pid}} file instead of {{consistent-id=_...pid}} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (IGNITE-14509) [Ducktape: Thin client] XML-based configuration
[ https://issues.apache.org/jira/browse/IGNITE-14509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikolay Izhikov reassigned IGNITE-14509: Assignee: Nikolay Izhikov (was: Evgeniya Vdovets) > [Ducktape: Thin client] XML-based configuration > --- > > Key: IGNITE-14509 > URL: https://issues.apache.org/jira/browse/IGNITE-14509 > Project: Ignite > Issue Type: Sub-task >Reporter: Evgeniya Vdovets >Assignee: Nikolay Izhikov >Priority: Major > > Need to add j2-based configuration for thin client to Ducktape framework as a > new feature > and modify simple thin client test (made as part of ignite-13970) to use this > approach > — > Task: > 1) create ClientConfiguration which contains addresses and port, data should > be provided from py test > 2) modify IgniteAwareService to use this config for thin clients -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-13691) Calcite Integration. Support of EXCEPT operator
[ https://issues.apache.org/jira/browse/IGNITE-13691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325175#comment-17325175 ] Konstantin Orlov commented on IGNITE-13691: --- Hi, [~alex_pl]! I left a few comments. Please see PR. > Calcite Integration. Support of EXCEPT operator > --- > > Key: IGNITE-13691 > URL: https://issues.apache.org/jira/browse/IGNITE-13691 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Yury Gerzhedovich >Assignee: Aleksey Plekhanov >Priority: Critical > Time Spent: 20m > Remaining Estimate: 0h > > As of now new Calcite based SQL engine doesn't support opearator EXCEPT. We > need to implement it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (IGNITE-14592) Incapsulate config modification logic into callback
[ https://issues.apache.org/jira/browse/IGNITE-14592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikolay Izhikov resolved IGNITE-14592. -- Resolution: Fixed > Incapsulate config modification logic into callback > --- > > Key: IGNITE-14592 > URL: https://issues.apache.org/jira/browse/IGNITE-14592 > Project: Ignite > Issue Type: Improvement >Reporter: Nikolay Izhikov >Assignee: Nikolay Izhikov >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Currently, {{ignite_aware.py}} contains several pieces of code for config > modification based on some external > parameters(update_ssl_config_from_globals, _prepare_configs). > This modifications should be placed in single config callback. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14474) Improve error message in case rebalance fails
[ https://issues.apache.org/jira/browse/IGNITE-14474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325134#comment-17325134 ] Rodion commented on IGNITE-14474: - [~Denis Chudov] please review the request > Improve error message in case rebalance fails > - > > Key: IGNITE-14474 > URL: https://issues.apache.org/jira/browse/IGNITE-14474 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.5 >Reporter: Denis Chudov >Assignee: Rodion >Priority: Major > Fix For: 2.9.2 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we can get a message like this when rebalance fails with an > exception (examples from ignite 2.5, in newer versions the log messages were > changed but the problem is still actual): > {code:java} > 2019-11-27 13:41:14,504[WARN ][utility-#79%xxx%][GridDhtPartitionDemander] > Rebalancing from node cancelled [grp=ignite-sys-cache, > topVer=AffinityTopologyVersion [topVer=1932, minorTopVer=1], > supplier=f014f30a-77f2-4459-aa5b-6c12907a7449, topic=0]. Supply message > couldn't be unmarshalled: class o.a.i.IgniteCheckedException: Failed to > unmarshal object with optimized marshaller > 2019-11-27 13:41:14,504[INFO ][utility-#79%xxx%][GridDhtPartitionDemander] > Cancelled rebalancing [grp=ignite-sys-cache, > supplier=f014f30a-77f2-4459-aa5b-6c12907a7449, topVer=AffinityTopologyVersion > [topVer=1932, minorTopVer=1], time=88 ms] > 2019-11-27 13:41:14,508[WARN ][utility-#76%xxx%][GridDhtPartitionDemander] > Rebalancing from node cancelled [grp=ignite-sys-cache, > topVer=AffinityTopologyVersion [topVer=1932, minorTopVer=1], > supplier=dfa5ee06-48c9-4458-ae55-48cc6ceda998, topic=0]. Supply message > couldn't be unmarshalled: class o.a.i.IgniteCheckedException: Failed to > unmarshal object with optimized marshaller > {code} > In the case above, a marshalling exception leads to rebalance failure which > will never be resolved - i.e. the cluster enters into a erroneous state. > We should report issues like this as ERROR. The message should explain that > the rebalance has failed, data for the cache was not fully copied to the > node, the backup factor is not recovered and the cluster may not work > correctly. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (IGNITE-14553) Calcite engine. Duplicated result on insert
[ https://issues.apache.org/jira/browse/IGNITE-14553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325087#comment-17325087 ] Aleksey Plekhanov edited comment on IGNITE-14553 at 4/19/21, 3:41 PM: -- Without MVCC already inserted by the current query data can be processed by this query again. Here one more reproducer to show this issue: {code:java} public void testInsertAsSelect() throws Exception { QueryEngine engine = Commons.lookupComponent(grid(1).context(), QueryEngine.class); engine.query(null, "PUBLIC", "CREATE TABLE test (epoch_cur int, epoch_copied int)"); engine.query(null, "PUBLIC", "INSERT INTO test VALUES (0, 0)").get(0).getAll(); for (int i = 1; i < 16; i++) { engine.query(null, "PUBLIC", "INSERT INTO test SELECT ?, epoch_cur FROM test", i).get(0).getAll(); List> rows = engine.query(null, "PUBLIC", "SELECT * FROM test WHERE epoch_copied = ?", i).get(0).getAll(); assertEquals("Unexpected rows for epoch " + i, 0, rows.size()); } } {code} was (Author: alex_pl): Without MVCC already inserted by the current query data can be processed by this query again. Here one more reproducer to show this issue: {code:java} public void testInsertAsSelect() throws Exception { QueryEngine engine = Commons.lookupComponent(grid(1).context(), QueryEngine.class); engine.query(null, "PUBLIC", "CREATE TABLE test (epoch_cur int, epoch_copied int)"); engine.query(null, "PUBLIC", "INSERT INTO test VALUES (0, 0)").get(0).getAll(); for (int i = 1; i < 16; i++) { engine.query(null, "PUBLIC", "INSERT INTO test SELECT ?, epoch_cur FROM test", i).get(0).getAll(); List> rows = engine.query(null, "PUBLIC", "SELECT * FROM test WHERE epoch_copied = ?", i).get(0).getAll(); assertEquals("Unexpected rows for epoch " + i, rows.size(), 0); } } {code} > Calcite engine. Duplicated result on insert > --- > > Key: IGNITE-14553 > URL: https://issues.apache.org/jira/browse/IGNITE-14553 > Project: Ignite > Issue Type: Bug > Components: sql >Reporter: Konstantin Orlov >Priority: Blocker > > Please see the test > {{modules/calcite/src/test/sql/types/string/test_scan_big_varchar.test_ignore}} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14474) Improve error message in case rebalance fails
[ https://issues.apache.org/jira/browse/IGNITE-14474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325121#comment-17325121 ] Ignite TC Bot commented on IGNITE-14474: {panel:title=Branch: [pull/9004/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel} {panel:title=Branch: [pull/9004/head] Base: [master] : No new tests found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}{panel} [TeamCity *--> Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=5972728&buildTypeId=IgniteTests24Java8_RunAll] > Improve error message in case rebalance fails > - > > Key: IGNITE-14474 > URL: https://issues.apache.org/jira/browse/IGNITE-14474 > Project: Ignite > Issue Type: Improvement >Reporter: Denis Chudov >Assignee: Rodion >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Currently we can get a message like this when rebalance fails with an > exception (examples from ignite 2.5, in newer versions the log messages were > changed but the problem is still actual): > {code:java} > 2019-11-27 13:41:14,504[WARN ][utility-#79%xxx%][GridDhtPartitionDemander] > Rebalancing from node cancelled [grp=ignite-sys-cache, > topVer=AffinityTopologyVersion [topVer=1932, minorTopVer=1], > supplier=f014f30a-77f2-4459-aa5b-6c12907a7449, topic=0]. Supply message > couldn't be unmarshalled: class o.a.i.IgniteCheckedException: Failed to > unmarshal object with optimized marshaller > 2019-11-27 13:41:14,504[INFO ][utility-#79%xxx%][GridDhtPartitionDemander] > Cancelled rebalancing [grp=ignite-sys-cache, > supplier=f014f30a-77f2-4459-aa5b-6c12907a7449, topVer=AffinityTopologyVersion > [topVer=1932, minorTopVer=1], time=88 ms] > 2019-11-27 13:41:14,508[WARN ][utility-#76%xxx%][GridDhtPartitionDemander] > Rebalancing from node cancelled [grp=ignite-sys-cache, > topVer=AffinityTopologyVersion [topVer=1932, minorTopVer=1], > supplier=dfa5ee06-48c9-4458-ae55-48cc6ceda998, topic=0]. Supply message > couldn't be unmarshalled: class o.a.i.IgniteCheckedException: Failed to > unmarshal object with optimized marshaller > {code} > In the case above, a marshalling exception leads to rebalance failure which > will never be resolved - i.e. the cluster enters into a erroneous state. > We should report issues like this as ERROR. The message should explain that > the rebalance has failed, data for the cache was not fully copied to the > node, the backup factor is not recovered and the cluster may not work > correctly. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-14497) Move background task deletion at the end of next checkpoint
[ https://issues.apache.org/jira/browse/IGNITE-14497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maria Makedonskaya updated IGNITE-14497: Reviewer: Ivan Bessonov (was: Sergey Chugunov) > Move background task deletion at the end of next checkpoint > --- > > Key: IGNITE-14497 > URL: https://issues.apache.org/jira/browse/IGNITE-14497 > Project: Ignite > Issue Type: Bug >Reporter: Maria Makedonskaya >Assignee: Maria Makedonskaya >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > In [1] has been described scenario of the race that makes possible a > situation when information from metastore has been deleted and part of the > index is still present in the storage. > Actually, fix in [1] that has been done in slightly different way, however, > it strongly decreases possibility of the race. Removal of the background task > has been moved to beginning of the next checkpoint. It was done this way, > because the problem was in case when node unexpectedly failed in the middle > of next checkpoint and after restart task failed on check of deleted index > metaPage. The check was done in [2]. > In current issue, we only move background task deletion at the end of the > next checkpoint. > [1][IGNITE-13382|https://issues.apache.org/jira/browse/IGNITE-13382] > [2][IGNITE-14447|https://issues.apache.org/jira/browse/IGNITE-14447] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14497) Move background task deletion at the end of next checkpoint
[ https://issues.apache.org/jira/browse/IGNITE-14497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325098#comment-17325098 ] Maria Makedonskaya commented on IGNITE-14497: - [~ibessonov], could you please review my changes? > Move background task deletion at the end of next checkpoint > --- > > Key: IGNITE-14497 > URL: https://issues.apache.org/jira/browse/IGNITE-14497 > Project: Ignite > Issue Type: Bug >Reporter: Maria Makedonskaya >Assignee: Maria Makedonskaya >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > In [1] has been described scenario of the race that makes possible a > situation when information from metastore has been deleted and part of the > index is still present in the storage. > Actually, fix in [1] that has been done in slightly different way, however, > it strongly decreases possibility of the race. Removal of the background task > has been moved to beginning of the next checkpoint. It was done this way, > because the problem was in case when node unexpectedly failed in the middle > of next checkpoint and after restart task failed on check of deleted index > metaPage. The check was done in [2]. > In current issue, we only move background task deletion at the end of the > next checkpoint. > [1][IGNITE-13382|https://issues.apache.org/jira/browse/IGNITE-13382] > [2][IGNITE-14447|https://issues.apache.org/jira/browse/IGNITE-14447] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-14536) Handle forceful shutdown of ScaleCube cluster node
[ https://issues.apache.org/jira/browse/IGNITE-14536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Chugunov updated IGNITE-14536: - Ignite Flags: (was: Docs Required,Release Notes Required) > Handle forceful shutdown of ScaleCube cluster node > -- > > Key: IGNITE-14536 > URL: https://issues.apache.org/jira/browse/IGNITE-14536 > Project: Ignite > Issue Type: Bug >Reporter: Semyon Danilov >Assignee: Semyon Danilov >Priority: Major > Labels: ignite-3 > Fix For: 3.0.0-alpha2 > > Time Spent: 50m > Remaining Estimate: 0h > > Right now, if scalecube cluster node was shutdown forcefully no event will be > propagated to ClusterService and topology wouldn't change -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14553) Calcite engine. Duplicated result on insert
[ https://issues.apache.org/jira/browse/IGNITE-14553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325087#comment-17325087 ] Aleksey Plekhanov commented on IGNITE-14553: Without MVCC already inserted by the current query data can be processed by this query again. Here one more reproducer to show this issue: {code:java} public void testInsertAsSelect() throws Exception { QueryEngine engine = Commons.lookupComponent(grid(1).context(), QueryEngine.class); engine.query(null, "PUBLIC", "CREATE TABLE test (epoch_cur int, epoch_copied int)"); engine.query(null, "PUBLIC", "INSERT INTO test VALUES (0, 0)").get(0).getAll(); for (int i = 1; i < 16; i++) { engine.query(null, "PUBLIC", "INSERT INTO test SELECT ?, epoch_cur FROM test", i).get(0).getAll(); List> rows = engine.query(null, "PUBLIC", "SELECT * FROM test WHERE epoch_copied = ?", i).get(0).getAll(); assertEquals("Unexpected rows for epoch " + i, rows.size(), 0); } } {code} > Calcite engine. Duplicated result on insert > --- > > Key: IGNITE-14553 > URL: https://issues.apache.org/jira/browse/IGNITE-14553 > Project: Ignite > Issue Type: Bug > Components: sql >Reporter: Konstantin Orlov >Priority: Blocker > > Please see the test > {{modules/calcite/src/test/sql/types/string/test_scan_big_varchar.test_ignore}} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-14536) Handle forceful shutdown of ScaleCube cluster node
[ https://issues.apache.org/jira/browse/IGNITE-14536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Chugunov updated IGNITE-14536: - Fix Version/s: 3.0.0-alpha2 > Handle forceful shutdown of ScaleCube cluster node > -- > > Key: IGNITE-14536 > URL: https://issues.apache.org/jira/browse/IGNITE-14536 > Project: Ignite > Issue Type: Bug >Reporter: Semyon Danilov >Assignee: Semyon Danilov >Priority: Major > Labels: ignite-3 > Fix For: 3.0.0-alpha2 > > Time Spent: 50m > Remaining Estimate: 0h > > Right now, if scalecube cluster node was shutdown forcefully no event will be > propagated to ClusterService and topology wouldn't change -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-14505) Print information about striped pool in metrics for local node
[ https://issues.apache.org/jira/browse/IGNITE-14505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Denis Mekhanikov updated IGNITE-14505: -- Release Note: Extend the metrics log message with information about the striped pool. > Print information about striped pool in metrics for local node > -- > > Key: IGNITE-14505 > URL: https://issues.apache.org/jira/browse/IGNITE-14505 > Project: Ignite > Issue Type: Improvement >Reporter: Denis Mekhanikov >Assignee: Denis Mekhanikov >Priority: Major > Fix For: 2.11 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently only information about public and system thread pools are printed > in metrics for a local node. It would be good to have the same information > about striped pool as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-14505) Print information about striped pool in metrics for local node
[ https://issues.apache.org/jira/browse/IGNITE-14505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ilya Kasnacheev updated IGNITE-14505: - Fix Version/s: 2.11 > Print information about striped pool in metrics for local node > -- > > Key: IGNITE-14505 > URL: https://issues.apache.org/jira/browse/IGNITE-14505 > Project: Ignite > Issue Type: Improvement >Reporter: Denis Mekhanikov >Assignee: Denis Mekhanikov >Priority: Major > Fix For: 2.11 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently only information about public and system thread pools are printed > in metrics for a local node. It would be good to have the same information > about striped pool as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14505) Print information about striped pool in metrics for local node
[ https://issues.apache.org/jira/browse/IGNITE-14505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325067#comment-17325067 ] Ilya Kasnacheev commented on IGNITE-14505: -- Can you please also file release notes field? > Print information about striped pool in metrics for local node > -- > > Key: IGNITE-14505 > URL: https://issues.apache.org/jira/browse/IGNITE-14505 > Project: Ignite > Issue Type: Improvement >Reporter: Denis Mekhanikov >Assignee: Denis Mekhanikov >Priority: Major > Fix For: 2.11 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently only information about public and system thread pools are printed > in metrics for a local node. It would be good to have the same information > about striped pool as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-14505) Print information about striped pool in metrics for local node
[ https://issues.apache.org/jira/browse/IGNITE-14505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ilya Kasnacheev updated IGNITE-14505: - Ignite Flags: (was: Release Notes Required) > Print information about striped pool in metrics for local node > -- > > Key: IGNITE-14505 > URL: https://issues.apache.org/jira/browse/IGNITE-14505 > Project: Ignite > Issue Type: Improvement >Reporter: Denis Mekhanikov >Assignee: Denis Mekhanikov >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Currently only information about public and system thread pools are printed > in metrics for a local node. It would be good to have the same information > about striped pool as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-14505) Print information about striped pool in metrics for local node
[ https://issues.apache.org/jira/browse/IGNITE-14505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ilya Kasnacheev updated IGNITE-14505: - Ignite Flags: Release Notes Required > Print information about striped pool in metrics for local node > -- > > Key: IGNITE-14505 > URL: https://issues.apache.org/jira/browse/IGNITE-14505 > Project: Ignite > Issue Type: Improvement >Reporter: Denis Mekhanikov >Assignee: Denis Mekhanikov >Priority: Major > Fix For: 2.11 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently only information about public and system thread pools are printed > in metrics for a local node. It would be good to have the same information > about striped pool as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-14505) Print information about striped pool in metrics for local node
[ https://issues.apache.org/jira/browse/IGNITE-14505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ilya Kasnacheev updated IGNITE-14505: - Ignite Flags: Release Notes Required (was: Docs Required,Release Notes Required) > Print information about striped pool in metrics for local node > -- > > Key: IGNITE-14505 > URL: https://issues.apache.org/jira/browse/IGNITE-14505 > Project: Ignite > Issue Type: Improvement >Reporter: Denis Mekhanikov >Assignee: Denis Mekhanikov >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Currently only information about public and system thread pools are printed > in metrics for a local node. It would be good to have the same information > about striped pool as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14505) Print information about striped pool in metrics for local node
[ https://issues.apache.org/jira/browse/IGNITE-14505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325066#comment-17325066 ] Ilya Kasnacheev commented on IGNITE-14505: -- Thank you for this improvement [~dmekhanikov], I have merged it to master. > Print information about striped pool in metrics for local node > -- > > Key: IGNITE-14505 > URL: https://issues.apache.org/jira/browse/IGNITE-14505 > Project: Ignite > Issue Type: Improvement >Reporter: Denis Mekhanikov >Assignee: Denis Mekhanikov >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Currently only information about public and system thread pools are printed > in metrics for a local node. It would be good to have the same information > about striped pool as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14558) Add information about javadoc validation and generation commands to DEVNOTES.md
[ https://issues.apache.org/jira/browse/IGNITE-14558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325065#comment-17325065 ] Peter Ivanov commented on IGNITE-14558: --- ${current.year} is not used when checking Javadoc for correctness. > Add information about javadoc validation and generation commands to > DEVNOTES.md > > > Key: IGNITE-14558 > URL: https://issues.apache.org/jira/browse/IGNITE-14558 > Project: Ignite > Issue Type: Improvement >Reporter: Andrey N. Gura >Assignee: Peter Ivanov >Priority: Critical > Labels: ignite-3 > Fix For: 3.0.0-alpha2 > > Time Spent: 10m > Remaining Estimate: 0h > > https://issues.apache.org/jira/browse/IGNITE-13751 is implemented and merged > but DEVNOTES.md is not updated. > Information about javadoc validation and generation commands should be added > to DEVNOTES.md. > Also, there is unresolved variable: > {code:java} > ${current.year} Copyright © Apache Software Foundation > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14573) DML operations failure.
[ https://issues.apache.org/jira/browse/IGNITE-14573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324995#comment-17324995 ] Stanilovsky Evgeny commented on IGNITE-14573: - [~korlov] check my changes plz? > DML operations failure. > --- > > Key: IGNITE-14573 > URL: https://issues.apache.org/jira/browse/IGNITE-14573 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Stanilovsky Evgeny >Assignee: Stanilovsky Evgeny >Priority: Major > Labels: calcite > Time Spent: 10m > Remaining Estimate: 0h > > As a result, insert with further read operations will fail. > For example: > {code:java} > CREATE TABLE IF NOT EXISTS test (id INTEGER, a INTEGER); > INSERT INTO test VALUES (1, 1), (2, 2), (3, 3), (4, NULL);" > UPDATE test SET a=CASE WHEN id=1 THEN 7 ELSE NULL END WHERE id <= 2"; > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (IGNITE-14558) Add information about javadoc validation and generation commands to DEVNOTES.md
[ https://issues.apache.org/jira/browse/IGNITE-14558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324972#comment-17324972 ] Andrey Mashenkov edited comment on IGNITE-14558 at 4/19/21, 12:03 PM: -- ${current.year} is still unresolved. A 'javadoc' profile need to be activated to resolve the issue. was (Author: amashenkov): ${current.year} is still unresolved. > Add information about javadoc validation and generation commands to > DEVNOTES.md > > > Key: IGNITE-14558 > URL: https://issues.apache.org/jira/browse/IGNITE-14558 > Project: Ignite > Issue Type: Improvement >Reporter: Andrey N. Gura >Assignee: Peter Ivanov >Priority: Critical > Labels: ignite-3 > Fix For: 3.0.0-alpha2 > > Time Spent: 10m > Remaining Estimate: 0h > > https://issues.apache.org/jira/browse/IGNITE-13751 is implemented and merged > but DEVNOTES.md is not updated. > Information about javadoc validation and generation commands should be added > to DEVNOTES.md. > Also, there is unresolved variable: > {code:java} > ${current.year} Copyright © Apache Software Foundation > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14558) Add information about javadoc validation and generation commands to DEVNOTES.md
[ https://issues.apache.org/jira/browse/IGNITE-14558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324972#comment-17324972 ] Andrey Mashenkov commented on IGNITE-14558: --- ${current.year} is still unresolved. > Add information about javadoc validation and generation commands to > DEVNOTES.md > > > Key: IGNITE-14558 > URL: https://issues.apache.org/jira/browse/IGNITE-14558 > Project: Ignite > Issue Type: Improvement >Reporter: Andrey N. Gura >Assignee: Peter Ivanov >Priority: Critical > Labels: ignite-3 > Fix For: 3.0.0-alpha2 > > Time Spent: 10m > Remaining Estimate: 0h > > https://issues.apache.org/jira/browse/IGNITE-13751 is implemented and merged > but DEVNOTES.md is not updated. > Information about javadoc validation and generation commands should be added > to DEVNOTES.md. > Also, there is unresolved variable: > {code:java} > ${current.year} Copyright © Apache Software Foundation > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (IGNITE-14565) Add additional update counter logging for detect causes of AssertionError: LWM after HWM
[ https://issues.apache.org/jira/browse/IGNITE-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324885#comment-17324885 ] Maria Makedonskaya edited comment on IGNITE-14565 at 4/19/21, 11:17 AM: [~slava.koptilin] , could you please take a look? was (Author: makedonskaya): [~sk0x50], could you please take a look? > Add additional update counter logging for detect causes of AssertionError: > LWM after HWM > > > Key: IGNITE-14565 > URL: https://issues.apache.org/jira/browse/IGNITE-14565 > Project: Ignite > Issue Type: Bug >Reporter: Maria Makedonskaya >Assignee: Maria Makedonskaya >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-14565) Add additional update counter logging for detect causes of AssertionError: LWM after HWM
[ https://issues.apache.org/jira/browse/IGNITE-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maria Makedonskaya updated IGNITE-14565: Reviewer: Vyacheslav Koptilin (was: Slava Koptilin) > Add additional update counter logging for detect causes of AssertionError: > LWM after HWM > > > Key: IGNITE-14565 > URL: https://issues.apache.org/jira/browse/IGNITE-14565 > Project: Ignite > Issue Type: Bug >Reporter: Maria Makedonskaya >Assignee: Maria Makedonskaya >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14565) Add additional update counter logging for detect causes of AssertionError: LWM after HWM
[ https://issues.apache.org/jira/browse/IGNITE-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324950#comment-17324950 ] Ignite TC Bot commented on IGNITE-14565: {panel:title=Branch: [pull/9011/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel} {panel:title=Branch: [pull/9011/head] Base: [master] : No new tests found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}{panel} [TeamCity *--> Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=5969343&buildTypeId=IgniteTests24Java8_RunAll] > Add additional update counter logging for detect causes of AssertionError: > LWM after HWM > > > Key: IGNITE-14565 > URL: https://issues.apache.org/jira/browse/IGNITE-14565 > Project: Ignite > Issue Type: Bug >Reporter: Maria Makedonskaya >Assignee: Maria Makedonskaya >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-14592) Incapsulate config modification logic into callback
[ https://issues.apache.org/jira/browse/IGNITE-14592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikolay Izhikov updated IGNITE-14592: - Description: Currently, {{ignite_aware.py}} contains several pieces of code for config modification based on some external parameters(update_ssl_config_from_globals, _prepare_configs). This modifications should be placed in single config callback. was: Right now extensions of {{IgniteSpec}} can't provide custom config files and it's templates because only template returned from spec if {{IgniteConfigTemplate}}. We need to return array of tuples from {{IgniteSpec#config_templates}} that specify config files required to be generated to run Ignite based node. > Incapsulate config modification logic into callback > --- > > Key: IGNITE-14592 > URL: https://issues.apache.org/jira/browse/IGNITE-14592 > Project: Ignite > Issue Type: Improvement >Reporter: Nikolay Izhikov >Assignee: Nikolay Izhikov >Priority: Major > > Currently, {{ignite_aware.py}} contains several pieces of code for config > modification based on some external > parameters(update_ssl_config_from_globals, _prepare_configs). > This modifications should be placed in single config callback. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (IGNITE-14592) Incapsulate config modification logic into callback
Nikolay Izhikov created IGNITE-14592: Summary: Incapsulate config modification logic into callback Key: IGNITE-14592 URL: https://issues.apache.org/jira/browse/IGNITE-14592 Project: Ignite Issue Type: Improvement Reporter: Nikolay Izhikov Assignee: Nikolay Izhikov Right now extensions of {{IgniteSpec}} can't provide custom config files and it's templates because only template returned from spec if {{IgniteConfigTemplate}}. We need to return array of tuples from {{IgniteSpec#config_templates}} that specify config files required to be generated to run Ignite based node. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (IGNITE-14591) Add Javadoc rules to maven checkstyle plugin.
[ https://issues.apache.org/jira/browse/IGNITE-14591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Mashenkov reassigned IGNITE-14591: - Assignee: Andrey Mashenkov > Add Javadoc rules to maven checkstyle plugin. > - > > Key: IGNITE-14591 > URL: https://issues.apache.org/jira/browse/IGNITE-14591 > Project: Ignite > Issue Type: Improvement >Reporter: Andrey Mashenkov >Assignee: Andrey Mashenkov >Priority: Major > Labels: ignite-3 > Time Spent: 10m > Remaining Estimate: 0h > > Let's add javadoc rules to maven-checkstyle-plugin and fix the Codestyle > guide. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-14591) Add Javadoc rules to maven checkstyle plugin.
[ https://issues.apache.org/jira/browse/IGNITE-14591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Mashenkov updated IGNITE-14591: -- Description: Let's add javadoc rules to maven-checkstyle-plugin and update the Codestyle guide. (was: Let's add javadoc rules to maven-checkstyle-plugin and fix the Codestyle guide.) > Add Javadoc rules to maven checkstyle plugin. > - > > Key: IGNITE-14591 > URL: https://issues.apache.org/jira/browse/IGNITE-14591 > Project: Ignite > Issue Type: Improvement >Reporter: Andrey Mashenkov >Assignee: Andrey Mashenkov >Priority: Major > Labels: ignite-3 > Time Spent: 10m > Remaining Estimate: 0h > > Let's add javadoc rules to maven-checkstyle-plugin and update the Codestyle > guide. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-14324) EVT_CLIENT_NODE_DISCONNECTED is not triggered in k8s
[ https://issues.apache.org/jira/browse/IGNITE-14324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandr Shapkin updated IGNITE-14324: -- Release Note: Fixed an issue that prevented a node from startup in case it can't obtain IP addresses to connect to > EVT_CLIENT_NODE_DISCONNECTED is not triggered in k8s > > > Key: IGNITE-14324 > URL: https://issues.apache.org/jira/browse/IGNITE-14324 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.9.1 >Reporter: Alexandr Shapkin >Assignee: Alexandr Shapkin >Priority: Major > Labels: discovery > Fix For: 2.11 > > Time Spent: 20m > Remaining Estimate: 0h > > Scenario: > Kubernetes world, a server node, a k8s service, and a thick client. The > client is subscribed to EVT_CLIENT_NODE_DISCONNECTED event and is connected > to the server node. > When a service goes down alongside the server, no > EVT_CLIENT_NODE_DISCONNECTED is caught and the client reports only about a > socket exception and inability to resolve IP addresses from the services, > cause k8s resource is not available. The DEBUG logs (attached) show that > discovery is constantly trying to use KubernetesIpFinder and restore the > connection. > Expected: > Discovery realizes that a client is disconnected, no more reconnection > attempts happen and EVT_CLIENT_NODE_DISCONNECTED is thrown. > Solution: > Count resolution attempts and if it’s more than the threshold (2 if > failuredetectiontimeout is not configured, otherwise #reconnCount) give up > and invoke disconnection logic -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14590) Calcite engine. Sort out the types/decimal and types/string directories
[ https://issues.apache.org/jira/browse/IGNITE-14590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324900#comment-17324900 ] Konstantin Orlov commented on IGNITE-14590: --- This patch also fixes a few minor problems: decimal number can't be deserialised when used in WHERE condition and problem with validation a huge decimal numbers. > Calcite engine. Sort out the types/decimal and types/string directories > --- > > Key: IGNITE-14590 > URL: https://issues.apache.org/jira/browse/IGNITE-14590 > Project: Ignite > Issue Type: Task > Components: sql >Reporter: Konstantin Orlov >Assignee: Konstantin Orlov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > We need to sort out results of the {{ScriptRunnerTestSuite}} to mute an every > red test and file a ticket for related problems. > This ticket covers only two directories: {{types/decimal}} and > {{types/string}}. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (IGNITE-14591) Add Javadoc rules to maven checkstyle plugin.
Andrey Mashenkov created IGNITE-14591: - Summary: Add Javadoc rules to maven checkstyle plugin. Key: IGNITE-14591 URL: https://issues.apache.org/jira/browse/IGNITE-14591 Project: Ignite Issue Type: Improvement Reporter: Andrey Mashenkov Let's add javadoc rules to maven-checkstyle-plugin and fix the Codestyle guide. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (IGNITE-14590) Calcite engine. Sort out the types/decimal and types/string directories
Konstantin Orlov created IGNITE-14590: - Summary: Calcite engine. Sort out the types/decimal and types/string directories Key: IGNITE-14590 URL: https://issues.apache.org/jira/browse/IGNITE-14590 Project: Ignite Issue Type: Task Components: sql Reporter: Konstantin Orlov Assignee: Konstantin Orlov We need to sort out results of the {{ScriptRunnerTestSuite}} to mute an every red test and file a ticket for related problems. This ticket covers only two directories: {{types/decimal}} and {{types/string}}. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (IGNITE-14589) Calcite engine. Numerous problem with type Decimal
Konstantin Orlov created IGNITE-14589: - Summary: Calcite engine. Numerous problem with type Decimal Key: IGNITE-14589 URL: https://issues.apache.org/jira/browse/IGNITE-14589 Project: Ignite Issue Type: Bug Components: sql Reporter: Konstantin Orlov There are numerous problem with a decimal types: * very big numbers printed in scientific notation * leading and trailing zeros are truncated when converting to string * casting to precise scale is not working( {{select cast('0.01' as decimal(10, 1)) * 10}} returns 0.1 instead of 0) Affected tests: {{src/test/sql/types/decimal}} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14565) Add additional update counter logging for detect causes of AssertionError: LWM after HWM
[ https://issues.apache.org/jira/browse/IGNITE-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324885#comment-17324885 ] Maria Makedonskaya commented on IGNITE-14565: - [~sk0x50], could you please take a look? > Add additional update counter logging for detect causes of AssertionError: > LWM after HWM > > > Key: IGNITE-14565 > URL: https://issues.apache.org/jira/browse/IGNITE-14565 > Project: Ignite > Issue Type: Bug >Reporter: Maria Makedonskaya >Assignee: Maria Makedonskaya >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-14565) Add additional update counter logging for detect causes of AssertionError: LWM after HWM
[ https://issues.apache.org/jira/browse/IGNITE-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maria Makedonskaya updated IGNITE-14565: Reviewer: Slava Koptilin (was: Vladimir Malinovskiy) > Add additional update counter logging for detect causes of AssertionError: > LWM after HWM > > > Key: IGNITE-14565 > URL: https://issues.apache.org/jira/browse/IGNITE-14565 > Project: Ignite > Issue Type: Bug >Reporter: Maria Makedonskaya >Assignee: Maria Makedonskaya >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Issue Comment Deleted] (IGNITE-14565) Add additional update counter logging for detect causes of AssertionError: LWM after HWM
[ https://issues.apache.org/jira/browse/IGNITE-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maria Makedonskaya updated IGNITE-14565: Comment: was deleted (was: [~vmalinovskiy], could you please take a look?) > Add additional update counter logging for detect causes of AssertionError: > LWM after HWM > > > Key: IGNITE-14565 > URL: https://issues.apache.org/jira/browse/IGNITE-14565 > Project: Ignite > Issue Type: Bug >Reporter: Maria Makedonskaya >Assignee: Maria Makedonskaya >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14565) Add additional update counter logging for detect causes of AssertionError: LWM after HWM
[ https://issues.apache.org/jira/browse/IGNITE-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324884#comment-17324884 ] Maria Makedonskaya commented on IGNITE-14565: - [~vmalinovskiy], could you please take a look? > Add additional update counter logging for detect causes of AssertionError: > LWM after HWM > > > Key: IGNITE-14565 > URL: https://issues.apache.org/jira/browse/IGNITE-14565 > Project: Ignite > Issue Type: Bug >Reporter: Maria Makedonskaya >Assignee: Maria Makedonskaya >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14565) Add additional update counter logging for detect causes of AssertionError: LWM after HWM
[ https://issues.apache.org/jira/browse/IGNITE-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324882#comment-17324882 ] Ignite TC Bot commented on IGNITE-14565: {panel:title=Branch: [pull/9011/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel} {panel:title=Branch: [pull/9011/head] Base: [master] : No new tests found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}{panel} [TeamCity *--> Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=5969343&buildTypeId=IgniteTests24Java8_RunAll] > Add additional update counter logging for detect causes of AssertionError: > LWM after HWM > > > Key: IGNITE-14565 > URL: https://issues.apache.org/jira/browse/IGNITE-14565 > Project: Ignite > Issue Type: Bug >Reporter: Maria Makedonskaya >Assignee: Maria Makedonskaya >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-14588) Calcite integration. Wrong processing of nested aggregates
[ https://issues.apache.org/jira/browse/IGNITE-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Plekhanov updated IGNITE-14588: --- Summary: Calcite integration. Wrong processing of nested aggregates (was: Calcite integration: Wrong processing of nested aggregates) > Calcite integration. Wrong processing of nested aggregates > -- > > Key: IGNITE-14588 > URL: https://issues.apache.org/jira/browse/IGNITE-14588 > Project: Ignite > Issue Type: Bug >Reporter: Aleksey Plekhanov >Assignee: Aleksey Plekhanov >Priority: Major > > The wrong plan is created when nested aggregates are used. > For example, this query: > {{SELECT avg(salary) FROM (SELECT avg(salary) as salary FROM employer UNION > ALL SELECT salary FROM employer)}} > Generates such a plan: > {noformat} > IgniteReduceHashAggregate(group=[{}], AVG(SALARY)=[AVG($0)]) > IgniteExchange(distribution=[single]) > IgniteMapHashAggregate(group=[{}], AVG(SALARY)=[AVG($0)]) > IgniteUnionAll(all=[true]) > IgniteSingleHashAggregate(group=[{}], SALARY=[AVG($0)]) > IgniteIndexScan(table=[[PUBLIC, EMPLOYER]], index=[_key_PK], > requiredColumns=[{3}]) > IgniteIndexScan(table=[[PUBLIC, EMPLOYER]], index=[_key_PK], > requiredColumns=[{3}]) > {noformat} > With this plan, in subquery data is aggregated locally on nodes and can > produce the wrong results. > For example: > {code:java} > @Test > public void aggregateNested() throws Exception { > String cacheName = "employer"; > IgniteCache employer = client.getOrCreateCache(new > CacheConfiguration() > .setName(cacheName) > .setSqlSchema("PUBLIC") > .setIndexedTypes(Integer.class, Employer.class) > .setBackups(2) > ); > awaitPartitionMapExchange(true, true, null); > List keysNode0 = primaryKeys(grid(0).cache(cacheName), 2); > List keysNode1 = primaryKeys(grid(1).cache(cacheName), 1); > employer.putAll(ImmutableMap.of( > keysNode0.get(0), new Employer("Igor", 1d), > keysNode0.get(1), new Employer("Roman", 2d) , > keysNode1.get(0), new Employer("Nikolay", 3d) > )); > QueryEngine engine = Commons.lookupComponent(grid(1).context(), > QueryEngine.class); > List>> qry = engine.query(null, "PUBLIC", > "SELECT avg(salary) FROM " + > "(SELECT avg(salary) as salary FROM employer UNION ALL SELECT > salary FROM employer)"); > assertEquals(1, qry.size()); > List> rows = qry.get(0).getAll(); > assertEquals(1, rows.size()); > assertEquals(2d, F.first(F.first(rows))); > } > {code} > With this reproducer we should get 2 as a result (avg(1, 2, 3) = 2, avg(2, 1, > 2, 3) = 2), but actual result is 2.1 (avg(1, 2) = 1.5, avg (3) = 3, avg(1.5, > 3, 1, 2, 3) = 2.1). > Root cause: default {{passThroughDistribution}} is not suitable for "reduce > aggregate" and "single aggregate" nodes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (IGNITE-14588) Calcite integration: Wrong processing of nested aggregates
Aleksey Plekhanov created IGNITE-14588: -- Summary: Calcite integration: Wrong processing of nested aggregates Key: IGNITE-14588 URL: https://issues.apache.org/jira/browse/IGNITE-14588 Project: Ignite Issue Type: Bug Reporter: Aleksey Plekhanov Assignee: Aleksey Plekhanov The wrong plan is created when nested aggregates are used. For example, this query: {{SELECT avg(salary) FROM (SELECT avg(salary) as salary FROM employer UNION ALL SELECT salary FROM employer)}} Generates such a plan: {noformat} IgniteReduceHashAggregate(group=[{}], AVG(SALARY)=[AVG($0)]) IgniteExchange(distribution=[single]) IgniteMapHashAggregate(group=[{}], AVG(SALARY)=[AVG($0)]) IgniteUnionAll(all=[true]) IgniteSingleHashAggregate(group=[{}], SALARY=[AVG($0)]) IgniteIndexScan(table=[[PUBLIC, EMPLOYER]], index=[_key_PK], requiredColumns=[{3}]) IgniteIndexScan(table=[[PUBLIC, EMPLOYER]], index=[_key_PK], requiredColumns=[{3}]) {noformat} With this plan, in subquery data is aggregated locally on nodes and can produce the wrong results. For example: {code:java} @Test public void aggregateNested() throws Exception { String cacheName = "employer"; IgniteCache employer = client.getOrCreateCache(new CacheConfiguration() .setName(cacheName) .setSqlSchema("PUBLIC") .setIndexedTypes(Integer.class, Employer.class) .setBackups(2) ); awaitPartitionMapExchange(true, true, null); List keysNode0 = primaryKeys(grid(0).cache(cacheName), 2); List keysNode1 = primaryKeys(grid(1).cache(cacheName), 1); employer.putAll(ImmutableMap.of( keysNode0.get(0), new Employer("Igor", 1d), keysNode0.get(1), new Employer("Roman", 2d) , keysNode1.get(0), new Employer("Nikolay", 3d) )); QueryEngine engine = Commons.lookupComponent(grid(1).context(), QueryEngine.class); List>> qry = engine.query(null, "PUBLIC", "SELECT avg(salary) FROM " + "(SELECT avg(salary) as salary FROM employer UNION ALL SELECT salary FROM employer)"); assertEquals(1, qry.size()); List> rows = qry.get(0).getAll(); assertEquals(1, rows.size()); assertEquals(2d, F.first(F.first(rows))); } {code} With this reproducer we should get 2 as a result (avg(1, 2, 3) = 2, avg(2, 1, 2, 3) = 2), but actual result is 2.1 (avg(1, 2) = 1.5, avg (3) = 3, avg(1.5, 3, 1, 2, 3) = 2.1). Root cause: default {{passThroughDistribution}} is not suitable for "reduce aggregate" and "single aggregate" nodes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-13029) Support Spring Data repositories initialization with Spring Boot auto-starter
[ https://issues.apache.org/jira/browse/IGNITE-13029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Chugunov updated IGNITE-13029: - Ignite Flags: Release Notes Required (was: Docs Required,Release Notes Required) > Support Spring Data repositories initialization with Spring Boot auto-starter > - > > Key: IGNITE-13029 > URL: https://issues.apache.org/jira/browse/IGNITE-13029 > Project: Ignite > Issue Type: Improvement > Components: spring, springdata >Affects Versions: 2.8 >Reporter: Denis A. Magda >Assignee: Sergey Dorozhkin >Priority: Major > Labels: newbie > Fix For: 2.11 > > > It's required to use {{@EnableIgniteRepositories}} annotation and follow this > procedure to enable Ignite Spring Data repositories: > https://apacheignite-mix.readme.io/docs/spring-data#spring-data-and-apache-ignite-configuration > Support the Spring Data repositories enablement via the Spring Boot > auto-starter if Spring Boot is used by a project: > https://apacheignite-mix.readme.io/docs/spring-boot -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-13029) Support Spring Data repositories initialization with Spring Boot auto-starter
[ https://issues.apache.org/jira/browse/IGNITE-13029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324807#comment-17324807 ] Sergey Chugunov commented on IGNITE-13029: -- [~stalkxt], TC results look good to me, I merged your patch to master branch in commit *7a26b06dbe7db240eb3021e224b94990325bff8a*. Thank you for contribution! > Support Spring Data repositories initialization with Spring Boot auto-starter > - > > Key: IGNITE-13029 > URL: https://issues.apache.org/jira/browse/IGNITE-13029 > Project: Ignite > Issue Type: Improvement > Components: spring, springdata >Affects Versions: 2.8 >Reporter: Denis A. Magda >Assignee: Sergey Dorozhkin >Priority: Major > Labels: newbie > Fix For: 2.11 > > > It's required to use {{@EnableIgniteRepositories}} annotation and follow this > procedure to enable Ignite Spring Data repositories: > https://apacheignite-mix.readme.io/docs/spring-data#spring-data-and-apache-ignite-configuration > Support the Spring Data repositories enablement via the Spring Boot > auto-starter if Spring Boot is used by a project: > https://apacheignite-mix.readme.io/docs/spring-boot -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-13029) Support Spring Data repositories initialization with Spring Boot auto-starter
[ https://issues.apache.org/jira/browse/IGNITE-13029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Chugunov updated IGNITE-13029: - Fix Version/s: 2.11 > Support Spring Data repositories initialization with Spring Boot auto-starter > - > > Key: IGNITE-13029 > URL: https://issues.apache.org/jira/browse/IGNITE-13029 > Project: Ignite > Issue Type: Improvement > Components: spring, springdata >Affects Versions: 2.8 >Reporter: Denis A. Magda >Assignee: Sergey Dorozhkin >Priority: Major > Labels: newbie > Fix For: 2.11 > > > It's required to use {{@EnableIgniteRepositories}} annotation and follow this > procedure to enable Ignite Spring Data repositories: > https://apacheignite-mix.readme.io/docs/spring-data#spring-data-and-apache-ignite-configuration > Support the Spring Data repositories enablement via the Spring Boot > auto-starter if Spring Boot is used by a project: > https://apacheignite-mix.readme.io/docs/spring-boot -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (IGNITE-14587) ServerImpl.resolveCoordinator returns daemon node as coordinator when daemon node is older then real coordinator
Rodion created IGNITE-14587: --- Summary: ServerImpl.resolveCoordinator returns daemon node as coordinator when daemon node is older then real coordinator Key: IGNITE-14587 URL: https://issues.apache.org/jira/browse/IGNITE-14587 Project: Ignite Issue Type: Bug Affects Versions: 2.9.1 Reporter: Rodion Assignee: Rodion Fix For: 2.9.2 Attachments: ServerImpl_resolveCoordinator_does_not_work_correctly_with_daemon_nodes.patch Scenario: * Start first server node. * Start daemon node * Start second server node * Stop first server node * Check coordinator (ServerImpl#resolveCoordinator and ExchangeLatchManager#getLatchCoordinator) ServerImpl#resolveCoordinator returns daemon node, ExchangeLatchManager#getLatchCoordinator - second server node. Patch with this scenario: [^ServerImpl_resolveCoordinator_does_not_work_correctly_with_daemon_nodes.patch] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14324) EVT_CLIENT_NODE_DISCONNECTED is not triggered in k8s
[ https://issues.apache.org/jira/browse/IGNITE-14324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324767#comment-17324767 ] Ivan Bessonov commented on IGNITE-14324: [~ashapkin] thank you for the fix! Looks good, I'll merge it. > EVT_CLIENT_NODE_DISCONNECTED is not triggered in k8s > > > Key: IGNITE-14324 > URL: https://issues.apache.org/jira/browse/IGNITE-14324 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.9.1 >Reporter: Alexandr Shapkin >Assignee: Alexandr Shapkin >Priority: Major > Labels: discovery > Fix For: 2.11 > > Time Spent: 10m > Remaining Estimate: 0h > > Scenario: > Kubernetes world, a server node, a k8s service, and a thick client. The > client is subscribed to EVT_CLIENT_NODE_DISCONNECTED event and is connected > to the server node. > When a service goes down alongside the server, no > EVT_CLIENT_NODE_DISCONNECTED is caught and the client reports only about a > socket exception and inability to resolve IP addresses from the services, > cause k8s resource is not available. The DEBUG logs (attached) show that > discovery is constantly trying to use KubernetesIpFinder and restore the > connection. > Expected: > Discovery realizes that a client is disconnected, no more reconnection > attempts happen and EVT_CLIENT_NODE_DISCONNECTED is thrown. > Solution: > Count resolution attempts and if it’s more than the threshold (2 if > failuredetectiontimeout is not configured, otherwise #reconnCount) give up > and invoke disconnection logic -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-14573) DML operations failure.
[ https://issues.apache.org/jira/browse/IGNITE-14573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324763#comment-17324763 ] Taras Ledkov commented on IGNITE-14573: --- [~zstan], I guess we have to change '{{!=}}' to SQL syntax '{{<>}}'. > DML operations failure. > --- > > Key: IGNITE-14573 > URL: https://issues.apache.org/jira/browse/IGNITE-14573 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Stanilovsky Evgeny >Assignee: Stanilovsky Evgeny >Priority: Major > Labels: calcite > Time Spent: 10m > Remaining Estimate: 0h > > As a result, insert with further read operations will fail. > For example: > {code:java} > CREATE TABLE IF NOT EXISTS test (id INTEGER, a INTEGER); > INSERT INTO test VALUES (1, 1), (2, 2), (3, 3), (4, NULL);" > UPDATE test SET a=CASE WHEN id=1 THEN 7 ELSE NULL END WHERE id <= 2"; > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)