[jira] [Commented] (IGNITE-14543) Calcite engine. Agregate functions fail on scalar values

2021-04-28 Thread Stanilovsky Evgeny (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17335150#comment-17335150
 ] 

Stanilovsky Evgeny commented on IGNITE-14543:
-

looks good.

> Calcite engine. Agregate functions fail on scalar values
> 
>
> Key: IGNITE-14543
> URL: https://issues.apache.org/jira/browse/IGNITE-14543
> Project: Ignite
>  Issue Type: Bug
>Reporter: Taras Ledkov
>Assignee: Konstantin Orlov
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Failed queries:
> {{SELECT COUNT(*)}}
> {{SELECT COUNT(NULL)}}
> {{SELECT AVG(NULL)}}
> Tests:
> {{aggregate/aggregates/test_count.test_ignored}}
> {{aggregate/aggregates/test_aggregate_types_scalar.test_ignore}}
> {{aggregate/aggregates/test_avg.test}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (IGNITE-14569) Create data structures system view

2021-04-28 Thread Ilya Kazakov (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ilya Kazakov updated IGNITE-14569:
--
Description: 
It will be good to have an api to list all created data structures: latches, 
atomics and so on. So it could be a system view.

There is system views for caches, for nodes, for continuous queries:  
https://ignite.apache.org/docs/latest/monitoring-metrics/system-views.

It needs a system views for data structures. In general, each data structure 
system view must have the same fields as the method arguments that creates the 
data structure.

For example system view for latches should have such fields:
  name - name of the latch
  initialCnt - count when latch was created (if this data is available)
  cnt - current latch count
  autoDel - does the latch automatically delete when its count reaches zero.

Queue system view:
  name - name of the queue
  capacity - capacity of the queue
  size - current size of the queue
Set system view:
  name - name of the set
  size - current size of the set
Atomics system view:
  name - name of the atomic
  initVal - initial value of the atomic
  currentVal - current value of the atomic
  type - SEQUENCE | LONG | REFERENCE 

  was:
It will be good to have an api to list all created data structures: latches, 
atomics and so on. So it could be a system view.

There is system views for caches, for nodes, for continuous queries. It needs a 
system view (or views) for data structures.


> Create data structures system view
> --
>
> Key: IGNITE-14569
> URL: https://issues.apache.org/jira/browse/IGNITE-14569
> Project: Ignite
>  Issue Type: Improvement
>  Components: data structures
>Affects Versions: 2.10
>Reporter: Ilya Kazakov
>Priority: Minor
>  Labels: newbie
>
> It will be good to have an api to list all created data structures: latches, 
> atomics and so on. So it could be a system view.
> There is system views for caches, for nodes, for continuous queries:  
> https://ignite.apache.org/docs/latest/monitoring-metrics/system-views.
> It needs a system views for data structures. In general, each data structure 
> system view must have the same fields as the method arguments that creates 
> the data structure.
> For example system view for latches should have such fields:
>   name - name of the latch
>   initialCnt - count when latch was created (if this data is available)
>   cnt - current latch count
>   autoDel - does the latch automatically delete when its count reaches zero.
> Queue system view:
>   name - name of the queue
>   capacity - capacity of the queue
>   size - current size of the queue
> Set system view:
>   name - name of the set
>   size - current size of the set
> Atomics system view:
>   name - name of the atomic
>   initVal - initial value of the atomic
>   currentVal - current value of the atomic
>   type - SEQUENCE | LONG | REFERENCE 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (IGNITE-14569) Create data structures system view

2021-04-28 Thread Ilya Kazakov (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ilya Kazakov updated IGNITE-14569:
--
Description: 
It will be good to have an api to list all created data structures: latches, 
atomics and so on. So it could be a system view.

There is system views for caches, for nodes, for continuous queries:  
[https://ignite.apache.org/docs/latest/monitoring-metrics/system-views].

It needs a system views for data structures. In general, each data structure 
system view must have the same fields as the method arguments that creates the 
data structure.

For example system view for *latches* should have such fields:
   name - name of the latch
   initialCnt - count when latch was created (if this data is available)
   cnt - current latch count
   autoDel - does the latch automatically delete when its count reaches zero.

*Queue system view:*
   name - name of the queue
   capacity - capacity of the queue
   size - current size of the queue
 
*Set system view:*
   name - name of the set
   size - current size of the set
 
*Atomics system view:*
   name - name of the atomic
   initVal - initial value of the atomic
   currentVal - current value of the atomic
   type - SEQUENCE | LONG | REFERENCE 

  was:
It will be good to have an api to list all created data structures: latches, 
atomics and so on. So it could be a system view.

There is system views for caches, for nodes, for continuous queries:  
https://ignite.apache.org/docs/latest/monitoring-metrics/system-views.

It needs a system views for data structures. In general, each data structure 
system view must have the same fields as the method arguments that creates the 
data structure.

For example system view for latches should have such fields:
  name - name of the latch
  initialCnt - count when latch was created (if this data is available)
  cnt - current latch count
  autoDel - does the latch automatically delete when its count reaches zero.

Queue system view:
  name - name of the queue
  capacity - capacity of the queue
  size - current size of the queue
Set system view:
  name - name of the set
  size - current size of the set
Atomics system view:
  name - name of the atomic
  initVal - initial value of the atomic
  currentVal - current value of the atomic
  type - SEQUENCE | LONG | REFERENCE 


> Create data structures system view
> --
>
> Key: IGNITE-14569
> URL: https://issues.apache.org/jira/browse/IGNITE-14569
> Project: Ignite
>  Issue Type: Improvement
>  Components: data structures
>Affects Versions: 2.10
>Reporter: Ilya Kazakov
>Priority: Minor
>  Labels: newbie
>
> It will be good to have an api to list all created data structures: latches, 
> atomics and so on. So it could be a system view.
> There is system views for caches, for nodes, for continuous queries:  
> [https://ignite.apache.org/docs/latest/monitoring-metrics/system-views].
> It needs a system views for data structures. In general, each data structure 
> system view must have the same fields as the method arguments that creates 
> the data structure.
> For example system view for *latches* should have such fields:
>    name - name of the latch
>    initialCnt - count when latch was created (if this data is available)
>    cnt - current latch count
>    autoDel - does the latch automatically delete when its count reaches zero.
> *Queue system view:*
>    name - name of the queue
>    capacity - capacity of the queue
>    size - current size of the queue
>  
> *Set system view:*
>    name - name of the set
>    size - current size of the set
>  
> *Atomics system view:*
>    name - name of the atomic
>    initVal - initial value of the atomic
>    currentVal - current value of the atomic
>    type - SEQUENCE | LONG | REFERENCE 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (IGNITE-7753) Processors are incorrectly initialized if a node joins during cluster activation

2021-04-28 Thread Stanislav Lukyanov (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-7753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stanislav Lukyanov reassigned IGNITE-7753:
--

Assignee: (was: Stanislav Lukyanov)

> Processors are incorrectly initialized if a node joins during cluster 
> activation
> 
>
> Key: IGNITE-7753
> URL: https://issues.apache.org/jira/browse/IGNITE-7753
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.3, 2.4, 2.5
>Reporter: Stanislav Lukyanov
>Priority: Major
>
> If a node joins during the cluster activation process (while the related 
> exchange operation is in progress), then some of the GridProcessor instances 
> of that node will be incorrectly initialized. While GridClusterStateProcessor 
> will correctly report the active cluster state, other processors that are 
> sensitive to the cluster state, e.g. GridServiceProcessor, will be not 
> initialized.
> A reproducer is below. 
> ===
> Ignite server = 
> IgnitionEx.start("examples/config/persistentstore/example-persistent-store.xml",
>  "server");
> CyclicBarrier barrier = new CyclicBarrier(2);
> Thread activationThread = new Thread(() -> {
> try {
> barrier.await();
> server.active(true);
> }
> catch (Exception e) {
> e.printStackTrace(); // TODO implement.
> }
> });
> activationThread.start();
> barrier.await();
> IgnitionEx.setClientMode(true);
> Ignite client = 
> IgnitionEx.start("examples/config/persistentstore/example-persistent-store.xml",
>  "client");
> activationThread.join();
> client.services().deployClusterSingleton("myClusterSingleton", new 
> SimpleMapServiceImpl<>());
> ===
> Here a single server node is started, then simultaneously a client node is 
> being started and the cluster is being activated, then client attempts to 
> deploy a service. As the result, the thread calling the deploy method hangs 
> forever with a stack trace like this:
> ===
> "main@1" prio=5 tid=0x1 nid=NA waiting
>   java.lang.Thread.State: WAITING
> at sun.misc.Unsafe.park(Unsafe.java:-1)
> at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836)
> at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedInterruptibly(AbstractQueuedSynchronizer.java:997)
> at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1304)
> at java.util.concurrent.CountDownLatch.await(CountDownLatch.java:231)
> at 
> org.apache.ignite.internal.util.IgniteUtils.awaitQuiet(IgniteUtils.java:7505)
> at 
> org.apache.ignite.internal.processors.service.GridServiceProcessor.serviceCache(GridServiceProcessor.java:290)
> at 
> org.apache.ignite.internal.processors.service.GridServiceProcessor.writeServiceToCache(GridServiceProcessor.java:728)
> at 
> org.apache.ignite.internal.processors.service.GridServiceProcessor.deployAll(GridServiceProcessor.java:634)
> at 
> org.apache.ignite.internal.processors.service.GridServiceProcessor.deployAll(GridServiceProcessor.java:600)
> at 
> org.apache.ignite.internal.processors.service.GridServiceProcessor.deployMultiple(GridServiceProcessor.java:488)
> at 
> org.apache.ignite.internal.processors.service.GridServiceProcessor.deployClusterSingleton(GridServiceProcessor.java:469)
> at 
> org.apache.ignite.internal.IgniteServicesImpl.deployClusterSingleton(IgniteServicesImpl.java:120)
> ===
> The behavior depends on the timings - the client has to join in the middle of 
> the activation's exchange process. Putting Thread.sleep(4000) into 
> GridDhtPartitionsExchangeFuture.onClusterStateChangeRequest seems to work on 
> a development laptop.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (IGNITE-7704) Document IgniteConfiguration, TcpDiscoverySpi, TcpCommunicationSpi timeouts and their relations

2021-04-28 Thread Stanislav Lukyanov (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-7704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stanislav Lukyanov reassigned IGNITE-7704:
--

Assignee: (was: Stanislav Lukyanov)

> Document IgniteConfiguration, TcpDiscoverySpi, TcpCommunicationSpi timeouts 
> and their relations
> ---
>
> Key: IGNITE-7704
> URL: https://issues.apache.org/jira/browse/IGNITE-7704
> Project: Ignite
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 2.3
>Reporter: Alexey Popov
>Priority: Major
> Fix For: 2.11
>
> Attachments: timeouts.md, timeouts_v2.md
>
>
> We often see similar questions related to IgniteConfiguration, 
> TcpDiscoverySpi, TcpCommunicationSpi timeouts and their relations. And we see 
> several side-effects after incorrect timeout configuration.
> It looks like this question is not well documented.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (IGNITE-14494) .NET: Problem with collection de/serialization

2021-04-28 Thread Yaroslav Molochkov (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yaroslav Molochkov resolved IGNITE-14494.
-
Resolution: Resolved

> .NET: Problem with collection de/serialization
> --
>
> Key: IGNITE-14494
> URL: https://issues.apache.org/jira/browse/IGNITE-14494
> Project: Ignite
>  Issue Type: Bug
>Reporter: Yaroslav Molochkov
>Priority: Major
> Attachments: UnitTest.cs
>
>
> Reproducer is attached. Basically the problem surfaces when you call 
> service's method via proxy. The method is supposed to return a collection 
> type result.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14655) .NET: Improve DataStreamer API

2021-04-28 Thread Igor Sapego (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334992#comment-17334992
 ] 

Igor Sapego commented on IGNITE-14655:
--

[~ptupitsyn] looks good to me. Find my comments in PR.

> .NET: Improve DataStreamer API
> --
>
> Key: IGNITE-14655
> URL: https://issues.apache.org/jira/browse/IGNITE-14655
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>Priority: Major
>  Labels: .NET
> Fix For: 2.11
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently, all {{AddData}} methods return a Task, however, this task is not 
> for an individual add/remove operation, but for the current batch.
> This is confusing: users often try to {{await}} the returned task, which is 
> natural; but the task will never complete, because the batch is not yet full, 
> and user code is stuck waiting.
> * Deprecate {{AddData}}, {{RemoveData}} methods
> * Add new {{void Add}} and {{void Remove}} methods
> * Add new {{BatchTask}} property to get the task for the current batch



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14610) BinaryBuilderReader doesn't supports reference (HANDLE) to collection

2021-04-28 Thread Konstantin Orlov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334935#comment-17334935
 ] 

Konstantin Orlov commented on IGNITE-14610:
---

[~tledkov-gridgain], the patch looks good to me.

> BinaryBuilderReader doesn't supports reference (HANDLE) to collection
> -
>
> Key: IGNITE-14610
> URL: https://issues.apache.org/jira/browse/IGNITE-14610
> Project: Ignite
>  Issue Type: Bug
>  Components: sql
>Affects Versions: 2.10
>Reporter: Taras Ledkov
>Assignee: Taras Ledkov
>Priority: Critical
> Fix For: 2.11
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> *Steps to reproduce:*
> 1. Create object with two objects collection fields, e.g. List
> 2. Assign the reference of the one field to the second.
> 3. Serialize object to BinaryObject
> 4. Create BinaryObjectBuiler from the object.
> 5. Add/change any field except collections.
> 6. Try to build new BinaryObject form the builer
> *Exception is thrown:*
> {code:java}
> class org.apache.ignite.binary.BinaryObjectException: Unsupported protocol 
> version: 2
>   at 
> org.apache.ignite.internal.binary.BinaryUtils.checkProtocolVersion(BinaryUtils.java:795)
>   at 
> org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl.(BinaryObjectBuilderImpl.java:139)
>   at 
> org.apache.ignite.internal.binary.builder.BinaryBuilderReader.parseValue(BinaryBuilderReader.java:522)
>   at 
> org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl.serializeTo(BinaryObjectBuilderImpl.java:286)
>   at 
> org.apache.ignite.internal.binary.builder.BinaryBuilderSerializer.writeValue(BinaryBuilderSerializer.java:100)
>   at 
> org.apache.ignite.internal.binary.builder.BinaryBuilderSerializer.writeValue(BinaryBuilderSerializer.java:53)
>   at 
> org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl.serializeTo(BinaryObjectBuilderImpl.java:293)
>   at 
> org.apache.ignite.internal.binary.builder.BinaryBuilderSerializer.writeValue(BinaryBuilderSerializer.java:100)
>   at 
> org.apache.ignite.internal.binary.builder.BinaryBuilderSerializer.writeValue(BinaryBuilderSerializer.java:53)
>   at 
> org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl.serializeTo(BinaryObjectBuilderImpl.java:293)
>   at 
> org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl.build(BinaryObjectBuilderImpl.java:188)
> {code}
> *Root cause:*
> BinaryBuilderReader#parseValue doesn’t support handle to collection. Only 
> handles to object are expected.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (IGNITE-14655) .NET: Improve DataStreamer API

2021-04-28 Thread Pavel Tupitsyn (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pavel Tupitsyn updated IGNITE-14655:

Summary: .NET: Improve DataStreamer API  (was: .NET: Do not return task 
from IDataStreamer.AddData method)

> .NET: Improve DataStreamer API
> --
>
> Key: IGNITE-14655
> URL: https://issues.apache.org/jira/browse/IGNITE-14655
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>Priority: Major
>  Labels: .NET
> Fix For: 2.11
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently, all {{AddData}} methods return a Task, however, this task is not 
> for an individual add/remove operation, but for the current batch.
> This is confusing: users often try to {{await}} the returned task, which is 
> natural; but the task will never complete, because the batch is not yet full, 
> and user code is stuck waiting.
> * Deprecate {{AddData}}, {{RemoveData}} methods
> * Add new {{void Add}} and {{void Remove}} methods
> * Add new {{BatchTask}} property to get the task for the current batch



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14610) BinaryBuilderReader doesn't supports reference (HANDLE) to collection

2021-04-28 Thread Ignite TC Bot (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334902#comment-17334902
 ] 

Ignite TC Bot commented on IGNITE-14610:


{panel:title=Branch: [pull/9057/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/9057/head] Base: [master] : New Tests 
(2)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#8b}Binary Objects{color} [[tests 
2|https://ci.ignite.apache.org/viewLog.html?buildId=5984965]]
* {color:#013220}IgniteBinaryObjectsTestSuite: 
BinaryMarshallerSelfTest.handleToCollection - PASSED{color}
* {color:#013220}IgniteBinaryObjectsTestSuite: 
BinaryMarshallerNonCompactSelfTest.handleToCollection - PASSED{color}

{panel}
[TeamCity *--> Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5985063&buildTypeId=IgniteTests24Java8_RunAll]

> BinaryBuilderReader doesn't supports reference (HANDLE) to collection
> -
>
> Key: IGNITE-14610
> URL: https://issues.apache.org/jira/browse/IGNITE-14610
> Project: Ignite
>  Issue Type: Bug
>  Components: sql
>Affects Versions: 2.10
>Reporter: Taras Ledkov
>Assignee: Taras Ledkov
>Priority: Critical
> Fix For: 2.11
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> *Steps to reproduce:*
> 1. Create object with two objects collection fields, e.g. List
> 2. Assign the reference of the one field to the second.
> 3. Serialize object to BinaryObject
> 4. Create BinaryObjectBuiler from the object.
> 5. Add/change any field except collections.
> 6. Try to build new BinaryObject form the builer
> *Exception is thrown:*
> {code:java}
> class org.apache.ignite.binary.BinaryObjectException: Unsupported protocol 
> version: 2
>   at 
> org.apache.ignite.internal.binary.BinaryUtils.checkProtocolVersion(BinaryUtils.java:795)
>   at 
> org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl.(BinaryObjectBuilderImpl.java:139)
>   at 
> org.apache.ignite.internal.binary.builder.BinaryBuilderReader.parseValue(BinaryBuilderReader.java:522)
>   at 
> org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl.serializeTo(BinaryObjectBuilderImpl.java:286)
>   at 
> org.apache.ignite.internal.binary.builder.BinaryBuilderSerializer.writeValue(BinaryBuilderSerializer.java:100)
>   at 
> org.apache.ignite.internal.binary.builder.BinaryBuilderSerializer.writeValue(BinaryBuilderSerializer.java:53)
>   at 
> org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl.serializeTo(BinaryObjectBuilderImpl.java:293)
>   at 
> org.apache.ignite.internal.binary.builder.BinaryBuilderSerializer.writeValue(BinaryBuilderSerializer.java:100)
>   at 
> org.apache.ignite.internal.binary.builder.BinaryBuilderSerializer.writeValue(BinaryBuilderSerializer.java:53)
>   at 
> org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl.serializeTo(BinaryObjectBuilderImpl.java:293)
>   at 
> org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl.build(BinaryObjectBuilderImpl.java:188)
> {code}
> *Root cause:*
> BinaryBuilderReader#parseValue doesn’t support handle to collection. Only 
> handles to object are expected.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14446) Implement DMS manager with watch registry

2021-04-28 Thread Alexey Scherbakov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334884#comment-17334884
 ] 

Alexey Scherbakov commented on IGNITE-14446:


[~kgusakov]

LGTM

> Implement DMS manager with watch registry
> -
>
> Key: IGNITE-14446
> URL: https://issues.apache.org/jira/browse/IGNITE-14446
> Project: Ignite
>  Issue Type: Sub-task
>Reporter: Kirill Gusakov
>Assignee: Kirill Gusakov
>Priority: Major
>  Labels: iep-73
>  Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14543) Calcite engine. Agregate functions fail on scalar values

2021-04-28 Thread Konstantin Orlov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334873#comment-17334873
 ] 

Konstantin Orlov commented on IGNITE-14543:
---

[~tledkov-gridgain], [~zstan], guys, do a review please

> Calcite engine. Agregate functions fail on scalar values
> 
>
> Key: IGNITE-14543
> URL: https://issues.apache.org/jira/browse/IGNITE-14543
> Project: Ignite
>  Issue Type: Bug
>Reporter: Taras Ledkov
>Assignee: Konstantin Orlov
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Failed queries:
> {{SELECT COUNT(*)}}
> {{SELECT COUNT(NULL)}}
> {{SELECT AVG(NULL)}}
> Tests:
> {{aggregate/aggregates/test_count.test_ignored}}
> {{aggregate/aggregates/test_aggregate_types_scalar.test_ignore}}
> {{aggregate/aggregates/test_avg.test}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (IGNITE-14667) Optimise WatchAggregator key criterion inference

2021-04-28 Thread Kirill Gusakov (Jira)
Kirill Gusakov created IGNITE-14667:
---

 Summary: Optimise WatchAggregator key criterion inference
 Key: IGNITE-14667
 URL: https://issues.apache.org/jira/browse/IGNITE-14667
 Project: Ignite
  Issue Type: Bug
Reporter: Kirill Gusakov


Now, MetaStorageManager is listening to the whole range of keys inferred from 
component watches key criteria. But in practice, it can be a rough strategy and 
if we have no prefix or range watches - we can infer the watch for collection 
of keys.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (IGNITE-14667) Optimise WatchAggregator key criterion inference

2021-04-28 Thread Kirill Gusakov (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirill Gusakov updated IGNITE-14667:

Issue Type: Task  (was: Bug)

> Optimise WatchAggregator key criterion inference
> 
>
> Key: IGNITE-14667
> URL: https://issues.apache.org/jira/browse/IGNITE-14667
> Project: Ignite
>  Issue Type: Task
>Reporter: Kirill Gusakov
>Priority: Major
>
> Now, MetaStorageManager is listening to the whole range of keys inferred from 
> component watches key criteria. But in practice, it can be a rough strategy 
> and if we have no prefix or range watches - we can infer the watch for 
> collection of keys.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (IGNITE-14543) Calcite engine. Agregate functions fail on scalar values

2021-04-28 Thread Konstantin Orlov (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konstantin Orlov reassigned IGNITE-14543:
-

Assignee: Konstantin Orlov

> Calcite engine. Agregate functions fail on scalar values
> 
>
> Key: IGNITE-14543
> URL: https://issues.apache.org/jira/browse/IGNITE-14543
> Project: Ignite
>  Issue Type: Bug
>Reporter: Taras Ledkov
>Assignee: Konstantin Orlov
>Priority: Major
>
> Failed queries:
> {{SELECT COUNT(*)}}
> {{SELECT COUNT(NULL)}}
> {{SELECT AVG(NULL)}}
> Tests:
> {{aggregate/aggregates/test_count.test_ignored}}
> {{aggregate/aggregates/test_aggregate_types_scalar.test_ignore}}
> {{aggregate/aggregates/test_avg.test}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14625) Make DurableBackgroundTask return future

2021-04-28 Thread Denis Chudov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334809#comment-17334809
 ] 

Denis Chudov commented on IGNITE-14625:
---

[~ktkale...@gridgain.com] I've left some minor comments in PR.

> Make DurableBackgroundTask return future
> 
>
> Key: IGNITE-14625
> URL: https://issues.apache.org/jira/browse/IGNITE-14625
> Project: Ignite
>  Issue Type: Improvement
>  Components: persistence
>Reporter: Kirill Tkalenko
>Assignee: Kirill Tkalenko
>Priority: Major
> Fix For: 2.11
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> While trying to implement rebuilding indexes on *DurableBackgroundTask*, I 
> encountered several problems:
> * For each task, a new thread is created, which can be critical for 
> rebuilding indexes, since there can be many caches and this can create many 
> threads;
> * Tasks can be completed close to the end of a checkpoint, and data may not 
> reach this checkpoint.
> Therefore, I propose to slightly rework the *DurableBackgroundTask*.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14655) .NET: Do not return task from IDataStreamer.AddData method

2021-04-28 Thread Ignite TC Bot (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334802#comment-17334802
 ] 

Ignite TC Bot commented on IGNITE-14655:


{panel:title=Branch: [pull/9058/head] Base: [master] : Possible Blockers 
(10)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Control Utility{color} [[tests 0 TIMEOUT , Exit Code 
|https://ci.ignite.apache.org/viewLog.html?buildId=5985728]]

{color:#d04437}Basic 1{color} [[tests 0 Exit Code 
|https://ci.ignite.apache.org/viewLog.html?buildId=5985674]]

{color:#d04437}Cache 6{color} [[tests 0 TIMEOUT , Exit Code 
|https://ci.ignite.apache.org/viewLog.html?buildId=5985695]]

{color:#d04437}Platform .NET (Core Linux){color} [[tests 1 TC_SERVICE_MESSAGE 
|https://ci.ignite.apache.org/viewLog.html?buildId=5985710]]
* dll: 
ContinuousQueryTest.TestIncludeExpiredIsFalseByDefaultAndExpiredEventsAreSkipped
 - Test has low fail rate in base branch 0,0% and is not flaky

{color:#d04437}Java Client{color} [[tests 0 TIMEOUT , Exit Code 
|https://ci.ignite.apache.org/viewLog.html?buildId=5985653]]

{color:#d04437}Cache 1{color} [[tests 1 TIMEOUT , Out Of Memory Error , Exit 
Code |https://ci.ignite.apache.org/viewLog.html?buildId=5985690]]
* IgniteBinaryCacheTestSuite: 
DataStreamProcessorPersistenceBinarySelfTest.testReplicatedIsolated - Test has 
low fail rate in base branch 0,0% and is not flaky

{color:#d04437}Platform C++ CMake (Win x64 / Release){color} [[tests 
1|https://ci.ignite.apache.org/viewLog.html?buildId=5985730]]
* IgniteCoreTest: ComputeTestSuite: IgniteCallAsyncLocalError - Test has low 
fail rate in base branch 0,0% and is not flaky

{color:#d04437}Platform C++ CMake (Linux Clang){color} [[tests 
1|https://ci.ignite.apache.org/viewLog.html?buildId=5985726]]
* IgniteCoreTest: ComputeTestSuite: IgniteRunRemoteError - Test has low fail 
rate in base branch 0,0% and is not flaky

{color:#d04437}Platform .NET (Inspections)*{color} [[tests 0 Failure on metric 
|https://ci.ignite.apache.org/viewLog.html?buildId=5985711]]

{panel}
{panel:title=Branch: [pull/9058/head] Base: [master] : New Tests 
(13)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#8b}Platform .NET (Core Linux){color} [[tests 
7|https://ci.ignite.apache.org/viewLog.html?buildId=5985710]]
* {color:#013220}dll: DataStreamerTest.TestDestroyCacheObsolete - PASSED{color}
* {color:#013220}dll: DataStreamerTest.TestFlushAsync - PASSED{color}
* {color:#013220}dll: DataStreamerTest.TestAutoFlushObsolete - PASSED{color}
* {color:#013220}dll: DataStreamerTest.TestDestroyCache - PASSED{color}
* {color:#013220}dll: DataStreamerTest.TestStreamerAsyncAwait - PASSED{color}
* {color:#013220}dll: DataStreamerTest.TestTryFlushObsolete - PASSED{color}
* {color:#013220}dll: DataStreamerTest.TestAddRemoveObsolete - PASSED{color}

{color:#8b}Platform .NET{color} [[tests 
6|https://ci.ignite.apache.org/viewLog.html?buildId=5985709]]
* {color:#013220}exe: DataStreamerTest.TestFlushAsync - PASSED{color}
* {color:#013220}exe: DataStreamerTest.TestTryFlushObsolete - PASSED{color}
* {color:#013220}exe: DataStreamerTest.TestDestroyCache - PASSED{color}
* {color:#013220}exe: DataStreamerTest.TestDestroyCacheObsolete - PASSED{color}
* {color:#013220}exe: DataStreamerTest.TestAddRemoveObsolete - PASSED{color}
* {color:#013220}exe: DataStreamerTest.TestAutoFlushObsolete - PASSED{color}

{panel}
[TeamCity *--> Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5985736&buildTypeId=IgniteTests24Java8_RunAll]

> .NET: Do not return task from IDataStreamer.AddData method
> --
>
> Key: IGNITE-14655
> URL: https://issues.apache.org/jira/browse/IGNITE-14655
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>Priority: Major
>  Labels: .NET
> Fix For: 2.11
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently, all {{AddData}} methods return a Task, however, this task is not 
> for an individual add/remove operation, but for the current batch.
> This is confusing: users often try to {{await}} the returned task, which is 
> natural; but the task will never complete, because the batch is not yet full, 
> and user code is stuck waiting.
> * Deprecate {{AddData}}, {{RemoveData}} methods
> * Add new {{void Add}} and {{void Remove}} methods
> * Add new {{BatchTask}} property to get the task for the current batch



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14238) Creating and destroying tables

2021-04-28 Thread Vladislav Pyatkov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334765#comment-17334765
 ] 

Vladislav Pyatkov commented on IGNITE-14238:


[~alapin] Please, look at the patch.

> Creating and destroying tables
> --
>
> Key: IGNITE-14238
> URL: https://issues.apache.org/jira/browse/IGNITE-14238
> Project: Ignite
>  Issue Type: Sub-task
>Reporter: Vyacheslav Koptilin
>Assignee: Vladislav Pyatkov
>Priority: Major
>  Labels: iep-72, ignite-3
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Need to implement a new cluster-wide procedure that will be responsible for 
> creating and destroying caches.
> [1] 
> https://cwiki.apache.org/confluence/display/IGNITE/IEP-54%3A+Schema-first+Approach



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (IGNITE-14392) Remove the SQL Transactions page from Apache Ignite docs

2021-04-28 Thread Igor Gusev (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Gusev reassigned IGNITE-14392:
---

Assignee: Igor Gusev  (was: Nikita Safonov)

> Remove the SQL Transactions page from Apache Ignite docs
> 
>
> Key: IGNITE-14392
> URL: https://issues.apache.org/jira/browse/IGNITE-14392
> Project: Ignite
>  Issue Type: Improvement
>  Components: documentation
>Reporter: Nikita Safonov
>Assignee: Igor Gusev
>Priority: Major
>
> The page: 
> [https://ignite.apache.org/docs/latest/SQL/sql-transactions|https://www.gridgain.com/docs/latest/developers-guide/SQL/sql-transactions]
>  * We should remove it from the menu (toc.yaml)
>  * We should make sure it's not indexed by Google -> need to update robot.txt 
>  * We should check references to this page from other pages. The references 
> do exist.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (IGNITE-14666) Add proper listener handling in DistributedConfigurationStorage and LocalConfigurationStorage

2021-04-28 Thread Mirza Aliev (Jira)
Mirza Aliev created IGNITE-14666:


 Summary: Add proper listener handling in 
DistributedConfigurationStorage and LocalConfigurationStorage
 Key: IGNITE-14666
 URL: https://issues.apache.org/jira/browse/IGNITE-14666
 Project: Ignite
  Issue Type: Task
Reporter: Mirza Aliev
Assignee: Mirza Aliev






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (IGNITE-14665) Security test suite runs no tests after CI test suite checker

2021-04-28 Thread Ilya Kasnacheev (Jira)
Ilya Kasnacheev created IGNITE-14665:


 Summary: Security test suite runs no tests after CI test suite 
checker
 Key: IGNITE-14665
 URL: https://issues.apache.org/jira/browse/IGNITE-14665
 Project: Ignite
  Issue Type: Bug
  Components: general
Reporter: Ilya Kasnacheev
Assignee: Maksim Timonin


Please see linked development list thread as well as suite
https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_Security?mode=builds

All runs end with:
{code}
  [INFO] ---
  [INFO]  T E S T S
  [INFO] ---
  [WARNING] ForkStarter IOException: 
org.apache.maven.surefire.util.internal.StringUtils.unescapeString(Ljava/lang/StringBuilder;Ljava/lang/CharSequence;)V

org.apache.maven.surefire.util.internal.StringUtils.unescapeBytes(Ljava/lang/String;Ljava/lang/String;)Ljava/nio/ByteBuffer;
  
org.apache.maven.surefire.util.internal.StringUtils.unescapeString(Ljava/lang/StringBuilder;Ljava/lang/CharSequence;)V
  
org.apache.maven.surefire.util.internal.StringUtils.unescapeString(Ljava/lang/StringBuilder;Ljava/lang/CharSequence;)V.
 See the dump file 
/opt/buildagent/work/7bc1c54bc719b67c/modules/core/target/surefire-reports/2021-04-28T14-22-01_678-jvmRun1.dumpstream
  [INFO]
  [INFO] Results:
  [INFO]
  [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
  [INFO]
{code}

After bisecting, this is the offender:
{code}
commit 62cc45861c0273286e00eb6fbc510c0bb5589e52
Author: Maksim Timonin 
Date:   Fri Feb 5 19:10:18 2021 +0300

IGNITE-13512 Add travis check that tests are not in suites - Fixes #8367.

Signed-off-by: Ilya Kasnacheev 
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14525) Empty page in docs

2021-04-28 Thread Igor Gusev (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334708#comment-17334708
 ] 

Igor Gusev commented on IGNITE-14525:
-

[~dma...@apache.org] can you review? This page does not exist in TOC, so we can 
safely remove it.

> Empty page in docs
> --
>
> Key: IGNITE-14525
> URL: https://issues.apache.org/jira/browse/IGNITE-14525
> Project: Ignite
>  Issue Type: Improvement
>  Components: documentation
>Reporter: Igor Gusev
>Assignee: Igor Gusev
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> [https://ignite.apache.org/docs/latest/installation/] page is empty. There 
> should be some introduction in it, or no page at all.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14662) Update dependency artifactId in spring-data extension documentation.

2021-04-28 Thread Mikhail Petrov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334696#comment-17334696
 ] 

Mikhail Petrov commented on IGNITE-14662:
-

[~NSAmelchev] Thanks for the review.

> Update dependency artifactId in spring-data extension documentation.
> 
>
> Key: IGNITE-14662
> URL: https://issues.apache.org/jira/browse/IGNITE-14662
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Mikhail Petrov
>Assignee: Mikhail Petrov
>Priority: Major
> Fix For: 2.11
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> It is needed to change artifactId for spring-data extension in documentation 
> from ignite-spring-data_2.2-ext to ignite-spring-data-2.2-ext.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (IGNITE-14525) Empty page in docs

2021-04-28 Thread Igor Gusev (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Gusev reassigned IGNITE-14525:
---

Assignee: Igor Gusev

> Empty page in docs
> --
>
> Key: IGNITE-14525
> URL: https://issues.apache.org/jira/browse/IGNITE-14525
> Project: Ignite
>  Issue Type: Improvement
>  Components: documentation
>Reporter: Igor Gusev
>Assignee: Igor Gusev
>Priority: Major
>
> [https://ignite.apache.org/docs/latest/installation/] page is empty. There 
> should be some introduction in it, or no page at all.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (IGNITE-14623) Calcite. Sort out test scripts at: sql/aggregate/aggregates/*

2021-04-28 Thread Taras Ledkov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334682#comment-17334682
 ] 

Taras Ledkov edited comment on IGNITE-14623 at 4/28/21, 11:59 AM:
--

Merged to 
[sql-calcite|https://github.com/apache/ignite/commit/5a19f9cbf0cfcf8f8727ac7a65758f6d305f06c5]


was (Author: tledkov-gridgain):
Merged to 
[sql=calcite|https://github.com/apache/ignite/commit/5a19f9cbf0cfcf8f8727ac7a65758f6d305f06c5]

> Calcite. Sort out test scripts at: sql/aggregate/aggregates/*
> -
>
> Key: IGNITE-14623
> URL: https://issues.apache.org/jira/browse/IGNITE-14623
> Project: Ignite
>  Issue Type: Task
>Reporter: Taras Ledkov
>Assignee: Taras Ledkov
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Calcite. Sort out test scripts at: {{sql/aggregate/aggregates/*}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14612) Calcite. SELECT with CASE without boolean expression - fails.

2021-04-28 Thread Konstantin Orlov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334677#comment-17334677
 ] 

Konstantin Orlov commented on IGNITE-14612:
---

[~zstan], the patch looks good to me.

> Calcite. SELECT with CASE without boolean expression - fails.
> -
>
> Key: IGNITE-14612
> URL: https://issues.apache.org/jira/browse/IGNITE-14612
> Project: Ignite
>  Issue Type: Bug
>  Components: sql
>Reporter: Stanilovsky Evgeny
>Assignee: Stanilovsky Evgeny
>Priority: Major
>  Labels: calcite
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> For example such expression - fails.
> {noformat}
> SELECT CASE WHEN 1 THEN 13 ELSE 12 END;{noformat}
> failed with:
> {code:java}
> class org.apache.ignite.IgniteException: Error at: 
> test_constant_comparisons.test:91. sql: SELECT CASE WHEN 1 THEN 13 ELSE 12 
> END;
>   at 
> org.apache.ignite.internal.processors.query.calcite.logical.SqlScriptRunner$Query.execute(SqlScriptRunner.java:518)
>   at 
> org.apache.ignite.internal.processors.query.calcite.logical.SqlScriptRunner.run(SqlScriptRunner.java:93)
>   at 
> org.apache.ignite.internal.processors.query.calcite.logical.ScriptTestRunner$1.run(ScriptTestRunner.java:214)
>   at java.lang.Thread.run(Thread.java:748)
> Caused by: class 
> org.apache.ignite.internal.processors.query.IgniteSQLException: Failed to 
> plan query.
>   at 
> org.apache.ignite.internal.processors.query.calcite.exec.ExecutionServiceImpl.prepareQuery(ExecutionServiceImpl.java:541)
>   at 
> org.apache.ignite.internal.processors.query.calcite.prepare.QueryPlanCacheImpl.queryPlan(QueryPlanCacheImpl.java:84)
>   at 
> org.apache.ignite.internal.processors.query.calcite.exec.ExecutionServiceImpl.executeQuery(ExecutionServiceImpl.java:398)
>   at 
> org.apache.ignite.internal.processors.query.calcite.CalciteQueryProcessor.query(CalciteQueryProcessor.java:246)
>   at 
> org.apache.ignite.internal.processors.query.calcite.logical.SqlScriptRunner.sql(SqlScriptRunner.java:111)
>   at 
> org.apache.ignite.internal.processors.query.calcite.logical.SqlScriptRunner.access$600(SqlScriptRunner.java:51)
>   at 
> org.apache.ignite.internal.processors.query.calcite.logical.SqlScriptRunner$Query.execute(SqlScriptRunner.java:513)
>   ... 3 more
> Caused by: org.apache.calcite.runtime.CalciteContextException: From line 1, 
> column 8 to line 1, column 38: Expected a boolean type
>   at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>   at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
>   at 
> org.apache.calcite.runtime.Resources$ExInstWithCause.ex(Resources.java:467)
>   at org.apache.calcite.sql.SqlUtil.newContextException(SqlUtil.java:883)
> {code}
> and this work perfectly well:
> {noformat}
> SELECT CASE WHEN 1=1 THEN 13 ELSE 12 END;{noformat}
> a little reserch shows that calcite also fails in non boolean expression, 
> root cause in 
> SqlCaseOperator#checkOperandTypes and further check : 
> {code:java}
> if (!SqlTypeUtil.inBooleanFamily(type){code} if we change this place, 
> appropriate test
> {noformat}
>   @Test void testCaseWhen2() {
> checkPlanEquals("SELECT CASE WHEN 1 THEN 13 ELSE 12 END");
>   }{noformat}
> will work fine in calcite but will fail in ignite with janino error:
> {noformat}
> class org.apache.ignite.IgniteException: Line 3, Column 7: Not a boolean 
> expression
>   at 
> org.apache.ignite.internal.processors.query.calcite.util.Commons.compile(Commons.java:299)
>   at 
> org.apache.ignite.internal.processors.query.calcite.exec.exp.ExpressionFactoryImpl.compile(ExpressionFactoryImpl.java:290)
>   at 
> org.apache.ignite.internal.processors.query.calcite.exec.exp.ExpressionFactoryImpl.lambda$scalar$4(ExpressionFactoryImpl.java:241)
>   at 
> java.util.concurrent.ConcurrentMap.computeIfAbsent(ConcurrentMap.java:324)
>   at 
> org.apache.ignite.internal.processors.query.calcite.exec.exp.ExpressionFactoryImpl.scalar(ExpressionFactoryImpl.java:241)
>   at 
> org.apache.ignite.internal.processors.query.calcite.exec.exp.ExpressionFactoryImpl.project(ExpressionFactoryImpl.java:198)
>   at 
> org.apache.ignite.internal.processors.query.calcite.exec.LogicalRelImplementor.visit(LogicalRelImplementor.java:195)
>   at 
> org.apache.ignite.internal.processors.query.calcite.exec.LogicalRelImplementor.visit(LogicalRelImplementor.java:102)
>   at 
> org.apache.ignite.internal.processors.query.calcite.rel.IgniteProj

[jira] [Updated] (IGNITE-14612) Calcite. SELECT with CASE without boolean expression - fails.

2021-04-28 Thread Stanilovsky Evgeny (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stanilovsky Evgeny updated IGNITE-14612:

Description: 
For example such expression - fails.
{noformat}
SELECT CASE WHEN 1 THEN 13 ELSE 12 END;{noformat}

failed with:

{code:java}
class org.apache.ignite.IgniteException: Error at: 
test_constant_comparisons.test:91. sql: SELECT CASE WHEN 1 THEN 13 ELSE 12 END;

at 
org.apache.ignite.internal.processors.query.calcite.logical.SqlScriptRunner$Query.execute(SqlScriptRunner.java:518)
at 
org.apache.ignite.internal.processors.query.calcite.logical.SqlScriptRunner.run(SqlScriptRunner.java:93)
at 
org.apache.ignite.internal.processors.query.calcite.logical.ScriptTestRunner$1.run(ScriptTestRunner.java:214)
at java.lang.Thread.run(Thread.java:748)
Caused by: class 
org.apache.ignite.internal.processors.query.IgniteSQLException: Failed to plan 
query.
at 
org.apache.ignite.internal.processors.query.calcite.exec.ExecutionServiceImpl.prepareQuery(ExecutionServiceImpl.java:541)
at 
org.apache.ignite.internal.processors.query.calcite.prepare.QueryPlanCacheImpl.queryPlan(QueryPlanCacheImpl.java:84)
at 
org.apache.ignite.internal.processors.query.calcite.exec.ExecutionServiceImpl.executeQuery(ExecutionServiceImpl.java:398)
at 
org.apache.ignite.internal.processors.query.calcite.CalciteQueryProcessor.query(CalciteQueryProcessor.java:246)
at 
org.apache.ignite.internal.processors.query.calcite.logical.SqlScriptRunner.sql(SqlScriptRunner.java:111)
at 
org.apache.ignite.internal.processors.query.calcite.logical.SqlScriptRunner.access$600(SqlScriptRunner.java:51)
at 
org.apache.ignite.internal.processors.query.calcite.logical.SqlScriptRunner$Query.execute(SqlScriptRunner.java:513)
... 3 more
Caused by: org.apache.calcite.runtime.CalciteContextException: From line 1, 
column 8 to line 1, column 38: Expected a boolean type
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at 
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at 
org.apache.calcite.runtime.Resources$ExInstWithCause.ex(Resources.java:467)
at org.apache.calcite.sql.SqlUtil.newContextException(SqlUtil.java:883)
{code}

and this work perfectly well:
{noformat}
SELECT CASE WHEN 1=1 THEN 13 ELSE 12 END;{noformat}

a little reserch shows that calcite also fails in non boolean expression, root 
cause in 
SqlCaseOperator#checkOperandTypes and further check : 
{code:java}
if (!SqlTypeUtil.inBooleanFamily(type){code} if we change this place, 
appropriate test

{noformat}
  @Test void testCaseWhen2() {
checkPlanEquals("SELECT CASE WHEN 1 THEN 13 ELSE 12 END");
  }{noformat}
will work fine in calcite but will fail in ignite with janino error:

{noformat}
class org.apache.ignite.IgniteException: Line 3, Column 7: Not a boolean 
expression

at 
org.apache.ignite.internal.processors.query.calcite.util.Commons.compile(Commons.java:299)
at 
org.apache.ignite.internal.processors.query.calcite.exec.exp.ExpressionFactoryImpl.compile(ExpressionFactoryImpl.java:290)
at 
org.apache.ignite.internal.processors.query.calcite.exec.exp.ExpressionFactoryImpl.lambda$scalar$4(ExpressionFactoryImpl.java:241)
at 
java.util.concurrent.ConcurrentMap.computeIfAbsent(ConcurrentMap.java:324)
at 
org.apache.ignite.internal.processors.query.calcite.exec.exp.ExpressionFactoryImpl.scalar(ExpressionFactoryImpl.java:241)
at 
org.apache.ignite.internal.processors.query.calcite.exec.exp.ExpressionFactoryImpl.project(ExpressionFactoryImpl.java:198)
at 
org.apache.ignite.internal.processors.query.calcite.exec.LogicalRelImplementor.visit(LogicalRelImplementor.java:195)
at 
org.apache.ignite.internal.processors.query.calcite.exec.LogicalRelImplementor.visit(LogicalRelImplementor.java:102)
at 
org.apache.ignite.internal.processors.query.calcite.rel.IgniteProject.accept(IgniteProject.java:89)
at 
org.apache.ignite.internal.processors.query.calcite.exec.LogicalRelImplementor.visit(LogicalRelImplementor.java:615)
at 
org.apache.ignite.internal.processors.query.calcite.exec.LogicalRelImplementor.go(LogicalRelImplementor.java:630)
at 
org.apache.ignite.internal.processors.query.calcite.exec.ExecutionServiceImpl.executeQuery(ExecutionServiceImpl.java:752)
at 
org.apache.ignite.internal.processors.query.calcite.exec.ExecutionServiceImpl.executePlan(ExecutionServiceImpl.java:692)
at 
org.apache.ignite.internal.processors.query.calcite.exec.ExecutionServiceImpl.executePlans(ExecutionServiceImpl.java:418)

[jira] [Assigned] (IGNITE-8731) .NET: intermittent failures in DataStreamerTest.TestFinalizer test

2021-04-28 Thread Pavel Tupitsyn (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-8731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pavel Tupitsyn reassigned IGNITE-8731:
--

Assignee: Pavel Tupitsyn

> .NET: intermittent failures in DataStreamerTest.TestFinalizer test
> --
>
> Key: IGNITE-8731
> URL: https://issues.apache.org/jira/browse/IGNITE-8731
> Project: Ignite
>  Issue Type: Task
>  Components: platforms
>Affects Versions: 2.5
>Reporter: Vladimir Ozerov
>Assignee: Pavel Tupitsyn
>Priority: Major
>  Labels: MakeTeamcityGreenAgain
>
> {{DataStreamerTest.TsetFinalizer}} constantly fails on some TC agents, while 
> work OK on others. Most likely we have an environmental issue.
> OK:
> # publicagent01_03_9090
> # publicagent02_02_9090
> Not OK:
> # publicagent01_01_9090
> # publicagent01_02_9090
> # publicagent02_01_9090
> # publicagent02_03_9090
> Quick comparison of agent's configuration reveals only one difference - 
> version of PowerShell. On "good" machines it is {{5.1.16299.15}}, on "bad" 
> machines it is {{5.1.17134.1}}.
> PowerShell is essential part of build infrastructure so chances that some 
> incorrect dependencies are linked at some point. I am not sure that this 
> might be the root cause of failures, but at the very least we can try.
> Let's downgrade PowerShell on one of affected machines and see if it works.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (IGNITE-14664) Implement MetaStorageService and corresponding raft commands.

2021-04-28 Thread Alexander Lapin (Jira)
Alexander Lapin created IGNITE-14664:


 Summary: Implement MetaStorageService and corresponding raft 
commands.
 Key: IGNITE-14664
 URL: https://issues.apache.org/jira/browse/IGNITE-14664
 Project: Ignite
  Issue Type: Improvement
Reporter: Alexander Lapin
Assignee: Alexander Lapin


MetaStorageService should start RaftGroupClientService and propagate 
corresponding operations as RaftCommands to MetaStorageRaftGroup. As naive 
implementation it's possible to use cursor related commands such as hasNext, 
next and close that will contain cursor id.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14661) Broken validation of parts of compound PK

2021-04-28 Thread Ignite TC Bot (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334649#comment-17334649
 ] 

Ignite TC Bot commented on IGNITE-14661:


{panel:title=Branch: [pull/9053/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/9053/head] Base: [master] : New Tests 
(2)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#8b}Queries 1{color} [[tests 
2|https://ci.ignite.apache.org/viewLog.html?buildId=5984566]]
* {color:#013220}IgniteBinaryCacheQueryTestSuite: 
IgniteCacheSqlInsertValidationSelfTest.testValidationSkippedForRawKeyVal - 
PASSED{color}
* {color:#013220}IgniteBinaryCacheQueryTestSuite: 
IgniteCacheSqlInsertValidationSelfTest.testValidationOfCompoundKey - 
PASSED{color}

{panel}
[TeamCity *--> Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5984587&buildTypeId=IgniteTests24Java8_RunAll]

> Broken validation of parts of compound PK
> -
>
> Key: IGNITE-14661
> URL: https://issues.apache.org/jira/browse/IGNITE-14661
> Project: Ignite
>  Issue Type: Bug
>Reporter: Konstantin Orlov
>Assignee: Konstantin Orlov
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently it's possible to set {{null}} to column that is part of compound PK 
> even if this field was declared as {{NOT NULL}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (IGNITE-14406) Define interface for Vault

2021-04-28 Thread Mirza Aliev (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mirza Aliev resolved IGNITE-14406.
--
Resolution: Done

Interface was merged in https://issues.apache.org/jira/browse/IGNITE-14407

> Define interface for Vault
> --
>
> Key: IGNITE-14406
> URL: https://issues.apache.org/jira/browse/IGNITE-14406
> Project: Ignite
>  Issue Type: Sub-task
>Reporter: Vyacheslav Koptilin
>Assignee: Mirza Aliev
>Priority: Major
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Need to provide a simple API that can be easily used and takes into account 
> types of properties: user-level properties, system-level, system-level 
> properties that require appliedRevision.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14623) Calcite. Sort out test scripts at: sql/aggregate/aggregates/*

2021-04-28 Thread Konstantin Orlov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334624#comment-17334624
 ] 

Konstantin Orlov commented on IGNITE-14623:
---

[~tledkov-gridgain], LGTM!

> Calcite. Sort out test scripts at: sql/aggregate/aggregates/*
> -
>
> Key: IGNITE-14623
> URL: https://issues.apache.org/jira/browse/IGNITE-14623
> Project: Ignite
>  Issue Type: Task
>Reporter: Taras Ledkov
>Assignee: Taras Ledkov
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Calcite. Sort out test scripts at: {{sql/aggregate/aggregates/*}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14660) Flaky test GridSubqueryJoinOptimizerSelfTest#testOptimizationAppliedToUnion

2021-04-28 Thread Ignite TC Bot (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334588#comment-17334588
 ] 

Ignite TC Bot commented on IGNITE-14660:


{panel:title=Branch: [pull/9052/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/9052/head] Base: [master] : No new tests 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}{panel}
[TeamCity *--> Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5984484&buildTypeId=IgniteTests24Java8_RunAll]

> Flaky test GridSubqueryJoinOptimizerSelfTest#testOptimizationAppliedToUnion
> ---
>
> Key: IGNITE-14660
> URL: https://issues.apache.org/jira/browse/IGNITE-14660
> Project: Ignite
>  Issue Type: Bug
>  Components: sql
>Reporter: Konstantin Orlov
>Assignee: Konstantin Orlov
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently 
> {{GridSubqueryJoinOptimizerSelfTest#testOptimizationAppliedToUnion}} could 
> fail because of lack of result sorting.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14661) Broken validation of parts of compound PK

2021-04-28 Thread Yury Gerzhedovich (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334535#comment-17334535
 ] 

Yury Gerzhedovich commented on IGNITE-14661:


[~korlov], LGTM

> Broken validation of parts of compound PK
> -
>
> Key: IGNITE-14661
> URL: https://issues.apache.org/jira/browse/IGNITE-14661
> Project: Ignite
>  Issue Type: Bug
>Reporter: Konstantin Orlov
>Assignee: Konstantin Orlov
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently it's possible to set {{null}} to column that is part of compound PK 
> even if this field was declared as {{NOT NULL}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14044) Cache with node filter is not destroyed properly on the filtered node.

2021-04-28 Thread Vyacheslav Koptilin (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334512#comment-17334512
 ] 

Vyacheslav Koptilin commented on IGNITE-14044:
--

Hello [~xtern],

I will take a look.

> Cache with node filter is not destroyed properly on the filtered node.
> --
>
> Key: IGNITE-14044
> URL: https://issues.apache.org/jira/browse/IGNITE-14044
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.10
>Reporter: Pavel Pereslegin
>Assignee: Pavel Pereslegin
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Steps to reproduce the problem:
>  # Start 2 nodes
>  # Create a cache with node filter (filter second node)
>  # Destroy cache
>  # Restart nodes
> Expected: cache was destroyed on both nodes.
>  Actual: cache was destroyed only on one node, the second node cannot join 
> the cluster with the following error:
> {noformat}
> Caused by: class org.apache.ignite.spi.IgniteSpiException: Joining node has 
> caches with data which are not presented on cluster, it could mean that they 
> were already destroyed, to add the node to cluster - remove directories with 
> the caches[cache1]
>   at 
> org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi.checkFailedError(TcpDiscoverySpi.java:2052)
>   at 
> org.apache.ignite.spi.discovery.tcp.ServerImpl.joinTopology(ServerImpl.java:1197)
>   at 
> org.apache.ignite.spi.discovery.tcp.ServerImpl.spiStart(ServerImpl.java:472)
>   at 
> org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi.spiStart(TcpDiscoverySpi.java:2154)
>   at 
> org.apache.ignite.internal.managers.GridManagerAdapter.startSpi(GridManagerAdapter.java:278)
>   ... 23 more
> {noformat}
> Reproducer
> {code:java}
> public class IgnitePdsDestroyCacheWithNodeFilterTest extends 
> GridCommonAbstractTest {
> @Override protected IgniteConfiguration getConfiguration(String 
> igniteInstanceName) throws Exception {
> return super.getConfiguration(igniteInstanceName)
> .setConsistentId(igniteInstanceName)
> .setDataStorageConfiguration(new DataStorageConfiguration()
> .setDefaultDataRegionConfiguration(new DataRegionConfiguration()
> .setPersistenceEnabled(true)));
> }
> @Test
> public void testDestroyCacheWithNodeFilter() throws Exception {
> cleanPersistenceDir();
> Ignite ignite = startGrids(2);
> ignite.cluster().state(ClusterState.ACTIVE);
> UUID nodeId0 = ignite.cluster().localNode().id();
> CacheConfiguration cfg1 = new 
> CacheConfiguration<>("cache1")
> .setCacheMode(CacheMode.REPLICATED)
> .setNodeFilter(n -> nodeId0.equals(n.id()));
> IgniteCache cache1 = ignite.createCache(cfg1);
> cache1.destroy();
> forceCheckpoint();
> awaitPartitionMapExchange();
> stopAllGrids();
> ignite = startGrids(2); // failing here
> ignite.cluster().state(ClusterState.ACTIVE);
> }
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (IGNITE-14662) Update dependency artifactId in spring-data extension documentation.

2021-04-28 Thread Amelchev Nikita (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amelchev Nikita updated IGNITE-14662:
-
Ignite Flags:   (was: Docs Required,Release Notes Required)

> Update dependency artifactId in spring-data extension documentation.
> 
>
> Key: IGNITE-14662
> URL: https://issues.apache.org/jira/browse/IGNITE-14662
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Mikhail Petrov
>Assignee: Mikhail Petrov
>Priority: Major
> Fix For: 2.11
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> It is needed to change artifactId for spring-data extension in documentation 
> from ignite-spring-data_2.2-ext to ignite-spring-data-2.2-ext.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (IGNITE-14662) Update dependency artifactId in spring-data extension documentation.

2021-04-28 Thread Amelchev Nikita (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amelchev Nikita updated IGNITE-14662:
-
Fix Version/s: 2.11

> Update dependency artifactId in spring-data extension documentation.
> 
>
> Key: IGNITE-14662
> URL: https://issues.apache.org/jira/browse/IGNITE-14662
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Mikhail Petrov
>Assignee: Mikhail Petrov
>Priority: Major
> Fix For: 2.11
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> It is needed to change artifactId for spring-data extension in documentation 
> from ignite-spring-data_2.2-ext to ignite-spring-data-2.2-ext.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)