[jira] [Commented] (IGNITE-14544) Calcite engine. Support DISTINCT aggregates

2021-05-19 Thread Aleksey Plekhanov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347860#comment-17347860
 ] 

Aleksey Plekhanov commented on IGNITE-14544:


[~tledkov-gridgain] I've left a couple of comments on GitHub, please have a 
look.

> Calcite engine. Support DISTINCT aggregates
> ---
>
> Key: IGNITE-14544
> URL: https://issues.apache.org/jira/browse/IGNITE-14544
> Project: Ignite
>  Issue Type: Bug
>Reporter: Taras Ledkov
>Assignee: Taras Ledkov
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Now, DISTINCT aggregates not implemented.
> (e.g. {{SELECT COUNT (DISTINCT lastName) FROM person}})
> Tests:
> {{aggregate/aggregates/test_count.test}}
> {{aggregate/aggregates/test_avg.test}}
> {{aggregate/aggregates/test_distinct_aggr.test}}
> {{aggregate/aggregates/test_distinct_string_agg.test}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (IGNITE-14744) Snapshot restore must support restoring with index rebuild

2021-05-19 Thread Maxim Muzafarov (Jira)
Maxim Muzafarov created IGNITE-14744:


 Summary: Snapshot restore must support restoring with index rebuild
 Key: IGNITE-14744
 URL: https://issues.apache.org/jira/browse/IGNITE-14744
 Project: Ignite
  Issue Type: Improvement
Affects Versions: 2.10
Reporter: Maxim Muzafarov
Assignee: Maxim Muzafarov
 Fix For: 2.11


Currently, the snapshot restore procedure can be performed in the same cluster 
topology. This means that it will not work in topologies with a different 
number of cluster nodes (for example, fewer nodes) since it requires a complete 
rebuild of the index for the cache groups.
We must support the restore procedure on different cluster topologies.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14044) Cache with node filter is not destroyed properly on the filtered node.

2021-05-19 Thread Pavel Pereslegin (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347775#comment-17347775
 ] 

Pavel Pereslegin commented on IGNITE-14044:
---

[~mmuzaf], please take a look at the proposed changes. 

> Cache with node filter is not destroyed properly on the filtered node.
> --
>
> Key: IGNITE-14044
> URL: https://issues.apache.org/jira/browse/IGNITE-14044
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.10
>Reporter: Pavel Pereslegin
>Assignee: Pavel Pereslegin
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Steps to reproduce the problem:
>  # Start 2 nodes
>  # Create a cache with node filter (filter second node)
>  # Destroy cache
>  # Restart nodes
> Expected: cache was destroyed on both nodes.
>  Actual: cache was destroyed only on one node, the second node cannot join 
> the cluster with the following error:
> {noformat}
> Caused by: class org.apache.ignite.spi.IgniteSpiException: Joining node has 
> caches with data which are not presented on cluster, it could mean that they 
> were already destroyed, to add the node to cluster - remove directories with 
> the caches[cache1]
>   at 
> org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi.checkFailedError(TcpDiscoverySpi.java:2052)
>   at 
> org.apache.ignite.spi.discovery.tcp.ServerImpl.joinTopology(ServerImpl.java:1197)
>   at 
> org.apache.ignite.spi.discovery.tcp.ServerImpl.spiStart(ServerImpl.java:472)
>   at 
> org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi.spiStart(TcpDiscoverySpi.java:2154)
>   at 
> org.apache.ignite.internal.managers.GridManagerAdapter.startSpi(GridManagerAdapter.java:278)
>   ... 23 more
> {noformat}
> Reproducer
> {code:java}
> public class IgnitePdsDestroyCacheWithNodeFilterTest extends 
> GridCommonAbstractTest {
> @Override protected IgniteConfiguration getConfiguration(String 
> igniteInstanceName) throws Exception {
> return super.getConfiguration(igniteInstanceName)
> .setConsistentId(igniteInstanceName)
> .setDataStorageConfiguration(new DataStorageConfiguration()
> .setDefaultDataRegionConfiguration(new DataRegionConfiguration()
> .setPersistenceEnabled(true)));
> }
> @Test
> public void testDestroyCacheWithNodeFilter() throws Exception {
> cleanPersistenceDir();
> Ignite ignite = startGrids(2);
> ignite.cluster().state(ClusterState.ACTIVE);
> UUID nodeId0 = ignite.cluster().localNode().id();
> CacheConfiguration cfg1 = new 
> CacheConfiguration<>("cache1")
> .setCacheMode(CacheMode.REPLICATED)
> .setNodeFilter(n -> nodeId0.equals(n.id()));
> IgniteCache cache1 = ignite.createCache(cfg1);
> cache1.destroy();
> forceCheckpoint();
> awaitPartitionMapExchange();
> stopAllGrids();
> ignite = startGrids(2); // failing here
> ignite.cluster().state(ClusterState.ACTIVE);
> }
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (IGNITE-14575) Write to Distributed Metastorage should throw exception on client if client is not connected to topology

2021-05-19 Thread Semyon Danilov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347671#comment-17347671
 ] 

Semyon Danilov edited comment on IGNITE-14575 at 5/19/21, 4:38 PM:
---

Hello [~mmuzaf] !

The issue seems to be fixed (4 subsequent master runs are successful).


was (Author: sdanilov):
Hello [~mmuzaf] !

The issue seems to be fixed (3 subsequent master runs are successful).

> Write to Distributed Metastorage should throw exception on client if client 
> is not connected to topology
> 
>
> Key: IGNITE-14575
> URL: https://issues.apache.org/jira/browse/IGNITE-14575
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.10
>Reporter: Semyon Danilov
>Assignee: Semyon Danilov
>Priority: Major
> Fix For: 2.11
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Reference to Distributed Metastorage can be obtained on client that hasn't 
> connected to any server node yet.
> The reference allows to send write request that will be completed after 
> client connect when Tcp Discovery is used and dropped on ZK Discovery.
> To make API more reliable we need to change this behavior: when client is not 
> connected to any server (because there are no servers in topology yet or 
> because it has disconnected from topology) all incoming write or cas requests 
> should be dropped, appropriate exception should be thrown.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14544) Calcite engine. Support DISTINCT aggregates

2021-05-19 Thread Konstantin Orlov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347746#comment-17347746
 ] 

Konstantin Orlov commented on IGNITE-14544:
---

[~tledkov-gridgain], the patch looks good to me!

> Calcite engine. Support DISTINCT aggregates
> ---
>
> Key: IGNITE-14544
> URL: https://issues.apache.org/jira/browse/IGNITE-14544
> Project: Ignite
>  Issue Type: Bug
>Reporter: Taras Ledkov
>Assignee: Taras Ledkov
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Now, DISTINCT aggregates not implemented.
> (e.g. {{SELECT COUNT (DISTINCT lastName) FROM person}})
> Tests:
> {{aggregate/aggregates/test_count.test}}
> {{aggregate/aggregates/test_avg.test}}
> {{aggregate/aggregates/test_distinct_aggr.test}}
> {{aggregate/aggregates/test_distinct_string_agg.test}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (IGNITE-14734) Implement compaction functionality management for meta storage.

2021-05-19 Thread Andrey N. Gura (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrey N. Gura reassigned IGNITE-14734:
---

Assignee: Andrey N. Gura

> Implement compaction functionality management for meta storage.
> ---
>
> Key: IGNITE-14734
> URL: https://issues.apache.org/jira/browse/IGNITE-14734
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Andrey N. Gura
>Assignee: Andrey N. Gura
>Priority: Major
>
> At present {{SimpleInMemoryKeyValueStorage}} already has compaction 
> functionality but it is question: who and when should invoke {{compact}} 
> method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14389) Implement simple in-memory meta storage

2021-05-19 Thread Andrey N. Gura (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347740#comment-17347740
 ] 

Andrey N. Gura commented on IGNITE-14389:
-

Merged to main branch.

> Implement simple in-memory meta storage
> ---
>
> Key: IGNITE-14389
> URL: https://issues.apache.org/jira/browse/IGNITE-14389
> Project: Ignite
>  Issue Type: New Feature
>Reporter: Andrey N. Gura
>Assignee: Andrey N. Gura
>Priority: Major
>  Labels: iep-61, ignite-3
> Fix For: 3.0.0-alpha2
>
>  Time Spent: 8h 10m
>  Remaining Estimate: 0h
>
> Simple in-memory meta storage should be implemented in order to: 
>  - Unblock development of dependent components.
>  - Provide ability to develop integration tests.
>  - Verify concepts and approaches defined by interface.
> In-memory meta storage should satisfy to the following requirements:
> - It should implement interface (not literally of course) defined in 
> IGNITE-14198 issue.
> - It should use simple in-memory data structures as storage.
> - It should be single-threaded for read-write requests (except of watch).
> - Ranges reads could be processed in another thread but it is not mandatory 
> in first iteration.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14553) Calcite engine. Duplicated result on insert

2021-05-19 Thread Taras Ledkov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347708#comment-17347708
 ] 

Taras Ledkov commented on IGNITE-14553:
---

[~korlov], the patch is OK with me.

> Calcite engine. Duplicated result on insert
> ---
>
> Key: IGNITE-14553
> URL: https://issues.apache.org/jira/browse/IGNITE-14553
> Project: Ignite
>  Issue Type: Bug
>  Components: sql
>Reporter: Konstantin Orlov
>Assignee: Konstantin Orlov
>Priority: Major
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> Please see the test 
> {{modules/calcite/src/test/sql/types/string/test_scan_big_varchar.test_ignore}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (IGNITE-14743) Support Row with large values.

2021-05-19 Thread Andrey Mashenkov (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrey Mashenkov updated IGNITE-14743:
--
Summary: Support Row with large values.  (was: Support large Tuples.)

> Support Row with large values.
> --
>
> Key: IGNITE-14743
> URL: https://issues.apache.org/jira/browse/IGNITE-14743
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Andrey Mashenkov
>Priority: Major
>  Labels: iep-54, ignite-3
> Fix For: 3.0
>
>
> For now, TupleAssembler writes offsets for varlen columns as 2-byte {{short 
> }}type.
> This implicitly restricts key/value sizes down to 64 kB in total.
> Let's use 4-bytes {{int}} type for offsets for large tuples.
> Possible ways are:
>  # Just use ints for offsets, this increases the memory overhead for Rows.
>  # Pre-calculate potential row size during SchemaDescriptor initialization 
> and keep 'offset_size' in schema. 
> Unlimited varlen type (which is default) usage will end-up user will have 
> 4-byte offset size in most cases.
>  # Pre-calculate exact tuple size for each row and use row flags. 
> This requires Tuple data analysis which we already do to detect non-null 
> varlen values and nulls. Strings may be a headache as we have to analyze each 
> char for accurate tuple size calculation.
>  # Pre-calculate tuple size skipping chars analysis.
> Using adaptive offset_size approaches allows us to use 1-2-4 byte numbers 
> (byte, short, int) for offsets.
> Collations for String columns may be introduced and used as a hint, but we 
> will need to check a collation for every char on write.
> 'Large keys' is an unwanted case, may a solution for values only will be 
> enough...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14728) Change IGNITE_PDS_WAL_REBALANCE_THRESHOLD from System property to Distributed property

2021-05-19 Thread Ignite TC Bot (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347680#comment-17347680
 ] 

Ignite TC Bot commented on IGNITE-14728:


{panel:title=Branch: [pull/9110/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/9110/head] Base: [master] : New Tests 
(1)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#8b}Control Utility{color} [[tests 
1|https://ci.ignite.apache.org/viewLog.html?buildId=6013802]]
* {color:#013220}IgniteControlUtilityTestSuite: 
GridCommandHandlerPropertiesTest.testPropertyWalRebalanceThreshold - 
PASSED{color}

{panel}
[TeamCity *-- Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=6013810buildTypeId=IgniteTests24Java8_RunAll]

> Change IGNITE_PDS_WAL_REBALANCE_THRESHOLD from System property to Distributed 
> property
> --
>
> Key: IGNITE-14728
> URL: https://issues.apache.org/jira/browse/IGNITE-14728
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Eduard Rakhmankulov
>Assignee: Eduard Rakhmankulov
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> We have a system property named "IGNITE_PDS_WAL_REBALANCE_THRESHOLD", that 
> determines a count of entries of partition starting from which cluster will 
> try applying historical rebalance for that partition.
>  But the system property is not convenient to use and is hidden from most 
> part of users.
> I propose the creation of a new DMS property *wal.rebalance.threshold* 
> instead of a system property.
> The next algorithm will be used:
>  # On node start *wal.rebalance.threshold* property will be checked.
>  # If there is no value, then the old system property 
> *IGNITE_PDS_WAL_REBALANCE_THRESHOLD* value will be written to DMS.
>  # If a system property is not defined then the default value from java will 
> be written to DMS (*500*).
>  # On property check print to log value and source of value.
> Mark the system property *IGNITE_PDS_WAL_REBALANCE_THRESHOLD* as deprecated.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14389) Implement simple in-memory meta storage

2021-05-19 Thread Alexander Lapin (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347678#comment-17347678
 ] 

Alexander Lapin commented on IGNITE-14389:
--

[~agura] LGTM from my side.

> Implement simple in-memory meta storage
> ---
>
> Key: IGNITE-14389
> URL: https://issues.apache.org/jira/browse/IGNITE-14389
> Project: Ignite
>  Issue Type: New Feature
>Reporter: Andrey N. Gura
>Assignee: Andrey N. Gura
>Priority: Major
>  Labels: iep-61, ignite-3
> Fix For: 3.0.0-alpha2
>
>  Time Spent: 7.5h
>  Remaining Estimate: 0h
>
> Simple in-memory meta storage should be implemented in order to: 
>  - Unblock development of dependent components.
>  - Provide ability to develop integration tests.
>  - Verify concepts and approaches defined by interface.
> In-memory meta storage should satisfy to the following requirements:
> - It should implement interface (not literally of course) defined in 
> IGNITE-14198 issue.
> - It should use simple in-memory data structures as storage.
> - It should be single-threaded for read-write requests (except of watch).
> - Ranges reads could be processed in another thread but it is not mandatory 
> in first iteration.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (IGNITE-14389) Implement simple in-memory meta storage

2021-05-19 Thread Alexander Lapin (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Lapin updated IGNITE-14389:
-
Reviewer: Alexander Lapin

> Implement simple in-memory meta storage
> ---
>
> Key: IGNITE-14389
> URL: https://issues.apache.org/jira/browse/IGNITE-14389
> Project: Ignite
>  Issue Type: New Feature
>Reporter: Andrey N. Gura
>Assignee: Andrey N. Gura
>Priority: Major
>  Labels: iep-61, ignite-3
> Fix For: 3.0.0-alpha2
>
>  Time Spent: 7.5h
>  Remaining Estimate: 0h
>
> Simple in-memory meta storage should be implemented in order to: 
>  - Unblock development of dependent components.
>  - Provide ability to develop integration tests.
>  - Verify concepts and approaches defined by interface.
> In-memory meta storage should satisfy to the following requirements:
> - It should implement interface (not literally of course) defined in 
> IGNITE-14198 issue.
> - It should use simple in-memory data structures as storage.
> - It should be single-threaded for read-write requests (except of watch).
> - Ranges reads could be processed in another thread but it is not mandatory 
> in first iteration.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14575) Write to Distributed Metastorage should throw exception on client if client is not connected to topology

2021-05-19 Thread Semyon Danilov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347671#comment-17347671
 ] 

Semyon Danilov commented on IGNITE-14575:
-

Hello [~mmuzaf] !

The issue seems to be fixed (3 subsequent master runs are successful).

> Write to Distributed Metastorage should throw exception on client if client 
> is not connected to topology
> 
>
> Key: IGNITE-14575
> URL: https://issues.apache.org/jira/browse/IGNITE-14575
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.10
>Reporter: Semyon Danilov
>Assignee: Semyon Danilov
>Priority: Major
> Fix For: 2.11
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Reference to Distributed Metastorage can be obtained on client that hasn't 
> connected to any server node yet.
> The reference allows to send write request that will be completed after 
> client connect when Tcp Discovery is used and dropped on ZK Discovery.
> To make API more reliable we need to change this behavior: when client is not 
> connected to any server (because there are no servers in topology yet or 
> because it has disconnected from topology) all incoming write or cas requests 
> should be dropped, appropriate exception should be thrown.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14738) Remove pytest-runner dependency from setup.py

2021-05-19 Thread Igor Sapego (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347664#comment-17347664
 ] 

Igor Sapego commented on IGNITE-14738:
--

[~ivandasch] checked. Looks good, merge it.

> Remove pytest-runner dependency from setup.py
> -
>
> Key: IGNITE-14738
> URL: https://issues.apache.org/jira/browse/IGNITE-14738
> Project: Ignite
>  Issue Type: Improvement
>  Components: python, thin client
>Affects Versions: python-0.4.0
>Reporter: Ivan Daschinsky
>Assignee: Ivan Daschinsky
>Priority: Major
>  Labels: python, thin
> Fix For: python-0.5.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> This dependency should be removed
> 1. It is deprecated (see https://pypi.org/project/pytest-runner/)
> 2. We already adopted {{tox}} and use it in travis-ci
> 3. It cause some issues when trying to install source package from local pypi 
> mirror ({{pytest-runner}} should be installed separately before 
> {{pyignite}}). However, when installing directly from pypi.org, all works ok.
> But, unfortunatelly, our TC agents doesn't have {{tox}} installed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (IGNITE-14743) Support large Tuples.

2021-05-19 Thread Andrey Mashenkov (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrey Mashenkov updated IGNITE-14743:
--
Labels: iep-54 ignite-3  (was: )

> Support large Tuples.
> -
>
> Key: IGNITE-14743
> URL: https://issues.apache.org/jira/browse/IGNITE-14743
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Andrey Mashenkov
>Priority: Major
>  Labels: iep-54, ignite-3
> Fix For: 3.0
>
>
> For now, TupleAssembler writes offsets for varlen columns as 2-byte {{short 
> }}type.
> This implicitly restricts key/value sizes down to 64 kB in total.
> Let's use 4-bytes {{int}} type for offsets for large tuples.
> Possible ways are:
>  # Just use ints for offsets, this increases the memory overhead for Rows.
>  # Pre-calculate potential row size during SchemaDescriptor initialization 
> and keep 'offset_size' in schema. 
> Unlimited varlen type (which is default) usage will end-up user will have 
> 4-byte offset size in most cases.
>  # Pre-calculate exact tuple size for each row and use row flags. 
> This requires Tuple data analysis which we already do to detect non-null 
> varlen values and nulls. Strings may be a headache as we have to analyze each 
> char for accurate tuple size calculation.
>  # Pre-calculate tuple size skipping chars analysis.
> Using adaptive offset_size approaches allows us to use 1-2-4 byte numbers 
> (byte, short, int) for offsets.
> Collations for String columns may be introduced and used as a hint, but we 
> will need to check a collation for every char on write.
> 'Large keys' is an unwanted case, may a solution for values only will be 
> enough...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (IGNITE-14743) Support large Tuples.

2021-05-19 Thread Andrey Mashenkov (Jira)
Andrey Mashenkov created IGNITE-14743:
-

 Summary: Support large Tuples.
 Key: IGNITE-14743
 URL: https://issues.apache.org/jira/browse/IGNITE-14743
 Project: Ignite
  Issue Type: Improvement
Reporter: Andrey Mashenkov
 Fix For: 3.0


For now, TupleAssembler writes offsets for varlen columns as 2-byte {{short 
}}type.
This implicitly restricts key/value sizes down to 64 kB in total.

Let's use 4-bytes {{int}} type for offsets for large tuples.

Possible ways are:
 # Just use ints for offsets, this increases the memory overhead for Rows.
 # Pre-calculate potential row size during SchemaDescriptor initialization and 
keep 'offset_size' in schema. 
Unlimited varlen type (which is default) usage will end-up user will have 
4-byte offset size in most cases.
 # Pre-calculate exact tuple size for each row and use row flags. 
This requires Tuple data analysis which we already do to detect non-null varlen 
values and nulls. Strings may be a headache as we have to analyze each char for 
accurate tuple size calculation.
 # Pre-calculate tuple size skipping chars analysis.

Using adaptive offset_size approaches allows us to use 1-2-4 byte numbers 
(byte, short, int) for offsets.

Collations for String columns may be introduced and used as a hint, but we will 
need to check a collation for every char on write.

'Large keys' is an unwanted case, may a solution for values only will be 
enough...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14737) Calcite. Equals predicate with multiple results from subqueries must fail.

2021-05-19 Thread Stanilovsky Evgeny (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347650#comment-17347650
 ] 

Stanilovsky Evgeny commented on IGNITE-14737:
-

[~alex_pl] fix your comments, check plz.

> Calcite. Equals predicate with multiple results from subqueries must fail.  
> 
>
> Key: IGNITE-14737
> URL: https://issues.apache.org/jira/browse/IGNITE-14737
> Project: Ignite
>  Issue Type: Bug
>  Components: sql
>Reporter: Stanilovsky Evgeny
>Assignee: Stanilovsky Evgeny
>Priority: Major
>  Labels: calcite
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Suppose table looks like :
> *products*
> ||name||cat_id||subcat_id||
> |n1|1|10|
> |n2|2|10|
> |n3|3|11|
> and request :
> {noformat}
> SELECT NAME FROM products WHERE CAT_ID = (SELECT CAT_ID FROM products WHERE 
> SUBCAT_ID = 10)
> {noformat}
> for now it correctly executed and returns undefined results, proposal : 
> return ERROR and appropriate message.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14738) Remove pytest-runner dependency from setup.py

2021-05-19 Thread Ivan Daschinsky (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347646#comment-17347646
 ] 

Ivan Daschinsky commented on IGNITE-14738:
--

[~isapego] Hi, could you please review it?

> Remove pytest-runner dependency from setup.py
> -
>
> Key: IGNITE-14738
> URL: https://issues.apache.org/jira/browse/IGNITE-14738
> Project: Ignite
>  Issue Type: Improvement
>  Components: python, thin client
>Affects Versions: python-0.4.0
>Reporter: Ivan Daschinsky
>Assignee: Ivan Daschinsky
>Priority: Major
>  Labels: python, thin
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> This dependency should be removed
> 1. It is deprecated (see https://pypi.org/project/pytest-runner/)
> 2. We already adopted {{tox}} and use it in travis-ci
> 3. It cause some issues when trying to install source package from local pypi 
> mirror ({{pytest-runner}} should be installed separately before 
> {{pyignite}}). However, when installing directly from pypi.org, all works ok.
> But, unfortunatelly, our TC agents doesn't have {{tox}} installed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (IGNITE-14720) Remove warning about disabling explicit GC

2021-05-19 Thread Ilya Kasnacheev (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ilya Kasnacheev updated IGNITE-14720:
-
Ignite Flags: Docs Required  (was: Docs Required,Release Notes Required)

> Remove warning about disabling explicit GC
> --
>
> Key: IGNITE-14720
> URL: https://issues.apache.org/jira/browse/IGNITE-14720
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Vladimir Pligin
>Assignee: Ilya
>Priority: Major
> Fix For: 2.11
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Right now we suggest the following
> {code:java}
> INFO:   ^-- Disable processing of calls to System.gc() (add 
> '-XX:+DisableExplicitGC' to JVM options){code}
> It does not make sense anymore (people don't call gc() when not needed) and 
> may actually prevent JVM from reclaiming heap and the failing due to running 
> out of direct memory buffers.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (IGNITE-14742) Store array component type in binary object

2021-05-19 Thread Nikolay Izhikov (Jira)
Nikolay Izhikov created IGNITE-14742:


 Summary: Store array component type in binary object
 Key: IGNITE-14742
 URL: https://issues.apache.org/jira/browse/IGNITE-14742
 Project: Ignite
  Issue Type: Improvement
Reporter: Nikolay Izhikov


Currently, an array of custom objects can't be retrieved from the cache
{code:java}
public class BinaryObjectTest extends GridCommonAbstractTest {
/** */
@Test
public void testArray() throws Exception {
Ignite ign = startGrid();

IgniteCache cache = ign.createCache("my-cache");

cache.put(1, new TestClass1[] {new TestClass1(), new TestClass1()});
TestClass1[] obj = cache.get(1);

assertEquals(TestClass1[].class, obj.getClass());
}
}
{code}

The fix should preserve backward compatibility.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (IGNITE-14742) Store array component type in binary object

2021-05-19 Thread Nikolay Izhikov (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikolay Izhikov reassigned IGNITE-14742:


Assignee: Nikolay Izhikov

> Store array component type in binary object
> ---
>
> Key: IGNITE-14742
> URL: https://issues.apache.org/jira/browse/IGNITE-14742
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Major
>
> Currently, an array of custom objects can't be retrieved from the cache
> {code:java}
> public class BinaryObjectTest extends GridCommonAbstractTest {
> /** */
> @Test
> public void testArray() throws Exception {
> Ignite ign = startGrid();
> IgniteCache cache = 
> ign.createCache("my-cache");
> cache.put(1, new TestClass1[] {new TestClass1(), new TestClass1()});
> TestClass1[] obj = cache.get(1);
> assertEquals(TestClass1[].class, obj.getClass());
> }
> }
> {code}
> The fix should preserve backward compatibility.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (IGNITE-14692) Validate tuple for STRICT schema

2021-05-19 Thread Andrey Mashenkov (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrey Mashenkov updated IGNITE-14692:
--
Fix Version/s: 3.0.0-alpha2

> Validate tuple for STRICT schema
> 
>
> Key: IGNITE-14692
> URL: https://issues.apache.org/jira/browse/IGNITE-14692
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Taras Ledkov
>Assignee: Taras Ledkov
>Priority: Major
>  Labels: iep-54, ignite-3
> Fix For: 3.0.0-alpha2
>
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> The part of the IGNITE-14556.
> At a point of Table public method is called by a user, we need to validate 
> user input
> Description.
> We can add this logic to check if value fields match the current schema 
> version (no new fields).
> For STRICT-Schema.  If Tuple has one or more additional columns, then we 
> should fail the user operation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (IGNITE-14732) Use enum sort order in index columns configuration.

2021-05-19 Thread Andrey Mashenkov (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrey Mashenkov updated IGNITE-14732:
--
Affects Version/s: (was: 3.0.0-alpha1)

> Use enum sort order in index columns configuration.
> ---
>
> Key: IGNITE-14732
> URL: https://issues.apache.org/jira/browse/IGNITE-14732
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Andrey Mashenkov
>Assignee: Andrey Mashenkov
>Priority: Trivial
>  Labels: iep-54, ignite-3
> Fix For: 3.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Now SortedIndexColumn interface has method that returns boolean for sort 
> order.
> {code:java}
> boolean asc();{code}
> Let's introduce a enum Sort with ASC/DESC values for this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (IGNITE-14732) Use enum sort order in index columns configuration.

2021-05-19 Thread Andrey Mashenkov (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrey Mashenkov updated IGNITE-14732:
--
Fix Version/s: (was: 3.0)
   3.0.0-alpha2

> Use enum sort order in index columns configuration.
> ---
>
> Key: IGNITE-14732
> URL: https://issues.apache.org/jira/browse/IGNITE-14732
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Andrey Mashenkov
>Assignee: Andrey Mashenkov
>Priority: Trivial
>  Labels: iep-54, ignite-3
> Fix For: 3.0.0-alpha2
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Now SortedIndexColumn interface has method that returns boolean for sort 
> order.
> {code:java}
> boolean asc();{code}
> Let's introduce a enum Sort with ASC/DESC values for this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (IGNITE-14732) Use enum sort order in index columns configuration.

2021-05-19 Thread Andrey Mashenkov (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrey Mashenkov reassigned IGNITE-14732:
-

Assignee: Andrey Mashenkov

> Use enum sort order in index columns configuration.
> ---
>
> Key: IGNITE-14732
> URL: https://issues.apache.org/jira/browse/IGNITE-14732
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Andrey Mashenkov
>Assignee: Andrey Mashenkov
>Priority: Trivial
>  Labels: iep-54, ignite-3
> Fix For: 3.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Now SortedIndexColumn interface has method that returns boolean for sort 
> order.
> {code:java}
> boolean asc();{code}
> Let's introduce a enum Sort with ASC/DESC values for this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (IGNITE-14740) Add multiple python versions on TC agents for testing pyignite

2021-05-19 Thread Ivan Daschinsky (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347500#comment-17347500
 ] 

Ivan Daschinsky edited comment on IGNITE-14740 at 5/19/21, 10:50 AM:
-

Yep, 
{{pyenv install 3.6.12 && pyenv install  3.7.9 && pyenv install  3.8.6 && pyenv 
install  3.9.1}}


was (Author: ivandasch):
Yep, 
{{ pyenv install 3.6.12 && pyenv install  3.7.9 && pyenv install  3.8.6 && 
pyenv install  3.9.1 }}

> Add multiple python versions on TC agents for testing pyignite
> --
>
> Key: IGNITE-14740
> URL: https://issues.apache.org/jira/browse/IGNITE-14740
> Project: Ignite
>  Issue Type: New Feature
>  Components: python, thin client
>Reporter: Ivan Daschinsky
>Assignee: Peter Ivanov
>Priority: Major
>  Labels: python, teamcity
>
> In order to test {{pyignite}} against different python versions, I suggests 
> followings
> 1. Install [pyenv|https://github.com/pyenv/pyenv]
> 2. Install through {{pyenv}} different python versions (3.6, 3.7, 3.8, 3.9)
> Before invoking {{tox}}, script should invoke {{pyenv init --path}} and 
> {{pyenv shell}} with specific python version. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14740) Add multiple python versions on TC agents for testing pyignite

2021-05-19 Thread Ivan Daschinsky (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347500#comment-17347500
 ] 

Ivan Daschinsky commented on IGNITE-14740:
--

Yep, 
{{ pyenv install 3.6.12 && pyenv install  3.7.9 && pyenv install  3.8.6 && 
pyenv install  3.9.1 }}

> Add multiple python versions on TC agents for testing pyignite
> --
>
> Key: IGNITE-14740
> URL: https://issues.apache.org/jira/browse/IGNITE-14740
> Project: Ignite
>  Issue Type: New Feature
>  Components: python, thin client
>Reporter: Ivan Daschinsky
>Assignee: Peter Ivanov
>Priority: Major
>  Labels: python, teamcity
>
> In order to test {{pyignite}} against different python versions, I suggests 
> followings
> 1. Install [pyenv|https://github.com/pyenv/pyenv]
> 2. Install through {{pyenv}} different python versions (3.6, 3.7, 3.8, 3.9)
> Before invoking {{tox}}, script should invoke {{pyenv init --path}} and 
> {{pyenv shell}} with specific python version. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (IGNITE-14727) SSL test should work with custom persistance root

2021-05-19 Thread Mikhail Filatov (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mikhail Filatov resolved IGNITE-14727.
--
Resolution: Fixed

> SSL test should work with custom persistance root
> -
>
> Key: IGNITE-14727
> URL: https://issues.apache.org/jira/browse/IGNITE-14727
> Project: Ignite
>  Issue Type: Task
>Reporter: Mikhail Filatov
>Assignee: Mikhail Filatov
>Priority: Trivial
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In test modules/ducktests/tests/ignitetest/tests/ssl_test.py we have 
> hard-coded path to the folder with certificates. 
> A situation when this folder does not exist is possible . 
> We should get a folder through globals in this test



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (IGNITE-14741) Extend coverage of unit tests to public methods of Affinity and Table managers

2021-05-19 Thread Vladislav Pyatkov (Jira)
Vladislav Pyatkov created IGNITE-14741:
--

 Summary: Extend coverage of unit tests to public methods of 
Affinity and Table managers
 Key: IGNITE-14741
 URL: https://issues.apache.org/jira/browse/IGNITE-14741
 Project: Ignite
  Issue Type: Improvement
Reporter: Vladislav Pyatkov
Assignee: Vladislav Pyatkov


We have to cover all public method of any components by unit tests.
In this issue we cover Affinity and Table managers by the unit tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14740) Add multiple python versions on TC agents for testing pyignite

2021-05-19 Thread Peter Ivanov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347486#comment-17347486
 ] 

Peter Ivanov commented on IGNITE-14740:
---

So will there be enough installing pyenv and using it to install target Python 
versions on every agent?

> Add multiple python versions on TC agents for testing pyignite
> --
>
> Key: IGNITE-14740
> URL: https://issues.apache.org/jira/browse/IGNITE-14740
> Project: Ignite
>  Issue Type: New Feature
>  Components: python, thin client
>Reporter: Ivan Daschinsky
>Assignee: Peter Ivanov
>Priority: Major
>  Labels: python, teamcity
>
> In order to test {{pyignite}} against different python versions, I suggests 
> followings
> 1. Install [pyenv|https://github.com/pyenv/pyenv]
> 2. Install through {{pyenv}} different python versions (3.6, 3.7, 3.8, 3.9)
> Before invoking {{tox}}, script should invoke {{pyenv init --path}} and 
> {{pyenv shell}} with specific python version. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14740) Add multiple python versions on TC agents for testing pyignite

2021-05-19 Thread Ivan Daschinsky (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347485#comment-17347485
 ] 

Ivan Daschinsky commented on IGNITE-14740:
--

[~vveider] You asked me about what is expected. Final step I can do by myself, 
but I cannot do anything with agents.

> Add multiple python versions on TC agents for testing pyignite
> --
>
> Key: IGNITE-14740
> URL: https://issues.apache.org/jira/browse/IGNITE-14740
> Project: Ignite
>  Issue Type: New Feature
>  Components: python, thin client
>Reporter: Ivan Daschinsky
>Assignee: Peter Ivanov
>Priority: Major
>  Labels: python, teamcity
>
> In order to test {{pyignite}} against different python versions, I suggests 
> followings
> 1. Install [pyenv|https://github.com/pyenv/pyenv]
> 2. Install through {{pyenv}} different python versions (3.6, 3.7, 3.8, 3.9)
> Before invoking {{tox}}, script should invoke {{pyenv init --path}} and 
> {{pyenv shell}} with specific python version. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (IGNITE-14738) Remove pytest-runner dependency from setup.py

2021-05-19 Thread Ivan Daschinsky (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347474#comment-17347474
 ] 

Ivan Daschinsky edited comment on IGNITE-14738 at 5/19/21, 10:01 AM:
-

[~vveider] It is not resolved yet, installing {{tox}} is just a prerequisite to 
code change. I should change {{setup.py}} and remove some old stuff.


was (Author: ivandasch):
[~vveider] It is not resolved yet

> Remove pytest-runner dependency from setup.py
> -
>
> Key: IGNITE-14738
> URL: https://issues.apache.org/jira/browse/IGNITE-14738
> Project: Ignite
>  Issue Type: Improvement
>  Components: python, thin client
>Affects Versions: python-0.4.0
>Reporter: Ivan Daschinsky
>Assignee: Ivan Daschinsky
>Priority: Major
>  Labels: python, thin
>
> This dependency should be removed
> 1. It is deprecated (see https://pypi.org/project/pytest-runner/)
> 2. We already adopted {{tox}} and use it in travis-ci
> 3. It cause some issues when trying to install source package from local pypi 
> mirror ({{pytest-runner}} should be installed separately before 
> {{pyignite}}). However, when installing directly from pypi.org, all works ok.
> But, unfortunatelly, our TC agents doesn't have {{tox}} installed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14738) Remove pytest-runner dependency from setup.py

2021-05-19 Thread Ivan Daschinsky (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347474#comment-17347474
 ] 

Ivan Daschinsky commented on IGNITE-14738:
--

[~vveider] It is not resolved yet

> Remove pytest-runner dependency from setup.py
> -
>
> Key: IGNITE-14738
> URL: https://issues.apache.org/jira/browse/IGNITE-14738
> Project: Ignite
>  Issue Type: Improvement
>  Components: python, thin client
>Affects Versions: python-0.4.0
>Reporter: Ivan Daschinsky
>Assignee: Ivan Daschinsky
>Priority: Major
>  Labels: python, thin
>
> This dependency should be removed
> 1. It is deprecated (see https://pypi.org/project/pytest-runner/)
> 2. We already adopted {{tox}} and use it in travis-ci
> 3. It cause some issues when trying to install source package from local pypi 
> mirror ({{pytest-runner}} should be installed separately before 
> {{pyignite}}). However, when installing directly from pypi.org, all works ok.
> But, unfortunatelly, our TC agents doesn't have {{tox}} installed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (IGNITE-14738) Remove pytest-runner dependency from setup.py

2021-05-19 Thread Ivan Daschinsky (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ivan Daschinsky reopened IGNITE-14738:
--
Ignite Flags:   (was: Docs Required,Release Notes Required)

> Remove pytest-runner dependency from setup.py
> -
>
> Key: IGNITE-14738
> URL: https://issues.apache.org/jira/browse/IGNITE-14738
> Project: Ignite
>  Issue Type: Improvement
>  Components: python, thin client
>Affects Versions: python-0.4.0
>Reporter: Ivan Daschinsky
>Assignee: Ivan Daschinsky
>Priority: Major
>  Labels: python, thin
>
> This dependency should be removed
> 1. It is deprecated (see https://pypi.org/project/pytest-runner/)
> 2. We already adopted {{tox}} and use it in travis-ci
> 3. It cause some issues when trying to install source package from local pypi 
> mirror ({{pytest-runner}} should be installed separately before 
> {{pyignite}}). However, when installing directly from pypi.org, all works ok.
> But, unfortunatelly, our TC agents doesn't have {{tox}} installed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (IGNITE-14738) Remove pytest-runner dependency from setup.py

2021-05-19 Thread Peter Ivanov (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Ivanov updated IGNITE-14738:
--
Affects Version/s: (was: python-0.4.0)

> Remove pytest-runner dependency from setup.py
> -
>
> Key: IGNITE-14738
> URL: https://issues.apache.org/jira/browse/IGNITE-14738
> Project: Ignite
>  Issue Type: Improvement
>  Components: python, thin client
>Reporter: Ivan Daschinsky
>Assignee: Ivan Daschinsky
>Priority: Major
>  Labels: python, thin
>
> This dependency should be removed
> 1. It is deprecated (see https://pypi.org/project/pytest-runner/)
> 2. We already adopted {{tox}} and use it in travis-ci
> 3. It cause some issues when trying to install source package from local pypi 
> mirror ({{pytest-runner}} should be installed separately before 
> {{pyignite}}). However, when installing directly from pypi.org, all works ok.
> But, unfortunatelly, our TC agents doesn't have {{tox}} installed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (IGNITE-14738) Remove pytest-runner dependency from setup.py

2021-05-19 Thread Peter Ivanov (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Ivanov updated IGNITE-14738:
--
Affects Version/s: python-0.4.0

> Remove pytest-runner dependency from setup.py
> -
>
> Key: IGNITE-14738
> URL: https://issues.apache.org/jira/browse/IGNITE-14738
> Project: Ignite
>  Issue Type: Improvement
>  Components: python, thin client
>Affects Versions: python-0.4.0
>Reporter: Ivan Daschinsky
>Assignee: Ivan Daschinsky
>Priority: Major
>  Labels: python, thin
>
> This dependency should be removed
> 1. It is deprecated (see https://pypi.org/project/pytest-runner/)
> 2. We already adopted {{tox}} and use it in travis-ci
> 3. It cause some issues when trying to install source package from local pypi 
> mirror ({{pytest-runner}} should be installed separately before 
> {{pyignite}}). However, when installing directly from pypi.org, all works ok.
> But, unfortunatelly, our TC agents doesn't have {{tox}} installed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14740) Add multiple python versions on TC agents for testing pyignite

2021-05-19 Thread Peter Ivanov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347471#comment-17347471
 ] 

Peter Ivanov commented on IGNITE-14740:
---

That is separate task which is not related to infrastructure changes.
Configuring TC if you do not have enough permissions or knowledge should be 
done in separate issue.

> Add multiple python versions on TC agents for testing pyignite
> --
>
> Key: IGNITE-14740
> URL: https://issues.apache.org/jira/browse/IGNITE-14740
> Project: Ignite
>  Issue Type: New Feature
>  Components: python, thin client
>Reporter: Ivan Daschinsky
>Assignee: Peter Ivanov
>Priority: Major
>  Labels: python, teamcity
>
> In order to test {{pyignite}} against different python versions, I suggests 
> followings
> 1. Install [pyenv|https://github.com/pyenv/pyenv]
> 2. Install through {{pyenv}} different python versions (3.6, 3.7, 3.8, 3.9)
> Before invoking {{tox}}, script should invoke {{pyenv init --path}} and 
> {{pyenv shell}} with specific python version. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14738) Remove pytest-runner dependency from setup.py

2021-05-19 Thread Ivan Daschinsky (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347472#comment-17347472
 ] 

Ivan Daschinsky commented on IGNITE-14738:
--

[~vveider] Tox works, thank you. I will change build script in all python tests 
jobs also [job| 
https://ci.ignite.apache.org/buildConfiguration/IgniteThinClients_Tests_ThinClientPython/6013824]

> Remove pytest-runner dependency from setup.py
> -
>
> Key: IGNITE-14738
> URL: https://issues.apache.org/jira/browse/IGNITE-14738
> Project: Ignite
>  Issue Type: Improvement
>  Components: python, thin client
>Affects Versions: python-0.4.0
>Reporter: Ivan Daschinsky
>Assignee: Ivan Daschinsky
>Priority: Major
>  Labels: python, thin
>
> This dependency should be removed
> 1. It is deprecated (see https://pypi.org/project/pytest-runner/)
> 2. We already adopted {{tox}} and use it in travis-ci
> 3. It cause some issues when trying to install source package from local pypi 
> mirror ({{pytest-runner}} should be installed separately before 
> {{pyignite}}). However, when installing directly from pypi.org, all works ok.
> But, unfortunatelly, our TC agents doesn't have {{tox}} installed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14692) Validate tuple for STRICT schema

2021-05-19 Thread Andrey Mashenkov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347462#comment-17347462
 ] 

Andrey Mashenkov commented on IGNITE-14692:
---

[~tledkov-gridgain], looks good.
Please fix styles and resolve conflicts.

> Validate tuple for STRICT schema
> 
>
> Key: IGNITE-14692
> URL: https://issues.apache.org/jira/browse/IGNITE-14692
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Taras Ledkov
>Assignee: Taras Ledkov
>Priority: Major
>  Labels: iep-54, ignite-3
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> The part of the IGNITE-14556.
> At a point of Table public method is called by a user, we need to validate 
> user input
> Description.
> We can add this logic to check if value fields match the current schema 
> version (no new fields).
> For STRICT-Schema.  If Tuple has one or more additional columns, then we 
> should fail the user operation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14740) Add multiple python versions on TC agents for testing pyignite

2021-05-19 Thread Ivan Daschinsky (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347461#comment-17347461
 ] 

Ivan Daschinsky commented on IGNITE-14740:
--

[~vveider] I suppose that ideally job trigger 4 child job that run tests using 
4 different python versions. Similar to 
[travis job| 
https://github.com/apache/ignite-python-thin-client/blob/master/.travis.yml]

> Add multiple python versions on TC agents for testing pyignite
> --
>
> Key: IGNITE-14740
> URL: https://issues.apache.org/jira/browse/IGNITE-14740
> Project: Ignite
>  Issue Type: New Feature
>  Components: python, thin client
>Reporter: Ivan Daschinsky
>Assignee: Peter Ivanov
>Priority: Major
>  Labels: python, teamcity
>
> In order to test {{pyignite}} against different python versions, I suggests 
> followings
> 1. Install [pyenv|https://github.com/pyenv/pyenv]
> 2. Install through {{pyenv}} different python versions (3.6, 3.7, 3.8, 3.9)
> Before invoking {{tox}}, script should invoke {{pyenv init --path}} and 
> {{pyenv shell}} with specific python version. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (IGNITE-14738) Remove pytest-runner dependency from setup.py

2021-05-19 Thread Peter Ivanov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347444#comment-17347444
 ] 

Peter Ivanov edited comment on IGNITE-14738 at 5/19/21, 9:36 AM:
-

I do not know such ¯\\_(ツ)_/¯
Just assign new issue to me and I will take it in priority pool.

Thanks!


was (Author: vveider):
I do not know such ¯\_(ツ)_/¯
Just assign new issue to me and I will take it in priority pool.

Thanks!

> Remove pytest-runner dependency from setup.py
> -
>
> Key: IGNITE-14738
> URL: https://issues.apache.org/jira/browse/IGNITE-14738
> Project: Ignite
>  Issue Type: Improvement
>  Components: python, thin client
>Affects Versions: python-0.4.0
>Reporter: Ivan Daschinsky
>Assignee: Ivan Daschinsky
>Priority: Major
>  Labels: python, thin
>
> This dependency should be removed
> 1. It is deprecated (see https://pypi.org/project/pytest-runner/)
> 2. We already adopted {{tox}} and use it in travis-ci
> 3. It cause some issues when trying to install source package from local pypi 
> mirror ({{pytest-runner}} should be installed separately before 
> {{pyignite}}). However, when installing directly from pypi.org, all works ok.
> But, unfortunatelly, our TC agents doesn't have {{tox}} installed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (IGNITE-14738) Remove pytest-runner dependency from setup.py

2021-05-19 Thread Peter Ivanov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347444#comment-17347444
 ] 

Peter Ivanov edited comment on IGNITE-14738 at 5/19/21, 9:36 AM:
-

I do not know such ¯\_(ツ)_/¯
Just assign new issue to me and I will take it in priority pool.

Thanks!


was (Author: vveider):
I do not know such ¯\\\_(ツ)_/¯
Just assign new issue to me and I will take it in priority pool.

Thanks!

> Remove pytest-runner dependency from setup.py
> -
>
> Key: IGNITE-14738
> URL: https://issues.apache.org/jira/browse/IGNITE-14738
> Project: Ignite
>  Issue Type: Improvement
>  Components: python, thin client
>Affects Versions: python-0.4.0
>Reporter: Ivan Daschinsky
>Assignee: Ivan Daschinsky
>Priority: Major
>  Labels: python, thin
>
> This dependency should be removed
> 1. It is deprecated (see https://pypi.org/project/pytest-runner/)
> 2. We already adopted {{tox}} and use it in travis-ci
> 3. It cause some issues when trying to install source package from local pypi 
> mirror ({{pytest-runner}} should be installed separately before 
> {{pyignite}}). However, when installing directly from pypi.org, all works ok.
> But, unfortunatelly, our TC agents doesn't have {{tox}} installed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (IGNITE-14738) Remove pytest-runner dependency from setup.py

2021-05-19 Thread Peter Ivanov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347444#comment-17347444
 ] 

Peter Ivanov edited comment on IGNITE-14738 at 5/19/21, 9:36 AM:
-

I do not know such ¯\\\_(ツ)_/¯
Just assign new issue to me and I will take it in priority pool.

Thanks!


was (Author: vveider):
I do not know such ¯_(ツ)_/¯
Just assign new issue to me and I will take it in priority pool.

Thanks!

> Remove pytest-runner dependency from setup.py
> -
>
> Key: IGNITE-14738
> URL: https://issues.apache.org/jira/browse/IGNITE-14738
> Project: Ignite
>  Issue Type: Improvement
>  Components: python, thin client
>Affects Versions: python-0.4.0
>Reporter: Ivan Daschinsky
>Assignee: Ivan Daschinsky
>Priority: Major
>  Labels: python, thin
>
> This dependency should be removed
> 1. It is deprecated (see https://pypi.org/project/pytest-runner/)
> 2. We already adopted {{tox}} and use it in travis-ci
> 3. It cause some issues when trying to install source package from local pypi 
> mirror ({{pytest-runner}} should be installed separately before 
> {{pyignite}}). However, when installing directly from pypi.org, all works ok.
> But, unfortunatelly, our TC agents doesn't have {{tox}} installed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (IGNITE-14738) Remove pytest-runner dependency from setup.py

2021-05-19 Thread Peter Ivanov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347444#comment-17347444
 ] 

Peter Ivanov edited comment on IGNITE-14738 at 5/19/21, 9:36 AM:
-

I do not know such ¯_(ツ)_/¯
Just assign new issue to me and I will take it in priority pool.

Thanks!


was (Author: vveider):
I do not know such ¯\\_(ツ)_/¯
Just assign new issue to me and I will take it in priority pool.

Thanks!

> Remove pytest-runner dependency from setup.py
> -
>
> Key: IGNITE-14738
> URL: https://issues.apache.org/jira/browse/IGNITE-14738
> Project: Ignite
>  Issue Type: Improvement
>  Components: python, thin client
>Affects Versions: python-0.4.0
>Reporter: Ivan Daschinsky
>Assignee: Ivan Daschinsky
>Priority: Major
>  Labels: python, thin
>
> This dependency should be removed
> 1. It is deprecated (see https://pypi.org/project/pytest-runner/)
> 2. We already adopted {{tox}} and use it in travis-ci
> 3. It cause some issues when trying to install source package from local pypi 
> mirror ({{pytest-runner}} should be installed separately before 
> {{pyignite}}). However, when installing directly from pypi.org, all works ok.
> But, unfortunatelly, our TC agents doesn't have {{tox}} installed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14740) Add multiple python versions on TC agents for testing pyignite

2021-05-19 Thread Peter Ivanov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347453#comment-17347453
 ] 

Peter Ivanov commented on IGNITE-14740:
---

I do not understand what exactly should be done other then installing pyenv and 
preinstalling target Python versions?

> Add multiple python versions on TC agents for testing pyignite
> --
>
> Key: IGNITE-14740
> URL: https://issues.apache.org/jira/browse/IGNITE-14740
> Project: Ignite
>  Issue Type: New Feature
>  Components: python, thin client
>Reporter: Ivan Daschinsky
>Assignee: Peter Ivanov
>Priority: Major
>  Labels: python, teamcity
>
> In order to test {{pyignite}} against different python versions, I suggests 
> followings
> 1. Install [pyenv|https://github.com/pyenv/pyenv]
> 2. Install through {{pyenv}} different python versions (3.6, 3.7, 3.8, 3.9)
> Before invoking {{tox}}, script should invoke {{pyenv init --path}} and 
> {{pyenv shell}} with specific python version. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14738) Remove pytest-runner dependency from setup.py

2021-05-19 Thread Peter Ivanov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347452#comment-17347452
 ] 

Peter Ivanov commented on IGNITE-14738:
---

{{tox}} is installed on all Linux agents.
Please, check.

> Remove pytest-runner dependency from setup.py
> -
>
> Key: IGNITE-14738
> URL: https://issues.apache.org/jira/browse/IGNITE-14738
> Project: Ignite
>  Issue Type: Improvement
>  Components: python, thin client
>Affects Versions: python-0.4.0
>Reporter: Ivan Daschinsky
>Assignee: Ivan Daschinsky
>Priority: Major
>  Labels: python, thin
>
> This dependency should be removed
> 1. It is deprecated (see https://pypi.org/project/pytest-runner/)
> 2. We already adopted {{tox}} and use it in travis-ci
> 3. It cause some issues when trying to install source package from local pypi 
> mirror ({{pytest-runner}} should be installed separately before 
> {{pyignite}}). However, when installing directly from pypi.org, all works ok.
> But, unfortunatelly, our TC agents doesn't have {{tox}} installed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (IGNITE-14740) Add multiple python versions on TC agents for testing pyignite

2021-05-19 Thread Ivan Daschinsky (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347449#comment-17347449
 ] 

Ivan Daschinsky edited comment on IGNITE-14740 at 5/19/21, 9:26 AM:


 Yep, this is just step of job.
But building python should be done before.

Pyenv is just bunch of shell scripts for automating PATH and building pythons


was (Author: ivandasch):
 Yep, this is just step of job.
But building python should be done before.

> Add multiple python versions on TC agents for testing pyignite
> --
>
> Key: IGNITE-14740
> URL: https://issues.apache.org/jira/browse/IGNITE-14740
> Project: Ignite
>  Issue Type: New Feature
>  Components: python, thin client
>Reporter: Ivan Daschinsky
>Assignee: Peter Ivanov
>Priority: Major
>  Labels: python, teamcity
>
> In order to test {{pyignite}} against different python versions, I suggests 
> followings
> 1. Install [pyenv|https://github.com/pyenv/pyenv]
> 2. Install through {{pyenv}} different python versions (3.6, 3.7, 3.8, 3.9)
> Before invoking {{tox}}, script should invoke {{pyenv init --path}} and 
> {{pyenv shell}} with specific python version. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14740) Add multiple python versions on TC agents for testing pyignite

2021-05-19 Thread Ivan Daschinsky (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347449#comment-17347449
 ] 

Ivan Daschinsky commented on IGNITE-14740:
--

 Yep, this is just step of job.
But building python should be done before.

> Add multiple python versions on TC agents for testing pyignite
> --
>
> Key: IGNITE-14740
> URL: https://issues.apache.org/jira/browse/IGNITE-14740
> Project: Ignite
>  Issue Type: New Feature
>  Components: python, thin client
>Reporter: Ivan Daschinsky
>Assignee: Peter Ivanov
>Priority: Major
>  Labels: python, teamcity
>
> In order to test {{pyignite}} against different python versions, I suggests 
> followings
> 1. Install [pyenv|https://github.com/pyenv/pyenv]
> 2. Install through {{pyenv}} different python versions (3.6, 3.7, 3.8, 3.9)
> Before invoking {{tox}}, script should invoke {{pyenv init --path}} and 
> {{pyenv shell}} with specific python version. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14740) Add multiple python versions on TC agents for testing pyignite

2021-05-19 Thread Peter Ivanov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347447#comment-17347447
 ] 

Peter Ivanov commented on IGNITE-14740:
---

{quote}Before invoking tox, script should invoke pyenv init --path and pyenv 
shell with specific python version.{quote}
I guess that should be controlled by TC build configuration, not by internal 
infrastructure, am I wrong?

> Add multiple python versions on TC agents for testing pyignite
> --
>
> Key: IGNITE-14740
> URL: https://issues.apache.org/jira/browse/IGNITE-14740
> Project: Ignite
>  Issue Type: New Feature
>  Components: python, thin client
>Reporter: Ivan Daschinsky
>Assignee: Peter Ivanov
>Priority: Major
>  Labels: python, teamcity
>
> In order to test {{pyignite}} against different python versions, I suggests 
> followings
> 1. Install [pyenv|https://github.com/pyenv/pyenv]
> 2. Install through {{pyenv}} different python versions (3.6, 3.7, 3.8, 3.9)
> Before invoking {{tox}}, script should invoke {{pyenv init --path}} and 
> {{pyenv shell}} with specific python version. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14738) Remove pytest-runner dependency from setup.py

2021-05-19 Thread Ivan Daschinsky (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347446#comment-17347446
 ] 

Ivan Daschinsky commented on IGNITE-14738:
--

[~vveider] IGNITE-14740

> Remove pytest-runner dependency from setup.py
> -
>
> Key: IGNITE-14738
> URL: https://issues.apache.org/jira/browse/IGNITE-14738
> Project: Ignite
>  Issue Type: Improvement
>  Components: python, thin client
>Affects Versions: python-0.4.0
>Reporter: Ivan Daschinsky
>Assignee: Ivan Daschinsky
>Priority: Major
>  Labels: python, thin
>
> This dependency should be removed
> 1. It is deprecated (see https://pypi.org/project/pytest-runner/)
> 2. We already adopted {{tox}} and use it in travis-ci
> 3. It cause some issues when trying to install source package from local pypi 
> mirror ({{pytest-runner}} should be installed separately before 
> {{pyignite}}). However, when installing directly from pypi.org, all works ok.
> But, unfortunatelly, our TC agents doesn't have {{tox}} installed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (IGNITE-14740) Add multiple python versions on TC agents for testing pyignite

2021-05-19 Thread Ivan Daschinsky (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ivan Daschinsky reassigned IGNITE-14740:


Assignee: Peter Ivanov

> Add multiple python versions on TC agents for testing pyignite
> --
>
> Key: IGNITE-14740
> URL: https://issues.apache.org/jira/browse/IGNITE-14740
> Project: Ignite
>  Issue Type: New Feature
>  Components: python, thin client
>Reporter: Ivan Daschinsky
>Assignee: Peter Ivanov
>Priority: Major
>  Labels: python, teamcity
>
> In order to test {{pyignite}} against different python versions, I suggests 
> followings
> 1. Install [pyenv|https://github.com/pyenv/pyenv]
> 2. Install through {{pyenv}} different python versions (3.6, 3.7, 3.8, 3.9)
> Before invoking {{tox}}, script should invoke {{pyenv init --path}} and 
> {{pyenv shell}} with specific python version. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (IGNITE-14740) Add multiple python versions on TC agents for testing pyignite

2021-05-19 Thread Ivan Daschinsky (Jira)
Ivan Daschinsky created IGNITE-14740:


 Summary: Add multiple python versions on TC agents for testing 
pyignite
 Key: IGNITE-14740
 URL: https://issues.apache.org/jira/browse/IGNITE-14740
 Project: Ignite
  Issue Type: New Feature
  Components: python, thin client
Reporter: Ivan Daschinsky


In order to test {{pyignite}} against different python versions, I suggests 
followings

1. Install [pyenv|https://github.com/pyenv/pyenv]
2. Install through {{pyenv}} different python versions (3.6, 3.7, 3.8, 3.9)

Before invoking {{tox}}, script should invoke {{pyenv init --path}} and {{pyenv 
shell}} with specific python version. 




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14738) Remove pytest-runner dependency from setup.py

2021-05-19 Thread Peter Ivanov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347444#comment-17347444
 ] 

Peter Ivanov commented on IGNITE-14738:
---

I do not know such ¯\_(ツ)_/¯
Just assign new issue to me and I will take it in priority pool.

Thanks!

> Remove pytest-runner dependency from setup.py
> -
>
> Key: IGNITE-14738
> URL: https://issues.apache.org/jira/browse/IGNITE-14738
> Project: Ignite
>  Issue Type: Improvement
>  Components: python, thin client
>Affects Versions: python-0.4.0
>Reporter: Ivan Daschinsky
>Assignee: Ivan Daschinsky
>Priority: Major
>  Labels: python, thin
>
> This dependency should be removed
> 1. It is deprecated (see https://pypi.org/project/pytest-runner/)
> 2. We already adopted {{tox}} and use it in travis-ci
> 3. It cause some issues when trying to install source package from local pypi 
> mirror ({{pytest-runner}} should be installed separately before 
> {{pyignite}}). However, when installing directly from pypi.org, all works ok.
> But, unfortunatelly, our TC agents doesn't have {{tox}} installed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14738) Remove pytest-runner dependency from setup.py

2021-05-19 Thread Ivan Daschinsky (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347439#comment-17347439
 ] 

Ivan Daschinsky commented on IGNITE-14738:
--

[~vveider] Is there specific label for tickets for TC INFRA?

> Remove pytest-runner dependency from setup.py
> -
>
> Key: IGNITE-14738
> URL: https://issues.apache.org/jira/browse/IGNITE-14738
> Project: Ignite
>  Issue Type: Improvement
>  Components: python, thin client
>Affects Versions: python-0.4.0
>Reporter: Ivan Daschinsky
>Assignee: Ivan Daschinsky
>Priority: Major
>  Labels: python, thin
>
> This dependency should be removed
> 1. It is deprecated (see https://pypi.org/project/pytest-runner/)
> 2. We already adopted {{tox}} and use it in travis-ci
> 3. It cause some issues when trying to install source package from local pypi 
> mirror ({{pytest-runner}} should be installed separately before 
> {{pyignite}}). However, when installing directly from pypi.org, all works ok.
> But, unfortunatelly, our TC agents doesn't have {{tox}} installed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14738) Remove pytest-runner dependency from setup.py

2021-05-19 Thread Peter Ivanov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347437#comment-17347437
 ] 

Peter Ivanov commented on IGNITE-14738:
---

pyenv installation currently requires agent redesign in terms of provided 
versions of Python.
I will need some time for research.

Please, file separate ticket for this issue.

> Remove pytest-runner dependency from setup.py
> -
>
> Key: IGNITE-14738
> URL: https://issues.apache.org/jira/browse/IGNITE-14738
> Project: Ignite
>  Issue Type: Improvement
>  Components: python, thin client
>Affects Versions: python-0.4.0
>Reporter: Ivan Daschinsky
>Assignee: Ivan Daschinsky
>Priority: Major
>  Labels: python, thin
>
> This dependency should be removed
> 1. It is deprecated (see https://pypi.org/project/pytest-runner/)
> 2. We already adopted {{tox}} and use it in travis-ci
> 3. It cause some issues when trying to install source package from local pypi 
> mirror ({{pytest-runner}} should be installed separately before 
> {{pyignite}}). However, when installing directly from pypi.org, all works ok.
> But, unfortunatelly, our TC agents doesn't have {{tox}} installed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14708) Add an ability to track request handling completion in GridRestProcessor

2021-05-19 Thread Ignite TC Bot (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347390#comment-17347390
 ] 

Ignite TC Bot commented on IGNITE-14708:


{panel:title=Branch: [pull/9107/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/9107/head] Base: [master] : No new tests 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}{panel}
[TeamCity *-- Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=6013141buildTypeId=IgniteTests24Java8_RunAll]

> Add an ability to track request handling completion in GridRestProcessor
> 
>
> Key: IGNITE-14708
> URL: https://issues.apache.org/jira/browse/IGNITE-14708
> Project: Ignite
>  Issue Type: Improvement
>  Components: rest
>Affects Versions: 2.10
>Reporter: Andrey Kuznetsov
>Assignee: Sergei Ryzhov
>Priority: Major
> Fix For: 2.11
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> It would be useful to have a way to perform some actions when request 
> handling in {{GridRestProcessor}} is done, either normally or exceptionally. 
> This will allow thirdparty plugins to add tracking/monitoring behavior to 
> request processing.
> Probable implementation: allow to add custom listener for {{handleAsync0()}} 
> results. Listener should accept both request and result (response or 
> exception).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14077) Implement distributed SchemaManager.

2021-05-19 Thread Alexander Lapin (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347389#comment-17347389
 ] 

Alexander Lapin commented on IGNITE-14077:
--

[~amashenkov] LGTM from my side.

> Implement distributed SchemaManager.
> 
>
> Key: IGNITE-14077
> URL: https://issues.apache.org/jira/browse/IGNITE-14077
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Andrey Mashenkov
>Assignee: Andrey Mashenkov
>Priority: Major
>  Labels: iep-54, ignite-3
> Fix For: 3.0.0-alpha2
>
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> Create SchemaManager API and implement schema manager backed by distributed 
> metastorage
> with schema versioning logic for the "strict-schema" case.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (IGNITE-14077) Implement distributed SchemaManager.

2021-05-19 Thread Alexander Lapin (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-14077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Lapin updated IGNITE-14077:
-
Reviewer: Alexander Lapin

> Implement distributed SchemaManager.
> 
>
> Key: IGNITE-14077
> URL: https://issues.apache.org/jira/browse/IGNITE-14077
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Andrey Mashenkov
>Assignee: Andrey Mashenkov
>Priority: Major
>  Labels: iep-54, ignite-3
> Fix For: 3.0.0-alpha2
>
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> Create SchemaManager API and implement schema manager backed by distributed 
> metastorage
> with schema versioning logic for the "strict-schema" case.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (IGNITE-14739) Enable a permanent wal recording of transactions states records.

2021-05-19 Thread Stanilovsky Evgeny (Jira)
Stanilovsky Evgeny created IGNITE-14739:
---

 Summary: Enable a permanent wal recording of transactions states 
records.
 Key: IGNITE-14739
 URL: https://issues.apache.org/jira/browse/IGNITE-14739
 Project: Ignite
  Issue Type: Improvement
  Components: persistence
Affects Versions: 2.10
Reporter: Stanilovsky Evgeny
Assignee: Stanilovsky Evgeny


After [1] was merged, i suggest to enable transactions states wal logging on a 
permanent basis. This will allow to correctly restore transactional states 
after partial or whole nodes crash. 

[1] https://issues.apache.org/jira/browse/IGNITE-6324




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14738) Remove pytest-runner dependency from setup.py

2021-05-19 Thread Ivan Daschinsky (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347331#comment-17347331
 ] 

Ivan Daschinsky commented on IGNITE-14738:
--

Yep, that's enough. Is there only python 3.8 available on TC? 
Is it possible also  to install {{pyenv}} on TC and use multiple python for 
testing?
(https://github.com/pyenv/pyenv).

> Remove pytest-runner dependency from setup.py
> -
>
> Key: IGNITE-14738
> URL: https://issues.apache.org/jira/browse/IGNITE-14738
> Project: Ignite
>  Issue Type: Improvement
>  Components: python, thin client
>Affects Versions: python-0.4.0
>Reporter: Ivan Daschinsky
>Assignee: Ivan Daschinsky
>Priority: Major
>  Labels: python, thin
>
> This dependency should be removed
> 1. It is deprecated (see https://pypi.org/project/pytest-runner/)
> 2. We already adopted {{tox}} and use it in travis-ci
> 3. It cause some issues when trying to install source package from local pypi 
> mirror ({{pytest-runner}} should be installed separately before 
> {{pyignite}}). However, when installing directly from pypi.org, all works ok.
> But, unfortunatelly, our TC agents doesn't have {{tox}} installed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-14738) Remove pytest-runner dependency from setup.py

2021-05-19 Thread Peter Ivanov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-14738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347318#comment-17347318
 ] 

Peter Ivanov commented on IGNITE-14738:
---

[~ivandasch] — how to install this package?
{code}
pip install tox
{code} ?

> Remove pytest-runner dependency from setup.py
> -
>
> Key: IGNITE-14738
> URL: https://issues.apache.org/jira/browse/IGNITE-14738
> Project: Ignite
>  Issue Type: Improvement
>  Components: python, thin client
>Affects Versions: python-0.4.0
>Reporter: Ivan Daschinsky
>Assignee: Ivan Daschinsky
>Priority: Major
>  Labels: python, thin
>
> This dependency should be removed
> 1. It is deprecated (see https://pypi.org/project/pytest-runner/)
> 2. We already adopted {{tox}} and use it in travis-ci
> 3. It cause some issues when trying to install source package from local pypi 
> mirror ({{pytest-runner}} should be installed separately before 
> {{pyignite}}). However, when installing directly from pypi.org, all works ok.
> But, unfortunatelly, our TC agents doesn't have {{tox}} installed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)