[jira] [Created] (IGNITE-13114) Off-by-one error in GridPortProcessor port number assertion
Chris Dennis created IGNITE-13114: - Summary: Off-by-one error in GridPortProcessor port number assertion Key: IGNITE-13114 URL: https://issues.apache.org/jira/browse/IGNITE-13114 Project: Ignite Issue Type: Bug Reporter: Chris Dennis GridPortProcessor asserts that the provided port number is `> 0` and `< 65535`. This upper bounds check should be `<= 65535`. Since this is a Java language assert it's likely to never be tripped in any production system, but could be seen when using Ignite in a testing environment that turns on these assertions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-13114) Off-by-one error in GridPortProcessor port number assertion
[ https://issues.apache.org/jira/browse/IGNITE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Dennis updated IGNITE-13114: -- Flags: Patch Patcha available here: https://github.com/apache/ignite/pull/7896 > Off-by-one error in GridPortProcessor port number assertion > --- > > Key: IGNITE-13114 > URL: https://issues.apache.org/jira/browse/IGNITE-13114 > Project: Ignite > Issue Type: Bug >Reporter: Chris Dennis >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > GridPortProcessor asserts that the provided port number is `> 0` and `< > 65535`. This upper bounds check should be `<= 65535`. Since this is a Java > language assert it's likely to never be tripped in any production system, but > could be seen when using Ignite in a testing environment that turns on these > assertions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IGNITE-13114) Off-by-one error in GridPortProcessor port number assertion
[ https://issues.apache.org/jira/browse/IGNITE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Dennis updated IGNITE-13114: -- Flags: (was: Patch) > Off-by-one error in GridPortProcessor port number assertion > --- > > Key: IGNITE-13114 > URL: https://issues.apache.org/jira/browse/IGNITE-13114 > Project: Ignite > Issue Type: Bug >Reporter: Chris Dennis >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > GridPortProcessor asserts that the provided port number is `> 0` and `< > 65535`. This upper bounds check should be `<= 65535`. Since this is a Java > language assert it's likely to never be tripped in any production system, but > could be seen when using Ignite in a testing environment that turns on these > assertions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-13114) Off-by-one error in GridPortProcessor port number assertion
[ https://issues.apache.org/jira/browse/IGNITE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125022#comment-17125022 ] Chris Dennis commented on IGNITE-13114: --- Mentioning [~avinogradov] as a maintainer a requested. Note that this is currently formulated as a Daggy bug-fix ([https://wiki.monotone.ca/DaggyFixes/)] since this is the Git bug-fix pattern I am most used to (and because this bug is so old, and probably affect all Ignite releases). It either needs a manual merge fix via the github UI, or I'll need to create an integration branch for it. Let me know if more work is needed on my side. > Off-by-one error in GridPortProcessor port number assertion > --- > > Key: IGNITE-13114 > URL: https://issues.apache.org/jira/browse/IGNITE-13114 > Project: Ignite > Issue Type: Bug >Reporter: Chris Dennis >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > GridPortProcessor asserts that the provided port number is `> 0` and `< > 65535`. This upper bounds check should be `<= 65535`. Since this is a Java > language assert it's likely to never be tripped in any production system, but > could be seen when using Ignite in a testing environment that turns on these > assertions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (IGNITE-13114) Off-by-one error in GridPortProcessor port number assertion
[ https://issues.apache.org/jira/browse/IGNITE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125020#comment-17125020 ] Chris Dennis edited comment on IGNITE-13114 at 6/3/20, 2:51 PM: Patch available here: [https://github.com/apache/ignite/pull/7896] was (Author: chrisdennis): Patcha available here: https://github.com/apache/ignite/pull/7896 > Off-by-one error in GridPortProcessor port number assertion > --- > > Key: IGNITE-13114 > URL: https://issues.apache.org/jira/browse/IGNITE-13114 > Project: Ignite > Issue Type: Bug >Reporter: Chris Dennis >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > GridPortProcessor asserts that the provided port number is `> 0` and `< > 65535`. This upper bounds check should be `<= 65535`. Since this is a Java > language assert it's likely to never be tripped in any production system, but > could be seen when using Ignite in a testing environment that turns on these > assertions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (IGNITE-13114) Off-by-one error in GridPortProcessor port number assertion
[ https://issues.apache.org/jira/browse/IGNITE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125022#comment-17125022 ] Chris Dennis edited comment on IGNITE-13114 at 6/3/20, 2:51 PM: Mentioning [~avinogradov] as a maintainer as requested. Note that this is currently formulated as a Daggy bug-fix ([https://wiki.monotone.ca/DaggyFixes/)] since this is the Git bug-fix pattern I am most used to (and because this bug is so old, and probably affect all Ignite releases). It either needs a manual merge fix via the github UI, or I'll need to create an integration branch for it. Let me know if more work is needed on my side. was (Author: chrisdennis): Mentioning [~avinogradov] as a maintainer a requested. Note that this is currently formulated as a Daggy bug-fix ([https://wiki.monotone.ca/DaggyFixes/)] since this is the Git bug-fix pattern I am most used to (and because this bug is so old, and probably affect all Ignite releases). It either needs a manual merge fix via the github UI, or I'll need to create an integration branch for it. Let me know if more work is needed on my side. > Off-by-one error in GridPortProcessor port number assertion > --- > > Key: IGNITE-13114 > URL: https://issues.apache.org/jira/browse/IGNITE-13114 > Project: Ignite > Issue Type: Bug >Reporter: Chris Dennis >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > GridPortProcessor asserts that the provided port number is `> 0` and `< > 65535`. This upper bounds check should be `<= 65535`. Since this is a Java > language assert it's likely to never be tripped in any production system, but > could be seen when using Ignite in a testing environment that turns on these > assertions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-13114) Off-by-one error in GridPortProcessor port number assertion
[ https://issues.apache.org/jira/browse/IGNITE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127004#comment-17127004 ] Chris Dennis commented on IGNITE-13114: --- Rebased against latest master (as of yesterday). > Off-by-one error in GridPortProcessor port number assertion > --- > > Key: IGNITE-13114 > URL: https://issues.apache.org/jira/browse/IGNITE-13114 > Project: Ignite > Issue Type: Bug >Reporter: Chris Dennis >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > GridPortProcessor asserts that the provided port number is `> 0` and `< > 65535`. This upper bounds check should be `<= 65535`. Since this is a Java > language assert it's likely to never be tripped in any production system, but > could be seen when using Ignite in a testing environment that turns on these > assertions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-13114) Off-by-one error in GridPortProcessor port number assertion
[ https://issues.apache.org/jira/browse/IGNITE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834301#comment-17834301 ] Chris Dennis commented on IGNITE-13114: --- Rebased this again today. Anyone care to merge a trivial fix to a decade old, obvious off-by-one bug? > Off-by-one error in GridPortProcessor port number assertion > --- > > Key: IGNITE-13114 > URL: https://issues.apache.org/jira/browse/IGNITE-13114 > Project: Ignite > Issue Type: Bug >Reporter: Chris Dennis >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > GridPortProcessor asserts that the provided port number is `> 0` and `< > 65535`. This upper bounds check should be `<= 65535`. Since this is a Java > language assert it's likely to never be tripped in any production system, but > could be seen when using Ignite in a testing environment that turns on these > assertions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-13114) Off-by-one error in GridPortProcessor port number assertion
[ https://issues.apache.org/jira/browse/IGNITE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834359#comment-17834359 ] Chris Dennis commented on IGNITE-13114: --- I did, I mentioned you 4 years ago when I originally created the PR ;) > Off-by-one error in GridPortProcessor port number assertion > --- > > Key: IGNITE-13114 > URL: https://issues.apache.org/jira/browse/IGNITE-13114 > Project: Ignite > Issue Type: Bug >Reporter: Chris Dennis >Priority: Minor > Fix For: 2.17 > > Time Spent: 20m > Remaining Estimate: 0h > > GridPortProcessor asserts that the provided port number is `> 0` and `< > 65535`. This upper bounds check should be `<= 65535`. Since this is a Java > language assert it's likely to never be tripped in any production system, but > could be seen when using Ignite in a testing environment that turns on these > assertions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
