[jira] [Commented] (IGNITE-7128) .NET: Add missing DataRegionMetrics
[
https://issues.apache.org/jira/browse/IGNITE-7128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750700#comment-16750700
]
Lev Khenkin commented on IGNITE-7128:
-
[~ptupitsyn] Latest tc run seems to be ok. Could you please take a look again?
> .NET: Add missing DataRegionMetrics
> ---
>
> Key: IGNITE-7128
> URL: https://issues.apache.org/jira/browse/IGNITE-7128
> Project: Ignite
> Issue Type: Improvement
> Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Lev Khenkin
>Priority: Minor
> Labels: .NET
> Time Spent: 10m
> Remaining Estimate: 0h
>
> See {{DataRegionMetricsParityTest}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-7128) .NET: Add missing DataRegionMetrics
[
https://issues.apache.org/jira/browse/IGNITE-7128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750424#comment-16750424
]
Lev Khenkin commented on IGNITE-7128:
-
[~ptupitsyn] I've fixed. Should I rerun .NET suite?
> .NET: Add missing DataRegionMetrics
> ---
>
> Key: IGNITE-7128
> URL: https://issues.apache.org/jira/browse/IGNITE-7128
> Project: Ignite
> Issue Type: Improvement
> Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Lev Khenkin
>Priority: Minor
> Labels: .NET
> Time Spent: 10m
> Remaining Estimate: 0h
>
> See {{DataRegionMetricsParityTest}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-7128) .NET: Add missing DataRegionMetrics
[
https://issues.apache.org/jira/browse/IGNITE-7128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750416#comment-16750416
]
Lev Khenkin commented on IGNITE-7128:
-
[~ptupitsyn] Yes, I think your solution is perfect. I will add
CheckpointBufferPages with value 0 and mark it as obsolete. Thank you
> .NET: Add missing DataRegionMetrics
> ---
>
> Key: IGNITE-7128
> URL: https://issues.apache.org/jira/browse/IGNITE-7128
> Project: Ignite
> Issue Type: Improvement
> Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Lev Khenkin
>Priority: Minor
> Labels: .NET
> Time Spent: 10m
> Remaining Estimate: 0h
>
> See {{DataRegionMetricsParityTest}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-7128) .NET: Add missing DataRegionMetrics
[
https://issues.apache.org/jira/browse/IGNITE-7128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750124#comment-16750124
]
Lev Khenkin commented on IGNITE-7128:
-
[~ptupitsyn] So this patch also fixes possible mistake. I.e.
getUsedCheckpointBufferSize() often returns 0 (if there is not ongoing
checkpointing), but getCheckpointBufferSize() doesn't equals 0, value is taken
from config. So in .NET before my patch user can get wrong metrics.
> .NET: Add missing DataRegionMetrics
> ---
>
> Key: IGNITE-7128
> URL: https://issues.apache.org/jira/browse/IGNITE-7128
> Project: Ignite
> Issue Type: Improvement
> Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Lev Khenkin
>Priority: Minor
> Labels: .NET
> Time Spent: 10m
> Remaining Estimate: 0h
>
> See {{DataRegionMetricsParityTest}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-7128) .NET: Add missing DataRegionMetrics
[
https://issues.apache.org/jira/browse/IGNITE-7128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750118#comment-16750118
]
Lev Khenkin commented on IGNITE-7128:
-
[~ptupitsyn] Pavel, but old version is obviously not right.
In PlatformClusterGroup we write even before my patch
{code:java}
writer.writeLong(metrics.getUsedCheckpointBufferPages());
writer.writeLong(metrics.getUsedCheckpointBufferSize());
{code}
And in .net we read this as CheckpointBufferPages and CheckpointBufferSize
before my patch.
For me this is a mistake and I fixed it.
> .NET: Add missing DataRegionMetrics
> ---
>
> Key: IGNITE-7128
> URL: https://issues.apache.org/jira/browse/IGNITE-7128
> Project: Ignite
> Issue Type: Improvement
> Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Lev Khenkin
>Priority: Minor
> Labels: .NET
> Time Spent: 10m
> Remaining Estimate: 0h
>
> See {{DataRegionMetricsParityTest}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-7128) .NET: Add missing DataRegionMetrics
[
https://issues.apache.org/jira/browse/IGNITE-7128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749682#comment-16749682
]
Lev Khenkin commented on IGNITE-7128:
-
[~ptupitsyn] Pavel, my patch is ready, TC run seems good, could you please
review my patch?
> .NET: Add missing DataRegionMetrics
> ---
>
> Key: IGNITE-7128
> URL: https://issues.apache.org/jira/browse/IGNITE-7128
> Project: Ignite
> Issue Type: Improvement
> Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Lev Khenkin
>Priority: Minor
> Labels: .NET
> Time Spent: 10m
> Remaining Estimate: 0h
>
> See {{DataRegionMetricsParityTest}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (IGNITE-7128) .NET: Add missing DataRegionMetrics
[
https://issues.apache.org/jira/browse/IGNITE-7128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lev Khenkin reassigned IGNITE-7128:
---
Assignee: Lev Khenkin
> .NET: Add missing DataRegionMetrics
> ---
>
> Key: IGNITE-7128
> URL: https://issues.apache.org/jira/browse/IGNITE-7128
> Project: Ignite
> Issue Type: Improvement
> Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Lev Khenkin
>Priority: Minor
> Labels: .NET
> Time Spent: 10m
> Remaining Estimate: 0h
>
> See {{DataRegionMetricsParityTest}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-7128) .NET: Add missing DataRegionMetrics
[
https://issues.apache.org/jira/browse/IGNITE-7128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749133#comment-16749133
]
Lev Khenkin commented on IGNITE-7128:
-
Hi! I've done PR with fix, but cannot assign jira to me :( Please, add me
rights.
> .NET: Add missing DataRegionMetrics
> ---
>
> Key: IGNITE-7128
> URL: https://issues.apache.org/jira/browse/IGNITE-7128
> Project: Ignite
> Issue Type: Improvement
> Components: platforms
>Reporter: Pavel Tupitsyn
>Priority: Minor
> Labels: .NET
> Time Spent: 10m
> Remaining Estimate: 0h
>
> See {{DataRegionMetricsParityTest}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
