[jira] (IGNITE-17541) Add "set" prefix to ThinClientConfiguration#sendServerExceptionStackTraceToClient()

2022-09-12 Thread Julia Bakulina (Jira) 


[ https://issues.apache.org/jira/browse/IGNITE-17541 ]


Julia Bakulina deleted comment on IGNITE-17541:
-

was (Author: JIRAUSER294860):
[~NSAmelchev], could you please review the changes?
They are almost fully checked by the previous reviewer.
Green visa https://mtcga.gridgain.com/prs.html

> Add "set" prefix to 
> ThinClientConfiguration#sendServerExceptionStackTraceToClient()
> ---
>
> Key: IGNITE-17541
> URL: https://issues.apache.org/jira/browse/IGNITE-17541
> Project: Ignite
>  Issue Type: Improvement
>  Components: thin client
>Affects Versions: 2.13
>Reporter: Ilya Shishkov
>Assignee: Julia Bakulina
>Priority: Minor
>  Labels: ise, newbie
> Fix For: 2.15
>
> Attachments: Client_configuration_test.patch
>
>  Time Spent: 5h 25m
>  Remaining Estimate: 0h
>
> IGNITE-13389 introduces 
> {{ThinClientConfiguration#sendServerExceptionStackTraceToClient()}}, but name 
> of the method does not allow to set up this option in XML configuration, 
> because Spring expects "set" prefix for setters.
> As you can see below, there is a workaround, but it would be more convenient 
> to set up this property directly.
> Workaround:
> {code:xml|title=Add extra ThinClientConfiguration bean with necessary 
> parameters}
>  class="org.apache.ignite.configuration.ThinClientConfiguration">
> 
> 
> {code}
> {code:xml|title=Set up thinClientConfiguration by means of SpEL}
> 
>  class="org.apache.ignite.configuration.ClientConnectorConfiguration">
>
> value="#{thinClientCfg.sendServerExceptionStackTraceToClient(true)}"/>
> 
> 
> {code}
> We should add "set" and "get" prefix to setter and getter methods 
> respectively or add extra methods with such prefixes from the point of 
> possible compatibility issues (see IGNITE-16549).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] (IGNITE-17541) Add "set" prefix to ThinClientConfiguration#sendServerExceptionStackTraceToClient()

2022-09-01 Thread Julia Bakulina (Jira) 


[ https://issues.apache.org/jira/browse/IGNITE-17541 ]


Julia Bakulina deleted comment on IGNITE-17541:
-

was (Author: JIRAUSER294860):
[~ivandasch], could you please review the changes? Not sure what fix version to 
include

> Add "set" prefix to 
> ThinClientConfiguration#sendServerExceptionStackTraceToClient()
> ---
>
> Key: IGNITE-17541
> URL: https://issues.apache.org/jira/browse/IGNITE-17541
> Project: Ignite
>  Issue Type: Improvement
>  Components: thin client
>Affects Versions: 2.13
>Reporter: Ilya Shishkov
>Assignee: Julia Bakulina
>Priority: Minor
>  Labels: ise, newbie
>  Time Spent: 2h 25m
>  Remaining Estimate: 0h
>
> IGNITE-13389 introduces 
> {{ThinClientConfiguration#sendServerExceptionStackTraceToClient()}}, but name 
> of the method does not allow to set up this option in XML configuration, 
> because Spring expects "set" prefix for setters.
> As you can see below, there is a workaround, but it would be more convenient 
> to set up this property directly.
> Workaround:
> {code:xml|title=Add extra ThinClientConfiguration bean with necessary 
> parameters}
>  class="org.apache.ignite.configuration.ThinClientConfiguration">
> 
> 
> {code}
> {code:xml|title=Set up thinClientConfiguration by means of SpEL}
> 
>  class="org.apache.ignite.configuration.ClientConnectorConfiguration">
>
> value="#{thinClientCfg.sendServerExceptionStackTraceToClient(true)}"/>
> 
> 
> {code}
> We should add "set" and "get" prefix to setter and getter methods 
> respectively or add extra methods with such prefixes from the point of 
> possible compatibility issues (see IGNITE-16549).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)