[jira] [Comment Edited] (IGNITE-11226) SQL: Remove GridQueryIndexing.prepareNativeStatement
[ https://issues.apache.org/jira/browse/IGNITE-11226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16794923#comment-16794923 ] Pavel Kuznetsov edited comment on IGNITE-11226 at 3/18/19 10:55 AM: [~vozerov] there are troubles with bot visa. Visa can be viewed at https://mtcga.gridgain.com/pr.html?serverId=apache&suiteId=IgniteTests24Java8_RunAll&branchForTc=pull/6258/head&action=Latest 1) Inspections log tells about JobStealingCollisionSpi.java - out of the scope (https://ci.ignite.apache.org/viewLog.html?buildId=3339821) 2) MVCC Queries Failed due to timeout https://ci.ignite.apache.org/viewLog.html?buildId=3339776 3) PHP client tests failed due to auth troubles : https://ci.ignite.apache.org/viewLog.html?buildId=3339777 these tests failed in master (for exampl https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=-5512920338110762681&tab=testDetails) was (Author: pkouznet): [~vozerov] there are troubles with bot visa. Visa can be viewed at https://mtcga.gridgain.com/pr.html?serverId=apache&suiteId=IgniteTests24Java8_RunAll&branchForTc=pull/6258/head&action=Latest 1) Inspections log tells about JobStealingCollisionSpi.java - out of the scope (https://ci.ignite.apache.org/viewLog.html?buildId=3339821) 2) MVCC Queries Failed due to timeout https://ci.ignite.apache.org/viewLog.html?buildId=3339776 3) PHP client tests failed due to auth troubles : https://ci.ignite.apache.org/viewLog.html?buildId=3339777 > SQL: Remove GridQueryIndexing.prepareNativeStatement > > > Key: IGNITE-11226 > URL: https://issues.apache.org/jira/browse/IGNITE-11226 > Project: Ignite > Issue Type: Task > Components: sql >Reporter: Vladimir Ozerov >Assignee: Pavel Kuznetsov >Priority: Major > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > This method is the only leak of H2 internals to the outer code. Close > analysis of code reveals that the only reason we have it is *JDBC metadata*. > Need to create a method which will prepare metadata for a statement and > return it as a detached object. Most probably we already have all necessary > mechanics. This is more about refactoring. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (IGNITE-11226) SQL: Remove GridQueryIndexing.prepareNativeStatement
[ https://issues.apache.org/jira/browse/IGNITE-11226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793484#comment-16793484 ] Vladimir Ozerov edited comment on IGNITE-11226 at 3/15/19 9:31 AM: --- [~pkouznet], the fix is not ready. {{prepareNativeStatement}} is still public, multiple test failures. was (Author: vozerov): [~pkouznet], the fix is not ready. {{prepareNativeStatement}} is still public. > SQL: Remove GridQueryIndexing.prepareNativeStatement > > > Key: IGNITE-11226 > URL: https://issues.apache.org/jira/browse/IGNITE-11226 > Project: Ignite > Issue Type: Task > Components: sql >Reporter: Vladimir Ozerov >Assignee: Pavel Kuznetsov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > This method is the only leak of H2 internals to the outer code. Close > analysis of code reveals that the only reason we have it is *JDBC metadata*. > Need to create a method which will prepare metadata for a statement and > return it as a detached object. Most probably we already have all necessary > mechanics. This is more about refactoring. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (IGNITE-11226) SQL: Remove GridQueryIndexing.prepareNativeStatement
[ https://issues.apache.org/jira/browse/IGNITE-11226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793484#comment-16793484 ] Vladimir Ozerov edited comment on IGNITE-11226 at 3/15/19 9:29 AM: --- [~pkouznet], the fix is not ready. {{prepareNativeStatement}} is still public. was (Author: vozerov): [~pkouznet], the fix is not ready. {{prepareNativeStatement}} is still public. As far as > SQL: Remove GridQueryIndexing.prepareNativeStatement > > > Key: IGNITE-11226 > URL: https://issues.apache.org/jira/browse/IGNITE-11226 > Project: Ignite > Issue Type: Task > Components: sql >Reporter: Vladimir Ozerov >Assignee: Pavel Kuznetsov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > This method is the only leak of H2 internals to the outer code. Close > analysis of code reveals that the only reason we have it is *JDBC metadata*. > Need to create a method which will prepare metadata for a statement and > return it as a detached object. Most probably we already have all necessary > mechanics. This is more about refactoring. -- This message was sent by Atlassian JIRA (v7.6.3#76005)