[jira] [Comment Edited] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158415#comment-16158415
]
Taras Ledkov edited comment on IGNITE-4756 at 9/8/17 10:29 AM:
---
[~javaller], looks good. Please do the minor cosmetic changes:
# {{GridAffinityAssignmentCache}} fix import order.
# {{GridAffinityAssignmentCache#printDistribution}} please use {{partsCnt}}
instead of the {{assignment.size()}} to calculate {{expectedCnt}}
# {{AffinityDistributionPrintLogTest}} unused member {{log}}
# Naming / semantic of the {{dflt}} parameter of the
{{AffinityDistributionPrintLogTest#print}}. Must be "not default"?
was (Author: tledkov-gridgain):
[~javaller], looks good. Please do the minor cosmetic changes:
# {{GridAffinityAssignmentCache}} fix import order.
# {{GridAffinityAssignmentCache#printDistribution}} please use {{partsCnt}}
instead of the {{assignment.size()}} to calculate {{expectedCnt}}
# {{AffinityDistributionPrintLogTest}} unused member {{log}}
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.3
>
>
> Summarize discussions:
> Add log message in case partitions distribution is not close to even
> distribution:
> # Add system property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD with default
> value 0.1 to print warn message only when nodes count differs more then
> threshold;
> # The statistic is calculated and printed only for the local node;
> # Statistic is placed at the {{GridAffinityAssignmentCache#calculate}} and
> calculated for new {{idealAssignment}}.
> # Message format is
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=,
> expectedPrimary=,
> exectedBackups=,
> primary=, backups=].
> {noformat}
> e.g. for cache with name "test", 2 backups, 4 partition, 3 nodes:
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=test,
> expectedPrimary=1.33 (33.3%), exectedBackups=2.66 (66.66%), primary=1 (25%),
> backups=3(75%)].
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158415#comment-16158415
]
Taras Ledkov edited comment on IGNITE-4756 at 9/8/17 10:10 AM:
---
[~javaller], looks good. Please do the minor cosmetic changes:
# {{GridAffinityAssignmentCache}} fix import order.
# {{GridAffinityAssignmentCache#printDistribution}} please use {{partsCnt}}
instead of the {{assignment.size()}} to calculate {{expectedCnt}}
# {{AffinityDistributionPrintLogTest}} unused member {{log}}
was (Author: tledkov-gridgain):
[~javaller], looks good. Please do the minor cosmetic changes:
# {{GridAffinityAssignmentCache}} fix import order.
# {{GridAffinityAssignmentCache#printDistribution}} please use {{partsCnt}}
instead of the {{assignment.size()}} to calculate {{expectedCnt}}
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.3
>
>
> Summarize discussions:
> Add log message in case partitions distribution is not close to even
> distribution:
> # Add system property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD with default
> value 0.1 to print warn message only when nodes count differs more then
> threshold;
> # The statistic is calculated and printed only for the local node;
> # Statistic is placed at the {{GridAffinityAssignmentCache#calculate}} and
> calculated for new {{idealAssignment}}.
> # Message format is
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=,
> expectedPrimary=,
> exectedBackups=,
> primary=, backups=].
> {noformat}
> e.g. for cache with name "test", 2 backups, 4 partition, 3 nodes:
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=test,
> expectedPrimary=1.33 (33.3%), exectedBackups=2.66 (66.66%), primary=1 (25%),
> backups=3(75%)].
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152677#comment-16152677
]
Vadim Opolski edited comment on IGNITE-4756 at 9/4/17 2:51 PM:
---
[~tledkov-gridgain] [~avinogradov] In my opinion tests - [TC
#2557|https://ci.ignite.apache.org/viewType.html?buildTypeId=Ignite20Tests_RunAll&branch_Ignite20Tests=pull%2F2557%2Fhead&tab=buildTypeStatusDiv]
look good.
was (Author: javaller):
[~tledkov-gridgain] [~avinogradov] In my opinion tests look good. [TC
#2557|https://ci.ignite.apache.org/viewType.html?buildTypeId=Ignite20Tests_RunAll&branch_Ignite20Tests=pull%2F2557%2Fhead&tab=buildTypeStatusDiv]
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.3
>
>
> Summarize discussions:
> Add log message in case partitions distribution is not close to even
> distribution:
> # Add system property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD with default
> value 0.1 to print warn message only when nodes count differs more then
> threshold;
> # The statistic is calculated and printed only for the local node;
> # Statistic is placed at the {{GridAffinityAssignmentCache#calculate}} and
> calculated for new {{idealAssignment}}.
> # Message format is
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=,
> expectedPrimary=,
> exectedBackups=,
> primary=, backups=].
> {noformat}
> e.g. for cache with name "test", 2 backups, 4 partition, 3 nodes:
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=test,
> expectedPrimary=1.33 (33.3%), exectedBackups=2.66 (66.66%), primary=1 (25%),
> backups=3(75%)].
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083691#comment-16083691
]
Vadim Opolski edited comment on IGNITE-4756 at 7/12/17 9:38 AM:
[~tledkov-gridgain] [~avinogradov] Log4JLogger dependency removed from core
module. Log have been initialize early. I'm working on printing cache group
name in log and calculating statistics only for loacal node. What's the next
step?
was (Author: javaller):
[~tledkov-gridgain] [~avinogradov] Log4JLogger dependency removed from core
module. Log have been initialize early. I'm working on printing cache group
name in log and calculating statistics only for loacal node. What the next step?
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.2
>
>
> Summarize discussions:
> Add log message in case partitions distribution is not close to even
> distribution:
> # Add system property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD with default
> value 0.1 to print warn message only when nodes count differs more then
> threshold;
> # The statistic is calculated and printed only for the local node;
> # Statistic is placed at the {{GridAffinityAssignmentCache#calculate}} and
> calculated for new {{idealAssignment}}.
> # Message format is
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=,
> expectedPrimary=,
> exectedBackups=,
> primary=, backups=].
> {noformat}
> e.g. for cache with name "test", 2 backups, 4 partition, 3 nodes:
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=test,
> expectedPrimary=1.33 (33.3%), exectedBackups=2.66 (66.66%), primary=1 (25%),
> backups=4(100%)].
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082134#comment-16082134
]
Vadim Opolski edited comment on IGNITE-4756 at 7/11/17 12:34 PM:
-
[~tledkov-gridgain] [~avinogradov] Changing logging in progress.
was (Author: javaller):
Removing Log4JLogger in progress.
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.2
>
>
> Summarize discussions:
> Add log message in case partitions distribution is not close to even
> distribution:
> # Add system property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD with default
> value 0.1 to print warn message only when nodes count differs more then
> threshold;
> # The statistic is calculated and printed only for the local node;
> # Statistic is placed at the {{GridAffinityAssignmentCache#calculate}} and
> calculated for new {{idealAssignment}}.
> # Message format is
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=,
> expectedPrimary=,
> exectedBackups=,
> primary=, backups=].
> {noformat}
> e.g. for cache with name "test", 2 backups, 4 partition, 3 nodes:
> {noformat}
> Local node affinity assignment distribution is not ideal [cache=test,
> expectedPrimary=1.33 (33.3%), exectedBackups=2.66 (66.66%), primary=1 (25%),
> backups=4(100%)].
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078171#comment-16078171
]
Taras Ledkov edited comment on IGNITE-4756 at 7/7/17 2:43 PM:
--
[~javaller], my comments:
# You mustn't initialize {{log}} member at the
{{RendezvousAffinityFunctionSimpleBenchmark#beforeTestsStarted}}. It have been
initialized early.
# Then Log4JLogger dependency is not needed. Please remove it from the {{core}}
module.
was (Author: tledkov-gridgain):
[~javaller], my comments:
# You mustn't initialize {log} member at the
{{RendezvousAffinityFunctionSimpleBenchmark#beforeTestsStarted}}. It have been
initialized early.
# Then Log4JLogger dependency is not needed. Please remove it from the {{core}}
module.
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.2
>
>
> Summarize discussions:
> Add log message in case partitions distribution is not close to even
> distribution:
> # Add system property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD with default
> value 0.1 to print warn message only when nodes count differs more then
> threshold;
> # The statistic is calculated and printed only for the local node;
> # Message format is
> {noformat}
> Affinity assignment distribution not even [cache=,
> even=, distribution=[,
> ..., ]].
> {noformat}
> e.g. for cache with name "test", 2 backups and (partitions count / nodes
> count) == 100 :
> {noformat}
> Affinity assignment distribution not even [cache=test, even=100 (10%),
> distribution=[100 (10%), 150 (15%), 500 (50%)]].
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16074861#comment-16074861
]
Taras Ledkov edited comment on IGNITE-4756 at 7/5/17 2:35 PM:
--
[~javaller] my comments:
# Ignite logger must not be created in constructor of AF. It is injected by
Ignite on affinity function initialization (see more about @LoggerResource and
@IgniteInstanceResource annotations);
At the tests use test injection:
{{GridTestUtils.setFieldValue(aff, "log", log);}}
# Statistic must be calculated only for local node (only for one node). The
part of calculation (increment of count) can be placed inside the method
{{assignPartition}}; Local node ID can be gathered from ignite instance (see
@IgniteInstanceResource annotations);
# The statistic structure for one node will be simplified to integer array
({{int[] stat}}) that contains counts of partitions (primary, back1, backup2,
etc);
was (Author: tledkov-gridgain):
[~javaller] my comments:
# Ignite logger must not be created in constructor of AF. It is injected by
Ignite on affinity function initialization (see more about @LoggerResource and
@IgniteInstanceResource annotations);
# Statistic must be calculated only for local node (only for one node). The
part of calculation (increment of count) can be placed inside the method
{{assignPartition}}; Local node ID can be gathered from ignite instance (see
@IgniteInstanceResource annotations);
# The statistic structure for one node will be simplified to integer array
({{int[] stat}}) that contains counts of partitions (primary, back1, backup2,
etc);
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.2
>
>
> Print information about affinity assignment to log.
> e.g.:
> {noformat}
> : primary, [, ,
> ], ..., [, ,
> ]
> : backup_0, [, ,
> ], ..., [, ,
> ]
> ...
> : backup_N, [, ,
> ], ..., [, ,
> ]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049263#comment-16049263
]
Taras Ledkov edited comment on IGNITE-4756 at 6/15/17 8:46 AM:
---
If I catch your question right:
# Your patch will be placed at the {{RendezvousAffinityFunction}};
# Add the system property to disable calculate/print the partition statistic;
# Calculates statistic (the partitions count for the replicas (primary,
backup_0, ... etc.)) on the assignment calculation. Take a look at the
{{assignPartition}} method.
# Revert the {{Ignite ignite}} member of the {{RendezvousAffinityFunction}}
(see the file history) to gather the local node and calculate statistic only
for local node.
# Print the statistic at the end of the {{assignPartitions}} method.
# To print cache / group name in log message we have to add the {{name}} member
to the {{AffinityFunctionContext}} and set it at the
{{GridAffinityAssignmentCache#calculate}}.
was (Author: tledkov-gridgain):
If I catch your question right:
# Your patch will be placed at the {{RendezvousAffinityFunction}};
# Add the system property to disable calculate/print the partition statistic;
# Calculates statistic (the partitions count for the replicas (primary,
backup_0, ... etc.)) on the assignment calculation. Take a look at the
{{assignPartition}} method.
# Revert the {{Ignite ignite}} member of the {{RendezvousAffinityFunction}}
(see the file history) to gather the local node and calculate statistic only
for local node.
# Print the statistic at the end of the {{assignPartitions}} method.
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.1
>
>
> Print information about affinity assignment to log.
> e.g.:
> {noformat}
> : primary, [, ,
> ], ..., [, ,
> ]
> : backup_0, [, ,
> ], ..., [, ,
> ]
> ...
> : backup_N, [, ,
> ], ..., [, ,
> ]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049263#comment-16049263
]
Taras Ledkov edited comment on IGNITE-4756 at 6/14/17 3:27 PM:
---
If I catch your question right:
# Your patch will be placed at the {{RendezvousAffinityFunction}};
# Add the system property to disable calculate/print the partition statistic;
# Calculates statistic (the partitions count for the replicas (primary,
backup_0, ... etc.)) on the assignment calculation. Take a look at the
{{assignPartition}} method.
# Revert the {{Ignite ignite}} member of the {{RendezvousAffinityFunction}}
(see the file history) to gather the local node and calculate statistic only
for local node.
# Print the statistic at the end of the {{assignPartitions}} method.
was (Author: tledkov-gridgain):
If I catch your question right:
# Your patch will be placed at the {{RendezvousAffinityFunction}};
# Add the system property to disable calculate/print the partition statistic;
# Calculates statistic (the partitions count for the replicas (primary,
backup_0, ... etc.)) on the assignment calculation. Take a look at the
{{assignPartition}} method.
# Revert the {{Ignite ignite}} member of the {{RendezvousAffinityFunction}}
(see the file history) to gather the local node and calculate statistic only
for local node.
# Print the statistic et the end of the {{assignPartitions}} method.
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.1
>
>
> Print information about affinity assignment to log.
> e.g.:
> {noformat}
> : primary, [, ,
> ], ..., [, ,
> ]
> : backup_0, [, ,
> ], ..., [, ,
> ]
> ...
> : backup_N, [, ,
> ], ..., [, ,
> ]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049263#comment-16049263
]
Taras Ledkov edited comment on IGNITE-4756 at 6/14/17 3:26 PM:
---
If I catch your question right:
# Your patch will be placed at the {{RendezvousAffinityFunction}};
# Add the system property to disable calculate/print the partition statistic;
# Calculates statistic (the partitions count for the replicas (primary,
backup_0, ... etc.)) on the assignment calculation. Take a look at the
{{assignPartition}} method.
# Revert the {{Ignite ignite}} member of the {{RendezvousAffinityFunction}}
(see the file history) to gather the local node and calculate statistic only
for local node.
# Print the statistic et the end of the {{assignPartitions}} method.
was (Author: tledkov-gridgain):
If I catch your question right:
# Your patch will be placed at the {{RendezvousAffinityFunction}};
# Add the system property to disable calculate/print the partition statistic;
# Calculates statistic (the partitions count for the replicas (primary,
backup_0, ... etc.)) on the assignment calculation take a look at the
{{assignPartition}} method.
# Revert the {{Ignite ignite}} member of the {{RendezvousAffinityFunction}}
(see the file history) to gather the local node and calculate statistic only
for local node.
# Print the statistic et the end of the {{assignPartitions}} method.
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.1
>
>
> Print information about affinity assignment to log.
> e.g.:
> {noformat}
> : primary, [, ,
> ], ..., [, ,
> ]
> : backup_0, [, ,
> ], ..., [, ,
> ]
> ...
> : backup_N, [, ,
> ], ..., [, ,
> ]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (IGNITE-4756) Print info about partition distribution to log
[
https://issues.apache.org/jira/browse/IGNITE-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049263#comment-16049263
]
Taras Ledkov edited comment on IGNITE-4756 at 6/14/17 3:25 PM:
---
If I catch your question right:
# Your patch will be placed at the {{RendezvousAffinityFunction}};
# Add the system property to disable calculate/print the partition statistic;
# Calculates statistic (the partitions count for the replicas (primary,
backup_0, ... etc.)) on the assignment calculation take a look at the
{{assignPartition}} method.
# Revert the {{Ignite ignite}} member of the {{RendezvousAffinityFunction}}
(see the file history) to gather the local node and calculate statistic only
for local node.
# Print the statistic et the end of the {{assignPartitions}} method.
was (Author: tledkov-gridgain):
If I catch your question right:
# You patch will be placed at the {{RendezvousAffinityFunction}};
# Add the system property to disable calculate/print the partition statistic;
# Calculates statistic (the partitions count for the replicas (primary,
backup_0, ... etc.)) on the assignment calculation take a look at the
{{assignPartition}} method.
# Revert the {{Ignite ignite}} member of the {{RendezvousAffinityFunction}}
(see the file history) to gather the local node and calculate statistic only
for local node.
# Print the statistic et the end of the {{assignPartitions}} method.
> Print info about partition distribution to log
> ---
>
> Key: IGNITE-4756
> URL: https://issues.apache.org/jira/browse/IGNITE-4756
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Reporter: Taras Ledkov
>Assignee: Vadim Opolski
>Priority: Minor
> Labels: newbie
> Fix For: 2.1
>
>
> Print information about affinity assignment to log.
> e.g.:
> {noformat}
> : primary, [, ,
> ], ..., [, ,
> ]
> : backup_0, [, ,
> ], ..., [, ,
> ]
> ...
> : backup_N, [, ,
> ], ..., [, ,
> ]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
