[jira] [Comment Edited] (IGNITE-6442) Deadlock detection doesn't execute.
[ https://issues.apache.org/jira/browse/IGNITE-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180625#comment-16180625 ] Vitaliy Biryukov edited comment on IGNITE-6442 at 9/26/17 11:36 AM: [~agura], Current [PR|https://github.com/apache/ignite/pull/2699] and [Upsouse|https://reviews.ignite.apache.org/ignite/review/IGNT-CR-346] from issue links. I've added this PR [PR_IGNITE-6445|https://github.com/apache/ignite/pull/2743] to show why I added TODO. was (Author: vitaliyb): [~agura], Current [PR|https://github.com/apache/ignite/pull/2699] and [Upsouse|https://reviews.ignite.apache.org/ignite/review/IGNT-CR-346] from issue links. > Deadlock detection doesn't execute. > --- > > Key: IGNITE-6442 > URL: https://issues.apache.org/jira/browse/IGNITE-6442 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.2 >Reporter: Vitaliy Biryukov >Assignee: Vitaliy Biryukov > Fix For: 2.3 > > > In case of a configuration with near cache and if all entities of one of the > transactions involved in the deadlock are on the node being the initiator of > this transaction, then immediately after the timeout, the transaction rolls > back (without calling DD). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (IGNITE-6442) Deadlock detection doesn't execute.
[ https://issues.apache.org/jira/browse/IGNITE-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178674#comment-16178674 ] Vitaliy Biryukov edited comment on IGNITE-6442 at 9/25/17 7:35 AM: --- [~agura], Done. I've simplified test and fixed bug in another way that future would return GridNearTxPrepareRespons. [TC run|https://ci.ignite.apache.org/viewLog.html?buildId=850753=buildResultsDiv=Ignite20Tests_RunAll] was (Author: vitaliyb): [~agura], Done. I've simplified test and fixed bug in another way that future would return GridNearTxPrepareRespons. > Deadlock detection doesn't execute. > --- > > Key: IGNITE-6442 > URL: https://issues.apache.org/jira/browse/IGNITE-6442 > Project: Ignite > Issue Type: Bug >Reporter: Vitaliy Biryukov >Assignee: Vitaliy Biryukov > Fix For: 2.3 > > > In case of a configuration with near cache and if all entities of one of the > transactions involved in the deadlock are on the node being the initiator of > this transaction, then immediately after the timeout, the transaction rolls > back (without calling DD). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (IGNITE-6442) Deadlock detection doesn't execute.
[ https://issues.apache.org/jira/browse/IGNITE-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173393#comment-16173393 ] Andrey Gura edited comment on IGNITE-6442 at 9/20/17 9:34 PM: -- [~VitaliyB] It's bad idea to check that deadlock detection procedure was initiated using log messages. In all tests we have expectation about deadlock detection: at least one transaction should detect deadlock. It's enough for tests purposes and more reliable because can't be affected by log message changes. Please, fix it. was (Author: agura): [~VitaliyB] It's bad idead to check that deadlock detection procedure was initiated using log messages. In all tests we have expectation about deadlock detection: at least one transaction should detect deadlock. It's enough for tests purposes and more reliable because can't be affected by log message changes. Please, fix it. > Deadlock detection doesn't execute. > --- > > Key: IGNITE-6442 > URL: https://issues.apache.org/jira/browse/IGNITE-6442 > Project: Ignite > Issue Type: Bug >Reporter: Vitaliy Biryukov >Assignee: Vitaliy Biryukov > Fix For: 2.3 > > > In case of a configuration with near cache and if all entities of one of the > transactions involved in the deadlock are on the node being the initiator of > this transaction, then immediately after the timeout, the transaction rolls > back (without calling DD). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (IGNITE-6442) Deadlock detection doesn't execute.
[ https://issues.apache.org/jira/browse/IGNITE-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173051#comment-16173051 ] Vitaliy Biryukov edited comment on IGNITE-6442 at 9/20/17 11:46 AM: Hi, [~agura]. Please, review this issue. [Upsourse|https://reviews.ignite.apache.org/ignite/review/IGNT-CR-346] I've reproduced the case in which DD is not called and fixed bug. My test method checks only that DD was called, but does not verify that it worked correctly. Because in this case DD works flaky. I'll fix it at [IGNITE-6445|https://issues.apache.org/jira/browse/IGNITE-6445] and add correctness check to my test method. [TC run|https://ci.ignite.apache.org/viewLog.html?buildId=840419=buildResultsDiv=Ignite20Tests_RunAll] was (Author: vitaliyb): Hi, [~agura]. Please, review this issue. [Upsourse|https://reviews.ignite.apache.org/ignite/review/IGNT-CR-346] I've reproduced the case in which DD is not called and fixed bug. My test method checks only that DD was called, but does not verify that it worked correctly. Because in this case DD works flaky. I'll fix it at [IGNITE-6445|https://issues.apache.org/jira/browse/IGNITE-6445] and add correctness check to my test method. > Deadlock detection doesn't execute. > --- > > Key: IGNITE-6442 > URL: https://issues.apache.org/jira/browse/IGNITE-6442 > Project: Ignite > Issue Type: Bug >Reporter: Vitaliy Biryukov >Assignee: Vitaliy Biryukov > > In case of a configuration with near cache and if all entities of one of the > transactions involved in the deadlock are on the node being the initiator of > this transaction, then immediately after the timeout, the transaction rolls > back (without calling DD). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
