[jira] [Comment Edited] (IGNITE-8776) Eviction policy MBeans are never registered if evictionPolicyFactory is used
[ https://issues.apache.org/jira/browse/IGNITE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541862#comment-16541862 ] Dmitriy Pavlov edited comment on IGNITE-8776 at 7/12/18 4:04 PM: - Merged to master. I've - updated PR in accordance with code style, - added empty lines after variable declaration and before return. - added test to suite so it could be run on TC. [~slukyanov], thank you for review. [~kcheng.mvp] thank you for contribution. was (Author: dpavlov): Merged to master. I've - updated PR in accordance with code style, - added empty lines after variable declaration and before return. - added test to suite so it could be run on TC. [~slukyanov], thank you for review > Eviction policy MBeans are never registered if evictionPolicyFactory is used > > > Key: IGNITE-8776 > URL: https://issues.apache.org/jira/browse/IGNITE-8776 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.5 >Reporter: Stanislav Lukyanov >Assignee: kcheng.mvp >Priority: Minor > Labels: newbie > Fix For: 2.7 > > > Eviction policy MBeans, such as LruEvictionPolicyMBean, are never registered > if evictionPolicyFactory is set instead of evictionPolicy (the latter is > deprecated). > This happens because GridCacheProcessor::registerMbean attempts to find > either an *MBean interface or IgniteMBeanAware interface on the passed > object. It works for LruEvictionPolicy but not for LruEvictionPolicyFactory > (which doesn't implement these interfaces). > The code needs to be adjusted to handle factories correctly. > New tests are needed to make sure that all standard beans are registered > (IgniteKernalMbeansTest does that for kernal mbeans - need the same for cache > beans). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (IGNITE-8776) Eviction policy MBeans are never registered if evictionPolicyFactory is used
[ https://issues.apache.org/jira/browse/IGNITE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535043#comment-16535043 ] kcheng.mvp edited comment on IGNITE-8776 at 7/6/18 4:00 PM: [~slukyanov] Everything is green https://ci.ignite.apache.org/viewLog.html?buildId=1462771=buildResultsDiv=IgniteTests24Java8_RunBasicTests Can you help me do a code review? was (Author: kcheng.mvp): [~slukyanov] Everything is greep https://ci.ignite.apache.org/viewLog.html?buildId=1462771=buildResultsDiv=IgniteTests24Java8_RunBasicTests Can you help me do a code review? > Eviction policy MBeans are never registered if evictionPolicyFactory is used > > > Key: IGNITE-8776 > URL: https://issues.apache.org/jira/browse/IGNITE-8776 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.5 >Reporter: Stanislav Lukyanov >Assignee: kcheng.mvp >Priority: Minor > Labels: newbie > > Eviction policy MBeans, such as LruEvictionPolicyMBean, are never registered > if evictionPolicyFactory is set instead of evictionPolicy (the latter is > deprecated). > This happens because GridCacheProcessor::registerMbean attempts to find > either an *MBean interface or IgniteMBeanAware interface on the passed > object. It works for LruEvictionPolicy but not for LruEvictionPolicyFactory > (which doesn't implement these interfaces). > The code needs to be adjusted to handle factories correctly. > New tests are needed to make sure that all standard beans are registered > (IgniteKernalMbeansTest does that for kernal mbeans - need the same for cache > beans). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (IGNITE-8776) Eviction policy MBeans are never registered if evictionPolicyFactory is used
[ https://issues.apache.org/jira/browse/IGNITE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534452#comment-16534452 ] kcheng.mvp edited comment on IGNITE-8776 at 7/6/18 5:48 AM: [~slukyanov] I have triggered the tests many times on TeamCity. every time I get the same result. Platform .NET (Core Linux) pull/4300/head #1109Exit code 1 (new) https://ci.ignite.apache.org/viewLog.html?buildId=1460429=buildResultsDiv=IgniteTests24Java8_RunBasicTests. I checked the history of 'Platform .NET (Core Linux) ' and found there are many other build also runs into the same result. was (Author: kcheng.mvp): I have triggered the tests many times on TeamCity. every time I get the same result. Platform .NET (Core Linux) pull/4300/head #1109Exit code 1 (new) https://ci.ignite.apache.org/viewLog.html?buildId=1460429=buildResultsDiv=IgniteTests24Java8_RunBasicTests. I checked the history of 'Platform .NET (Core Linux) ' and found there are many other build also runs into the same result. > Eviction policy MBeans are never registered if evictionPolicyFactory is used > > > Key: IGNITE-8776 > URL: https://issues.apache.org/jira/browse/IGNITE-8776 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.5 >Reporter: Stanislav Lukyanov >Assignee: kcheng.mvp >Priority: Minor > Labels: newbie > > Eviction policy MBeans, such as LruEvictionPolicyMBean, are never registered > if evictionPolicyFactory is set instead of evictionPolicy (the latter is > deprecated). > This happens because GridCacheProcessor::registerMbean attempts to find > either an *MBean interface or IgniteMBeanAware interface on the passed > object. It works for LruEvictionPolicy but not for LruEvictionPolicyFactory > (which doesn't implement these interfaces). > The code needs to be adjusted to handle factories correctly. > New tests are needed to make sure that all standard beans are registered > (IgniteKernalMbeansTest does that for kernal mbeans - need the same for cache > beans). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
