[jira] [Commented] (IGNITE-10178) change tests that fail("Ignite JIRA ticket URL") to @Ignore("Ignite JIRA ticket URL")
[
https://issues.apache.org/jira/browse/IGNITE-10178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752458#comment-16752458
]
Oleg Ignatenko commented on IGNITE-10178:
-
[~Mmuzaf] I tried to edit coding guidelines as you recommended in [comment
above|https://issues.apache.org/jira/browse/IGNITE-10178?focusedCommentId=16716635=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16716635]
but couldn't find a way to edit the page, either I lack necessary privileges
or maybe missed something in UI.
I saw your name in edits history, could you please help me in that? either
explain the Ui / access rights or maybe edit the page yourself based on
examples in this ticket?
> change tests that fail("Ignite JIRA ticket URL") to @Ignore("Ignite JIRA
> ticket URL")
> -
>
> Key: IGNITE-10178
> URL: https://issues.apache.org/jira/browse/IGNITE-10178
> Project: Ignite
> Issue Type: Sub-task
>Reporter: Oleg Ignatenko
>Assignee: Oleg Ignatenko
>Priority: Major
> Fix For: 2.8
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Change tests that use {{fail("Ignite JIRA ticket URL")}} to {{@Ignore("Ignite
> JIRA ticket URL")}}. Do the same change for tests that fail by
> {{@IgniteIgnore("Ignite JIRA ticket URL")}}, like for example
> [S3CheckpointSpiStartStopSelfTest.testStartStop|https://github.com/apache/ignite/blob/master/modules/aws/src/test/java/org/apache/ignite/spi/checkpoint/s3/S3CheckpointSpiStartStopSelfTest.java].
> Also, use
> [Ignore|http://junit.sourceforge.net/javadoc/org/junit/Ignore.html] to
> annotate empty test classes in examples that were discovered and re-muted per
> IGNITE-10174.
> If needed, refer parent task for more details.
> Note this step would better be coordinated with Teamcity and TC bot
> maintainers because it may substantially impact them.
> -
> Note that tests that are expected to be ignored depending on runtime
> conditions should be rewritten to use {{Assume}} instead of {{fail}}. So that
> old code...
> {code}if (someRuntimeCondition())
> fail("Ignite JIRA ticket URL");{code}
> ...will change to
> {code}Assume.assumeFalse("Ignite JIRA ticket URL",
> someRuntimeCondition());{code}
> (this change can be "extracted" into separate JIRA task if it is more
> convenient). Readers interested to find more details about how {{Assume}}
> works can find more details and code snippet [in comments
> here|https://issues.apache.org/jira/browse/IGNITE-10178?focusedCommentId=16723863=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16723863].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10178) change tests that fail("Ignite JIRA ticket URL") to @Ignore("Ignite JIRA ticket URL")
[
https://issues.apache.org/jira/browse/IGNITE-10178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743601#comment-16743601
]
Ignite TC Bot commented on IGNITE-10178:
{panel:title=-- Run :: All (Nightly): No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All (Nightly)*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2810230buildTypeId=IgniteTests24Java8_RunAllNightly]
> change tests that fail("Ignite JIRA ticket URL") to @Ignore("Ignite JIRA
> ticket URL")
> -
>
> Key: IGNITE-10178
> URL: https://issues.apache.org/jira/browse/IGNITE-10178
> Project: Ignite
> Issue Type: Sub-task
>Reporter: Oleg Ignatenko
>Assignee: Oleg Ignatenko
>Priority: Major
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Change tests that use {{fail("Ignite JIRA ticket URL")}} to {{@Ignore("Ignite
> JIRA ticket URL")}}. Do the same change for tests that fail by
> {{@IgniteIgnore("Ignite JIRA ticket URL")}}, like for example
> [S3CheckpointSpiStartStopSelfTest.testStartStop|https://github.com/apache/ignite/blob/master/modules/aws/src/test/java/org/apache/ignite/spi/checkpoint/s3/S3CheckpointSpiStartStopSelfTest.java].
> Also, use
> [Ignore|http://junit.sourceforge.net/javadoc/org/junit/Ignore.html] to
> annotate empty test classes in examples that were discovered and re-muted per
> IGNITE-10174.
> If needed, refer parent task for more details.
> Note this step would better be coordinated with Teamcity and TC bot
> maintainers because it may substantially impact them.
> -
> Note that tests that are expected to be ignored depending on runtime
> conditions should be rewritten to use {{Assume}} instead of {{fail}}. So that
> old code...
> {code}if (someRuntimeCondition())
> fail("Ignite JIRA ticket URL");{code}
> ...will change to
> {code}Assume.assumeFalse("Ignite JIRA ticket URL",
> someRuntimeCondition());{code}
> (this change can be "extracted" into separate JIRA task if it is more
> convenient). Readers interested to find more details about how {{Assume}}
> works can find more details and code snippet [in comments
> here|https://issues.apache.org/jira/browse/IGNITE-10178?focusedCommentId=16723863=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16723863].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10178) change tests that fail("Ignite JIRA ticket URL") to @Ignore("Ignite JIRA ticket URL")
[
https://issues.apache.org/jira/browse/IGNITE-10178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743448#comment-16743448
]
Oleg Ignatenko commented on IGNITE-10178:
-
(i) first set of changes was made per [PR
5745|https://github.com/apache/ignite/pull/5745] which was further finalized in
[PR 5824|https://github.com/apache/ignite/pull/5824]
> change tests that fail("Ignite JIRA ticket URL") to @Ignore("Ignite JIRA
> ticket URL")
> -
>
> Key: IGNITE-10178
> URL: https://issues.apache.org/jira/browse/IGNITE-10178
> Project: Ignite
> Issue Type: Sub-task
>Reporter: Oleg Ignatenko
>Assignee: Oleg Ignatenko
>Priority: Major
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Change tests that use {{fail("Ignite JIRA ticket URL")}} to {{@Ignore("Ignite
> JIRA ticket URL")}}. Do the same change for tests that fail by
> {{@IgniteIgnore("Ignite JIRA ticket URL")}}, like for example
> [S3CheckpointSpiStartStopSelfTest.testStartStop|https://github.com/apache/ignite/blob/master/modules/aws/src/test/java/org/apache/ignite/spi/checkpoint/s3/S3CheckpointSpiStartStopSelfTest.java].
> Also, use
> [Ignore|http://junit.sourceforge.net/javadoc/org/junit/Ignore.html] to
> annotate empty test classes in examples that were discovered and re-muted per
> IGNITE-10174.
> If needed, refer parent task for more details.
> Note this step would better be coordinated with Teamcity and TC bot
> maintainers because it may substantially impact them.
> -
> Note that tests that are expected to be ignored depending on runtime
> conditions should be rewritten to use {{Assume}} instead of {{fail}}. So that
> old code...
> {code}if (someRuntimeCondition())
> fail("Ignite JIRA ticket URL");{code}
> ...will change to
> {code}Assume.assumeFalse("Ignite JIRA ticket URL",
> someRuntimeCondition());{code}
> (this change can be "extracted" into separate JIRA task if it is more
> convenient). Readers interested to find more details about how {{Assume}}
> works can find more details and code snippet [in comments
> here|https://issues.apache.org/jira/browse/IGNITE-10178?focusedCommentId=16723863=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16723863].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10178) change tests that fail("Ignite JIRA ticket URL") to @Ignore("Ignite JIRA ticket URL")
[
https://issues.apache.org/jira/browse/IGNITE-10178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729630#comment-16729630
]
Ignite TC Bot commented on IGNITE-10178:
{panel:title=-- Run :: All: No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2650264buildTypeId=IgniteTests24Java8_RunAll]
> change tests that fail("Ignite JIRA ticket URL") to @Ignore("Ignite JIRA
> ticket URL")
> -
>
> Key: IGNITE-10178
> URL: https://issues.apache.org/jira/browse/IGNITE-10178
> Project: Ignite
> Issue Type: Sub-task
>Reporter: Oleg Ignatenko
>Assignee: PetrovMikhail
>Priority: Major
>
> Change tests that use {{fail("Ignite JIRA ticket URL")}} to {{@Ignore("Ignite
> JIRA ticket URL")}}. Do the same change for tests that fail by
> {{@IgniteIgnore("Ignite JIRA ticket URL")}}, like for example
> [S3CheckpointSpiStartStopSelfTest.testStartStop|https://github.com/apache/ignite/blob/master/modules/aws/src/test/java/org/apache/ignite/spi/checkpoint/s3/S3CheckpointSpiStartStopSelfTest.java].
> Also, use
> [Ignore|http://junit.sourceforge.net/javadoc/org/junit/Ignore.html] to
> annotate empty test classes in examples that were discovered and re-muted per
> IGNITE-10174.
> If needed, refer parent task for more details.
> Note this step would better be coordinated with Teamcity and TC bot
> maintainers because it may substantially impact them.
> -
> Note that tests that are expected to be ignored depending on runtime
> conditions should be rewritten to use {{Assume}} instead of {{fail}}. So that
> old code...
> {code}if (someRuntimeCondition())
> fail("Ignite JIRA ticket URL");{code}
> ...will change to
> {code}Assume.assumeFalse("Ignite JIRA ticket URL",
> someRuntimeCondition());{code}
> (this change can be "extracted" into separate JIRA task if it is more
> convenient). Readers interested to find more details about how {{Assume}}
> works can find more details and code snippet [in comments
> here|https://issues.apache.org/jira/browse/IGNITE-10178?focusedCommentId=16723863=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16723863].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10178) change tests that fail("Ignite JIRA ticket URL") to @Ignore("Ignite JIRA ticket URL")
[
https://issues.apache.org/jira/browse/IGNITE-10178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728789#comment-16728789
]
ASF GitHub Bot commented on IGNITE-10178:
-
GitHub user ololo3000 opened a pull request:
https://github.com/apache/ignite/pull/5745
IGNITE-10178 Ignore annotations added
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ololo3000/ignite IGNITE-10178
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/5745.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5745
commit aa2c91f0de000323e1ab8246ae5a1d55429f16d1
Author: Petrov
Date: 2018-12-25T15:05:58Z
IGNITE-10178 Ignore annotations added
commit 8b859ace05cbe0e20a5f7a13be32fa0179591728
Author: Petrov
Date: 2018-12-25T15:12:18Z
Merge branch 'master' into IGNITE-10178
commit 1a8cc8fe1251b1ced6e278816c7ad4ac1c4ecbe7
Author: Petrov
Date: 2018-12-25T16:56:58Z
IGNITE-10178 minor fixes
> change tests that fail("Ignite JIRA ticket URL") to @Ignore("Ignite JIRA
> ticket URL")
> -
>
> Key: IGNITE-10178
> URL: https://issues.apache.org/jira/browse/IGNITE-10178
> Project: Ignite
> Issue Type: Sub-task
>Reporter: Oleg Ignatenko
>Assignee: PetrovMikhail
>Priority: Major
>
> Change tests that use {{fail("Ignite JIRA ticket URL")}} to {{@Ignore("Ignite
> JIRA ticket URL")}}. Do the same change for tests that fail by
> {{@IgniteIgnore("Ignite JIRA ticket URL")}}, like for example
> [S3CheckpointSpiStartStopSelfTest.testStartStop|https://github.com/apache/ignite/blob/master/modules/aws/src/test/java/org/apache/ignite/spi/checkpoint/s3/S3CheckpointSpiStartStopSelfTest.java].
> Also, use
> [Ignore|http://junit.sourceforge.net/javadoc/org/junit/Ignore.html] to
> annotate empty test classes in examples that were discovered and re-muted per
> IGNITE-10174.
> If needed, refer parent task for more details.
> Note this step would better be coordinated with Teamcity and TC bot
> maintainers because it may substantially impact them.
> -
> Note that tests that are expected to be ignored depending on runtime
> conditions should be rewritten to use {{Assume}} instead of {{fail}}. So that
> old code...
> {code}if (someRuntimeCondition())
> fail("Ignite JIRA ticket URL");{code}
> ...will change to
> {code}Assume.assumeFalse("Ignite JIRA ticket URL",
> someRuntimeCondition());{code}
> (this change can be "extracted" into separate JIRA task if it is more
> convenient). Readers interested to find more details about how {{Assume}}
> works can find more details and code snippet [in comments
> here|https://issues.apache.org/jira/browse/IGNITE-10178?focusedCommentId=16723863=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16723863].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10178) change tests that fail("Ignite JIRA ticket URL") to @Ignore("Ignite JIRA ticket URL")
[
https://issues.apache.org/jira/browse/IGNITE-10178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723863#comment-16723863
]
Oleg Ignatenko commented on IGNITE-10178:
-
(i) Note that in JUnit 4 an idiomatic way to ignore tests depending on runtime
conditions is by using
[Assume|https://junit.org/junit4/javadoc/4.12/org/junit/Assume.html] API.
See code snippet demonstrating how it works: {code}
import org.junit.Test;
import static org.junit.Assume.assumeTrue;
public class AssumeDemo {
@Test
public void assume1() {
assumeTrue("", runtimeCondition(1));
System.out.println("assume 1");
}
@Test
public void assume2() {
assumeTrue("", runtimeCondition(2));
System.out.println("assume 2");
}
private boolean runtimeCondition(int val) {
boolean res = (val & 1) == 0;
System.out.println("Runtime condition holds: " + res);
return res;
}
}{code}
The output when executing this code is as follows: {noformat}
Runtime condition holds: false
Test ignored.
org.junit.internal.AssumptionViolatedException:
at org.junit.Assume.assumeTrue(Assume.java:59)
at org.apache.ignite.ml.common.AssumeDemo.assume1(AssumeDemo.java:10)
...
Runtime condition holds: true
assume 2{noformat}
> change tests that fail("Ignite JIRA ticket URL") to @Ignore("Ignite JIRA
> ticket URL")
> -
>
> Key: IGNITE-10178
> URL: https://issues.apache.org/jira/browse/IGNITE-10178
> Project: Ignite
> Issue Type: Sub-task
>Reporter: Oleg Ignatenko
>Assignee: PetrovMikhail
>Priority: Major
>
> Change tests that use {{fail("Ignite JIRA ticket URL")}} to {{@Ignore("Ignite
> JIRA ticket URL")}}. Do the same change for tests that fail by
> {{@IgniteIgnore("Ignite JIRA ticket URL")}}, like for example
> [S3CheckpointSpiStartStopSelfTest.testStartStop|https://github.com/apache/ignite/blob/master/modules/aws/src/test/java/org/apache/ignite/spi/checkpoint/s3/S3CheckpointSpiStartStopSelfTest.java].
> Also, use
> [Ignore|http://junit.sourceforge.net/javadoc/org/junit/Ignore.html] to
> annotate empty test classes in examples that were discovered and re-muted per
> IGNITE-10174.
> If needed, refer parent task for more details.
> Note this step would better be coordinated with Teamcity and TC bot
> maintainers because it may substantially impact them
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10178) change tests that fail("Ignite JIRA ticket URL") to @Ignore("Ignite JIRA ticket URL")
[
https://issues.apache.org/jira/browse/IGNITE-10178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716635#comment-16716635
]
Maxim Muzafarov commented on IGNITE-10178:
--
Hello,
I'd suggest updating the
[CodingGuidelines-B.Brokentests|https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-B.Brokentests]
confluence page after these changes will be merged.
> change tests that fail("Ignite JIRA ticket URL") to @Ignore("Ignite JIRA
> ticket URL")
> -
>
> Key: IGNITE-10178
> URL: https://issues.apache.org/jira/browse/IGNITE-10178
> Project: Ignite
> Issue Type: Sub-task
>Reporter: Oleg Ignatenko
>Priority: Major
>
> Change tests that use {{fail("Ignite JIRA ticket URL")}} to {{@Ignore("Ignite
> JIRA ticket URL")}}. Do the same change for tests that fail by
> {{@IgniteIgnore("Ignite JIRA ticket URL")}}, like for example
> [S3CheckpointSpiStartStopSelfTest.testStartStop|https://github.com/apache/ignite/blob/master/modules/aws/src/test/java/org/apache/ignite/spi/checkpoint/s3/S3CheckpointSpiStartStopSelfTest.java].
> Also, use
> [Ignore|http://junit.sourceforge.net/javadoc/org/junit/Ignore.html] to
> annotate empty test classes in examples that were discovered and re-muted per
> IGNITE-10174.
> If needed, refer parent task for more details.
> Note this step would better be coordinated with Teamcity and TC bot
> maintainers because it may substantially impact them
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
