[jira] [Commented] (IGNITE-10279) Control.sh utility unify options naming format

2018-12-24 Thread Alexey Kuznetsov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728238#comment-16728238
 ] 

Alexey Kuznetsov commented on IGNITE-10279:
---

Looks good to me. Merged to master.

> Control.sh utility unify options naming format
> --
>
> Key: IGNITE-10279
> URL: https://issues.apache.org/jira/browse/IGNITE-10279
> Project: Ignite
>  Issue Type: Improvement
>Affects Versions: 2.6
>Reporter: Sergey Antonov
>Assignee: Sergey Antonov
>Priority: Major
> Fix For: 2.8
>
>
> Now we have options in several styles:
> {noformat}
> --ping-interval 
> {noformat}
> {noformat}
> --skipZeros
> {noformat}
> I think, we must unify options naming format and we should use linux like 
> format, i.e. {{--word1-word2}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10279) Control.sh utility unify options naming format

2018-12-24 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728239#comment-16728239
 ] 

ASF GitHub Bot commented on IGNITE-10279:
-

Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/5672


> Control.sh utility unify options naming format
> --
>
> Key: IGNITE-10279
> URL: https://issues.apache.org/jira/browse/IGNITE-10279
> Project: Ignite
>  Issue Type: Improvement
>Affects Versions: 2.6
>Reporter: Sergey Antonov
>Assignee: Sergey Antonov
>Priority: Major
> Fix For: 2.8
>
>
> Now we have options in several styles:
> {noformat}
> --ping-interval 
> {noformat}
> {noformat}
> --skipZeros
> {noformat}
> I think, we must unify options naming format and we should use linux like 
> format, i.e. {{--word1-word2}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10279) Control.sh utility unify options naming format

2018-12-21 Thread Sergey Antonov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16726566#comment-16726566
 ] 

Sergey Antonov commented on IGNITE-10279:
-

[~ibessonov] I got TC visa. My changes in control.sh can't affect Hibernate 
tests. 

> Control.sh utility unify options naming format
> --
>
> Key: IGNITE-10279
> URL: https://issues.apache.org/jira/browse/IGNITE-10279
> Project: Ignite
>  Issue Type: Improvement
>Affects Versions: 2.6
>Reporter: Sergey Antonov
>Assignee: Sergey Antonov
>Priority: Major
> Fix For: 2.8
>
>
> Now we have options in several styles:
> {noformat}
> --ping-interval 
> {noformat}
> {noformat}
> --skipZeros
> {noformat}
> I think, we must unify options naming format and we should use linux like 
> format, i.e. {{--word1-word2}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10279) Control.sh utility unify options naming format

2018-12-21 Thread Ignite TC Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16726560#comment-16726560
 ] 

Ignite TC Bot commented on IGNITE-10279:


{panel:title=--> Run :: All: Possible 
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Hibernate 5.3{color} [[tests 0 Exit Code 
|https://ci.ignite.apache.org/viewLog.html?buildId=2610542]]

{panel}
[TeamCity *--> Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2601834&buildTypeId=IgniteTests24Java8_RunAll]

> Control.sh utility unify options naming format
> --
>
> Key: IGNITE-10279
> URL: https://issues.apache.org/jira/browse/IGNITE-10279
> Project: Ignite
>  Issue Type: Improvement
>Affects Versions: 2.6
>Reporter: Sergey Antonov
>Assignee: Sergey Antonov
>Priority: Major
> Fix For: 2.8
>
>
> Now we have options in several styles:
> {noformat}
> --ping-interval 
> {noformat}
> {noformat}
> --skipZeros
> {noformat}
> I think, we must unify options naming format and we should use linux like 
> format, i.e. {{--word1-word2}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10279) Control.sh utility unify options naming format

2018-12-20 Thread Ivan Bessonov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725799#comment-16725799
 ] 

Ivan Bessonov commented on IGNITE-10279:


[~antonovsergey93] code looks good, thank you!

> Control.sh utility unify options naming format
> --
>
> Key: IGNITE-10279
> URL: https://issues.apache.org/jira/browse/IGNITE-10279
> Project: Ignite
>  Issue Type: Improvement
>Affects Versions: 2.6
>Reporter: Sergey Antonov
>Assignee: Sergey Antonov
>Priority: Major
> Fix For: 2.8
>
>
> Now we have options in several styles:
> {noformat}
> --ping-interval 
> {noformat}
> {noformat}
> --skipZeros
> {noformat}
> I think, we must unify options naming format and we should use linux like 
> format, i.e. {{--word1-word2}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10279) Control.sh utility unify options naming format

2018-12-20 Thread Sergey Antonov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725795#comment-16725795
 ] 

Sergey Antonov commented on IGNITE-10279:
-

[~ibessonov] I applied your comment and rerun TC. Let's wait TC bot visa.

> Control.sh utility unify options naming format
> --
>
> Key: IGNITE-10279
> URL: https://issues.apache.org/jira/browse/IGNITE-10279
> Project: Ignite
>  Issue Type: Improvement
>Affects Versions: 2.6
>Reporter: Sergey Antonov
>Assignee: Sergey Antonov
>Priority: Major
> Fix For: 2.8
>
>
> Now we have options in several styles:
> {noformat}
> --ping-interval 
> {noformat}
> {noformat}
> --skipZeros
> {noformat}
> I think, we must unify options naming format and we should use linux like 
> format, i.e. {{--word1-word2}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10279) Control.sh utility unify options naming format

2018-12-20 Thread Ivan Bessonov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725667#comment-16725667
 ] 

Ivan Bessonov commented on IGNITE-10279:


[~antonovsergey93] I checked your code and see no issues except for code 
formatting. I added only one comment on GitHub but please run through all you 
changes and check if everything's correct. Thank you!

> Control.sh utility unify options naming format
> --
>
> Key: IGNITE-10279
> URL: https://issues.apache.org/jira/browse/IGNITE-10279
> Project: Ignite
>  Issue Type: Improvement
>Affects Versions: 2.6
>Reporter: Sergey Antonov
>Assignee: Sergey Antonov
>Priority: Major
> Fix For: 2.8
>
>
> Now we have options in several styles:
> {noformat}
> --ping-interval 
> {noformat}
> {noformat}
> --skipZeros
> {noformat}
> I think, we must unify options naming format and we should use linux like 
> format, i.e. {{--word1-word2}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10279) Control.sh utility unify options naming format

2018-12-19 Thread Sergey Kosarev (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725155#comment-16725155
 ] 

Sergey Kosarev commented on IGNITE-10279:
-

[~antonovsergey93], looks good, thanks.

> Control.sh utility unify options naming format
> --
>
> Key: IGNITE-10279
> URL: https://issues.apache.org/jira/browse/IGNITE-10279
> Project: Ignite
>  Issue Type: Improvement
>Affects Versions: 2.6
>Reporter: Sergey Antonov
>Assignee: Sergey Antonov
>Priority: Major
> Fix For: 2.8
>
>
> Now we have options in several styles:
> {noformat}
> --ping-interval 
> {noformat}
> {noformat}
> --skipZeros
> {noformat}
> I think, we must unify options naming format and we should use linux like 
> format, i.e. {{--word1-word2}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10279) Control.sh utility unify options naming format

2018-12-19 Thread Sergey Antonov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725015#comment-16725015
 ] 

Sergey Antonov commented on IGNITE-10279:
-

[~macrergate], I fixed your comments. Could you review changes again?

> Control.sh utility unify options naming format
> --
>
> Key: IGNITE-10279
> URL: https://issues.apache.org/jira/browse/IGNITE-10279
> Project: Ignite
>  Issue Type: Improvement
>Affects Versions: 2.6
>Reporter: Sergey Antonov
>Assignee: Sergey Antonov
>Priority: Major
> Fix For: 2.8
>
>
> Now we have options in several styles:
> {noformat}
> --ping-interval 
> {noformat}
> {noformat}
> --skipZeros
> {noformat}
> I think, we must unify options naming format and we should use linux like 
> format, i.e. {{--word1-word2}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10279) Control.sh utility unify options naming format

2018-12-18 Thread Ignite TC Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16724099#comment-16724099
 ] 

Ignite TC Bot commented on IGNITE-10279:


{panel:title=--> Run :: All: Possible 
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Platform .NET (Inspections){color} [[tests 0 
BuildFailureOnMetric 
|https://ci.ignite.apache.org/viewLog.html?buildId=2583097]]

{panel}
[TeamCity *--> Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2583108&buildTypeId=IgniteTests24Java8_RunAll]

> Control.sh utility unify options naming format
> --
>
> Key: IGNITE-10279
> URL: https://issues.apache.org/jira/browse/IGNITE-10279
> Project: Ignite
>  Issue Type: Improvement
>Affects Versions: 2.6
>Reporter: Sergey Antonov
>Assignee: Sergey Antonov
>Priority: Major
> Fix For: 2.8
>
>
> Now we have options in several styles:
> {noformat}
> --ping-interval 
> {noformat}
> {noformat}
> --skipZeros
> {noformat}
> I think, we must unify options naming format and we should use linux like 
> format, i.e. {{--word1-word2}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10279) Control.sh utility unify options naming format

2018-12-18 Thread Ignite TC Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16724077#comment-16724077
 ] 

Ignite TC Bot commented on IGNITE-10279:


{panel:title=--> Run :: All: Possible 
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}ZooKeeper{color} [[tests 
1|https://ci.ignite.apache.org/viewLog.html?buildId=2583044]]
* ZookeeperIpFinderTestSuite: 
ZookeeperIpFinderTest.testFourNodesWithDuplicateRegistrations - 0,0% fails in 
last 406 master runs.

{color:#d04437}Platform .NET (Inspections){color} [[tests 0 
BuildFailureOnMetric 
|https://ci.ignite.apache.org/viewLog.html?buildId=2583097]]

{panel}
[TeamCity *--> Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2583108&buildTypeId=IgniteTests24Java8_RunAll]

> Control.sh utility unify options naming format
> --
>
> Key: IGNITE-10279
> URL: https://issues.apache.org/jira/browse/IGNITE-10279
> Project: Ignite
>  Issue Type: Improvement
>Affects Versions: 2.6
>Reporter: Sergey Antonov
>Assignee: Sergey Antonov
>Priority: Major
> Fix For: 2.8
>
>
> Now we have options in several styles:
> {noformat}
> --ping-interval 
> {noformat}
> {noformat}
> --skipZeros
> {noformat}
> I think, we must unify options naming format and we should use linux like 
> format, i.e. {{--word1-word2}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10279) Control.sh utility unify options naming format

2018-12-17 Thread Ignite TC Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723126#comment-16723126
 ] 

Ignite TC Bot commented on IGNITE-10279:


{panel:title=--> Run :: All: Possible 
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Cache 7{color} [[tests 
2|https://ci.ignite.apache.org/viewLog.html?buildId=2574618]]
* IgniteCacheWithIndexingAndPersistenceTestSuite: 
GridCommandHandlerIndexingTest.testBrokenCacheDataTreeShouldFailValidation - 
0,0% fails in last 351 master runs.
* IgniteCacheTestSuite7: 
IgniteCacheStartWithLoadTest.testNoRebalanceDuringCacheStart - 0,0% fails in 
last 351 master runs.

{color:#d04437}Platform .NET (Inspections){color} [[tests 0 
BuildFailureOnMetric 
|https://ci.ignite.apache.org/viewLog.html?buildId=2574625]]

{panel}
[TeamCity *--> Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2573091&buildTypeId=IgniteTests24Java8_RunAll]

> Control.sh utility unify options naming format
> --
>
> Key: IGNITE-10279
> URL: https://issues.apache.org/jira/browse/IGNITE-10279
> Project: Ignite
>  Issue Type: Improvement
>Affects Versions: 2.6
>Reporter: Sergey Antonov
>Assignee: Sergey Antonov
>Priority: Major
> Fix For: 2.8
>
>
> Now we have options in several styles:
> {noformat}
> --ping-interval 
> {noformat}
> {noformat}
> --skipZeros
> {noformat}
> I think, we must unify options naming format and we should use linux like 
> format, i.e. {{--word1-word2}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10279) Control.sh utility unify options naming format

2018-12-14 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721499#comment-16721499
 ] 

ASF GitHub Bot commented on IGNITE-10279:
-

GitHub user antonovsergey93 opened a pull request:

https://github.com/apache/ignite/pull/5672

IGNITE-10279 Control.sh unify options naming and rework help.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-10279

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/5672.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5672


commit 416ff563bab57e8850f0e644619689df5bd0a44c
Author: Sergey Antonov 
Date:   2018-12-14T12:57:58Z

IGNITE-10279 WIP

commit 5a6eea61a651fcdf9603501a4c25c5adb8cd6ba8
Author: Sergey Antonov 
Date:   2018-12-14T13:56:25Z

IGNITE-10279 Rework join method

commit 929e595c642acb05acd4bafb4c0c6378aaefee14
Author: Sergey Antonov 
Date:   2018-12-14T14:19:16Z

IGNITE-10279 Remove toString() invocation.

commit 022e274650feaf8339a13ff3b5a7cdd5995c4d04
Author: Sergey Antonov 
Date:   2018-12-14T14:58:27Z

IGNITE-10279 Rework help.




> Control.sh utility unify options naming format
> --
>
> Key: IGNITE-10279
> URL: https://issues.apache.org/jira/browse/IGNITE-10279
> Project: Ignite
>  Issue Type: Improvement
>Affects Versions: 2.6
>Reporter: Sergey Antonov
>Assignee: Sergey Antonov
>Priority: Major
> Fix For: 2.8
>
>
> Now we have options in several styles:
> {noformat}
> --ping-interval 
> {noformat}
> {noformat}
> --skipZeros
> {noformat}
> I think, we must unify options naming format and we should use linux like 
> format, i.e. {{--word1-word2}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10279) Control.sh utility unify options naming format

2018-12-14 Thread ARomantsov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721367#comment-16721367
 ] 

ARomantsov commented on IGNITE-10279:
-

Can you please also fix help of control.sh

I suggest something like

{code:java}
Contol.sh is used to execute admin commands on cluster or get common cluster 
info. The command has the following syntax:
  control.sh [--host HOST_OR_IP] [--port PORT] [--user USER] [--password 
PASSWORD] [--ping-interval PING_INTERVAL] [--ping-timeout PING_TIMEOUT] 
[--ssl_enabled] [--ssl_protocol SSL_PROTOCOL[, SSL_PROTOCOL_2, ...]] 
[--ssl_algorithm SSL_ALGORITHM] [--ssl_cipher_suites SSL_CIPHER_1[, 
SSL_CIPHER_2, ...]] [--ssl_key_store_type SSL_KEY_STORE_TYPE] 
[--ssl_key_store_path PATH] [--ssl_key_store_password PASSWORD] 
[--ssl_truststore_type SSL_TRUST_STORE_TYPE] [--ssl_truststore_path PATH] 
[--ssl_truststore_password PASSWORD] [command] 
This utility can do the following commands:
  Activate cluster:
control.sh  --activate
  Deactivate cluster:
control.sh  --deactivate [--yes]
  Print current cluster state:
control.sh  --state
  Print cluster baseline topology:
control.sh  --baseline
  Add nodes into baseline topology:
control.sh  --baseline add consistentId1[,consistentId2,,consistentIdN] 
[--yes]
  Remove nodes from baseline topology:
control.sh  --baseline remove 
consistentId1[,consistentId2,,consistentIdN] [--yes]
  Set baseline topology:
control.sh  --baseline set consistentId1[,consistentId2,,consistentIdN] 
[--yes]
  Set baseline topology based on version:
control.sh  --baseline version topologyVersion [--yes]
  List or kill transactions:
control.sh  --tx [xid XID] [minDuration SECONDS] [minSize SIZE] [label 
PATTERN_REGEX] [servers|clients] [nodes 
consistentId1[,consistentId2,,consistentIdN]] [limit NUMBER] [order 
DURATION|SIZE|START_TIME] [kill] [--yes]
  View caches information in a cluster. For more details type:
control.sh --cache help
By default commands affecting the cluster require interactive confirmation.
Use --yes option to disable it.
Default values:
HOST_OR_IP=127.0.0.1
PORT=11211
PING_INTERVAL=5000
PING_TIMEOUT=3
SSL_PROTOCOL=TLS
SSL_ALGORITHM=SunX509
SSL_KEY_STORE_TYPE=JKS
SSL_TRUST_STORE_TYPE=JKS
Exit codes:
0 - successful execution.
1 - invalid arguments.
2 - connection failed.
3 - authentication failed.
4 - unexpected error.
{code}


> Control.sh utility unify options naming format
> --
>
> Key: IGNITE-10279
> URL: https://issues.apache.org/jira/browse/IGNITE-10279
> Project: Ignite
>  Issue Type: Improvement
>Affects Versions: 2.6
>Reporter: Sergey Antonov
>Assignee: Sergey Antonov
>Priority: Major
> Fix For: 2.8
>
>
> Now we have options in several styles:
> {noformat}
> --ping-interval 
> {noformat}
> {noformat}
> --skipZeros
> {noformat}
> I think, we must unify options naming format and we should use linux like 
> format, i.e. {{--word1-word2}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)