[jira] [Commented] (IGNITE-10671) Double initialization of segmentAware and FileArchiver lead to race breaking file compression.
[ https://issues.apache.org/jira/browse/IGNITE-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728640#comment-16728640 ] ASF GitHub Bot commented on IGNITE-10671: - Github user daradurvs closed the pull request at: https://github.com/apache/ignite/pull/5737 > Double initialization of segmentAware and FileArchiver lead to race breaking > file compression. > -- > > Key: IGNITE-10671 > URL: https://issues.apache.org/jira/browse/IGNITE-10671 > Project: Ignite > Issue Type: Bug >Reporter: Pavel Voronkin >Assignee: Pavel Voronkin >Priority: Critical > Fix For: 2.8 > > Attachments: WalCompactionSwitchOverTest.java > > > Race is painful when you switch your cluster from walCompaction=false to > walCompaction=true. > The same FileCompressor instance will use different segmentAwares due to > start0() is called twice which leads to inconsistent behaviour and errors > during compaction, basically we will try to archive files twice concurrently. > See reproducer in attachment. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10671) Double initialization of segmentAware and FileArchiver lead to race breaking file compression.
[ https://issues.apache.org/jira/browse/IGNITE-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728512#comment-16728512 ] ASF GitHub Bot commented on IGNITE-10671: - GitHub user daradurvs opened a pull request: https://github.com/apache/ignite/pull/5737 IGNITE-10671 Messed @Test annotation You can merge this pull request into a Git repository by running: $ git pull https://github.com/daradurvs/ignite ignite-10671 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5737.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5737 commit 966e8291dfa522ecbbad30eafc7cb4b0989866f0 Author: Vyacheslav Daradur Date: 2018-12-24T19:54:16Z Fixed > Double initialization of segmentAware and FileArchiver lead to race breaking > file compression. > -- > > Key: IGNITE-10671 > URL: https://issues.apache.org/jira/browse/IGNITE-10671 > Project: Ignite > Issue Type: Bug >Reporter: Pavel Voronkin >Assignee: Pavel Voronkin >Priority: Critical > Fix For: 2.8 > > Attachments: WalCompactionSwitchOverTest.java > > > Race is painful when you switch your cluster from walCompaction=false to > walCompaction=true. > The same FileCompressor instance will use different segmentAwares due to > start0() is called twice which leads to inconsistent behaviour and errors > during compaction, basically we will try to archive files twice concurrently. > See reproducer in attachment. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10671) Double initialization of segmentAware and FileArchiver lead to race breaking file compression.
[ https://issues.apache.org/jira/browse/IGNITE-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728313#comment-16728313 ] ASF GitHub Bot commented on IGNITE-10671: - Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/5665 > Double initialization of segmentAware and FileArchiver lead to race breaking > file compression. > -- > > Key: IGNITE-10671 > URL: https://issues.apache.org/jira/browse/IGNITE-10671 > Project: Ignite > Issue Type: Bug >Reporter: Pavel Voronkin >Assignee: Pavel Voronkin >Priority: Critical > Fix For: 2.8 > > Attachments: WalCompactionSwitchOverTest.java > > > Race is painful when you switch your cluster from walCompaction=false to > walCompaction=true. > The same FileCompressor instance will use different segmentAwares due to > start0() is called twice which leads to inconsistent behaviour and errors > during compaction, basically we will try to archive files twice concurrently. > See reproducer in attachment. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10671) Double initialization of segmentAware and FileArchiver lead to race breaking file compression.
[
https://issues.apache.org/jira/browse/IGNITE-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726615#comment-16726615
]
Ignite TC Bot commented on IGNITE-10671:
{panel:title=-- Run :: All: No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2609783buildTypeId=IgniteTests24Java8_RunAll]
> Double initialization of segmentAware and FileArchiver lead to race breaking
> file compression.
> --
>
> Key: IGNITE-10671
> URL: https://issues.apache.org/jira/browse/IGNITE-10671
> Project: Ignite
> Issue Type: Bug
>Reporter: Pavel Voronkin
>Assignee: Pavel Voronkin
>Priority: Critical
> Fix For: 2.8
>
> Attachments: WalCompactionSwitchOverTest.java
>
>
> Race is painful when you switch your cluster from walCompaction=false to
> walCompaction=true.
> The same FileCompressor instance will use different segmentAwares due to
> start0() is called twice which leads to inconsistent behaviour and errors
> during compaction, basically we will try to archive files twice concurrently.
> See reproducer in attachment.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10671) Double initialization of segmentAware and FileArchiver lead to race breaking file compression.
[
https://issues.apache.org/jira/browse/IGNITE-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726616#comment-16726616
]
Ignite TC Bot commented on IGNITE-10671:
{panel:title=-- Run :: All: No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2609783buildTypeId=IgniteTests24Java8_RunAll]
> Double initialization of segmentAware and FileArchiver lead to race breaking
> file compression.
> --
>
> Key: IGNITE-10671
> URL: https://issues.apache.org/jira/browse/IGNITE-10671
> Project: Ignite
> Issue Type: Bug
>Reporter: Pavel Voronkin
>Assignee: Pavel Voronkin
>Priority: Critical
> Fix For: 2.8
>
> Attachments: WalCompactionSwitchOverTest.java
>
>
> Race is painful when you switch your cluster from walCompaction=false to
> walCompaction=true.
> The same FileCompressor instance will use different segmentAwares due to
> start0() is called twice which leads to inconsistent behaviour and errors
> during compaction, basically we will try to archive files twice concurrently.
> See reproducer in attachment.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10671) Double initialization of segmentAware and FileArchiver lead to race breaking file compression.
[
https://issues.apache.org/jira/browse/IGNITE-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726613#comment-16726613
]
Ignite TC Bot commented on IGNITE-10671:
{panel:title=-- Run :: All: Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Cache 7{color} [[tests
2|https://ci.ignite.apache.org/viewLog.html?buildId=2610544]]
* IgniteCacheTestSuite7:
AuthenticationProcessorNodeRestartTest.testConcurrentFailedOperationNodeRestartServer
- 0,0% fails in last 303 master runs.
{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2609783buildTypeId=IgniteTests24Java8_RunAll]
> Double initialization of segmentAware and FileArchiver lead to race breaking
> file compression.
> --
>
> Key: IGNITE-10671
> URL: https://issues.apache.org/jira/browse/IGNITE-10671
> Project: Ignite
> Issue Type: Bug
>Reporter: Pavel Voronkin
>Assignee: Pavel Voronkin
>Priority: Critical
> Fix For: 2.8
>
> Attachments: WalCompactionSwitchOverTest.java
>
>
> Race is painful when you switch your cluster from walCompaction=false to
> walCompaction=true.
> The same FileCompressor instance will use different segmentAwares due to
> start0() is called twice which leads to inconsistent behaviour and errors
> during compaction, basically we will try to archive files twice concurrently.
> See reproducer in attachment.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10671) Double initialization of segmentAware and FileArchiver lead to race breaking file compression.
[
https://issues.apache.org/jira/browse/IGNITE-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726578#comment-16726578
]
Ignite TC Bot commented on IGNITE-10671:
{panel:title=-- Run :: All: Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}ZooKeeper (Discovery) 2{color} [[tests 0 TIMEOUT , Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=2609722]]
* GridCachePartitionedNodeRestartTest.testRestartWithTxFourNodesNoBackups (last
started)
{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2609783buildTypeId=IgniteTests24Java8_RunAll]
> Double initialization of segmentAware and FileArchiver lead to race breaking
> file compression.
> --
>
> Key: IGNITE-10671
> URL: https://issues.apache.org/jira/browse/IGNITE-10671
> Project: Ignite
> Issue Type: Bug
>Reporter: Pavel Voronkin
>Assignee: Pavel Voronkin
>Priority: Critical
> Fix For: 2.8
>
> Attachments: WalCompactionSwitchOverTest.java
>
>
> Race is painful when you switch your cluster from walCompaction=false to
> walCompaction=true.
> The same FileCompressor instance will use different segmentAwares due to
> start0() is called twice which leads to inconsistent behaviour and errors
> during compaction, basically we will try to archive files twice concurrently.
> See reproducer in attachment.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10671) Double initialization of segmentAware and FileArchiver lead to race breaking file compression.
[ https://issues.apache.org/jira/browse/IGNITE-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726537#comment-16726537 ] Pavel Voronkin commented on IGNITE-10671: - There is an error with ignite bot, i can't paste visa, [https://mtcga.gridgain.com/pr.html?serverId=apache=IgniteTests24Java8_RunAll==pull/5665/head=Latest.] Can you please check i've rerun blockers. > Double initialization of segmentAware and FileArchiver lead to race breaking > file compression. > -- > > Key: IGNITE-10671 > URL: https://issues.apache.org/jira/browse/IGNITE-10671 > Project: Ignite > Issue Type: Bug >Reporter: Pavel Voronkin >Assignee: Pavel Voronkin >Priority: Critical > Attachments: WalCompactionSwitchOverTest.java > > > Race is painful when you switch your cluster from walCompaction=false to > walCompaction=true. > The same FileCompressor instance will use different segmentAwares due to > start0() is called twice which leads to inconsistent behaviour and errors > during compaction, basically we will try to archive files twice concurrently. > See reproducer in attachment. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10671) Double initialization of segmentAware and FileArchiver lead to race breaking file compression.
[ https://issues.apache.org/jira/browse/IGNITE-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725904#comment-16725904 ] Anton Kalashnikov commented on IGNITE-10671: Now it's looks good for me. I think you can merge master to your branch and restart failed tests because it already was fixed. After that it can be merged to master. > Double initialization of segmentAware and FileArchiver lead to race breaking > file compression. > -- > > Key: IGNITE-10671 > URL: https://issues.apache.org/jira/browse/IGNITE-10671 > Project: Ignite > Issue Type: Bug >Reporter: Pavel Voronkin >Assignee: Pavel Voronkin >Priority: Critical > Attachments: WalCompactionSwitchOverTest.java > > > Race is painful when you switch your cluster from walCompaction=false to > walCompaction=true. > The same FileCompressor instance will use different segmentAwares due to > start0() is called twice which leads to inconsistent behaviour and errors > during compaction, basically we will try to archive files twice concurrently. > See reproducer in attachment. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10671) Double initialization of segmentAware and FileArchiver lead to race breaking file compression.
[ https://issues.apache.org/jira/browse/IGNITE-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725886#comment-16725886 ] Pavel Voronkin commented on IGNITE-10671: - [~akalashnikov] thanks, i've fixed your comments. > Double initialization of segmentAware and FileArchiver lead to race breaking > file compression. > -- > > Key: IGNITE-10671 > URL: https://issues.apache.org/jira/browse/IGNITE-10671 > Project: Ignite > Issue Type: Bug >Reporter: Pavel Voronkin >Assignee: Pavel Voronkin >Priority: Critical > Attachments: WalCompactionSwitchOverTest.java > > > Race is painful when you switch your cluster from walCompaction=false to > walCompaction=true. > The same FileCompressor instance will use different segmentAwares due to > start0() is called twice which leads to inconsistent behaviour and errors > during compaction, basically we will try to archive files twice concurrently. > See reproducer in attachment. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10671) Double initialization of segmentAware and FileArchiver lead to race breaking file compression.
[ https://issues.apache.org/jira/browse/IGNITE-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725838#comment-16725838 ] Anton Kalashnikov commented on IGNITE-10671: [~voropava], in general it looks good, but I have left a couple notes in [Upsource|https://reviews.ignite.apache.org/ignite/review/IGNT-CR-994] > Double initialization of segmentAware and FileArchiver lead to race breaking > file compression. > -- > > Key: IGNITE-10671 > URL: https://issues.apache.org/jira/browse/IGNITE-10671 > Project: Ignite > Issue Type: Bug >Reporter: Pavel Voronkin >Assignee: Pavel Voronkin >Priority: Critical > Attachments: WalCompactionSwitchOverTest.java > > > Race is painful when you switch your cluster from walCompaction=false to > walCompaction=true. > The same FileCompressor instance will use different segmentAwares due to > start0() is called twice which leads to inconsistent behaviour and errors > during compaction, basically we will try to archive files twice concurrently. > See reproducer in attachment. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10671) Double initialization of segmentAware and FileArchiver lead to race breaking file compression.
[ https://issues.apache.org/jira/browse/IGNITE-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725694#comment-16725694 ] Ivan Daschinskiy commented on IGNITE-10671: --- [~voropava] Code style now is ok, tests are also ok. I agree with fix, now it looks good to me. > Double initialization of segmentAware and FileArchiver lead to race breaking > file compression. > -- > > Key: IGNITE-10671 > URL: https://issues.apache.org/jira/browse/IGNITE-10671 > Project: Ignite > Issue Type: Bug >Reporter: Pavel Voronkin >Assignee: Pavel Voronkin >Priority: Critical > Attachments: WalCompactionSwitchOverTest.java > > > Race is painful when you switch your cluster from walCompaction=false to > walCompaction=true. > The same FileCompressor instance will use different segmentAwares due to > start0() is called twice which leads to inconsistent behaviour and errors > during compaction, basically we will try to archive files twice concurrently. > See reproducer in attachment. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10671) Double initialization of segmentAware and FileArchiver lead to race breaking file compression.
[ https://issues.apache.org/jira/browse/IGNITE-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725638#comment-16725638 ] Pavel Voronkin commented on IGNITE-10671: - Failures are not related to my changes and exists on master branch. |[JDBC Driver|https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_JdbcDriver=pull%2F5665%2Fhead=buildTypeStatusDiv] [ [tests 0 TIMEOUT , Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=2592534]] |[Critical F.R.: 0,0%|https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_JdbcDriver=%3Cdefault%3E=buildTypeStatusDiv]| | | JdbcThinTransactionsServerNoAutoCommitComplexSelfTest.testBatchDmlStatements (last started)|(no data) | | | [!https://cdn2.iconfinder.com/data/icons/metro-uinvert-dock/256/Services.png|width=12,height=12! Thread Dump|https://mtcga.gridgain.com/rest/getBuildLog/threadDump?serverId=apache=2592534=-1]| | | | | | | | [Spring|https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_Spring=pull%2F5665%2Fhead=buildTypeStatusDiv] [ [tests 0 Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=2592538]] | | | | CacheJdbcBlobStoreFactorySelfTest.testIncorrectBeanConfiguration (last started)|(no data) | | | | | | | [Queries 1|https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_Queries1=pull%2F5665%2Fhead=buildTypeStatusDiv] [ [tests 0 Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=2592603]] | | | | IgniteSqlSchemaIndexingTest.testCustomSchemaMultipleCachesTablesCollision (last started)|(no data) | | | | | | | [Hibernate 5.1|https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_Hibernate2=pull%2F5665%2Fhead=buildTypeStatusDiv] [ [tests 0 Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=2592527]] | | | | CacheHibernateStoreFactorySelfTest.testIncorrectBeanConfiguration (last started)|(no data) | | | | | | | [Hibernate 4.2|https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_Hibernate1=pull%2F5665%2Fhead=buildTypeStatusDiv] [ [tests 0 Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=2592526]] | | | | CacheHibernateStoreFactorySelfTest.testIncorrectBeanConfiguration (last started)|(no data) | | | | | | | [Thin client: PHP|https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_ThinClientPhp=pull%2F5665%2Fhead=buildTypeStatusDiv] [ [tests 102 Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=2592561]] | | | | | | | | [[Inspections] Core|https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_InspectionsCore=pull%2F5665%2Fhead=buildTypeStatusDiv] [ [tests 0 TC_ADD_MSG |https://ci.ignite.apache.org/viewLog.html?buildId=2592605]| | > Double initialization of segmentAware and FileArchiver lead to race breaking > file compression. > -- > > Key: IGNITE-10671 > URL: https://issues.apache.org/jira/browse/IGNITE-10671 > Project: Ignite > Issue Type: Bug >Reporter: Pavel Voronkin >Assignee: Pavel Voronkin >Priority: Critical > Attachments: WalCompactionSwitchOverTest.java > > > Race is painful when you switch your cluster from walCompaction=false to > walCompaction=true. > The same FileCompressor instance will use different segmentAwares due to > start0() is called twice which leads to inconsistent behaviour and errors > during compaction, basically we will try to archive files twice concurrently. > See reproducer in attachment. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10671) Double initialization of segmentAware and FileArchiver lead to race breaking file compression.
[ https://issues.apache.org/jira/browse/IGNITE-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720348#comment-16720348 ] ASF GitHub Bot commented on IGNITE-10671: - GitHub user voropava opened a pull request: https://github.com/apache/ignite/pull/5665 IGNITE-10671 Introduced state machine to handle lifecycle of start/ac… …tivate/stop. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-10671 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5665.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5665 commit 467a0916286482ffa41362e5f88307695912048c Author: Pavel Voronkin Date: 2018-12-13T16:10:01Z IGNITE-10671 Introduced state machine to handle lifecycle of start/activate/stop. > Double initialization of segmentAware and FileArchiver lead to race breaking > file compression. > -- > > Key: IGNITE-10671 > URL: https://issues.apache.org/jira/browse/IGNITE-10671 > Project: Ignite > Issue Type: Bug >Reporter: Pavel Voronkin >Assignee: Pavel Voronkin >Priority: Critical > Attachments: WalCompactionSwitchOverTest.java > > > Race is painful when you switch your cluster from walCompaction=false to > walCompaction=true. > The same FileCompressor instance will use different segmentAwares due to > start0() is called twice which leads to inconsistent behaviour and errors > during compaction, basically we will try to archive files twice concurrently. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
