[jira] [Commented] (IGNITE-1084) [Test] HibernateL2CacheSelfTest#testNaturalIdCache() is broken

[Vadim Opolski (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047903#comment-16047903
 ] 

Vadim Opolski commented on IGNITE-1084:
---

I'm wrong




> [Test] HibernateL2CacheSelfTest#testNaturalIdCache() is broken
> --
>
> Key: IGNITE-1084
> URL: https://issues.apache.org/jira/browse/IGNITE-1084
> Project: Ignite
>  Issue Type: Sub-task
>  Components: cache
>Reporter: Sergey Evdokimov
>Assignee: Vadim Opolski
>Priority: Minor
>  Labels: Muted_test
> Fix For: 2.1
>
>
> Test HibernateL2CacheSelfTest#testNaturalIdCache() should be unmuted and 
> fixed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-1084) [Test] HibernateL2CacheSelfTest#testNaturalIdCache() is broken

[Anton Vinogradov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047892#comment-16047892
 ] 

Anton Vinogradov commented on IGNITE-1084:
--

[~javaller]

IGNITE-4760 fixed at 2.1. 
Why you specified 2.0 as a fix version?


> [Test] HibernateL2CacheSelfTest#testNaturalIdCache() is broken
> --
>
> Key: IGNITE-1084
> URL: https://issues.apache.org/jira/browse/IGNITE-1084
> Project: Ignite
>  Issue Type: Sub-task
>  Components: cache
>Reporter: Sergey Evdokimov
>Assignee: Vadim Opolski
>Priority: Minor
>  Labels: Muted_test
> Fix For: 2.0
>
>
> Test HibernateL2CacheSelfTest#testNaturalIdCache() should be unmuted and 
> fixed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-1084) [Test] HibernateL2CacheSelfTest#testNaturalIdCache() is broken

[Vadim Opolski (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047872#comment-16047872
 ] 

Vadim Opolski commented on IGNITE-1084:
---

Done




> [Test] HibernateL2CacheSelfTest#testNaturalIdCache() is broken
> --
>
> Key: IGNITE-1084
> URL: https://issues.apache.org/jira/browse/IGNITE-1084
> Project: Ignite
>  Issue Type: Sub-task
>  Components: cache
>Reporter: Sergey Evdokimov
>Assignee: Vadim Opolski
>Priority: Minor
>  Labels: Muted_test
> Fix For: 2.0
>
>
> Test HibernateL2CacheSelfTest#testNaturalIdCache() should be unmuted and 
> fixed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-1084) [Test] HibernateL2CacheSelfTest#testNaturalIdCache() is broken

[Anton Vinogradov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047825#comment-16047825
 ] 

Anton Vinogradov commented on IGNITE-1084:
--

[~javaller]

Got it, 
Please specify correct fixVersion and resolve the issue.

> [Test] HibernateL2CacheSelfTest#testNaturalIdCache() is broken
> --
>
> Key: IGNITE-1084
> URL: https://issues.apache.org/jira/browse/IGNITE-1084
> Project: Ignite
>  Issue Type: Sub-task
>  Components: cache
>Reporter: Sergey Evdokimov
>Assignee: Vadim Opolski
>Priority: Minor
>  Labels: Muted_test
>
> Test HibernateL2CacheSelfTest#testNaturalIdCache() should be unmuted and 
> fixed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-1084) [Test] HibernateL2CacheSelfTest#testNaturalIdCache() is broken

[Anton Vinogradov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16044200#comment-16044200
 ] 

Anton Vinogradov commented on IGNITE-1084:
--

[~javaller]
Please explain why this issue was closed as fixed without
- any comments
- fix version 
- commit to master branch

> [Test] HibernateL2CacheSelfTest#testNaturalIdCache() is broken
> --
>
> Key: IGNITE-1084
> URL: https://issues.apache.org/jira/browse/IGNITE-1084
> Project: Ignite
>  Issue Type: Sub-task
>  Components: cache
>Reporter: Sergey Evdokimov
>Assignee: Vadim Opolski
>Priority: Minor
>  Labels: Muted_test
>
> Test HibernateL2CacheSelfTest#testNaturalIdCache() should be unmuted and 
> fixed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-1084) [Test] HibernateL2CacheSelfTest#testNaturalIdCache() is broken

[Vadim Opolski (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976791#comment-15976791
 ] 

Vadim Opolski commented on IGNITE-1084:
---

https://github.com/apache/ignite/pull/1841


> [Test] HibernateL2CacheSelfTest#testNaturalIdCache() is broken
> --
>
> Key: IGNITE-1084
> URL: https://issues.apache.org/jira/browse/IGNITE-1084
> Project: Ignite
>  Issue Type: Sub-task
>  Components: cache
>Reporter: Sergey Evdokimov
>Assignee: Vadim Opolski
>Priority: Minor
>  Labels: Muted_test
>
> Test HibernateL2CacheSelfTest#testNaturalIdCache() should be unmuted and 
> fixed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-1084) [Test] HibernateL2CacheSelfTest#testNaturalIdCache() is broken

[Semen Boikov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974449#comment-15974449
 ] 

Semen Boikov commented on IGNITE-1084:
--

I debugged test and found that reason of test failure is IGNITE-4760, so 
suggested test fix is not correct. Need check test does not fail when 
IGNITE-4760 is fixed.

> [Test] HibernateL2CacheSelfTest#testNaturalIdCache() is broken
> --
>
> Key: IGNITE-1084
> URL: https://issues.apache.org/jira/browse/IGNITE-1084
> Project: Ignite
>  Issue Type: Sub-task
>  Components: cache
>Reporter: Sergey Evdokimov
>Assignee: Vadim Opolski
>Priority: Minor
>  Labels: Muted_test
>
> Test HibernateL2CacheSelfTest#testNaturalIdCache() should be unmuted and 
> fixed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-1084) [Test] HibernateL2CacheSelfTest#testNaturalIdCache() is broken

[Anton Vinogradov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426255#comment-15426255
 ] 

Anton Vinogradov commented on IGNITE-1084:
--

Milap, 
Thanks for pull request and explanation, but each contribution should follow 
rules explained here: 
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers
some tips:
1) Provided pullrequest should contain only changes related to the issue and it 
should be mergable to master branch.
2) Provided code should follow 
https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules and 
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines
3) Most important: TeamCity should be used to check pullrequest.
4) Issue status should be changed to PATCH AVAILABLE 
Thanks!

> [Test] HibernateL2CacheSelfTest#testNaturalIdCache() is broken
> --
>
> Key: IGNITE-1084
> URL: https://issues.apache.org/jira/browse/IGNITE-1084
> Project: Ignite
>  Issue Type: Test
>  Components: cache
>Reporter: Sergey Evdokimov
>Assignee: Milap Wadhwa
>Priority: Minor
>  Labels: Muted_test
>
> Test HibernateL2CacheSelfTest#testNaturalIdCache() should be unmuted and 
> fixed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1084) [Test] HibernateL2CacheSelfTest#testNaturalIdCache() is broken

[Milap Wadhwa (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407848#comment-15407848
 ] 

Milap Wadhwa commented on IGNITE-1084:
--

Hi Yakov,

Issue is with NONSTRICT_READ_WRITE policy in hibernate.

In case of Read_Write policy hibernate uses Optimistic Locking where NaturalId 
key is used as a lock. If someone is trying to update the row, hibernate will 
acquire the lock on the key and subsequent reads/writes for the same key will 
be served by DB layer and later L2 cache will get updated asynchronously and 
eventually will remove the lock on the key.

But in case of NonStrictReadWrite, Hibernate allows read on inconsistent key 
from L2 cache i.e. It does not acquire the lock. which means subsequent reads 
will be allowed to read from L2 cache and background process will evict the 
cache for the key asynchronously. 

Test case is failing because It is checking non-existence of k (NaturalId) 
which is correct behaviour because test case is changing k to k`
In NonStrictReadWrite L2 cache has reads for both keys k and k` because It does 
not have lock on k which is incorrect. 
This is not causing problem for ReadWrite because key k is always locked in L2 
cache which delegate this read to db which eventually does not have key k 
(update with k`) and hence the test case is passing.

Solution:
problem is due to inconsistent L2 cache state in case of updating the 
naturalId. So, before validating the test case, wrote a utility to reload the 
entire L2 cache. 

I hope I have explained it properly. Please let me know If you need more info.


Regards,
Milap Wadhwa

> [Test] HibernateL2CacheSelfTest#testNaturalIdCache() is broken
> --
>
> Key: IGNITE-1084
> URL: https://issues.apache.org/jira/browse/IGNITE-1084
> Project: Ignite
>  Issue Type: Test
>  Components: cache
>Reporter: Sergey Evdokimov
>Assignee: Milap Wadhwa
>Priority: Minor
>  Labels: Muted_test
>
> Test HibernateL2CacheSelfTest#testNaturalIdCache() should be unmuted and 
> fixed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1084) [Test] HibernateL2CacheSelfTest#testNaturalIdCache() is broken

[Yakov Zhdanov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406085#comment-15406085
 ] 

Yakov Zhdanov commented on IGNITE-1084:
---

[~milap.wadhwa] can you please describe your changes in a few words?

> [Test] HibernateL2CacheSelfTest#testNaturalIdCache() is broken
> --
>
> Key: IGNITE-1084
> URL: https://issues.apache.org/jira/browse/IGNITE-1084
> Project: Ignite
>  Issue Type: Test
>  Components: cache
>Reporter: Sergey Evdokimov
>Assignee: Milap Wadhwa
>Priority: Minor
>  Labels: Muted_test
>
> Test HibernateL2CacheSelfTest#testNaturalIdCache() should be unmuted and 
> fixed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1084) [Test] HibernateL2CacheSelfTest#testNaturalIdCache() is broken

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395459#comment-15395459
 ] 

ASF GitHub Bot commented on IGNITE-1084:


GitHub user mwadhwa opened a pull request:

https://github.com/apache/ignite/pull/901

IGNITE-1084 fixed issue  broken HibernateL2CacheSelfTest#testNaturalI…

…dCache()

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mwadhwa/ignite master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/901.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #901


commit 2a1be7d6925390081d8aa674b516381e4c5a0b42
Author: milap.wadhwa 
Date:   2016-07-27T11:11:55Z

IGNITE-1084 fixed issue  broken 
HibernateL2CacheSelfTest#testNaturalIdCache()




> [Test] HibernateL2CacheSelfTest#testNaturalIdCache() is broken
> --
>
> Key: IGNITE-1084
> URL: https://issues.apache.org/jira/browse/IGNITE-1084
> Project: Ignite
>  Issue Type: Test
>  Components: cache
>Reporter: Sergey Evdokimov
>Assignee: Milap Wadhwa
>Priority: Minor
>  Labels: Muted_test
>
> Test HibernateL2CacheSelfTest#testNaturalIdCache() should be unmuted and 
> fixed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)