[jira] [Commented] (IGNITE-11356) Test framework: Remove custom assumption exceptions handling
[
https://issues.apache.org/jira/browse/IGNITE-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797117#comment-16797117
]
Ivan Pavlukhin commented on IGNITE-11356:
-
Thank you Ilya. I am glad that you helped me to accomplish with it.
> Test framework: Remove custom assumption exceptions handling
>
>
> Key: IGNITE-11356
> URL: https://issues.apache.org/jira/browse/IGNITE-11356
> Project: Ignite
> Issue Type: Task
>Reporter: Ivan Pavlukhin
>Assignee: Ivan Pavlukhin
>Priority: Major
> Labels: MakeTeamcityGreenAgain
> Time Spent: 40m
> Remaining Estimate: 0h
>
> It turns out that custom handling of {{AssumptionViolatedException}} can be
> removed. Currently with custom handling tests with unmet assumptions are
> marked as passed. With default handling failed assumptions on instance level
> mark tests as ignored.
> Note: on class level reporting in case of unmet assumptions does not look
> perfect. But with custom handling a particular test is not included into TC
> report at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11356) Test framework: Remove custom assumption exceptions handling
[
https://issues.apache.org/jira/browse/IGNITE-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797076#comment-16797076
]
Ilya Kasnacheev commented on IGNITE-11356:
--
I have merged this change to master! Thank you for your code cleanup efforts.
> Test framework: Remove custom assumption exceptions handling
>
>
> Key: IGNITE-11356
> URL: https://issues.apache.org/jira/browse/IGNITE-11356
> Project: Ignite
> Issue Type: Task
>Reporter: Ivan Pavlukhin
>Assignee: Ivan Pavlukhin
>Priority: Major
> Labels: MakeTeamcityGreenAgain
> Time Spent: 40m
> Remaining Estimate: 0h
>
> It turns out that custom handling of {{AssumptionViolatedException}} can be
> removed. Currently with custom handling tests with unmet assumptions are
> marked as passed. With default handling failed assumptions on instance level
> mark tests as ignored.
> Note: on class level reporting in case of unmet assumptions does not look
> perfect. But with custom handling a particular test is not included into TC
> report at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11356) Test framework: Remove custom assumption exceptions handling
[
https://issues.apache.org/jira/browse/IGNITE-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796892#comment-16796892
]
Ivan Pavlukhin commented on IGNITE-11356:
-
[~ilyak], tests are ready, take a look.
> Test framework: Remove custom assumption exceptions handling
>
>
> Key: IGNITE-11356
> URL: https://issues.apache.org/jira/browse/IGNITE-11356
> Project: Ignite
> Issue Type: Task
>Reporter: Ivan Pavlukhin
>Assignee: Ivan Pavlukhin
>Priority: Major
> Labels: MakeTeamcityGreenAgain
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> It turns out that custom handling of {{AssumptionViolatedException}} can be
> removed. Currently with custom handling tests with unmet assumptions are
> marked as passed. With default handling failed assumptions on instance level
> mark tests as ignored.
> Note: on class level reporting in case of unmet assumptions does not look
> perfect. But with custom handling a particular test is not included into TC
> report at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11356) Test framework: Remove custom assumption exceptions handling
[
https://issues.apache.org/jira/browse/IGNITE-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796891#comment-16796891
]
Ignite TC Bot commented on IGNITE-11356:
{panel:title=--> Run :: All (Nightly): No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All (Nightly)*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=3353824&buildTypeId=IgniteTests24Java8_RunAllNightly]
> Test framework: Remove custom assumption exceptions handling
>
>
> Key: IGNITE-11356
> URL: https://issues.apache.org/jira/browse/IGNITE-11356
> Project: Ignite
> Issue Type: Task
>Reporter: Ivan Pavlukhin
>Assignee: Ivan Pavlukhin
>Priority: Major
> Labels: MakeTeamcityGreenAgain
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It turns out that custom handling of {{AssumptionViolatedException}} can be
> removed. Currently with custom handling tests with unmet assumptions are
> marked as passed. With default handling failed assumptions on instance level
> mark tests as ignored.
> Note: on class level reporting in case of unmet assumptions does not look
> perfect. But with custom handling a particular test is not included into TC
> report at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11356) Test framework: Remove custom assumption exceptions handling
[
https://issues.apache.org/jira/browse/IGNITE-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796044#comment-16796044
]
Ivan Pavlukhin commented on IGNITE-11356:
-
[~ilyak], now it seems to be a real conflict. There was a commit to
{{GridAbstractTest}} earlier today. I resolved conflicts and updated last PR
(6288). But because there were some changes it worth to take a look and run
tests again. I will return when tests are ready.
> Test framework: Remove custom assumption exceptions handling
>
>
> Key: IGNITE-11356
> URL: https://issues.apache.org/jira/browse/IGNITE-11356
> Project: Ignite
> Issue Type: Task
>Reporter: Ivan Pavlukhin
>Assignee: Ivan Pavlukhin
>Priority: Major
> Labels: MakeTeamcityGreenAgain
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It turns out that custom handling of {{AssumptionViolatedException}} can be
> removed. Currently with custom handling tests with unmet assumptions are
> marked as passed. With default handling failed assumptions on instance level
> mark tests as ignored.
> Note: on class level reporting in case of unmet assumptions does not look
> perfect. But with custom handling a particular test is not included into TC
> report at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11356) Test framework: Remove custom assumption exceptions handling
[
https://issues.apache.org/jira/browse/IGNITE-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796007#comment-16796007
]
Ilya Kasnacheev commented on IGNITE-11356:
--
[~Pavlukhin]
> Test framework: Remove custom assumption exceptions handling
>
>
> Key: IGNITE-11356
> URL: https://issues.apache.org/jira/browse/IGNITE-11356
> Project: Ignite
> Issue Type: Task
>Reporter: Ivan Pavlukhin
>Assignee: Ivan Pavlukhin
>Priority: Major
> Labels: MakeTeamcityGreenAgain
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It turns out that custom handling of {{AssumptionViolatedException}} can be
> removed. Currently with custom handling tests with unmet assumptions are
> marked as passed. With default handling failed assumptions on instance level
> mark tests as ignored.
> Note: on class level reporting in case of unmet assumptions does not look
> perfect. But with custom handling a particular test is not included into TC
> report at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11356) Test framework: Remove custom assumption exceptions handling
[
https://issues.apache.org/jira/browse/IGNITE-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796006#comment-16796006
]
Ilya Kasnacheev commented on IGNITE-11356:
--
{code}
This branch has conflicts that must be resolved
Only those with write access to this repository can merge pull requests.
Conflicting files
modules/core/src/test/java/org/apache/ignite/testframework/junits/GridAbstractTest.java
{code}
:(
> Test framework: Remove custom assumption exceptions handling
>
>
> Key: IGNITE-11356
> URL: https://issues.apache.org/jira/browse/IGNITE-11356
> Project: Ignite
> Issue Type: Task
>Reporter: Ivan Pavlukhin
>Assignee: Ivan Pavlukhin
>Priority: Major
> Labels: MakeTeamcityGreenAgain
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It turns out that custom handling of {{AssumptionViolatedException}} can be
> removed. Currently with custom handling tests with unmet assumptions are
> marked as passed. With default handling failed assumptions on instance level
> mark tests as ignored.
> Note: on class level reporting in case of unmet assumptions does not look
> perfect. But with custom handling a particular test is not included into TC
> report at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11356) Test framework: Remove custom assumption exceptions handling
[
https://issues.apache.org/jira/browse/IGNITE-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16794973#comment-16794973
]
Ivan Pavlukhin commented on IGNITE-11356:
-
[~ilyak], I created PR with a single squashed commit. Please take a look
https://github.com/apache/ignite/pull/6288/commits
> Test framework: Remove custom assumption exceptions handling
>
>
> Key: IGNITE-11356
> URL: https://issues.apache.org/jira/browse/IGNITE-11356
> Project: Ignite
> Issue Type: Task
>Reporter: Ivan Pavlukhin
>Assignee: Ivan Pavlukhin
>Priority: Major
> Labels: MakeTeamcityGreenAgain
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It turns out that custom handling of {{AssumptionViolatedException}} can be
> removed. Currently with custom handling tests with unmet assumptions are
> marked as passed. With default handling failed assumptions on instance level
> mark tests as ignored.
> Note: on class level reporting in case of unmet assumptions does not look
> perfect. But with custom handling a particular test is not included into TC
> report at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11356) Test framework: Remove custom assumption exceptions handling
[
https://issues.apache.org/jira/browse/IGNITE-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16794959#comment-16794959
]
Ilya Kasnacheev commented on IGNITE-11356:
--
[~Pavlukhin]
Unfortunately I still get "Could not merge the pull-request to master without
conflicts. " when trying to apply this PR. I'm not an expert on how to make it
work. Maybe create a different PR with squashed commit?
> Test framework: Remove custom assumption exceptions handling
>
>
> Key: IGNITE-11356
> URL: https://issues.apache.org/jira/browse/IGNITE-11356
> Project: Ignite
> Issue Type: Task
>Reporter: Ivan Pavlukhin
>Assignee: Ivan Pavlukhin
>Priority: Major
> Labels: MakeTeamcityGreenAgain
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It turns out that custom handling of {{AssumptionViolatedException}} can be
> removed. Currently with custom handling tests with unmet assumptions are
> marked as passed. With default handling failed assumptions on instance level
> mark tests as ignored.
> Note: on class level reporting in case of unmet assumptions does not look
> perfect. But with custom handling a particular test is not included into TC
> report at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11356) Test framework: Remove custom assumption exceptions handling
[
https://issues.apache.org/jira/browse/IGNITE-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16794899#comment-16794899
]
Ivan Pavlukhin commented on IGNITE-11356:
-
[~ilyak] I rebased changes, please take a look.
> Test framework: Remove custom assumption exceptions handling
>
>
> Key: IGNITE-11356
> URL: https://issues.apache.org/jira/browse/IGNITE-11356
> Project: Ignite
> Issue Type: Task
>Reporter: Ivan Pavlukhin
>Assignee: Ivan Pavlukhin
>Priority: Major
> Labels: MakeTeamcityGreenAgain
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It turns out that custom handling of {{AssumptionViolatedException}} can be
> removed. Currently with custom handling tests with unmet assumptions are
> marked as passed. With default handling failed assumptions on instance level
> mark tests as ignored.
> Note: on class level reporting in case of unmet assumptions does not look
> perfect. But with custom handling a particular test is not included into TC
> report at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11356) Test framework: Remove custom assumption exceptions handling
[
https://issues.apache.org/jira/browse/IGNITE-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16794884#comment-16794884
]
Ilya Kasnacheev commented on IGNITE-11356:
--
[~Pavlukhin] can you please rebase this change to latest master? Unfortunately
it would not apply without conflicts.
> Test framework: Remove custom assumption exceptions handling
>
>
> Key: IGNITE-11356
> URL: https://issues.apache.org/jira/browse/IGNITE-11356
> Project: Ignite
> Issue Type: Task
>Reporter: Ivan Pavlukhin
>Assignee: Ivan Pavlukhin
>Priority: Major
> Labels: MakeTeamcityGreenAgain
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It turns out that custom handling of {{AssumptionViolatedException}} can be
> removed. Currently with custom handling tests with unmet assumptions are
> marked as passed. With default handling failed assumptions on instance level
> mark tests as ignored.
> Note: on class level reporting in case of unmet assumptions does not look
> perfect. But with custom handling a particular test is not included into TC
> report at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11356) Test framework: Remove custom assumption exceptions handling
[
https://issues.apache.org/jira/browse/IGNITE-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16794751#comment-16794751
]
Ignite TC Bot commented on IGNITE-11356:
{panel:title=--> Run :: All (Nightly): No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All (Nightly)*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=3336716&buildTypeId=IgniteTests24Java8_RunAllNightly]
> Test framework: Remove custom assumption exceptions handling
>
>
> Key: IGNITE-11356
> URL: https://issues.apache.org/jira/browse/IGNITE-11356
> Project: Ignite
> Issue Type: Task
>Reporter: Ivan Pavlukhin
>Assignee: Ivan Pavlukhin
>Priority: Major
> Labels: MakeTeamcityGreenAgain
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It turns out that custom handling of {{AssumptionViolatedException}} can be
> removed. Currently with custom handling tests with unmet assumptions are
> marked as passed. With default handling failed assumptions on instance level
> mark tests as ignored.
> Note: on class level reporting in case of unmet assumptions does not look
> perfect. But with custom handling a particular test is not included into TC
> report at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11356) Test framework: Remove custom assumption exceptions handling
[
https://issues.apache.org/jira/browse/IGNITE-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777804#comment-16777804
]
Sergey Chugunov commented on IGNITE-11356:
--
[~Pavlukhin],
Patch looks good to me. As we don't have any regression in tests, lets proceed
with merging it to master.
Thanks for contribution!
> Test framework: Remove custom assumption exceptions handling
>
>
> Key: IGNITE-11356
> URL: https://issues.apache.org/jira/browse/IGNITE-11356
> Project: Ignite
> Issue Type: Task
>Reporter: Ivan Pavlukhin
>Assignee: Ivan Pavlukhin
>Priority: Major
> Labels: MakeTeamcityGreenAgain
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It turns out that custom handling of {{AssumptionViolatedException}} can be
> removed. Currently with custom handling tests with unmet assumptions are
> marked as passed. With default handling failed assumptions on instance level
> mark tests as ignored.
> Note: on class level reporting in case of unmet assumptions does not look
> perfect. But with custom handling a particular test is not included into TC
> report at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11356) Test framework: Remove custom assumption exceptions handling
[
https://issues.apache.org/jira/browse/IGNITE-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1639#comment-1639
]
Ivan Pavlukhin commented on IGNITE-11356:
-
Rerun tests after merge with latest master.
> Test framework: Remove custom assumption exceptions handling
>
>
> Key: IGNITE-11356
> URL: https://issues.apache.org/jira/browse/IGNITE-11356
> Project: Ignite
> Issue Type: Task
>Reporter: Ivan Pavlukhin
>Assignee: Ivan Pavlukhin
>Priority: Major
> Labels: MakeTeamcityGreenAgain
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It turns out that custom handling of {{AssumptionViolatedException}} can be
> removed. Currently with custom handling tests with unmet assumptions are
> marked as passed. With default handling failed assumptions on instance level
> mark tests as ignored.
> Note: on class level reporting in case of unmet assumptions does not look
> perfect. But with custom handling a particular test is not included into TC
> report at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11356) Test framework: Remove custom assumption exceptions handling
[
https://issues.apache.org/jira/browse/IGNITE-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1622#comment-1622
]
Ignite TC Bot commented on IGNITE-11356:
{panel:title=--> Run :: All: Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}_Javadoc_{color} [[tests 0 BuildFailureOnMessage
|https://ci.ignite.apache.org/viewLog.html?buildId=3182665]]
{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=3181875&buildTypeId=IgniteTests24Java8_RunAll]
> Test framework: Remove custom assumption exceptions handling
>
>
> Key: IGNITE-11356
> URL: https://issues.apache.org/jira/browse/IGNITE-11356
> Project: Ignite
> Issue Type: Task
>Reporter: Ivan Pavlukhin
>Assignee: Ivan Pavlukhin
>Priority: Major
> Labels: MakeTeamcityGreenAgain
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It turns out that custom handling of {{AssumptionViolatedException}} can be
> removed. Currently with custom handling tests with unmet assumptions are
> marked as passed. With default handling failed assumptions on instance level
> mark tests as ignored.
> Note: on class level reporting in case of unmet assumptions does not look
> perfect. But with custom handling a particular test is not included into TC
> report at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11356) Test framework: Remove custom assumption exceptions handling
[
https://issues.apache.org/jira/browse/IGNITE-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777125#comment-16777125
]
Ivan Pavlukhin commented on IGNITE-11356:
-
Apparently, some glitches are possible after explicit lock removal. So, I
reverted PR to an initial stage. First visa corresponds to that state.
> Test framework: Remove custom assumption exceptions handling
>
>
> Key: IGNITE-11356
> URL: https://issues.apache.org/jira/browse/IGNITE-11356
> Project: Ignite
> Issue Type: Task
>Reporter: Ivan Pavlukhin
>Assignee: Ivan Pavlukhin
>Priority: Major
> Labels: MakeTeamcityGreenAgain
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It turns out that custom handling of {{AssumptionViolatedException}} can be
> removed. Currently with custom handling tests with unmet assumptions are
> marked as passed. With default handling failed assumptions on instance level
> mark tests as ignored.
> Note: on class level reporting in case of unmet assumptions does not look
> perfect. But with custom handling a particular test is not included into TC
> report at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11356) Test framework: Remove custom assumption exceptions handling
[
https://issues.apache.org/jira/browse/IGNITE-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16774874#comment-16774874
]
Ivan Pavlukhin commented on IGNITE-11356:
-
[~sergey-chugunov], I removed using of lock in the class rule and renamed the
class. Tests looks good after these changes. {{Disk Page Compressions}} build
currently hangs in master branch as well.
> Test framework: Remove custom assumption exceptions handling
>
>
> Key: IGNITE-11356
> URL: https://issues.apache.org/jira/browse/IGNITE-11356
> Project: Ignite
> Issue Type: Task
>Reporter: Ivan Pavlukhin
>Assignee: Ivan Pavlukhin
>Priority: Major
> Labels: MakeTeamcityGreenAgain
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It turns out that custom handling of {{AssumptionViolatedException}} can be
> removed. Currently with custom handling tests with unmet assumptions are
> marked as passed. With default handling failed assumptions on instance level
> mark tests as ignored.
> Note: on class level reporting in case of unmet assumptions does not look
> perfect. But with custom handling a particular test is not included into TC
> report at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11356) Test framework: Remove custom assumption exceptions handling
[
https://issues.apache.org/jira/browse/IGNITE-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16774873#comment-16774873
]
Ignite TC Bot commented on IGNITE-11356:
{panel:title=--> Run :: All (Nightly): Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Disk Page Compressions{color} [[tests 0 TIMEOUT , Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=3144521]]
* IgnitePdsExchangeDuringCheckpointTest.testExchangeOnNodeJoin (last started)
{panel}
[TeamCity *--> Run :: All (Nightly)*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=3142214&buildTypeId=IgniteTests24Java8_RunAllNightly]
> Test framework: Remove custom assumption exceptions handling
>
>
> Key: IGNITE-11356
> URL: https://issues.apache.org/jira/browse/IGNITE-11356
> Project: Ignite
> Issue Type: Task
>Reporter: Ivan Pavlukhin
>Assignee: Ivan Pavlukhin
>Priority: Major
> Labels: MakeTeamcityGreenAgain
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It turns out that custom handling of {{AssumptionViolatedException}} can be
> removed. Currently with custom handling tests with unmet assumptions are
> marked as passed. With default handling failed assumptions on instance level
> mark tests as ignored.
> Note: on class level reporting in case of unmet assumptions does not look
> perfect. But with custom handling a particular test is not included into TC
> report at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11356) Test framework: Remove custom assumption exceptions handling
[
https://issues.apache.org/jira/browse/IGNITE-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773088#comment-16773088
]
Ivan Pavlukhin commented on IGNITE-11356:
-
[~sergey-chugunov] I will spend some to check if a class rule body is needed to
be executed under exclusive lock. If not I will remove that logic and rename a
rule class in a way reflecting it's single responsibility.
> Test framework: Remove custom assumption exceptions handling
>
>
> Key: IGNITE-11356
> URL: https://issues.apache.org/jira/browse/IGNITE-11356
> Project: Ignite
> Issue Type: Task
>Reporter: Ivan Pavlukhin
>Assignee: Ivan Pavlukhin
>Priority: Major
> Labels: MakeTeamcityGreenAgain
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It turns out that custom handling of {{AssumptionViolatedException}} can be
> removed. Currently with custom handling tests with unmet assumptions are
> marked as passed. With default handling failed assumptions on instance level
> mark tests as ignored.
> Note: on class level reporting in case of unmet assumptions does not look
> perfect. But with custom handling a particular test is not included into TC
> report at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11356) Test framework: Remove custom assumption exceptions handling
[
https://issues.apache.org/jira/browse/IGNITE-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773073#comment-16773073
]
Sergey Chugunov commented on IGNITE-11356:
--
[~Pavlukhin],
Fix looks good to me, but could we come up with a better name for
`GridClassRule`?
I think we can even borrow from member name `firstLastTestRule` to make the
purpose obvious without need of reading javadoc on implementation class.
> Test framework: Remove custom assumption exceptions handling
>
>
> Key: IGNITE-11356
> URL: https://issues.apache.org/jira/browse/IGNITE-11356
> Project: Ignite
> Issue Type: Task
>Reporter: Ivan Pavlukhin
>Assignee: Ivan Pavlukhin
>Priority: Major
> Labels: MakeTeamcityGreenAgain
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It turns out that custom handling of {{AssumptionViolatedException}} can be
> removed. Currently with custom handling tests with unmet assumptions are
> marked as passed. With default handling failed assumptions on instance level
> mark tests as ignored.
> Note: on class level reporting in case of unmet assumptions does not look
> perfect. But with custom handling a particular test is not included into TC
> report at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11356) Test framework: Remove custom assumption exceptions handling
[
https://issues.apache.org/jira/browse/IGNITE-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16772727#comment-16772727
]
Ignite TC Bot commented on IGNITE-11356:
{panel:title=--> Run :: All (Nightly): No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All (Nightly)*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=3125455&buildTypeId=IgniteTests24Java8_RunAllNightly]
> Test framework: Remove custom assumption exceptions handling
>
>
> Key: IGNITE-11356
> URL: https://issues.apache.org/jira/browse/IGNITE-11356
> Project: Ignite
> Issue Type: Task
>Reporter: Ivan Pavlukhin
>Assignee: Ivan Pavlukhin
>Priority: Major
> Labels: MakeTeamcityGreenAgain
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It turns out that custom handling of {{AssumptionViolatedException}} can be
> removed. Currently with custom handling tests with unmet assumptions are
> marked as passed. With default handling failed assumptions on instance level
> mark tests as ignored.
> Note: on class level reporting in case of unmet assumptions does not look
> perfect. But with custom handling a particular test is not included into TC
> report at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
