[jira] [Commented] (IGNITE-11750) Implement locked pages info dump for long-running B+Tree operations
[
https://issues.apache.org/jira/browse/IGNITE-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856559#comment-16856559
]
Dmitriy Govorukhin commented on IGNITE-11750:
-
[~sergey-chugunov] Thanks for the review! Merged to master.
> Implement locked pages info dump for long-running B+Tree operations
> ---
>
> Key: IGNITE-11750
> URL: https://issues.apache.org/jira/browse/IGNITE-11750
> Project: Ignite
> Issue Type: Improvement
>Reporter: Alexey Goncharuk
>Assignee: Dmitriy Govorukhin
>Priority: Major
> Fix For: 2.8
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> I've stumbled upon an incident where a batch of Ignite threads were hanging
> on BPlusTree operations trying to acquire read or write lock on pages. From
> the thread dump it is impossible to check if there is an issue with
> {{OffheapReadWriteLock}} or there is a subtle deadlock in the tree.
> I suggest we implement a timeout for page lock acquire and tracking of locked
> pages. This should be relatively easy to implement in {{PageHandler}} (the
> only thing to consider is performance degradation). If a timeout occurs, we
> should print all the locks currently owned by a thread. This way we should be
> able to determine if there is a deadlock in the {{BPlusTree}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11750) Implement locked pages info dump for long-running B+Tree operations
[
https://issues.apache.org/jira/browse/IGNITE-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854522#comment-16854522
]
Ignite TC Bot commented on IGNITE-11750:
{panel:title=-- Run :: All: Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Platform .NET (Inspections)*{color} [[tests 0 Failure on metric
|https://ci.ignite.apache.org/viewLog.html?buildId=4030145]]
{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4022895buildTypeId=IgniteTests24Java8_RunAll]
> Implement locked pages info dump for long-running B+Tree operations
> ---
>
> Key: IGNITE-11750
> URL: https://issues.apache.org/jira/browse/IGNITE-11750
> Project: Ignite
> Issue Type: Improvement
>Reporter: Alexey Goncharuk
>Assignee: Dmitriy Govorukhin
>Priority: Major
> Fix For: 2.8
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> I've stumbled upon an incident where a batch of Ignite threads were hanging
> on BPlusTree operations trying to acquire read or write lock on pages. From
> the thread dump it is impossible to check if there is an issue with
> {{OffheapReadWriteLock}} or there is a subtle deadlock in the tree.
> I suggest we implement a timeout for page lock acquire and tracking of locked
> pages. This should be relatively easy to implement in {{PageHandler}} (the
> only thing to consider is performance degradation). If a timeout occurs, we
> should print all the locks currently owned by a thread. This way we should be
> able to determine if there is a deadlock in the {{BPlusTree}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11750) Implement locked pages info dump for long-running B+Tree operations
[
https://issues.apache.org/jira/browse/IGNITE-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853100#comment-16853100
]
Sergey Chugunov commented on IGNITE-11750:
--
[~DmitriyGovorukhin],
Change looks good to me, please proceed with merging.
Thank you for contribution!
> Implement locked pages info dump for long-running B+Tree operations
> ---
>
> Key: IGNITE-11750
> URL: https://issues.apache.org/jira/browse/IGNITE-11750
> Project: Ignite
> Issue Type: Improvement
>Reporter: Alexey Goncharuk
>Assignee: Dmitriy Govorukhin
>Priority: Major
> Fix For: 2.8
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> I've stumbled upon an incident where a batch of Ignite threads were hanging
> on BPlusTree operations trying to acquire read or write lock on pages. From
> the thread dump it is impossible to check if there is an issue with
> {{OffheapReadWriteLock}} or there is a subtle deadlock in the tree.
> I suggest we implement a timeout for page lock acquire and tracking of locked
> pages. This should be relatively easy to implement in {{PageHandler}} (the
> only thing to consider is performance degradation). If a timeout occurs, we
> should print all the locks currently owned by a thread. This way we should be
> able to determine if there is a deadlock in the {{BPlusTree}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11750) Implement locked pages info dump for long-running B+Tree operations
[
https://issues.apache.org/jira/browse/IGNITE-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848931#comment-16848931
]
Ignite TC Bot commented on IGNITE-11750:
{panel:title=-- Run :: All: No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=3957295buildTypeId=IgniteTests24Java8_RunAll]
> Implement locked pages info dump for long-running B+Tree operations
> ---
>
> Key: IGNITE-11750
> URL: https://issues.apache.org/jira/browse/IGNITE-11750
> Project: Ignite
> Issue Type: Improvement
>Reporter: Alexey Goncharuk
>Assignee: Dmitriy Govorukhin
>Priority: Major
> Fix For: 2.8
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> I've stumbled upon an incident where a batch of Ignite threads were hanging
> on BPlusTree operations trying to acquire read or write lock on pages. From
> the thread dump it is impossible to check if there is an issue with
> {{OffheapReadWriteLock}} or there is a subtle deadlock in the tree.
> I suggest we implement a timeout for page lock acquire and tracking of locked
> pages. This should be relatively easy to implement in {{PageHandler}} (the
> only thing to consider is performance degradation). If a timeout occurs, we
> should print all the locks currently owned by a thread. This way we should be
> able to determine if there is a deadlock in the {{BPlusTree}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
