[jira] [Commented] (IGNITE-11771) Kubernetes discovery support for non-ready pods
[ https://issues.apache.org/jira/browse/IGNITE-11771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863956#comment-16863956 ] Roman Shtykh commented on IGNITE-11771: --- [~Mmuzaf] Thank you for pointing at it! Sorry I should have checked it on TC as well. Will fix. > Kubernetes discovery support for non-ready pods > --- > > Key: IGNITE-11771 > URL: https://issues.apache.org/jira/browse/IGNITE-11771 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.7 >Reporter: Balazs Peterfi >Assignee: Denis Magda >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > I have a use case where Ignite is running in embedded mode and on start-up > there is a time consuming task to warm-up the cache. During that time > Kubernetes sees the pods as not ready due to the loading, thus the current > implementation doesn't return them as potential members. Eventually they > would become ready and see each-other but by then it would be a split-brain > situation. > The idea is to return IPs not only for "ready" pods but for "not ready" ones > as well in case the discovery client is configured that way. See more details > here: > [https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.13/#endpointsubset-v1-core] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11771) Kubernetes discovery support for non-ready pods
[
https://issues.apache.org/jira/browse/IGNITE-11771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863950#comment-16863950
]
Maxim Muzafarov commented on IGNITE-11771:
--
[~shroman], Folks,
it seems that Check Style Suite [1] began to fail with the exception below due
to the current commit.
Could you please check?
{code:java}
[Step 2/2] [ERROR]
/opt/buildagent/work/69588afcb2ab3382/modules/kubernetes/src/main/java/org/apache/ignite/spi/discovery/tcp/ipfinder/kubernetes/TcpDiscoveryKubernetesIpFinder.java:323:
'VARIABLE_DEF' should be separated from previous statement.
[EmptyLineSeparator]{code}
[1]
[https://ci.ignite.apache.org/viewLog.html?buildId=4117329&buildTypeId=IgniteTests24Java8_CheckCodeStyle]
> Kubernetes discovery support for non-ready pods
> ---
>
> Key: IGNITE-11771
> URL: https://issues.apache.org/jira/browse/IGNITE-11771
> Project: Ignite
> Issue Type: Improvement
>Affects Versions: 2.7
>Reporter: Balazs Peterfi
>Assignee: Denis Magda
>Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I have a use case where Ignite is running in embedded mode and on start-up
> there is a time consuming task to warm-up the cache. During that time
> Kubernetes sees the pods as not ready due to the loading, thus the current
> implementation doesn't return them as potential members. Eventually they
> would become ready and see each-other but by then it would be a split-brain
> situation.
> The idea is to return IPs not only for "ready" pods but for "not ready" ones
> as well in case the discovery client is configured that way. See more details
> here:
> [https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.13/#endpointsubset-v1-core]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11771) Kubernetes discovery support for non-ready pods
[ https://issues.apache.org/jira/browse/IGNITE-11771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863308#comment-16863308 ] Denis Magda commented on IGNITE-11771: -- [~shroman], sorry my bad. Sure, please disregard that suggestion. > Kubernetes discovery support for non-ready pods > --- > > Key: IGNITE-11771 > URL: https://issues.apache.org/jira/browse/IGNITE-11771 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.7 >Reporter: Balazs Peterfi >Assignee: Denis Magda >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > I have a use case where Ignite is running in embedded mode and on start-up > there is a time consuming task to warm-up the cache. During that time > Kubernetes sees the pods as not ready due to the loading, thus the current > implementation doesn't return them as potential members. Eventually they > would become ready and see each-other but by then it would be a split-brain > situation. > The idea is to return IPs not only for "ready" pods but for "not ready" ones > as well in case the discovery client is configured that way. See more details > here: > [https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.13/#endpointsubset-v1-core] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11771) Kubernetes discovery support for non-ready pods
[ https://issues.apache.org/jira/browse/IGNITE-11771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16862704#comment-16862704 ] Roman Shtykh commented on IGNITE-11771: --- [~dmagda] sure. But I am not sure that having it enabled by default helps "to avoid any issues with existing deployments." In the current implementation (what we have in master branch), `notReadyAddresses` are not included, right? If they started being included, existing deployments might be surprised. > Kubernetes discovery support for non-ready pods > --- > > Key: IGNITE-11771 > URL: https://issues.apache.org/jira/browse/IGNITE-11771 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.7 >Reporter: Balazs Peterfi >Assignee: Denis Magda >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > I have a use case where Ignite is running in embedded mode and on start-up > there is a time consuming task to warm-up the cache. During that time > Kubernetes sees the pods as not ready due to the loading, thus the current > implementation doesn't return them as potential members. Eventually they > would become ready and see each-other but by then it would be a split-brain > situation. > The idea is to return IPs not only for "ready" pods but for "not ready" ones > as well in case the discovery client is configured that way. See more details > here: > [https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.13/#endpointsubset-v1-core] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11771) Kubernetes discovery support for non-ready pods
[ https://issues.apache.org/jira/browse/IGNITE-11771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16862464#comment-16862464 ] Denis Magda commented on IGNITE-11771: -- [~shroman], could you please incorporate a minor change? I left a note in Github. Please feel free to merge after that. > Kubernetes discovery support for non-ready pods > --- > > Key: IGNITE-11771 > URL: https://issues.apache.org/jira/browse/IGNITE-11771 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.7 >Reporter: Balazs Peterfi >Assignee: Denis Magda >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > I have a use case where Ignite is running in embedded mode and on start-up > there is a time consuming task to warm-up the cache. During that time > Kubernetes sees the pods as not ready due to the loading, thus the current > implementation doesn't return them as potential members. Eventually they > would become ready and see each-other but by then it would be a split-brain > situation. > The idea is to return IPs not only for "ready" pods but for "not ready" ones > as well in case the discovery client is configured that way. See more details > here: > [https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.13/#endpointsubset-v1-core] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11771) Kubernetes discovery support for non-ready pods
[ https://issues.apache.org/jira/browse/IGNITE-11771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16861814#comment-16861814 ] Roman Shtykh commented on IGNITE-11771: --- [~balazspeterfi] Sorry for taking so long. So you have something as described in [https://github.com/hazelcast/hazelcast-kubernetes/issues/56] ? LGTM. [~dmagda], if no concerns I merge. > Kubernetes discovery support for non-ready pods > --- > > Key: IGNITE-11771 > URL: https://issues.apache.org/jira/browse/IGNITE-11771 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.7 >Reporter: Balazs Peterfi >Assignee: Denis Magda >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > I have a use case where Ignite is running in embedded mode and on start-up > there is a time consuming task to warm-up the cache. During that time > Kubernetes sees the pods as not ready due to the loading, thus the current > implementation doesn't return them as potential members. Eventually they > would become ready and see each-other but by then it would be a split-brain > situation. > The idea is to return IPs not only for "ready" pods but for "not ready" ones > as well in case the discovery client is configured that way. See more details > here: > [https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.13/#endpointsubset-v1-core] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
