[jira] [Commented] (IGNITE-11844) Should to filtered indexes by cache name instead of validate all caches in group
[ https://issues.apache.org/jira/browse/IGNITE-11844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876072#comment-16876072 ] Sergey Chugunov commented on IGNITE-11844: -- [~6uest], I reviewed latest patch, it looks good to me now. Please proceed with merging and thank you for the contribution! > Should to filtered indexes by cache name instead of validate all caches in > group > > > Key: IGNITE-11844 > URL: https://issues.apache.org/jira/browse/IGNITE-11844 > Project: Ignite > Issue Type: Bug >Reporter: Vladislav Pyatkov >Assignee: Andrey Kalinin >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > control.sh utility method validate_indexes checks all indexes of all caches > in group. Just do specify one caches (from generic group) in caches list, > then all indexes from all caches (that group) will be start to validate and > this can consume more time, than checks indexes only specified caches. > Will be correct to validate only indexes of specified caches, for the purpose > need to filtered caches, by list from parameters, in shared group. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11844) Should to filtered indexes by cache name instead of validate all caches in group
[
https://issues.apache.org/jira/browse/IGNITE-11844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874817#comment-16874817
]
Ignite TC Bot commented on IGNITE-11844:
{panel:title=-- Run :: All: No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4054687buildTypeId=IgniteTests24Java8_RunAll]
> Should to filtered indexes by cache name instead of validate all caches in
> group
>
>
> Key: IGNITE-11844
> URL: https://issues.apache.org/jira/browse/IGNITE-11844
> Project: Ignite
> Issue Type: Bug
>Reporter: Vladislav Pyatkov
>Assignee: Andrey Kalinin
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> control.sh utility method validate_indexes checks all indexes of all caches
> in group. Just do specify one caches (from generic group) in caches list,
> then all indexes from all caches (that group) will be start to validate and
> this can consume more time, than checks indexes only specified caches.
> Will be correct to validate only indexes of specified caches, for the purpose
> need to filtered caches, by list from parameters, in shared group.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11844) Should to filtered indexes by cache name instead of validate all caches in group
[
https://issues.apache.org/jira/browse/IGNITE-11844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874755#comment-16874755
]
Ignite TC Bot commented on IGNITE-11844:
{panel:title=-- Run :: All: Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}[Check Code Style]{color} [[tests 0 Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=4213434]]
{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4054687buildTypeId=IgniteTests24Java8_RunAll]
> Should to filtered indexes by cache name instead of validate all caches in
> group
>
>
> Key: IGNITE-11844
> URL: https://issues.apache.org/jira/browse/IGNITE-11844
> Project: Ignite
> Issue Type: Bug
>Reporter: Vladislav Pyatkov
>Assignee: Andrey Kalinin
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> control.sh utility method validate_indexes checks all indexes of all caches
> in group. Just do specify one caches (from generic group) in caches list,
> then all indexes from all caches (that group) will be start to validate and
> this can consume more time, than checks indexes only specified caches.
> Will be correct to validate only indexes of specified caches, for the purpose
> need to filtered caches, by list from parameters, in shared group.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11844) Should to filtered indexes by cache name instead of validate all caches in group
[ https://issues.apache.org/jira/browse/IGNITE-11844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874166#comment-16874166 ] Andrey Kalinin commented on IGNITE-11844: - [~sergey-chugunov], just fix it. Please, check again. > Should to filtered indexes by cache name instead of validate all caches in > group > > > Key: IGNITE-11844 > URL: https://issues.apache.org/jira/browse/IGNITE-11844 > Project: Ignite > Issue Type: Bug >Reporter: Vladislav Pyatkov >Assignee: Andrey Kalinin >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > control.sh utility method validate_indexes checks all indexes of all caches > in group. Just do specify one caches (from generic group) in caches list, > then all indexes from all caches (that group) will be start to validate and > this can consume more time, than checks indexes only specified caches. > Will be correct to validate only indexes of specified caches, for the purpose > need to filtered caches, by list from parameters, in shared group. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11844) Should to filtered indexes by cache name instead of validate all caches in group
[ https://issues.apache.org/jira/browse/IGNITE-11844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873282#comment-16873282 ] Sergey Chugunov commented on IGNITE-11844: -- [~6uest], It is possible that cacheNames collection which you're using for filtering in ValidateIndexesClosure is null (take a look a few lines of code above: there are checks for the collection to be null). So the fix makes it possible for NPE to be thrown. Please fix this and add a test to verify that the code is NPE bulletproof. > Should to filtered indexes by cache name instead of validate all caches in > group > > > Key: IGNITE-11844 > URL: https://issues.apache.org/jira/browse/IGNITE-11844 > Project: Ignite > Issue Type: Bug >Reporter: Vladislav Pyatkov >Assignee: Andrey Kalinin >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > control.sh utility method validate_indexes checks all indexes of all caches > in group. Just do specify one caches (from generic group) in caches list, > then all indexes from all caches (that group) will be start to validate and > this can consume more time, than checks indexes only specified caches. > Will be correct to validate only indexes of specified caches, for the purpose > need to filtered caches, by list from parameters, in shared group. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11844) Should to filtered indexes by cache name instead of validate all caches in group
[ https://issues.apache.org/jira/browse/IGNITE-11844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859791#comment-16859791 ] Vladislav Pyatkov commented on IGNITE-11844: [~6uest] Looks good to me. > Should to filtered indexes by cache name instead of validate all caches in > group > > > Key: IGNITE-11844 > URL: https://issues.apache.org/jira/browse/IGNITE-11844 > Project: Ignite > Issue Type: Bug >Reporter: Vladislav Pyatkov >Assignee: Andrey Kalinin >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > control.sh utility method validate_indexes checks all indexes of all caches > in group. Just do specify one caches (from generic group) in caches list, > then all indexes from all caches (that group) will be start to validate and > this can consume more time, than checks indexes only specified caches. > Will be correct to validate only indexes of specified caches, for the purpose > need to filtered caches, by list from parameters, in shared group. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11844) Should to filtered indexes by cache name instead of validate all caches in group
[ https://issues.apache.org/jira/browse/IGNITE-11844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857434#comment-16857434 ] Andrey Kalinin commented on IGNITE-11844: - [~v.pyatkov]. Please review again. > Should to filtered indexes by cache name instead of validate all caches in > group > > > Key: IGNITE-11844 > URL: https://issues.apache.org/jira/browse/IGNITE-11844 > Project: Ignite > Issue Type: Bug >Reporter: Vladislav Pyatkov >Assignee: Andrey Kalinin >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > control.sh utility method validate_indexes checks all indexes of all caches > in group. Just do specify one caches (from generic group) in caches list, > then all indexes from all caches (that group) will be start to validate and > this can consume more time, than checks indexes only specified caches. > Will be correct to validate only indexes of specified caches, for the purpose > need to filtered caches, by list from parameters, in shared group. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11844) Should to filtered indexes by cache name instead of validate all caches in group
[
https://issues.apache.org/jira/browse/IGNITE-11844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857433#comment-16857433
]
Ignite TC Bot commented on IGNITE-11844:
{panel:title=-- Run :: All: Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Platform .NET (Inspections)*{color} [[tests 0 Failure on metric
|https://ci.ignite.apache.org/viewLog.html?buildId=4054660]]
{color:#d04437}[Check Code Style]{color} [[tests 0 Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=4054686]]
{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4039941buildTypeId=IgniteTests24Java8_RunAll]
> Should to filtered indexes by cache name instead of validate all caches in
> group
>
>
> Key: IGNITE-11844
> URL: https://issues.apache.org/jira/browse/IGNITE-11844
> Project: Ignite
> Issue Type: Bug
>Reporter: Vladislav Pyatkov
>Assignee: Andrey Kalinin
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> control.sh utility method validate_indexes checks all indexes of all caches
> in group. Just do specify one caches (from generic group) in caches list,
> then all indexes from all caches (that group) will be start to validate and
> this can consume more time, than checks indexes only specified caches.
> Will be correct to validate only indexes of specified caches, for the purpose
> need to filtered caches, by list from parameters, in shared group.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11844) Should to filtered indexes by cache name instead of validate all caches in group
[ https://issues.apache.org/jira/browse/IGNITE-11844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856576#comment-16856576 ] Andrey Kalinin commented on IGNITE-11844: - [~v.pyatkov], looks reasonable. Fixed. > Should to filtered indexes by cache name instead of validate all caches in > group > > > Key: IGNITE-11844 > URL: https://issues.apache.org/jira/browse/IGNITE-11844 > Project: Ignite > Issue Type: Bug >Reporter: Vladislav Pyatkov >Assignee: Andrey Kalinin >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > control.sh utility method validate_indexes checks all indexes of all caches > in group. Just do specify one caches (from generic group) in caches list, > then all indexes from all caches (that group) will be start to validate and > this can consume more time, than checks indexes only specified caches. > Will be correct to validate only indexes of specified caches, for the purpose > need to filtered caches, by list from parameters, in shared group. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11844) Should to filtered indexes by cache name instead of validate all caches in group
[
https://issues.apache.org/jira/browse/IGNITE-11844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856566#comment-16856566
]
Vladislav Pyatkov commented on IGNITE-11844:
[~6uest] I look at your commit and have one question:
Why you using {{ThreadLocalRandom}}, when the method
({{testValidateSingleCacheShouldNotTriggerCacheGroupValidation()}}) can be used
from one thread only? Is rely necessary to use random values here? (I think
predefined values will be enough there - for example i instead of
{{rand.nextInt()}}.)
> Should to filtered indexes by cache name instead of validate all caches in
> group
>
>
> Key: IGNITE-11844
> URL: https://issues.apache.org/jira/browse/IGNITE-11844
> Project: Ignite
> Issue Type: Bug
>Reporter: Vladislav Pyatkov
>Assignee: Andrey Kalinin
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> control.sh utility method validate_indexes checks all indexes of all caches
> in group. Just do specify one caches (from generic group) in caches list,
> then all indexes from all caches (that group) will be start to validate and
> this can consume more time, than checks indexes only specified caches.
> Will be correct to validate only indexes of specified caches, for the purpose
> need to filtered caches, by list from parameters, in shared group.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11844) Should to filtered indexes by cache name instead of validate all caches in group
[ https://issues.apache.org/jira/browse/IGNITE-11844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856550#comment-16856550 ] Andrey Kalinin commented on IGNITE-11844: - [~v.pyatkov] please review. > Should to filtered indexes by cache name instead of validate all caches in > group > > > Key: IGNITE-11844 > URL: https://issues.apache.org/jira/browse/IGNITE-11844 > Project: Ignite > Issue Type: Bug >Reporter: Vladislav Pyatkov >Assignee: Andrey Kalinin >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > control.sh utility method validate_indexes checks all indexes of all caches > in group. Just do specify one caches (from generic group) in caches list, > then all indexes from all caches (that group) will be start to validate and > this can consume more time, than checks indexes only specified caches. > Will be correct to validate only indexes of specified caches, for the purpose > need to filtered caches, by list from parameters, in shared group. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11844) Should to filtered indexes by cache name instead of validate all caches in group
[
https://issues.apache.org/jira/browse/IGNITE-11844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856533#comment-16856533
]
Ignite TC Bot commented on IGNITE-11844:
{panel:title=-- Run :: All: Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Platform .NET (Inspections)*{color} [[tests 0 Failure on metric
|https://ci.ignite.apache.org/viewLog.html?buildId=4045983]]
{color:#d04437}MVCC PDS 4{color} [[tests 0 TIMEOUT , Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=4045985]]
{color:#d04437}[Check Code Style]{color} [[tests 0 Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=4045986]]
{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4039941buildTypeId=IgniteTests24Java8_RunAll]
> Should to filtered indexes by cache name instead of validate all caches in
> group
>
>
> Key: IGNITE-11844
> URL: https://issues.apache.org/jira/browse/IGNITE-11844
> Project: Ignite
> Issue Type: Bug
>Reporter: Vladislav Pyatkov
>Assignee: Andrey Kalinin
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> control.sh utility method validate_indexes checks all indexes of all caches
> in group. Just do specify one caches (from generic group) in caches list,
> then all indexes from all caches (that group) will be start to validate and
> this can consume more time, than checks indexes only specified caches.
> Will be correct to validate only indexes of specified caches, for the purpose
> need to filtered caches, by list from parameters, in shared group.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
